mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-11-04 19:28:46 +01:00
## Thinking Path > - Paperclip lets people assign work to AI agents and inspect the result. > - A task can use repositories from more than one project. > - Remote workspace preparation treated every additional project as a read-only source. > - This rejected valid Git repositories before the provider started, even when no source was read-only. > - The task page then hid the preparation reason behind a generic failed-attempt notice. > - This pull request prepares authorized repositories as writable task copies and shows redacted workspace validation errors. > - People can work across both projects and see the reason if folder preparation fails. ## Linked Issues or Issue Description **What happened?** A remote task with a selected Git-backed project and another mentioned Git-backed project failed before provider execution. It reported `remote_workspace_readonly_sources_unsupported`. Neither project had a read-only setting. The task notice showed only that the attempt failed. **Expected behavior** Each attached repository should be writable inside the task workspace. This should preserve source access checks and saved work. A workspace validation failure should explain its cause on the task page. **Steps to reproduce** 1. Configure remote workspace storage and a native sandbox environment. 2. Select a Git-backed project for a task. 3. Mention another authorized Git-backed project in the task. 4. Start the task. Preparation rejects the additional source before it starts the provider. **Paperclip version or commit** Reproduced against `dc9f387edc`, before this change. **Deployment mode** Managed remote workspace storage. Local regression checks use disposable PostgreSQL and independent filesystem processes. Related merged work: Refs #18403 and #18504. Those changes established remote storage and metadata-only references. They still reject configured cross-project repositories. No duplicate writable-repository repair was found. Refs #18774 for the test-only retention-fixture repair reused to unblock CI. ## What Changed - Add every configured Git repository of an authorized referenced project to `.paperclip-repositories/` as an editable task copy. - Retain saved paths, refs, pins and files. Recheck retained project access and source trust. Keep explicit read-only, local-source import and remote feature gates. - Keep committed snapshot repository coverage separate from later requests. Honor configured default refs, resolve remote branch names, and publish secondary checkouts only after checkout succeeds. Share configured-ref resolution between root and attached-repository scripts. - Include redacted workspace validation messages in the task interruption projection and existing failure notice. Preserve Retry permissions and render messages as plain text. Explain retained-folder access and trust denials while preserving the dedicated low-trust project-access path. - Add source, authorization, redaction, UI and save/restore regressions. Update the implementation contract and workspace maps. - Reuse the reviewed test-only repair from #18774. Batch the shared-workspace history fixture, verify its complete privacy-source map, and drain owned test bodies before cleanup. Production retention behavior is unchanged. ## Verification - Red before repair: four source-resolution cases failed with the reported read-only error. The task-error projection test also failed because it omitted the cause. - Green: 49 source and transport tests, 16 task projection and redaction tests, and 10 UI tests. The assembled preparation check passes. All 48 remote workspace lifecycle tests pass. The full preparation suite passed all 126 assertions but its cleanup hook exceeded 30 seconds. The unchanged base reproduces the same cleanup timeout with all 126 assertions passing. The focused preparation check finishes cleanly. - The real PostgreSQL/Git lifecycle checks cover both first-turn and later project attachments. They verify the configured release branch, saved edits, replacement allocations, unchanged source folders, committed archive contents, and released writers. - Review regressions were red before repair: the default ref became null, later attachment failed during restore, non-default remote branch checkout failed, and invalid secondary refs left partial checkouts. They now pass. - The local browser shows the workspace validation explanation and Retry action. The fixture uses a saved failed run; this proves the error display, not a successful live sandbox run. - `pnpm -r typecheck` and `pnpm build` pass. Map, module-boundary and token checks pass. - A local two-turn acceptance probe repeated at `17ed67eaa7` used real Codex CLI 0.165.0, `gpt-6-astra`, and `xhigh` effort. Codex wrote files in both task repositories. The services saved them, removed the first allocation and its Git sources, restored another allocation, and Codex read the saved files and wrote a follow-up in both folders. This uses the real source resolver and persistence services with a local command-runner stand-in for sandbox transport. It does not qualify Daytona, managed subscription forwarding, or the original task. The first probe waited for stdin; closing the test harness pipe fixed that setup error before provider work. - `pnpm test:run` passed the first chat shard, then failed one chat response concurrency assertion in the second shard. That case passes in isolation on this head. The same isolated chat case passes on the unchanged base. Both corresponding unchanged-base chat shards also pass (351 and 324 tests). The cause of the earlier wider-suite chat failure is not established. The preparation cleanup timeout and chat failure remain part of this record. - CI at `17ed67eaa7`: all other verification jobs passed. Browser shard 6 initially reported a request callback from the preceding test after teardown; its single unchanged-code retry passed. Server shard 10 timed out the 2,100-row retention confirmation fixture at 15 seconds on both attempts. That exact case passes locally, but the repeated CI failure required a repair. Its setup repeatedly rebuilt a shared-workspace privacy map. The logs and failures remain part of this record. - Reused the test-only repair from #18774 without changing its source file. At `ab774e9418`, all 54 retention tests and all 25 ordinary production privacy tests pass locally (79 total). Full CI [41650626903](https://github.com/paperclipai/paperclip/actions/runs/41650626903) passed on that commit, and its exact-head Greptile review was 5/5. The fixture preserves its 2,100 rows, query-bound assertions, privacy-source map, and completed-history test deadlines. - The additional review identified retained-source access/trust denials that still bypassed the workspace explanation. Real-resolver regressions reproduced both plain-403 failures before the correction. Both now yield a safe workspace validation explanation, while the dedicated low-trust denial and saved workspace remain unchanged. The optional duplicate ref-resolution block is also consolidated. - Final review corrections: 65 source, transport and error-projection tests passed, followed by all 48 lifecycle cases against an owned disposable PostgreSQL database (113 total). The initial combined command skipped the explicitly gated lifecycle suite; the subsequent dedicated invocation enabled and passed all 48. Full workspace typecheck and build pass. The first standalone lifecycle launcher lacked the repository TypeScript loader; rerunning with that loader resolved its import setup error. At previous head `7be02ea09c4ac76df560e8b517050cdf398f33f0`, full CI [41654422329, attempt 2](https://github.com/paperclipai/paperclip/actions/runs/41654422329/attempts/2) passed, Greptile is 5/5 on that exact head, and all review threads are resolved. The first attempt timed out the unchanged voice-session report/history case at 15 seconds; 3,027 cases in its shard passed. That exact case passed locally, then its single unchanged-code shard retry passed. The wider-suite timeout cause remains unproven. The completed Paperclip advisory check is neutral; its earlier findings are corrected. No staging deployment or original-task recovery is claimed. - Master advanced while checks ran, producing conflicts in two adjacent test additions. Merged `27d35314be` into this branch as `d5c8d552939c86056abf8fe10833881b2ade41a4`, preserving both workspace-error tests and the audited Stop/receipt tests. Kept workspace maps to minimal corrections under the updated map rule. All 82 source, transport and interruption cases, all 48 real-database save/restore lifecycle cases, full typecheck, build, and map checks pass locally on the combined code. Current-head [CI 41660719214](https://github.com/paperclipai/paperclip/actions/runs/41660719214) and Greptile are pending; the earlier verified head has not been merged. ## Risks - Additional remote project repositories are now editable task copies. Shared source folders and upstream push permissions do not change. - Snapshot coverage uses existing workspace metadata. Older workspaces capture their previous inventory at reservation; successful save publication advances coverage and snapshot identity in one transaction. No SQL migration is needed. - A retained copy can contain files from a project that is no longer mentioned. Preparation rechecks that project's current access and trust policy before reuse. - Explicit read-only descriptors still fail. Source-less projects remain metadata-only. Local folders still require import. No migration or provider-pack update is needed. - Error display reads only workspace validation errors. The existing run-secret registry and username censor run before display truncation. A redaction failure omits the explanation. - The retained fixture repair pauses its row trigger only within the isolated seed transaction, rebuilds the exact source map, and restores the trigger before commit. A rollback regression and 25 ordinary privacy cases pass. Its paged-case test budget honors the existing bounded inner waits; production deadlines are unchanged. ## Model Used OpenAI Codex, GPT-6 family, with reasoning, tool use and code execution. The exact serving model ID and context-window size are not exposed by this session. The test-only fixture changes are reused from #18774, whose model record identifies OpenAI GPT-6.1 Sol. The optional live acceptance probe uses `gpt-6-astra` with `xhigh` effort through Codex CLI 0.165.0. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either (a) linked existing issues with `Fixes: #` / `Closes #` / `Refs #` OR (b) described the issue in-PR following the relevant issue template - [x] I have not referenced internal/instance-local Paperclip issues or links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip` URLs) - [x] My branch name describes the change (e.g. `docs/...`, `fix/...`) and contains no internal Paperclip ticket id or instance-derived details - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [ ] All Paperclip CI gates are green - [ ] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I will address all Greptile and reviewer comments before requesting merge --------- Co-authored-by: Paperclip <noreply@paperclip.ing>
375 lines
22 KiB
Markdown
375 lines
22 KiB
Markdown
# Execution workspaces, services, and files — agent access
|
|
|
|
Product map: [Execution workspaces, services, and files](../feature-map/workspaces.md).
|
|
|
|
Feature ID: `workspaces`.
|
|
|
|
Lost-source reconstruction adds the board-only
|
|
`POST /api/issues/{id}/recovery-actions/reconstruct-workspace` action. It requires
|
|
`runtime:manage` and ordinary task visibility. Agents cannot authorize it. The
|
|
result is a durable fresh-session admission request, subject to current execution
|
|
gates. It grants no additional tool access, budget, work window or permission to
|
|
repeat completed actions. Attachments must belong to the same task and company.
|
|
The original failed run and lost-export evidence remain unchanged.
|
|
Later native run-only cancellations can coexist only with confirmed lease stops,
|
|
board file-only repair and an external-action outcome of `not_performed`.
|
|
Their immutable evidence is checked again at dispatch. Historical cancellation
|
|
retention runs internally and grants no new agent operation or authority.
|
|
|
|
Review date: 2026-10-12. Source commit: `58e16dbddfc9c8d0cf60867f9d9847f0feda055b`.
|
|
Native REST transport reconciled in this change; see the
|
|
[shared transport contract](README.md#native-rest-transport).
|
|
|
|
This is a source-reviewed baseline of representative operations and known gaps.
|
|
Each capability needs operation-level review before its entire scope can be
|
|
qualified. No live agent execution is claimed. Follow the [map contract](../README.md)
|
|
for format, permission checks, evidence and maintenance.
|
|
|
|
## `binding`
|
|
|
|
Capability ID: `workspaces/binding`.
|
|
|
|
Review: `baseline`.
|
|
|
|
API: `present` — representative operation IDs:
|
|
|
|
- `GET /api/issues/{id}/heartbeat-context`.
|
|
- `GET /api/execution-workspaces/{id}`.
|
|
- `GET /api/issues/{id}/workspace` inspects the durable task binding.
|
|
- `PUT /api/issues/{id}/workspace` requests the next binding.
|
|
- `GET /api/companies/{companyId}/execution-workspaces?summary=true&selectableForTask=true`
|
|
lists authorized task-selectable workspaces.
|
|
|
|
Agent access: `available` — Native get_task_context / REST / CLI / MCP workspace read.
|
|
|
|
The task-bound native tools `get_workspace`, `list_workspaces`, and
|
|
`select_workspace` use the ordinary authenticated APIs. Legacy agents can call
|
|
those APIs with their admitted run token. These paths do not require a project.
|
|
|
|
Policy: Company/project/workspace visibility and runtime authority; active run, trust
|
|
preset and task ownership where required.
|
|
|
|
Ordinary input may reuse the exact currently bound private task directory after
|
|
an explicitly fresh retry. Preparation rechecks company, source task, current
|
|
binding and canonical path; missing directories, symlinks and foreign roots are
|
|
rejected. This preserves files without granting new access or replaying the
|
|
previous turn. An explicitly fresh retry still creates a clean sibling.
|
|
|
|
Task workspace writes require `issue:mutate`, an active owned task/run for agents,
|
|
and current source visibility. Shared physical roots also require source-project
|
|
workspace write authority. Accepting a new pending choice advances its binding
|
|
revision; superseded retries fail while current-choice retries remain idempotent.
|
|
Binding revisions and request keys fence retries;
|
|
selection applies at the next normal admission without interrupting a live run.
|
|
|
|
The managed `remoteWorkspaceStorageEnabled` setting defaults on for Cloud and
|
|
self-hosted instances. New native Paperclip Runner sandbox workspaces with
|
|
supported fresh sources reserve company/task-bound remote authority through
|
|
existing admission only when durable Postgres, S3, and a stable key are configured.
|
|
Existing host workspaces and configured local folders stay on the legacy path
|
|
until an explicit import. Stored `false` disables new enrollment unless managed
|
|
configuration overrides it. Enrolled workspaces keep remote authority when new
|
|
enrollment is disabled, and missing persistence prerequisites fail admission
|
|
without a controller checkout fallback. Current authorization and responsible-user
|
|
checks still apply. Authorized referenced Git repositories use writable task
|
|
copies without changing shared source folders or upstream push permissions.
|
|
Explicitly read-only sources and explicitly concurrent shared writers are rejected.
|
|
Managed mutable same-project repositories are supported.
|
|
Portable capture streams validated working files while staging self-contained
|
|
Git metadata. The smaller temporary-space requirement grants no new agent access
|
|
or execution authority. Changed sources still fail before a save receipt.
|
|
Daytona can stream an already captured archive when its guarded download copy
|
|
cannot fit. The sandbox-user read rechecks confinement and refuses symlinks at
|
|
open; it does not grant the privileged download API access to a mutable source.
|
|
Snapshot publication and the single-writer fence keep their existing authority.
|
|
An inherited isolated workspace or operator branch can be reserved through the
|
|
task's current persisted binding. The original source task remains provenance.
|
|
Reservation checks task/run, binding, trust, and retained source visibility before
|
|
claiming the single writer; an unbound task cannot claim that workspace.
|
|
A live writer conflict at atomic reservation uses the existing workspace wait,
|
|
including inherited isolated workspaces and operator branches. The retry retains
|
|
the binding and current admission gates; Stop cancels it. Stale or stopped
|
|
writers with unfinished saves remain fenced. The wait retains the admitted
|
|
assignment role; reassignment during preparation cancels the old assignee's retry.
|
|
The
|
|
[preparation tests](../../server/src/services/heartbeat/workspace-preparation.test.ts)
|
|
and [heartbeat tests](../../server/src/__tests__/heartbeat-remote-workspace-busy.test.ts)
|
|
cover reservation and persisted waits with PostgreSQL; live sandbox
|
|
provider acceptance remains separate.
|
|
The [reservation tests](../../server/src/services/remote-workspace-reservation.test.ts)
|
|
exercise that service boundary with real PostgreSQL, including competing children,
|
|
private sources, foreign companies, and closed records. This is automated evidence,
|
|
not live agent qualification.
|
|
Importing an existing local task folder is an operator source-checkout command,
|
|
not an agent API or tool: see the
|
|
[dry-run/apply runbook](../../doc/DEVELOPING.md#experimental-native-remote-workspace-storage).
|
|
It requires deployment storage/key access and blocks unfinished writers/recovery.
|
|
Source: [remote source admission](../../server/src/services/heartbeat/remote-workspace-source.ts)
|
|
and [migration](../../server/src/services/remote-workspace-migration.ts).
|
|
Evidence: `source-only` for these additions; live agent qualification is separate.
|
|
|
|
Admission checks current task/run authority and the persisted selected configuration.
|
|
It does not inventory physical aliases or authorize historical sources/readers.
|
|
Explicit workspace-record selection and full workspace metadata disclosure retain
|
|
app-record privacy. Existing isolated remote-source receipts remain restorable;
|
|
new preparation does not create a remote fallback due to historical file ownership.
|
|
Historical `workspace_source_restricted` failures retain existing recovery support.
|
|
An authorized board recovery through `POST /api/issues/{id}/recovery-actions/resolve`
|
|
can schedule a server-owned `recovery` selection for the latest restricted-source
|
|
failure only when its saved evidence proves provider work never started. The
|
|
selection requires task mutation and configured-source access and applies at normal
|
|
admission. It keeps task environment settings and never reads or deletes the denied
|
|
checkout. Pause, budget, approval, interaction, dependency, and ownership gates
|
|
remain effective. Repeated resolution of the same action does not enqueue another
|
|
run. Agents cannot mint recovery provenance through the workspace selection API;
|
|
they can observe the existing recovery action and request board recovery.
|
|
Local paths, unsupported transports and credential-bearing URLs are not fallback
|
|
sources. Company/task/remote bindings, real paths, Git storage and the exact origin
|
|
are revalidated for reuse, cleanup and reopening. A failed save removes only the
|
|
owned task worktree. The [isolated-source service](../../server/src/services/isolated-remote-workspace-source.ts)
|
|
and its local regression tests establish source and lifecycle boundaries; live
|
|
agent/provider qualification remains separate.
|
|
Reconstructable Git expiration adds no agent endpoint or permission. It records
|
|
company/workspace/repository identity and an exact commit before removing owned
|
|
cache files. Existing task/workspace reopening retains current company, source,
|
|
and trust checks. Missing upstream access returns a retryable error; it does not
|
|
choose a newer commit or grant access to another company's source. Shared project
|
|
bases and unresolved recovery remain protected. Local lifecycle evidence is in
|
|
[expiration tests](../../server/src/__tests__/git-workspace-expiration.test.ts).
|
|
|
|
Only directly selected configuration policies participate in current execution trust.
|
|
Physical aliases and historical source projects do not contribute filesystem policy.
|
|
The
|
|
authoritative sandbox or SSH selection suppresses configured and built-in
|
|
controller worktree and runtime provisioning regardless of task trust, app configuration
|
|
write grants or board sponsorship. Genuine isolated worktrees still permit
|
|
authorized read-only source copying. Configuration write permission does not authorize
|
|
controller execution. Explicit, channel, inherited, foreign or nondefault isolated
|
|
source choices remain copy-only for controller provisioning even on local runs.
|
|
Their deny-only workspace marker survives metadata and binding changes; a board
|
|
reopen does not turn it into approval. Implicit trusted local defaults and explicit
|
|
SSH remote provisioning retain their existing placement; no new sandbox provision transport
|
|
is claimed. The implicit default follows task creation: configured policy pointer,
|
|
then primary source, creation time and ID. A missing or foreign configured source
|
|
does not authorize controller hooks. This precedence neither changes existing
|
|
creation validation nor rotates bindings or clears retained copy-only markers.
|
|
Closed-worktree reopening checks current task, agent, organizational and source policies without assuming a future driver. Effective low-trust reopens suppress configured and built-in host scripts. Returned checkpoints must have directory parents for every nested entry before merging, including unchanged entries; invalid output leaves retained host files intact and keeps recovery evidence.
|
|
|
|
Skipping the host scan for a fully unchanged returned snapshot grants no new
|
|
access. The merge still holds its canonical writer lock and runs both authority
|
|
and publication hooks. Denials still propagate, and checkpoint/archive validation
|
|
is unchanged. [Regression coverage](../../packages/adapter-utils/src/workspace-restore-unchanged.test.ts)
|
|
is source-level evidence only.
|
|
Child creation by an admitted agent checks an explicit prospective-task context before the child is saved. The creator run must have an authoritative saved policy and a verified company/agent/parent lineage. Current parent, prospective child and selected source configuration policies must fit that boundary. This creation path does not relax exact task/run checks for existing-task writes. The [child trust regression](../../server/src/__tests__/task-workspace-child-trust.test.ts) is automated source-level evidence, not live agent qualification.
|
|
Source review for these additions: PR #15749 and
|
|
[task workspace routes](../../server/src/routes/task-workspaces.ts),
|
|
[native authority](../../server/src/services/native-runtime/paperclip-runner-tool-authority.ts),
|
|
and [semantic transport](../../server/src/services/task-workspace-tools.ts).
|
|
|
|
Evidence: `source-only` —
|
|
[implementation](../../server/src/routes/workspace-runtime-service-authz.ts#L76) at the
|
|
reviewed commit above.
|
|
|
|
Verification: `not-run` — exercise a listed permitted operation with actual agent
|
|
credentials/run context; inspect its result and applicable persistence/attribution.
|
|
Assert the relevant denied actor, owner, company or mode from Policy. Review the
|
|
remaining operations before qualifying the whole capability.
|
|
|
|
Gaps: Run/task context identifies its actual realized workspace; record existence is not
|
|
a running service.
|
|
|
|
## `provisioning`
|
|
|
|
Capability ID: `workspaces/provisioning`.
|
|
|
|
Source preparation keeps its dedicated lock connection active during work on
|
|
other connections. It preserves company/source exclusion and existing admission
|
|
authority; it adds no agent API or permission. The
|
|
[source-lock regression](../../server/src/services/isolated-remote-workspace-source-lock.test.ts)
|
|
covers PostgreSQL idle timeout, competing preparation, ordinary pool availability,
|
|
and failure cleanup. Deployed agent recovery requires separate live evidence.
|
|
|
|
Review: `baseline`.
|
|
|
|
API: `present` — representative operation IDs:
|
|
|
|
- `GET /api/execution-workspaces/{id}`.
|
|
- `GET /api/execution-workspaces/{id}/workspace-operations`.
|
|
- `POST /api/issues/{id}/workspace/repositories` requests repository preparation.
|
|
|
|
Agent access: `partial` — REST / native call_api reads; task/project assignment triggers
|
|
server provisioning.
|
|
|
|
Native `prepare_repository` and admitted legacy REST callers can request a
|
|
catalog repository or validated repository URL for their current task.
|
|
Preparation occurs at normal admission; the agent cannot supply a host path or
|
|
controller identity. Current selected-configuration permissions, responsible-user authority, trust
|
|
restrictions, immutable receipts, and concrete binding/path integrity are checked
|
|
before acquisition and publication. Low-trust callers cannot trigger a
|
|
new controller-side Git acquisition. Evidence remains source-only here; focused
|
|
[repository tests](../../server/src/__tests__/task-workspace-repositories-trust.test.ts)
|
|
are separate from live agent qualification.
|
|
|
|
An admitted native standard task can read a same-agent completion continuation
|
|
for its own pending repository in its current workspace. An explicit yield may
|
|
use that saved continuation; explicit completion remains completion. Existing
|
|
status decisions and wake admission retain Stop and authorization gates. The
|
|
[workspace API regression](../../server/src/__tests__/task-workspace-api.test.ts)
|
|
and [driver regression](../../packages/paperclip-runner/src/drivers/completion-continuation.test.ts)
|
|
cover this contract; live qualification remains separate.
|
|
|
|
Policy: Company/project/workspace visibility and runtime authority; active run, trust
|
|
preset and task ownership where required.
|
|
|
|
Evidence: `source-only` —
|
|
[implementation](../../server/src/routes/workspace-runtime-service-authz.ts#L76) at the
|
|
reviewed commit above.
|
|
|
|
Verification: `not-run` — exercise a listed permitted operation with actual agent
|
|
credentials/run context; inspect its result and applicable persistence/attribution.
|
|
Assert the relevant denied actor, owner, company or mode from Policy. Review the
|
|
remaining operations before qualifying the whole capability.
|
|
|
|
Gaps: Observing readiness exists. Creating host commands or arbitrary provision targets
|
|
is a separate protected operation.
|
|
|
|
## `services`
|
|
|
|
Capability ID: `workspaces/services`.
|
|
|
|
Review: `baseline`.
|
|
|
|
API: `present` — representative operation IDs:
|
|
|
|
- `POST /api/execution-workspaces/{id}/runtime-services/{action}`.
|
|
|
|
Agent access: `available` — Authorized agent REST / native `call_api` / CLI runtime
|
|
service controls and existing stdio MCP controls.
|
|
|
|
Policy: Company/project/workspace visibility and runtime authority; active run, trust
|
|
preset and task ownership where required.
|
|
|
|
Evidence: `source-only` —
|
|
[implementation](../../server/src/routes/workspace-runtime-service-authz.ts#L76) at the
|
|
reviewed commit above.
|
|
|
|
Verification: `not-run` — exercise a listed permitted operation with actual agent
|
|
credentials/run context; inspect its result and applicable persistence/attribution.
|
|
Assert the relevant denied actor, owner, company or mode from Policy. Review the
|
|
remaining operations before qualifying the whole capability.
|
|
|
|
Gaps: No dedicated production control_workspace_service binding. Generic native
|
|
calls retain runtime trust and workspace/task scope checks. Optional MCP availability
|
|
must be recorded.
|
|
|
|
## `files-git`
|
|
|
|
Capability ID: `workspaces/files-git`.
|
|
|
|
Review: `baseline`.
|
|
|
|
API: `present` — representative operation IDs:
|
|
|
|
- `GET /api/issues/{issueId}/file-resources/content`.
|
|
- `GET /api/issues/{issueId}/file-resources/list`.
|
|
|
|
Agent access: `partial` — Authorized workspace filesystem tools; Dot workspace bridge
|
|
when enabled; board file-resource HTTP UI. Native standard-mode `download_artifact`
|
|
installs an authorized saved asset (up to 10 MiB) into the admitted workspace,
|
|
requiring exact saved size/hash. Linux local and lease-owned remote command
|
|
runners are supported; plugin task providers without an installer and Dot/Muse/Grok
|
|
profiles do not expose it. The tool follows API rollout policy, current task/run,
|
|
issue mutation and asset-content ACLs, including responsible-user capture ownership.
|
|
Publication is create-only after staging/hash checks; conflicting files and symlink
|
|
paths fail. Retry the identical identity after an unknown outcome. Audit records
|
|
contain identity/outcome only; contents remain untrusted and screening still applies.
|
|
The [authority regression](../../server/src/services/native-runtime/artifact-transfer.integration.test.ts)
|
|
and [filesystem faults](../../server/src/services/native-runtime/artifact-transfer.test.ts)
|
|
use disposable data and real files; provider transport qualification is separate.
|
|
|
|
Policy: Company/project/workspace visibility and runtime authority; active run, trust
|
|
preset and task ownership where required.
|
|
|
|
Evidence: `source-only` —
|
|
[implementation](../../server/src/routes/workspace-runtime-service-authz.ts#L76) at the
|
|
reviewed commit above.
|
|
|
|
Verification: `not-run` — exercise a listed permitted operation with actual agent
|
|
credentials/run context; inspect its result and applicable persistence/attribution.
|
|
Assert the relevant denied actor, owner, company or mode from Policy. Review the
|
|
remaining operations before qualifying the whole capability.
|
|
|
|
Gaps: Files panel HTTP requires board. Agents can use their admitted workspace file
|
|
tools; remote/Dot scope and Git command availability differ.
|
|
|
|
Task-bound file reads authorize the current task, company, and concrete binding;
|
|
selected project roots require selected configuration access. Historical task,
|
|
reader, physical-root, and directory acquisition classifications have no effect.
|
|
Root containment and symlink escape checks remain, and attachments, task records,
|
|
workspace metadata, and operation logs retain their app-data privacy.
|
|
|
|
For enrolled remote workspaces the same board file-resource endpoints read the
|
|
authorized live allocation or a verified committed saved version. Returned
|
|
`source.kind` is `live` or `saved`, with `savedAt` for a saved copy. An unavailable
|
|
clean allocation does not prevent reads of its current committed save once
|
|
writer authority is clear; saved reads validate the exact company, workspace,
|
|
and snapshot even while a remote location remains recorded. Cleanup may clear
|
|
only that location during a saved read; logical-authority changes and foreign
|
|
or reintroduced locations still reject it. Live reads retain their full fence. An unavailable
|
|
dirty allocation cannot silently fall back to stale saved bytes. Remote paths
|
|
never become controller filesystem authority. Confined path/symlink checks,
|
|
bounded search/preview, download streaming, and cancellation remain enforced by
|
|
[remote file access](../../server/src/services/remote-workspace-files.ts).
|
|
Evidence: `source-only` here; regression suites are not a live agent read proof.
|
|
Verification: `not-run` — exercise allowed live/saved reads and deny another
|
|
company, changed binding, traversal, and unsaved-allocation fallback.
|
|
|
|
## `closure`
|
|
|
|
Capability ID: `workspaces/closure`.
|
|
|
|
Review: `baseline`.
|
|
|
|
API: `present` — representative operation IDs:
|
|
|
|
- `PATCH /api/execution-workspaces/{id}`.
|
|
- `GET /api/execution-workspaces/{id}/close-readiness`.
|
|
- `POST /api/execution-workspaces/{id}/reconcile-branch`.
|
|
|
|
Agent access: `partial` — REST / native fallback for permitted update; CLI workspace;
|
|
reconcile-branch requires board.
|
|
|
|
Policy: Company/project/workspace visibility and runtime authority; active run, trust
|
|
preset and task ownership where required.
|
|
Workspace metadata reads do not perform storage inspection or certify delivery.
|
|
The explicit close-readiness API and destructive cleanup retain live safety checks.
|
|
Automatic GitHub delivery checks reuse explicit source-project GitHub consent,
|
|
rechecking the stored repository, selected grant, project access and trust on each
|
|
proof. Missing or revoked consent never falls back to another identity. The resolved destination and
|
|
provider recovery hint cannot be supplied as an authorization override through
|
|
workspace metadata. Ambiguous or inaccessible proof retains storage.
|
|
|
|
Evidence: `source-only` —
|
|
[implementation](../../server/src/routes/workspace-runtime-service-authz.ts#L76) at the
|
|
reviewed commit above.
|
|
|
|
Verification: `not-run` — exercise a listed permitted operation with actual agent
|
|
credentials/run context; inspect its result and applicable persistence/attribution.
|
|
Assert the relevant denied actor, owner, company or mode from Policy. Review the
|
|
remaining operations before qualifying the whole capability.
|
|
|
|
Gaps: Closure/readiness exists; not every workspace can be reopened, and branch
|
|
reconciliation has a board boundary.
|
|
|
|
Remote closure additionally requires a clean committed snapshot and no active
|
|
writer. It releases confirmed remote compute while retaining the saved authority;
|
|
reopen restores from that saved version when the allocation is gone. Custom
|
|
cleanup/teardown commands block remote close. Manual runtime commands, jobs,
|
|
repairs, and services reject remote workspaces before local filesystem access.
|
|
Agent tasks remain the supported execution path. No new agent authority is granted.
|
|
Source: [remote lifecycle](../../server/src/services/remote-workspace-lifecycle.ts)
|
|
and [close readiness](../../server/src/services/execution-workspaces.ts).
|
|
Evidence: `source-only` for the remote extension. Verification: `not-run` —
|
|
reject dirty/unfinished/custom-command close, confirm clean release retains the
|
|
snapshot, then reopen under current task/company authorization.
|