Files
PaperClipAI/ui/src/components/SidebarRecentTasks.tsx
T
Nicky LeachandPaperclip f05b90508a refactor(core): remove retired compatibility paths (#22055)
## Thinking Path

> - Paperclip is the open source app people use to manage AI agents for
work.
> - Core manages chat authorization, AI connection defaults, navigation,
and the plugin host.
> - Core still writes old default rows and checks an Agent Chat flag
that always reads true.
> - It also carries a desktop rail that cannot open and private aliases
with canonical equivalents.
> - This pull request removes those paths and moves their tests onto the
paths Core uses.
> - The result is fewer Core database operations and less code to
maintain.

## Linked Issues or Issue Description

**What existing behavior does this improve?**

Core AI default writes, Agent Chat execution and delivery, private
plugin host and Runner setup, and board navigation.

**Subsystem affected**

Cross-cutting. Core server, board UI, private Runner helpers, and a
repository guard script.

**Current behavior**

The server writes provider-scoped and per-method AI defaults, then reads
only the provider-scoped rows. It reads settings to decide whether to
block Agent Chat, although every settings view enables it. The desktop
sidebar renders expanded while still tracking requests to open and close
a retired icon rail. The agent client retries conflicts that the server
already resolves when there is exactly one active match.

**Proposed behavior**

Write provider-scoped defaults directly. Use the existing Agent Chat
authorization and retry checks without the redundant settings reads.
Render the current sidebar directly and let the API report true agent
reference conflicts.

**Reason and benefit**

A personal non-custom connection save or explicit default selection
sends one fewer SQL statement. It also avoids the provider-default write
that the legacy trigger performed when the old statement inserted or
updated a row. A successful task-to-chat send or receipt replay avoids
two transaction settings SELECTs when the singleton row already exists.
Conversation comment, wake release, and retry paths also avoid a
transaction settings read when they previously entered the gate. Savings
in other settings paths depend on cache hits. Core-to-plugin RPC and
plugin-to-Launcher HTTP traffic stay the same.

**Breaking changes**

The public plugin SDK, host navigation, and organization-switcher fields
retain their existing interfaces and behavior. The settings API still
accepts and reports the Agent Chat compatibility key. This change needs
no schema migration or rollout ordering.

**Additional context**

Refs #10610 for prior reporting on the retired sidebar rail. Refs #21756
for adjacent Coordinator plugin slots, which remain a separate change.

## What Changed

- Stop writing per-method AI defaults. Preserve the provider-scope
upsert and first-account behavior. Keep the existing tables and
migration trigger.
- Remove Agent Chat checks that read a constant true value. Keep
conversation ownership, task scope, session, and request-retry checks.
- Remove unused lock-owner fields and private plugin lifecycle, secret
extraction, Gmail connector, PRP setup, heartbeat resolver, and ACPX
aliases.
- Use a single API request for agent references. Remove retired sidebar
rail state, hooks, and branches across the active and production
snapshot layouts. Preserve desktop resizing, mobile drawer controls,
contextual navigation, and public plugin slot inputs.
- Remove unused FeedCard and AgentDetail inputs and the test-only Git
push matcher alias.
- Keep the cleanup that erases historical plaintext chat retries from
browser storage.

Production source in the touched files is 106,800 → 105,633 nonblank
lines, down 1,167. The production Git diff adds 251 physical lines and
removes 1,480, down 1,229. Those figures exclude tests, fixtures, docs,
and Storybook. The entire Git diff adds 482 physical lines and removes
2,325, down 1,843.

## Verification

- Merged master at `b56f240f45` into the PR branch as `f73fea4009`. The
five sidebar files retain the expanded navigation cleanup and master’s
explicit session-replay masking contract. The merge also preserves
master’s account-repair recovery guard and GitHub star-prompt behavior.
- Focused UI Vitest run passed 361 tests across 11 files. This covers
analytics privacy and replay masking, sidebar and layout, GitHub star
prompt, and agent detail.
- Focused server Vitest run passed 45 tests across three files. This
covers restored configuration handling, conversation recovery, and Agent
Chat authority and receipt replay.
- `pnpm --filter @paperclipai/ui typecheck`, the Git push guard and its
14 tests, and `git diff --check origin/master...HEAD` passed.
- `pnpm verify --base origin/master` classified the Git-push guard as a
global CI input and returned exit 2. GitHub CI supplied the broader
coverage.
- GitHub CI and Runner image checks passed on `f73fea4009`. Both
required checks, `ci / verify` and `ci / e2e`, passed. [CI
workflow](https://github.com/paperclipai/paperclip/actions/runs/44181261752)
· [Runner image
workflow](https://github.com/paperclipai/paperclip/actions/runs/44181261413)
- Standard Greptile reported 5/5 with no actionable findings or open
review threads. [Greptile
review](https://github.com/paperclipai/paperclip/pull/22055#issuecomment-6959078925)
- The optional Superagent Security Scan finished neutral with an
inconclusive workflow result and zero annotations. The final rollup had
61 successes, five skips, and one neutral, with no failed or pending
checks. [PR
checks](https://github.com/paperclipai/paperclip/pull/22055/checks)

## Risks

Agent Chat authorization and retry are sensitive to small query changes.
The final diff keeps the conversation agent field and all existing
authorization and idempotency checks. The tests cover revoked defaults,
legacy migration reads, bound-listener authority, and mobile and desktop
navigation. Installations that still run software old enough to read the
per-method AI table will no longer see new defaults in that table.
Current Core reads the provider-scoped table.

## Model Used

OpenAI Codex, GPT-6.1 Sol (`gpt-6.1-sol`), with source inspection and
shell-based tests.

## Checklist

- [x] I have included a thinking path that traces from project context
to this change
- [x] I have specified the model used (with version and capability
details)
- [x] I have checked ROADMAP.md and confirmed this PR does not duplicate
planned core work
- [x] I have searched GitHub for duplicate or related PRs and linked
them above
- [x] I have either (a) linked existing issues with `Fixes: #` / `Closes
#` / `Refs #` OR (b) described the issue in-PR following the relevant
issue template
- [x] I have not referenced internal/instance-local Paperclip issues or
links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip`
URLs)
- [x] My branch name describes the change (e.g. `docs/...`, `fix/...`)
and contains no internal Paperclip ticket id or instance-derived details
- [x] I have run tests locally and they pass
- [x] I have added or updated tests where applicable
- [x] I have updated relevant documentation to reflect my changes
- [x] I have considered and documented any risks above
- [x] All Paperclip CI gates are green
- [x] Greptile is 5/5 with no open P2s, recommendations, or follow-ups
- [x] I will address all Greptile and reviewer comments before
requesting merge

---------

Co-authored-by: Paperclip <noreply@paperclip.ing>
2026-11-17 14:00:14 -08:00

357 lines
14 KiB
TypeScript

import { useMemo, useState, type FormEvent } from "react";
import { useQueryClient } from "@tanstack/react-query";
import { Archive, MoreHorizontal, Pencil, RefreshCw } from "lucide-react";
import { agentsApi } from "@/api/agents";
import { issuesApi } from "@/api/issues";
import { queryKeys } from "@/lib/queryKeys";
import { useRecentTasks } from "@/hooks/useRecentTasks";
import { useRecentTaskOpenWarmup } from "@/hooks/useRecentTaskOpenWarmup";
import { useAccountIdentity } from "@/api/companies-query";
import { useOptionalToastActions } from "@/context/ToastContext";
import {
recordRecentTask,
type RecentTaskEntry,
} from "@/lib/recent-tasks";
import { Button } from "@/components/ui/button";
import {
Dialog,
DialogContent,
DialogDescription,
DialogFooter,
DialogHeader,
DialogTitle,
} from "@/components/ui/dialog";
import {
DropdownMenu,
DropdownMenuContent,
DropdownMenuItem,
DropdownMenuTrigger,
} from "@/components/ui/dropdown-menu";
import { Input } from "@/components/ui/input";
import { StatusIcon } from "./StatusIcon";
import { SidebarSection } from "./SidebarSection";
import { RecentTaskNavItem } from "./RecentTaskNavItem";
import { RecentTaskGroup } from "./RecentTaskGroup";
import { recentTaskHierarchy } from "@/lib/recent-task-hierarchy";
import { useLocation } from "@/lib/router";
import { taskStatusIconProps } from "@/lib/task-status-presentation";
const RECENT_TASK_MENU_ITEM_CLASS =
"h-(--profile-popover-row-height) gap-(--profile-popover-row-gap) rounded-lg px-2.5 py-0 text-(length:--text-compact) font-medium leading-(--profile-popover-label-line-height) focus:bg-accent/50 focus:text-foreground";
const RESTART_WAKE_RETRY_STORAGE_SUFFIX = ":restart-wake-retry";
function restartWakeRetryStorageKey(companyId: string, userId: string | null) {
// Action retry state must survive changes to the recent-task snapshot format.
return `paperclip.recentTasks:${companyId}:${userId ?? "__local_board__"}${RESTART_WAKE_RETRY_STORAGE_SUFFIX}`;
}
function readRestartWakeRetryIssueIds(storageKey: string | null) {
if (!storageKey) return new Set<string>();
try {
const parsed = JSON.parse(window.localStorage.getItem(storageKey) ?? "[]") as unknown;
return new Set(Array.isArray(parsed) ? parsed.filter((value): value is string => typeof value === "string") : []);
} catch {
return new Set<string>();
}
}
function setRestartWakeRetryPending(storageKey: string | null, issueId: string, pending: boolean) {
if (!storageKey) return;
const issueIds = readRestartWakeRetryIssueIds(storageKey);
if (pending) issueIds.add(issueId);
else issueIds.delete(issueId);
try {
if (issueIds.size > 0) window.localStorage.setItem(storageKey, JSON.stringify([...issueIds]));
else window.localStorage.removeItem(storageKey);
} catch {
// Recent Tasks remains usable when browser storage is unavailable.
}
}
function errorMessage(error: unknown, fallback: string) {
return error instanceof Error && error.message.trim() ? error.message : fallback;
}
export function SidebarRecentTasks({
companyId,
liveIssueIds,
}: {
companyId: string | null | undefined;
liveIssueIds: ReadonlySet<string>;
}) {
const { userId, settled } = useAccountIdentity();
if (!companyId || !settled) return null;
return (
<RecentTasksList
key={`${companyId}:${userId ?? "__local_board__"}`}
companyId={companyId}
userId={userId}
liveIssueIds={liveIssueIds}
/>
);
}
function RecentTasksList({
companyId,
userId,
liveIssueIds,
}: {
companyId: string;
userId: string | null;
liveIssueIds: ReadonlySet<string>;
}) {
const { entries } = useRecentTasks({ companyId, userId });
const { pathname } = useLocation();
const hierarchy = useMemo(() => recentTaskHierarchy(entries, pathname), [entries, pathname]);
const queryClient = useQueryClient();
const toastActions = useOptionalToastActions();
const [renameEntry, setRenameEntry] = useState<RecentTaskEntry | null>(null);
const [renameValue, setRenameValue] = useState("");
const [pendingAction, setPendingAction] = useState<"rename" | "archive" | "pause" | null>(null);
const restartRetryStorageKey = restartWakeRetryStorageKey(companyId, userId);
useRecentTaskOpenWarmup({ companyId, userId, tasks: entries, navigationKey: pathname });
if (entries.length === 0) return null;
const refreshIssueQueries = async (issueId: string) => {
await Promise.all([
queryClient.invalidateQueries({ queryKey: queryKeys.issues.detail(issueId) }),
queryClient.invalidateQueries({ queryKey: queryKeys.issues.list(companyId) }),
queryClient.invalidateQueries({ queryKey: queryKeys.issues.activity(issueId) }),
]);
};
const beginRename = (entry: RecentTaskEntry) => {
setRenameEntry(entry);
setRenameValue(entry.title);
};
const submitRename = async (event: FormEvent<HTMLFormElement>) => {
event.preventDefault();
const nextTitle = renameValue.trim();
if (!renameEntry || !nextTitle || nextTitle === renameEntry.title) {
setRenameEntry(null);
return;
}
setPendingAction("rename");
try {
const updated = await issuesApi.update(renameEntry.id, { title: nextTitle });
queryClient.setQueryData(queryKeys.issues.detail(renameEntry.id), updated);
recordRecentTask(updated, userId, Date.now());
await refreshIssueQueries(renameEntry.id);
setRenameEntry(null);
toastActions?.pushToast({ title: "Task renamed", tone: "success" });
} catch (error) {
toastActions?.pushToast({
title: "Task rename failed",
body: errorMessage(error, "Unable to rename this task."),
tone: "error",
});
} finally {
setPendingAction(null);
}
};
const archiveTask = async (entry: RecentTaskEntry) => {
setPendingAction("archive");
try {
await issuesApi.archiveFromInbox(entry.id);
await refreshIssueQueries(entry.id);
await queryClient.invalidateQueries({
queryKey: queryKeys.sidebarBadges(companyId),
});
toastActions?.pushToast({ title: "Task archived from inbox", tone: "success" });
} catch (error) {
toastActions?.pushToast({
title: "Task archive failed",
body: errorMessage(error, "Unable to archive this task from the inbox."),
tone: "error",
});
} finally {
setPendingAction(null);
}
};
const toggleTaskPause = async (entry: RecentTaskEntry) => {
setPendingAction("pause");
try {
const state = await issuesApi.getTreeControlState(entry.id);
if (state.activePauseHold?.isRoot) {
const restartIssue = await issuesApi.get(entry.id);
setRestartWakeRetryPending(restartRetryStorageKey, entry.id, true);
await issuesApi.releaseTreeHold(entry.id, state.activePauseHold.holdId, {
reason: "Restarted from Recent Tasks.",
});
if (restartIssue.assigneeAgentId) {
const wakeResult = await agentsApi.wakeup(
restartIssue.assigneeAgentId,
{
source: "assignment",
triggerDetail: "manual",
reason: "recent_task_restart",
payload: { issueId: restartIssue.id },
},
restartIssue.companyId,
);
if (!("id" in wakeResult)) {
throw new Error(wakeResult.message ?? "The assignee wake was skipped.");
}
}
setRestartWakeRetryPending(restartRetryStorageKey, entry.id, false);
toastActions?.pushToast({ title: "Task restarted", tone: "success" });
} else if (state.activePauseHold) {
throw new Error("This task is paused by a parent task. Restart it from the pause root.");
} else if (readRestartWakeRetryIssueIds(restartRetryStorageKey).has(entry.id)) {
const restartIssue = await issuesApi.get(entry.id);
if (restartIssue.assigneeAgentId) {
const wakeResult = await agentsApi.wakeup(
restartIssue.assigneeAgentId,
{
source: "assignment",
triggerDetail: "manual",
reason: "recent_task_restart_retry",
payload: { issueId: restartIssue.id },
},
restartIssue.companyId,
);
if (!("id" in wakeResult)) {
throw new Error(wakeResult.message ?? "The assignee wake was skipped.");
}
}
setRestartWakeRetryPending(restartRetryStorageKey, entry.id, false);
toastActions?.pushToast({ title: "Task restarted", tone: "success" });
} else {
await issuesApi.createTreeHold(entry.id, {
mode: "pause",
reason: "Paused from Recent Tasks.",
releasePolicy: { strategy: "manual" },
});
toastActions?.pushToast({ title: "Task paused", tone: "success" });
}
await queryClient.invalidateQueries({
queryKey: ["issues", "tree-control-state", entry.id],
});
await queryClient.invalidateQueries({ queryKey: queryKeys.issues.summaries(companyId) });
} catch (error) {
toastActions?.pushToast({
title: "Task pause update failed",
body: errorMessage(error, "Unable to pause or restart this task."),
tone: "error",
});
} finally {
setPendingAction(null);
}
};
const renderTaskRow = (entry: RecentTaskEntry) => (
<div className="sidebar-action-row group/recent-task relative">
<RecentTaskNavItem
task={entry}
label={entry.title}
iconNode={entry.displayStatus === "monitoring" && !liveIssueIds.has(entry.id) ? <StatusIcon {...taskStatusIconProps(entry)} /> : undefined}
trailing={entry.status === "in_review" && entry.externalConversationState === "waiting"
? <span className="text-xs text-muted-foreground">Idle</span> : undefined}
className="sidebar-action-link pointer-coarse:pr-8"
liveCount={liveIssueIds.has(entry.id) ? 1 : undefined}
/>
<DropdownMenu>
<DropdownMenuTrigger asChild>
<Button
type="button"
variant="ghost"
size="icon-xs"
aria-label={`More actions for ${entry.title}`}
className="sidebar-action-menu absolute right-2 top-(--pct-50) z-10 -translate-y-(--pct-50) text-muted-foreground pointer-events-none opacity-0 transition-opacity hover:bg-sidebar-accent dark:hover:bg-sidebar-accent hover:text-foreground focus-visible:pointer-events-auto focus-visible:opacity-100 pointer-coarse:pointer-events-auto pointer-coarse:opacity-100 pointer-coarse:before:hidden group-hover/recent-task:pointer-events-auto group-hover/recent-task:opacity-100 group-focus-within/recent-task:pointer-events-auto group-focus-within/recent-task:opacity-100 data-[state=open]:pointer-events-auto data-[state=open]:bg-sidebar-accent data-[state=open]:text-foreground data-[state=open]:opacity-100"
>
<MoreHorizontal aria-hidden="true" />
</Button>
</DropdownMenuTrigger>
<DropdownMenuContent
side="right"
align="start"
className="w-(--profile-popover-width) rounded-xl p-1.5 shadow-(--shadow-profile-popover)"
>
<DropdownMenuItem
className={RECENT_TASK_MENU_ITEM_CLASS}
onSelect={() => beginRename(entry)}
>
<Pencil aria-hidden="true" />
Rename
</DropdownMenuItem>
<DropdownMenuItem
className={RECENT_TASK_MENU_ITEM_CLASS}
disabled={pendingAction !== null}
onSelect={() => void archiveTask(entry)}
>
<Archive aria-hidden="true" />
Archive
</DropdownMenuItem>
<DropdownMenuItem
className={RECENT_TASK_MENU_ITEM_CLASS}
disabled={pendingAction !== null}
onSelect={() => void toggleTaskPause(entry)}
>
<RefreshCw aria-hidden="true" />
Pause/Restart
</DropdownMenuItem>
</DropdownMenuContent>
</DropdownMenu>
</div>
);
return (
<>
<SidebarSection label="Recent Tasks">
{entries.filter(entry => !hierarchy.nestedIds.has(entry.id)).map((entry) => (
<RecentTaskGroup key={entry.id} task={entry} userId={userId} flattened={hierarchy.flattenedIds.has(entry.id)}
selectedChild={hierarchy.selectedChild?.parentId === entry.id ? hierarchy.selectedChild : undefined} renderChild={renderTaskRow}>
{renderTaskRow(entry)}
</RecentTaskGroup>
))}
</SidebarSection>
<Dialog
open={renameEntry !== null}
onOpenChange={(open) => {
if (!open && pendingAction !== "rename") setRenameEntry(null);
}}
>
<DialogContent className="sm:max-w-md">
<form className="grid gap-4" onSubmit={(event) => void submitRename(event)}>
<DialogHeader>
<DialogTitle>Rename task</DialogTitle>
<DialogDescription>Choose a short, clear name for this task.</DialogDescription>
</DialogHeader>
<Input
autoFocus
aria-label="Task name"
value={renameValue}
disabled={pendingAction === "rename"}
onChange={(event) => setRenameValue(event.target.value)}
/>
<DialogFooter>
<Button
type="button"
variant="outline"
disabled={pendingAction === "rename"}
onClick={() => setRenameEntry(null)}
>
Cancel
</Button>
<Button
type="submit"
disabled={pendingAction === "rename" || !renameValue.trim()}
>
{pendingAction === "rename" ? "Saving..." : "Save"}
</Button>
</DialogFooter>
</form>
</DialogContent>
</Dialog>
</>
);
}