mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-11-18 23:08:26 +01:00
## Thinking Path > - Paperclip is the open source app people use to manage AI agents for work. > - Pull requests must pass CI before merge. > - The protected CI gate requires each author and triggering user to be an AWS-allowlisted owner of `.github/**`. > - Four team maintainers are missing from that owner rule. Their PRs use the GitHub-hosted queue. > - This pull request adds those four accounts to the existing CI owner rule. > - Their eligible PRs can use the AWS test fleet after this change reaches protected `master`. ## Linked Issues or Issue Description Related: #22077 showed this routing result. #21192 introduced the current CI CODEOWNER check. No duplicate roster-change PR was found. **What existing behavior does this improve?** Runner selection for PRs from team maintainers. **Current behavior** `tonio-alucema`, `scotttong`, `lucktastic`, and `nguyenm7` are not owners of `.github/**`. The gate sends their test jobs to GitHub-hosted runners. Repository admin access alone does not satisfy the gate. **Proposed behavior** Add all four users to the existing `.github/**` CODEOWNERS rule. Keep all existing owners and the current identity, event, and commit checks. **Reason and benefit** These maintainers can use the trusted AWS fleet without a separate routing exception. This avoids the hosted queue for eligible runs. ## What Changed - Add `@tonio-alucema`, `@scotttong`, `@lucktastic`, and `@nguyenm7` to the `.github/**` owner rule. - Prepare the separate repository settings for this policy: add lucktastic's verified user ID, `13757243`, to `AWS_CI_TRUSTED_USER_IDS`. Synchronize `AWS_CI_ROUTING_USER_IDS_SOURCE` and `AWS_CI_ROUTING_USER_IDS`. The other three users were already listed. This settings change is complete; the protected master owner check still controls test execution. ## Verification - Final tested head: `0fc7873beefe73fe53ffbf1363862c865fc77eef`. [CI attempt 3 completed successfully](https://github.com/paperclipai/paperclip/actions/runs/44199904434/attempts/3). All applicable jobs pass, including typecheck, build, all test matrices, [verify](https://github.com/paperclipai/paperclip/actions/runs/44199904434/job/134472019170), and [E2E](https://github.com/paperclipai/paperclip/actions/runs/44199904434/job/134468650593). Failed-job retries retain earlier passing jobs; this is combined coverage on the unchanged head, not a new full-suite execution. - [Greptile: 5/5 with no actionable issues](https://github.com/paperclipai/paperclip/pull/22098#issuecomment-6964150026). No unresolved review threads. No merge conflicts with `master`. - Passed `node --test .github/scripts/tests/ci-routing.test.mjs .github/scripts/tests/ci-profile.test.mjs`: 163 tests, zero failures. These cover accepted and rejected identities, non-owner authors and rerun actors, malformed settings, and trusted-source validation. - Resolved the proposed CODEOWNERS file through the existing `trustedOwnerIds` resolver and live GitHub user records. All four requested users resolve to distinct human accounts with repository admin access. Existing owners remain present. All four users are in the numeric AWS allowlist, and both admission variables match it. - Passed `git diff --check`. Reviewed the full one-line diff for credentials, private URLs, personal data, and run artifacts; none are present. No new test implementation was needed for this roster-only edit. CI supplies the broad application coverage; no full local application suite was run. - GitHub requires approval from an existing CI code owner before merge. The automatic review requests are in place. <details> <summary>Earlier CI failures and retry evidence</summary> Attempt 1 was incomplete. The [Build runner](https://github.com/paperclipai/paperclip/actions/runs/44199904434/job/134451301493) lost communication with GitHub; its annotation confirms runner loss, and its log was unavailable (HTTP 404). [E2E shard 8/8](https://github.com/paperclipai/paperclip/actions/runs/44199904434/job/134451302068), [server shard 5/12](https://github.com/paperclipai/paperclip/actions/runs/44199904434/job/134451302631), and [server shard 9/12](https://github.com/paperclipai/paperclip/actions/runs/44199904434/job/134451302800) each logged a runner shutdown signal. [E2E shard 7/8](https://github.com/paperclipai/paperclip/actions/runs/44199904434/job/134451302023) separately failed at `tests/e2e/plan-task-fixture.spec.ts:30`. A test-company deletion returned HTTP 500 because an activity-log row still referenced the company (`activity_log_company_id_companies_id_fk`). The fixture and application code match the base revision. This test failure prevented the automatic runner-loss retry. A manual failed-job retry used the unchanged head. Attempt 2's [Build retry](https://github.com/paperclipai/paperclip/actions/runs/44199904434/job/134458626180) passed. [E2E shard 7/8](https://github.com/paperclipai/paperclip/actions/runs/44199904434/job/134458626964) passed all 32 active tests, including both planning fixtures. The cleanup error did not repeat without a source change. This establishes recovery; its original cause remains unresolved. [Server shard 9/12](https://github.com/paperclipai/paperclip/actions/runs/44199904434/job/134458630607) also passed. [E2E shard 8/8](https://github.com/paperclipai/paperclip/actions/runs/44199904434/job/134458627148) and [server shard 5/12](https://github.com/paperclipai/paperclip/actions/runs/44199904434/job/134458630550) each logged another runner shutdown. The E2E and verify aggregates rejected the interrupted dependencies. A second manual failed-job retry completed the missing coverage. Attempt 3's [E2E shard 8/8](https://github.com/paperclipai/paperclip/actions/runs/44199904434/job/134465389776) and [server shard 5/12](https://github.com/paperclipai/paperclip/actions/runs/44199904434/job/134465390839) passed, and both required aggregate checks passed. No source changes or check bypasses were used during recovery. </details> ## Risks - These users become code-owner reviewers for `.github/**`. They also become eligible for the CI profiling paths that use this owner rule. - Runner authorization still requires the numeric allowlist and the protected master owner rule for every checked identity. The change takes effect for newly evaluated gates after merge. PR edits cannot grant themselves access. - Existing queued jobs retain their runner selection. Start a new PR run or rerun the routing gate after merge to evaluate the new roster. ## Model Used OpenAI `gpt-6.1-sol` through the Codex harness, with xhigh reasoning effort, repository tools, and code execution. Context window size is not exposed by this runtime. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either (a) linked existing issues with `Fixes: #` / `Closes #` / `Refs #` OR (b) described the issue in-PR following the relevant issue template - [x] I have not referenced internal/instance-local Paperclip issues or links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip` URLs) - [x] My branch name describes the change (e.g. `docs/...`, `fix/...`) and contains no internal Paperclip ticket id or instance-derived details - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] All Paperclip CI gates are green - [x] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I will address all Greptile and reviewer comments before requesting merge Co-authored-by: Paperclip <noreply@paperclip.ing>
28 lines
1.7 KiB
Plaintext
28 lines
1.7 KiB
Plaintext
# Replace @cryppadotta if a different maintainer or team should own release infrastructure.
|
|
|
|
.github/** @cryppadotta @devinfoley @nickyleach @forgottendev @tonio-alucema @scotttong @lucktastic @nguyenm7
|
|
scripts/ci-profile/** @cryppadotta @devinfoley @nickyleach @forgottendev
|
|
scripts/release*.sh @cryppadotta @devinfoley @nickyleach @forgottendev
|
|
scripts/release-*.mjs @cryppadotta @devinfoley @nickyleach @forgottendev
|
|
scripts/create-github-release.sh @cryppadotta @devinfoley @nickyleach @forgottendev
|
|
scripts/rollback-latest.sh @cryppadotta @devinfoley @nickyleach @forgottendev
|
|
doc/RELEASING.md @cryppadotta @devinfoley @nickyleach @forgottendev @tonio-alucema @scotttong
|
|
doc/PUBLISHING.md @cryppadotta @devinfoley @nickyleach @forgottendev
|
|
doc/RELEASE-AUTOMATION-SETUP.md @cryppadotta @devinfoley @nickyleach @forgottendev
|
|
skills/** @cryppadotta @devinfoley @nickyleach @forgottendev
|
|
|
|
# Review configuration and repository rules
|
|
/.greptile/ @cryppadotta @devinfoley @nickyleach @forgottendev
|
|
/rules/ @cryppadotta @devinfoley @nickyleach @forgottendev
|
|
|
|
# Package files — dependency changes require review
|
|
# package.json matches recursively at all depths (covers root + all workspaces)
|
|
package.json @cryppadotta @devinfoley @nickyleach @forgottendev
|
|
pnpm-lock.yaml @cryppadotta @devinfoley @nickyleach @forgottendev
|
|
/tests/runner-e2e/report-lock.json @cryppadotta @devinfoley @nickyleach @forgottendev
|
|
/tests/runner-e2e/report-lock.patch @cryppadotta @devinfoley @nickyleach @forgottendev
|
|
pnpm-workspace.yaml @cryppadotta @devinfoley @nickyleach @forgottendev
|
|
.npmrc @cryppadotta @devinfoley @nickyleach @forgottendev
|
|
|
|
/packages/paperclip-runner/src/contracts/runtime-context-prompts.ts @cryppadotta @devinfoley @nickyleach @forgottendev
|