mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-11-14 08:53:19 +01:00
## Thinking Path > - Paperclip manages AI agents and their work. > - Native agents open input images with a file reader. > - Plugin Runner tasks use an authenticated Runner connection. > - Runner needs a way to fetch an authorized file from the tenant app. > - The tenant grants access to the exact attachment for the active run. > - Runner downloads and verifies it before it returns a local path. ## Linked Issues or Issue Description Refs #19740. Builds on the attachment authorization and command transport added in #20939. ## What Changed - Add the PRP v3 `runner.attachment.download` command for native workspace providers. - Issue short-lived grants for exact authorized wake and historical attachments. Recheck the active run, source, size, and SHA-256 at the tenant endpoint. - Download current-wake inputs before provider dispatch. Download historical files when the authorized chat reader asks for them. Preserve SSH and sandbox command staging as a fallback. - Run HTTPS transfers off the Runner control loop. Report completion with one PRP event per transfer. Drop pending results on cancellation and clear files at turn settlement, authority rotation, and restart. - Grant restricted Codex sessions read-only access to the attachment directory. ## Verification - 69 targeted server attachment tests passed. They cover wake and historical downloads, authorization failures, and command fallback. - 22 focused historical attachment tests passed, including grant redemption under a held database lock. - Six focused Rust attachment tests passed, including a source-pinned Codex sandbox check. The sandbox could read the staged file but could not modify it or read adjacent Runner state. - The real Runner transport test confirmed one durable command and one completion event for a transfer. Restart-continuation tests confirmed fresh attachment paths appear before dispatch. - Server and Runner TypeScript checks, Rust formatting, and PRP generated schema checks passed. - Required GitHub CI passed on `7a33752bd7`. [CI run](https://github.com/paperclipai/paperclip/actions/runs/43122967837) - Greptile scored the same revision 5/5 with no unresolved review threads. [Review](https://github.com/paperclipai/paperclip/pull/20956#issuecomment-6808582134) ## Risks - Saved provider and Runner identities keep their existing formats. A previous Runner falls back to command staging where the target supports it. A restart continuation refreshes temporary attachment paths before dispatch. - Plugin Runner tasks require a compatible Runner ROM and outbound HTTPS access to the configured tenant origin. - Live agent-computer qualification remains a release check. ## Model Used OpenAI GPT-6 through Codex, with repository inspection, shell tools, and local test execution. Exact variant and context window are unavailable in this session. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either (a) linked existing issues with `Fixes: #123` / `Closes #123` / `Refs #123` or (b) described the issue in-PR following the relevant issue template - [x] I have not referenced internal/instance-local Paperclip issues or links - [x] My branch name describes the change - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] All Paperclip CI gates are green - [x] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I will address all Greptile and reviewer comments before requesting merge --------- Co-authored-by: Paperclip <noreply@paperclip.ing>
180 lines
10 KiB
Markdown
180 lines
10 KiB
Markdown
# PRP v1/v2 Contract
|
||
|
||
The JSON Schema files in `schemas/` are the language-neutral source of truth for
|
||
Paperclip Runner Protocol versions 1 and 2. The fixtures in `fixtures/` define
|
||
accepted and rejected compatibility cases.
|
||
|
||
## Compatibility
|
||
|
||
- `protocolVersion`, `fixtureVersion`, and `event.schemaVersion` are required.
|
||
- A consumer fails closed when a required version or schema discriminator is
|
||
not supported.
|
||
- A v1 envelope can contain an unknown optional property when its schema marks
|
||
that object as extensible.
|
||
- A consumer ignores an unknown optional property until a later contract gives
|
||
it meaning.
|
||
- A required field, enum value, or typed structured-input field is not optional.
|
||
- Question and answer identifiers are stable across the provider boundary.
|
||
- Peers negotiate the highest mutually supported protocol version. Existing v1
|
||
runners remain compatible but cannot receive v2-only session-goal commands.
|
||
|
||
The `unknown-optional-fields.json` fixture must be accepted. The
|
||
`unsupported-required-version.json` fixture must be rejected.
|
||
|
||
## Session goals (v2)
|
||
|
||
PRP v2 adds a provider-neutral durable session-goal lifecycle. Every v2
|
||
capability snapshot includes `sessionGoals`, even when its availability is
|
||
`unsupported` or `policy_disabled`. Paperclip sends controls only when the
|
||
negotiated capability advertises the corresponding action.
|
||
|
||
Commands:
|
||
|
||
- `session.goal.get`
|
||
- `session.goal.set` for objective, status, and optional token budget changes
|
||
- `session.goal.clear`
|
||
|
||
Events:
|
||
|
||
- `session.capabilities.updated`
|
||
- `session.goal.snapshot`
|
||
- `session.goal.updated`
|
||
- `session.goal.cleared`
|
||
|
||
Goal state is separate from Paperclip's company/business goal hierarchy. The
|
||
snapshot distinguishes the durable status from `workingNow`, because an active
|
||
goal can be idle between autonomous turns. A runner emits the full capability
|
||
and authoritative snapshot after every session open or resume. Missing v1
|
||
capability is unsupported; clients do not infer support from an adapter name.
|
||
|
||
## Harness credential updates
|
||
|
||
`auth.credentials.updated` is a P0 runner event available in the v1, v2, and v3 event
|
||
schemas. Its payload uses `paperclip.auth.credentials.updated.v1` and contains
|
||
only `provider`, `bindingId`, `revision`, and `detection`. No tokens, account
|
||
identifiers, credential paths, or credential fingerprints are permitted.
|
||
|
||
An updated consumer opts in with `observeCredentials: true` in `run.prepare`,
|
||
before `session.open`. The bundled runner transport opts in for fresh sessions;
|
||
set its `observeCredentials` option to `false` to disable observation for a
|
||
fresh session. Older hosts that omit the field receive no new event. Consumers
|
||
must update their schemas before opting in: an event-enum addition is not an
|
||
unknown optional property. Existing runner binaries ignore the optional flag
|
||
and do not provide observation; absence of an event does not establish support.
|
||
|
||
The current Unix runner observes native Codex's managed `CODEX_HOME/auth.json`
|
||
and the Codex/Grok ACPX session homes. It uses a non-recursive directory watch
|
||
plus a one-second polling fallback, so atomic file replacement is handled.
|
||
Grok's initial inline subscription credential is the baseline, allowing a
|
||
refresh during launcher startup to be detected. A first valid credential file
|
||
without a prior baseline establishes the baseline without claiming a refresh.
|
||
Account identity changes also emit updates, even when token values stay the
|
||
same, and establish the baseline for later refreshes on the new account.
|
||
Hosts must evaluate the current credential through their private credential
|
||
channel and account checks; the event does not authorize an account switch.
|
||
Metadata-only changes, partial writes, and deletion do not emit updates.
|
||
Unsupported harnesses and refreshes retained only in memory need
|
||
their own observer or native-hook integration; adding this event does not make
|
||
them observable.
|
||
|
||
`bindingId: "harness-auth"` identifies the selected harness authentication
|
||
within the envelope's normalized session. Revisions increase for that binding
|
||
and survive runner restarts and warm run attachments. The baseline fingerprint
|
||
and pending event are persisted together in a private runner state file. Source
|
||
retries retain the same event identity until the durable PRP outbox accepts it.
|
||
Hosts should commit an idempotent reaction or durable work item through
|
||
`onCommittedEvent` before returning and advancing the cumulative ACK.
|
||
The bundled transport exposes `onCredentialsUpdated(event)` for this commit.
|
||
It awaits the callback before ACK, including during warm idle, attachment, and
|
||
provider cleanup. Callback failures leave delivery unacknowledged for retry;
|
||
callbacks must therefore deduplicate by the original source event identity.
|
||
When configured, credential updates bypass the turn notification queue.
|
||
Paperclip commits them directly to the run log in a separate credential source
|
||
namespace, preserving the original PRP envelope and avoiding collisions with
|
||
the driver's normalized event sequence. A turn-only notification consumer
|
||
cannot reliably handle idle or cleanup updates; use this callback instead.
|
||
|
||
`detection: "credential_store"` reports an observed credential change, not proof
|
||
that an OAuth refresh succeeded. Multiple changes between observations can be
|
||
coalesced; this is not an audit of every refresh exchange. The schema also
|
||
allows `native_hook` for integrations with an explicit signal. Observation
|
||
continues during warm idle and checks at turn terminal and close boundaries,
|
||
including Grok's private refresh handoff after live-store cleanup. Retained
|
||
runner observations enter the durable outbox before a suspend or shutdown
|
||
command completes, without draining the provider backlog. A final check after
|
||
provider cleanup also enters the outbox and waits for the host ACK. The runner
|
||
retains its terminal recovery fence if that delivery fails.
|
||
|
||
The event authorizes no credential access or write on its own. A host that
|
||
needs rotated token values must use a separately authorized handoff with its
|
||
existing account-identity and freshness safeguards. The default Paperclip
|
||
credential copy-back behavior remains in place.
|
||
|
||
## Scope
|
||
|
||
The first provider descriptor and adapter fixture cover Codex only. The schemas
|
||
for provider-neutral events and semantic receipts do not enable those actions.
|
||
Discovery and authorization are separate contracts.
|
||
|
||
The conformance manifest records every source file and its SHA-256 digest. Run
|
||
`pnpm generate:protocol-manifest` from this package after a source change. CI
|
||
runs the same generator with `--check` to reject drift. This check also compiles
|
||
the JSON Schemas and validates every replay, question, and cross-language
|
||
conformance fixture against its declared schema.
|
||
|
||
The files in `fixtures/replay/golden/` are deterministic reducer oracles. Each
|
||
accepted replay fixture has a complete session snapshot and a compact parity
|
||
summary. `pnpm generate:replay-goldens` updates them after an intentional
|
||
reducer change; package build and CI fail when they drift.
|
||
|
||
The files in `fixtures/local-runner/scripts/` drive the package-local fake
|
||
harness. They cover successful, failed, interrupted, interactive, duplicate
|
||
terminal, process-cleanup, and oversized-frame behavior without starting a
|
||
production adapter.
|
||
|
||
`runtime.activity.recorded` is a P1 Runner event in v1, v2 and v3 with exactly
|
||
`{ namespace, activityKey }`. Both opaque identifiers contain 1–160 Unicode code
|
||
points and exclude C0 controls and DEL. `namespace` groups a producer's activity
|
||
types; `activityKey` names an activity within that group. Consumers use the pair
|
||
to select a response to activity in the run. The authenticated outer envelope
|
||
provides run and session identity, source sequence and emission time. Core resolves
|
||
the run's company, task and agent through its existing authorized run binding;
|
||
callers cannot supply those identities in the payload. Recording activity does
|
||
not independently verify the reported action or grant access to any resource.
|
||
The event uses the ordinary durable outbox, acknowledgement and replay contract.
|
||
|
||
Local clients capture an opaque context with `paperclip-runnerd notification-context`
|
||
before an operation and invoke `record-activity CONTEXT NAMESPACE ACTIVITY_KEY`
|
||
after success. Runner publishes its matching absolute executable as host-owned
|
||
`PAPERCLIP_RUNTIME_NOTIFICATION_HELPER` and the stable endpoint descriptor path
|
||
as `PAPERCLIP_RUNTIME_NOTIFICATION_CONTEXT`. Configured task environment cannot
|
||
override either value. Context is invalidated on warm attachment and process
|
||
recovery, so a caller cannot attribute a later completion to a different run.
|
||
|
||
### Runner attachment downloads
|
||
|
||
For native workspace providers, the authenticated controller can send
|
||
`runner.attachment.download` as a PRP v3 command after provider preparation.
|
||
The controller authorizes the source and sends `turnId`, an HTTPS `url` with
|
||
no query or fragment, a short-lived opaque bearer `token`, `byteSize`,
|
||
`sha256` (lowercase hex), and `contentType`. The controller must choose the
|
||
tenant download endpoint and issue a grant redeemable for only the admitted
|
||
file during that turn. Keep grants in private controller state.
|
||
|
||
Runner starts a bounded HTTPS GET with the grant in the Authorization header
|
||
and returns `{ status: "pending", downloadId }`. Runner can process Stop while
|
||
the GET runs. Runner emits one `runner.attachment.settled` event with the same
|
||
`downloadId` and a `ready` or `failed` status. A ready event includes the local
|
||
`path` only after Runner verifies the complete file.
|
||
The path is local to the Runner, uses a random filename, and is valid only
|
||
during the bound turn. Runner clears its private download directory on turn
|
||
settlement, authority rotation, and shutdown. The next use of that Runner
|
||
state directory also clears residue from interrupted processes. The command
|
||
supports files through 10 MiB and limits live downloads to 128 files or
|
||
128 MiB per turn. Providers should receive only the path and file metadata.
|
||
|
||
The authenticated `session.snapshot` result advertises this command with
|
||
`attachmentDownloadVersion: 1`. The tenant controller uses this capability
|
||
before issuing a grant. Attachment admission and issuance of grants belong
|
||
to the tenant app.
|