mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-10-30 21:49:18 +01:00
## Thinking Path > - Paperclip is the open source app people use to manage AI agents for work > - Paperclip reports server and browser errors through optional Sentry monitoring > - One environment variable sends both error types to one Sentry project > - Operators need separate control for browser and server error data > - This pull request adds specific variables and keeps the existing variable as a fallback > - The benefit is separate monitoring without breaking current deployments ## Linked Issues or Issue Description **What existing behavior does this improve?** The Sentry configuration for server and browser monitoring uses one environment variable. **Subsystem affected** Cross-cutting (multiple of the above) **Current behavior** `SENTRY_DSN` supplies the server and browser clients. Both clients therefore report to the same Sentry project. **Proposed behavior** `SENTRY_DSN_FRONTEND` supplies the browser client. `SENTRY_DSN_BACKEND` supplies the server process. `SENTRY_DSN` remains a fallback for either component. **Reason and benefit** Operators can send browser and server errors to separate Sentry projects. Operators can also activate only one component. **Breaking changes** None. Existing deployments can continue to use `SENTRY_DSN`. ## What Changed - Add `resolveSentryDsns(env)` and use it in the server and browser configuration paths. - Add precedence, empty-string, fallback, and route tests. - Update the README, observability guide, and stale code comments. - Log one warning when the server uses the legacy fallback without exposing a DSN value. ## Verification - `pnpm vitest run --project server sentry-dsn` — 8 tests pass. - `pnpm vitest run --project server auth-routes` — 21 tests pass. - The earlier run of the three targeted suites passed 40 tests. - `tsc --noEmit` passes for the files in this diff. - All required GitHub Actions checks pass, including the full continuous-integration suite. ## Risks The main risk is an incorrect environment variable precedence rule. Unit tests cover specific values, empty strings, and legacy fallback behavior. The existing `SENTRY_DSN` path remains compatible. ## Model Used OpenAI Codex — GPT-5, current runtime, tool use and code execution. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either (a) linked existing issues with `Fixes: #` / `Closes #` / `Refs #` OR (b) described the issue in-PR following the relevant issue template - [x] I have not referenced internal/instance-local Paperclip issues or links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip` URLs) - [x] My branch name describes the change (e.g. `docs/...`, `fix/...`) and contains no internal Paperclip ticket id or instance-derived details - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] All Paperclip CI gates are green - [x] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I will address all Greptile and reviewer comments before requesting merge --------- Co-authored-by: Paperclip <noreply@paperclip.ing>
107 lines
3.0 KiB
TypeScript
107 lines
3.0 KiB
TypeScript
import { Router } from "express";
|
|
import { eq } from "drizzle-orm";
|
|
import type { Db } from "@paperclipai/db";
|
|
import { authUsers } from "@paperclipai/db";
|
|
import {
|
|
authSessionSchema,
|
|
currentUserProfileSchema,
|
|
updateCurrentUserProfileSchema,
|
|
} from "@paperclipai/shared";
|
|
import { unauthorized } from "../errors.js";
|
|
import { validate } from "../middleware/validate.js";
|
|
import { resolveSentryDsns } from "../sentry-dsn.js";
|
|
|
|
async function loadCurrentUserProfile(db: Db, userId: string) {
|
|
const user = await db
|
|
.select({
|
|
id: authUsers.id,
|
|
email: authUsers.email,
|
|
name: authUsers.name,
|
|
image: authUsers.image,
|
|
})
|
|
.from(authUsers)
|
|
.where(eq(authUsers.id, userId))
|
|
.then((rows) => rows[0] ?? null);
|
|
|
|
if (!user) {
|
|
throw unauthorized("Signed-in user not found");
|
|
}
|
|
|
|
return currentUserProfileSchema.parse({
|
|
id: user.id,
|
|
email: user.email ?? null,
|
|
name: user.name ?? null,
|
|
image: user.image ?? null,
|
|
});
|
|
}
|
|
|
|
export function authRoutes(db: Db) {
|
|
const router = Router();
|
|
|
|
router.get("/get-session", async (req, res) => {
|
|
if (req.actor.type !== "board" || !req.actor.userId) {
|
|
throw unauthorized("Board authentication required");
|
|
}
|
|
|
|
const user = await loadCurrentUserProfile(db, req.actor.userId);
|
|
res.json(authSessionSchema.parse({
|
|
session: {
|
|
id: `paperclip:${req.actor.source ?? "none"}:${req.actor.userId}`,
|
|
userId: req.actor.userId,
|
|
},
|
|
user,
|
|
// The browser reads this value to open its own Sentry gate — see
|
|
// `ui/src/lib/sentry.ts`. `req.actor.type` already gates this whole
|
|
// handler, so no second authorization check runs here. This field
|
|
// carries the front-end DSN only; it never carries the backend DSN.
|
|
sentryDsn: resolveSentryDsns().frontend,
|
|
}));
|
|
});
|
|
|
|
router.get("/profile", async (req, res) => {
|
|
if (req.actor.type !== "board" || !req.actor.userId) {
|
|
throw unauthorized("Board authentication required");
|
|
}
|
|
|
|
res.json(await loadCurrentUserProfile(db, req.actor.userId));
|
|
});
|
|
|
|
router.patch("/profile", validate(updateCurrentUserProfileSchema), async (req, res) => {
|
|
if (req.actor.type !== "board" || !req.actor.userId) {
|
|
throw unauthorized("Board authentication required");
|
|
}
|
|
|
|
const patch = updateCurrentUserProfileSchema.parse(req.body);
|
|
const now = new Date();
|
|
|
|
const updated = await db
|
|
.update(authUsers)
|
|
.set({
|
|
name: patch.name,
|
|
...(patch.image !== undefined ? { image: patch.image } : {}),
|
|
updatedAt: now,
|
|
})
|
|
.where(eq(authUsers.id, req.actor.userId))
|
|
.returning({
|
|
id: authUsers.id,
|
|
email: authUsers.email,
|
|
name: authUsers.name,
|
|
image: authUsers.image,
|
|
})
|
|
.then((rows) => rows[0] ?? null);
|
|
|
|
if (!updated) {
|
|
throw unauthorized("Signed-in user not found");
|
|
}
|
|
|
|
res.json(currentUserProfileSchema.parse({
|
|
id: updated.id,
|
|
email: updated.email ?? null,
|
|
name: updated.name ?? null,
|
|
image: updated.image ?? null,
|
|
}));
|
|
});
|
|
|
|
return router;
|
|
}
|