Files
PaperClipAI/tests/runner-e2e/server-stop.ts
T
DottaandPaperclip 16787e4167 Qualify rolling web deployments and preserve Stop through handoff (#18526)
## Thinking Path

> - Paperclip is the open source app people use to manage AI agents for
work.
> - The web server owns request handling and remote execution
coordination.
> - Deployment must start a ready replacement while the old server still
serves.
> - An outage test does not prove that two live servers can overlap
safely.
> - This pull request adds a separate Product E2E cell for that
boundary.
> - The existing run, file, recovery, and retained-session checks still
apply.

## Linked Issues or Issue Description

Refs #18518. The runtime prerequisite is merged; this PR qualifies its
ephemeral server and deployment contracts.

## What Changed

- Add the explicit `rolling-web-deployment` Codex Daytona workflow.
- Start independent A/B/C homes and compiled builds behind a test
ingress.
- Wait for readiness before routing, then drain and delete the old home.
- Observe active authority before handoff and use the existing read-only
recovery oracle.
- Require ordinary reads and saves to succeed throughout replacement.
Read back every accepted save exactly once.
- Preserve the five-minute outage suites and their existing validators.
- Add a model-free supervisor smoke and an unready replacement control.
- Require graceful exit before deleting an old home; forced cleanup
cannot satisfy the oracle.
- Preserve a durable Stop through lease release/expiry until the
recovered execution owner acknowledges it. Permit only fenced
reattachment of the original execution for Stop cleanup; submit no new
turn.
- Exclude events saved by A during shutdown from evidence of B making
progress.

## Verification

- E2E TypeScript check passed.
- Affected harness checks: 143 passed. Catalog, fixture and report
checks: 120 passed.
- Actual supervisor smoke passed two replacements: 436 reads, 45 saves,
zero request failures, and confirmed owned resource cleanup.
- B became ready in 18.7 seconds; C became ready in 109.2 seconds. A
prior C timeout remains failed evidence.
- Fresh browser proof: 11 checks passed, 246 reads, 50 acknowledged
saves, zero failures, 1,058ms reconnect, both old homes deleted and
cleanup confirmed.
- Stop lease-gap regression: three PostgreSQL delivery tests passed with
a simulated provider edge. Current server TypeScript build/vendoring
passed.
- Full harness: 5,814 passed, 17 failed, four skipped. Two shutdown
races passed the focused file; two report timeouts passed an isolated
42-test rerun. Onboarding/workflow-security/Pi/date-expired fixtures are
unchanged on inspected master; the host embedded PostgreSQL fixture
remains a setup limitation. This is not a green full local suite.
- CI at `172509b8be` passed all gates. Greptile is 5/5 with every review
thread resolved. The earlier access-service race failure passed its
isolated regression and the subsequent full CI.
- Final review corrections: six focused executor cases, three PostgreSQL
command-delivery cases, 19 harness cases and server/E2E typechecks
passed.
- Three live attempts failed before agent creation: two harness setup
gaps were fixed, then provider authentication failed. The saved OpenAI
key returns 401; a refresh is pending. The Daytona probe reported
cleanup uncertain, and no sandbox with that attempt label was found
through the authenticated staging manager. No live model execution is
claimed.
- Live Runner overlap, released-container qualification and hosted
deployment proof remain pending. Merging this opt-in qualification lane
does not claim those results.

## Risks

- The source lane shares workspace dependencies and does not establish
container packaging correctness.
- The live workflow needs an explicitly owned S3 bucket, PostgreSQL,
pinned remote image and provider credentials.
- Qualification cleanup stops all owned processes after failure. A
failed replacement must not be reported as a pass.

## Model Used

OpenAI Codex, GPT-6. Tool use, code execution and repository review. The
runtime does not expose a more specific model ID or context-window size.

## Checklist

- [x] I have included a thinking path that traces from project context
to this change
- [x] I have specified the model used (with version and capability
details)
- [x] I have checked ROADMAP.md and confirmed this PR does not duplicate
planned core work
- [x] I have searched GitHub for duplicate or related PRs and linked
them above
- [x] I have either (a) linked existing issues with `Fixes: #` / `Closes
#` / `Refs #` OR (b) described the issue in-PR following the relevant
issue template
- [x] I have not referenced internal/instance-local Paperclip issues or
links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip`
URLs)
- [x] My branch name describes the change (e.g. `docs/...`, `fix/...`)
and contains no internal Paperclip ticket id or instance-derived details
- [x] I have run tests locally and they pass
- [x] I have added or updated tests where applicable
- [x] I have updated relevant documentation to reflect my changes
- [x] I have considered and documented any risks above
- [x] All Paperclip CI gates are green
- [x] Greptile is 5/5 with no open P2s, recommendations, or follow-ups
- [x] I will address all Greptile and reviewer comments before
requesting merge

---------

Co-authored-by: Paperclip <noreply@paperclip.ing>
2026-11-01 02:53:27 -06:00

161 lines
7.9 KiB
TypeScript

import type { ChildProcess } from "node:child_process";
import { createProcessTreeOwner, incompleteTreeFallback, type RestartRunnerIdentity } from "./process-tree-owner.js";
// The wrapper receives Playwright's group signal; only it signals Paperclip.
export const runnerE2EServerDetached = process.platform !== "win32";
const wait = (ms: number) => new Promise<void>(resolve => setTimeout(resolve, ms));
export function createRunnerE2EServerStopper(options: {
gracefulTimeoutMs: number;
forcedTimeoutMs: number;
hasSpawnError: (child: ChildProcess) => boolean;
markExpectedStop: (child: ChildProcess) => void;
log: (message: string) => void;
createOwner?: typeof createProcessTreeOwner;
}) {
type State = {
owner: ReturnType<typeof createProcessTreeOwner>;
promise?: Promise<void>;
restartPromise?: Promise<void>;
finalRequested?: boolean;
finalPhaseStarted?: boolean;
finalComplete?: boolean;
gracefulDeadline?: number;
forcedDeadline?: number;
gracefulSent: boolean;
groupSignals: Set<number>;
escalationLogged: boolean;
};
const states = new WeakMap<ChildProcess, State>();
const watched = new Set<ChildProcess>();
let finalGraceDeadline: number | undefined;
let finalForcedDeadline: number | undefined;
let finalAllPromise: Promise<void> | undefined;
const exited = (child: ChildProcess) => child.exitCode !== null || child.signalCode !== null || options.hasSpawnError(child);
function watch(child: ChildProcess) {
let state = states.get(child);
if (!state) {
state = { owner: (options.createOwner ?? createProcessTreeOwner)(child), gracefulSent: false, groupSignals: new Set(), escalationLogged: false };
states.set(child, state);
watched.add(child);
}
return state;
}
async function stopOnce(child: ChildProcess, state: State, signal: NodeJS.Signals, restarting = false) {
state.gracefulDeadline ??= Date.now() + options.gracefulTimeoutMs;
await state.owner.observe();
if (!exited(child) && !state.gracefulSent) {
state.gracefulSent = child.kill(signal);
}
while (Date.now() < state.gracefulDeadline) {
await state.owner.observe();
if (restarting && state.finalRequested) throw new Error("Final shutdown interrupted controller restart");
if (exited(child)) {
if (restarting) {
state.owner.assertRestartRunnerAlive();
if (!state.owner.restartCleanupGroups().size) return;
}
if (!state.owner.liveGroups().length) { state.owner.stopObserving(); return; }
// The leader is gone. Retire only descendants whose start identities
// we observed while they belonged to this server, including private groups.
const unsignaled = new Set((restarting ? [...state.owner.restartCleanupGroups()] : state.owner.liveGroups().map(group => group.processGroupId)).filter(pid => !state.groupSignals.has(pid)));
for (const pid of await state.owner.signal("SIGTERM", unsignaled)) state.groupSignals.add(pid);
}
await wait(25);
}
if (restarting) throw new Error("Controller restart did not retire non-durable children within its graceful deadline");
if (!state.escalationLogged) {
options.log(`\nPaperclip did not stop within ${options.gracefulTimeoutMs}ms; sending SIGKILL\n`);
state.escalationLogged = true;
}
if (runnerE2EServerDetached) await state.owner.signal("SIGKILL");
else if (!exited(child)) child.kill("SIGKILL");
state.forcedDeadline ??= finalForcedDeadline ?? Date.now() + options.forcedTimeoutMs;
do {
await state.owner.observe();
if (exited(child) && !state.owner.liveGroups().length) { state.owner.stopObserving(); return; }
await wait(25);
} while (Date.now() < state.forcedDeadline);
throw new Error("Paperclip server or observed descendants did not exit after SIGKILL");
}
const stop = (child: ChildProcess, signal: NodeJS.Signals = "SIGTERM"): Promise<void> => {
options.markExpectedStop(child);
const state = watch(child);
state.finalRequested = true;
state.promise ??= Promise.resolve().then(async () => {
if (state.restartPromise && !state.finalPhaseStarted) {
await state.restartPromise.catch(() => {});
state.finalPhaseStarted = true;
// A completed restart is a separate phase, not elapsed cleanup time.
state.gracefulDeadline = finalGraceDeadline ?? Date.now() + options.gracefulTimeoutMs;
state.forcedDeadline = undefined;
state.groupSignals.clear();
}
await stopOnce(child, state, signal);
state.finalComplete = true;
}).catch(async error => {
try {
await incompleteTreeFallback(error, child, state, state.gracefulDeadline!, options.forcedTimeoutMs);
} finally {
state.promise = undefined;
}
});
/* Retain the signal/deadline phase so a later audit can recover without
repeating the graceful signal. */
return state.promise;
};
return Object.assign(stop, {
assertGracefulExit: (child: ChildProcess): void => {
const state = states.get(child);
if (!state?.finalComplete || state.escalationLogged || child.exitCode !== 0 || child.signalCode !== null) {
throw new Error("Controller did not exit gracefully; forced cleanup cannot qualify a rolling deployment");
}
},
watch: (child: ChildProcess) => watch(child).owner.observe(),
crashForRestart: (child: ChildProcess): Promise<void> => {
if (process.platform === "win32") return Promise.reject(new Error("Owned crash restart requires process-group inspection"));
options.markExpectedStop(child);
const state = watch(child);
if (state.finalRequested || state.restartPromise) return Promise.reject(new Error("Restart already requested or final cleanup active"));
state.restartPromise = (async () => {
state.gracefulDeadline = Date.now() + options.forcedTimeoutMs;
await state.owner.signal("SIGKILL");
await stopOnce(child, state, "SIGKILL");
})();
return state.restartPromise;
},
forRestart: (child: ChildProcess, identity: RestartRunnerIdentity): Promise<void> => {
options.markExpectedStop(child);
const state = watch(child);
if (state.finalRequested || state.restartPromise) return Promise.reject(new Error("Restart already requested or final cleanup active"));
state.restartPromise = (async () => {
await state.owner.preserveRunnerForRestart(identity);
options.log(`Controller restart preserves admitted runner pid=${identity.processPid} pgid=${identity.processGroupId} started=${identity.processStartedAt}\n`);
await stopOnce(child, state, "SIGTERM", true);
})();
return state.restartPromise;
},
stopAll: (signal: NodeJS.Signals = "SIGTERM"): Promise<void> => {
// Replacement controller drain precedes old daemon retirement. All
// generations share the original final-cleanup window, including retries.
finalGraceDeadline ??= Math.min(Date.now() + options.gracefulTimeoutMs,
...[...watched].map(child => states.get(child)!).filter(state => state.finalRequested && !state.finalComplete
&& (!state.restartPromise || state.finalPhaseStarted)).map(state => state.gracefulDeadline ?? Infinity));
finalForcedDeadline ??= finalGraceDeadline + options.forcedTimeoutMs;
for (const child of watched) {
const state = states.get(child)!;
state.finalRequested = true;
state.gracefulDeadline ??= finalGraceDeadline;
}
finalAllPromise ??= Promise.resolve().then(async () => {
const failures: unknown[] = [];
for (const child of [...watched].reverse()) {
try { await stop(child, signal); } catch (error) { failures.push(error); }
}
if (failures.length) throw new AggregateError(failures, "Owned server cleanup incomplete");
}).catch(error => { finalAllPromise = undefined; throw error; });
return finalAllPromise;
},
});
}