Files
PaperClipAI/tests/runner-e2e/instance-isolation.ts
T
f4337bb5fb test(evals): land the chat catalog eval harness on master (#19614)
## Thinking Path

> - Paperclip is the open source app people use to manage AI agents for
work
> - The chat-feature evals measure whether agents complete real chat
requests through the product
> - The chat catalog eval harness and its repairs live on the
`chat-eval/master-candidate` branch, not on master
> - Today's work made 139 of 242 chat evals pass in verified single-case
live runs. Each product fix landed on master as its own pull request
> - The eval-side changes (setups, graders, fault seams, evidence
capture) still exist only on the candidate
> - This pull request lands the harness on master. Master stays the
source of truth for product behavior
> - The benefit is one tree: evals run against master commits, and
product fixes reach the evals as soon as they merge

## Linked Issues or Issue Description

Refs #19441, Refs #19599, Refs #20270, Refs #20334, Refs #20342, Refs
#20344, Refs #20354, Refs #20360, Refs #20373, Refs #20382, Refs #20409

**What existing behavior does this improve?**
The chat catalog eval harness and the product it evaluates live on a
long-running branch outside master. Eval fixes do not reach master, so
master-based eval runs use old setups and graders.

**Subsystem affected**
`tests/runner-e2e` chat catalog harness, plus a small set of product
changes that exist only on the candidate.

**Proposed change**
Land the harness on master. Every product fix from this eval work
already merged to master as its own pull request. Conflicts keep
master's product behavior.

## What Changed

- Most of the diff (808 of 851 files) is under `tests/runner-e2e/`:
chat-catalog domains, scenarios, descriptors, the TestOps manifest,
private evidence tooling, and their tests.
- Graders now check saved state, setup literals and rendered or clicked
links. Many keyword and regex checks on free-form replies are removed.
Each changed grader has a bumped `oracleVersion` and calibration tests
(a valid reply, a reworded valid reply, and broken variants that must
fail).
- The shared link helper `hasLink` no longer treats a list link (for
example `/COM/issues?view=mine`) as a link to every task without a URL
key.
- Setup fixes build real state through supported product routes: routine
history, agent grants through the board grant route, budget holds with a
real cap, and a storage-layer archive fault for
`inbox-search.archive-partial-failure`.
- Browser boundary journeys (sign-in, chat-disabled, onboarding) now
write the standard pass evidence files.
- Retargeted cases, approved by the maintainer:
`agent-chat.chat-disabled` (Conference Room gate),
`agents.restore-instructions` (no saved instruction history),
`access.manage-membership` (member permission edits stay board-only).
- The private evidence trusted files (`manual-private-handoff.ts`,
`manual-private-retention.ts`, `manual-private-report-assets.ts`) are
byte-identical to master.
- Product files outside `tests/` (43 files, +1,328 −49) carry
candidate-only changes that master does not yet have. Most are tests.
The main code changes are in `request-human-input.ts`,
`heartbeat-run-summary.ts`, `native-completion-feedback.ts`,
`native-run-finalizer.ts`, `openapi.ts`, `secrets.ts` and
`IssueChatLongThreadPerf.tsx`.

## Verification

- `pnpm vitest run chat-catalog-domains chat-catalog-contract.test.ts
chat-catalog-consistency.test.ts unit-launcher.test.mjs
--testTimeout=180000` in `tests/runner-e2e`: 269 files pass, 3,550 tests
pass.
- `node --test chat-full-catalog-testops-manifest.test.mjs`: 10 pass.
- `node tests/runner-e2e/source-sdk-public-inputs.mjs <HEAD> --check`:
no change.
- `tsc` for `server` and `tests/runner-e2e`: clean.
- Live single-case verification: 139 of 242 cases passed on paid runs,
and a person read the saved evidence for each. These are single-case
runs, not one full-cohort run.

## Risks

- Large diff. Most of it is test-only, but the 43 non-test files change
product code paths. Review those files first.
- Some graders are now less strict on reply wording. A person must read
replies for meaning on those cases.
- 42 cases need disposable outside accounts (Notion, Slack, GitHub,
Daytona and others) and stay blocked. `access.invite-teammate` stays
failing until local agent isolation lands, because the runner's durable
state keeps a live invite token.
- The paid workflow compares the trusted private-evidence files with
master. They are unchanged, so this risk is low.

## Model Used

Anthropic Claude Opus 5.5 (`claude-opus-5-5`), with tool use and code
execution, in Claude Code. Subagents used the same model.

## Checklist

- [x] I have included a thinking path that traces from project context
to this change
- [x] I have specified the model used (with version and capability
details)
- [x] I have checked ROADMAP.md and confirmed this PR does not duplicate
planned core work
- [x] I have searched GitHub for duplicate or related PRs and linked
them above
- [x] I have either (a) linked existing issues with `Fixes: #` / `Closes
#` / `Refs #` OR (b) described the issue in-PR following the relevant
issue template
- [x] I have not referenced internal/instance-local Paperclip issues or
links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip`
URLs)
- [x] My branch name describes the change (e.g. `docs/...`, `fix/...`)
and contains no internal Paperclip ticket id or instance-derived details
- [x] I have run tests locally and they pass
- [x] I have added or updated tests where applicable
- [x] I have updated relevant documentation to reflect my changes
- [x] I have considered and documented any risks above
- [ ] All Paperclip CI gates are green
- [ ] Greptile is 5/5 with no open P2s, recommendations, or follow-ups
- [x] I will address all Greptile and reviewer comments before
requesting merge

🤖 Generated with [Claude Code](https://claude.com/claude-code)

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Paperclip <noreply@paperclip.ing>
2026-11-10 08:02:11 -06:00

132 lines
6.5 KiB
TypeScript

import { readDockerDatabaseReceipt, type DockerRun } from "./docker-postgres.js";
import path from "node:path";
import { readFile, realpath, stat, writeFile } from "node:fs/promises";
const CONTROLLER_DATABASE_OWNER_FILE = ".runner-e2e-controller-owner.json";
/** Written only after the supervisor has started this fixture's Postgres. */
export async function recordControllerDatabaseOwnership(input: {
configPath: string; temporaryRoot: string; dataDirectory: string; connectionString: string;
externalDatabaseName?: string;
}) {
const temporaryRoot = await realpath(input.temporaryRoot);
const dataDirectory = await realpath(input.dataDirectory);
if (!dataDirectory.startsWith(`${temporaryRoot}${path.sep}`)) {
throw new Error("Controller database path escaped its fixture-owned root");
}
await writeFile(path.join(dataDirectory, CONTROLLER_DATABASE_OWNER_FILE), JSON.stringify({
version: input.externalDatabaseName ? 2 : 1, externalDatabaseName: input.externalDatabaseName,
configPath: await realpath(input.configPath), temporaryRoot,
dataDirectory, connectionString: input.connectionString,
}), { mode: 0o600 });
}
/** True only for a launcher-created external database recorded for this exact config. */
export async function isOwnedExternalControllerDatabase(configPath: string, temporaryRoot: string, database: { connectionString?: unknown; embeddedPostgresDataDir?: unknown }) {
if (typeof database.connectionString !== "string" || typeof database.embeddedPostgresDataDir !== "string") return false;
try {
const owner = JSON.parse(await readFile(path.join(database.embeddedPostgresDataDir, CONTROLLER_DATABASE_OWNER_FILE), "utf8"));
return owner.version === 2 && /^runner_e2e_[a-f0-9]{32}$/.test(owner.externalDatabaseName)
&& new URL(database.connectionString).pathname === `/${owner.externalDatabaseName}`
&& owner.connectionString === database.connectionString
&& owner.configPath === await realpath(configPath) && owner.temporaryRoot === await realpath(temporaryRoot);
} catch { return false; }
}
export async function assertRunnerDatabaseIsolation(
configPath: string,
temporaryRoot: string,
dockerReceiptPath?: string,
dockerRun?: DockerRun,
) {
const configText = await readFile(configPath, "utf8");
const config = JSON.parse(configText) as {
database?: {
mode?: string;
connectionString?: string;
embeddedPostgresDataDir?: string;
embeddedPostgresPort?: number;
backup?: { dir?: string };
};
logging?: { logDir?: string };
storage?: {
provider?: string;
localDisk?: { baseDir?: string };
};
secrets?: {
provider?: string;
strictMode?: boolean;
localEncrypted?: { keyFilePath?: string };
};
};
if (!config.database) throw new Error("Runner E2E config omitted its database");
const docker = dockerReceiptPath ? await readDockerDatabaseReceipt(dockerReceiptPath, temporaryRoot, dockerRun) : undefined;
const supervised = !docker && config.database?.mode === "postgres";
if (docker ? config.database?.mode !== "postgres" || config.database.connectionString !== docker.connectionString : !config.database || (!supervised &&
(config.database.mode !== "embedded-postgres" || config.database.connectionString))) {
throw new Error("Runner E2E Paperclip instance did not use its fixture-owned database lane");
}
if (
config.storage?.provider !== "local_disk" ||
config.secrets?.provider !== "local_encrypted" ||
config.secrets.strictMode !== true
) {
throw new Error(
"Runner E2E instance did not use isolated local storage and strict encrypted secrets",
);
}
const isolatedPaths = {
...(docker ? {} : { database: config.database.embeddedPostgresDataDir }),
backup: config.database.backup?.dir,
logs: config.logging?.logDir,
storage: config.storage.localDisk?.baseDir,
secretsKey: config.secrets.localEncrypted?.keyFilePath,
};
for (const [label, configuredPath] of Object.entries(isolatedPaths)) {
if (!configuredPath) {
throw new Error(`Runner E2E config omitted its ${label} path`);
}
const resolved = path.resolve(configuredPath);
if (!resolved.startsWith(`${temporaryRoot}${path.sep}`)) {
throw new Error(
`Runner E2E ${label} path escaped the isolated root: ${resolved}`,
);
}
}
if (!docker) {
const databasePath = path.resolve(isolatedPaths.database!);
if (supervised) {
try {
const root = await realpath(temporaryRoot);
const directory = await realpath(databasePath);
if (!directory.startsWith(`${root}${path.sep}`)) throw new Error("Database escaped fixture");
const owner = JSON.parse(await readFile(path.join(directory, CONTROLLER_DATABASE_OWNER_FILE), "utf8"));
const port = config.database.embeddedPostgresPort;
const connection = new URL(config.database.connectionString!);
const external = owner.version === 2 && /^runner_e2e_[a-f0-9]{32}$/.test(owner.externalDatabaseName)
&& ["postgres:", "postgresql:"].includes(connection.protocol)
&& ["127.0.0.1", "localhost", "[::1]"].includes(connection.hostname)
&& connection.pathname === `/${owner.externalDatabaseName}`;
const embedded = owner.version === 1 && Number.isInteger(port) && Number(port) > 0 && Number(port) <= 65535
&& config.database.connectionString === `postgres://paperclip:paperclip@127.0.0.1:${port}/paperclip`
&& (await stat(path.join(directory, "PG_VERSION"))).isFile();
if ((!external && !embedded) || owner.temporaryRoot !== root || owner.dataDirectory !== directory
|| owner.configPath !== await realpath(configPath) || owner.connectionString !== config.database.connectionString) {
throw new Error("Supervisor database ownership mismatch");
}
} catch (cause) {
throw new Error("Runner E2E Paperclip instance did not use its fixture-owned database lane", { cause });
}
}
const databaseStat = await stat(databasePath);
if (!databaseStat.isDirectory())
throw new Error("Embedded database path is not a directory");
}
const keyStat = await stat(path.resolve(isolatedPaths.secretsKey!));
if (!keyStat.isFile())
throw new Error("Encrypted-secrets master key path is not a file");
}
/** The compatibility entry point still requires an owned controller/embedded database. */
export async function assertEmbeddedDatabaseIsolation(configPath: string, temporaryRoot: string) { return assertRunnerDatabaseIsolation(configPath, temporaryRoot); }