Files
PaperClipAI/tests/runner-e2e/server-entry.ts
T
f4337bb5fb test(evals): land the chat catalog eval harness on master (#19614)
## Thinking Path

> - Paperclip is the open source app people use to manage AI agents for
work
> - The chat-feature evals measure whether agents complete real chat
requests through the product
> - The chat catalog eval harness and its repairs live on the
`chat-eval/master-candidate` branch, not on master
> - Today's work made 139 of 242 chat evals pass in verified single-case
live runs. Each product fix landed on master as its own pull request
> - The eval-side changes (setups, graders, fault seams, evidence
capture) still exist only on the candidate
> - This pull request lands the harness on master. Master stays the
source of truth for product behavior
> - The benefit is one tree: evals run against master commits, and
product fixes reach the evals as soon as they merge

## Linked Issues or Issue Description

Refs #19441, Refs #19599, Refs #20270, Refs #20334, Refs #20342, Refs
#20344, Refs #20354, Refs #20360, Refs #20373, Refs #20382, Refs #20409

**What existing behavior does this improve?**
The chat catalog eval harness and the product it evaluates live on a
long-running branch outside master. Eval fixes do not reach master, so
master-based eval runs use old setups and graders.

**Subsystem affected**
`tests/runner-e2e` chat catalog harness, plus a small set of product
changes that exist only on the candidate.

**Proposed change**
Land the harness on master. Every product fix from this eval work
already merged to master as its own pull request. Conflicts keep
master's product behavior.

## What Changed

- Most of the diff (808 of 851 files) is under `tests/runner-e2e/`:
chat-catalog domains, scenarios, descriptors, the TestOps manifest,
private evidence tooling, and their tests.
- Graders now check saved state, setup literals and rendered or clicked
links. Many keyword and regex checks on free-form replies are removed.
Each changed grader has a bumped `oracleVersion` and calibration tests
(a valid reply, a reworded valid reply, and broken variants that must
fail).
- The shared link helper `hasLink` no longer treats a list link (for
example `/COM/issues?view=mine`) as a link to every task without a URL
key.
- Setup fixes build real state through supported product routes: routine
history, agent grants through the board grant route, budget holds with a
real cap, and a storage-layer archive fault for
`inbox-search.archive-partial-failure`.
- Browser boundary journeys (sign-in, chat-disabled, onboarding) now
write the standard pass evidence files.
- Retargeted cases, approved by the maintainer:
`agent-chat.chat-disabled` (Conference Room gate),
`agents.restore-instructions` (no saved instruction history),
`access.manage-membership` (member permission edits stay board-only).
- The private evidence trusted files (`manual-private-handoff.ts`,
`manual-private-retention.ts`, `manual-private-report-assets.ts`) are
byte-identical to master.
- Product files outside `tests/` (43 files, +1,328 −49) carry
candidate-only changes that master does not yet have. Most are tests.
The main code changes are in `request-human-input.ts`,
`heartbeat-run-summary.ts`, `native-completion-feedback.ts`,
`native-run-finalizer.ts`, `openapi.ts`, `secrets.ts` and
`IssueChatLongThreadPerf.tsx`.

## Verification

- `pnpm vitest run chat-catalog-domains chat-catalog-contract.test.ts
chat-catalog-consistency.test.ts unit-launcher.test.mjs
--testTimeout=180000` in `tests/runner-e2e`: 269 files pass, 3,550 tests
pass.
- `node --test chat-full-catalog-testops-manifest.test.mjs`: 10 pass.
- `node tests/runner-e2e/source-sdk-public-inputs.mjs <HEAD> --check`:
no change.
- `tsc` for `server` and `tests/runner-e2e`: clean.
- Live single-case verification: 139 of 242 cases passed on paid runs,
and a person read the saved evidence for each. These are single-case
runs, not one full-cohort run.

## Risks

- Large diff. Most of it is test-only, but the 43 non-test files change
product code paths. Review those files first.
- Some graders are now less strict on reply wording. A person must read
replies for meaning on those cases.
- 42 cases need disposable outside accounts (Notion, Slack, GitHub,
Daytona and others) and stay blocked. `access.invite-teammate` stays
failing until local agent isolation lands, because the runner's durable
state keeps a live invite token.
- The paid workflow compares the trusted private-evidence files with
master. They are unchanged, so this risk is low.

## Model Used

Anthropic Claude Opus 5.5 (`claude-opus-5-5`), with tool use and code
execution, in Claude Code. Subagents used the same model.

## Checklist

- [x] I have included a thinking path that traces from project context
to this change
- [x] I have specified the model used (with version and capability
details)
- [x] I have checked ROADMAP.md and confirmed this PR does not duplicate
planned core work
- [x] I have searched GitHub for duplicate or related PRs and linked
them above
- [x] I have either (a) linked existing issues with `Fixes: #` / `Closes
#` / `Refs #` OR (b) described the issue in-PR following the relevant
issue template
- [x] I have not referenced internal/instance-local Paperclip issues or
links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip`
URLs)
- [x] My branch name describes the change (e.g. `docs/...`, `fix/...`)
and contains no internal Paperclip ticket id or instance-derived details
- [x] I have run tests locally and they pass
- [x] I have added or updated tests where applicable
- [x] I have updated relevant documentation to reflect my changes
- [x] I have considered and documented any risks above
- [ ] All Paperclip CI gates are green
- [ ] Greptile is 5/5 with no open P2s, recommendations, or follow-ups
- [x] I will address all Greptile and reviewer comments before
requesting merge

🤖 Generated with [Claude Code](https://claude.com/claude-code)

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Paperclip <noreply@paperclip.ing>
2026-11-10 08:02:11 -06:00

100 lines
5.7 KiB
TypeScript

import { CHAT_SETUP_HEALTH_ID } from "./chat-setup-health.js";
import { installChatReadinessObserver } from "./chat-readiness-observer.js";
// This entrypoint is used only by isolated Runner E2E instances. Production
// service code has no test flag, delay, altered prompt, or private test API.
import { ServerResponse } from "node:http";
import path from "node:path";
import { installAgentFilesystemSandbox } from "./agent-filesystem-sandbox.js";
import { PaperclipRunnerToolAuthority } from "../../server/src/services/native-runtime/paperclip-runner-tool-authority.js";
import { canonicalDocumentIssueId, contextCommentGateSelected, holdCommittedDocumentResponse, isArmed } from "./context-comment-gate.js";
import { holdInteractionResponse } from "./interaction-response-gate.js";
import { installOwnedEmailResponseLoss } from "./chat-catalog-domains/runtime-email-fault.js";
import { installOwnedEmailReceiptDuplicate } from "./chat-catalog-domains/runtime-email-duplicate.js";
const ids: string[] = JSON.parse(process.env.PAPERCLIP_RUNNER_E2E_EXECUTION_IDS ?? "[]");
if (ids.length && ids.every(id => id === CHAT_SETUP_HEALTH_ID || id.startsWith("chat-features.runner-opencode.local."))) {
const { requireServerAdapter } = await import("../../server/src/adapters/index.js");
await installChatReadinessObserver({ executionIds: ids, temporaryRoot: process.env.PAPERCLIP_RUNNER_E2E_TEMP_ROOT ?? "",
adapter: requireServerAdapter("paperclip_runner") });
}
await installOwnedEmailResponseLoss({ executionIds: ids, attemptId: process.env.PAPERCLIP_E2E_ACCOUNTING_ATTEMPT_ID ?? "", temporaryRoot: process.env.PAPERCLIP_RUNNER_E2E_TEMP_ROOT ?? "" });
await installOwnedEmailReceiptDuplicate({ executionIds: ids, attemptId: process.env.PAPERCLIP_E2E_ACCOUNTING_ATTEMPT_ID ?? "", temporaryRoot: process.env.PAPERCLIP_RUNNER_E2E_TEMP_ROOT ?? "" });
const contextCommentGate = contextCommentGateSelected(ids);
const completionBusyGate = ids.some(id => id.startsWith("completion-updates.") && id.endsWith(".handoff-completion-busy"));
if (ids.some((id) => id.endsWith(".accept-while-running"))) {
const held = new Set<string>();
const hold = async (value: any) => {
const interaction = value?.interaction ?? value;
if (!interaction?.sourceRunId || interaction.status !== "pending" ||
!["request_confirmation", "request_checkbox_confirmation"].includes(interaction.kind) || held.has(interaction.id)) return;
held.add(interaction.id);
await holdInteractionResponse({
deadlineAt: Date.now() + 90_000,
loadStatus: async () => {
const response = await fetch(`http://127.0.0.1:${process.env.PAPERCLIP_RUNNER_E2E_PORT}/api/issues/${interaction.issueId}/interactions`);
if (!response.ok) throw new Error(`Approval barrier read failed: ${response.status}`);
const rows = await response.json() as Array<{ id: string; status: string }>;
const row = rows.find((candidate) => candidate.id === interaction.id);
if (!row) throw new Error("Approval barrier lost its committed card");
return row.status;
},
});
};
const execute = PaperclipRunnerToolAuthority.prototype.execute;
PaperclipRunnerToolAuthority.prototype.execute = async function (...args) {
const result = await execute.apply(this, args);
if (args[0].tool === "request_human_input") await hold(result);
return result;
};
const end = ServerResponse.prototype.end;
ServerResponse.prototype.end = function (this: ServerResponse, ...args: any[]) {
const body = args[0];
let interaction: any;
if (this.req.method === "POST" && /\/interactions(?:\?|$)/.test(this.req.url ?? "") &&
this.statusCode >= 200 && this.statusCode < 300 && (typeof body === "string" || Buffer.isBuffer(body))) {
try { interaction = JSON.parse(body.toString()); } catch { /* non-JSON response */ }
}
if (interaction?.sourceRunId && ["request_confirmation", "request_checkbox_confirmation"].includes(interaction.kind)) {
void hold(interaction).then(() => Reflect.apply(end, this, args), (error) => this.destroy(error));
return this;
}
return Reflect.apply(end, this, args);
} as typeof end;
}
if (contextCommentGate || completionBusyGate) {
const heldIssues = new Set<string>();
const holdFirstDocument = async (issueId: string) => {
if (heldIssues.has(issueId) || (!contextCommentGate && !await isArmed(issueId))) return;
heldIssues.add(issueId);
await holdCommittedDocumentResponse(issueId, Date.now() + (completionBusyGate ? 300_000 : 90_000));
};
const execute = PaperclipRunnerToolAuthority.prototype.execute;
PaperclipRunnerToolAuthority.prototype.execute = async function (...args) {
const result = await execute.apply(this, args);
if (args[0].tool === "write_document") {
const issueId = this.binding?.issueId;
if (typeof issueId === "string") await holdFirstDocument(issueId);
}
return result;
};
const end = ServerResponse.prototype.end;
ServerResponse.prototype.end = function (this: ServerResponse, ...args: any[]) {
const body = args[0];
const request = this.req as typeof this.req & { originalUrl?: string };
const issueId = this.req.method === "PUT"
? canonicalDocumentIssueId(request.url, body, request.originalUrl)
: undefined;
if (issueId && this.statusCode >= 200 && this.statusCode < 300) {
void holdFirstDocument(decodeURIComponent(issueId)).then(
() => Reflect.apply(end, this, args),
(error) => this.destroy(error),
);
return this;
}
return Reflect.apply(end, this, args);
} as typeof end;
}
// Before the product starts any agent, hide the eval harness from runnerd and its descendants.
installAgentFilesystemSandbox(path.resolve(import.meta.dirname, "../.."));
await import("../../cli/src/index.js");