mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-11-04 19:28:46 +01:00
## Thinking Path > - Paperclip manages work for AI agents. > - An environment plugin can own a Runner task. > - The merged launch-preparation contract lets the execution owner build the provider configuration. > - Core still needs a task process owner and a setup test that uses that configuration. > - This PR connects the task API to the Runner process-owner contract. > - Operators can test a plugin environment before Core sends it task work. ## Linked Issues or Issue Description **Subsystem affected** Runner, plugin SDK, and agent environment tests. **Problem or motivation** A task-only environment cannot use the shell-based setup path. Core must verify the Runner hello exchange and process cleanup through dedicated task operations. **Proposed solution** Add a lease-bound task driver and use it for a bounded setup probe. Keep heartbeat admission and task execution in #16978. This PR follows the merged launch-preparation contract in #16997. **Alternatives considered** A provider declaration alone cannot prove that Runner and the provider connect. A shell bridge would give the plugin an unnecessary command interface. ## What Changed - Pass structured Runner launch data to process owners. Support an external connection and explicit detach. - Add typed launch authentication checks and checkpoint operations. Check lease, run, project, and retained-task authority. - Connect launch preparation, PRP, termination proof, and credential handoff to the task driver. Reject local environment overrides during installed-account setup. Pass saved-account identity and credential home directly from Core. - Run a short-lived setup probe through the existing agent environment test API. Require a verified provider hello and cleanup. Keep saved Copilot account checks metadata-only through a dedicated task operation. - Update the Copilot source identity because the shared transport source changed. Keep provider behavior and the earlier identity fixture. ## Verification - CI passes on `f987adec7`: 55 successful checks and 5 expected skips. Standard Greptile and Apex are both 5/5 with no open findings. The branch merges cleanly with current master. - Repository typecheck and build pass after the rebase onto the workspace-provider contract. Server typecheck and build also pass after the final setup fix. - The 110 focused lease, SDK, setup, Copilot, and route cases pass after the rebase. All 14 setup cases pass after the final change. These include a real local Runner with a test provider. The saved-agent model-discovery case also passes. - Apex found that Core's relative workspace marker failed the driver path check, and non-Codex sessions omitted the observed model. Both failures were reproduced and fixed. The probe leaves physical workspace selection to plugin preparation. The transport reads each provider's observed model and exposes it to the driver. All 14 setup cases, 6 transport peer cases, and both existing real Runner/OpenCode cases pass. Runner build and server typecheck pass. - The coverage audit removed two redundant cases, repeated fixture code, and two extra real Runner launches. It kept authorization, credential selection, cancellation, lost replies, termination proof, checkpoint identity, and provider setup checks. - The Copilot source-identity check passes. The added-line secret and PII scan passes. The unmerged v52 attestation was regenerated after the shared transport fix. - CI on `13faeff02` caught one stale Copilot digest assertion after attestation regeneration. The literal now matches the candidate attestation, and all 49 installation cases pass. That CI lane otherwise passed 1,818 cases. - An earlier CI run hit an unchanged UI toast timing test. The separate fix is tracked in #16952. Current CI passes that shard. CI also caught a stale model-discovery assertion in this change; the assertion is fixed. - The local full-suite run was stopped when master changed. The final CI run supplies exact-head full-suite validation. No live Cloud or provider test was run. ## Risks - Native hello tests require a saved Core account or the installed account. Local environment overrides are unsupported for installed-account probes and fail before the provider runs. - A native task provider must declare launch preparation and authentication-check version 1. It must keep the checked configuration fixed through submission. Core rejects providers that cannot make this guarantee. - A lost task reply does not prove process termination. Core retains grants until the provider proves termination and Core saves required state. - This PR does not enable native heartbeat dispatch through plugin environments. Cloud deployment and live provider validation remain separate. ## Model Used OpenAI Codex, GPT-6. The exact model ID and context window are not exposed in this session. Tool use includes code editing, local tests, and the GitHub CLI. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have described the issue in-PR following the relevant issue template - [x] I have not referenced internal/instance-local Paperclip issues or links - [x] My branch name describes the change and contains no internal issue details - [x] I have run focused tests locally and they pass - [x] I have added or updated tests where applicable - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] All Paperclip CI gates are green - [x] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I will address all Greptile and reviewer comments before requesting merge --------- Co-authored-by: Paperclip <noreply@paperclip.ing>
189 lines
9.7 KiB
Markdown
189 lines
9.7 KiB
Markdown
# Environment task API
|
|
|
|
An environment driver can provide a Runner task through a worker hook.
|
|
The task API has no shell command or file transfer operation.
|
|
|
|
This API is a server and worker contract. The agent environment test can verify
|
|
a task-capable provider. Native heartbeat dispatch is a separate integration.
|
|
|
|
## Declare the hook
|
|
|
|
Set `supportsTasks: true` on the environment driver in the plugin manifest.
|
|
Implement `onEnvironmentTask` with the SDK types:
|
|
|
|
```ts
|
|
import type {
|
|
PluginEnvironmentTaskParams,
|
|
PluginEnvironmentTaskResult,
|
|
} from "@paperclipai/plugin-sdk";
|
|
|
|
type TaskHook = (
|
|
params: PluginEnvironmentTaskParams,
|
|
) => Promise<PluginEnvironmentTaskResult>;
|
|
```
|
|
|
|
Core requires the `environment.drivers.register` capability, a ready plugin,
|
|
the manifest declaration, and the worker's `environmentTask` method.
|
|
The SDK validates each operation and its result before it returns the result.
|
|
See [the schemas](../../packages/plugins/sdk/src/environment-tasks.ts) for all fields.
|
|
|
|
## Operations
|
|
|
|
| Operation | Result | Required behavior |
|
|
| --- | --- | --- |
|
|
| `describe` | `description` | Return the installed Runner version and SHA-256 digest. |
|
|
| `prepare` | `prepared` | Prepare the provider configuration for the exact Core requirements. Do not start a process. |
|
|
| `submit` | `accepted` | Start the same opaque task at most once. Use the structured launch inputs. |
|
|
| `copilot_metadata` | `copilot_metadata` | Verify a Copilot account and model on a private setup lease. Send no prompt. |
|
|
| `connection` | `connection` | Return an authenticated WSS endpoint and its generation. |
|
|
| `status` | `status` | Report the phase and observed process termination. |
|
|
| `check_project_auth` | `project_auth` | Validate the prepared project configuration before managed credential transfer. |
|
|
| `read_state` | `state` | Read the exact retained Runner checkpoint. |
|
|
| `archive_state` | `state` | Archive suspended authority with an idempotent archive key. Keep provider session files. |
|
|
| `credentials` | `credentials` | Return the selected account after process termination. |
|
|
| `stop` | `accepted` | Stop the task and its descendants. Fence a delayed submission. |
|
|
| `complete` | `accepted` | Release task resources after Core saves required results. |
|
|
|
|
Each result must contain the task ID from the request. Core rejects a result
|
|
with a different ID or result kind. A WSS URL must have no user information,
|
|
query, or fragment. Return authentication in the secret headers.
|
|
|
|
`submit` contains the PRP version range, Runner identity, bootstrap ticket,
|
|
authorized project IDs, and optional launch limits. It can also contain a saved
|
|
task ID for session reuse and a typed Codex or Claude credential. Core does not
|
|
supply an executable command or a guest path.
|
|
|
|
## Launch preparation
|
|
|
|
A provider can return `launchPreparationVersion: 1` from `describe`.
|
|
Core can then send the `prepare` operation before `submit`.
|
|
|
|
The requirements contain the provider, model, policy, run identity, instructions,
|
|
and runtime context. They do not contain provider credentials or executable
|
|
choices. Resource paths identify source locations. The plugin must resolve them
|
|
for its execution environment.
|
|
|
|
The result contains a configuration ID, requirements digest, and provider
|
|
descriptor. The schema is `paperclip.runner.launch-requirements.v1`.
|
|
The digest is SHA-256 over the requirements JSON. Sort object keys in lexical
|
|
order at every level. Keep array order. Omit absent optional fields.
|
|
The execution owner must preserve Core policy and resource assignments.
|
|
|
|
Preparation must be idempotent for the task and requirements. The plugin owns
|
|
configuration storage and cleanup. A late preparation result must not authorize
|
|
execution after cancellation. The `submit` operation can reference the saved
|
|
configuration with `preparedLaunchId`.
|
|
|
|
Recovery can supply the prior prepared result. Recovery within the same run
|
|
must use the same configuration. A different run supplies its current
|
|
requirements. A saved task ID in `resumeFrom` requires the same retained-session
|
|
authority as submission.
|
|
|
|
Core requires preparation version 1 for native plugin execution. It validates
|
|
and saves the result before it submits its configuration ID.
|
|
|
|
## Launch authentication validation
|
|
|
|
Declare `projectAuthCheckVersion: 1` in `describe` for each native task launch.
|
|
Core calls `check_project_auth` after preparation and before credential transfer.
|
|
The request names the configuration ID, provider, and authorized project IDs.
|
|
It contains no credential.
|
|
|
|
The plugin must check the effective configuration for that prepared launch.
|
|
Reject project settings, parent settings, helper commands, or environment routing
|
|
that can replace the selected account or redirect its credential.
|
|
Keep the checked configuration fixed until submission. If the configuration can
|
|
change, reject submission and require new preparation and validation.
|
|
|
|
Return `project_auth` with the same configuration ID and provider.
|
|
Set `allowed: true` only after the checks pass.
|
|
Core saves this result on the task lease. Core requires the exact configuration,
|
|
provider, and project set before each submission. This also applies when the
|
|
provider uses an installed account.
|
|
A new preparation or check removes the prior validation. A failed check does not
|
|
authorize credential transfer. The dispatch update also checks that validation
|
|
has not changed while Core waited for database work.
|
|
|
|
## Retained checkpoint operations
|
|
|
|
`read_state` supplies the exact durable identity and an optional `resumeFrom`.
|
|
`archive_state` supplies the prior identity, a 24-character lowercase hexadecimal
|
|
archive key, and `resumeFrom`. Both return `state` with the task ID and Runner
|
|
state object. They do not accept a filesystem path.
|
|
|
|
Core authorizes retained sources with the same checks as preparation and launch.
|
|
The plugin must read only that task's state. Archive must require process
|
|
termination and exact suspended identity. It must return the same archived state
|
|
on retry. It must keep the provider session files. Return an error when the state
|
|
is absent or its identity differs. Do not return credentials or environment values.
|
|
|
|
## Lease authority
|
|
|
|
Core calls `environmentRuntimeService.task` with a company ID, a saved lease ID,
|
|
and an operation. It derives the plugin and driver from the lease. A change to
|
|
the environment configuration cannot redirect cleanup to a new provider.
|
|
|
|
Before preparation or submission, Core checks the active lease, run, issue, and every project
|
|
in the company. It checks the submitting run ID separately from a retained PRP
|
|
identity. Session reuse requires the same agent, environment, workspace, and
|
|
provider. It also requires a retained source task and proof of termination.
|
|
|
|
An internal setup probe can use a private, time-limited lease without a run row.
|
|
Core checks the saved probe identity, rejects project mounts, and limits the
|
|
Runner lifetime to the remaining probe time.
|
|
|
|
## Failure and cleanup
|
|
|
|
A failed submission reply does not prove that the task failed to start.
|
|
Core saves the dispatch marker before it calls the worker. Retry against the
|
|
same task ID. Do not allocate another task to resolve an uncertain reply.
|
|
|
|
An accepted stop does not prove termination. Set `executionStopped: true`
|
|
only after the Runner and all descendants have stopped. A terminal phase alone
|
|
does not permit Core to release execution authority.
|
|
|
|
Core fences new submissions when cleanup starts. It stops the saved task,
|
|
checks termination, saves credential results, and completes the task before it
|
|
releases or destroys the environment lease. An uncertain result leaves a saved
|
|
lease for the cleanup sweep. Cleanup can use that lease after the environment
|
|
or run row is deleted.
|
|
|
|
## Credential writeback
|
|
|
|
Account selection and credential revision have separate identities. Keep the
|
|
selected account fixed for the task. A credential result of `null` means that
|
|
cancellation prevented task admission. It must not mean that an export failed.
|
|
|
|
Core saves the account grant, secret reference, and session epoch on the lease.
|
|
It saves no credential bytes or temporary path in lease metadata. After process
|
|
termination, it can recover a Codex refresh even if Core restarted. It uses the
|
|
existing account comparison and secret service. A revoked grant, replaced
|
|
account, or changed session epoch discards the old refresh.
|
|
|
|
Keep file synchronization and backup outside this API. The provider must retain
|
|
recoverable credential state until task completion succeeds.
|
|
|
|
## Native environment test
|
|
|
|
The agent environment test can use a task-capable plugin environment. Core
|
|
creates a short-lived probe lease with a private run and session identity.
|
|
The probe has no project mounts or task tools. It prepares the launch, checks
|
|
authentication routing, and verifies the Runner and provider hello exchange.
|
|
A passing result requires confirmed cleanup. This test does not enable
|
|
heartbeat dispatch to plugin environments.
|
|
|
|
## Copilot account test
|
|
|
|
`copilot_metadata` accepts the selected token and an optional model ID. Core
|
|
permits it only on an active private setup lease. The provider must use the
|
|
verified Copilot metadata client. It must send no prompt and use no project
|
|
workspace or tool server. Return the metadata and `executionStopped: true` only
|
|
after the probe and its descendants stop. A lost reply keeps the task available
|
|
for `stop`, `status`, and `complete`. Core checks the profile and model before
|
|
it accepts the account. Do not store the token in task metadata or logs.
|
|
|
|
For a native hello probe, select a saved AI account or use the installed account.
|
|
Core rejects local environment overrides when no saved account is selected.
|
|
This includes draft credentials. The probe uses the installed VM environment. Core does not test a different installed account in their place.
|
|
Only Core can supply the selected account identity and local credential home.
|