mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-11-13 15:55:46 +01:00
## Thinking Path
> - Paperclip is the open source app people use to manage AI agents for
work
> - The board UI sidebar has a Recents list of the tasks a person opened
last
> - The Recents list renders from a local snapshot, but its links had no
warm-up. A click waited for the task-detail code and about nine
first-frame reads
> - Task lists (Inbox, Tasks) already warm a task on hover, press and
click, and #20355 added a batched `chat-bootstrap` read that had no UI
consumer
> - The hosted database is CPU-bound, so a fix must add at most one read
per page load and must not compete with the page's own reads
> - This pull request gives Recents the same open-intent prefetch as
task lists, warms the task-detail code, and preloads the top ten recent
tasks with one `chat-bootstrap` request after the page is idle
> - The benefit is that a click on a recent task shows its chat from
cache, without a wait for the API
## Linked Issues or Issue Description
Refs #20355 (server read this PR consumes). Builds on #20389, #20398 and
#20419.
**Is your feature request related to a problem?**
Opening a task from the sidebar's Recents was slower than opening it
from a task list. The Recents links had no prefetch. The task page
waited for its first-frame reads after the click.
**Describe the solution you'd like**
Recents links use the task lists' open-intent prefetch. When the page is
idle, one batched request loads the first frame of the most recent tasks
into the task page's caches.
**Describe alternatives you've considered**
Per-task prefetch of every recent task. That makes up to ten times nine
requests per page load, which the hosted database cannot afford.
**Additional context**
I searched open PRs and remote branches for "chat-bootstrap" and
"instant task opens". The only related work is the server-side branches
that merged as #20355. There is no other in-flight UI consumer of
`chat-bootstrap`.
## What Changed
- `ui/src/hooks/useIssueNavigationPrefetch.ts`: the open-intent handlers
from `IssueLinkQuicklook` move into one hook (light warm on pass-over;
`history: true` on a resting hover or focus, a mouse or pen press, and a
click). `IssueLinkQuicklook` now uses the hook. Its behavior does not
change.
- `ui/src/components/RecentTaskNavItem.tsx`: one Recents link wrapper
that applies the hook. The classic list (`SidebarRecentTasks`), the
Coordinator task rows and `DesignSidebar` use it. `SidebarNavItem`
accepts the handlers through a new optional `linkHandlers` prop.
- Classic Recents links now open `/issues/<identifier>` (Coordinator
already did). The old UUID link remounted the task page after a redirect
to the identifier route.
- `ui/src/hooks/useRecentTaskOpenWarmup.ts`: when Recents shows a task,
it fires the task-detail code warm-up (`useWarmTaskDetailCode`). After
two frames, a visible tab, no fetching queries and an idle callback, it
sends one `issues/chat-bootstrap?ids=` request for the ten most recent
tasks. It skips tasks whose first frame is cached and fresh. It sends no
request for an empty list or a hidden tab. It sends at most one request
per account per page load. Unmount or an account change aborts the
request.
- `ui/src/lib/issueChatBootstrapCache.ts`: `seedIssueChatBootstrap`
writes each field under the keys the task page reads, for the requested
ref, the id and the identifier: core issue, recent comments, comment
input facts (one batch, through the new `seedIssueIdBatch`), recent
activity, the recent run window (through the new shared
`buildRecentIssueRunWindow`), interactions, attachments, live runs and
active run. An explicit `null` active run is stored. A missing field is
not stored. It does not replace data that is as new or newer, data with
a read in flight, or data with a pending invalidation. Keys whose page
merges observed history (comments, activity, runs, input facts) are
filled only when empty. Items for another company are ignored.
- The seed fills the `?view=core` key, not the full detail key.
`seedIssueDetailCache` is not used: the core payload cannot stand in for
the detail read's related data, and seeding it there would suppress that
read.
- `issuesApi.chatBootstrap` client method.
- `tests/perf/collections/recent-task-open.spec.ts` and its README
section.
## Verification
Local disposable instance (`local_trusted`, production UI build,
embedded PostgreSQL, collection fixture plus 12 comments on each of 8
recent tasks, streamlined UI with the Coordinator sidebar). Journey:
open Projects with 8 Recents, wait for network idle plus 3 s, click a
recent task, measure until its latest comment is on screen. Each run
uses a fresh browser context (empty HTTP cache and storage apart from
Recents). Median of 5 runs, same server and fixture for both arms:
| Arm | Click to first chat frame | Idle page API requests |
| --- | --- | --- |
| `master` (b6f4008f9b), loopback | 227 ms (first run: 249 ms) | 24
(range 21–25) |
| This PR, loopback | 134 ms | 22 (range 21–27) |
| `master`, +150 ms on each API response | 455 ms | 19 |
| This PR, +150 ms on each API response | 135 ms | 20 (+1
`chat-bootstrap`) |
With added latency, the first frame no longer depends on API latency.
- `PAPERCLIP_COLLECTION_PERF_BASE_URL=http://127.0.0.1:<port> pnpm exec
playwright test --config tests/perf/collections/playwright.config.ts
recent-task-open.spec.ts recent-task-summaries.spec.ts`: 5 passed. On
`master` the two assertion cases fail (0 `chat-bootstrap` requests; 10
first-frame reads after the click).
- Reads that still follow a click on a preloaded task: full detail (`GET
/issues/:id`), `work-products`, `documents`, `feedback-votes`,
`tree-control/state`, `tree-holds`, `runner-goal`, `browsers`, and the
`read` mark. The `chat-bootstrap` payload does not cover them. None
gates the chat's first frame (the frame shows at 135 ms while every API
response waits 150 ms).
- Unit tests: `RecentTaskNavItem.test.tsx` (intent levels, href),
`useRecentTaskOpenWarmup.test.tsx` (one request for the top ten, code
warm-up, wait for page reads, hidden tab, fresh entries skipped, once
per account, user isolation, abort on unmount),
`issueChatBootstrapCache.test.ts` (each key in the endpoint shape,
`null` versus missing fields, company isolation, no downgrade of newer,
in-flight or invalidated data, merge keys filled only when empty).
- `ui` Vitest: `src/components src/hooks src/lib src/api` 694 files
passed; `src/pages src/App src/context` 188 files passed. `pnpm
check:token-gates`: clean. `pnpm verify` exits 2 because a `tests/` file
is a global CI input; required CI supplies the broad coverage.
## Risks
- Low to medium. One extra read per page load when Recents has tasks
without a fresh cached first frame. The read starts only after the
page's own queries settle, and the server reads at most two tasks at a
time.
- A live event that arrives while the preload is in flight, for a task
with no cached keys, can leave seeded data up to 30 s old until the next
live event or the next open after the stale time. Inbox hover prefetch
has the same window.
- Classic Recents links now use the identifier route instead of the UUID
route. The task page already redirected UUID links to this route.
- `tests/perf/collections` is a manual suite. CI does not run it.
## Model Used
- Claude Opus 5.5 (`claude-opus-5-5`), Anthropic, in Claude Code with
tool use (shell, file edits, browser automation through Playwright).
Standard context window.
## Checklist
- [x] I have included a thinking path that traces from project context
to this change
- [x] I have specified the model used (with version and capability
details)
- [x] I have checked ROADMAP.md and confirmed this PR does not duplicate
planned core work
- [x] I have searched GitHub for duplicate or related PRs and linked
them above
- [x] I have either (a) linked existing issues with `Fixes: #` / `Closes
#` / `Refs #` OR (b) described the issue in-PR following the relevant
issue template
- [x] I have not referenced internal/instance-local Paperclip issues or
links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip`
URLs)
- [x] My branch name describes the change (e.g. `docs/...`, `fix/...`)
and contains no internal Paperclip ticket id or instance-derived details
- [x] I have run tests locally and they pass
- [x] I have added or updated tests where applicable
- [x] I have updated relevant documentation to reflect my changes
- [x] I have considered and documented any risks above
- [ ] All Paperclip CI gates are green
- [ ] Greptile is 5/5 with no open P2s, recommendations, or follow-ups
- [ ] I will address all Greptile and reviewer comments before
requesting merge
🤖 Generated with [Claude Code](https://claude.com/claude-code)
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
131 lines
5.0 KiB
TypeScript
131 lines
5.0 KiB
TypeScript
import { useEffect, useRef } from "react";
|
|
import { useQueryClient, type QueryClient } from "@tanstack/react-query";
|
|
import { ISSUE_CHAT_BOOTSTRAP_MAX_IDS } from "@paperclipai/shared";
|
|
import { issuesApi } from "@/api/issues";
|
|
import { hasFreshIssueChatFirstFrame, seedIssueChatBootstrap } from "@/lib/issueChatBootstrapCache";
|
|
import { useWarmTaskDetailCode } from "./useWarmTaskDetailCode";
|
|
|
|
export type RecentTaskOpenWarmupTask = { id: string; identifier: string | null };
|
|
|
|
/** Accounts (company and user) whose Recents were preloaded during this page load. */
|
|
const preloadedScopes = new Set<string>();
|
|
|
|
export function resetRecentTaskChatPreloadForTests() {
|
|
preloadedScopes.clear();
|
|
}
|
|
|
|
const IDLE_TIMEOUT_MS = 2_000;
|
|
|
|
/**
|
|
* Run `start` once the page has painted, the tab is visible, no query is
|
|
* fetching (the page's own reads have finished) and the browser is idle.
|
|
* Returns a cancel function.
|
|
*/
|
|
function whenPageSettles(queryClient: QueryClient, start: () => void) {
|
|
const cleanups = new Set<() => void>();
|
|
const add = (cleanup: () => void) => cleanups.add(cleanup);
|
|
let done = false;
|
|
const cancel = () => {
|
|
done = true;
|
|
for (const cleanup of cleanups) cleanup();
|
|
cleanups.clear();
|
|
};
|
|
const step = () => {
|
|
if (done) return;
|
|
for (const cleanup of cleanups) cleanup();
|
|
cleanups.clear();
|
|
if (document.visibilityState !== "visible") {
|
|
const onVisible = () => { if (document.visibilityState === "visible") step(); };
|
|
document.addEventListener("visibilitychange", onVisible);
|
|
add(() => document.removeEventListener("visibilitychange", onVisible));
|
|
return;
|
|
}
|
|
if (queryClient.isFetching() > 0) {
|
|
add(queryClient.getQueryCache().subscribe(() => {
|
|
if (queryClient.isFetching() === 0) step();
|
|
}));
|
|
return;
|
|
}
|
|
const run = () => {
|
|
if (done) return;
|
|
// Something started while waiting for idle time: wait for it as well.
|
|
if (document.visibilityState !== "visible" || queryClient.isFetching() > 0) {
|
|
step();
|
|
return;
|
|
}
|
|
done = true;
|
|
cleanups.clear();
|
|
start();
|
|
};
|
|
if (typeof window.requestIdleCallback === "function") {
|
|
const handle = window.requestIdleCallback(run, { timeout: IDLE_TIMEOUT_MS });
|
|
add(() => window.cancelIdleCallback(handle));
|
|
} else {
|
|
const handle = window.setTimeout(run, 200);
|
|
add(() => window.clearTimeout(handle));
|
|
}
|
|
};
|
|
// Two frames: the page's primary content has painted.
|
|
let second: number | undefined;
|
|
const first = window.requestAnimationFrame(() => { second = window.requestAnimationFrame(step); });
|
|
add(() => {
|
|
window.cancelAnimationFrame(first);
|
|
if (second !== undefined) window.cancelAnimationFrame(second);
|
|
});
|
|
return cancel;
|
|
}
|
|
|
|
/**
|
|
* Make opening a recent task from the sidebar nearly instant.
|
|
*
|
|
* Once Recents has painted, warm the task-detail code as task lists do. Then,
|
|
* once the page is idle, read the chat's first frame for the most recent tasks
|
|
* in one `chat-bootstrap` request and seed it into the task page's caches.
|
|
* At most one request per account per page load; none for an empty list, a
|
|
* hidden tab or tasks whose first frame is already cached and fresh. Live
|
|
* updates keep seeded entries fresh afterwards, one task at a time.
|
|
*/
|
|
export function useRecentTaskOpenWarmup({
|
|
companyId,
|
|
userId,
|
|
tasks,
|
|
}: {
|
|
companyId: string | null | undefined;
|
|
userId: string | null | undefined;
|
|
tasks: readonly RecentTaskOpenWarmupTask[];
|
|
}) {
|
|
const queryClient = useQueryClient();
|
|
const hasTasks = tasks.length > 0;
|
|
useWarmTaskDetailCode(hasTasks);
|
|
// Read when the preload starts. A reorder must not cancel a request in flight.
|
|
const latestTasks = useRef(tasks);
|
|
latestTasks.current = tasks;
|
|
useEffect(() => {
|
|
if (!companyId || !hasTasks || typeof window.requestAnimationFrame !== "function") return;
|
|
const scope = `${companyId}:${userId ?? "__local_board__"}`;
|
|
if (preloadedScopes.has(scope)) return;
|
|
const controller = new AbortController();
|
|
const cancel = whenPageSettles(queryClient, () => {
|
|
if (preloadedScopes.has(scope)) return;
|
|
preloadedScopes.add(scope);
|
|
const ids = latestTasks.current
|
|
.slice(0, ISSUE_CHAT_BOOTSTRAP_MAX_IDS)
|
|
.filter((task) => !hasFreshIssueChatFirstFrame(queryClient, task.identifier ? [task.id, task.identifier] : [task.id]))
|
|
.map((task) => task.id);
|
|
if (!ids.length) return;
|
|
const requestedAt = Date.now();
|
|
// A synchronous throw (bad input) is also only a missed preload.
|
|
Promise.resolve().then(() => issuesApi.chatBootstrap(companyId, ids, { signal: controller.signal })).then((response) => {
|
|
if (controller.signal.aborted) return;
|
|
for (const item of response.items) seedIssueChatBootstrap(queryClient, item, { companyId, requestedAt });
|
|
}).catch(() => {
|
|
// Best effort: a task opened later reads its own first frame.
|
|
});
|
|
});
|
|
return () => {
|
|
cancel();
|
|
controller.abort();
|
|
};
|
|
}, [companyId, hasTasks, queryClient, userId]);
|
|
}
|