mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-10-31 22:24:16 +01:00
## Thinking Path > - Paperclip manages AI agents and needs reliable checks for each contribution. > - CI selects affected suites and then affected Vitest files before allocating runners. > - Recent runs compared a tested merge against a stale event base. > - That included unrelated master changes and sometimes reached the compare API file cap. > - Ordinary documentation also forced every suite and invalidated test caches. > - This PR reads complete merge trees and exempts a small set of audited prose inputs. > - Tests retain conservative coverage when the diff or an input is uncertain. ## Linked Issues or Issue Description Refs #18348 and #18214. This is a follow-up to the merged affected-test selector. Related CI performance work: #16513 and #16500 address setup and suite execution. This PR changes diff collection and input classification. ## What Changed - Fetch the exact tested merge and its parents into a temporary bare repository. Read the complete tree diff against the actual first parent. Validate the second parent against the event PR head. Never execute PR code in the routing job. - Carry the immutable base, merge and PR-head identities into the plan. Validate the same complete diff again before file selection. - Use one prose policy across the planner, Vitest selector and task cache adapter. Exempt only `doc/DEVELOPING.md`, `doc/DATABASE.md`, and Markdown under `doc/plans/`. - Keep the uncached typecheck and CLI guidance guard for the first two documents. Keep policy checks for historical plans. Keep existing coverage for all other docs, runtime skills, fixtures and unknown inputs. - Extend candidate-workflow qualification to exercise mixed source and prose changes. ## Verification - Passed: 15 planner and Git routing tests, including a 353-file diff, stale base, rename, deletion, wrong parent and fetch-failure cases. - Passed: 83 routing, Vitest graph, exact selection, workflow and real Turbo cache checks. - Passed: `pnpm -r typecheck` and `pnpm build`. - Full local `pnpm test:run` was attempted and stopped after repeated embedded PostgreSQL startup failures in native-session and Muse tests. It did not pass or complete. The exact cause remains unverified. The changed files do not include those tests or their database setup. Linux CI results are recorded below. - Passed: real mixed Inbox/source/prose graph qualification selected 699/911 workspace test files, preserving the source-only selection. - Passed: both GitHub CI qualification jobs, including real mixed source/prose Vitest selection. Greptile reviewed commit `10ac6f5ec9` at 5/5 with no findings. - First full CI attempt: the [chat shard](https://github.com/paperclipai/paperclip/actions/runs/41111003419/job/124253342684) received a runner shutdown signal. The [Runner shard](https://github.com/paperclipai/paperclip/actions/runs/41111003419/job/124253341271) failed the unchanged Antigravity authentication success assertion. All 11 cases in that file passed when run directly. That Runner lane does not use the changed selector/cache path. The exact assertion-failure cause remains unverified. The chat shard passed on the one retry. The authentication assertion also passed on retry, but the same Runner shard failed a different unchanged test: `native-distribution-integrity.test.ts:242`, "retains spawned native bytes until the exact child exits", exceeded 5000ms. The [retry log](https://github.com/paperclipai/paperclip/actions/runs/41111003419/job/124259174201) preserves the failure. The Runner shard and required verify aggregate are still red; all other checks passed. All 33 native-distribution tests then passed in a direct local run. This shows recovery in isolation, not the cause of the Linux timeout. No further blind reruns were issued. - Replayed 15 real recent PR merge commits through a blob-filtered bare fetch. Nine needed a corrected base. The four API comparisons that returned 300 filenames became complete diffs of 3, 57, 66 and 54 files. The 3-file case (#18326) becomes eligible for graph selection. Most other samples still correctly use full CI because they include inputs outside this narrow prose policy. - Cache proof: prose edits preserve a product-test cache hit; changing runtime API documentation invalidates it. ## Risks - Prose exceptions must be removed or revised if product code starts reading those files. The allowlist is deliberately small. Runtime docs and skills remain covered. - A network or Git failure keeps the full-suite fallback. Unexpected merge topology also keeps full CI. Stack and force-full policies remain in place. - This does not claim an end-to-end speedup yet. Many mixed-content PRs still require full CI. The routing fetch reads only shallow commit/tree objects; it does not check out or execute PR files. ## Model Used OpenAI Codex, GPT-6 family, with reasoning, repository tools and code execution. The exact served model ID and context-window size are not exposed to this session. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either (a) linked existing issues with `Fixes: #` / `Closes #` / `Refs #` OR (b) described the issue in-PR following the relevant issue template - [x] I have not referenced internal/instance-local Paperclip issues or links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip` URLs) - [x] My branch name describes the change (e.g. `docs/...`, `fix/...`) and contains no internal Paperclip ticket id or instance-derived details - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [ ] All Paperclip CI gates are green - [x] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I will address all Greptile and reviewer comments before requesting merge Co-authored-by: Paperclip <noreply@paperclip.ing>
189 lines
14 KiB
JavaScript
189 lines
14 KiB
JavaScript
import assert from "node:assert/strict";
|
|
import { execFileSync, spawnSync } from "node:child_process";
|
|
import { chmodSync, copyFileSync, existsSync, mkdtempSync, mkdirSync, readFileSync, readdirSync, rmSync, symlinkSync, writeFileSync } from "node:fs";
|
|
import { tmpdir } from "node:os";
|
|
import path from "node:path";
|
|
import test from "node:test";
|
|
|
|
import { executionPlan, sourceFiles } from "./execution-plan.mjs";
|
|
|
|
const repositoryRoot = new URL("../../", import.meta.url);
|
|
const turbo = process.env.PAPERCLIP_CI_TEST_TURBO ?? new URL("node_modules/.bin/turbo", repositoryRoot).pathname;
|
|
|
|
test("real Turbo keeps full runs and different selected test sets in separate cache entries", () => {
|
|
const directory = mkdtempSync(path.join(tmpdir(), "ci-selection-cache-"));
|
|
const write = (file, value) => writeFileSync(path.join(directory, file), value);
|
|
const json = (file, value) => write(file, JSON.stringify(value));
|
|
const git = (...args) => execFileSync("git", args, { cwd: directory, encoding: "utf8" }).trim();
|
|
try {
|
|
git("init", "-q");
|
|
for (const folder of ["scripts/ci", "server/src", "packages/fixture", "bin", ".ci-test-selection"]) mkdirSync(path.join(directory, folder), { recursive: true });
|
|
for (const file of ["run-task.mjs", "execution-plan.mjs", "test-selection-manifest.mjs"]) {
|
|
copyFileSync(new URL(`scripts/ci/${file}`, repositoryRoot), path.join(directory, "scripts/ci", file));
|
|
}
|
|
mkdirSync(path.join(directory, ".github/scripts"), { recursive: true });
|
|
copyFileSync(new URL(".github/scripts/ci-inputs.mjs", repositoryRoot), path.join(directory, ".github/scripts/ci-inputs.mjs"));
|
|
write(".gitignore", ".turbo/\n.ci-test-selection/\nresult.txt\ncalls.txt\n");
|
|
json("package.json", { name: "selection-cache-proof", private: true, packageManager: "npm@10.0.0", workspaces: ["packages/*"], scripts: { "test:run:general": "node check.cjs" } });
|
|
json("packages/fixture/package.json", { name: "fixture", private: true });
|
|
json("package-lock.json", { name: "selection-cache-proof", lockfileVersion: 3, packages: { "": { name: "selection-cache-proof" } } });
|
|
json("turbo.json", { globalDependencies: ["doc/**", "docs/**"], globalEnv: ["CI_TASK_CACHE_SCOPE", "PAPERCLIP_*"], tasks: {
|
|
"//#ci:server": { inputs: ["check.cjs", "server/**"], outputs: ["result.txt"], cache: true },
|
|
} });
|
|
mkdirSync(path.join(directory, "doc/plans"), { recursive: true });
|
|
mkdirSync(path.join(directory, "docs/api"), { recursive: true });
|
|
write("doc/DEVELOPING.md", "before"); write("doc/plans/example.md", "before");
|
|
write("docs/api/issues.md", "before");
|
|
write("server/src/a.test.ts", "// a"); write("server/src/b.test.ts", "// b");
|
|
write("check.cjs", `const fs=require('node:fs');fs.appendFileSync('calls.txt','call\\n');const file=process.env.PAPERCLIP_CI_TEST_SELECTION;fs.writeFileSync('result.txt',file?JSON.parse(fs.readFileSync(file)).lanes['general-server-without-chat'].shards[0]['@paperclipai/server'].join(','):'full');`);
|
|
write("bin/pnpm", `#!${process.execPath}\nconst {spawnSync}=require('node:child_process');const args=process.argv.slice(2);if(args[0]==='--version')console.log('9.15.4');else{const r=spawnSync(${JSON.stringify(turbo)},args.slice(2),{stdio:'inherit'});process.exit(r.status??1);}`);
|
|
chmodSync(path.join(directory, "bin/pnpm"), 0o755);
|
|
git("add", ".");
|
|
git("-c", "user.name=CI", "-c", "user.email=ci@example.invalid", "commit", "-qm", "fixture");
|
|
const head = git("rev-parse", "HEAD");
|
|
const calls = () => readFileSync(path.join(directory, "calls.txt"), "utf8").trim().split("\n").length;
|
|
const run = (testFile) => {
|
|
const selection = path.join(directory, ".ci-test-selection/manifest.json");
|
|
json(".ci-test-selection/manifest.json", { version: 1, head, lanes: {
|
|
"general-server-without-chat": { shards: [{ "@paperclipai/server": [testFile ?? "server/src/a.test.ts"] }] },
|
|
} });
|
|
const result = spawnSync(process.execPath, [path.join(directory, "scripts/ci/run-task.mjs")], {
|
|
cwd: directory, encoding: "utf8", env: { ...process.env, PATH: `${directory}/bin:${process.env.PATH}`,
|
|
CI_TASK: "ci:server", CI_TASK_ARGS: "[]", CI_FORCE_TASKS: "false", CI_TASK_DRY_RUN: "false",
|
|
PAPERCLIP_CI_TEST_SELECTION: testFile ? selection : "", PAPERCLIP_CI_SELECTION_HASH: "",
|
|
TURBO_TOKEN: "", TURBO_TEAM: "", TURBO_TELEMETRY_DISABLED: "1" },
|
|
});
|
|
assert.equal(result.status, 0, result.stdout + result.stderr);
|
|
assert.equal(readFileSync(path.join(directory, "result.txt"), "utf8"), testFile ?? "full");
|
|
};
|
|
run(); run(); assert.equal(calls(), 1);
|
|
write("doc/DEVELOPING.md", "after"); write("doc/plans/example.md", "after");
|
|
run(); assert.equal(calls(), 1, "audited prose does not invalidate product test results");
|
|
run("server/src/a.test.ts"); run("server/src/a.test.ts"); assert.equal(calls(), 2);
|
|
run("server/src/b.test.ts"); assert.equal(calls(), 3);
|
|
run(); assert.equal(calls(), 3, "the original full result is reusable without accepting a subset result");
|
|
write("docs/api/issues.md", "after");
|
|
run(); assert.equal(calls(), 4, "runtime documentation must invalidate results");
|
|
} finally { rmSync(directory, { recursive: true, force: true }); }
|
|
});
|
|
|
|
test("every cached lane maps to an existing package script with complete inputs", () => {
|
|
const config = JSON.parse(readFileSync(new URL("turbo.json", repositoryRoot), "utf8"));
|
|
for (const [name, definition] of Object.entries(config.tasks).filter(([, task]) => task.cache)) {
|
|
const plan = executionPlan(config, name.slice(3), ["--shard-index", "0"]);
|
|
const rootTask = plan.target.startsWith("//#");
|
|
const manifest = JSON.parse(readFileSync(new URL(rootTask ? "package.json"
|
|
: "packages/paperclip-runner/package.json", repositoryRoot), "utf8"));
|
|
const script = plan.target.split("#")[1];
|
|
assert.equal(typeof manifest.scripts[script], "string", plan.target);
|
|
assert.ok(plan.config.tasks[plan.target].inputs.length > 0);
|
|
for (const input of plan.config.tasks[plan.target].inputs) {
|
|
const file = rootTask ? input : input.slice("$TURBO_ROOT$/".length);
|
|
assert.ok(definition.inputs.some((glob) => path.matchesGlob(file, glob)), input);
|
|
assert.doesNotMatch(file, /\/(?:node_modules|target|dist)\//);
|
|
}
|
|
assert.ok(plan.args.includes("--shard-index"));
|
|
}
|
|
});
|
|
|
|
test("real Turbo executes existing suite scripts and invalidates source, arguments, environment and failed tasks", () => {
|
|
const directory = mkdtempSync(path.join(tmpdir(), "ci-turbo-"));
|
|
const write = (name, content) => writeFileSync(path.join(directory, name), content);
|
|
const json = (name, value) => write(name, JSON.stringify(value));
|
|
try {
|
|
execFileSync("git", ["init", "-q"], { cwd: directory });
|
|
mkdirSync(path.join(directory, ".github/scripts"), { recursive: true });
|
|
copyFileSync(new URL(".github/scripts/ci-inputs.mjs", repositoryRoot), path.join(directory, ".github/scripts/ci-inputs.mjs"));
|
|
write(".gitignore", ".turbo/\ngenerated/\nresult.txt\ncalls.txt\n");
|
|
mkdirSync(path.join(directory, "packages/fixture"), { recursive: true });
|
|
json("packages/fixture/package.json", { name: "fixture", private: true });
|
|
json("package.json", { name: "cache-proof", private: true, packageManager: "npm@10.0.0", workspaces: ["packages/*"],
|
|
scripts: { "test:run:general": "node check.cjs" } });
|
|
json("package-lock.json", { name: "cache-proof", lockfileVersion: 3, packages: { "": { name: "cache-proof" } } });
|
|
const definition = { globalEnv: ["CI_TASK_CACHE_SCOPE"], tasks: {
|
|
"//#ci:server": { inputs: ["*.txt", "check.cjs"], outputs: ["result.txt"], env: ["FLAVOR"], cache: true },
|
|
} };
|
|
const execution = () => executionPlan(definition, "ci:server", ["--shard-index", "0", "--shard-count", "12"], sourceFiles(directory));
|
|
write("input[one].txt", "first");
|
|
write("check.cjs", `const fs = require('node:fs'); fs.appendFileSync('calls.txt','call\\n'); const input=fs.readFileSync('input[one].txt','utf8'); if(input==='fail') process.exit(1); if(!process.argv.includes('general-server-without-chat')) process.exit(2); fs.writeFileSync('result.txt',input+process.env.FLAVOR);`);
|
|
const run = (extra = {}, args = execution().args) => {
|
|
const plan = execution();
|
|
json("turbo.json", plan.config);
|
|
return spawnSync(turbo, ["run", plan.target, "--cache=local:rw", "--cache-dir=.turbo/cache", "--", ...args], {
|
|
cwd: directory, encoding: "utf8", env: { ...process.env, TURBO_TELEMETRY_DISABLED: "1", FLAVOR: "a", CI_TASK_CACHE_SCOPE: "node-24", ...extra },
|
|
});
|
|
};
|
|
const calls = () => readFileSync(path.join(directory, "calls.txt"), "utf8").trim().split("\n").length;
|
|
const pass = (extra) => { const r = run(extra); assert.equal(r.status, 0, r.stdout + r.stderr); return r; };
|
|
pass(); assert.equal(calls(), 1);
|
|
rmSync(path.join(directory, "result.txt"));
|
|
pass(); assert.equal(calls(), 1, "cached task must not execute");
|
|
assert.equal(readFileSync(path.join(directory, "result.txt"), "utf8"), "firsta");
|
|
write("unrelated.md", "another push");
|
|
pass(); assert.equal(calls(), 1, "unrelated input must retain the result");
|
|
write("input[one].txt", "second");
|
|
pass(); assert.equal(calls(), 2, "source must invalidate checks");
|
|
pass({ FLAVOR: "b" }); assert.equal(calls(), 3);
|
|
pass({ FLAVOR: "b", CI_TASK_CACHE_SCOPE: "node-25" }); assert.equal(calls(), 4);
|
|
assert.equal(run({}, [...execution().args, "--another-argument"]).status, 0);
|
|
assert.equal(calls(), 5, "different shard arguments must not share a task result");
|
|
write("input[one].txt", "fail");
|
|
assert.notEqual(run().status, 0); assert.notEqual(run().status, 0);
|
|
assert.equal(calls(), 7, "a failed task must execute on every attempt");
|
|
} finally { rmSync(directory, { recursive: true, force: true }); }
|
|
});
|
|
|
|
test("the task launcher bypasses cache reads and writes when execution is forced", () => {
|
|
const directory = mkdtempSync(path.join(tmpdir(), "ci-turbo-forced-"));
|
|
const write = (name, value) => writeFileSync(path.join(directory, name), value);
|
|
const json = (name, value) => write(name, JSON.stringify(value));
|
|
try {
|
|
execFileSync("git", ["init", "-q"], { cwd: directory });
|
|
mkdirSync(path.join(directory, "scripts/ci"), { recursive: true });
|
|
mkdirSync(path.join(directory, "bin"));
|
|
mkdirSync(path.join(directory, "packages/fixture"), { recursive: true });
|
|
for (const name of ["run-task.mjs", "execution-plan.mjs", "test-selection-manifest.mjs"]) {
|
|
copyFileSync(new URL(`scripts/ci/${name}`, repositoryRoot), path.join(directory, "scripts/ci", name));
|
|
}
|
|
mkdirSync(path.join(directory, ".github/scripts"), { recursive: true });
|
|
copyFileSync(new URL(".github/scripts/ci-inputs.mjs", repositoryRoot), path.join(directory, ".github/scripts/ci-inputs.mjs"));
|
|
write(".gitignore", ".turbo/\ncalls.txt\nresult.txt\nbin/\n");
|
|
json("packages/fixture/package.json", { name: "fixture", private: true });
|
|
json("package.json", { name: "forced-cache-proof", private: true, packageManager: "npm@10.0.0",
|
|
workspaces: ["packages/*"], scripts: { "test:run:general": "node check.cjs" } });
|
|
json("package-lock.json", { name: "forced-cache-proof", lockfileVersion: 3, packages: { "": { name: "forced-cache-proof" } } });
|
|
json("turbo.json", { globalDependencies: [], globalEnv: ["CI_TASK_CACHE_SCOPE"], tasks: {
|
|
"//#ci:server": { inputs: ["input.txt", "check.cjs"], outputs: ["result.txt"], cache: true },
|
|
} });
|
|
write("input.txt", "result");
|
|
write("check.cjs", "const fs=require('node:fs');fs.appendFileSync('calls.txt','call\\n');fs.writeFileSync('result.txt',fs.readFileSync('input.txt'));");
|
|
write("bin/pnpm", `#!${process.execPath}\nconst {spawnSync}=require('node:child_process');const args=process.argv.slice(2);if(args[0]==='--version'){console.log('9.15.4');}else{if(args[0]!=='exec'||args[1]!=='turbo')process.exit(2);const result=spawnSync(${JSON.stringify(turbo)},args.slice(2),{stdio:'inherit'});process.exit(result.status??1);}`);
|
|
chmodSync(path.join(directory, "bin/pnpm"), 0o755);
|
|
const run = force => {
|
|
const result = spawnSync(process.execPath, [path.join(directory, "scripts/ci/run-task.mjs")], {
|
|
cwd: directory, encoding: "utf8", env: { ...process.env, PATH: `${path.join(directory, "bin")}${path.delimiter}${process.env.PATH}`,
|
|
CI_TASK: "ci:server", CI_TASK_ARGS: "[]", CI_TASK_DRY_RUN: "false", CI_FORCE_TASKS: String(force),
|
|
TURBO_TOKEN: "", TURBO_TEAM: "", TURBO_TELEMETRY_DISABLED: "1" },
|
|
});
|
|
assert.equal(result.status, 0, result.stdout + result.stderr);
|
|
};
|
|
const calls = () => readFileSync(path.join(directory, "calls.txt"), "utf8").trim().split("\n").length;
|
|
const cacheFiles = () => existsSync(path.join(directory, ".turbo/cache"))
|
|
? readdirSync(path.join(directory, ".turbo/cache"), { recursive: true }).sort() : [];
|
|
run(true); run(true);
|
|
assert.equal(calls(), 2, "forced runs must execute even when a previous result exists");
|
|
assert.deepEqual(cacheFiles(), [], "forced runs must not populate the task cache");
|
|
run(false); run(false);
|
|
assert.equal(calls(), 3, "ordinary runs still reuse local results");
|
|
const retainedCache = cacheFiles();
|
|
assert.ok(retainedCache.length > 0);
|
|
run(true);
|
|
assert.equal(calls(), 4, "forced runs must bypass an existing cache hit");
|
|
assert.deepEqual(cacheFiles(), retainedCache);
|
|
symlinkSync("input.txt", path.join(directory, "unclassified-link"));
|
|
run(false);
|
|
assert.equal(calls(), 5, "unclassified non-regular input must force execution");
|
|
assert.deepEqual(cacheFiles(), retainedCache);
|
|
} finally { rmSync(directory, { recursive: true, force: true }); }
|
|
});
|