mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-11-03 17:51:58 +01:00
## Thinking Path > - Paperclip lets people manage AI agents and inspect their work. > - The chat catalog uses real Product E2E cases and reports their original grades to TestOps. > - The current report matrix waits for every selected worker. > - A large selection can hide completed results for hours. > - Each case can use the existing private reader and safe exporter after its own worker ends. > - This PR gives each case a separate upload and readback job, then verifies final coverage without another upload. > - People can inspect completed cases while the rest of the selection runs. ## Linked Issues or Issue Description Refs #18542, #18625. **What existing behavior does this improve?** The existing chat catalog reports results to TestOps only after all selected workers finish. **Current behavior** One slow case holds back the report and upload jobs for all other cases. **Proposed behavior** Each finished case gets its own protected reader, safe projection, upload and backend verification. The final job checks the whole selection through read-only requests. It does not upload results again. **Reason and benefit** A person can inspect a completed grade and its safe evidence receipts while other cases run. This changes future runs. It does not change an in-flight run. ## What Changed - Add one same-commit reusable workflow with separate worker, private-reader and TestOps-upload jobs. Each job uses only its own protected environment. Callers pass empty named secret placeholders and do not inherit secrets. - Reuse the original exporter and grade checks. Freeze each case's three Allure JSON files once. Allow known sibling results during per-case readback. Keep final exact selection coverage. - Submit each bundle at most once. Reconcile uncertain responses by readback. Retain only closed publication, failure and upload-intent receipts. A rerun attempt still fails the existing attempt-one admission guard. - Preserve failed original grades, failed cleanup and missing evidence. No missing original can become a passing result. - Keep external-input cases in the serial lane. Small native-only selections allow two cases at once. Small mixed selections allow one native and one external case. Larger selections retain eight native cases and one external case. - Add source, privacy and failure controls to the existing unit roster. Document the reporting flow and runner-group admission requirement. - Fix an existing corruption-test fixture that could write the same byte back to a random IV. Read and flip one bit instead. Keep the storage rejection and unpublished-plaintext assertions unchanged. ## Verification - 152 focused Node controls pass across the shared client, API, selection, CLI and streaming tests. The retained parent controls show the missing multipart and partial-readback behavior, plus the small external-selection error before its fix. - The focused workflow security control passes. Actionlint passes for both workflows. Changed JavaScript files pass syntax checks. Git diff checks pass. - Local controls use synthetic data and mocked HTTP. They make no provider call and do not start an app, database or native build. - Previous head `b51406df` passed PR CI (48 jobs pass and one is skipped). The review-driven test-only successor `0c65cc21` then failed one unchanged snapshot-storage corruption test, plus the final CI summary. The latest head includes its narrow fixture repair. Its first CI attempt separately hit runner shutdown/lost-communication failures, two setup/timeouts and a heartbeat-cancel cleanup HTTP 500/lock timeout; those observations are retained without claiming their underlying cause. One same-head failed-and-cancelled-only recovery now passes at `bf9c3e8f`: 48 jobs pass and one is skipped, including required `ci / verify` and `ci / e2e`. All 31 already-passing jobs retained their original execution records; all 15 recovered leaves and both dependent summaries passed. The first attempt remains recorded; the recovery does not establish the underlying causes of those failures. A small AWS run after delivery must prove that one case and both attachments are visible before another original case ends. That live proof is pending; local controls do not prove vendor ingestion or environment-secret resolution. - Retained earlier fixture-calibration failures remain recorded. The final integrated Node control run is green. A deterministic Node crypto/filesystem control also reproduces the no-op corruption mutation with a valid IV byte equal to `X`, then passes after flipping that byte. This control uses no app or database. The failing CI byte was not captured, so the exact historical byte remains unknown. ## Risks - The called workflow needs its exact master ref in the existing selected-workflow runner group. No IAM role change is needed. - Environment-only secrets must resolve in the called jobs. The caller passes no actual model or reporting key. The small live proof must confirm this behavior. - TestOps does not document an idempotency key for this upload route. An uncertain write is never resent automatically. If readback cannot verify it, the workflow fails with retained closed receipts. - The existing job run can already be marked finished by the selection watch. The live proof must record its actual stage and prove subsequent uploads are accepted. This PR does not reopen, stop or close that job run. - Backend ingestion does not prove that an already-open TestOps page refreshes automatically. - The corruption-test repair changes no production storage or cryptography. New-head AWS CI must qualify the existing database-backed owner test. - Each case adds short protected reader and upload jobs. The app source, original case clocks, graders, model, budgets, raw-evidence privacy boundary and zero eval retries stay unchanged. The versioned stream concurrency group serializes new streaming runs; an old immutable batch run can continue in its original group. ## Model Used OpenAI `gpt-6.1-sol`, with tool use and code execution. The session does not expose a context-window size. Independent source peers used the same model family. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either (a) linked existing issues with `Fixes: #` / `Closes #` / `Refs #` OR (b) described the issue in-PR following the relevant issue template - [x] I have not referenced internal/instance-local Paperclip issues or links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip` URLs) - [x] My branch name describes the change (e.g. `docs/...`, `fix/...`) and contains no internal Paperclip ticket id or instance-derived details - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] All Paperclip CI gates are green - [x] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I will address all Greptile and reviewer comments before requesting merge --------- Co-authored-by: Paperclip <noreply@paperclip.ing>
287 lines
18 KiB
Markdown
287 lines
18 KiB
Markdown
# Chat feature evals
|
|
|
|
`chat-features` promotes two entries from the [scenario catalog](chat-scenarios/README.md)
|
|
into real Product E2E executions. The scope is deliberately small: prove the
|
|
fixture, browser interaction, independent grading and report loop before adding
|
|
more features. Catalog coverage is not live acceptance.
|
|
|
|
| Scenario | Actual user request | Independent outcome |
|
|
| --- | --- | --- |
|
|
| `tasks.create-backlog` | Add a task for Morgan to draft the launch announcement in Launch, but don't start it yet. | Exactly one task, Launch project, Morgan assignee, backlog at creation, no worker execution, usable chat link after reload. |
|
|
| `tasks.delegate-announcement` | Have Morgan write a two-sentence launch announcement using the Launch project brief, save it on the task, and send me the result here when it's finished. | Exactly one task, actual Morgan execution, current worker-authored document grounded in the project brief, task Done, automatic completion response in the original chat, usable result after reload. |
|
|
|
|
The queries are read directly from `chat-scenarios/tasks.yaml`. Context and
|
|
expected outcomes stay evaluator-side. The fixture creates a disposable company,
|
|
CEO, Morgan and Launch project through production APIs; both agents use the
|
|
shipped role instructions. The brief contains a product, date and random invitation
|
|
code absent from the user query. The browser sends one message through Agent Chat.
|
|
The harness never creates the result task, writes the announcement, completes the
|
|
task, or sends a hidden follow-up.
|
|
|
|
## Run the first slice
|
|
|
|
Follow the installation steps in [README.md](README.md#local-commands). The Codex
|
|
subscription profile uses the catalog's recorded default model and an
|
|
explicit `CODEX_AUTH_JSON` login. Load that login privately into the launcher
|
|
environment; do not print it or save it in tracked configuration. The existing
|
|
subscription fixture stages only `auth.json` in the disposable company login slot
|
|
and removes it with the isolated instance.
|
|
|
|
The local native OpenCode profile uses the current production-qualified model
|
|
and `OPENROUTER_API_KEY` through the existing encrypted company-secret fixture.
|
|
Each of the two journeys has a cell for each original profile. These four cells
|
|
remain unchanged; the TestOps profile below adds one separately named backlog cell.
|
|
|
|
```sh
|
|
pnpm test:e2e:runner:typecheck
|
|
pnpm test:e2e:runner:unit
|
|
pnpm test:e2e:runner -- --list --suite chat-features
|
|
pnpm test:e2e:runner -- --id chat-features.runner-codex-subscription.local.create-backlog --max-automatic-retries 0
|
|
pnpm test:e2e:runner -- --id chat-features.runner-codex-subscription.local.delegate-announcement --max-automatic-retries 0
|
|
pnpm test:e2e:runner -- --id chat-features.runner-opencode.local.delegate-announcement --max-automatic-retries 0
|
|
```
|
|
|
|
Run creation first and inspect its packaged report before delegation. For the original Codex
|
|
acceptance, run each cell three times against fresh fixtures on the same definition
|
|
revision. Keep every attempt, including failures; a retry does not erase one. A
|
|
fixture or product correction starts a new three-sample measurement. All cells
|
|
are explicit-only and excluded from `--all`; this does not implement or qualify
|
|
the rest of the YAML inventory.
|
|
|
|
## OpenCode TestOps integration acceptance
|
|
|
|
The additional explicit cell
|
|
`chat-features.runner-opencode-deepseek-1017.local.create-backlog` runs the same backlog
|
|
query, public fixture and saved-state oracle on native OpenCode with
|
|
`openrouter/deepseek/deepseek-v4.1-flash-1017`. It requires only the selected
|
|
`OPENROUTER_API_KEY` profile credential. The launcher stores an encrypted secret
|
|
reference for the disposable agents; no key belongs in catalog data or chat.
|
|
This selected model is a qualification candidate. Other OpenCode suites keep
|
|
their existing model, and delegation is not registered for this profile.
|
|
|
|
```sh
|
|
pnpm test:e2e:runner -- --id chat-features.runner-opencode-deepseek-1017.local.create-backlog --max-automatic-retries 0
|
|
```
|
|
|
|
Use a separately named TestOps integration-acceptance plan and launch for this
|
|
single cell. It retains one human request, one accounted controller work run,
|
|
120-second turns, a seven-minute attempt, the five-minute stable-state bound
|
|
and zero automatic retries. Morgan is created as fixture context but must not
|
|
execute the saved backlog task. Existing setup probes and unknown usage remain
|
|
reported separately. The original 244-scenario campaign, failed attempts and
|
|
Codex measurements are not reset or regraded by this measurement.
|
|
|
|
The existing normalized result, JUnit and packaged report carry the outcome to
|
|
the execution integration. Catalog selection and provider-free oracle checks
|
|
do not establish an AWS model pass or a successful TestOps upload. Accept this
|
|
integration only after the real AWS execution and its TestOps result agree.
|
|
|
|
## Bounds and grading
|
|
|
|
Creation expects one accounted native work run; delegation expects three (CEO
|
|
handoff, Morgan work, CEO completion response). Runs have a 120-second timeout
|
|
and attempts a seven-minute deadline. The visible task and completion reply must
|
|
settle within five minutes after the human request, including a five-second stable
|
|
observation. This is an independent journey acceptance bound: three runs may not
|
|
each consume their maximum timeout and still pass. The outer attempt also covers
|
|
fixture setup, reload and link checks, and evidence collection. A failed provider
|
|
run rejects immediately; the historical missing turn-start event was not a
|
|
five-minute poll timeout. Automatic retries are disabled. Company
|
|
and agent budgets are 500 cents each, CEO daily work runs are capped at three,
|
|
Morgan at one, and periodic heartbeats are disabled. Initial production hello
|
|
probes fall outside heartbeat usage and budget accounting; detailed setup tokens
|
|
and cost are unavailable. These limits are not an absolute inference or cash cap.
|
|
Subscription cost coverage must remain explicit in the report.
|
|
|
|
An obsolete CEO assignment can leave a cancelled queue entry when the CEO creates
|
|
a task and then assigns it to Morgan. Grader v2 distinguishes that entry from
|
|
provider work only when the dispatch gate records `issue_assignee_changed`, an
|
|
explicitly null start time, no native issue, and its unchanged stale-queue stop
|
|
receipt. The entry must belong to this company and the one task now assigned to
|
|
Morgan. It stays in the full observation and final ledger, with its events and an
|
|
explicit provider-log omission reason. Active, unrelated, or unproved cancellations
|
|
still fail. The three successful work runs, worker output, completion delivery,
|
|
and original deadlines remain required. Backlog creation still permits no task wake.
|
|
|
|
Because this subscription currently reports unpriced usage, setup explicitly sets
|
|
`unpricedUsagePolicy: allow` on the disposable company and both agents through the
|
|
public budget API and verifies all three policies. The 500-cent hard stops remain
|
|
enabled for reported costs; they cannot cap unknown dollar usage. Run caps and
|
|
deadlines remain independent bounds. Without this explicit funding prerequisite,
|
|
the default policy pauses the company after the first unpriced run and cancels
|
|
the delegated worker. Such a pause is not a successful chat journey.
|
|
|
|
`chat-feature.json` retains the scenario ID, capability IDs, grader version,
|
|
saved records, audit attribution, rendered links and individual checks.
|
|
`chat-feature-runs.json` uses the existing native run evidence collector, including
|
|
on failures. Setup evidence records fixture IDs, synthetic brief, readiness and
|
|
saved budgets. Ordinary Product E2E evidence packaging, redaction, cleanup, failure
|
|
classification and dashboards own the result. The definition digest includes the
|
|
query, defaults, flow and grader sources.
|
|
Individual saved-state checks are also recorded when the journey fails, so the
|
|
report shows partial progress without turning it into a passing workflow.
|
|
|
|
The grader rejects duplicate tasks, wrong owners/projects/companies, early execution,
|
|
missing audit attribution, missing or stale deliverables, extra human nudges and
|
|
uncorrelated completion replies. Document provenance binds the current revision
|
|
to Morgan's actual run. The completion check reuses `completionDelivery`; a
|
|
handoff promise or a marker alone cannot establish delivery. Chromium verifies
|
|
the task link and reload persistence.
|
|
|
|
The checks establish the specified saved state, two-sentence structure, required
|
|
brief facts and result access. They do not score writing quality or every semantic
|
|
claim in the response. Inspect the retained conversation and announcement before
|
|
accepting the first samples; the existing completion semantic-review rubric still
|
|
applies. Oracle calibration tests exercise both valid evidence and plausible wrong
|
|
outcomes without calling a model.
|
|
|
|
Only after this loop is stable should another scenario be promoted. Keep each
|
|
starting condition explicit: connected versus missing connection, allowed versus
|
|
approval-required, and so on. Reuse the fixture/report infrastructure and add a
|
|
case-specific outcome oracle; do not make all YAML paragraphs executable through
|
|
an unconstrained model judge.
|
|
|
|
## Initial measurement — 2026-10-26
|
|
|
|
Three fresh samples per cell on definition
|
|
`7fb20426ce3f1dd4efeddfb79f231336ea65a16b9c2a73bf6131e997acd74e9d`
|
|
produced **5/6 passes**: backlog creation 3/3 and delegation 2/3. These used local
|
|
native Codex subscription execution with `gpt-5.6-sol`. All six cleaned up
|
|
successfully. Both workflows have successful browser-to-provider evidence, but
|
|
the initial repeatability target is not met.
|
|
|
|
In campaign `local-2026-10-26T15-48-12-199Z`, the first CEO run in delegation
|
|
failed before creating a task: `runnerd did not report the provider turn identity`.
|
|
Retained events show submission and provider startup, followed by the transport's
|
|
turn-start deadline. The precise cause of the missing event remains unresolved;
|
|
the existing machine classification is retained without claiming that the provider
|
|
or infrastructure has been proven responsible. Investigate this before expanding
|
|
the suite. No replacement sample erased this failure.
|
|
|
|
The local `results/chat-feature-acceptance/acceptance.md` records every sample and
|
|
earlier failed revision; its sibling dashboard uses the standard report generator.
|
|
Results are ignored generated artifacts, so retain or publish them through the
|
|
existing Product E2E pipeline when handing this measurement to another machine.
|
|
|
|
### Follow-up measurement — 2026-10-26
|
|
|
|
The unchanged delegation cell subsequently passed three fresh executions:
|
|
`local-2026-10-26T16-50-50-751Z`, `local-2026-10-26T16-54-58-203Z`, and
|
|
`local-2026-10-26T16-58-39-074Z`. The latter two campaigns also ran backlog
|
|
creation concurrently and passed both cells. All five selected executions used
|
|
one attempt with zero automatic retries, retained the same definition above,
|
|
and passed cleanup. Five existing turn-identity, early-terminal and runner-exit
|
|
regressions passed as well.
|
|
|
|
These are green rechecks, not a demonstrated repair of the earlier startup
|
|
interruption: no production code, timing limits or oracle assertions changed,
|
|
and the missing turn-start event did not reproduce. Keep the original failure
|
|
in the history. Across the original final-definition batch and this recheck,
|
|
backlog is 5/5 and delegation is 5/6. The local
|
|
`results/chat-feature-recheck/verification.md` records the follow-up evidence;
|
|
its standard dashboard is explicitly scoped to the latest campaign.
|
|
|
|
## Retired TestOps plans
|
|
|
|
The one-case **Chat feature evals** plan and three-case
|
|
**Chat completion pilot — OpenCode 1017** plan are retired. Their scenarios are
|
|
included in the [full catalog](#full-catalog-in-testops). Use that plan or select
|
|
cases from it; do not recreate the smoke or pilot plans.
|
|
|
|
The former `chat-feature-testops.yml` and `chat-completion-testops.yml` workflows
|
|
are removed. Their bootstrap functions reject registration before any API call
|
|
or mutation marker. Shared transport, evidence, export and verification helpers
|
|
remain for the full-catalog workflow and retained historical evidence. Retiring a
|
|
plan does not delete its cases, results, launches or private evidence.
|
|
|
|
Retained launch helpers encode TestOps name filters as Base64 of UTF-8 JSON in
|
|
`search`. Plain name text returns HTTP 400. Their nonce and once-only guards
|
|
remain unchanged; this transport contract does not restore the retired plans.
|
|
|
|
## Full catalog in TestOps
|
|
|
|
The [Chat catalog TestOps workflow](../../.github/workflows/chat-catalog-testops.yml)
|
|
registers all 244 scenarios from the 35 YAML areas in a separate
|
|
**Chat feature catalog — OpenCode 1017 (candidate)** plan. Its source-derived
|
|
manifest is `chat-full-catalog-testops-manifest.json`. This is the active chat
|
|
plan. The former backlog and three-case pilot plans are retired; their cases
|
|
and measured history are preserved.
|
|
Legacy aliases reuse existing TestOps case identities without renaming them.
|
|
|
|
The catalog contains 236 Agent Chat routes, five browser boundaries, one external
|
|
assistant route and two Slack routes. An execution mapping is not a passing
|
|
measurement. Five implementations declare incomplete coverage. Six routes do not
|
|
produce the generic final PNG required by the unchanged evidence owner. Eighteen
|
|
declare additional credentials and 37 declare external inputs. These groups
|
|
overlap. Exact requirements and limitations appear in each case's preconditions.
|
|
A declared credential does not establish whether its runtime reference exists.
|
|
|
|
This lane runs the app and fixtures from candidate
|
|
`3b66c3c144360ddf32714a0742fd774b8ceafb16`. Its app and domain definitions are
|
|
unchanged from `de0941835cc8f0d01c982574ee258e110babdbeb`; the successor adds only
|
|
finite TestOps host admission. Trusted selection, evidence transfer and publishing
|
|
use the workflow's immutable master revision. Each result records both revisions.
|
|
A pass qualifies that candidate measurement, not the current master app. Other
|
|
lanes sharing a case retain their own sources. This integration does not merge
|
|
the broad catalog branch or its core fixes, reset earlier campaign ordinals, or
|
|
change the previous 196-of-244 acceptance gate.
|
|
|
|
Native execution uses OpenCode and
|
|
`openrouter/deepseek/deepseek-v4.1-flash-1017` on the existing AWS fleet. Each case
|
|
keeps its original query, oracle, run counts, clocks, budgets and zero automatic
|
|
retries. Browser boundaries and the external assistant retain their original
|
|
surfaces and may have zero native work runs. The external companion keeps its own
|
|
declared provider requirement. Setup inference and unpriced usage are not free.
|
|
|
|
Initial setup uses the existing reporting environment:
|
|
|
|
1. Dispatch reviewed master with `operation=bootstrap`. It reconciles the exact
|
|
244 cases and the dedicated plan, then registers and binds its own GitHub job.
|
|
Missing cases use one marked POST each. Existing cases retain their identities
|
|
and history. Alias conflicts, foreign selections and uncertain writes stop
|
|
setup. It makes no model call or synthetic test result.
|
|
2. Read the registration receipt. Store its compact `binding` JSON as
|
|
`CHAT_FULL_CATALOG_TESTOPS_BINDING`. It contains observed plan, job, integration
|
|
and case IDs plus registered full names, and fits one GitHub environment
|
|
variable. The job must retain its observed single `Branch/defaultValue`
|
|
definition for `refs/heads/master`.
|
|
3. Use normal TestOps **Run** for the full plan or a selected subset. The service's
|
|
actual expected case list controls execution. Do not manually dispatch another
|
|
evaluation after an uncertain request. Initial route verification uses a small
|
|
selection and does not qualify all 244 cases.
|
|
|
|
Each worker executes one case. Selections of up to three cases allow two cases
|
|
at once. Larger selections allow eight independent cases and one external-input
|
|
case at once. External-input cases remain serial because they can share QA
|
|
resources. A full run can take hours. Its elapsed time depends on setup and fleet
|
|
capacity; the declared case clocks are not a completion-time guarantee.
|
|
|
|
Each finished worker starts its own protected reader and safe exporter. A
|
|
separate reporting job uploads that case and verifies its result and two JSON
|
|
attachments while other workers continue. The reader has only an exact-key AWS
|
|
session. The worker has only its declared model keys. Only the uploader has the
|
|
TestOps key. The existing eight-cell private authority limit is unchanged.
|
|
|
|
The exporter freezes each UUID-bearing Allure bundle once. An uncertain upload
|
|
response triggers readback, never an automatic resend. The final job verifies
|
|
complete selected-case coverage and the original statuses without uploading the
|
|
results again. Failed originals and failed cleanup remain failed beside passed
|
|
results. Missing originals cannot become fabricated measurements or a
|
|
full-selection pass. Backend ingestion does not guarantee that an open TestOps
|
|
page refreshes without user action.
|
|
|
|
The caller and reusable case workflow must both be admitted at their exact
|
|
`refs/heads/master` paths in the existing runner group. Called jobs use their own
|
|
protected environments; the caller passes empty named secret placeholders and
|
|
never inherits or forwards actual model or reporting keys. Streaming runs use
|
|
the fixed `chat-catalog-testops-streaming-v1` serialization group. Runs started
|
|
before this change retain their original batch-reporting flow.
|
|
|
|
Raw evidence and final PNGs remain in protected storage. Public GitHub artifacts
|
|
and TestOps attachments contain only allowlisted provenance, checks, accounting
|
|
and private-evidence receipts. Raw conversations, screenshots, provider sessions
|
|
and credentials do not enter the public artifact path. Additional credentials
|
|
reach only cases that declare them. External inputs use the existing selected-case
|
|
private-input owner, disposable-resource checks and oracle commitments.
|
|
Unconfigured inputs remain setup blockers.
|