mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-11-06 23:20:53 +01:00
## Thinking Path > - Paperclip manages AI agents and preserves their work history. > - Product E2E cases use TestOps plans to select real AWS evaluations. > - The full chat catalog now includes the former smoke and completion-pilot cases. > - The two old bootstrap workflows can recreate their smaller plans after deletion. > - This pull request removes those workflows and stops their plan-creation functions before API access. > - The full-catalog workflow keeps its shared clients, evidence rules, case identities, and measured results. ## Linked Issues or Issue Description Refs #18542, #18516. The user requested removal of the duplicate smoke and completion-pilot plans and investigation of their recreation paths. Both old workflows accepted manual dispatch only. Their bootstrap operations created plans by name when the plans were absent. They had no schedules in their workflow definitions. The old workflow records were disabled before plan removal. An existing pilot execution was allowed to finish successfully. This change does not cancel executions or delete cases, results, launches, or private evidence. ## What Changed - Remove `chat-feature-testops.yml` and `chat-completion-testops.yml`. - Make the former singleton plan creator reject every call before API reads or mutation markers. - Reject pilot bootstrap before API access. Keep the full-catalog branch and its integration validation. - Remove tests that require the retired workflow files. Keep shared helper and full-catalog controls. Run the trusted-checkout boundary test against the active catalog workflow. - Replace old setup instructions with retirement guidance and the active full-catalog route. The master sync preserves the incoming typed launch-search fix from #18620, including both regression tests. The only conflict was the retired pilot documentation. Its search-format note remains as a retained-helper contract. ## Verification - Two new retirement controls fail against the parent code because it reaches an API or mutation marker. Both pass after the change. - Six owning Node suites after the master sync: 146 passed (144 before the sync). Shared contract: 22 passed. Catalog and retained export controls: 12 passed. Focused workflow and release controls: 7 passed. - Two modified API modules pass Node syntax checks. `git diff --check` passes. - The pure workflow-security file has the same four failures and 13 passes on both the untouched parent and this branch. Two assertions expect eight trusted bootstrap steps where master now has nine. Two lists omit the already-shipped catalog workflow. This change does not repair or relax those unrelated assertions. - A broader release-test invocation had 73 passes and 20 sandbox failures from blocked mock HTTP listeners or npm permissions. Its focused affected workflow control passes. A standard Vitest setup attempt stopped on a missing `acpx/runtime` bundle dependency before tests. No local app, database, provider, or native runtime was qualified. - Current-head PR CI passes: 48 successful jobs and one skipped job, including both required checks. Greptile is 5/5. Independent source review passes. No new model run is needed for this retirement. ## Risks - Existing integrations that point at either retired workflow will stop dispatching. This is the requested behavior; use the full catalog instead. - Historical evidence readers still use shared helpers. Those helpers remain, including the transport and official-context parser used by the active catalog. - Workflow removal is a repository change. TestOps plan deletion and disabling obsolete executors are separate service actions. Neither action should delete shared cases or measurements. ## Model Used OpenAI `gpt-6.1-sol` through Codex, with source editing, shell tools, and independent source review. The context-window size is not asserted. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either (a) linked existing issues with `Fixes: #` / `Closes #` / `Refs #` OR (b) described the issue in-PR following the relevant issue template - [x] I have not referenced internal/instance-local Paperclip issues or links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip` URLs) - [x] My branch name describes the change (e.g. `docs/...`, `fix/...`) and contains no internal Paperclip ticket id or instance-derived details - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] All Paperclip CI gates are green - [x] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I will address all Greptile and reviewer comments before requesting merge Co-authored-by: Paperclip <noreply@paperclip.ing>
274 lines
17 KiB
Markdown
274 lines
17 KiB
Markdown
# Chat feature evals
|
|
|
|
`chat-features` promotes two entries from the [scenario catalog](chat-scenarios/README.md)
|
|
into real Product E2E executions. The scope is deliberately small: prove the
|
|
fixture, browser interaction, independent grading and report loop before adding
|
|
more features. Catalog coverage is not live acceptance.
|
|
|
|
| Scenario | Actual user request | Independent outcome |
|
|
| --- | --- | --- |
|
|
| `tasks.create-backlog` | Add a task for Morgan to draft the launch announcement in Launch, but don't start it yet. | Exactly one task, Launch project, Morgan assignee, backlog at creation, no worker execution, usable chat link after reload. |
|
|
| `tasks.delegate-announcement` | Have Morgan write a two-sentence launch announcement using the Launch project brief, save it on the task, and send me the result here when it's finished. | Exactly one task, actual Morgan execution, current worker-authored document grounded in the project brief, task Done, automatic completion response in the original chat, usable result after reload. |
|
|
|
|
The queries are read directly from `chat-scenarios/tasks.yaml`. Context and
|
|
expected outcomes stay evaluator-side. The fixture creates a disposable company,
|
|
CEO, Morgan and Launch project through production APIs; both agents use the
|
|
shipped role instructions. The brief contains a product, date and random invitation
|
|
code absent from the user query. The browser sends one message through Agent Chat.
|
|
The harness never creates the result task, writes the announcement, completes the
|
|
task, or sends a hidden follow-up.
|
|
|
|
## Run the first slice
|
|
|
|
Follow the installation steps in [README.md](README.md#local-commands). The Codex
|
|
subscription profile uses the catalog's recorded default model and an
|
|
explicit `CODEX_AUTH_JSON` login. Load that login privately into the launcher
|
|
environment; do not print it or save it in tracked configuration. The existing
|
|
subscription fixture stages only `auth.json` in the disposable company login slot
|
|
and removes it with the isolated instance.
|
|
|
|
The local native OpenCode profile uses the current production-qualified model
|
|
and `OPENROUTER_API_KEY` through the existing encrypted company-secret fixture.
|
|
Each of the two journeys has a cell for each original profile. These four cells
|
|
remain unchanged; the TestOps profile below adds one separately named backlog cell.
|
|
|
|
```sh
|
|
pnpm test:e2e:runner:typecheck
|
|
pnpm test:e2e:runner:unit
|
|
pnpm test:e2e:runner -- --list --suite chat-features
|
|
pnpm test:e2e:runner -- --id chat-features.runner-codex-subscription.local.create-backlog --max-automatic-retries 0
|
|
pnpm test:e2e:runner -- --id chat-features.runner-codex-subscription.local.delegate-announcement --max-automatic-retries 0
|
|
pnpm test:e2e:runner -- --id chat-features.runner-opencode.local.delegate-announcement --max-automatic-retries 0
|
|
```
|
|
|
|
Run creation first and inspect its packaged report before delegation. For the original Codex
|
|
acceptance, run each cell three times against fresh fixtures on the same definition
|
|
revision. Keep every attempt, including failures; a retry does not erase one. A
|
|
fixture or product correction starts a new three-sample measurement. All cells
|
|
are explicit-only and excluded from `--all`; this does not implement or qualify
|
|
the rest of the YAML inventory.
|
|
|
|
## OpenCode TestOps integration acceptance
|
|
|
|
The additional explicit cell
|
|
`chat-features.runner-opencode-deepseek-1017.local.create-backlog` runs the same backlog
|
|
query, public fixture and saved-state oracle on native OpenCode with
|
|
`openrouter/deepseek/deepseek-v4.1-flash-1017`. It requires only the selected
|
|
`OPENROUTER_API_KEY` profile credential. The launcher stores an encrypted secret
|
|
reference for the disposable agents; no key belongs in catalog data or chat.
|
|
This selected model is a qualification candidate. Other OpenCode suites keep
|
|
their existing model, and delegation is not registered for this profile.
|
|
|
|
```sh
|
|
pnpm test:e2e:runner -- --id chat-features.runner-opencode-deepseek-1017.local.create-backlog --max-automatic-retries 0
|
|
```
|
|
|
|
Use a separately named TestOps integration-acceptance plan and launch for this
|
|
single cell. It retains one human request, one accounted controller work run,
|
|
120-second turns, a seven-minute attempt, the five-minute stable-state bound
|
|
and zero automatic retries. Morgan is created as fixture context but must not
|
|
execute the saved backlog task. Existing setup probes and unknown usage remain
|
|
reported separately. The original 244-scenario campaign, failed attempts and
|
|
Codex measurements are not reset or regraded by this measurement.
|
|
|
|
The existing normalized result, JUnit and packaged report carry the outcome to
|
|
the execution integration. Catalog selection and provider-free oracle checks
|
|
do not establish an AWS model pass or a successful TestOps upload. Accept this
|
|
integration only after the real AWS execution and its TestOps result agree.
|
|
|
|
## Bounds and grading
|
|
|
|
Creation expects one accounted native work run; delegation expects three (CEO
|
|
handoff, Morgan work, CEO completion response). Runs have a 120-second timeout
|
|
and attempts a seven-minute deadline. The visible task and completion reply must
|
|
settle within five minutes after the human request, including a five-second stable
|
|
observation. This is an independent journey acceptance bound: three runs may not
|
|
each consume their maximum timeout and still pass. The outer attempt also covers
|
|
fixture setup, reload and link checks, and evidence collection. A failed provider
|
|
run rejects immediately; the historical missing turn-start event was not a
|
|
five-minute poll timeout. Automatic retries are disabled. Company
|
|
and agent budgets are 500 cents each, CEO daily work runs are capped at three,
|
|
Morgan at one, and periodic heartbeats are disabled. Initial production hello
|
|
probes fall outside heartbeat usage and budget accounting; detailed setup tokens
|
|
and cost are unavailable. These limits are not an absolute inference or cash cap.
|
|
Subscription cost coverage must remain explicit in the report.
|
|
|
|
An obsolete CEO assignment can leave a cancelled queue entry when the CEO creates
|
|
a task and then assigns it to Morgan. Grader v2 distinguishes that entry from
|
|
provider work only when the dispatch gate records `issue_assignee_changed`, an
|
|
explicitly null start time, no native issue, and its unchanged stale-queue stop
|
|
receipt. The entry must belong to this company and the one task now assigned to
|
|
Morgan. It stays in the full observation and final ledger, with its events and an
|
|
explicit provider-log omission reason. Active, unrelated, or unproved cancellations
|
|
still fail. The three successful work runs, worker output, completion delivery,
|
|
and original deadlines remain required. Backlog creation still permits no task wake.
|
|
|
|
Because this subscription currently reports unpriced usage, setup explicitly sets
|
|
`unpricedUsagePolicy: allow` on the disposable company and both agents through the
|
|
public budget API and verifies all three policies. The 500-cent hard stops remain
|
|
enabled for reported costs; they cannot cap unknown dollar usage. Run caps and
|
|
deadlines remain independent bounds. Without this explicit funding prerequisite,
|
|
the default policy pauses the company after the first unpriced run and cancels
|
|
the delegated worker. Such a pause is not a successful chat journey.
|
|
|
|
`chat-feature.json` retains the scenario ID, capability IDs, grader version,
|
|
saved records, audit attribution, rendered links and individual checks.
|
|
`chat-feature-runs.json` uses the existing native run evidence collector, including
|
|
on failures. Setup evidence records fixture IDs, synthetic brief, readiness and
|
|
saved budgets. Ordinary Product E2E evidence packaging, redaction, cleanup, failure
|
|
classification and dashboards own the result. The definition digest includes the
|
|
query, defaults, flow and grader sources.
|
|
Individual saved-state checks are also recorded when the journey fails, so the
|
|
report shows partial progress without turning it into a passing workflow.
|
|
|
|
The grader rejects duplicate tasks, wrong owners/projects/companies, early execution,
|
|
missing audit attribution, missing or stale deliverables, extra human nudges and
|
|
uncorrelated completion replies. Document provenance binds the current revision
|
|
to Morgan's actual run. The completion check reuses `completionDelivery`; a
|
|
handoff promise or a marker alone cannot establish delivery. Chromium verifies
|
|
the task link and reload persistence.
|
|
|
|
The checks establish the specified saved state, two-sentence structure, required
|
|
brief facts and result access. They do not score writing quality or every semantic
|
|
claim in the response. Inspect the retained conversation and announcement before
|
|
accepting the first samples; the existing completion semantic-review rubric still
|
|
applies. Oracle calibration tests exercise both valid evidence and plausible wrong
|
|
outcomes without calling a model.
|
|
|
|
Only after this loop is stable should another scenario be promoted. Keep each
|
|
starting condition explicit: connected versus missing connection, allowed versus
|
|
approval-required, and so on. Reuse the fixture/report infrastructure and add a
|
|
case-specific outcome oracle; do not make all YAML paragraphs executable through
|
|
an unconstrained model judge.
|
|
|
|
## Initial measurement — 2026-10-26
|
|
|
|
Three fresh samples per cell on definition
|
|
`7fb20426ce3f1dd4efeddfb79f231336ea65a16b9c2a73bf6131e997acd74e9d`
|
|
produced **5/6 passes**: backlog creation 3/3 and delegation 2/3. These used local
|
|
native Codex subscription execution with `gpt-5.6-sol`. All six cleaned up
|
|
successfully. Both workflows have successful browser-to-provider evidence, but
|
|
the initial repeatability target is not met.
|
|
|
|
In campaign `local-2026-10-26T15-48-12-199Z`, the first CEO run in delegation
|
|
failed before creating a task: `runnerd did not report the provider turn identity`.
|
|
Retained events show submission and provider startup, followed by the transport's
|
|
turn-start deadline. The precise cause of the missing event remains unresolved;
|
|
the existing machine classification is retained without claiming that the provider
|
|
or infrastructure has been proven responsible. Investigate this before expanding
|
|
the suite. No replacement sample erased this failure.
|
|
|
|
The local `results/chat-feature-acceptance/acceptance.md` records every sample and
|
|
earlier failed revision; its sibling dashboard uses the standard report generator.
|
|
Results are ignored generated artifacts, so retain or publish them through the
|
|
existing Product E2E pipeline when handing this measurement to another machine.
|
|
|
|
### Follow-up measurement — 2026-10-26
|
|
|
|
The unchanged delegation cell subsequently passed three fresh executions:
|
|
`local-2026-10-26T16-50-50-751Z`, `local-2026-10-26T16-54-58-203Z`, and
|
|
`local-2026-10-26T16-58-39-074Z`. The latter two campaigns also ran backlog
|
|
creation concurrently and passed both cells. All five selected executions used
|
|
one attempt with zero automatic retries, retained the same definition above,
|
|
and passed cleanup. Five existing turn-identity, early-terminal and runner-exit
|
|
regressions passed as well.
|
|
|
|
These are green rechecks, not a demonstrated repair of the earlier startup
|
|
interruption: no production code, timing limits or oracle assertions changed,
|
|
and the missing turn-start event did not reproduce. Keep the original failure
|
|
in the history. Across the original final-definition batch and this recheck,
|
|
backlog is 5/5 and delegation is 5/6. The local
|
|
`results/chat-feature-recheck/verification.md` records the follow-up evidence;
|
|
its standard dashboard is explicitly scoped to the latest campaign.
|
|
|
|
## Retired TestOps plans
|
|
|
|
The one-case **Chat feature evals** plan and three-case
|
|
**Chat completion pilot — OpenCode 1017** plan are retired. Their scenarios are
|
|
included in the [full catalog](#full-catalog-in-testops). Use that plan or select
|
|
cases from it; do not recreate the smoke or pilot plans.
|
|
|
|
The former `chat-feature-testops.yml` and `chat-completion-testops.yml` workflows
|
|
are removed. Their bootstrap functions reject registration before any API call
|
|
or mutation marker. Shared transport, evidence, export and verification helpers
|
|
remain for the full-catalog workflow and retained historical evidence. Retiring a
|
|
plan does not delete its cases, results, launches or private evidence.
|
|
|
|
Retained launch helpers encode TestOps name filters as Base64 of UTF-8 JSON in
|
|
`search`. Plain name text returns HTTP 400. Their nonce and once-only guards
|
|
remain unchanged; this transport contract does not restore the retired plans.
|
|
|
|
## Full catalog in TestOps
|
|
|
|
The [Chat catalog TestOps workflow](../../.github/workflows/chat-catalog-testops.yml)
|
|
registers all 244 scenarios from the 35 YAML areas in a separate
|
|
**Chat feature catalog — OpenCode 1017 (candidate)** plan. Its source-derived
|
|
manifest is `chat-full-catalog-testops-manifest.json`. This is the active chat
|
|
plan. The former backlog and three-case pilot plans are retired; their cases
|
|
and measured history are preserved.
|
|
Legacy aliases reuse existing TestOps case identities without renaming them.
|
|
|
|
The catalog contains 236 Agent Chat routes, five browser boundaries, one external
|
|
assistant route and two Slack routes. An execution mapping is not a passing
|
|
measurement. Five implementations declare incomplete coverage. Six routes do not
|
|
produce the generic final PNG required by the unchanged evidence owner. Eighteen
|
|
declare additional credentials and 37 declare external inputs. These groups
|
|
overlap. Exact requirements and limitations appear in each case's preconditions.
|
|
A declared credential does not establish whether its runtime reference exists.
|
|
|
|
This lane runs the app and fixtures from candidate
|
|
`3b66c3c144360ddf32714a0742fd774b8ceafb16`. Its app and domain definitions are
|
|
unchanged from `de0941835cc8f0d01c982574ee258e110babdbeb`; the successor adds only
|
|
finite TestOps host admission. Trusted selection, evidence transfer and publishing
|
|
use the workflow's immutable master revision. Each result records both revisions.
|
|
A pass qualifies that candidate measurement, not the current master app. Other
|
|
lanes sharing a case retain their own sources. This integration does not merge
|
|
the broad catalog branch or its core fixes, reset earlier campaign ordinals, or
|
|
change the previous 196-of-244 acceptance gate.
|
|
|
|
Native execution uses OpenCode and
|
|
`openrouter/deepseek/deepseek-v4.1-flash-1017` on the existing AWS fleet. Each case
|
|
keeps its original query, oracle, run counts, clocks, budgets and zero automatic
|
|
retries. Browser boundaries and the external assistant retain their original
|
|
surfaces and may have zero native work runs. The external companion keeps its own
|
|
declared provider requirement. Setup inference and unpriced usage are not free.
|
|
|
|
Initial setup uses the existing reporting environment:
|
|
|
|
1. Dispatch reviewed master with `operation=bootstrap`. It reconciles the exact
|
|
244 cases and the dedicated plan, then registers and binds its own GitHub job.
|
|
Missing cases use one marked POST each. Existing cases retain their identities
|
|
and history. Alias conflicts, foreign selections and uncertain writes stop
|
|
setup. It makes no model call or synthetic test result.
|
|
2. Read the registration receipt. Store its compact `binding` JSON as
|
|
`CHAT_FULL_CATALOG_TESTOPS_BINDING`. It contains observed plan, job, integration
|
|
and case IDs plus registered full names, and fits one GitHub environment
|
|
variable. The job must retain its observed single `Branch/defaultValue`
|
|
definition for `refs/heads/master`.
|
|
3. Use normal TestOps **Run** for the full plan or a selected subset. The service's
|
|
actual expected case list controls execution. Do not manually dispatch another
|
|
evaluation after an uncertain request. Initial route verification uses a small
|
|
selection and does not qualify all 244 cases.
|
|
|
|
Each worker executes one case. Selections of up to three cases run serially.
|
|
Larger selections allow eight independent cases and one external-input case at
|
|
once. External-input cases remain serial because they can share QA resources.
|
|
A full run can take hours. Its elapsed time depends on setup and fleet capacity;
|
|
the declared case clocks are not a completion-time guarantee. Each worker and
|
|
report reader has a singleton private-evidence approval and exact-key AWS
|
|
session; the existing eight-cell
|
|
authority limit is unchanged. Reports wait for all selected workers. A
|
|
credential-free job then validates and merges their metadata projections. The
|
|
protected reporter uploads original outcomes and verifies every selected result,
|
|
including paginated selections over 100 cases. Failed originals and failed
|
|
cleanup remain failed beside passed results. Missing originals cannot become
|
|
fabricated measurements or a full-selection pass.
|
|
|
|
Raw evidence and final PNGs remain in protected storage. Public GitHub artifacts
|
|
and TestOps attachments contain only allowlisted provenance, checks, accounting
|
|
and private-evidence receipts. Raw conversations, screenshots, provider sessions
|
|
and credentials do not enter the public artifact path. Additional credentials
|
|
reach only cases that declare them. External inputs use the existing selected-case
|
|
private-input owner, disposable-resource checks and oracle commitments.
|
|
Unconfigured inputs remain setup blockers.
|