Files
PaperClipAI/doc/ci-profiling.md
T
DottaandPaperclip 7420af26fc fix(ci): finish large Honeycomb profile exports (#16423)
## Thinking Path

> - Paperclip uses pull request CI to check changes before merge.
> - The merged CI profiler records a selected full PR suite in
Honeycomb.
> - A real 48-job profile exposed an export failure after Honeycomb
accepted only part of the trace.
> - The same run exposed three fixture subprocesses that looked like
incomplete test launches, one direct reporter without a launcher marker,
and one overlong test name.
> - The exporter needs to handle temporary ingest rejection without
sending accepted spans again.
> - This pull request fixes those cases and documents the trace display
limit.
> - The benefit is a complete, checkable CI waterfall with test-file
timings.

## Linked Issues or Issue Description

**What happened?**

The first live `profile-ci` run on #16423 completed all 48 jobs, but the
post-run exporter stopped when Honeycomb rejected part of a batch. The
initial trace had no root span. Its coverage flag also reported four
unfinished invocations and one invalid timing record.

**Expected behavior**

The exporter should pace large uploads, retry only temporarily rejected
events, and publish the root after every child is accepted. Completed
reporters should count as complete. Long test names should not erase
test timing.

**Steps to reproduce**

1. Add `profile-ci` to a CI CODEOWNER PR with the merged profiler.
2. Run the full PR suite, as in [run
38732093469](https://github.com/paperclipai/paperclip/actions/runs/38732093469).
3. Inspect the separate [failed exporter
run](https://github.com/paperclipai/paperclip/actions/runs/38733393370)
and the trace coverage fields.

**Paperclip version or commit**

`12612b06eb4332844ac4c8770a1fb6c6b7eccbc9` (PR run head, based on merged
#16378).

## What Changed

- Pace Honeycomb uploads and retry only transiently rejected events from
each batch.
- Preserve overlong test timings with bounded names and count complete
reporter pairs without a launcher record.
- Keep nested Vitest fixture runs from inheriting CI profiling and
creating false coverage gaps.
- Clarify ordinary CI access, large-trace display limits, and export
behavior in the operator guide.

## Verification

- [Full PR
suite](https://github.com/paperclipai/paperclip/actions/runs/38732093469/attempts/1):
48 of 48 jobs succeeded; 10m 29s wall time. The selected jobs used the
AWS public PR fleet. The protected exporter used a separate
GitHub-hosted runner.
- [Clean Honeycomb file
waterfall](https://ui.honeycomb.io/paperclip/environments/test/datasets/paperclip-ci/trace?trace_id=01ed0c541b0442e613a030ffb6dc8d9b&trace_start_ts=1792065955&trace_end_ts=1792066584):
48 jobs, 822 steps, 2,622 file spans, and `ci.profile_complete=true`. It
was reconstructed from that run's 45 timing artifacts after identifying
three nested fixture records. The full trace also recorded 44,497 tests;
Honeycomb's chart omits some deep test spans because it displays at most
32,000 spans per trace.
- The original exporter stopped after a partially accepted batch. A
local replay of that batch succeeded. I used the authorized local
test-environment key to complete the original upload and create the
file-level view. No key was added to this branch or PR.
- `node --test .github/scripts/tests/ci-profile.test.mjs
scripts/ci-profile/reporters.test.mjs`: 18 passed.
- `pnpm exec vitest run
server/src/__tests__/vitest-chat-shards.test.ts`: 1 passed.
- `git diff --check`: passed.
- The local `pnpm -r typecheck` and profiled fixture rerun could not
start: the package-manager shim could not verify the `pnpm@9.15.4`
registry signature because its fetches failed. `pnpm test:run` and `pnpm
build` were not run locally; hosted CI is pending.
- The updated exporter has not yet run from protected `master`; this PR
remains draft until CI and review finish.

## Risks

- A 48,000-span export now takes about three extra minutes due to
pacing. Retry limits still fail a persistently rejected batch and keep
the root unpublished.
- Honeycomb may retain duplicates from an already partial export. The
clean file-level evidence trace uses a separate trace ID.
- The API key stays only in the protected `ci-profiling` environment. PR
jobs write timing artifacts but never receive it.

> For core feature work, check [`ROADMAP.md`](ROADMAP.md) first and
discuss it in `#dev` before opening the PR. Feature PRs that overlap
with planned core work may need to be redirected — see
`CONTRIBUTING.md`.

## Model Used

OpenAI Codex, GPT-6 family, with reasoning, code execution, GitHub API,
and browser inspection. The runtime does not expose the exact serving
model ID or context window size.

## Checklist

- [x] I have included a thinking path that traces from project context
to this change
- [x] I have specified the model used (with version and capability
details)
- [x] I have checked ROADMAP.md and confirmed this PR does not duplicate
planned core work
- [x] I have searched GitHub for duplicate or related PRs and linked
them above
- [x] I have either (a) linked existing issues with `Fixes: #` /
`Closes: #` / `Refs: #` OR (b) described the issue in-PR following the
relevant issue template
- [x] I have not referenced internal/instance-local Paperclip issues or
links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip`
URLs)
- [x] My branch name describes the change (e.g. `docs/...`, `fix/...`)
and contains no internal Paperclip ticket id or instance-derived details
- [x] I have run tests locally and they pass
- [x] I have added or updated tests where applicable
- [x] I have updated relevant documentation to reflect my changes
- [x] I have considered and documented any risks above
- [ ] All Paperclip CI gates are green
- [ ] Greptile is 5/5 with no open P2s, recommendations, or follow-ups
- [x] I will address all Greptile and reviewer comments before
requesting merge

---------

Co-authored-by: Paperclip <noreply@paperclip.ing>
2026-10-15 07:51:02 -05:00

157 lines
9.4 KiB
Markdown

# Profile the complete PR suite
Add the `profile-ci` label to a PR authored by a CI CODEOWNER. Adding the label starts a fresh `PR` workflow
run. Further pushes while the label remains also run with profiling enabled.
The run is named **CI profile · PR #number**. It runs all lanes of the main PR
suite, including middle-of-stack and release-notes-only PRs that normally skip
most lanes.
After the run finishes, open its Summary and follow **Open the Honeycomb
waterfall**. The separate **CI profile** workflow exports the trace after all
jobs finish. Its summary has the exact time range, job/span counts, and coverage
warnings. Keep the label on the PR and its head unchanged until export finishes.
Remove the label to stop profiling subsequent pushes. To profile the same
revision again, remove and re-add the label or rerun all jobs.
The PR author, original workflow actor, and rerun actor must all be individual
users in the trusted `master` branch's `.github/**` CODEOWNERS rule. GitHub user
IDs are resolved from that rule; PR edits to CODEOWNERS cannot grant access.
A label on an outside contributor's PR does not enable profiling, even when a
maintainer applies it. The PR still runs normal CI and needs no Honeycomb
access. Failed identity lookups disable profiling.
Ordinary PRs do not write timing artifacts or export traces. The exporter job is
skipped for ordinary run names. Adding another label does not run the CI matrix.
Profiling preserves the existing trusted AWS runner routing. Eligible PR jobs
use `paperclip-public-pr-x64`; the routing gate uses `paperclip-ci-routing-x64`.
The existing fail-closed GitHub-hosted fallback still applies if AWS routing
cannot be authorized. Only the separate post-run Honeycomb exporter uses
`ubuntu-latest` directly; it is outside the measured PR suite.
## Read the waterfall
The workflow root measures elapsed time from run creation to the last job's
completion. For reruns, it starts at that attempt's `run_started_at` instead of
the original creation time. Every job is a child on the same wall clock, with
its steps and available test details beneath it. All spans use a sample rate of
one. There is no sampling within the selected attempt. For a compact Gantt view,
open a job row's menu and choose **Collapse spans at this depth**. Expand an
individual job to inspect its steps and test files.
The expandable hierarchy is **workflow → job → step → test filename → tests**.
Vitest, Playwright, and Node file rows use repository-relative filenames, also
available in `test.file`. Separate files retain their own children even when
individual test names repeat across files.
Honeycomb shows only the 32,000 spans closest to the root in a very large trace.
All file rows are near the root, but the chart can omit some individual test
rows. Use **View events** to query all recorded test spans. Test names are
limited to 256 characters in the trace; file paths remain intact.
- Compare the jobs that finish last (`ci.finishes_last`) with other overlapping
work. A long job that finishes early is not necessarily delaying CI.
- Expand setup, dependency installation, cache restore, Rust compilation, builds,
and tests to find repeated or slow work.
- `ci.execution_ms` measures a job's execution. `ci.start_offset_ms` shows when
it started relative to the whole run. Do not add parallel job durations to
calculate elapsed time.
- Waiting spans cover job creation to runner start. Dependency waits can occur
before GitHub creates a job, so they appear as gaps from the workflow start.
GitHub does not expose a separate ready timestamp; do not interpret every gap
as runner queue time or claim this is a computed dependency critical path.
GitHub job/step timestamps have second precision. Vitest and Playwright record
test timestamps at the runner. Node's test reporter records completion receipt
time and duration (`test.clock=reporter-receipt`); buffered IPC delivery can shift
those small test spans. Vitest file spans include its test/hook execution and
carry collection/setup durations as fields. Playwright file spans cover the
first through last test attempt in that file. Rust and standalone script checks
retain their full job/step timings; stable libtest does not expose per-test wall
timestamps. The trace is CI timing data, not application tracing.
Scope includes all main PR lanes: policy, typecheck/release registry, general and
serialized tests, Runner checks, Docker context checks, build, canary dry run,
browser E2E, and aggregate checks. Separate Storybook, image, deployment, release,
and live-provider eval workflows are outside this trace.
## Failure, coverage, and reruns
The exporter uses GitHub's attempt-specific job API and paginates jobs and
artifacts. It includes failed and cancelled jobs and uploads available test
timings with `always()`. A force-cancelled or failed setup job may leave no
artifact. Coverage warnings and `ci.profile_complete=false` make missing
artifacts, interrupted reporters, rejected data, and absent test details visible.
Test launchers write an expected-invocation record before starting each Vitest,
Playwright, or Node process. Each reporter must write matching start/end records,
so a missing reporter cannot hide behind another successful invocation in the
same job. Direct package scripts can start a reporter without the launcher;
their start/end pair proves collection. Compare `ci.expected_invocations` with
`ci.reported_invocations`.
Failed or cancelled workflows are conservatively incomplete because a failed
command can prevent later tests or steps from running.
Each attempt gets a different trace ID. Rerunning failed jobs alone produces an
attempt trace for those jobs; it does not replay completed jobs. Reruns are marked
`ci.partial_rerun=true` conservatively. Use a fresh label-triggered run for an
unambiguous full-suite baseline. GitHub may carry earlier successful jobs into
the new attempt's job inventory. Jobs completed before the new attempt started
are excluded and counted in `ci.carried_job_count`.
The exporter sends bounded batches with pauses and retries only events that
Honeycomb rejects temporarily. If export still fails, inspect **CI profile**
before rerunning it. A partial HTTP export may already have sent some spans;
reruns use the same IDs but the Events API does not promise deduplication. Timing artifacts
remain available for 14 days. Invalid/oversized artifacts stop export instead of
silently truncating the suite. No logs, environment dumps, error messages, stack
traces, or credentials are included in the exported field allowlist.
## Operator setup and activation
Use the existing Honeycomb `paperclip` team, `test` environment, and a separate
service dataset named `paperclip-ci`. Create GitHub environment `ci-profiling` with **Selected branches and tags**:
allow only the branch `master`, with no PR-ref or tag patterns. Store environment
secret `HONEYCOMB_CI_API_KEY` with a dedicated ingest-only key for the Honeycomb
`test` environment. Do not create a repository- or organization-level secret of
that name: the environment restriction prevents in-repository PR workflows from
requesting the key. Tests still execute the PR branch; only the separate exporter
runs from `master`. It needs event
ingest permission; dataset creation permission is needed only if the dataset
has not been created yet. Do not store the environment configuration key in CI.
Create the repository label `profile-ci` if it does not exist.
`ci-profile.yml` runs from the trusted default-branch revision. It checks out only
the exporter, installs no dependencies, and parses PR artifacts as bounded JSON
without extracting or executing their contents. The PR jobs never receive the
Honeycomb key. The exporter independently verifies CI CODEOWNER identities,
the current label, repository, and exact tested PR revision before reading
artifacts or sending data. Its credential is sent only in an HTTPS header to
`api.honeycomb.io`; redirects are rejected. Exported fields are allowlisted.
`CODEOWNERS` also covers `scripts/ci-profile/**`, so changes to the privileged
exporter require infrastructure-owner review.
The new trusted workflow and routing definitions must merge to master before
the label-triggered journey is active. A PR uses `pr-trusted.yml@master` and
`ci-routing.yml@master`; do not change those trust references just to test this
feature before merge.
## Local qualification
```sh
node --test .github/scripts/tests/ci-profile.test.mjs .github/scripts/tests/ci-routing.test.mjs
node --test scripts/ci-profile/reporters.test.mjs
actionlint .github/workflows/{pr,pr-trusted,ci-routing,ci-profile}.yml
node scripts/ci-profile/export.mjs --run-id=RUN_ID --attempt=1 --historical --dry-run --output=/tmp/ci-trace.json
```
`--historical` is local-only and permits a deliberate export of an existing
unlabeled run. It has complete GitHub job/step timing but cannot reconstruct
test details that were never recorded. Omit `--dry-run` and supply
`HONEYCOMB_CI_API_KEY` to send the selected baseline to Honeycomb. It is labeled
as historical/incomplete test coverage; it is not proof of the label-triggered
workflow.
References: [Honeycomb trace fields](https://docs.honeycomb.io/get-started/best-practices/organizing-data/),
[Events API](https://docs.honeycomb.io/api/events/create-events),
[large trace display limit](https://docs.honeycomb.io/troubleshoot/common-issues/data-in-honeycomb/#your-very-large-trace-displays-only-32000-spans),
[GitHub workflow_run](https://docs.github.com/en/actions/reference/workflows-and-actions/events-that-trigger-workflows#workflow_run).