mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-11-12 22:56:58 +01:00
## Thinking Path
> - Paperclip is the open source app people use to manage AI agents for
work
> - The board UI reads the company project list in many places: the
sidebar, starred projects, the command palette, the new-task dialog, and
archive-aware pages such as the Mine inbox
> - Active-only consumers read `GET /projects`, and archive-aware ones
read `GET /projects?includeArchived=true`, under two React Query keys
> - A Mine load therefore fetched the same large payload twice (580–590
KB each on our dev instance)
> - The two responses differ only by archived rows; the server's active
list is exactly the rows where `archivedAt` is null
> - This pull request makes every consumer share the
`includeArchived=true` query, and active-only consumers filter it with
`select`
> - The benefit is one project read per page instead of two
## Linked Issues or Issue Description
**What existing behavior does this improve?**
Duplicate project list reads on page load.
**Subsystem affected**
Board UI project queries (`ui/src/lib/company-projects-query.ts` and its
consumers).
**Current behavior**
A cold Mine load sends both `/companies/:id/projects` (sidebar) and
`/companies/:id/projects?includeArchived=true` (inbox).
**Proposed behavior**
One `includeArchived=true` read serves both. Active-only consumers apply
`selectActiveProjects`.
**Reason and benefit**
The project list is one of the largest shell payloads. Reading it once
saves a large response on every page that has both kinds of consumer.
## What Changed
- New `companyProjectsQuery(companyId, { includeArchived? })` in
`ui/src/lib/company-projects-query.ts`. It always uses the
`includeArchived: true` key and fetch. For active-only use it adds a
stable, module-level `select` that keeps rows without `archivedAt`.
- 22 files that read the active list now spread
`companyProjectsQuery(...)`, and so do the plugin SDK project picker and
16 archive-aware pages that wrote the shared key and fetcher inline.
Their `enabled` and other options are unchanged. `OnboardingWizard`'s
one imperative read is unchanged. `pages/Inbox.tsx` already reads the
same key and fetcher, so it shares the entry without an edit.
- Invalidation: project mutations and live events invalidate
`queryKeys.projects.all(companyId)`, which matches the shared key. The
onboarding wizard invalidated the old active-only key; it now
invalidates `projects.all`.
- Tests: new `company-projects-query.test.tsx` (one request for both
consumers, correct filtering, and one refetch after `projects.all`
invalidation). Three existing tests (`CommandPalette`, `CompanyExport`,
`GitHubBotManagement`) now seed or expect the shared key.
- New browser check
`tests/perf/collections/shared-project-list.spec.ts`: after the Mine
inbox read completes, the page has sent no active-only project request.
## Verification
- `pnpm verify` passes.
- `ui`: the consumer suites (`CoordinatorSidebar`, `SidebarProjects`,
`SidebarStarredProjects`, `CommandPalette`, `NewIssueDialog`,
`AgentWorkPanels`, `CoordinatorNeedsYou`, `IssueDetail`,
`ProjectDetail`, `Projects`, `CompanyExport`, `ChatExecutionDefaults`,
`GatewaysList`, `Search`, `IssueProperties`, `persisted-query-cache`)
pass.
- Browser check:
`PAPERCLIP_COLLECTION_PERF_BASE_URL=http://127.0.0.1:<port> pnpm exec
playwright test --config tests/perf/collections/playwright.config.ts
shared-project-list.spec.ts`. It passes on this branch and fails on
`master`.
## Risks
- A page that needs only active projects now downloads archived rows
too. For most companies that is a small difference; the duplicate read
it removes is a full copy.
- The server does not order either list, and consumers sort for display,
so filtering on the client keeps behavior.
## Model Used
- Claude Opus 5.5 (`claude-opus-5-5`), Anthropic, via Claude Code with
tool use (shell, file edits, browser). 1M-token context window. Extended
thinking was off.
## Checklist
- [x] I have included a thinking path that traces from project context
to this change
- [x] I have specified the model used (with version and capability
details)
- [x] I have checked ROADMAP.md and confirmed this PR does not duplicate
planned core work
- [x] I have searched GitHub for duplicate or related PRs and linked
them above
- [x] I have either (a) linked existing issues with `Fixes: #` / `Closes
#` / `Refs #` OR (b) described the issue in-PR following the relevant
issue template
- [x] I have not referenced internal/instance-local Paperclip issues or
links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip`
URLs)
- [x] My branch name describes the change (e.g. `docs/...`, `fix/...`)
and contains no internal Paperclip ticket id or instance-derived details
- [x] I have run tests locally and they pass
- [x] I have added or updated tests where applicable
- [x] I have updated relevant documentation to reflect my changes
- [x] I have considered and documented any risks above
- [ ] All Paperclip CI gates are green
- [ ] Greptile is 5/5 with no open P2s, recommendations, or follow-ups
- [x] I will address all Greptile and reviewer comments before
requesting merge
🤖 Generated with [Claude Code](https://claude.com/claude-code)
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
452 lines
16 KiB
TypeScript
452 lines
16 KiB
TypeScript
import { AgentIdentity } from "@/components/AgentIdentity";
|
|
import { useCombinedInboxTasksEnabled } from "@/hooks/useCombinedInboxTasksEnabled";
|
|
import { useState, useEffect, useMemo } from "react";
|
|
import { useLocation, useNavigate } from "@/lib/router";
|
|
import { useQuery } from "@tanstack/react-query";
|
|
import { useCompany } from "../context/CompanyContext";
|
|
import { useDialogActions } from "../context/DialogContext";
|
|
import { useSidebar } from "../context/SidebarContext";
|
|
import { issuesApi } from "../api/issues";
|
|
import { authApi } from "../api/auth";
|
|
import { agentsApi } from "../api/agents";
|
|
import { instanceSettingsApi } from "../api/instanceSettings";
|
|
import { queryKeys } from "../lib/queryKeys";
|
|
import {
|
|
CommandDialog,
|
|
CommandEmpty,
|
|
CommandGroup,
|
|
CommandInput,
|
|
CommandItem,
|
|
CommandList,
|
|
CommandSeparator,
|
|
} from "@/components/ui/command";
|
|
import {
|
|
CircleDot,
|
|
Bot,
|
|
Hexagon,
|
|
Target,
|
|
LayoutDashboard,
|
|
Inbox,
|
|
DollarSign,
|
|
History,
|
|
SquarePen,
|
|
FileCode2,
|
|
Plus,
|
|
Search,
|
|
} from "lucide-react";
|
|
import { Identity } from "./Identity";
|
|
import { agentUrl, projectUrl } from "../lib/utils";
|
|
import {
|
|
SEARCH_OPERATOR_QUICK_FILTERS,
|
|
buildSearchPathFromQuery,
|
|
parseSearchQuery,
|
|
type SearchQueryParserContext,
|
|
} from "../lib/search-query-parser";
|
|
import { companyProjectsQuery } from "@/lib/company-projects-query";
|
|
|
|
const SEARCH_ALL_VALUE = "__paperclip-search-all__";
|
|
|
|
export function buildFullSearchPath(query: string, context: SearchQueryParserContext = {}) {
|
|
return buildSearchPathFromQuery(query, context);
|
|
}
|
|
|
|
const ISSUE_DETAIL_PATH_RE = /\/issues\/[^/?#]+(?:$|\?|#|\/)/;
|
|
|
|
function isOnIssueDetail(pathname: string): boolean {
|
|
return ISSUE_DETAIL_PATH_RE.test(pathname);
|
|
}
|
|
|
|
/** Max promoted project matches kept when typing in the palette. */
|
|
const MAX_MATCHED_PROJECTS = 5;
|
|
/** Task cap when projects are also promoted, so Tasks can't crowd them out. */
|
|
const TASK_LIMIT_WITH_PROJECTS = 6;
|
|
const TASK_LIMIT = 10;
|
|
|
|
/** True when every char of `needle` appears in `haystack` in order (fuzzy). */
|
|
function isSubsequence(needle: string, haystack: string): boolean {
|
|
let i = 0;
|
|
for (let j = 0; j < haystack.length && i < needle.length; j += 1) {
|
|
if (haystack[j] === needle[i]) i += 1;
|
|
}
|
|
return i === needle.length;
|
|
}
|
|
|
|
/**
|
|
* Score a project against a lowercased query. Higher is a better match;
|
|
* `null` means no match. Prefers name hits (exact > prefix > substring) over
|
|
* description hits, with fuzzy subsequence as a last resort.
|
|
*/
|
|
function scoreProjectMatch(name: string, description: string, q: string): number | null {
|
|
if (name === q) return 1000;
|
|
// Shorter names rank first, but clamp the length penalty so a prefix match can
|
|
// never sink below the substring band (max 699) for unusually long names —
|
|
// keeps the prefix > substring > description > fuzzy ordering invariant.
|
|
if (name.startsWith(q)) return Math.max(700, 900 - name.length);
|
|
const nameIdx = name.indexOf(q);
|
|
if (nameIdx >= 0) return 700 - nameIdx;
|
|
if (description.includes(q)) return 400;
|
|
if (isSubsequence(q, name)) return 200;
|
|
return null;
|
|
}
|
|
|
|
export function CommandPalette() {
|
|
const [open, setOpen] = useState(false);
|
|
const [query, setQuery] = useState("");
|
|
const navigate = useNavigate();
|
|
const location = useLocation();
|
|
const { selectedCompanyId } = useCompany();
|
|
const { openNewIssue, openNewAgent } = useDialogActions();
|
|
const { isMobile, setSidebarOpen } = useSidebar();
|
|
const searchQuery = query.trim();
|
|
const onIssueDetail = isOnIssueDetail(location.pathname);
|
|
const { data: experimentalSettings } = useQuery({
|
|
queryKey: queryKeys.instance.experimentalSettings,
|
|
queryFn: () => instanceSettingsApi.getExperimental(),
|
|
});
|
|
const { enabled: combinedInboxTasksEnabled } = useCombinedInboxTasksEnabled();
|
|
const fileViewerEnabled = experimentalSettings?.enableExperimentalFileViewer === true;
|
|
|
|
useEffect(() => {
|
|
function handleKeyDown(e: KeyboardEvent) {
|
|
if (e.key === "k" && (e.metaKey || e.ctrlKey)) {
|
|
e.preventDefault();
|
|
setOpen(true);
|
|
if (isMobile) setSidebarOpen(false);
|
|
}
|
|
}
|
|
document.addEventListener("keydown", handleKeyDown);
|
|
return () => document.removeEventListener("keydown", handleKeyDown);
|
|
}, [isMobile, setSidebarOpen]);
|
|
|
|
useEffect(() => {
|
|
if (!open) setQuery("");
|
|
}, [open]);
|
|
|
|
const { data: agents = [] } = useQuery({
|
|
queryKey: queryKeys.agents.list(selectedCompanyId!),
|
|
queryFn: () => agentsApi.list(selectedCompanyId!),
|
|
enabled: !!selectedCompanyId && open,
|
|
});
|
|
|
|
const { data: allProjects = [] } = useQuery({
|
|
...companyProjectsQuery(selectedCompanyId!),
|
|
enabled: !!selectedCompanyId && open,
|
|
});
|
|
const projects = useMemo(
|
|
() => allProjects,
|
|
[allProjects],
|
|
);
|
|
|
|
const { data: labels = [] } = useQuery({
|
|
queryKey: queryKeys.issues.labels(selectedCompanyId!),
|
|
queryFn: () => issuesApi.listLabels(selectedCompanyId!),
|
|
enabled: !!selectedCompanyId && open,
|
|
});
|
|
|
|
const { data: session } = useQuery({
|
|
queryKey: queryKeys.auth.session,
|
|
queryFn: () => authApi.getSession(),
|
|
enabled: open,
|
|
});
|
|
|
|
const currentUserId = session?.user?.id ?? session?.session?.userId ?? null;
|
|
const parserContext = useMemo<SearchQueryParserContext>(() => ({
|
|
currentUserId,
|
|
agents,
|
|
projects,
|
|
labels,
|
|
}), [agents, currentUserId, labels, projects]);
|
|
const parsedQuery = useMemo(() => parseSearchQuery(query, parserContext), [parserContext, query]);
|
|
const quickSearchQuery = parsedQuery.query.trim();
|
|
|
|
const { data: issues = [] } = useQuery({
|
|
queryKey: queryKeys.issues.list(selectedCompanyId!),
|
|
queryFn: () => issuesApi.list(selectedCompanyId!),
|
|
enabled: !!selectedCompanyId && open && searchQuery.length === 0,
|
|
});
|
|
|
|
const { data: searchedIssues = [] } = useQuery({
|
|
queryKey: queryKeys.issues.search(selectedCompanyId!, quickSearchQuery, undefined, 10),
|
|
queryFn: () => issuesApi.list(selectedCompanyId!, { q: quickSearchQuery, limit: 10, includeRoutineExecutions: true }),
|
|
enabled: !!selectedCompanyId && open && quickSearchQuery.length > 0,
|
|
});
|
|
|
|
function go(path: string) {
|
|
setOpen(false);
|
|
navigate(path);
|
|
}
|
|
|
|
function goFullSearch() {
|
|
go(buildFullSearchPath(searchQuery, parserContext));
|
|
}
|
|
|
|
const agentName = (id: string | null) => {
|
|
if (!id) return null;
|
|
return agents.find((a) => a.id === id)?.name ?? null;
|
|
};
|
|
|
|
const visibleIssues = useMemo(
|
|
() => (quickSearchQuery.length > 0 ? searchedIssues : issues),
|
|
[issues, searchedIssues, quickSearchQuery],
|
|
);
|
|
|
|
// Client-side typeahead ranking over the already-loaded projects. cmdk ranks
|
|
// items by their `value` (which defaults to the rendered name) and would bury
|
|
// or drop description-only matches, so we rank in JS and force-match below.
|
|
const matchedProjects = useMemo(() => {
|
|
if (quickSearchQuery.length === 0) return [];
|
|
const q = quickSearchQuery.toLowerCase();
|
|
return projects
|
|
.map((project) => ({
|
|
project,
|
|
score: scoreProjectMatch(
|
|
project.name.toLowerCase(),
|
|
(project.description ?? "").toLowerCase(),
|
|
q,
|
|
),
|
|
}))
|
|
.filter((entry): entry is { project: (typeof projects)[number]; score: number } => entry.score !== null)
|
|
.sort((a, b) => b.score - a.score)
|
|
.slice(0, MAX_MATCHED_PROJECTS)
|
|
.map((entry) => entry.project);
|
|
}, [projects, quickSearchQuery]);
|
|
|
|
const showSearchAll = searchQuery.length > 0;
|
|
const showPromotedProjects = showSearchAll && matchedProjects.length > 0;
|
|
const taskLimit = showPromotedProjects ? TASK_LIMIT_WITH_PROJECTS : TASK_LIMIT;
|
|
const showEmptyHint =
|
|
showSearchAll && visibleIssues.length === 0 && matchedProjects.length === 0;
|
|
|
|
return (
|
|
<CommandDialog open={open} onOpenChange={(v) => {
|
|
setOpen(v);
|
|
if (v && isMobile) setSidebarOpen(false);
|
|
}}>
|
|
<CommandInput
|
|
placeholder="Search tasks, agents, projects..."
|
|
value={query}
|
|
onValueChange={setQuery}
|
|
onKeyDown={(event) => {
|
|
if (event.key === "Enter" && (event.metaKey || event.ctrlKey)) {
|
|
event.preventDefault();
|
|
goFullSearch();
|
|
return;
|
|
}
|
|
if (event.key === "Enter" && showEmptyHint) {
|
|
event.preventDefault();
|
|
goFullSearch();
|
|
}
|
|
}}
|
|
/>
|
|
<CommandList>
|
|
<CommandEmpty>
|
|
{showSearchAll ? (
|
|
<span>
|
|
No quick task matches. Press{" "}
|
|
<kbd className="rounded border border-border bg-muted px-1 py-0.5 text-(length:--text-nano)">↵</kbd>{" "}
|
|
to <span className="font-medium">search all</span> or keep typing to refine.
|
|
</span>
|
|
) : (
|
|
"No results found."
|
|
)}
|
|
</CommandEmpty>
|
|
|
|
{showSearchAll ? (
|
|
<CommandGroup heading="Search">
|
|
<CommandItem
|
|
value={`${SEARCH_ALL_VALUE} ${searchQuery}`}
|
|
onSelect={goFullSearch}
|
|
className="bg-accent/40 border border-accent data-[selected=true]:bg-accent/60"
|
|
data-testid="command-search-all"
|
|
>
|
|
<Search className="mr-2 h-4 w-4" />
|
|
<span className="flex-1 truncate">
|
|
Search all for <span className="font-semibold">“{searchQuery}”</span>
|
|
</span>
|
|
<span className="ml-auto inline-flex items-center gap-1 text-xs text-muted-foreground">
|
|
<span>open full search</span>
|
|
<kbd className="rounded border border-border bg-background px-1 py-0.5 text-(length:--text-nano)">↵</kbd>
|
|
</span>
|
|
</CommandItem>
|
|
</CommandGroup>
|
|
) : null}
|
|
|
|
{showSearchAll ? <CommandSeparator /> : null}
|
|
|
|
<CommandGroup heading="Quick filters">
|
|
{SEARCH_OPERATOR_QUICK_FILTERS.map((chip) => (
|
|
<CommandItem
|
|
key={chip}
|
|
value={`quick-filter ${chip}`}
|
|
onSelect={() => setQuery((current) => current.trim() ? `${current.trim()} ${chip}` : chip)}
|
|
data-testid="command-filter-chip"
|
|
>
|
|
<Search className="mr-2 h-4 w-4" />
|
|
<span className="font-mono text-xs">{chip}</span>
|
|
</CommandItem>
|
|
))}
|
|
</CommandGroup>
|
|
|
|
<CommandSeparator />
|
|
|
|
{showPromotedProjects && (
|
|
<>
|
|
<CommandGroup heading="Projects">
|
|
{matchedProjects.map((project) => (
|
|
<CommandItem
|
|
key={project.id}
|
|
value={`${searchQuery} ${project.name}`}
|
|
onSelect={() => go(projectUrl(project))}
|
|
data-testid="command-project-match"
|
|
>
|
|
<Hexagon className="mr-2 h-4 w-4 shrink-0" />
|
|
<span className="min-w-0 truncate">{project.name}</span>
|
|
{project.description ? (
|
|
<span className="ml-2 hidden min-w-0 flex-1 truncate text-xs text-muted-foreground sm:inline">
|
|
{project.description}
|
|
</span>
|
|
) : null}
|
|
</CommandItem>
|
|
))}
|
|
</CommandGroup>
|
|
<CommandSeparator />
|
|
</>
|
|
)}
|
|
|
|
<CommandGroup heading="Actions">
|
|
<CommandItem
|
|
onSelect={() => {
|
|
setOpen(false);
|
|
openNewIssue();
|
|
}}
|
|
>
|
|
<SquarePen className="mr-2 h-4 w-4" />
|
|
Create new task
|
|
<span className="ml-auto text-xs text-muted-foreground">C</span>
|
|
</CommandItem>
|
|
{onIssueDetail && fileViewerEnabled && (
|
|
<CommandItem
|
|
onSelect={() => {
|
|
setOpen(false);
|
|
window.dispatchEvent(new CustomEvent("paperclip:open-file-viewer"));
|
|
}}
|
|
>
|
|
<FileCode2 className="mr-2 h-4 w-4" />
|
|
Open file in this issue...
|
|
<span className="ml-auto text-xs text-muted-foreground">g f</span>
|
|
</CommandItem>
|
|
)}
|
|
<CommandItem
|
|
onSelect={() => {
|
|
setOpen(false);
|
|
openNewAgent();
|
|
}}
|
|
>
|
|
<Plus className="mr-2 h-4 w-4" />
|
|
Create new agent
|
|
</CommandItem>
|
|
<CommandItem onSelect={() => go("/projects")}>
|
|
<Plus className="mr-2 h-4 w-4" />
|
|
Create new project
|
|
</CommandItem>
|
|
</CommandGroup>
|
|
|
|
<CommandSeparator />
|
|
|
|
<CommandGroup heading="Pages">
|
|
<CommandItem onSelect={() => go("/dashboard")}>
|
|
<LayoutDashboard className="mr-2 h-4 w-4" />
|
|
Dashboard
|
|
</CommandItem>
|
|
<CommandItem onSelect={() => go(combinedInboxTasksEnabled ? "/issues?view=mine" : "/inbox")}>
|
|
<Inbox className="mr-2 h-4 w-4" />
|
|
{combinedInboxTasksEnabled ? "My work" : "Inbox"}
|
|
</CommandItem>
|
|
<CommandItem onSelect={() => go("/issues")}>
|
|
<CircleDot className="mr-2 h-4 w-4" />
|
|
Tasks
|
|
</CommandItem>
|
|
<CommandItem onSelect={() => go("/projects")}>
|
|
<Hexagon className="mr-2 h-4 w-4" />
|
|
Projects
|
|
</CommandItem>
|
|
<CommandItem onSelect={() => go("/goals")}>
|
|
<Target className="mr-2 h-4 w-4" />
|
|
Goals
|
|
</CommandItem>
|
|
<CommandItem onSelect={() => go("/agents")}>
|
|
<Bot className="mr-2 h-4 w-4" />
|
|
Agents
|
|
</CommandItem>
|
|
<CommandItem onSelect={() => go("/costs")}>
|
|
<DollarSign className="mr-2 h-4 w-4" />
|
|
Costs
|
|
</CommandItem>
|
|
<CommandItem onSelect={() => go("/activity")}>
|
|
<History className="mr-2 h-4 w-4" />
|
|
Activity
|
|
</CommandItem>
|
|
</CommandGroup>
|
|
|
|
{visibleIssues.length > 0 && (
|
|
<>
|
|
<CommandSeparator />
|
|
<CommandGroup heading="Tasks">
|
|
{visibleIssues.slice(0, taskLimit).map((issue) => (
|
|
<CommandItem
|
|
key={issue.id}
|
|
value={
|
|
searchQuery.length > 0
|
|
? `${searchQuery} ${issue.identifier ?? ""} ${issue.title}`
|
|
: undefined
|
|
}
|
|
onSelect={() => go(`/issues/${issue.identifier ?? issue.id}`)}
|
|
>
|
|
<CircleDot className="mr-2 h-4 w-4" />
|
|
<span className="text-muted-foreground mr-2 font-mono text-xs">
|
|
{issue.identifier ?? issue.id.slice(0, 8)}
|
|
</span>
|
|
<span className="flex-1 truncate">{issue.title}</span>
|
|
{issue.assigneeAgentId && (() => {
|
|
const name = agentName(issue.assigneeAgentId);
|
|
return name ? <AgentIdentity agent={agents?.find((agent) => agent.id === issue.assigneeAgentId) ?? { id: issue.assigneeAgentId, name }} size="sm" className="ml-2 hidden sm:inline-flex" /> : null;
|
|
})()}
|
|
</CommandItem>
|
|
))}
|
|
</CommandGroup>
|
|
</>
|
|
)}
|
|
|
|
{agents.length > 0 && (
|
|
<>
|
|
<CommandSeparator />
|
|
<CommandGroup heading="Agents">
|
|
{agents.slice(0, 10).map((agent) => (
|
|
<CommandItem key={agent.id} onSelect={() => go(agentUrl(agent))}>
|
|
<Bot className="mr-2 h-4 w-4" />
|
|
{agent.name}
|
|
<span className="text-xs text-muted-foreground ml-2">{agent.role}</span>
|
|
</CommandItem>
|
|
))}
|
|
</CommandGroup>
|
|
</>
|
|
)}
|
|
|
|
{projects.length > 0 && !showSearchAll && (
|
|
<>
|
|
<CommandSeparator />
|
|
<CommandGroup heading="Projects">
|
|
{projects.slice(0, 10).map((project) => (
|
|
<CommandItem key={project.id} onSelect={() => go(projectUrl(project))}>
|
|
<Hexagon className="mr-2 h-4 w-4" />
|
|
{project.name}
|
|
</CommandItem>
|
|
))}
|
|
</CommandGroup>
|
|
</>
|
|
)}
|
|
</CommandList>
|
|
</CommandDialog>
|
|
);
|
|
}
|