mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-10-13 13:38:01 +02:00
## Thinking Path > - Paperclip is the open source app people use to manage AI agents for work. > - The server ships a copy of Paperclip Runner for native agent execution. > - The Claude ACP bridge is a runner dependency, but it was absent from the server package. > - The runner resolves this bridge dynamically, so the import-based packaging check missed it. > - A Claude session then failed before startup and showed a generic connection error. > - This pull request ships the qualified bridge and reports a missing runtime with repair steps. ## Linked Issues or Issue Description **What happened?** A server install with the vendored runner could not load `@agentclientprotocol/claude-agent-acp/package.json`. The runtime test suggested checking the model or provider connection. The task reported an interrupted runner session. **Expected behavior** The server package includes its qualified Claude ACP runtime. A missing bundled runtime reports an installation error and explains how to repair it. **Steps to reproduce** 1. Use a server install with the vendored runner and no Claude ACP bridge. 2. Select the Paperclip Runner ACP harness and the Claude provider. 3. Run the runtime test or open a session. 4. Observe a missing-module failure before Claude starts. **Paperclip version or commit** Reproduced on `e733bddc45`. This branch is based on current master. **Deployment mode** Self-hosted server built from source. Related: #15224 upgrades the Claude bridge. This PR fixes its omission from the server package and keeps the current qualified version. A future bridge upgrade must update the server pin too. ## What Changed - Add Claude ACP `0.73.0` to the server dependencies and bundled dependencies. - Pin the qualified Claude SDK and bridge dependencies in the npm bundle producer graph. Publish its native packages as consumer optional dependencies instead of shipping the producer executable. - Bind source-built vendored runners to the shared pnpm dependency store while retaining the server manifest as the provider authority. Keep published npm and self-rooted deployment roots unchanged. - Include dynamically resolved Claude and Codex bridges in the vendor dependency check. - Preserve the missing-package category through the sidecar, Rust transport, and native session executor. Stop automatic retries for this installation failure. - Show **Runtime missing** in the runtime test and task thread. Explain the reinstall or rebuild, server restart, and runtime test steps. - Add regression tests and document the repair procedure. ## Verification - Red/green comparison with the production sidecar: the same missing-package setup returns a raw require-stack error on the original code and an actionable, non-retryable missing-runtime error on this branch. - The rebuilt server's vendored Claude installation probe passes using the source-server authority selected by the launcher, without starting a provider or making a model request. - Focused server verification: 830 tests passed. Runner installation and sidecar error tests: 83 passed, with 6 platform-specific skips. Packaging tests: 28 passed. Rust transport tests: 7 passed. - Source/deployment authority tests: 3 passed. Red/green packaging tests include a Linux-produced Claude SDK bundle, actual npm pack, and closed executable admission on Linux x64 and macOS ARM64/x64. - Full UI suite: 8,113 tests passed. - `pnpm -r typecheck` and `pnpm build` passed on the rebased branch. - Full current-head CI passed, including all general and serialized test lanes, Runner Rust/Vitest verification, typecheck, build, and all eight e2e shards. Greptile reviewed `d6a2741834ff922956560f2f689382827bbaf9e0` at 5/5 with no unresolved threads. - Local full-suite limitation: an earlier parallel attempt hit Postgres startup failures and timeouts; the affected server tests and a database fixture passed in isolation. The subsequent serial `pnpm test:run` was stopped while still running after complete CI passed. Focused local tests, full UI tests, typecheck, and build completed as listed above. - Token gates and `git diff --check` passed. ## Risks - Bundling the Claude bridge increases the server package size. The producer graph retains the qualified SDK version and existing isolation patch. Native platform declarations move to the published server manifest, while the runtime keeps its exact version, declared-slot, no-follow, and executable digest checks. - The new failure category is permanent. Operators must repair the server installation before they retry the task. - Existing failed runs retain their recorded error. The clearer message applies to new runtime tests and runs. - No database schema or migration changes. ## Model Used OpenAI GPT-6 through Codex. The system reports the model family; the exact deployment ID and context-window size are not exposed in this session. Used reasoning, browser inspection, tool use, and code execution. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either (a) linked existing issues with `Fixes: #` / `Closes #` / `Refs #` OR (b) described the issue in-PR following the relevant issue template - [x] I have not referenced internal/instance-local Paperclip issues or links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip` URLs) - [x] My branch name describes the change (e.g. `docs/...`, `fix/...`) and contains no internal Paperclip ticket id or instance-derived details - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] All Paperclip CI gates are green - [x] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I will address all Greptile and reviewer comments before requesting merge --------- Co-authored-by: Paperclip <noreply@paperclip.ing>
161 lines
7.5 KiB
JavaScript
161 lines
7.5 KiB
JavaScript
// Verify every npm package the vendored paperclip-runner actually imports
|
|
// at runtime is also declared as a direct dependency of server/package.json.
|
|
//
|
|
// packages/paperclip-runner is private and never published, so the server
|
|
// build vendors its compiled dist/ tree wholesale with `cp -R` (see the
|
|
// `build` script's `... dist/vendor/paperclip-runner/` step) -- code only,
|
|
// no node_modules alongside it. Every npm package the vendored code
|
|
// actually imports is therefore also a runtime dependency of server once
|
|
// vendored, and has to be declared there too (see acpx, ajv). That mirror
|
|
// step is easy to forget -- it silently missed smol-toml in #13110, and CI
|
|
// stayed green while production crash-looped 3 seconds into every start
|
|
// (#13116) -- because nothing enforced it.
|
|
//
|
|
// This derives the required set from esbuild's own module-resolution scan
|
|
// of the entry points server actually imports (index.js, testing.js, live/index.js),
|
|
// with `write: false` so nothing is written to disk and `packages:
|
|
// "external"` so npm imports are reported, not inlined. That is precise:
|
|
// paperclip-runner declares dependencies (react-markdown, the codex/opencode
|
|
// CLI packages, ...) that only its unrelated ./react and ./browser export
|
|
// subpaths use, which server never imports, so requiring *every* declared
|
|
// dependency to be mirrored would be over-broad and demand dependencies
|
|
// server does not actually need.
|
|
//
|
|
// This intentionally only analyzes the module graph; it does not bundle or
|
|
// rewrite anything on disk. Several runner modules resolve sibling build
|
|
// artifacts -- the native runnerd binary, the ACPX/OpenCode CJS sidecar
|
|
// scripts in dist/cli, JSON replay fixtures under a top-level protocol/
|
|
// directory -- via `import.meta.url`-relative filesystem paths rather than
|
|
// JS imports, each at whatever nesting depth its source file happens to
|
|
// sit at. Actually bundling those entry points (an earlier version of this
|
|
// fix did) collapses and rearranges that layout, silently breaking those
|
|
// lookups. Preserving the original `cp -R` tree 1:1 is what keeps all of
|
|
// them working, so this script only verifies; it never restructures.
|
|
|
|
import { build } from "esbuild";
|
|
import { existsSync, readFileSync } from "node:fs";
|
|
import { builtinModules } from "node:module";
|
|
import { dirname, resolve } from "node:path";
|
|
import { fileURLToPath, pathToFileURL } from "node:url";
|
|
|
|
const serverRoot = resolve(dirname(fileURLToPath(import.meta.url)), "..");
|
|
const runnerRoot = resolve(serverRoot, "../packages/paperclip-runner");
|
|
const runnerDist = resolve(runnerRoot, "dist");
|
|
|
|
// The only entry points server/src actually imports from the vendored
|
|
// runner, including the installed-runtime readiness probe surface.
|
|
const ENTRY_POINT_NAMES = ["index.js", "testing.js", "live/index.js"];
|
|
|
|
const NODE_BUILTINS = new Set([
|
|
...builtinModules,
|
|
...builtinModules.map((name) => `node:${name}`),
|
|
]);
|
|
|
|
/** The npm package name a bare import specifier resolves to, honoring scoped packages and subpaths. */
|
|
function packageNameFromSpecifier(specifier) {
|
|
const segments = specifier.split("/");
|
|
return specifier.startsWith("@") ? segments.slice(0, 2).join("/") : segments[0];
|
|
}
|
|
|
|
export function findMissingVendorDependencies(importedPackageNames, declaredDependencyNames) {
|
|
return [...importedPackageNames]
|
|
.filter((name) => !declaredDependencyNames.has(name))
|
|
.sort();
|
|
}
|
|
|
|
export async function findRunnerExternalPackages(entryPoints) {
|
|
for (const entryPoint of entryPoints) {
|
|
if (!existsSync(entryPoint)) {
|
|
throw new Error(
|
|
`paperclip-runner vendor check: expected build output at ${entryPoint}. ` +
|
|
`Run "pnpm --filter @paperclipai/paperclip-runner build" first.`,
|
|
);
|
|
}
|
|
}
|
|
|
|
// write: false means this never touches disk -- it's a module-graph scan,
|
|
// not a real bundle. Vendoring itself still happens via `cp -R` elsewhere
|
|
// in the build script. `outdir` is required by esbuild for multiple entry
|
|
// points but nothing is ever written there, so any sibling path will do.
|
|
const result = await build({
|
|
entryPoints,
|
|
outdir: resolve(dirname(entryPoints[0]), ".vendor-dependency-scan"),
|
|
bundle: true,
|
|
write: false,
|
|
platform: "node",
|
|
format: "esm",
|
|
packages: "external",
|
|
metafile: true,
|
|
logLevel: "silent",
|
|
});
|
|
|
|
const externalPackageNames = new Set();
|
|
for (const output of Object.values(result.metafile.outputs)) {
|
|
for (const imported of output.imports) {
|
|
if (!imported.external) continue;
|
|
if (imported.path.startsWith(".") || NODE_BUILTINS.has(imported.path)) continue;
|
|
externalPackageNames.add(packageNameFromSpecifier(imported.path));
|
|
}
|
|
}
|
|
return externalPackageNames;
|
|
}
|
|
|
|
// Provider entrypoints are resolved with createRequire from profile metadata,
|
|
// so esbuild cannot see them. These two bridges ship in the server package;
|
|
// other ACP agents use separately provisioned provider packs.
|
|
export async function findRunnerRuntimePackages(entryPoints, profileData) {
|
|
const packages = await findRunnerExternalPackages(entryPoints);
|
|
for (const agent of ["claude", "codex"]) {
|
|
const profile = profileData?.profiles?.[agent];
|
|
if (profileData?.schema !== "paperclip.acpx-profiles.v1" || !profile?.agentServerPackage) {
|
|
throw new Error(`paperclip-runner vendor check: missing ${agent} provider profile.`);
|
|
}
|
|
packages.add(profile.agentServerPackage);
|
|
}
|
|
return packages;
|
|
}
|
|
|
|
function readDependencyNames(packageJsonPath) {
|
|
const packageJson = JSON.parse(readFileSync(packageJsonPath, "utf8"));
|
|
return new Map(Object.entries(packageJson.dependencies ?? {}));
|
|
}
|
|
|
|
function explainMissingDependencies(missing, runnerDependencyNames) {
|
|
const lines = missing.map((name) => {
|
|
const range = runnerDependencyNames.get(name);
|
|
return range
|
|
? ` "${name}": "${range}" (matches packages/paperclip-runner/package.json)`
|
|
: ` "${name}" (not declared as a paperclip-runner dependency either -- check for a missing or mistyped dependency there first)`;
|
|
});
|
|
return (
|
|
`paperclip-runner vendor check: server/package.json is missing the runtime ` +
|
|
`${missing.length === 1 ? "dependency" : "dependencies"} the vendored runner ` +
|
|
`imports at runtime:\n${lines.join("\n")}\n\n` +
|
|
`packages/paperclip-runner/dist is copied into server's own published package ` +
|
|
`without its node_modules, so every npm package the runner imports must also be ` +
|
|
`a direct dependency of server so it resolves once vendored. Add ` +
|
|
`${missing.length === 1 ? "it" : "them"} to server/package.json's "dependencies".`
|
|
);
|
|
}
|
|
|
|
async function main() {
|
|
const entryPoints = ENTRY_POINT_NAMES.map((name) => resolve(runnerDist, name));
|
|
const profileData = JSON.parse(readFileSync(resolve(runnerRoot, "acpx-profiles.json"), "utf8"));
|
|
const externalPackageNames = await findRunnerRuntimePackages(entryPoints, profileData);
|
|
const serverDependencyNames = readDependencyNames(resolve(serverRoot, "package.json"));
|
|
|
|
const missing = findMissingVendorDependencies(
|
|
externalPackageNames,
|
|
new Set(serverDependencyNames.keys()),
|
|
);
|
|
if (missing.length > 0) {
|
|
const runnerDependencyNames = readDependencyNames(resolve(runnerRoot, "package.json"));
|
|
throw new Error(explainMissingDependencies(missing, runnerDependencyNames));
|
|
}
|
|
}
|
|
|
|
// Only run when invoked directly (`node scripts/verify-runner-vendor-dependencies.mjs`),
|
|
// not when the vitest suite imports findMissingVendorDependencies for a unit test.
|
|
const isMain = process.argv[1] && import.meta.url === pathToFileURL(process.argv[1]).href;
|
|
if (isMain) await main();
|