mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-10-14 17:40:37 +02:00
## Thinking Path > - Paperclip is the open source app people use to manage AI agents for work. > - Feature recipes and Storybook help contributors find behavior, examples, and verification steps. > - Independent feature changes currently update shared catalogs, indexes, and review hashes. > - Those shared files cause merge conflicts and repeated bookkeeping during parallel work. > - This pull request stores metadata in each feature recipe and story, then generates the combined views. > - Contributors can merge independent work without editing a common index. Git and PR evidence retain change and review history. ## Linked Issues or Issue Description **What existing behavior does this improve?** Maintaining the product, agent-access, and Storybook maps while multiple agents change different features. **Current behavior** A story or recipe change can update `catalog.json`, `INDEX.md`, review hashes, verification tables, and tracked generated navigation. Two unrelated changes then conflict in the same files. **Proposed behavior** Each story declares capability links and classification in `parameters.paperclip`. Each feature recipe declares its navigation and optional verification guidance. Startup, build, and UI typechecking discover these sources and generate ignored indexes and Storybook pages. **Reason and benefit** A routine change edits its own source files. Aggregate metadata is rebuilt from the merged checkout. There is no sidecar registry, shared review journal, or hash acknowledgment to maintain. **Breaking changes** The tracked Storybook catalog and index paths are retired. Consumers use `ui/storybook/generated/` or `maps/generated/` after generation. Contributor instructions and the existing feature-gap browser suite use the new paths. Story and overview IDs remain stable. ## What Changed - Move the existing annotations into 262 story files. Preserve classifications, capability associations, exports, and explicit IDs. - Discover all 35 feature recipes. Store section/order beside each recipe and move durable verification routes out of the shared table. - Remove tracked catalogs, inventories, overview pages, and inline preview ordering. Keep authored preview behavior in `preview-base.tsx`. - Generate the Storybook guide, feature/access Markdown indexes, gap report, page-reference inventory, and preview wrapper automatically. - Update the map contracts and maintenance skills to use Git history and revision-specific PR/CI evidence. - Add schema, identity, regeneration, and actual Git merge tests. Run these through the existing UI Vitest suite. Add focused browser navigation checks. This is one coordinated migration. Most of the 367 changed files contain only moved metadata or deleted generated content. Review the generator scripts, map contracts, Storybook configuration, and tests first. No product API or authorization behavior changes. ## Verification Passed: - `node scripts/check-maps.mjs`: 35 paired areas and 175 capabilities. - `node scripts/storybook-catalog.mjs --check`: 262 suites and 2,485 authored stories after incorporating current master. - `node --test scripts/check-maps.test.mjs scripts/storybook-catalog.test.mjs scripts/storybook-feature-index.test.mjs`: 28 tests, including independent branches merged in both orders with identical generated output and no tracked changes. - `pnpm --filter @paperclipai/ui exec vitest run storybook/map-tooling.test.ts`: the CI entrypoint runs those map tests. - `pnpm check:token-gates`. - `pnpm -r typecheck` and `pnpm build` before the final master rebase. - `pnpm build-storybook`: all 2,517 original story/docs URLs retained. Current master contributes exactly four additional recovery stories. - Focused Playwright navigation checks: search and open a feature without examples; expand verification guidance and check source links; retain capability order and follow a related Foundations suite. The final clean Storybook build passed after deleting every ignored map output. Post-rebase UI typechecking and both browser tests passed. The working tree stays clean after generation. The concurrent-cleanup regression fails with `ENOENT` without the fix and passes with it. All GitHub CI gates passed on `00fc7ec18e`, which also received Greptile 5/5 with no unresolved findings. The final merge commit `1c3c5143a6` incorporates master and resolves only the two modify/delete conflicts by retaining removal of the aggregate index and catalog. Master’s new workspace feature and access guidance is preserved. Map validation, catalog generation, overview generation, all 28 map tests, and diff checks pass after conflict resolution. The maintainer explicitly requested merging without another Greptile review. CI has not been rerun to completion on this merge commit. The local repository-wide `pnpm test:run` was stopped before completion after the earlier CI matrix passed; it is not reported as a local pass. No screenshot baselines or production acceptance are claimed. To repeat the browser check against an owned Storybook server: ```sh PAPERCLIP_GAP_STORYBOOK_URL=http://127.0.0.1:6136 pnpm exec playwright test --config tests/storybook-visual/feature-gap-stories.config.ts map-navigation.spec.ts ``` ## Risks - Existing branches need a one-time rebase to move their catalog changes into local annotations. The PR incorporates the recovery changes from current master. - Changing the same story or capability can still produce a meaningful conflict. This removes the shared aggregate bottleneck. - The generator uses Storybook's existing CSF parser. Literal-only annotations and parser regression tests protect the current contract. - Generated Markdown is available after running the generator; the published Storybook provides a browsable guide. - Shared source changes still require review. Removing hashes removes mechanical acknowledgments; it does not establish runtime parity. ## Model Used OpenAI Codex, based on GPT-6, with repository inspection, code execution, and browser-test tools. The exact deployment model ID and context window were not exposed in this session. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either (a) linked existing issues with `Fixes: #` / `Closes #` / `Refs #` OR (b) described the issue in-PR following the relevant issue template - [x] I have not referenced internal/instance-local Paperclip issues or links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip` URLs) - [x] My branch name describes the change (e.g. `docs/...`, `fix/...`) and contains no internal Paperclip ticket id or instance-derived details - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] All Paperclip CI gates are green on the previously reviewed head `00fc7ec18e`; final conflict-resolution checks are documented above - [x] Greptile is 5/5 with no open P2s, recommendations, or follow-ups on `00fc7ec18e`; another review was waived by the maintainer - [x] I will address all Greptile and reviewer comments before requesting merge --------- Co-authored-by: Paperclip <noreply@paperclip.ing>
122 lines
6.9 KiB
Markdown
122 lines
6.9 KiB
Markdown
# Paperclip feature map
|
|
|
|
Start here when reproducing a user-facing bug, verifying a change, or deciding
|
|
which surfaces a fix must cover. Each recipe describes what a person can do,
|
|
where they can do it, the expected result, and the evidence needed to verify it.
|
|
Product behavior is still governed by [the implementation spec](../../doc/SPEC-implementation.md).
|
|
|
|
The sibling [agent access map](../agent-access-map/README.md) records APIs,
|
|
agent entry points and permission boundaries for the same capability IDs.
|
|
Follow the [shared map contract](../README.md) when maintaining either map.
|
|
|
|
## Browse features
|
|
|
|
Open the [published Storybook guide](https://d1p6rlowie26tp.cloudfront.net/storybook/branches/master/?path=/story/overview-storybook-guide--coverage-guide)
|
|
for the assembled feature and capability index. The Markdown recipes in this
|
|
directory are the authored source. Each has a same-named agent-access companion.
|
|
|
|
Run `node scripts/storybook-catalog.mjs` to generate local navigation in
|
|
`maps/generated/feature-map.md`, `maps/generated/agent-access-map.md`, and the
|
|
Storybook guide. A new recipe is discovered automatically; do not register it in
|
|
this README or maintain counts here.
|
|
|
|
## Before driving a journey
|
|
|
|
1. Use this checkout's [isolated test drive](../../doc/DEVELOPING.md#one-command-isolated-manual-test-drive)
|
|
for manual product checks. It creates a temporary instance and prints its URL
|
|
and data directory. Do not guess that a server on port 3100 belongs to you.
|
|
2. Record the commit, URL, company, login role, relevant experimental settings,
|
|
adapter, runtime mode, and live versus simulated dependencies. Use disposable
|
|
tasks and provider resources. A fresh test drive creates a company and CEO,
|
|
but no task or first run.
|
|
3. Use the current navigation and company prefix. Paths in recipes omit that
|
|
prefix. Record whether the streamlined or production shell is selected;
|
|
Agent Chat, chat connectors, and the combined Inbox/Tasks view have separate
|
|
gates. A hidden surface is an unmet prerequisite, not a successful test.
|
|
4. Run the smallest relevant test first. Vitest commands below run from the
|
|
repository root after installing dependencies. Playwright recipes use their
|
|
named configuration and its isolated environment, not an unrelated running
|
|
instance. Reserve expensive runner/provider tests for the behavior at issue.
|
|
5. Exercise the actual user action, inspect its result, reload, and verify the
|
|
persisted state or continuation. Use read-only API checks to corroborate UI
|
|
evidence; creating state through the API does not prove the creation UI.
|
|
|
|
For agent-driven acceptance work, start with the
|
|
[Paperclip verification skill](../../.agents/skills/verify-paperclip/SKILL.md) for an
|
|
isolated launch, ownership/readiness checks, browser driving, evidence, and cleanup.
|
|
It uses this directory as its feature map. The existing
|
|
[dev-workspace run/verify skill](../../.agents/skills/paperclip-dev-workspace-run-verify-fix/SKILL.md)
|
|
and [evaluation skill](../../.agents/skills/paperclip-evals/SKILL.md) describe runtime
|
|
ownership and evidence handling. Reuse them; this map introduces no environment
|
|
launcher, credentials, scheduled job, or second test framework.
|
|
|
|
## Evidence contract
|
|
|
|
Report each entry point as **passed**, **failed**, **blocked** (with its missing
|
|
prerequisite), or **not run**. Include the feature filename and entry-point ID,
|
|
commit/environment, user action, expected and observed result, command/exit code,
|
|
and evidence links. Screenshots or traces should show both the action and the
|
|
discriminating result. Include task/run/request IDs when relevant, without secrets.
|
|
|
|
A fix is verified across its affected surfaces only when each has evidence or
|
|
an explicit reason it does not apply. Shared code alone does not prove parity.
|
|
Keep product regressions visible; do not change the recipe to bless a failure.
|
|
For Paperclip-assigned work, attach evidence through the
|
|
[artifact workflow](../../doc/AGENT-ARTIFACTS.md).
|
|
|
|
## Inventory and remaining depth
|
|
|
|
The generated `maps/generated/coverage.json` lists the current non-test TSX page
|
|
modules and the recipes that directly reference each one. An unreferenced module
|
|
is a documentation candidate, not proof that its feature is absent or untested.
|
|
Remaining workflow limits live in each recipe. Inventory and example associations
|
|
describe documentation scope, not runtime health.
|
|
|
|
## Maintaining the reference
|
|
|
|
The map documents user journeys. It does not execute them automatically;
|
|
generated inventories record documentation scope rather than live test health.
|
|
|
|
When maintaining a recipe, compare its entry points and expected results with
|
|
the current source. Check that linked tests still exercise the stated behavior
|
|
and that local references still exist. Keep the same-named agent access companion
|
|
and stable sub-feature IDs aligned when behavior or access changes. Source-only
|
|
access inventory remains distinct from live verification. Run
|
|
`node scripts/check-maps.mjs` after map edits for structural/reference checks;
|
|
follow the shared contract for the source and behavioral checks it cannot perform.
|
|
|
|
Each recipe starts with a small frontmatter navigation record, then an H1:
|
|
|
|
```markdown
|
|
---
|
|
navigation: {"section":"Tasks and conversations","sectionOrder":20,"order":10}
|
|
---
|
|
```
|
|
|
|
The H1 supplies the feature title, and the first paragraph supplies its summary.
|
|
Orders are local to the section; leave gaps for additions. Equal orders use the
|
|
stable filename as a tie-breaker. Keep a section's name/order consistent across
|
|
its recipes. A new feature or capability needs only its recipe and companion.
|
|
|
|
Optional `### Storybook verification` guidance lives inside the recipe's Gotchas
|
|
section. Each level-four heading contains a backtick-quoted capability key and
|
|
has `Scope` (`ui`, `cli`, or `browser`),
|
|
`Storybook`, `Production`, and `Sources` fields. These are verification instructions
|
|
and intentional scope limits, not run results or a required story for every API.
|
|
The generated gap report combines this guidance with current story associations.
|
|
|
|
After frontmatter, each recipe starts with an H1 and a user-visible description, then exactly:
|
|
|
|
1. **Sub-features** — stable backticked IDs and observable behavior/states.
|
|
2. **How to get to it (user POV)** — one H3 backticked entry-point ID per surface.
|
|
3. **Driving it with <harness>** — starts with `Preconditions:`; repeat each entry-point H3,
|
|
with `Automated:` and `Manual:` paragraphs. Name test scope and gaps honestly.
|
|
4. **Gotchas** — misleading look-alikes, feature gates, and invalid evidence.
|
|
|
|
New or updated entries follow
|
|
[Poteto's feature-map examples](../../.agents/skills/create-verification-skill/references/feature-map-example).
|
|
Existing entries with a `Driving it` heading can adopt the named harness when
|
|
their recipes are updated. The original format was inspired by
|
|
[Omnigent's feature map](https://github.com/omnigent-ai/omnigent/tree/91acfbbb59f6fc210ff95a9e9428aadd62e06582/feature-map).
|
|
Paperclip's recipes and checks follow its own task model and test infrastructure.
|