mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-11-11 05:11:49 +01:00
Pluralize stalled IssueBlockedNotice copy for multi-leaf chains
When the chip strip surfaces more than one stalled leaf, the trailing
imperative now uses plural agreement ("Resolve the stalled reviews
below or remove them as blockers.") to match the chips. Single-leaf
copy is unchanged.
Refs PAP-2382 (follow-up from PAP-2374 UX review of PAP-2373).
Co-Authored-By: Paperclip <noreply@paperclip.ing>
This commit is contained in:
1 parent
aeae9c607e
commit
bfd495d34c
2 files changed
+6
-4
No files matched your search
@@ -69,7 +69,9 @@ export function IssueBlockedNotice({
|
||||
<p className="leading-5">
|
||||
{blockers.length > 0
|
||||
? isStalled
|
||||
? <>Work on this issue is blocked by {blockerLabel}, but the chain is stalled in review without a clear next step. Resolve the stalled review below or remove it as a blocker.</>
|
||||
? stalledLeafBlockers.length > 1
|
||||
? <>Work on this issue is blocked by {blockerLabel}, but the chain is stalled in review without a clear next step. Resolve the stalled reviews below or remove them as blockers.</>
|
||||
: <>Work on this issue is blocked by {blockerLabel}, but the chain is stalled in review without a clear next step. Resolve the stalled review below or remove it as a blocker.</>
|
||||
: <>Work on this issue is blocked by {blockerLabel} until {blockers.length === 1 ? "it is" : "they are"} complete. Comments still wake the assignee for questions or triage.</>
|
||||
: <>Work on this issue is blocked until it is moved back to todo. Comments still wake the assignee for questions or triage.</>}
|
||||
</p>
|
||||
|
||||
@@ -288,7 +288,7 @@ const blockedNoticeFixtures: BlockedNoticeFixture[] = [
|
||||
},
|
||||
{
|
||||
label: "Stalled (multiple leaves)",
|
||||
caption: "Multiple stalled reviews — copy switches to the unnamed pluralized variant.",
|
||||
caption: "Multiple stalled reviews — body uses plural agreement (\"reviews\"/\"them\") to match the chip strip.",
|
||||
blockers: [
|
||||
summaryBlocker({
|
||||
id: "issue-stalled-parent-multi-a",
|
||||
@@ -461,8 +461,8 @@ function StatusLanguage() {
|
||||
</div>
|
||||
<p className="mt-3 text-xs text-muted-foreground">
|
||||
Stalled-state copy switches to "stalled in review without a clear next step" and adds a "Stalled in review"
|
||||
chip strip beneath the regular blocker chips. Single-leaf stalled copy names the leaf identifier; multi-leaf
|
||||
falls back to the unnamed pluralized variant.
|
||||
chip strip beneath the regular blocker chips. The trailing imperative pluralizes when multiple stalled
|
||||
leaves are surfaced ("reviews"/"them") to match the chip strip.
|
||||
</p>
|
||||
</Section>
|
||||
|
||||
|
||||
Reference in new issue
Block a user