mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-11-20 09:50:48 +01:00
Validate reassessed Done decisions for every saved disposition
New evidence can satisfy a completion contract whose saved result reported needs_review, yielded, or blocked. Validate the proposed authoritative Done decision so those results reach bounded incomplete-delivery feedback before the commit guard, rather than retrying as status races. Add six regressions for the other saved dispositions and both continuation allowances. Also verify reassessment stays settled after corrective effects are marked delivered. Co-Authored-By: Paperclip <noreply@paperclip.ing>
This commit is contained in:
1 parent
bb19d6741e
commit
b197e4f9f6
3 files changed
+16
-6
No files matched your search
@@ -141,6 +141,8 @@ concrete blocker. This creates no generic human completion approval.
|
||||
|
||||
Reassessment uses the same bounded incomplete-delivery continuation as initial
|
||||
finalization. A stable unmerged PR does not create a status-race retry deadline.
|
||||
The proposed server status controls delivery validation, including when new
|
||||
evidence completes a result that previously reported another disposition.
|
||||
The transactional commit also checks these outputs, including reassessment
|
||||
paths. Human and agent work-product updates lock their source and destination
|
||||
tasks in a stable order before changing status or identity. Provider reads occur
|
||||
|
||||
@@ -2921,12 +2921,18 @@ describe("P6-31 Section 18.13 executable status-authority corpus", () => {
|
||||
});
|
||||
|
||||
it.each([
|
||||
{ trigger: "retired review", correctiveUsed: false },
|
||||
{ trigger: "new evidence", correctiveUsed: false },
|
||||
{ trigger: "retired review", correctiveUsed: true },
|
||||
{ trigger: "new evidence", correctiveUsed: true },
|
||||
])("settles unmerged delivery from $trigger without retry polling (corrective used=$correctiveUsed)", async ({ trigger, correctiveUsed }) => {
|
||||
{ trigger: "retired review", correctiveUsed: false, disposition: "done" },
|
||||
{ trigger: "new evidence", correctiveUsed: false, disposition: "done" },
|
||||
{ trigger: "retired review", correctiveUsed: true, disposition: "done" },
|
||||
{ trigger: "new evidence", correctiveUsed: true, disposition: "done" },
|
||||
...["needs_review", "yielded", "blocked"].flatMap(disposition => [false, true].map(correctiveUsed =>
|
||||
({ trigger: "new evidence", correctiveUsed, disposition }))),
|
||||
])("settles unmerged delivery from $trigger without retry polling (disposition=$disposition, corrective used=$correctiveUsed)", async ({ trigger, correctiveUsed, disposition }) => {
|
||||
const seeded = await seedAutomaticReview();
|
||||
const [saved] = await db.select().from(nativeRunResults).where(eq(nativeRunResults.id, seeded.resultId!));
|
||||
await db.update(nativeRunResults).set({ resultJson: { ...saved.resultJson,
|
||||
result: { ...(saved.resultJson.result as object), reportedWorkDisposition: disposition } } })
|
||||
.where(eq(nativeRunResults.id, saved.id));
|
||||
const [originalAssessment] = await db.select().from(workAssessments).where(eq(workAssessments.id, seeded.assessmentId));
|
||||
await db.update(workAssessments).set({ createdAt: new Date(Date.now() - 2000),
|
||||
assessmentJson: { ...originalAssessment.assessmentJson, allCriteriaSatisfied: false } }).where(eq(workAssessments.id, seeded.assessmentId));
|
||||
@@ -2957,6 +2963,8 @@ describe("P6-31 Section 18.13 executable status-authority corpus", () => {
|
||||
expect(effects.some(effect => effect.kind === "enqueue_continuation")).toBe(!correctiveUsed);
|
||||
expect(effects.some(effect => effect.kind === "record_finalization_error")).toBe(correctiveUsed);
|
||||
expect(effects.some(effect => (effect.summary ?? effect.nextAction ?? "").includes("not been verified as merged"))).toBe(true);
|
||||
await db.update(statusDecisionEffects).set({ deliveryState: "delivered" })
|
||||
.where(eq(statusDecisionEffects.decisionId, latest.id));
|
||||
const assessments = await db.select().from(workAssessments).where(eq(workAssessments.runId, seeded.runId));
|
||||
expect(await work.load(scope)).toEqual([]);
|
||||
expect(await work.check(pending)).toBeNull();
|
||||
|
||||
@@ -257,7 +257,7 @@ export async function reassessNativeStatusFromSource(
|
||||
: [currentIssue.title, currentIssue.description].filter(Boolean).join("\n");
|
||||
try {
|
||||
await validateNativeDeliverableEvidence(db, { companyId: row.companyId, issueId: row.issueId,
|
||||
runId: row.runId, objective, semanticToolReceipts: run.resultJson?.semanticToolReceipts },
|
||||
runId: row.runId, objective, semanticToolReceipts: run.resultJson?.semanticToolReceipts, authoritativeDone: true },
|
||||
record(resultRow.resultJson).result);
|
||||
} catch (error) {
|
||||
if (!(error instanceof NativeDeliverableEvidenceError)) throw error;
|
||||
|
||||
Reference in new issue
Block a user