mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-10-25 02:26:12 +02:00
Address review feedback: refresh stale JSDoc, fix JSX indentation, drop one-off capture scripts
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This commit is contained in:
1 parent
8b3b11a7d5
commit
9df4b529c1
3 files changed
+8
-76
No files matched your search
@@ -1,40 +0,0 @@
|
||||
#!/usr/bin/env node
|
||||
// Capture all 10 redesign-lab variants at desktop 1440 and mobile 390 in one browser.
|
||||
import fs from "node:fs/promises";
|
||||
import path from "node:path";
|
||||
import { chromium } from "@playwright/test";
|
||||
|
||||
const BASE = "issue-thread-interaction-redesign-lab";
|
||||
const variants = [
|
||||
"v-01-compact-card",
|
||||
"v-02-borderless-inline",
|
||||
"v-03-collapsed-by-default",
|
||||
"v-04-chat-native",
|
||||
"v-05-trimmed-footer-bar",
|
||||
"v-06-dense-two-column",
|
||||
"v-07-chip-answers",
|
||||
"v-08-banner-disclosure",
|
||||
"v-09-split-surface",
|
||||
"v-10-minimal-monochrome",
|
||||
];
|
||||
const out = path.resolve("artifacts/PAP-12696-review");
|
||||
await fs.mkdir(out, { recursive: true });
|
||||
|
||||
const browser = await chromium.launch({ headless: true });
|
||||
try {
|
||||
for (const [w, h, tag] of [[1440, 900, "1440"], [390, 844, "390"]]) {
|
||||
const ctx = await browser.newContext({ viewport: { width: w, height: h }, deviceScaleFactor: 2 });
|
||||
const page = await ctx.newPage();
|
||||
for (const v of variants) {
|
||||
const url = `http://localhost:6006/iframe.html?id=${BASE}--${v}&viewMode=story`;
|
||||
await page.goto(url, { waitUntil: "networkidle" });
|
||||
await page.waitForTimeout(1200);
|
||||
const file = path.join(out, `${v}-${tag}.png`);
|
||||
await page.screenshot({ path: file, fullPage: true });
|
||||
console.log(`Wrote ${file}`);
|
||||
}
|
||||
await ctx.close();
|
||||
}
|
||||
} finally {
|
||||
await browser.close();
|
||||
}
|
||||
@@ -1,27 +0,0 @@
|
||||
#!/usr/bin/env node
|
||||
// Capture the new V12 lab variant (Dotta's pick) at desktop 1440 and mobile 390.
|
||||
import fs from "node:fs/promises";
|
||||
import path from "node:path";
|
||||
import { chromium } from "@playwright/test";
|
||||
|
||||
const BASE = "issue-thread-interaction-redesign-lab";
|
||||
const story = "v-12-expanded-by-default";
|
||||
const out = path.resolve("artifacts/PAP-12696-v12");
|
||||
await fs.mkdir(out, { recursive: true });
|
||||
|
||||
const browser = await chromium.launch({ headless: true });
|
||||
try {
|
||||
for (const [w, h, tag] of [[1440, 900, "1440"], [390, 844, "390"]]) {
|
||||
const ctx = await browser.newContext({ viewport: { width: w, height: h }, deviceScaleFactor: 2 });
|
||||
const page = await ctx.newPage();
|
||||
const url = `http://localhost:6006/iframe.html?id=${BASE}--${story}&viewMode=story`;
|
||||
await page.goto(url, { waitUntil: "networkidle" });
|
||||
await page.waitForTimeout(1200);
|
||||
const file = path.join(out, `${story}-${tag}.png`);
|
||||
await page.screenshot({ path: file, fullPage: true });
|
||||
console.log(`Wrote ${file}`);
|
||||
await ctx.close();
|
||||
}
|
||||
} finally {
|
||||
await browser.close();
|
||||
}
|
||||
@@ -184,10 +184,9 @@ function statusTone(status: IssueThreadInteraction["status"]): "pending" | "succ
|
||||
}
|
||||
|
||||
/**
|
||||
* A confirmation that targets the issue's `plan` document renders as a distinct
|
||||
* plan card (PAP-95g): a full state-coloured outline — violet while in review,
|
||||
* green once approved, red when changes are requested (PAP-75 palette) — with no
|
||||
* left stripe, so plans stand out from comments and status rows.
|
||||
* A confirmation that targets the issue's `plan` document uses plan-specific
|
||||
* label copy ("Plan review", approve/request-changes wording). The card shell
|
||||
* itself is the same neutral disclosure row as every other interaction.
|
||||
*/
|
||||
function isPlanConfirmation(interaction: IssueThreadInteraction): boolean {
|
||||
if (interaction.kind !== "request_confirmation") return false;
|
||||
@@ -734,11 +733,11 @@ function QuestionOptionButton({
|
||||
</span>
|
||||
<span className="min-w-0 flex-1">
|
||||
<span className="block font-medium">{label}</span>
|
||||
{description ? (
|
||||
<span className="mt-0.5 block text-xs leading-4 text-muted-foreground">
|
||||
{description}
|
||||
</span>
|
||||
) : null}
|
||||
{description ? (
|
||||
<span className="mt-0.5 block text-xs leading-4 text-muted-foreground">
|
||||
{description}
|
||||
</span>
|
||||
) : null}
|
||||
</span>
|
||||
</button>
|
||||
);
|
||||
|
||||
Reference in new issue
Block a user