mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-11-20 18:26:40 +01:00
fix(feedback): keep run ids and dates intact when redacting phone numbers (#21251)
## Thinking Path
> - Paperclip is the open source app people use to manage AI agents for
work
> - People can export a feedback bundle that holds run records for
review
> - The bundle is redacted before export, and one rule removes phone
numbers
> - The phone rule also matched two all-digit groups inside a run UUID
> - A run id such as `9224d1c8-1dbf-4314-9924-e16fcf3ad1fa` became
`9224d1c8-1dbf-[REDACTED_PHONE]-e16fcf3ad1fa`, so the bundle no longer
named its run
> - This pull request keeps UUIDs and ISO dates out of the phone rule
> - The benefit is that exported ids and dates stay correct and real
phone numbers stay redacted
## Linked Issues or Issue Description
**What happened?**
In the paid chat eval `cli-operations.feedback-bundle`, the exported
bundle's `envelope.targetId` was
`9224d1c8-1dbf-[REDACTED_PHONE]-e16fcf3ad1fa`. The phone rule
`(?<!\w)(?:\+?\d[\d ()-]{7,}\d)(?!\w)` matches two all-digit UUID groups
joined by `-`. About 2 to 3 percent of random UUIDs have that shape. The
same rule also matched a bare date such as `2026-11-12`.
**Steps to reproduce**
1. Call `sanitizeFeedbackText` with text that contains
`9224d1c8-1dbf-4314-9924-e16fcf3ad1fa`.
2. Read the output.
**Expected behavior**
The UUID stays unchanged. A real phone number such as `+1 (415)
555-1234` is still redacted.
## What Changed
- `server/src/services/feedback-redaction.ts`: the phone rule now runs
only on the text between public identifiers. UUIDs and ISO-8601 dates
and timestamps are copied through unchanged. Other rules are unchanged.
- `server/src/__tests__/feedback-redaction.test.ts`: a regression test
with the `-4314-9924-` UUID, an all-digit UUID, a date and a timestamp,
next to a real phone number that must stay redacted.
## Verification
- `cd server && npx vitest run src/__tests__/feedback-redaction.test.ts`
passes (13 tests). The new test fails on master: the UUID and the date
are replaced with `[REDACTED_PHONE]`.
## Risks
- Low risk. A phone number written in the exact shape of a UUID or an
ISO date is no longer redacted. Those shapes are not phone numbers.
## Model Used
- Claude Opus 5.5 (`claude-opus-5-5`), Anthropic, with tool use and code
execution in Claude Code.
## Checklist
- [x] I have included a thinking path that traces from project context
to this change
- [x] I have specified the model used (with version and capability
details)
- [x] I have checked ROADMAP.md and confirmed this PR does not duplicate
planned core work
- [x] I have searched GitHub for duplicate or related PRs and linked
them above
- [x] I have either (a) linked existing issues with `Fixes: #` / `Closes
#` / `Refs #` OR (b) described the issue in-PR following the relevant
issue template
- [x] I have not referenced internal/instance-local Paperclip issues or
links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip`
URLs)
- [x] My branch name describes the change (e.g. `docs/...`, `fix/...`)
and contains no internal Paperclip ticket id or instance-derived details
- [x] I have run tests locally and they pass
- [x] I have added or updated tests where applicable
- [x] I have updated relevant documentation to reflect my changes
- [x] I have considered and documented any risks above
- [x] All Paperclip CI gates are green
- [x] Greptile is 5/5 with no open P2s, recommendations, or follow-ups
- [x] I will address all Greptile and reviewer comments before
requesting merge
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
1 parent
ddc0aacad8
commit
9025597ce4
2 files changed
+37
No files matched your search
@@ -81,6 +81,18 @@ describe("feedback redaction", () => {
|
||||
expect(output).toContain("[REDACTED_PHONE]");
|
||||
});
|
||||
|
||||
it("keeps run ids and dates intact while still redacting a phone number beside them", () => {
|
||||
const state = createFeedbackRedactionState();
|
||||
const runId = "9224d1c8-1dbf-4314-9924-e16fcf3ad1fa";
|
||||
const allDigitId = "12345678-1234-4234-9234-123456789012";
|
||||
const input = `Run ${runId} and ${allDigitId} on 2026-11-12 at 2026-11-12 00:43:37; call +1 (415) 555-1234.`;
|
||||
|
||||
expect(sanitizeFeedbackText(input, state, "body", 10_000)).toBe(
|
||||
`Run ${runId} and ${allDigitId} on 2026-11-12 at 2026-11-12 00:43:37; call [REDACTED_PHONE].`,
|
||||
);
|
||||
expect(finalizeFeedbackRedactionSummary(state).counts).toEqual({ phone: 1 });
|
||||
});
|
||||
|
||||
it("preserves nested metadata while masking structured secrets", () => {
|
||||
const state = createFeedbackRedactionState();
|
||||
const input = {
|
||||
|
||||
@@ -17,8 +17,12 @@ type RedactionPattern = {
|
||||
kind: string;
|
||||
regex: RegExp;
|
||||
replacement: PatternReplacement;
|
||||
preservesIdentifiers?: boolean;
|
||||
};
|
||||
|
||||
const PUBLIC_IDENTIFIER_RE =
|
||||
/\b(?:[0-9a-f]{8}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{12}|\d{4}-\d{2}-\d{2}(?:[T ]\d{2}:\d{2}(?::\d{2}(?:\.\d+)?)?(?:Z|[+-]\d{2}:?\d{2})?)?)\b/gi;
|
||||
|
||||
const SECRET_ASSIGNMENT_RE =
|
||||
/\b(api[-_]?key|access[-_]?token|auth(?:_?token)?|authorization|bearer|secret|passwd|password|credential|jwt|private[-_]?key|cookie|connectionstring)\s*[:=]\s*([^\s,;]+)/gi;
|
||||
|
||||
@@ -67,6 +71,7 @@ const FREE_TEXT_PATTERNS: RedactionPattern[] = [
|
||||
kind: "phone",
|
||||
regex: /(?<!\w)(?:\+?\d[\d ()-]{7,}\d)(?!\w)/g,
|
||||
replacement: "[REDACTED_PHONE]",
|
||||
preservesIdentifiers: true,
|
||||
},
|
||||
];
|
||||
|
||||
@@ -85,6 +90,26 @@ function recordField(state: FeedbackRedactionState, fieldPath: string) {
|
||||
}
|
||||
|
||||
function applyPattern(input: string, pattern: RedactionPattern) {
|
||||
if (pattern.preservesIdentifiers) return applyPatternOutsideIdentifiers(input, pattern);
|
||||
return applyPatternToSegment(input, pattern);
|
||||
}
|
||||
|
||||
function applyPatternOutsideIdentifiers(input: string, pattern: RedactionPattern) {
|
||||
let matches = 0;
|
||||
let output = "";
|
||||
let cursor = 0;
|
||||
for (const identifier of input.matchAll(PUBLIC_IDENTIFIER_RE)) {
|
||||
const start = identifier.index ?? 0;
|
||||
const segment = applyPatternToSegment(input.slice(cursor, start), pattern);
|
||||
output += segment.output + identifier[0];
|
||||
matches += segment.matches;
|
||||
cursor = start + identifier[0].length;
|
||||
}
|
||||
const tail = applyPatternToSegment(input.slice(cursor), pattern);
|
||||
return { output: output + tail.output, matches: matches + tail.matches };
|
||||
}
|
||||
|
||||
function applyPatternToSegment(input: string, pattern: RedactionPattern) {
|
||||
let matches = 0;
|
||||
const output = input.replace(pattern.regex, (match: string, ...args: string[]) => {
|
||||
const replacement = typeof pattern.replacement === "function"
|
||||
|
||||
Reference in new issue
Block a user