Fix secrets responsive table breakpoint

This commit is contained in:
Dotta committed 2026-07-02 02:16:55 +00:00
1 parent f5d7a13aba
commit 84507ce609
2 files changed
+68 -27

No files matched your search

+19 -12
View File
@@ -575,13 +575,11 @@ describe("Secrets page layout", () => {
}); });
await flushReact(); await flushReact();
const usageButton = Array.from(document.body.querySelectorAll("button")).find( const viewUsageButton = Array.from(document.body.querySelectorAll("button")).find(
(button) => button.textContent?.includes("Usage"), (button) => button.textContent?.includes("View in Usage"),
) as HTMLButtonElement | undefined; ) as HTMLButtonElement | undefined;
await act(async () => { await act(async () => {
usageButton?.dispatchEvent(new PointerEvent("pointerdown", { bubbles: true })); viewUsageButton?.click();
usageButton?.dispatchEvent(new KeyboardEvent("keydown", { bubbles: true, key: "Enter" }));
usageButton?.click();
}); });
await flushReact(); await flushReact();
@@ -620,6 +618,17 @@ describe("Secrets page layout", () => {
expect(container.textContent).toContain("Each user"); expect(container.textContent).toContain("Each user");
expect(container.textContent).toContain("3/5 set"); expect(container.textContent).toContain("3/5 set");
expect(container.textContent).not.toContain("User secret definitions"); expect(container.textContent).not.toContain("User secret definitions");
const listContainer = container.querySelector('[data-testid="secrets-list-container"]');
const tableView = container.querySelector('[data-testid="secrets-table-view"]');
const cardView = container.querySelector('[data-testid="secrets-card-view"]');
expect(listContainer?.className).toContain("@container");
expect(tableView?.className).toContain("@min-[40rem]:block");
expect(tableView?.className).not.toContain("md:block");
expect(tableView?.querySelector("[role='row']")?.className).toContain("minmax(12rem,2.4fr)");
expect(cardView?.className).toContain("@min-[40rem]:hidden");
expect(cardView?.className).not.toContain("md:hidden");
expect(mockSecretsApi.list).toHaveBeenCalledWith("company-1"); expect(mockSecretsApi.list).toHaveBeenCalledWith("company-1");
expect(mockSecretsApi.listUserSecretDefinitions).toHaveBeenCalledWith("company-1"); expect(mockSecretsApi.listUserSecretDefinitions).toHaveBeenCalledWith("company-1");
@@ -704,8 +713,8 @@ describe("Secrets page layout", () => {
}); });
it("opens the New secret dialog when provider queries fail", async () => { it("opens the New secret dialog when provider queries fail", async () => {
mockSecretsApi.providers.mockRejectedValueOnce(new ApiError(403, "Providers unavailable")); mockSecretsApi.providers.mockRejectedValueOnce(new ApiError("Providers unavailable", 403, null));
mockSecretsApi.providerConfigs.mockRejectedValueOnce(new ApiError(403, "Provider vaults unavailable")); mockSecretsApi.providerConfigs.mockRejectedValueOnce(new ApiError("Provider vaults unavailable", 403, null));
const root = createRoot(container); const root = createRoot(container);
const queryClient = new QueryClient({ const queryClient = new QueryClient({
defaultOptions: { queries: { retry: false } }, defaultOptions: { queries: { retry: false } },
@@ -774,13 +783,11 @@ describe("Secrets page layout", () => {
expect(document.body.textContent).toContain("Usage"); expect(document.body.textContent).toContain("Usage");
expect(document.body.textContent).toContain("Access events"); expect(document.body.textContent).toContain("Access events");
const coverageButton = Array.from(document.body.querySelectorAll("button")).find( const viewCoverageButton = Array.from(document.body.querySelectorAll("button")).find(
(button) => button.textContent?.trim() === "Coverage", (button) => button.textContent?.includes("View in Coverage"),
) as HTMLButtonElement | undefined; ) as HTMLButtonElement | undefined;
await act(async () => { await act(async () => {
coverageButton?.dispatchEvent(new PointerEvent("pointerdown", { bubbles: true })); viewCoverageButton?.click();
coverageButton?.dispatchEvent(new KeyboardEvent("keydown", { bubbles: true, key: "Enter" }));
coverageButton?.click();
}); });
await flushReact(); await flushReact();
+49 -15
View File
@@ -1514,15 +1514,16 @@ export function Secrets() {
) : filteredRows.length === 0 ? ( ) : filteredRows.length === 0 ? (
<EmptyState icon={Search} message="No secrets match your filters." /> <EmptyState icon={Search} message="No secrets match your filters." />
) : ( ) : (
<div className="min-w-0 overflow-x-hidden text-sm"> <div className="@container min-w-0 overflow-x-hidden text-sm" data-testid="secrets-list-container">
<div <div
role="table" role="table"
aria-label="Secrets" aria-label="Secrets"
className="hidden min-w-0 md:block" className="hidden min-w-0 @min-[40rem]:block"
data-testid="secrets-table-view"
> >
<div <div
role="row" role="row"
className="grid grid-cols-[minmax(0,2.4fr)_minmax(5.25rem,0.75fr)_minmax(7rem,1fr)_minmax(5rem,0.7fr)_2.75rem] items-center gap-3 bg-muted/40 px-3 py-2 text-xs uppercase tracking-wide text-muted-foreground" className="grid grid-cols-[minmax(12rem,2.4fr)_minmax(5.25rem,0.75fr)_minmax(7rem,1fr)_minmax(5rem,0.7fr)_2.75rem] items-center gap-3 bg-muted/40 px-3 py-2 text-xs uppercase tracking-wide text-muted-foreground"
> >
<div role="columnheader" className="font-medium">Secret</div> <div role="columnheader" className="font-medium">Secret</div>
<div role="columnheader" className="font-medium">Status</div> <div role="columnheader" className="font-medium">Status</div>
@@ -1547,7 +1548,7 @@ export function Secrets() {
key={row.id} key={row.id}
role="row" role="row"
className={cn( className={cn(
"grid cursor-pointer grid-cols-[minmax(0,2.4fr)_minmax(5.25rem,0.75fr)_minmax(7rem,1fr)_minmax(5rem,0.7fr)_2.75rem] items-center gap-3 border-b border-border/60 px-3 py-3 hover:bg-accent/40", "grid cursor-pointer grid-cols-[minmax(12rem,2.4fr)_minmax(5.25rem,0.75fr)_minmax(7rem,1fr)_minmax(5rem,0.7fr)_2.75rem] items-center gap-3 border-b border-border/60 px-3 py-3 hover:bg-accent/40",
row.kind === "company" && selectedSecretId === row.secret.id && "bg-accent/60", row.kind === "company" && selectedSecretId === row.secret.id && "bg-accent/60",
row.kind === "user" && selectedDefinitionId === row.definition.id && "bg-accent/60", row.kind === "user" && selectedDefinitionId === row.definition.id && "bg-accent/60",
)} )}
@@ -1619,7 +1620,7 @@ export function Secrets() {
</div> </div>
</div> </div>
<div className="space-y-2 md:hidden"> <div className="space-y-2 @min-[40rem]:hidden" data-testid="secrets-card-view">
{filteredRows.map((row) => { {filteredRows.map((row) => {
const status = row.kind === "company" ? row.secret.status : row.definition.status; const status = row.kind === "company" ? row.secret.status : row.definition.status;
return ( return (
@@ -1732,10 +1733,12 @@ export function Secrets() {
{selectedSecret ? ( {selectedSecret ? (
<> <>
<SheetHeader className="space-y-3"> <SheetHeader className="space-y-3">
<SheetTitle className="flex min-w-0 items-center gap-2 text-base"> <SheetTitle className="flex min-w-0 items-center gap-2 pr-8 text-base">
<KeyRound className="h-4 w-4 shrink-0" /> <KeyRound className="h-4 w-4 shrink-0" />
<span className="min-w-0 flex-1 truncate">{selectedSecret.name}</span> <span className="min-w-0 flex-1 truncate">{selectedSecret.name}</span>
<StatusBadge status={selectedSecret.status} /> <span className="shrink-0">
<StatusBadge status={selectedSecret.status} />
</span>
</SheetTitle> </SheetTitle>
<SheetDescription className="sr-only"> <SheetDescription className="sr-only">
{providerLabel(providers, selectedSecret.provider)} secret {selectedSecret.key} {providerLabel(providers, selectedSecret.provider)} secret {selectedSecret.key}
@@ -1832,7 +1835,12 @@ export function Secrets() {
</div> </div>
<div className="flex-1 min-h-0 overflow-y-auto px-4 py-3"> <div className="flex-1 min-h-0 overflow-y-auto px-4 py-3">
<TabsContent value="details"> <TabsContent value="details">
<SecretDetailsTab secret={selectedSecret} providers={providers} providerConfigs={providerConfigs} /> <SecretDetailsTab
secret={selectedSecret}
providers={providers}
providerConfigs={providerConfigs}
onViewUsage={() => setSecretDetailTab("usage")}
/>
</TabsContent> </TabsContent>
<TabsContent value="usage"> <TabsContent value="usage">
<SecretUsageTab loading={usageQuery.isPending} bindings={usageQuery.data?.bindings ?? []} /> <SecretUsageTab loading={usageQuery.isPending} bindings={usageQuery.data?.bindings ?? []} />
@@ -1850,10 +1858,12 @@ export function Secrets() {
) : selectedDefinition ? ( ) : selectedDefinition ? (
<> <>
<SheetHeader className="space-y-3"> <SheetHeader className="space-y-3">
<SheetTitle className="flex min-w-0 items-center gap-2 text-base"> <SheetTitle className="flex min-w-0 items-center gap-2 pr-8 text-base">
<UserRound className="h-4 w-4 shrink-0" /> <UserRound className="h-4 w-4 shrink-0" />
<span className="min-w-0 flex-1 truncate">{selectedDefinition.name}</span> <span className="min-w-0 flex-1 truncate">{selectedDefinition.name}</span>
<StatusBadge status={selectedDefinition.status} /> <span className="shrink-0">
<StatusBadge status={selectedDefinition.status} />
</span>
</SheetTitle> </SheetTitle>
<SheetDescription className="sr-only"> <SheetDescription className="sr-only">
Each user secret definition {selectedDefinition.key} Each user secret definition {selectedDefinition.key}
@@ -1958,7 +1968,11 @@ export function Secrets() {
</div> </div>
<div className="flex-1 min-h-0 overflow-y-auto px-4 py-3"> <div className="flex-1 min-h-0 overflow-y-auto px-4 py-3">
<TabsContent value="details"> <TabsContent value="details">
<UserSecretDetailsTab companyId={selectedCompanyId} definition={selectedDefinition} /> <UserSecretDetailsTab
companyId={selectedCompanyId}
definition={selectedDefinition}
onViewCoverage={() => setSecretDetailTab("coverage")}
/>
</TabsContent> </TabsContent>
<TabsContent value="coverage"> <TabsContent value="coverage">
<UserSecretCoverageTab <UserSecretCoverageTab
@@ -3482,9 +3496,11 @@ function CoverageInline({
function UserSecretDetailsTab({ function UserSecretDetailsTab({
companyId, companyId,
definition, definition,
onViewCoverage,
}: { }: {
companyId: string; companyId: string;
definition: UserSecretDefinition; definition: UserSecretDefinition;
onViewCoverage: () => void;
}) { }) {
return ( return (
<dl className="divide-y divide-border/60 text-xs"> <dl className="divide-y divide-border/60 text-xs">
@@ -3497,7 +3513,14 @@ function UserSecretDetailsTab({
</DetailRow> </DetailRow>
<DetailRow label="Status"><StatusBadge status={definition.status} /></DetailRow> <DetailRow label="Status"><StatusBadge status={definition.status} /></DetailRow>
<DetailRow label="Coverage"> <DetailRow label="Coverage">
<CoverageInline companyId={companyId} definitionId={definition.id} /> <button
type="button"
className="inline-flex min-w-0 items-center gap-1 text-left text-primary hover:underline"
onClick={onViewCoverage}
>
<CoverageInline companyId={companyId} definitionId={definition.id} />
<span className="shrink-0 text-muted-foreground">· View in Coverage</span>
</button>
</DetailRow> </DetailRow>
<DetailRow label="Created">{formatRelative(definition.createdAt)}</DetailRow> <DetailRow label="Created">{formatRelative(definition.createdAt)}</DetailRow>
<DetailRow label="Updated">{formatRelative(definition.updatedAt)}</DetailRow> <DetailRow label="Updated">{formatRelative(definition.updatedAt)}</DetailRow>
@@ -3594,11 +3617,17 @@ function SecretDetailsTab({
secret, secret,
providers, providers,
providerConfigs, providerConfigs,
onViewUsage,
}: { }: {
secret: CompanySecret; secret: CompanySecret;
providers: SecretProviderDescriptor[]; providers: SecretProviderDescriptor[];
providerConfigs: CompanySecretProviderConfig[]; providerConfigs: CompanySecretProviderConfig[];
onViewUsage: () => void;
}) { }) {
const bindingLabel = (secret.referenceCount ?? 0) === 1
? "1 binding"
: `${secret.referenceCount ?? 0} bindings`;
return ( return (
<dl className="divide-y divide-border/60 text-xs"> <dl className="divide-y divide-border/60 text-xs">
<DetailRow label="Description"> <DetailRow label="Description">
@@ -3617,9 +3646,14 @@ function SecretDetailsTab({
</DetailRow> </DetailRow>
<DetailRow label="Latest version">v{secret.latestVersion}</DetailRow> <DetailRow label="Latest version">v{secret.latestVersion}</DetailRow>
<DetailRow label="References"> <DetailRow label="References">
{(secret.referenceCount ?? 0) === 1 <button
? "1 binding" type="button"
: `${secret.referenceCount ?? 0} bindings`} className="inline-flex items-center gap-1 text-left text-primary hover:underline"
onClick={onViewUsage}
>
{bindingLabel}
<span className="text-muted-foreground">· View in Usage</span>
</button>
</DetailRow> </DetailRow>
<DetailRow label="Created">{formatRelative(secret.createdAt)}</DetailRow> <DetailRow label="Created">{formatRelative(secret.createdAt)}</DetailRow>
<DetailRow label="Updated">{formatRelative(secret.updatedAt)}</DetailRow> <DetailRow label="Updated">{formatRelative(secret.updatedAt)}</DetailRow>