Jannik/PaperClipAI
1
0 Fork 0
mirror of https://github.com/paperclipai/paperclip.git synced 2026-10-27 11:03:27 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix(server): preserve coalesced feedback retry identity

Browse Source 
Co-Authored-By: Paperclip <noreply@paperclip.ing>
This commit is contained in:
DottaandPaperclip committed 2026-08-15 08:33:01 +00:00
1 parent 9bf5683a08
commit 809c833c43
2 files changed
+12
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

server/src/__tests__/heartbeat-process-recovery.test.ts
+3
View File
@@ -1922,6 +1922,9 @@ describeEmbeddedPostgres("heartbeat orphaned process recovery", () => {
expect(runs).toHaveLength(2);
const coalescedRun = runs.find((run) => run.id === secondRunId);
expect(coalescedRun?.contextSnapshot).toMatchObject({
wakeReason: "feedback_delivery_retry",
retryReason: "feedback_delivery_retry",
retryOfRunId: fixture.runId,
feedbackDeliveryRootWakeupRequestId: fixture.wakeupRequestId,
feedbackDeliveryRetryGeneration: 1,
wakeCommentIds: [first.commentId, secondCommentId],
server/src/services/heartbeat.ts
+9
View File
@@ -10446,6 +10446,12 @@ export function heartbeatService(db: Db, options: HeartbeatServiceOptions = {})
mergedContext.commentId = orderedCommentIds.at(-1);
mergedContext.wakeCommentId = orderedCommentIds.at(-1);
}
// The queued run now owns the feedback-delivery obligation. Preserve
// its retry identity even when the queued context came from a newer,
// unrelated wake so terminal disposition can recover a failed merge.
mergedContext.wakeReason = FEEDBACK_DELIVERY_RETRY_WAKE_REASON;
mergedContext.retryReason = FEEDBACK_DELIVERY_RETRY_REASON;
mergedContext.retryOfRunId = input.run.id;
mergedContext.feedbackDeliveryRootWakeupRequestId = input.delivery.rootWakeupRequestId;
mergedContext.feedbackDeliverySourceRunId = input.run.id;
mergedContext.feedbackDeliveryRetryGeneration = 1;
@@ -10487,6 +10493,9 @@ export function heartbeatService(db: Db, options: HeartbeatServiceOptions = {})
mergedDeferredContext.commentId = orderedCommentIds.at(-1);
mergedDeferredContext.wakeCommentId = orderedCommentIds.at(-1);
}
mergedDeferredContext.wakeReason = FEEDBACK_DELIVERY_RETRY_WAKE_REASON;
mergedDeferredContext.retryReason = FEEDBACK_DELIVERY_RETRY_REASON;
mergedDeferredContext.retryOfRunId = input.run.id;
mergedDeferredContext.feedbackDeliveryRootWakeupRequestId = input.delivery.rootWakeupRequestId;
mergedDeferredContext.feedbackDeliverySourceRunId = input.run.id;
mergedDeferredContext.feedbackDeliveryRetryGeneration = 1;