fix(tasks): hide More messages when no hidden history exists (#22099)

## Thinking Path

> - Paperclip is the open source app people use to manage AI agents for
work
> - The task page shows the instruction and the recent exchange first,
and shows a **More messages** button for older history
> - The button is visible on almost every task. A click often shows no
new message, and the button then goes away
> - The compact chat shows only the latest run, so the page treats any
task with two or more runs as a task with hidden history
> - The recent comments read also reports more comments when the omitted
comment is already pinned into the window
> - This pull request shows the button only when a message is really
hidden
> - The benefit is a clean task page and a button that always reveals
something

## Linked Issues or Issue Description

Refs #17751

**What happened?**

The task page shows **More messages** on almost every task. A click
often adds no message, and the button then goes away.

**Expected behavior**

The page shows **More messages** only when it hides an older comment or
an older run that has no visible answer.

**Steps to reproduce**

1. Create a task and let an agent answer it in two runs.
2. Open the task with a fresh application cache.
3. See **More messages** above the conversation. Click it. No new
message appears.

## What Changed

- The recent run window keeps the newest omitted run (`earlierRun`), and
it keeps that run as later turns arrive.
- The task page ignores the omitted run when the run succeeded and its
agent answer is already visible. A failed run, or a run with no visible
answer, still shows the button. The answer check is the same one the
chat thread uses (moved to `ui/src/lib/run-answer-visibility.ts`), so a
legacy withheld-run placeholder or a progress comment does not count as
an answer.
- `GET /issues/:id/recent-comments` reads seven rows instead of five. It
sets `hasMore` only when the window leaves out a comment. Older comments
that are pinned into the window (the latest human message and the first
instruction) do not count.
- Added regression tests for the page (including the placeholder case),
the run window cache and the server route.

## Verification

- `pnpm exec vitest run src/pages/IssueDetail.test.tsx
src/components/TaskChatThread.test.tsx src/lib` in `ui`: 3,637 passed, 1
skipped. The new page test fails without the fix.
- After the review fixes: `pnpm exec vitest run
src/pages/IssueDetail.test.tsx src/components/TaskChatThread.test.tsx
src/lib/issueChatBootstrapCache.test.ts
src/lib/issueDetailCache.test.ts` in `ui`: 738 passed, 1 skipped.
- `pnpm exec vitest run src/__tests__/task-cold-open.test.ts
src/__tests__/issue-chat-bootstrap-routes.test.ts` in `server`: 33
passed.
- `tsc --noEmit` in `ui` and `server`: no errors in the changed files.
- I did not do a check in the browser.

## Risks

Low risk. No schema change. The API response shape does not change. The
run window cache gets one optional field, and older saved caches without
the field keep the old behavior.

Limitation: the recent runs read returns only the two latest runs, so
the page sees one omitted run. If that run has a visible answer but an
older run failed, the page does not show the button. **More task actions
→ Show task activity** still shows that run.

## Model Used

Claude Opus 5.5 (`claude-opus-5-5`) through Claude Code, with tool use
and code execution.

## Checklist

- [x] I have included a thinking path that traces from project context
to this change
- [x] I have specified the model used (with version and capability
details)
- [x] I have checked ROADMAP.md and confirmed this PR does not duplicate
planned core work
- [x] I have searched GitHub for duplicate or related PRs and linked
them above
- [x] I have either (a) linked existing issues with `Fixes: #` / `Closes
#` / `Refs #` OR (b) described the issue in-PR following the relevant
issue template
- [x] I have not referenced internal/instance-local Paperclip issues or
links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip`
URLs)
- [x] My branch name describes the change (e.g. `docs/...`, `fix/...`)
and contains no internal Paperclip ticket id or instance-derived details
- [x] I have run tests locally and they pass
- [x] I have added or updated tests where applicable
- [x] I have updated relevant documentation to reflect my changes
- [x] I have considered and documented any risks above
- [ ] All Paperclip CI gates are green
- [ ] Greptile is 5/5 with no open P2s, recommendations, or follow-ups
- [x] I will address all Greptile and reviewer comments before
requesting merge

🤖 Generated with [Claude Code](https://claude.com/claude-code)

---------

Co-authored-by: devinfoley <139239+devinfoley@users.noreply.github.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
authored and GitHub committed 2026-11-20 17:41:17 -08:00
1 parent b4cea5b5a4
commit 621c5577cd
9 files changed
+134 -56

No files matched your search

@@ -134,6 +134,26 @@ const support = externalDatabase ? { supported: true } : await getEmbeddedPostgr
expect(response.body.comments.map((c: { body: string }) => c.body)).toEqual([
"Human direction", "Newest direction", "New reply 5", "New reply 4", "New reply 3", "New reply 2",
]);
expect(response.body.hasMore).toBe(true);
});
it.each([
{ replies: 4, pinned: 2, hasMore: false },
{ replies: 4, pinned: 3, hasMore: true },
{ replies: 4, pinned: 6, hasMore: true },
])("reports more comments only when one stays hidden ($replies replies after $pinned older)", async ({ replies, pinned, hasMore }) => {
const bareIssueId = randomUUID();
await db.insert(issues).values({ id: bareIssueId, companyId, title: "No description" });
await db.insert(issueComments).values([
...Array.from({ length: pinned }, (_, i) => ({
companyId, issueId: bareIssueId, body: `Older ${i}`, createdAt: new Date(i),
...(i === 0 || i === pinned - 1 ? { authorType: "user" as const, authorUserId: "local-board" } : { authorType: "agent" as const, authorAgentId: agentId }),
})),
...Array.from({ length: replies }, (_, i) => ({ companyId, issueId: bareIssueId, body: `Reply ${i}`, authorType: "agent" as const, authorAgentId: agentId, createdAt: new Date(1000 + i) })),
]);
const response = await request(app()).get(`/api/issues/${bareIssueId}/recent-comments`);
expect(response.status).toBe(200);
expect(response.body.comments).toHaveLength(replies + 2);
expect(response.body.hasMore).toBe(hasMore);
});
it("loads the original input receipts outside the recent activity window and ignores replay receipts", async () => {
const commentId = randomUUID();
+3 -2
View File
@@ -17357,17 +17357,18 @@ export function issueRoutes(
});
}
const [recent, human, firstInstruction] = await Promise.all([
svc.listComments(issue.id, { companyId: issue.companyId, order: "desc", limit: 5 }),
svc.listComments(issue.id, { companyId: issue.companyId, order: "desc", limit: 7 }),
svc.listComments(issue.id, { companyId: issue.companyId, order: "desc", limit: 1, humanOnly: true }),
issue.description?.trim()
? Promise.resolve([])
: svc.listComments(issue.id, { companyId: issue.companyId, order: "asc", limit: 1, humanOnly: true }),
]);
const comments = [...new Map([...firstInstruction, ...human, ...recent.slice(0, 4)].map((comment) => [comment.id, comment])).values()];
const included = new Set(comments.map((comment) => comment.id));
return runRedactions.redactForIssue(issue.companyId, issue.id, {
comments,
latestCommentId: recent[0]?.id ?? null,
hasMore: recent.length > 4,
hasMore: recent.slice(4).some((comment) => !included.has(comment.id)),
});
}
+7 -46
View File
@@ -1,3 +1,9 @@
import {
hasVisibleRunAnswer,
LEGACY_WITHHELD_RUN_COMMENT,
presentationDecisionCommentId,
semanticProgressCommentIds,
} from "@/lib/run-answer-visibility";
import { imagePreparationReceiptIds } from "./task-chat/image-resources";
import type { ScrollingHistory } from "@/components/task-chat/TaskMessageScroller";
import { TaskChatShimmerScope } from "@/components/task-chat/TaskChatShimmer";
@@ -306,8 +312,6 @@ function isNativePaperclipRunnerRun(
run?.runtimeMode === "native" && run.adapterType === "paperclip_runner"
);
}
const LEGACY_WITHHELD_RUN_COMMENT =
"Run completed. Agent did not post a summary comment this run (transcript withheld — see run log).";
function acceptedSemanticResult(
value: unknown,
@@ -348,42 +352,6 @@ function acceptedSemanticResultDisposition(value: unknown): string | null {
: null;
}
function presentationDecisionCommentId(
value: unknown,
): string | null | undefined {
if (!value || typeof value !== "object" || Array.isArray(value))
return undefined;
const decision = (value as Record<string, unknown>).presentationDecision;
if (!decision || typeof decision !== "object" || Array.isArray(decision))
return undefined;
const record = decision as Record<string, unknown>;
if (record.schema !== "paperclip.run_presentation_decision.v1")
return undefined;
return typeof record.commentId === "string" && record.commentId.trim()
? record.commentId
: null;
}
function semanticProgressCommentIds(value: unknown): Set<string> {
if (!value || typeof value !== "object" || Array.isArray(value))
return new Set();
const receipts = (value as Record<string, unknown>).semanticToolReceipts;
if (!receipts || typeof receipts !== "object" || Array.isArray(receipts))
return new Set();
const ids = new Set<string>();
for (const receipt of Object.values(receipts)) {
if (!receipt || typeof receipt !== "object" || Array.isArray(receipt))
continue;
const record = receipt as Record<string, unknown>;
if (record.operationId !== "report_progress") continue;
const result = record.result;
if (!result || typeof result !== "object" || Array.isArray(result))
continue;
const commentId = (result as Record<string, unknown>).commentId;
if (typeof commentId === "string" && commentId) ids.add(commentId);
}
return ids;
}
function acceptedSemanticResultVerificationCaveats(value: unknown) {
const runResult =
@@ -1046,14 +1014,7 @@ export function TaskChatThread(props: TaskChatThreadProps) {
const meta = linkedRunMetaById.get(run.id);
if (acceptedSemanticResultDisposition(meta?.resultJson) === "yielded" ||
interactions?.some(interaction => interaction.sourceRunId === run.id && interaction.status === "pending")) continue;
const presentationCommentId = presentationDecisionCommentId(meta?.resultJson);
const progressCommentIds = semanticProgressCommentIds(meta?.resultJson);
if (projectedComments.some(comment =>
comment.authorType === "agent" && !comment.deletedAt && comment.body.trim() &&
comment.body !== LEGACY_WITHHELD_RUN_COMMENT && !progressCommentIds.has(comment.id) &&
(comment.runId ?? comment.createdByRunId ?? comment.derivedCreatedByRunId) === run.id &&
(presentationCommentId === undefined || presentationCommentId === comment.id),
)) deferred.add(run.id);
if (hasVisibleRunAnswer(projectedComments, run.id, meta?.resultJson)) deferred.add(run.id);
}
return deferred;
}, [issueId, runs, projectedComments, linkedRunMetaById, interactions, compactTranscriptDeferral, slowSettledTranscriptRunIds, openedAt]);
+10 -4
View File
@@ -15,6 +15,7 @@ import { queryKeys } from "@/lib/queryKeys";
export interface RecentIssueRunWindow {
runs: RunForIssue[];
hasEarlierRuns: boolean;
earlierRun?: Pick<RunForIssue, "runId" | "status" | "resultJson"> | null;
}
export function recentIssueActivityQueryKey(issueRef: string) {
@@ -92,7 +93,7 @@ export async function fetchRecentIssueRunWindow(
const existingRunIds = new Set(recent.map((run) => run.runId));
previous = previous.filter((run) => existingRunIds.has(run.runId));
}
return buildRecentIssueRunWindow(recent, previous, !reconciledFullHistory && previousWindow?.hasEarlierRuns === true);
return buildRecentIssueRunWindow(recent, previous, reconciledFullHistory ? false : previousWindow?.hasEarlierRuns === true, reconciledFullHistory ? null : previousWindow?.earlierRun);
}
/**
@@ -103,17 +104,22 @@ export function buildRecentIssueRunWindow(
recent: RunForIssue[],
previous: RunForIssue[] = [],
previouslyHadEarlierRuns = false,
previousEarlierRun?: RecentIssueRunWindow["earlierRun"],
): RecentIssueRunWindow {
// The second row refreshes a just-finished predecessor. Start with only
// the latest run, then keep every run observed while this task is open.
const visible = new Set([...previous.map((run) => run.runId), ...recent.slice(0, 1).map((run) => run.runId)]);
return {
const omitted = recent.find((run) => !visible.has(run.runId));
const retained = recent.length >= 2 && previouslyHadEarlierRuns;
const window: RecentIssueRunWindow = {
runs: [...new Map([...previous, ...recent].filter((run) => visible.has(run.runId)).map((run) => [run.runId, run])).values()],
// A first run is already visible. The disclosure needs evidence of an
// omitted run, and must retain that evidence as later turns arrive.
hasEarlierRuns: recent.some((run) => !visible.has(run.runId))
|| (recent.length >= 2 && previouslyHadEarlierRuns),
hasEarlierRuns: !!omitted || retained,
};
const earlierRun = omitted ? { runId: omitted.runId, status: omitted.status, resultJson: omitted.resultJson } : retained ? previousEarlierRun : undefined;
if (earlierRun) window.earlierRun = earlierRun;
return window;
}
/** Prefetched answers for live state stay usable only briefly. */
+1 -1
View File
@@ -66,7 +66,7 @@ describe("seedIssueChatBootstrap", () => {
// The activity key holds the de-duplicated recent answer.
expect(qc.getQueryData(recentIssueActivityQueryKey(ref))).toEqual([event("a1"), event("a2")]);
// A cold open shows the latest run and discloses the earlier one.
expect(qc.getQueryData(recentIssueRunWindowQueryKey(ref))).toEqual({ runs: [run("r2")], hasEarlierRuns: true });
expect(qc.getQueryData(recentIssueRunWindowQueryKey(ref))).toEqual({ runs: [run("r2")], hasEarlierRuns: true, earlierRun: { runId: "r1", status: "succeeded" } });
expect(qc.getQueryData(queryKeys.issues.interactions(ref))).toEqual([]);
expect(qc.getQueryData(queryKeys.issues.attachments(ref))).toEqual([]);
expect(qc.getQueryData(queryKeys.issues.liveRuns(ref))).toEqual([]);
+2 -2
View File
@@ -229,7 +229,7 @@ describe("task navigation prefetch", () => {
await prefetchIssueDetailForNavigation(client, ref, { issue, history: true });
expect(issuesApi.chatBootstrap).toHaveBeenCalledWith(issue.companyId, [ref]);
expect(client.getQueryData(recentIssueActivityQueryKey(ref))).toEqual([{ id: "event-1" }]);
expect(client.getQueryData(recentIssueRunWindowQueryKey(ref))).toEqual({ runs: [run("run-2", "failed")], hasEarlierRuns: true });
expect(client.getQueryData(recentIssueRunWindowQueryKey(ref))).toEqual({ runs: [run("run-2", "failed")], hasEarlierRuns: true, earlierRun: { runId: "run-1", status: "succeeded" } });
expect(client.getQueryData(queryKeys.issues.liveRuns(ref))).toEqual([]);
expect(client.getQueryData([...queryKeys.issues.comments(ref), "recent"])).toEqual(recentComments);
// The recent-comments read shares the bootstrap; the header keeps its own read.
@@ -263,7 +263,7 @@ describe("task navigation prefetch", () => {
await prefetchIssueDetailForNavigation(client, ref, { issue, history: true });
expect(client.getQueryData(recentIssueActivityQueryKey(ref))).toEqual([{ id: "event-1" }]);
// Same window shape the page builds: the latest run, plus evidence of earlier runs.
expect(client.getQueryData(recentIssueRunWindowQueryKey(ref))).toEqual({ runs: [run("run-2", "failed")], hasEarlierRuns: true });
expect(client.getQueryData(recentIssueRunWindowQueryKey(ref))).toEqual({ runs: [run("run-2", "failed")], hasEarlierRuns: true, earlierRun: { runId: "run-1", status: "succeeded" } });
expect(client.getQueryData(queryKeys.issues.interactions(ref))).toEqual([]);
expect(client.getQueryData(queryKeys.issues.attachments(ref))).toEqual([]);
expect(client.getQueryData(queryKeys.issues.liveRuns(ref))).toEqual([]);
+62
View File
@@ -0,0 +1,62 @@
export const LEGACY_WITHHELD_RUN_COMMENT =
"Run completed. Agent did not post a summary comment this run (transcript withheld — see run log).";
export function presentationDecisionCommentId(
value: unknown,
): string | null | undefined {
if (!value || typeof value !== "object" || Array.isArray(value))
return undefined;
const decision = (value as Record<string, unknown>).presentationDecision;
if (!decision || typeof decision !== "object" || Array.isArray(decision))
return undefined;
const record = decision as Record<string, unknown>;
if (record.schema !== "paperclip.run_presentation_decision.v1")
return undefined;
return typeof record.commentId === "string" && record.commentId.trim()
? record.commentId
: null;
}
export function semanticProgressCommentIds(value: unknown): Set<string> {
if (!value || typeof value !== "object" || Array.isArray(value))
return new Set();
const receipts = (value as Record<string, unknown>).semanticToolReceipts;
if (!receipts || typeof receipts !== "object" || Array.isArray(receipts))
return new Set();
const ids = new Set<string>();
for (const receipt of Object.values(receipts)) {
if (!receipt || typeof receipt !== "object" || Array.isArray(receipt))
continue;
const record = receipt as Record<string, unknown>;
if (record.operationId !== "report_progress") continue;
const result = record.result;
if (!result || typeof result !== "object" || Array.isArray(result))
continue;
const commentId = (result as Record<string, unknown>).commentId;
if (typeof commentId === "string" && commentId) ids.add(commentId);
}
return ids;
}
export function hasVisibleRunAnswer(
comments: ReadonlyArray<{
id: string;
authorType: string;
body: string;
deletedAt?: Date | string | null;
runId?: string | null;
createdByRunId?: string | null;
derivedCreatedByRunId?: string | null;
}>,
runId: string,
resultJson: unknown,
): boolean {
const presentationCommentId = presentationDecisionCommentId(resultJson);
const progressCommentIds = semanticProgressCommentIds(resultJson);
return comments.some(comment =>
comment.authorType === "agent" && !comment.deletedAt && comment.body.trim() &&
comment.body !== LEGACY_WITHHELD_RUN_COMMENT && !progressCommentIds.has(comment.id) &&
(comment.runId ?? comment.createdByRunId ?? comment.derivedCreatedByRunId) === runId &&
(presentationCommentId === undefined || presentationCommentId === comment.id),
);
}
+24
View File
@@ -1,6 +1,7 @@
import { TaskChatPausedTakeover, type TaskComposerPause } from "../components/task-chat/TaskChatPausedTakeover";
// @vitest-environment jsdom
import { LEGACY_WITHHELD_RUN_COMMENT } from "@/lib/run-answer-visibility";
import type { Breadcrumb } from "../context/BreadcrumbContext";
import { DispositionRecoveryNotice, type DispositionRecoverySnapshot } from "../components/DispositionRecoveryNotice";
@@ -2455,6 +2456,29 @@ describe("IssueDetail", () => {
});
});
it.each([
{ status: "succeeded", answered: true, disclosed: false },
{ status: "succeeded", answered: false, disclosed: true },
{ status: "failed", answered: true, disclosed: true },
{ status: "succeeded", answered: true, disclosed: true, body: LEGACY_WITHHELD_RUN_COMMENT },
])("discloses an omitted $status run only when its answer is not visible (answered: $answered)", async ({ status, answered, disclosed, body = "Earlier answer" }) => {
queryClient.setQueryData(["issues", "history-expanded", "PAP-1"], false);
mockIssuesApi.get.mockResolvedValue(createIssue());
const latest = { runId: "latest", status: "succeeded", agentId: "agent-1", createdAt: new Date().toISOString() };
const older = { ...latest, runId: "older", status };
const answer = createIssueComment({ id: "answer", authorType: "agent", authorAgentId: "agent-1", authorUserId: null,
body, createdByRunId: answered ? "older" : "unrelated" });
mockIssuesApi.recentComments.mockResolvedValue({ comments: [answer], latestCommentId: answer.id, hasMore: false });
mockActivityApi.recentRunsForIssue.mockResolvedValue([latest, older]);
await act(async () => renderIssueView());
await waitForAssertion(() => {
const props = mockIssueChatThreadRender.mock.calls.at(-1)?.[0];
expect(props?.linkedRuns).toMatchObject([latest]);
expect(props?.comments).toMatchObject([{ id: "answer" }]);
expect(Boolean(props?.historyControl)).toBe(disclosed);
});
});
it.each([false, true])("refreshes admission with latest comments (compact chat: %s)", async compact => {
const interruption: NonNullable<Issue["interruption"]> = { intentId: "retry", responsibility: "system", state: "failed",
nextRetryAt: null, canRetry: true, userAction: null, sourceRunIds: ["failed-run"], observedRunId: "failed-run",
+5 -1
View File
@@ -233,6 +233,7 @@ import {
type IssueChatRunFinalizationAction,
} from "../components/IssueChatThread";
import { TaskChatThread } from "../components/TaskChatThread";
import { hasVisibleRunAnswer } from "@/lib/run-answer-visibility";
import type { TaskChatIssueBrief } from "../components/task-chat/TaskChatDescriptionBubble";
import { useClassicTaskInterfaceEnabled } from "../hooks/useClassicTaskInterfaceEnabled";
import { useStreamlinedUiEnabled } from "../hooks/useStreamlinedUiEnabled";
@@ -1672,7 +1673,10 @@ const IssueDetailChatTab = memo(function IssueDetailChatTab({
...(Array.isArray(linkedRunHistory) ? linkedRunHistory : linkedRunHistory?.runs ?? []),
...(conversationMode && !historyExpanded ? commentRuns.data ?? [] : []),
].map(run => [run.runId, run])).values()], [linkedRunHistory, conversationMode, historyExpanded, commentRuns.data]);
const hasEarlierRuns = !Array.isArray(linkedRunHistory) && linkedRunHistory?.hasEarlierRuns === true;
const earlierRun = Array.isArray(linkedRunHistory) ? undefined : linkedRunHistory?.earlierRun;
const hasEarlierRuns = !Array.isArray(linkedRunHistory) && linkedRunHistory?.hasEarlierRuns === true && !(
earlierRun?.status === "succeeded" && hasVisibleRunAnswer(comments, earlierRun.runId, earlierRun.resultJson)
);
const resolvedActivity = useMemo(
() => [...new Map([...(activity ?? []), ...(inputFacts.data ?? [])].map((event) => [event.id, event])).values()],
[activity, inputFacts.data],