Jannik/PaperClipAI
1
0 Fork 0
mirror of https://github.com/paperclipai/paperclip.git synced 2026-11-05 21:02:34 +01:00
Code Issues Packages Projects Releases Wiki Activity

test(evals): accept concealed expired-session reads with full sign-in proof

Browse Source
This commit is contained in:
Dotta committed 2026-10-27 16:00:38 -05:00
1 parent 872988beb1
commit 43aeb5c141
2 files changed
+3 -3
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

tests/runner-e2e/chat-catalog-domains/identity-sign-in.test.ts
+2 -2
View File
@@ -6,9 +6,9 @@ function valid() { return { personId: "alex", returnedPersonId: "alex", companyI
nonmemberCompanyStatus: 403, nonmemberConversationStatus: 404, nonmemberBrowserBlocked: true,
beforeCommentIds: [], afterCommentIds: [], runIds: [] }; }
describe("real sign-in boundary acceptance", () => {
it("accepts complete real auth+same-resource+audience evidence", () => { expect(gradeSignInBoundary(valid()).passed).toBe(true); });
it.each([401, 404])("accepts complete real auth+same-resource+audience evidence with production denial %s", expiredReadStatus => { expect(gradeSignInBoundary({ ...valid(), expiredReadStatus }).passed).toBe(true); });
it.each([
{ expiredReadStatus: 200 }, { returnedPersonId: "riley" }, { returnedConversationId: "new-conversation" },
{ expiredReadStatus: 200 }, { expiredReadStatus: 403 }, { expiredReadStatus: 500 }, { returnedPersonId: "riley" }, { returnedConversationId: "new-conversation" },
{ safeReturnPath: "https://other.test/steal" }, { nonmemberConversationStatus: 200 }, { nonmemberBrowserBlocked: false },
{ runIds: ["accidental-run"] }, { afterCommentIds: ["sent-expired-intent"] }, { restoredComposerVisible: false },
])("rejects incomplete or wrong boundary proof %j", change => { expect(gradeSignInBoundary({ ...valid(), ...change }).passed).toBe(false); });
tests/runner-e2e/chat-catalog-domains/identity-sign-in.ts
+1 -1
View File
@@ -20,7 +20,7 @@ interface SignInEvidence {
export function gradeSignInBoundary(value: unknown) {
const c = checks(); const o = value as SignInEvidence | undefined;
c.add("real-invalidated-human-session", !!o && !!o.personId && o.personId !== "local-board" && o.beforeComposerVisible
&& o.expiredReadStatus === 401 && o.expiredComposerAbsent, "A previously usable real human session is revoked by the server; the expired browser cannot read or compose in its conversation.");
&& [401, 404].includes(o.expiredReadStatus) && o.expiredComposerAbsent, "A previously usable real human session is revoked by the server; the expired browser cannot read or compose in its conversation.");
c.add("configured-safe-sign-in-return", !!o && o.configuredSignInVisible && typeof o.safeReturnPath === "string" && o.safeReturnPath === o.intendedReturnPath
&& o.safeReturnPath.startsWith("/") && !o.safeReturnPath.startsWith("//") && o.returnedPersonId === o.personId
&& o.returnedConversationId === o.conversationId && o.restoredComposerVisible,