mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-11-20 09:50:48 +01:00
fix(ci): waive lockfile bake time for pinned harnesses (#22349)
## Thinking Path > - Paperclip is the open source app people use to manage AI agents for work. > - Paperclip Runner ships pinned harnesses that run those agents. > - Some new models require a new harness release before they can run. > - The lockfile bot waits three days before it can merge new dependency versions automatically. > - That wait held the Claude and Codex refresh in #22231. > - This PR waives the wait for a fixed set of harness packages so model updates can ship as soon as npm confirms the releases. ## Linked Issues or Issue Description Refs #22231, #22278, #14942, #15572, and #18238. **What happened?** The refresh in #22231 held 16 new Claude Agent SDK and Codex versions even though the new model support needed those harness updates. **Expected behavior** Verified npm releases of named harness packages can pass the gate immediately. The gate applies the normal minimum age to other packages. **Steps to reproduce** Compare the parent and head of #22231 across the three lockfiles managed by the bot. Run the gate with the publish times in its hold comment and a clock within three days of the releases. ## What Changed - Exempt 28 exact package names from the minimum age. These cover the Claude Agent SDK, Codex CLI, their provider-specific ACP bridges, OpenCode, and the Copilot binaries pinned by Runner. - Take package identities from the Runner manifest and active provider profiles, then check the managed lockfiles for platform binaries. Codex platform aliases use the same registry name with a platform suffix on each version. Pi and Kimi use separate npm locks. Gemini, Grok, the local Cursor CLI, and Antigravity use separate install paths. The Cursor Cloud SDK gets model availability from the service. - Keep the npm publish-time and resolution checks for every entry. Update the bot report and setup documentation. ## Verification - Replayed the exact #22231 lockfile diff using the bot's recorded publish times and a fixed clock. The previous gate held all 16 versions. The new gate verified all 16 and held zero. - Ran the workflow CLI against the same three lockfile pairs and the live npm registry. It wrote `eligible=true` and reported 16 passing versions. - Reconciled the 28 exact names with the Runner manifest, provider profiles, all three bot-managed pnpm lockfiles, and the npm manifests for Claude Agent SDK 0.3.328, Codex 0.170.0, and OpenCode 1.18.34. - Ran `node --test '.github/scripts/tests/*.test.mjs'` locally. All 810 tests passed. The new cases cover mixed refreshes, similar names, registry errors, missing publish times, and non-registry resolutions. - Ran `git diff --check`. - GitHub Actions passed the required typecheck, build, test, and e2e checks on `9c8bccac51`. The Canary runner shut down on the first attempt, and browser shard 7 had a test-company cleanup error. Both passed on the failed-jobs retry. [CI attempt 2](https://github.com/paperclipai/paperclip/actions/runs/44610325309/attempts/2) - Standard Greptile scored the same revision 5/5. [Review](https://github.com/paperclipai/paperclip/pull/22349#issuecomment-7021573041) ## Risks An npm release of an allowlisted harness can reach master during its first three days through the existing automatic merge path. A compromised release can use that same path. Every added version still needs an npm publish time and a registry resolution. Review new platform package names before adding them to the allowlist. Superagent requests security review for this policy change. [Scanner finding](https://github.com/paperclipai/paperclip/pull/22349#discussion_r4634801827) ## Model Used OpenAI GPT-6 in Codex, with shell and code execution. The exact model snapshot and context window were not reported. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either (a) linked existing issues with `Fixes: #` / `Closes #` / `Refs #` OR (b) described the issue in-PR following the relevant issue template - [x] I have not referenced internal/instance-local Paperclip issues or links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip` URLs) - [x] My branch name describes the change (e.g. `docs/...`, `fix/...`) and contains no internal Paperclip ticket id or instance-derived details - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] All Paperclip CI gates are green - [x] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I will address all Greptile and reviewer comments before requesting merge Co-authored-by: Paperclip <noreply@paperclip.ing>
This commit is contained in:
1 parent
d8ae55198d
commit
3c32b8d4dc
4 files changed
+91
-10
No files matched your search
@@ -2,9 +2,8 @@
|
||||
/**
|
||||
* check-lockfile-release-age.mjs
|
||||
* Decides whether the lockfile bot may merge refreshed pnpm lockfiles without review.
|
||||
* Every package version that the refresh adds must be published on npm for at least
|
||||
* the minimum age. A version that is too new, or that cannot be verified, holds the
|
||||
* PR for a human.
|
||||
* Every added version must have a verified npm publish time. Versions outside
|
||||
* the harness allowlist must also meet the minimum age.
|
||||
*
|
||||
* Exports: parseLockfilePackages(text), addedPackageVersions(baseText, headText),
|
||||
* addedPackageVersionsAcross(pairs),
|
||||
@@ -28,6 +27,36 @@ const RESOLUTION = /^ {4}resolution: (.+?)\s*$/;
|
||||
// directory resolution names its own source and needs a human.
|
||||
const REGISTRY_RESOLUTION = /^\{integrity: [^,{}]+\}$/;
|
||||
const DAY_MS = 24 * 60 * 60 * 1000;
|
||||
const HARNESS_PACKAGES = new Set([
|
||||
'@agentclientprotocol/claude-agent-acp',
|
||||
'@agentclientprotocol/codex-acp',
|
||||
'@anthropic-ai/claude-agent-sdk',
|
||||
'@anthropic-ai/claude-agent-sdk-darwin-arm64',
|
||||
'@anthropic-ai/claude-agent-sdk-darwin-x64',
|
||||
'@anthropic-ai/claude-agent-sdk-linux-arm64',
|
||||
'@anthropic-ai/claude-agent-sdk-linux-arm64-musl',
|
||||
'@anthropic-ai/claude-agent-sdk-linux-x64',
|
||||
'@anthropic-ai/claude-agent-sdk-linux-x64-musl',
|
||||
'@anthropic-ai/claude-agent-sdk-win32-arm64',
|
||||
'@anthropic-ai/claude-agent-sdk-win32-x64',
|
||||
'@github/copilot-darwin-arm64',
|
||||
'@github/copilot-darwin-x64',
|
||||
'@github/copilot-linux-x64',
|
||||
'@openai/codex',
|
||||
'opencode-ai',
|
||||
'opencode-darwin-arm64',
|
||||
'opencode-darwin-x64',
|
||||
'opencode-darwin-x64-baseline',
|
||||
'opencode-linux-arm64',
|
||||
'opencode-linux-arm64-musl',
|
||||
'opencode-linux-x64',
|
||||
'opencode-linux-x64-baseline',
|
||||
'opencode-linux-x64-baseline-musl',
|
||||
'opencode-linux-x64-musl',
|
||||
'opencode-windows-arm64',
|
||||
'opencode-windows-x64',
|
||||
'opencode-windows-x64-baseline',
|
||||
]);
|
||||
|
||||
/** Maps each key of the lockfile's top-level `packages:` section to its resolution. */
|
||||
export function parseLockfilePackages(text) {
|
||||
@@ -122,7 +151,7 @@ async function holdReason({ name, version, resolution }, fetchPublishTime, now,
|
||||
}
|
||||
if (!published || Number.isNaN(published.getTime())) return 'no publish time on npm';
|
||||
const ageMs = now.getTime() - published.getTime();
|
||||
if (ageMs < minAgeMs) {
|
||||
if (ageMs < minAgeMs && !HARNESS_PACKAGES.has(name)) {
|
||||
return `published ${published.toISOString()} (${(ageMs / DAY_MS).toFixed(1)} days ago)`;
|
||||
}
|
||||
return null;
|
||||
@@ -131,14 +160,14 @@ async function holdReason({ name, version, resolution }, fetchPublishTime, now,
|
||||
export function formatReport(result, minAgeDays) {
|
||||
const lines = ['<!-- lockfile-release-age -->'];
|
||||
if (result.eligible) {
|
||||
lines.push(`All ${result.checked} added package versions are at least ${minAgeDays} days old. The lockfile bot merges this PR.`);
|
||||
lines.push(`All ${result.checked} added package versions passed the release-age gate. The lockfile bot merges this PR.`);
|
||||
} else {
|
||||
lines.push(
|
||||
`The lockfile bot did not merge this PR. These added package versions are newer than ${minAgeDays} days or could not be verified:`,
|
||||
'',
|
||||
...result.held.map(({ key, reason }) => `- \`${key}\`: ${reason}`),
|
||||
'',
|
||||
'A maintainer can review and merge this PR. If no one does, the daily refresh tries again and merges it when every version is old enough.',
|
||||
'A maintainer can review and merge this PR. If no one does, the daily refresh tries again and merges it once the refresh passes the gate.',
|
||||
);
|
||||
}
|
||||
return `${lines.join('\n')}\n`;
|
||||
|
||||
@@ -150,6 +150,56 @@ test('holds a version newer than the minimum age', async () => {
|
||||
assert.match(result.held[0].reason, /0\.5 days ago/);
|
||||
});
|
||||
|
||||
test('gives only named harness releases an exception to the minimum age', async () => {
|
||||
const harnessKeys = [
|
||||
'@agentclientprotocol/claude-agent-acp@0.73.0',
|
||||
'@agentclientprotocol/codex-acp@1.6.2',
|
||||
'@anthropic-ai/claude-agent-sdk@0.3.328',
|
||||
'@anthropic-ai/claude-agent-sdk-linux-x64-musl@0.3.328',
|
||||
'@github/copilot-darwin-arm64@1.0.88',
|
||||
'@openai/codex@0.170.0',
|
||||
'@openai/codex@0.170.0-win32-arm64',
|
||||
'opencode-ai@1.18.34',
|
||||
'opencode-linux-x64-baseline-musl@1.18.34',
|
||||
];
|
||||
const harnesses = addedPackageVersions(lockfile([]), lockfile(harnessKeys));
|
||||
const other = addedPackageVersions(lockfile([]), lockfile([
|
||||
'@agentclientprotocol/sdk@1.9.0',
|
||||
'@anthropic-ai/claude-agent-sdk-lookalike@1.0.0',
|
||||
'fresh@1.0.1',
|
||||
]));
|
||||
const options = { fetchPublishTime: async () => daysAgo(0.5), now, minAgeMs: 3 * DAY_MS };
|
||||
|
||||
const result = await checkReleaseAge(harnesses, options);
|
||||
assert.deepEqual(result, { eligible: true, checked: harnessKeys.length, held: [] });
|
||||
assert.match(formatReport(result, 3), /passed the release-age gate/);
|
||||
|
||||
const mixed = await checkReleaseAge([...harnesses, ...other], options);
|
||||
assert.equal(mixed.eligible, false);
|
||||
assert.deepEqual(mixed.held.map(h => h.key), other.map(h => h.key));
|
||||
});
|
||||
|
||||
test('still requires a verified npm release for allowlisted names', async () => {
|
||||
const entries = addedPackageVersions(lockfile([]), lockfile([
|
||||
'@openai/codex@0.170.0',
|
||||
'@openai/codex@0.171.0',
|
||||
['@openai/codex@0.172.0', '{tarball: https://example.com/codex.tgz}'],
|
||||
'@openai/codex@https://example.com/codex.tgz',
|
||||
]));
|
||||
const result = await checkReleaseAge(entries, {
|
||||
fetchPublishTime: timesFrom({ '@openai/codex@0.170.0': new Error('npm registry returned 503') }),
|
||||
now,
|
||||
minAgeMs: 3 * DAY_MS,
|
||||
});
|
||||
assert.equal(result.eligible, false);
|
||||
assert.deepEqual(result.held.map(h => h.reason), [
|
||||
'registry lookup failed: npm registry returned 503',
|
||||
'no publish time on npm',
|
||||
'not a registry resolution: {tarball: https://example.com/codex.tgz}',
|
||||
'not a registry version',
|
||||
]);
|
||||
});
|
||||
|
||||
test('fails closed on lookup errors, missing publish times and non-registry versions', async () => {
|
||||
const entries = addedPackageVersions(
|
||||
lockfile([]),
|
||||
|
||||
@@ -206,7 +206,7 @@ jobs:
|
||||
|
||||
## Risks
|
||||
|
||||
The lockfile bot merges this PR without CI or review when every added package version is at least 3 days old on npm. Otherwise the PR waits for a maintainer, and the daily refresh tries again. The bot merges only the exact commit this workflow generated from manifests already reviewed on master. Unknown report lock baselines remain blocked. This update changes no permissions or paid enable gates.
|
||||
The lockfile bot merges this PR without CI or review when it verifies every added version on npm and all versions outside the harness allowlist are at least 3 days old. Otherwise the PR waits for a maintainer, and the daily refresh tries again. The bot merges only the exact commit this workflow generated from manifests already reviewed on master. Unknown report lock baselines remain blocked. This update changes no permissions or paid enable gates.
|
||||
|
||||
## Model Used
|
||||
|
||||
@@ -230,8 +230,8 @@ jobs:
|
||||
echo "head_sha=$(git rev-parse HEAD)" >> "$GITHUB_OUTPUT"
|
||||
|
||||
# Resolution picks the newest matching version for any added or widened
|
||||
# dependency. Merge without review only when every added version has been
|
||||
# on npm long enough for a hijacked release to be caught and pulled.
|
||||
# dependency. The gate verifies every added version on npm and enforces
|
||||
# the age requirement outside the harness allowlist.
|
||||
- name: Check release age of added package versions
|
||||
id: release-age
|
||||
if: steps.upsert-pr.outputs.pr_url != ''
|
||||
|
||||
@@ -232,7 +232,9 @@ The reporting-lock proof (`tests/runner-e2e/report-lock.json` and `report-lock.p
|
||||
|
||||
After a Dependabot lockfile merges, this workflow renews the proof. It first confirms three things: GitHub signed the merge commit, Dependabot opened the pull request, and the lockfile at the pull request head matches a verified Dependabot commit. It then records the merged lockfile in the proof and merges the refresh like any other. Paid evaluation jobs refuse the new lockfile until that refresh merges.
|
||||
|
||||
Resolution keeps locked versions, but it picks the newest matching version for an added or widened dependency. A release-age gate (`.github/scripts/check-lockfile-release-age.mjs`) therefore checks every package version that the refresh adds to any of the lockfiles. The bot merges only when each one has been on npm for at least 3 days. If any version is newer, or the gate cannot verify it, the bot leaves a comment on the PR and does not merge. A maintainer can review and merge it, or the daily scheduled refresh merges it after the versions are old enough. A held run saves its lockfiles, and the hashes of the `master` lockfiles it started from, as an artifact. The next run resolves from those lockfiles only while `master` still has every one of them unchanged. Held versions therefore stay put while their manifests are unchanged, even when newer releases appear, and a lockfile change on `master` replaces them. The gate also holds any added entry whose resolution is not a plain npm registry tarball. Change the age with `--min-age-days` in the workflow.
|
||||
Resolution keeps locked versions, but it picks the newest matching version for an added or widened dependency. A release-age gate (`.github/scripts/check-lockfile-release-age.mjs`) therefore checks every package version that the refresh adds to any of the lockfiles. The gate requires a verified npm publish time for each added version. Versions outside the exact-name harness allowlist must also be at least 3 days old. If a version fails either requirement, the bot holds the PR and posts a comment. A maintainer can review and merge it, or the daily scheduled refresh can merge it once it passes the gate. A held run saves its lockfiles, and the hashes of the `master` lockfiles it started from, as an artifact. The next run resolves from those lockfiles only while `master` still has every one of them unchanged. Held versions therefore stay put while their manifests are unchanged, even when newer releases appear, and a lockfile change on `master` replaces them. The gate also holds any added entry whose resolution is not a plain npm registry tarball. Change the age with `--min-age-days` in the workflow.
|
||||
|
||||
The allowlist covers the Codex CLI and Claude Agent SDK, their provider-specific ACP bridges, the OpenCode CLI, and the Copilot binaries pinned in the Runner manifest. Claude and OpenCode publish separate npm names for their platform binaries. Codex publishes its locked binaries under the `@openai/codex` name with platform suffixes on the versions. When a harness adds a platform package to a managed lockfile, review its exact npm name for inclusion in the allowlist. Pi and Kimi use separate npm lockfiles. The Gemini CLI package, Grok downloads, Cursor, and Antigravity use separate install paths outside the managed pnpm lockfiles.
|
||||
|
||||
The merge uses a dedicated GitHub App. Do not reuse `commitperclip` or bypass the built-in `github-actions` app. Those identities are available to other workflows, including release jobs that run dependency install scripts, so a bypass for them would let any of those workflows land code on `master`.
|
||||
|
||||
|
||||
Reference in new issue
Block a user