mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-10-28 20:21:50 +01:00
PAP-12318 remove SelectedAgentChat shim after AssistantChat adoption
Conference Room (BoardChat) already renders AssistantChat directly, so the SelectedAgentChat wrapper — and its deprecated conferenceRoomMode prop — was dead code. Delete the file and migrate the Storybook story to AssistantChatView. No conferenceRoomMode references remain; flag gating unchanged. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This commit is contained in:
1 parent
6fbf006ebb
commit
0e6f0f1fd8
2 files changed
+7
-49
No files matched your search
@@ -1,42 +0,0 @@
|
||||
import {
|
||||
AssistantChat,
|
||||
AssistantChatView,
|
||||
type AssistantChatProps,
|
||||
type AssistantChatViewProps,
|
||||
} from "./AssistantChat";
|
||||
|
||||
export {
|
||||
ASSISTANT_CHAT_ACTIVE_POLL_MS,
|
||||
ASSISTANT_CHAT_IDLE_POLL_MS,
|
||||
mergeAssistantChatComments,
|
||||
resolveAssistantChatPollInterval,
|
||||
resolveDefaultChatTarget,
|
||||
type AssistantChatStarterPrompt,
|
||||
type PendingAssistantChatComment,
|
||||
} from "./AssistantChat";
|
||||
|
||||
export type SelectedAgentChatProps = Omit<AssistantChatProps, "targetAgentId"> & {
|
||||
defaultTargetAgentId?: string | null;
|
||||
/** @deprecated AssistantChat always uses the assistant preset. */
|
||||
conferenceRoomMode?: boolean;
|
||||
};
|
||||
|
||||
export type SelectedAgentChatViewProps = AssistantChatViewProps & {
|
||||
/** @deprecated AssistantChatView always uses the assistant preset. */
|
||||
conferenceRoomMode?: boolean;
|
||||
};
|
||||
|
||||
export function SelectedAgentChat({
|
||||
defaultTargetAgentId,
|
||||
conferenceRoomMode: _conferenceRoomMode,
|
||||
...props
|
||||
}: SelectedAgentChatProps) {
|
||||
return <AssistantChat {...props} targetAgentId={defaultTargetAgentId} />;
|
||||
}
|
||||
|
||||
export function SelectedAgentChatView({
|
||||
conferenceRoomMode: _conferenceRoomMode,
|
||||
...props
|
||||
}: SelectedAgentChatViewProps) {
|
||||
return <AssistantChatView {...props} />;
|
||||
}
|
||||
+7
-7
@@ -2,7 +2,7 @@ import { useState } from "react";
|
||||
import type { Meta, StoryObj } from "@storybook/react-vite";
|
||||
import type { Agent, IssueComment } from "@paperclipai/shared";
|
||||
import type { ActiveRunForIssue, LiveRunForIssue } from "@/api/heartbeats";
|
||||
import { SelectedAgentChatView } from "@/components/SelectedAgentChat";
|
||||
import { AssistantChatView } from "@/components/AssistantChat";
|
||||
import type { IssueChatComment } from "@/lib/issue-chat-messages";
|
||||
import { pendingSuggestedTasksInteraction } from "@/fixtures/issueThreadInteractionFixtures";
|
||||
import { storybookAgents } from "../fixtures/paperclipData";
|
||||
@@ -104,12 +104,12 @@ function Frame({ children }: { children: React.ReactNode }) {
|
||||
|
||||
/** Stateful wrapper so the agent switcher is interactive in the canvas. */
|
||||
function ChatHarness(
|
||||
props: Omit<React.ComponentProps<typeof SelectedAgentChatView>, "targetAgentId" | "onTargetAgentChange">,
|
||||
props: Omit<React.ComponentProps<typeof AssistantChatView>, "targetAgentId" | "onTargetAgentChange">,
|
||||
) {
|
||||
const [targetAgentId, setTargetAgentId] = useState<string>(ceoAgent.id);
|
||||
return (
|
||||
<Frame>
|
||||
<SelectedAgentChatView
|
||||
<AssistantChatView
|
||||
{...props}
|
||||
targetAgentId={targetAgentId}
|
||||
onTargetAgentChange={setTargetAgentId}
|
||||
@@ -125,15 +125,15 @@ const baseProps = {
|
||||
issueId,
|
||||
currentUserId,
|
||||
onSend: async () => {},
|
||||
} satisfies Partial<React.ComponentProps<typeof SelectedAgentChatView>>;
|
||||
} satisfies Partial<React.ComponentProps<typeof AssistantChatView>>;
|
||||
|
||||
const meta: Meta<typeof SelectedAgentChatView> = {
|
||||
title: "Chat & Comments/Selected-Agent Chat",
|
||||
const meta: Meta<typeof AssistantChatView> = {
|
||||
title: "Chat & Comments/Assistant Chat",
|
||||
parameters: { layout: "fullscreen" },
|
||||
};
|
||||
export default meta;
|
||||
|
||||
type Story = StoryObj<typeof SelectedAgentChatView>;
|
||||
type Story = StoryObj<typeof AssistantChatView>;
|
||||
|
||||
/** Empty / idle — composer ready, default CEO target, switcher available. */
|
||||
export const EmptyIdle: Story = {
|
||||
Reference in new issue
Block a user