mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-11-04 19:28:46 +01:00
## Thinking Path
> - Paperclip is the open source app people use to manage AI agents for
work.
> - Task indicators tell an operator whether work is active, waiting, or
complete.
> - An agent can yield until a saved monitor checks CI or another
external result.
> - The task currently keeps the In Progress icon between those runs.
> - Changing the stored status would affect monitor admission and
recovery.
> - This pull request adds a read-only Monitoring display state with a
blue clock.
> - Operators can see and filter scheduled waits while execution keeps
its existing rules.
## Linked Issues or Issue Description
**What existing behavior does this improve?**
Task status indicators, task collection filters, board columns, and
search facets.
**Current behavior**
A task that waits for a scheduled monitor shows the same In Progress
icon as active work.
**Proposed behavior**
Show Monitoring with a static blue clock when an agent-owned task has a
saved ordinary monitor and no active run, execution lock, review
participant, or active recovery action. Return to the normal task
indicator when the check starts. Preserve review, blocked, terminal, and
quota-recovery states.
**Reason and benefit**
Operators can distinguish scheduled waits from current agent work
without reading the task history.
**Breaking changes**
None to stored task statuses or execution rules. Task reads gain
optional displayStatus. Collections and search gain a separate read
filter. Existing status filters keep their lifecycle meaning.
Related historical work: #4396 covered a monitoring label exemption.
This change uses the saved monitor and a read projection.
## What Changed
- Add one SQL projection for task detail, compact lists, summaries,
relations, search results, and display-status counts.
- Show the blue clock in shared task icons and chips, task detail and
breadcrumbs, properties, references, list rows, recent navigation, and
agent task cards.
- Add Monitoring to task filtering, grouping, sorting, board columns,
and search facets. Prevent a drag from creating this derived state.
- Keep stored lifecycle statuses, monitor scheduling, checkout,
recovery, permissions, and agent status filters unchanged.
- Add database and UI regression coverage, full-page Storybook examples,
and product and access-map documentation.
## Verification
- Passed `pnpm -r typecheck`.
- Passed `pnpm build`.
- Passed `pnpm check:token-gates` and the map/catalog structural checks.
- Ran the new database suite on a disposable PostgreSQL 17 database. It
covers read surfaces, filter pagination/counts, queued/running checks,
rescheduling, completion, retained monitors, review, and recovery holds.
- Ran existing search, list, board, sidebar, task status, and filter
tests. Corrected board queries use displayStatus and eight columns.
- The full local `pnpm test:run` stopped in a chat integration shard: 12
failures (four timeouts and eight FIFO publication assertions). That run
spanned a rebase. A focused rerun on the current source passed all 21
selected cases without assertion or timeout changes. The original cause
is not established; this does not claim the full local suite passed.
Final-head required CI passed (ci / verify and ci / e2e, run
41488267209).
- Passed 82 tests for task API summaries, recovery precedence, search,
and optimistic updates; 54 tests for status cards, database reads, and
board moves; and 27 tests for blocker relations and recent-task cache
updates. One intermediate database setup hit its 20-second hook timeout;
the serial rerun passed.
- Greptile is 5/5 on d003ea672d. All
review threads are resolved. The separate optional Paperclip Review
ended early and returned neutral; GitHub rejected a direct rerun request
with HTTP 404. It is not counted as a completed review.
- Review fixes cover escalated recovery, is:open, optimistic status
changes, blocker-summary projection, and recent-task dedupe.
- Reviewed 15 screenshots from production pages and components with
isolated Storybook API fixtures: task detail/properties/breadcrumb,
list, groups, status filter, board, search/results/filter counts,
reference pills, sibling navigation, agent cards, picker, dashboard,
inbox, profile, watched status-card tasks, light theme, and mobile. This
does not claim deployed staging verification.
## Risks
- Read projections must stay consistent across full, compact, summary,
and search responses. Tests cover those paths.
- Monitoring is not a writable lifecycle status. The board does not
accept drops into its Monitoring lane or onto a monitored card. This
prevents a drag from implying a scheduled check. Move work into In
Progress through that lane instead.
- The read projection adds run/recovery existence checks. Existing
heartbeat_runs_company_issue_created_idx and
issue_recovery_actions_company_source_status_idx indexes cover the
company/task lookup. It adds no worker, timer, recurring query,
migration, or provider call. No production load benchmark is claimed.
- Older clients can ignore displayStatus. Existing lifecycle status
filters keep their behavior.
## Model Used
OpenAI Codex, GPT-6, with reasoning, repository tools, code execution,
and browser tools. The exact backend model identifier and context-window
size are not exposed in this session.
## Checklist
- [x] I have included a thinking path that traces from project context
to this change
- [x] I have specified the model used (with version and capability
details)
- [x] I have checked ROADMAP.md and confirmed this PR does not duplicate
planned core work
- [x] I have searched GitHub for duplicate or related PRs and linked
them above
- [x] I have either (a) linked existing issues with `Fixes: #` / `Closes
#` / `Refs #` OR (b) described the issue in-PR following the relevant
issue template
- [x] I have not referenced internal/instance-local Paperclip issues or
links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip`
URLs)
- [x] My branch name describes the change (e.g. `docs/...`, `fix/...`)
and contains no internal Paperclip ticket id or instance-derived details
- [x] I have run tests locally and they pass
- [x] I have added or updated tests where applicable
- [x] I have updated relevant documentation to reflect my changes
- [x] I have considered and documented any risks above
- [x] All Paperclip CI gates are green
- [x] Greptile is 5/5 with no open P2s, recommendations, or follow-ups
- [x] I will address all Greptile and reviewer comments before
requesting merge
---------
Co-authored-by: Paperclip <noreply@paperclip.ing>
351 lines
14 KiB
TypeScript
351 lines
14 KiB
TypeScript
import { useState, type FormEvent } from "react";
|
|
import { useQueryClient } from "@tanstack/react-query";
|
|
import { Archive, MoreHorizontal, Pencil, RefreshCw } from "lucide-react";
|
|
import { agentsApi } from "@/api/agents";
|
|
import { issuesApi } from "@/api/issues";
|
|
import { queryKeys } from "@/lib/queryKeys";
|
|
import { useRecentTasks } from "@/hooks/useRecentTasks";
|
|
import { useAccountIdentity } from "@/api/companies-query";
|
|
import { useSidebar } from "@/context/SidebarContext";
|
|
import { useOptionalToastActions } from "@/context/ToastContext";
|
|
import {
|
|
updateRecentTaskSnapshots,
|
|
type RecentTaskEntry,
|
|
} from "@/lib/recent-tasks";
|
|
import { Button } from "@/components/ui/button";
|
|
import {
|
|
Dialog,
|
|
DialogContent,
|
|
DialogDescription,
|
|
DialogFooter,
|
|
DialogHeader,
|
|
DialogTitle,
|
|
} from "@/components/ui/dialog";
|
|
import {
|
|
DropdownMenu,
|
|
DropdownMenuContent,
|
|
DropdownMenuItem,
|
|
DropdownMenuTrigger,
|
|
} from "@/components/ui/dropdown-menu";
|
|
import { Input } from "@/components/ui/input";
|
|
import { StatusIcon } from "./StatusIcon";
|
|
import { SidebarSection } from "./SidebarSection";
|
|
import { SidebarNavItem } from "./SidebarNavItem";
|
|
|
|
const RECENT_TASK_MENU_ITEM_CLASS =
|
|
"h-(--profile-popover-row-height) gap-(--profile-popover-row-gap) rounded-lg px-2.5 py-0 text-(length:--text-compact) font-medium leading-(--profile-popover-label-line-height) focus:bg-accent/50 focus:text-foreground";
|
|
const RESTART_WAKE_RETRY_STORAGE_SUFFIX = ":restart-wake-retry";
|
|
|
|
function restartWakeRetryStorageKey(companyId: string, userId: string | null) {
|
|
// Action retry state must survive changes to the recent-task snapshot format.
|
|
return `paperclip.recentTasks:${companyId}:${userId ?? "__local_board__"}${RESTART_WAKE_RETRY_STORAGE_SUFFIX}`;
|
|
}
|
|
|
|
function readRestartWakeRetryIssueIds(storageKey: string | null) {
|
|
if (!storageKey) return new Set<string>();
|
|
try {
|
|
const parsed = JSON.parse(window.localStorage.getItem(storageKey) ?? "[]") as unknown;
|
|
return new Set(Array.isArray(parsed) ? parsed.filter((value): value is string => typeof value === "string") : []);
|
|
} catch {
|
|
return new Set<string>();
|
|
}
|
|
}
|
|
|
|
function setRestartWakeRetryPending(storageKey: string | null, issueId: string, pending: boolean) {
|
|
if (!storageKey) return;
|
|
const issueIds = readRestartWakeRetryIssueIds(storageKey);
|
|
if (pending) issueIds.add(issueId);
|
|
else issueIds.delete(issueId);
|
|
try {
|
|
if (issueIds.size > 0) window.localStorage.setItem(storageKey, JSON.stringify([...issueIds]));
|
|
else window.localStorage.removeItem(storageKey);
|
|
} catch {
|
|
// Recent Tasks remains usable when browser storage is unavailable.
|
|
}
|
|
}
|
|
|
|
function errorMessage(error: unknown, fallback: string) {
|
|
return error instanceof Error && error.message.trim() ? error.message : fallback;
|
|
}
|
|
|
|
export function SidebarRecentTasks({
|
|
companyId,
|
|
liveIssueIds,
|
|
}: {
|
|
companyId: string | null | undefined;
|
|
liveIssueIds: ReadonlySet<string>;
|
|
}) {
|
|
const { collapsed, peeking } = useSidebar();
|
|
const rail = collapsed && !peeking;
|
|
const { userId, settled } = useAccountIdentity();
|
|
|
|
if (!companyId || !settled) return null;
|
|
|
|
return (
|
|
<RecentTasksList
|
|
key={`${companyId}:${userId ?? "__local_board__"}`}
|
|
companyId={companyId}
|
|
userId={userId}
|
|
liveIssueIds={liveIssueIds}
|
|
rail={rail}
|
|
/>
|
|
);
|
|
}
|
|
|
|
function RecentTasksList({
|
|
companyId,
|
|
userId,
|
|
liveIssueIds,
|
|
rail,
|
|
}: {
|
|
companyId: string;
|
|
userId: string | null;
|
|
liveIssueIds: ReadonlySet<string>;
|
|
rail: boolean;
|
|
}) {
|
|
const { entries, storageKey } = useRecentTasks({ companyId, userId });
|
|
const queryClient = useQueryClient();
|
|
const toastActions = useOptionalToastActions();
|
|
const [renameEntry, setRenameEntry] = useState<RecentTaskEntry | null>(null);
|
|
const [renameValue, setRenameValue] = useState("");
|
|
const [pendingAction, setPendingAction] = useState<"rename" | "archive" | "pause" | null>(null);
|
|
const restartRetryStorageKey = restartWakeRetryStorageKey(companyId, userId);
|
|
|
|
if (entries.length === 0) return null;
|
|
|
|
const refreshIssueQueries = async (issueId: string) => {
|
|
await Promise.all([
|
|
queryClient.invalidateQueries({ queryKey: queryKeys.issues.detail(issueId) }),
|
|
queryClient.invalidateQueries({ queryKey: queryKeys.issues.list(companyId) }),
|
|
queryClient.invalidateQueries({ queryKey: queryKeys.issues.activity(issueId) }),
|
|
]);
|
|
};
|
|
|
|
const beginRename = (entry: RecentTaskEntry) => {
|
|
setRenameEntry(entry);
|
|
setRenameValue(entry.title);
|
|
};
|
|
|
|
const submitRename = async (event: FormEvent<HTMLFormElement>) => {
|
|
event.preventDefault();
|
|
const nextTitle = renameValue.trim();
|
|
if (!renameEntry || !nextTitle || nextTitle === renameEntry.title) {
|
|
setRenameEntry(null);
|
|
return;
|
|
}
|
|
|
|
setPendingAction("rename");
|
|
try {
|
|
const updated = await issuesApi.update(renameEntry.id, { title: nextTitle });
|
|
queryClient.setQueryData(queryKeys.issues.detail(renameEntry.id), updated);
|
|
if (storageKey) updateRecentTaskSnapshots(storageKey, companyId, [updated]);
|
|
await refreshIssueQueries(renameEntry.id);
|
|
setRenameEntry(null);
|
|
toastActions?.pushToast({ title: "Task renamed", tone: "success" });
|
|
} catch (error) {
|
|
toastActions?.pushToast({
|
|
title: "Task rename failed",
|
|
body: errorMessage(error, "Unable to rename this task."),
|
|
tone: "error",
|
|
});
|
|
} finally {
|
|
setPendingAction(null);
|
|
}
|
|
};
|
|
|
|
const archiveTask = async (entry: RecentTaskEntry) => {
|
|
setPendingAction("archive");
|
|
try {
|
|
await issuesApi.archiveFromInbox(entry.id);
|
|
await refreshIssueQueries(entry.id);
|
|
await queryClient.invalidateQueries({
|
|
queryKey: queryKeys.sidebarBadges(companyId),
|
|
});
|
|
toastActions?.pushToast({ title: "Task archived from inbox", tone: "success" });
|
|
} catch (error) {
|
|
toastActions?.pushToast({
|
|
title: "Task archive failed",
|
|
body: errorMessage(error, "Unable to archive this task from the inbox."),
|
|
tone: "error",
|
|
});
|
|
} finally {
|
|
setPendingAction(null);
|
|
}
|
|
};
|
|
|
|
const toggleTaskPause = async (entry: RecentTaskEntry) => {
|
|
setPendingAction("pause");
|
|
try {
|
|
const state = await issuesApi.getTreeControlState(entry.id);
|
|
if (state.activePauseHold?.isRoot) {
|
|
const restartIssue = await issuesApi.get(entry.id);
|
|
setRestartWakeRetryPending(restartRetryStorageKey, entry.id, true);
|
|
await issuesApi.releaseTreeHold(entry.id, state.activePauseHold.holdId, {
|
|
reason: "Restarted from Recent Tasks.",
|
|
});
|
|
if (restartIssue.assigneeAgentId) {
|
|
const wakeResult = await agentsApi.wakeup(
|
|
restartIssue.assigneeAgentId,
|
|
{
|
|
source: "assignment",
|
|
triggerDetail: "manual",
|
|
reason: "recent_task_restart",
|
|
payload: { issueId: restartIssue.id },
|
|
},
|
|
restartIssue.companyId,
|
|
);
|
|
if (!("id" in wakeResult)) {
|
|
throw new Error(wakeResult.message ?? "The assignee wake was skipped.");
|
|
}
|
|
}
|
|
setRestartWakeRetryPending(restartRetryStorageKey, entry.id, false);
|
|
toastActions?.pushToast({ title: "Task restarted", tone: "success" });
|
|
} else if (state.activePauseHold) {
|
|
throw new Error("This task is paused by a parent task. Restart it from the pause root.");
|
|
} else if (readRestartWakeRetryIssueIds(restartRetryStorageKey).has(entry.id)) {
|
|
const restartIssue = await issuesApi.get(entry.id);
|
|
if (restartIssue.assigneeAgentId) {
|
|
const wakeResult = await agentsApi.wakeup(
|
|
restartIssue.assigneeAgentId,
|
|
{
|
|
source: "assignment",
|
|
triggerDetail: "manual",
|
|
reason: "recent_task_restart_retry",
|
|
payload: { issueId: restartIssue.id },
|
|
},
|
|
restartIssue.companyId,
|
|
);
|
|
if (!("id" in wakeResult)) {
|
|
throw new Error(wakeResult.message ?? "The assignee wake was skipped.");
|
|
}
|
|
}
|
|
setRestartWakeRetryPending(restartRetryStorageKey, entry.id, false);
|
|
toastActions?.pushToast({ title: "Task restarted", tone: "success" });
|
|
} else {
|
|
await issuesApi.createTreeHold(entry.id, {
|
|
mode: "pause",
|
|
reason: "Paused from Recent Tasks.",
|
|
releasePolicy: { strategy: "manual" },
|
|
});
|
|
toastActions?.pushToast({ title: "Task paused", tone: "success" });
|
|
}
|
|
await queryClient.invalidateQueries({
|
|
queryKey: ["issues", "tree-control-state", entry.id],
|
|
});
|
|
await queryClient.invalidateQueries({ queryKey: queryKeys.issues.summaries(companyId) });
|
|
} catch (error) {
|
|
toastActions?.pushToast({
|
|
title: "Task pause update failed",
|
|
body: errorMessage(error, "Unable to pause or restart this task."),
|
|
tone: "error",
|
|
});
|
|
} finally {
|
|
setPendingAction(null);
|
|
}
|
|
};
|
|
|
|
return (
|
|
<>
|
|
<SidebarSection label="Recent Tasks">
|
|
{entries.map((entry) => (
|
|
<div key={entry.id} className="sidebar-action-row group/recent-task relative">
|
|
<SidebarNavItem
|
|
to={`/issues/${entry.id}`}
|
|
label={entry.title}
|
|
iconNode={entry.displayStatus === "monitoring" && !liveIssueIds.has(entry.id) ? <StatusIcon status={entry.status} displayStatus={entry.displayStatus} /> : undefined}
|
|
trailing={entry.status === "in_review" && entry.externalConversationState === "waiting"
|
|
? <span className="text-xs text-muted-foreground">Idle</span> : undefined}
|
|
trailingLabel={entry.status === "in_review" && entry.externalConversationState === "waiting" ? "Idle" : undefined}
|
|
className={rail ? undefined : "sidebar-action-link pointer-coarse:pr-8"}
|
|
liveCount={liveIssueIds.has(entry.id) ? 1 : undefined}
|
|
/>
|
|
{!rail ? (
|
|
<DropdownMenu>
|
|
<DropdownMenuTrigger asChild>
|
|
<Button
|
|
type="button"
|
|
variant="ghost"
|
|
size="icon-xs"
|
|
aria-label={`More actions for ${entry.title}`}
|
|
className="sidebar-action-menu absolute right-2 top-(--pct-50) z-10 -translate-y-(--pct-50) text-muted-foreground pointer-events-none opacity-0 transition-opacity hover:bg-sidebar-accent dark:hover:bg-sidebar-accent hover:text-foreground focus-visible:pointer-events-auto focus-visible:opacity-100 pointer-coarse:pointer-events-auto pointer-coarse:opacity-100 pointer-coarse:before:hidden group-hover/recent-task:pointer-events-auto group-hover/recent-task:opacity-100 group-focus-within/recent-task:pointer-events-auto group-focus-within/recent-task:opacity-100 data-[state=open]:pointer-events-auto data-[state=open]:bg-sidebar-accent data-[state=open]:text-foreground data-[state=open]:opacity-100"
|
|
>
|
|
<MoreHorizontal aria-hidden="true" />
|
|
</Button>
|
|
</DropdownMenuTrigger>
|
|
<DropdownMenuContent
|
|
side="right"
|
|
align="start"
|
|
className="w-(--profile-popover-width) rounded-xl p-1.5 shadow-(--shadow-profile-popover)"
|
|
>
|
|
<DropdownMenuItem
|
|
className={RECENT_TASK_MENU_ITEM_CLASS}
|
|
onSelect={() => beginRename(entry)}
|
|
>
|
|
<Pencil aria-hidden="true" />
|
|
Rename
|
|
</DropdownMenuItem>
|
|
<DropdownMenuItem
|
|
className={RECENT_TASK_MENU_ITEM_CLASS}
|
|
disabled={pendingAction !== null}
|
|
onSelect={() => void archiveTask(entry)}
|
|
>
|
|
<Archive aria-hidden="true" />
|
|
Archive
|
|
</DropdownMenuItem>
|
|
<DropdownMenuItem
|
|
className={RECENT_TASK_MENU_ITEM_CLASS}
|
|
disabled={pendingAction !== null}
|
|
onSelect={() => void toggleTaskPause(entry)}
|
|
>
|
|
<RefreshCw aria-hidden="true" />
|
|
Pause/Restart
|
|
</DropdownMenuItem>
|
|
</DropdownMenuContent>
|
|
</DropdownMenu>
|
|
) : null}
|
|
</div>
|
|
))}
|
|
</SidebarSection>
|
|
|
|
<Dialog
|
|
open={renameEntry !== null}
|
|
onOpenChange={(open) => {
|
|
if (!open && pendingAction !== "rename") setRenameEntry(null);
|
|
}}
|
|
>
|
|
<DialogContent className="sm:max-w-md">
|
|
<form className="grid gap-4" onSubmit={(event) => void submitRename(event)}>
|
|
<DialogHeader>
|
|
<DialogTitle>Rename task</DialogTitle>
|
|
<DialogDescription>Choose a short, clear name for this task.</DialogDescription>
|
|
</DialogHeader>
|
|
<Input
|
|
autoFocus
|
|
aria-label="Task name"
|
|
value={renameValue}
|
|
disabled={pendingAction === "rename"}
|
|
onChange={(event) => setRenameValue(event.target.value)}
|
|
/>
|
|
<DialogFooter>
|
|
<Button
|
|
type="button"
|
|
variant="outline"
|
|
disabled={pendingAction === "rename"}
|
|
onClick={() => setRenameEntry(null)}
|
|
>
|
|
Cancel
|
|
</Button>
|
|
<Button
|
|
type="submit"
|
|
disabled={pendingAction === "rename" || !renameValue.trim()}
|
|
>
|
|
{pendingAction === "rename" ? "Saving..." : "Save"}
|
|
</Button>
|
|
</DialogFooter>
|
|
</form>
|
|
</DialogContent>
|
|
</Dialog>
|
|
</>
|
|
);
|
|
}
|