mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-11-18 14:35:55 +01:00
## Thinking Path > - Paperclip helps people manage AI agents and their work. > - The inbox collects decisions, requests, and updates for the people in a company. > - People need a clear personal queue and a consistent way to answer each request. > - Repeated headings, inconsistent card actions, and separate review flows make that work harder. > - This pull request connects the inbox UI to the routing foundation in #20959. > - Compact cards use shared task controls and open supporting work in a side panel. > - People can answer, claim, transfer, archive, and inspect outcomes from one place. ## Linked Issues or Issue Description **What existing behavior does this improve?** The inbox cards, personal views, shared task controls, and decision history. **Subsystem affected** UI. This PR targets master and uses the routing foundation merged in #20959. **Current behavior** The inbox repeats headings and counts. Cards have different layouts and action placement. The requester can repeat the signed-in person's name. Review and question controls differ between the inbox and task thread. **Proposed behavior** Open Assigned to you by default. Show one count line above the cards. Use a compact card layout with consistent actions and supporting details. Show the requester's avatar and name only when they differ from the signed-in person. Share question controls, including a radio option for Other that reveals a text field when selected. **Reason and benefit** People can scan their queue and complete requests without losing the surrounding task or creating separate drafts for the same review. **Breaking changes** The default inbox view becomes personal. The all-assignee and shared views remain available. Card close menus distinguish personal archive and snooze from shared withdrawal. **Additional context** Refs #20959, #19363, and #19520. Refs #20268 for related actionable-request work. This stack adds personal routing and shared controls. ROADMAP.md includes Multiple Human Users and Agent Reviews and Approvals. ## What Changed - Add personal, unassigned, company, all-assignee, and archived inbox views. Add claim, transfer, personal close actions, receipts, and history controls. - Use compact decision cards with a single count line, one-pixel borders, and equal space above, below, and to the right of each primary action. - Open artifacts and synchronized confirmation/approval controls in a shared side panel. Share their revision drafts and action state with the task thread. Other requests keep one editable form on the inbox card while reviewing an artifact. - Make Other match the question options and reveal its field only when selected. Apply this to inbox and task question cards. - Hide self-requester labels, space agent avatars, and use the standard canceled status icon for withdrawn requests. - Use connector logos in connector cards. Keep the connector promotion background and sidebar border continuous. - Add company and project decision-owner controls and document the updated inbox behavior. ## Verification - The complete [GitHub Actions CI matrix](https://github.com/paperclipai/paperclip/actions/runs/43141559641) passes on `8d81a75e49b518fff6b6ff4c23dd67979b0b97ee` (Linux/Node 24: typecheck, build, general and serialized tests, Runner support, browser shards, and aggregate gates). Greptile is 5/5 on that exact head with zero open findings, and the security scan passes. - Local UI typechecking passes. Eight focused suites pass 382 tests: 236 inbox/review/question/connector tests plus all 146 composer tests. Regressions passed red to green for attachment links, prompt rendering, single-form artifact review, connector scope copy, accessible headings, and the composer test harness's missing theme provider. The final commit changes only that test harness; production code is unchanged from `59d015833f`. - Browser acceptance on the production implementation confirms preserved selected answers with one editable question form, accessible Markdown prompts, inert image references, accurate connector scope copy, native PDF downloads, image sidebar previews, and Open file requesting the attachment endpoint while preserving the inbox URL. Request reads and file responses were intercepted; no question answers were written. The preview is healthy on the final head. - Visual and interaction checks cover Other radio behavior in both themes and on mobile, the loaded Google Calendar logo, and 20px above, below, and to the right of the primary action across all 23 visible cards. The affected desktop/mobile navigation and sidebar specs pass locally and in the final CI browser matrix. - Real-editor browser checks confirm Ctrl/Cmd+Enter cannot bypass another person's confirmation. Cancel preserves the draft and unlocks silently; Continue submits once. Approval write failures remain visible. - `pnpm verify` returns exit 2 because DESIGN.md requires broader coverage; the final full CI matrix supplies every requested gate. Maps and Storybook catalog structural checks pass. The routing foundation #20959 merged after passing 249 database tests, server typechecking, full CI, Greptile 5/5, and security scanning. Its backend and SDK registry are preserved. - Demo data is retained for testing; database suites and browser specs use separate disposable databases. ## Risks - The inbox uses the routing contracts merged in #20959. Personal filters and history affect shared task entry points; the affected controls are included in local regression coverage and full CI. - Personal defaults and close-menu wording change inbox behavior. Existing resolver permissions still control shared actions. - Shared revision state and live invalidation affect two surfaces. Focused tests cover draft synchronization, action locks, and incoming updates. - Visual changes use the existing design tokens and component primitives. ## Model Used OpenAI GPT-6 through Codex. Used repository tools, code execution, and browser checks. This session does not expose a more specific runtime model ID or its context-window size. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have described the issue in-PR following the relevant issue template - [x] I have not referenced internal/instance-local Paperclip issues or links - [x] My branch name describes the change and contains no internal Paperclip ticket id - [x] I have run focused tests locally and they pass - [x] I have added or updated tests where applicable - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] All Paperclip CI gates are green - [x] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I will address all Greptile and reviewer comments before requesting merge --------- Co-authored-by: Scott Tong <scott@scottsmbpm5max.lan> Co-authored-by: Paperclip <noreply@paperclip.ing>
168 lines
12 KiB
TypeScript
168 lines
12 KiB
TypeScript
import { describe, expect, it } from "vitest";
|
|
import type { AttentionAudience, AttentionItem, AttentionReceipt, AttentionSourceKind } from "@paperclipai/shared";
|
|
import {
|
|
ATTENTION_COMPANY_AUDIENCE_TEXT,
|
|
ATTENTION_POOL_AUDIENCE_TEXT,
|
|
attentionAudienceLineNamesResponders,
|
|
attentionClaimAlternative,
|
|
attentionEveryoneViewAllowed,
|
|
attentionItemClaimable,
|
|
attentionReceiptLine,
|
|
attentionResponderText,
|
|
attentionUnownedAudienceText,
|
|
attentionViewsFor,
|
|
describeAttentionAudience,
|
|
parseAttentionView,
|
|
unassignedBannerText,
|
|
} from "./attention-views";
|
|
import { coordinatorAttentionQueryKey } from "./coordinator-attention";
|
|
|
|
function item(audience: AttentionAudience, sourceKind: AttentionSourceKind = "issue_thread_interaction") {
|
|
return { id: "card", sourceKind, audience, subject: { id: "card" } } as unknown as AttentionItem;
|
|
}
|
|
|
|
describe("attention views (PAP-749 task 1b)", () => {
|
|
it("defaults to For you and keeps only the three known views", () => {
|
|
expect(parseAttentionView(null)).toBe("mine");
|
|
expect(parseAttentionView("all")).toBe("mine");
|
|
expect(parseAttentionView("bogus")).toBe("mine");
|
|
expect(parseAttentionView("unassigned")).toBe("unassigned");
|
|
expect(parseAttentionView("company")).toBe("company");
|
|
});
|
|
|
|
it("opens Everyone only for a board member (PAP-768)", () => {
|
|
expect(parseAttentionView("all", { everyone: true })).toBe("all");
|
|
expect(parseAttentionView("all", { everyone: false })).toBe("mine");
|
|
expect(attentionViewsFor(false)).toEqual(["mine", "unassigned", "company", "archived"]);
|
|
expect(attentionViewsFor(true)).toEqual(["mine", "unassigned", "company", "archived", "all"]);
|
|
});
|
|
|
|
it("treats owners, admins, operators and legacy members as board members, not viewers (PAP-768)", () => {
|
|
const member = (membershipRole: "owner" | "admin" | "operator" | "viewer" | "member" | null, status: "active" | "suspended" = "active") =>
|
|
({ source: "session", isInstanceAdmin: false, memberships: [{ companyId: "c1", membershipRole, status }] });
|
|
for (const role of ["owner", "admin", "operator", "member"] as const) {
|
|
expect(attentionEveryoneViewAllowed("c1", member(role))).toBe(true);
|
|
}
|
|
expect(attentionEveryoneViewAllowed("c1", member("viewer"))).toBe(false);
|
|
expect(attentionEveryoneViewAllowed("c1", member(null))).toBe(false);
|
|
expect(attentionEveryoneViewAllowed("c1", member("owner", "suspended"))).toBe(false);
|
|
expect(attentionEveryoneViewAllowed("c2", member("owner"))).toBe(false);
|
|
expect(attentionEveryoneViewAllowed("c1", { source: "local_implicit", isInstanceAdmin: false, memberships: [] })).toBe(true);
|
|
expect(attentionEveryoneViewAllowed("c1", { source: "session", isInstanceAdmin: true, memberships: [] })).toBe(true);
|
|
expect(attentionEveryoneViewAllowed("c1", undefined)).toBe(false);
|
|
expect(attentionEveryoneViewAllowed(null, member("owner"))).toBe(false);
|
|
});
|
|
|
|
it("keys each list by company, person and view", () => {
|
|
expect(coordinatorAttentionQueryKey("c1", "scott", "mine")).not.toEqual(coordinatorAttentionQueryKey("c1", "dotta", "mine"));
|
|
expect(coordinatorAttentionQueryKey("c1", "scott", "mine")).not.toEqual(coordinatorAttentionQueryKey("c1", "scott", "unassigned"));
|
|
expect(coordinatorAttentionQueryKey("c1", "scott", "mine").slice(0, 4)).toEqual(["attention", "c1", "scott", "mine"]);
|
|
});
|
|
|
|
it("answers Why me? for your own card from the audience reason", () => {
|
|
expect(describeAttentionAudience(item({ kind: "user", userId: "scott", reason: "addressee" }), "scott"))
|
|
.toEqual({ kind: "mine", text: "Sent to you" });
|
|
expect(describeAttentionAudience(item({ kind: "user", userId: "scott", reason: "reviewer" }), "scott"))
|
|
.toEqual({ kind: "mine", text: "You are the reviewer" });
|
|
expect(describeAttentionAudience(item({ kind: "user", userId: "scott", reason: "instigator" }), "scott"))
|
|
.toEqual({ kind: "mine", text: "You created the original task" });
|
|
expect(describeAttentionAudience(item({ kind: "user", userId: "scott", reason: "escalation_owner" }), "scott"))
|
|
.toEqual({ kind: "mine", text: "You are the default decision owner" });
|
|
});
|
|
|
|
it("names the project and budget escalation owners (PAP-749 task 1d)", () => {
|
|
expect(describeAttentionAudience(item({ kind: "user", userId: "riley", reason: "project_owner" }), "riley"))
|
|
.toEqual({ kind: "mine", text: "You own this project's decisions" });
|
|
const budgetStop = item({ kind: "user", userId: "scott", reason: "budget_owner", alsoInCompany: true }, "budget_alert");
|
|
expect(describeAttentionAudience(budgetStop, "scott")).toEqual({ kind: "mine", text: "You own budget escalation" });
|
|
// Company still shows the hard stop to everyone else, as "For @scott".
|
|
expect(describeAttentionAudience(budgetStop, "dotta")).toEqual({ kind: "other", userId: "scott" });
|
|
expect(attentionItemClaimable(budgetStop)).toBe(false);
|
|
});
|
|
|
|
it("names the other person on a card that is not yours", () => {
|
|
expect(describeAttentionAudience(item({ kind: "user", userId: "dotta", reason: "addressee" }), "scott"))
|
|
.toEqual({ kind: "other", userId: "dotta" });
|
|
});
|
|
|
|
it("says why an ownerless card is answerable and offers Claim only where an addressee can be stored", () => {
|
|
expect(describeAttentionAudience(item({ kind: "pool", userId: null, reason: "none" }), "scott"))
|
|
.toEqual({ kind: "pool", text: ATTENTION_POOL_AUDIENCE_TEXT, claimable: true });
|
|
expect(describeAttentionAudience(item({ kind: "pool", userId: null, reason: "none" }, "decision"), "scott"))
|
|
.toEqual({ kind: "pool", text: ATTENTION_POOL_AUDIENCE_TEXT, claimable: false });
|
|
// An ownerless interaction that moved to Company after 7 days can still be claimed.
|
|
expect(describeAttentionAudience(item({ kind: "company", userId: null, reason: "none" }), "scott"))
|
|
.toEqual({ kind: "company", text: ATTENTION_COMPANY_AUDIENCE_TEXT, claimable: true });
|
|
expect(attentionItemClaimable(item({ kind: "company", userId: null, reason: "none" }, "failed_run"))).toBe(false);
|
|
expect(attentionItemClaimable(item({ kind: "user", userId: "dotta", reason: "addressee" }))).toBe(false);
|
|
});
|
|
|
|
it("says \"Transferred by\" on a card routed to you (PAP-749 plan §6)", () => {
|
|
expect(describeAttentionAudience(item({ kind: "user", userId: "riley", reason: "addressee", transferredByUserId: "scott" }), "riley"))
|
|
.toEqual({ kind: "mine", text: "Transferred by", transferredByUserId: "scott" });
|
|
});
|
|
|
|
it("phrases receipts with display names, never IDs", () => {
|
|
const labels = new Map([["scott", "Scott"], ["riley", "Riley"]]);
|
|
const receipt = (outcome: AttentionReceipt["outcome"], transferredToUserId: string | null = null) =>
|
|
({ outcome, actorUserId: "scott", transferredToUserId }) as AttentionReceipt;
|
|
expect(attentionReceiptLine(receipt("answered"), labels)).toBe("Answered by @Scott");
|
|
expect(attentionReceiptLine(receipt("withdrawn"), labels)).toBe("Withdrawn by @Scott");
|
|
expect(attentionReceiptLine(receipt("transferred", "riley"), labels)).toBe("Transferred to @Riley by @Scott");
|
|
expect(attentionReceiptLine(receipt("approved"), null)).toBe("Approved by @someone");
|
|
});
|
|
|
|
it("says who may answer in the same statement as why the card is here (PAP-767)", () => {
|
|
const resolver = (overrides: Partial<NonNullable<AttentionItem["resolverAudience"]>> = {}) => ({
|
|
requestedResolverPolicy: "anyone", effectiveResolverPolicy: "anyone", effectiveResolverPolicySource: "requested",
|
|
resolverPolicyProvenance: "inherited", addresseeAgentId: null, addresseeUserId: null, addresseeName: null,
|
|
createdByAgentId: "agent-1", createdByAgentName: "Watchdog", ...overrides,
|
|
}) as NonNullable<AttentionItem["resolverAudience"]>;
|
|
const card = (audience: AttentionAudience, resolverAudience: AttentionItem["resolverAudience"]) =>
|
|
({ ...item(audience), resolverAudience }) as AttentionItem;
|
|
const describe_ = (entry: AttentionItem, viewer: string) => describeAttentionAudience(entry, viewer)!;
|
|
|
|
// NEE-15: the project owner's card is open to anyone, so others may answer it too.
|
|
const owned = card({ kind: "user", userId: "dotta", reason: "project_owner" }, resolver());
|
|
expect(attentionResponderText(owned, describe_(owned, "dotta"))).toBe("Anyone else can answer it too.");
|
|
const sent = card({ kind: "user", userId: "dotta", reason: "addressee" }, resolver({ addresseeUserId: "dotta" }));
|
|
expect(attentionResponderText(sent, describe_(sent, "dotta"))).toBe("Only you can answer it.");
|
|
expect(attentionResponderText(sent, describe_(sent, "scott"), new Map([["dotta", "Dotta"]]))).toBe("Only @Dotta can answer it.");
|
|
|
|
// An ownerless card addressed to a napping agent names the agent and the board, once.
|
|
const napping = card({ kind: "pool", userId: null, reason: "none" }, resolver({ addresseeAgentId: "agent-2", addresseeName: "Napping Agent" }));
|
|
const pool = describe_(napping, "scott") as Extract<ReturnType<typeof describeAttentionAudience>, { kind: "pool" }>;
|
|
expect(attentionUnownedAudienceText(napping, pool)).toBe("No owner yet. Napping Agent or any board member can answer it.");
|
|
const boardOnly = card({ kind: "pool", userId: null, reason: "none" }, resolver({ effectiveResolverPolicy: "human_only" }));
|
|
expect(attentionUnownedAudienceText(boardOnly, pool)).toBe("No owner yet. Any board member can answer it.");
|
|
const notCreator = card({ kind: "pool", userId: null, reason: "none" }, resolver({ effectiveResolverPolicy: "not_creator" }));
|
|
expect(attentionUnownedAudienceText(notCreator, pool)).toBe("No owner yet. Anyone except Watchdog can answer it.");
|
|
// A card with no resolver facts (an approval, a recovery) keeps the plain line.
|
|
const approval = { ...item({ kind: "pool", userId: null, reason: "none" }, "approval"), resolverAudience: null } as AttentionItem;
|
|
expect(attentionUnownedAudienceText(approval, pool)).toBe(ATTENTION_POOL_AUDIENCE_TEXT);
|
|
expect(attentionAudienceLineNamesResponders(napping, "scott")).toBe(true);
|
|
expect(attentionAudienceLineNamesResponders(napping, null)).toBe(false);
|
|
expect(attentionAudienceLineNamesResponders(approval, "scott")).toBe(false);
|
|
});
|
|
|
|
it("offers the task instead of Claim on an ownerless card with no owner field (PAP-767)", () => {
|
|
const pool: AttentionAudience = { kind: "pool", userId: null, reason: "none" };
|
|
const withTask = { ...item(pool, "blocker_attention"), subject: { id: "i", kind: "issue", href: "/NEE/issues/NEE-16" } } as unknown as AttentionItem;
|
|
expect(attentionClaimAlternative(withTask)).toEqual({ kind: "assign", href: "/NEE/issues/NEE-16" });
|
|
const noTask = { ...item(pool, "approval"), relatedIssue: null } as AttentionItem;
|
|
expect(attentionClaimAlternative(noTask)).toEqual({ kind: "none" });
|
|
// Claim itself, a card for a person and a company alert need no alternative.
|
|
expect(attentionClaimAlternative(item(pool))).toBeNull();
|
|
expect(attentionClaimAlternative(item({ kind: "user", userId: "scott", reason: "addressee" }, "approval"))).toBeNull();
|
|
expect(attentionClaimAlternative({ ...item({ kind: "company", userId: null, reason: "none" }, "failed_run"), stale: null } as AttentionItem)).toBeNull();
|
|
const unowned = { ...item({ kind: "company", userId: null, reason: "none" }, "blocker_attention"), stale: { reason: "unowned" },
|
|
subject: { id: "i", kind: "issue", href: "/NEE/issues/NEE-9" } } as unknown as AttentionItem;
|
|
expect(attentionClaimAlternative(unowned)).toEqual({ kind: "assign", href: "/NEE/issues/NEE-9" });
|
|
});
|
|
|
|
it("phrases the Unassigned banner", () => {
|
|
expect(unassignedBannerText(1)).toBe("1 card needs an owner");
|
|
expect(unassignedBannerText(3)).toBe("3 cards need an owner");
|
|
});
|
|
});
|