mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-11-04 19:28:46 +01:00
## Thinking Path > - Paperclip helps people manage AI agents at work. > - Native Runner owns execution and task authority. > - Operators need an explicit native Cursor Cloud choice. > - Tools/files need company, task, session and run scope. > - This connects setup and lifecycle to Runner Core. > - Legacy agents retain their selected runtime/history. ## Linked Issues or Issue Description Depends on #18068. Managed-only API placement and API-owned Stop containment are in #18310. Refs #5664, #11803, #17299, and #17471. No duplicate native integration was found. ## What Changed - Add explicit native setup, Test, saved settings and dispatch with no-prompt account/catalog/callback checks. - Scope MCP to company, agent, task, session and run through authenticated HTTPS. Register verified artifacts/work products; preserve unpriced accounting, completion and budgets. - Connect Question/Plan continuation, cold handoff and admitted fresh sessions; recheck waiting admission under the task lock. - Present audited Stop intent while preserving physical containment proof; bound typed Stop metadata. Preserve title edits through preference/navigation readiness. - Select one live/history representation per run to prevent duplicate settled cards. Integrate upstream task/read-state/retry/schema contracts and repair two test fixtures. ## Verification Core #18068 merged normally as `3910352c923a`. Product head `5a60f541c982` has passing repository CI/build/browser checks, including required `ci / verify` and `ci / e2e`, plus a fresh exact-head Greptile 5/5 review with zero unresolved threads. Two non-required external app checks remain pending: Paperclip Review is queued waiting for its assigned agent; Superagent Security Scan is reviewing the diff. These are not claimed completed. The normal merge endpoint enforces the repository rules; no policy or status override is used. The dependent Top PR is addressing its fresh deferred-Stop review finding. Product `5a60f541c982` passed 270 UI and 20 selected Cloud/native/disk-full tests, UI/server typechecks, tokens and maps. Top’s clean normal merge passed tokens/maps/diff checks; its matrix is pending. Earlier receipts retain Core’s 47 Rust, 4 compiled-native retirement and 19 settlement controls, normal Runner build, and runtime 9af build/recursive typecheck. Reproduced loading/shutdown CI fixture failures passed 7/7 browser and 121/121 unit tests, including a broken-unsubscribe negative control. No timeout/oracle was relaxed. The actual-parent restack adopts 75 mainline paths, including schema/permission and generic runtime changes, beyond the prior two fixture repairs and client projection fix. The full difference from hosted `9af1a5de42a2` is therefore larger than four files; backend source also differs. The merged config-read checks match Core391, and the Cursor placement/runtime/relay/selection modules match frozen9af; selected affected regressions pass. Paid proof keeps its actual 9af source/image identity. The separately tested live/history card fix is not claimed deployed on that host. On 9af, original saved settings survived reopening and fresh no-prompt Test authenticated catalog/model/binding; no new Save is claimed. Fresh Linux admission passed. With `claude-sonnet-4-5`, Artifact downloaded exact 27 bytes and matched 121 canonical identities in complete S3-served history. First Stop’s strict quiet FAILED on a 10.373-second gap despite independent cancellation/no late artifact. One targeted unchanged-sampler retry retained all 24 samples: 35.076 seconds quiet / maximum gap 4.584 seconds, 67 ordered canonical identities, and separate CANCELLED/artifact-absent status after the original 180-second deadline. The pre-reload duplicate settled card is disclosed. Exact-ID cleanup for the three new provider agents is awaiting authorization, so full grades and the fresh Artifact’s post-cleanup download remain blocked. A historical deleted-provider artifact was newly downloaded on 9af; original F226 Question/Plan/reconnect and cleanup proof keep their identities. Retained failures: stale fixture 132/133; E8 48/135 with 87 reset-hook failures; Mac 17 SQL failures/skips; earlier title/startup/custody/Stop/deletion failures with unknown causes/bounded recoveries; `dea023` Stop’s warning/50 duplicate identities; pre-repair ACK and original Core CI failures. WSP’s 251-assertion, 7/8-suite attempt failed physical PostgreSQL teardown; the unchanged wrapper rerun passed 128. Retry alone establishes no cause or full local-suite pass. All paid attempts remain recorded; vendor dollar cost is UNKNOWN. ## Risks Experimental: Cursor independently acknowledges neither the effective model nor instruction digest before the first prompt. Explicit values are submitted and checked through behavior; unpriced provider dollar cost stays UNKNOWN. Callbacks need authenticated reachable HTTPS. Scope, revocation, budgets, completion and cleanup remain authoritative. Operator Stop intent is separate from physical containment. Saved legacy agents retain their selected runtime. Prior shared title-save/deletion failures remain disclosed. ## Model Used OpenAI Codex, GPT-6 family, assisted with reasoning, repository tools, code execution, browser verification, and delegated code review. The serving model’s exact API ID and context window are not exposed. No value is inferred from the model catalog. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used and the limits of available model metadata - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have linked public issues or described the issue in this PR - [x] I have not referenced internal or instance-local Paperclip issues or links - [x] My branch describes the change and contains no internal ticket ID - [x] I have run the scoped local tests reported above; pending gates are stated separately - [x] I have added or updated tests where applicable - [x] I have updated relevant documentation - [x] I have considered and documented the risks - [x] All required CI gates pass on the current head - [x] Fresh Greptile is 5/5 with no unresolved findings on the current head - [x] I will address all reviewer comments before requesting merge --------- Co-authored-by: Paperclip <noreply@paperclip.ing>
110 lines
6.3 KiB
TypeScript
110 lines
6.3 KiB
TypeScript
import { afterEach, describe, expect, it, vi } from "vitest";
|
|
import type { RunnerApi } from "./api.js";
|
|
import { runnerMatrix } from "./catalog.js";
|
|
import { setupLiveFixtures } from "./live-fixtures.js";
|
|
|
|
const optIn = "PAPERCLIP_CURSOR_CLOUD_ALLOW_UNPRICED_QUALIFICATION";
|
|
const execution = runnerMatrix.find(cell => cell.id === "cursor-cloud.runner-cursor-cloud.local.cloud-followup")!;
|
|
const companyId = "fixture-company", agentId = "fixture-agent";
|
|
const policyDefaults = { companyId, metric: "billed_cents", windowKind: "calendar_month_utc",
|
|
amount: 1_000, hardStopEnabled: true, isActive: true, unpricedUsagePolicy: "allow" };
|
|
function fixtureApi(changeOverview?: (overview: Record<string, any>) => unknown) {
|
|
const calls: Array<{ method: string; path: string; body?: any }> = [];
|
|
const policies: Array<Record<string, any>> = [];
|
|
const api = {
|
|
async get(path: string) {
|
|
calls.push({ method: "GET", path });
|
|
if (path.endsWith("/environments?driver=local")) return [{ id: "local", driver: "local" }];
|
|
if (path.endsWith("/budgets/overview")) {
|
|
const overview = { companyId, policies };
|
|
return changeOverview ? changeOverview(overview) : overview;
|
|
}
|
|
throw new Error(`Unexpected GET ${path}`);
|
|
},
|
|
async postSensitive(path: string) { calls.push({ method: "SECRET", path }); return { id: "fixture-secret" }; },
|
|
async post(path: string, body: Record<string, any>) {
|
|
calls.push({ method: "POST", path, body });
|
|
if (path === "/api/companies") return { id: companyId, name: "Test" };
|
|
if (path.endsWith("/agents")) return { ...body, id: agentId, companyId };
|
|
if (path.endsWith("/budgets/policies")) {
|
|
const policy = { ...policyDefaults, ...body, unpricedEventCount: 1, excludedDiagnostic: "not-evidence" };
|
|
policies.push(policy);
|
|
return policy;
|
|
}
|
|
throw new Error(`Unexpected POST ${path}`);
|
|
},
|
|
} as unknown as RunnerApi;
|
|
return { api, calls };
|
|
}
|
|
function setup(api: RunnerApi, selected = execution) {
|
|
return setupLiveFixtures({ api, execution: selected, executionNonce: "budget-control", workspacePath: "/tmp/cursor-budget-control",
|
|
credentials: { [selected.profile.credential]: "synthetic-provider-key" } });
|
|
}
|
|
afterEach(() => vi.unstubAllEnvs());
|
|
|
|
describe("Cursor Cloud qualification budgets", () => {
|
|
it.each([undefined, "", "0", "true"])("blocks missing exact opt-in %s before fixture or provider dispatch", async value => {
|
|
vi.stubEnv(optIn, value);
|
|
const { api, calls } = fixtureApi();
|
|
await expect(setup(api)).rejects.toThrow(optIn);
|
|
expect(calls).toEqual([]);
|
|
});
|
|
|
|
it("verifies only the owned company and agent policies with known-cost hard stops intact", async () => {
|
|
vi.stubEnv(optIn, "1");
|
|
const { api, calls } = fixtureApi();
|
|
const fixtures = await setup(api);
|
|
expect(calls.find(call => call.path === "/api/companies")!.body.budgetMonthlyCents).toBe(1_000);
|
|
expect(calls.find(call => call.path.endsWith("/agents"))!.body.budgetMonthlyCents).toBe(1_000);
|
|
const writes = calls.filter(call => call.path.endsWith("/budgets/policies"));
|
|
expect(writes.map(call => ({ path: call.path, body: call.body }))).toEqual([
|
|
{ path: `/api/companies/${companyId}/budgets/policies`, body: { scopeType: "company", scopeId: companyId,
|
|
metric: "billed_cents", windowKind: "calendar_month_utc", amount: 1_000, hardStopEnabled: true, isActive: true, unpricedUsagePolicy: "allow" } },
|
|
{ path: `/api/companies/${companyId}/budgets/policies`, body: { scopeType: "agent", scopeId: agentId,
|
|
metric: "billed_cents", windowKind: "calendar_month_utc", amount: 1_000, hardStopEnabled: true, isActive: true, unpricedUsagePolicy: "allow" } },
|
|
]);
|
|
expect(calls.at(-1)).toEqual({ method: "GET", path: `/api/companies/${companyId}/budgets/overview` });
|
|
expect((fixtures as unknown as Record<string, unknown>).qualificationBudget).toEqual({
|
|
schema: "paperclip.e2e.cursor-cloud.qualification-budget.v1", unpricedUsageOptIn: true,
|
|
policies: [{ ...policyDefaults, scopeType: "company", scopeId: companyId }, { ...policyDefaults, scopeType: "agent", scopeId: agentId }],
|
|
});
|
|
await fixtures.teardown();
|
|
});
|
|
|
|
it.each([
|
|
["missing agent", (value: any) => { value.policies.pop(); }],
|
|
["foreign scope", (value: any) => { value.policies[1].scopeId = "foreign-agent"; }],
|
|
["foreign company", (value: any) => { value.policies[1].companyId = "foreign-company"; }],
|
|
["foreign overview", (value: any) => { value.companyId = "foreign-company"; }],
|
|
["zero limit", (value: any) => { value.policies[0].amount = 0; }],
|
|
["hard stop disabled", (value: any) => { value.policies[1].hardStopEnabled = false; }],
|
|
["inactive guard", (value: any) => { value.policies[0].isActive = false; }],
|
|
["unpriced block", (value: any) => { value.policies[1].unpricedUsagePolicy = "block"; }],
|
|
["wrong metric", (value: any) => { value.policies[0].metric = "runs"; }],
|
|
["wrong window", (value: any) => { value.policies[1].windowKind = "rolling_day"; }],
|
|
["duplicate scope", (value: any) => { value.policies.push({ ...value.policies[1] }); }],
|
|
["malformed policies", (value: any) => { value.policies = null; }],
|
|
] as const)("fails closed before returning a dispatchable fixture: %s", async (_name, change) => {
|
|
vi.stubEnv(optIn, "1");
|
|
const { api, calls } = fixtureApi(value => { change(value); return value; });
|
|
await expect(setup(api)).rejects.toThrow("budget policy readback");
|
|
expect(calls.some(call => call.path.includes("/issues"))).toBe(false);
|
|
});
|
|
|
|
it("propagates failed public policy readback before dispatch", async () => {
|
|
vi.stubEnv(optIn, "1");
|
|
const { api } = fixtureApi(() => { throw new Error("readback transport failed"); });
|
|
await expect(setup(api)).rejects.toThrow("readback transport failed");
|
|
});
|
|
|
|
it("does not change other providers or require their unpriced opt-in", async () => {
|
|
vi.stubEnv(optIn, undefined);
|
|
const { api, calls } = fixtureApi();
|
|
const other = runnerMatrix.find(cell => cell.suite.id === "stock-harness" && cell.profile.id === "runner-codex" && cell.environment.id === "local")!;
|
|
const fixtures = await setup(api, other);
|
|
expect(calls.some(call => call.path.includes("/budgets/"))).toBe(false);
|
|
expect(fixtures).not.toHaveProperty("qualificationBudget");
|
|
await fixtures.teardown();
|
|
});
|
|
});
|