mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-11-01 15:35:12 +01:00
## Thinking Path > - Paperclip manages agents and their work. > - Native Runner must bind each provider turn to the selected task, account, model, and instructions. > - Antigravity needs native ACP admission and physical process ownership across continuation. > - A saved conversation must not reuse an old process owner or silently switch its effective model. > - This pull request adds the native candidate behind exact operator admission. > - The default release gate remains closed while qualification is pending. ## Linked Issues or Issue Description Builds on merged #18187. Product account setup and the candidate producer are in dependent #18189. The repeatable browser journey is in #18190. Refs: #12503, #14938; those proposals use legacy CLI adapters. **Agent or provider** Google Antigravity ACP 1.4.3. **Why this adapter is useful** Users need to set up an Antigravity agent and run real work through their managed Google subscription. **How the agent is invoked** Native Paperclip Runner uses the pinned Antigravity ACP runtime. Exact operator admission is required while qualification remains pending. ## What Changed - Add native Antigravity ACP model and instruction admission, selected-account homes, and fenced refresh ownership. - Carry exact candidate authority from the control plane through Runner, Rust, the sidecar, and each current run. Clamp daemon lifetime to the absolute permission expiry, including replacement owners. - Preserve a rotated OAuth refresh token before later identity verification can fail, including failed or cancelled startup admission. Make private lease-close retries safe. - Bound native probe retirement and retry the exact original owner; do not delete credential homes before physical proof. - Preserve Gemini API-key recovery when shared Google subscription capability is added. - Resume the same tagged native conversation with fresh per-turn process ownership and physical native retirement. - Include native manifests in isolated Rust image stages, release cache keys, and dev rebuild detection. The workflow changes only extend existing cache input lists. - Keep current master provider behavior and append Grok 13, Pi 35, and Copilot 84 input identities. Preserve prior identities, including saved Copilot 82 and 83 runs. ## Verification - Runner TypeScript main checks, profile generators, Rust formatting, and offline workspace checks pass. The native backend integration target passes 28 tests. - The complete transport and cleanup group passes 387 tests without unhandled rejections. These checks use local scripted children and actual process and port ownership. - Saved-profile decoding, native-execution parsing, installation, and selected-credential controls pass 208 focused tests. All 109 pre-existing profile identity files remain byte-for-byte unchanged. Copilot, Grok, and shared TypeScript/Rust generation checks pass. - The final recovery fixture passes all seven cases. After the master rebase, the combined recovery and owned-Node-runtime group passes all 10 cases. Each expiry case sets one 45-second absolute grant before startup. It includes the deliberate six-second cold delay, four existing eight-second command budgets, and active-turn headroom. The test proves an active turn before expiry and then checks the daemon, owned process group, child processes, and all three native port fences. The 60-second test deadline does not renew provider authority. - The consolidated model-discovery and pending-release group passes 22 tests. Google credential compatibility and auth recovery pass 25 tests, including existing Gemini API-key recovery. The full product settings test group remains intact in #18189. - Earlier failures remain in their original CI runs and local records. They exposed the Copilot 82 decoder gap, an expired five-second fixture bootstrap ticket, and a fixture grant consumed before activation on loaded CI. Each repair has a separate result. Production ticket limits and admission behavior are unchanged by the final test commits. - An unrelated decision-expiry check failed in [the earlier CI run](https://github.com/paperclipai/paperclip/actions/runs/40941986698/job/123688668997). Its owning code is unchanged from the base. The unchanged suite passes 20 tests on isolated PostgreSQL. A controlled database rollback reproduces the earlier wake: clean startup schedules the 120-second decision expiry, while rollback reconciliation leaves a 30-second continuation-coalescing wake. The decision stays open, with no wake delivery or error. The fresh final-head server shard passes; the failed result is preserved. - Final native commit `ec6bc7e4d77f5ae0cc4946dbba6c662e95a87f5b` passed `ci / verify` and `ci / e2e`. Fresh Greptile and Paperclip reviews both score 5/5, with no open findings. Antigravity retains the recorded native `.5` closure and exact low-model profile. This PR does not claim global or cross-platform qualification. ## Risks - The new transport carries private managed credentials. Exact ownership, account generation, model, instructions, and native retirement are fail-closed. - Only local macOS ARM64 has a verified complete Antigravity runtime. Default Antigravity task execution remains disabled without current trusted operator admission. The Google server sign-in lane and production candidate producer ship in #18189; this native slice does not expose the subscription catalog choice. - Shared launch inputs change provider identities. New identities are append-only; existing recorded identities remain available. ## Model Used OpenAI Codex (GPT-6). The host did not expose the exact model revision or context limit. The model used tools for code edits, tests, and review. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either (a) linked existing issues with `Fixes: #` / `Closes #` / `Refs #` OR (b) described the issue in-PR following the relevant issue template - [x] I have not referenced internal/instance-local Paperclip issues or links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip` URLs) - [x] My branch name describes the change (e.g. `docs/...`, `fix/...`) and contains no internal Paperclip ticket id or instance-derived details - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] All Paperclip CI gates are green - [x] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I will address all Greptile and reviewer comments before requesting merge --------- Co-authored-by: Paperclip <noreply@paperclip.ing>
278 lines
11 KiB
TypeScript
278 lines
11 KiB
TypeScript
import { z } from "zod";
|
||
import { aiProviderRoutingSchema, aiRoutingHarness, isAiRoutingCompatible, type AiProviderRouting } from "./ai-provider-routing.js";
|
||
|
||
/** Runtime authentication is a separate transport, never a tool or channel. */
|
||
export const connectionPurposeTransportSchema = z.discriminatedUnion(
|
||
"connectionPurpose",
|
||
[
|
||
z.object({
|
||
connectionPurpose: z.literal("tool"),
|
||
transport: z.enum(["mcp_remote", "rest_api", "local_stdio"]),
|
||
}),
|
||
z.object({
|
||
connectionPurpose: z.literal("channel"),
|
||
transport: z.enum(["chat_sdk", "rest_api", "voice"]),
|
||
config: z.object({ provider: z.string().optional() }).passthrough().optional(),
|
||
}).refine(
|
||
(connection) => connection.transport === "voice" ? connection.config?.provider === "speko" : connection.transport === "chat_sdk" ? connection.config?.provider !== "speko" : connection.config?.provider === "agentmail",
|
||
{ message: "Channel transport must match its provider: voice for Speko, REST for AgentMail, Chat SDK otherwise", path: ["config", "provider"] },
|
||
),
|
||
z.object({
|
||
connectionPurpose: z.literal("ai"),
|
||
transport: z.literal("runtime_auth"),
|
||
}),
|
||
],
|
||
);
|
||
export type ConnectionPurposeTransport = z.infer<
|
||
typeof connectionPurposeTransportSchema
|
||
>;
|
||
|
||
export const AI_PROVIDERS = [
|
||
"anthropic",
|
||
"openai",
|
||
"openrouter",
|
||
"xai",
|
||
"github",
|
||
"google",
|
||
] as const;
|
||
export const aiProviderSchema = z.enum(AI_PROVIDERS);
|
||
export const aiAuthMethodSchema = z.enum(["subscription", "api_key"]);
|
||
export type AiProvider = z.infer<typeof aiProviderSchema>;
|
||
export type AiAuthMethod = z.infer<typeof aiAuthMethodSchema>;
|
||
const requirement = { provider: aiProviderSchema, method: aiAuthMethodSchema };
|
||
export const aiConnectionBindingSchema = z.discriminatedUnion("mode", [
|
||
z.object({
|
||
provider: aiProviderSchema,
|
||
// Retained on the wire for older servers during rolling upgrades. The
|
||
// responsible user's provider default determines the actual run method.
|
||
method: aiAuthMethodSchema,
|
||
mode: z.literal("responsible_user"),
|
||
}).strict(),
|
||
z
|
||
.object({
|
||
...requirement,
|
||
mode: z.literal("shared"),
|
||
connectionId: z.string().uuid(),
|
||
grantId: z.string().uuid(),
|
||
})
|
||
.strict(),
|
||
z
|
||
.object({
|
||
...requirement,
|
||
// Explicit personal selection. Human access still applies on every run.
|
||
mode: z.literal("delegated"),
|
||
connectionId: z.string().uuid(),
|
||
grantId: z.string().uuid(),
|
||
})
|
||
.strict(),
|
||
]);
|
||
export type AiConnectionBinding = z.infer<typeof aiConnectionBindingSchema>;
|
||
export const aiConnectionMetadataSchema = z.object({ ...requirement, routing: aiProviderRoutingSchema.optional() }).strict();
|
||
export type AiConnectionMetadata = z.infer<typeof aiConnectionMetadataSchema>;
|
||
|
||
/** Existing integrations only. This table describes compatibility, never routing. */
|
||
export const AI_CONNECTION_CAPABILITIES: Record<
|
||
AiProvider,
|
||
{
|
||
name: string;
|
||
methods: Partial<
|
||
Record<AiAuthMethod, { adapters: readonly string[]; envKey: string }>
|
||
>;
|
||
}
|
||
> = {
|
||
github: {
|
||
name: "GitHub Copilot",
|
||
methods: { api_key: { adapters: ["copilot_runtime"], envKey: "COPILOT_GITHUB_TOKEN" } },
|
||
},
|
||
google: { name: "Google", methods: {
|
||
api_key: { adapters: ["gemini_local", "pi_local", "antigravity_runtime"], envKey: "GEMINI_API_KEY" },
|
||
subscription: { adapters: ["antigravity_runtime"], envKey: "GEMINI_HOME" },
|
||
} },
|
||
anthropic: {
|
||
name: "Claude",
|
||
methods: {
|
||
subscription: {
|
||
adapters: ["claude_local"],
|
||
envKey: "CLAUDE_CODE_OAUTH_TOKEN",
|
||
},
|
||
api_key: { adapters: ["claude_local", "pi_local"], envKey: "ANTHROPIC_API_KEY" },
|
||
},
|
||
},
|
||
openai: {
|
||
name: "OpenAI",
|
||
methods: {
|
||
subscription: { adapters: ["codex_local"], envKey: "CODEX_HOME" },
|
||
api_key: { adapters: ["codex_local", "pi_local"], envKey: "OPENAI_API_KEY" },
|
||
},
|
||
},
|
||
openrouter: {
|
||
name: "OpenRouter",
|
||
methods: {
|
||
api_key: { adapters: ["opencode_local", "pi_local"], envKey: "OPENROUTER_API_KEY" },
|
||
},
|
||
},
|
||
xai: {
|
||
name: "Grok",
|
||
methods: {
|
||
subscription: { adapters: ["grok_local"], envKey: "GROK_HOME" },
|
||
api_key: { adapters: ["grok_local"], envKey: "XAI_API_KEY" },
|
||
},
|
||
},
|
||
};
|
||
export function isAiConnectionCompatible(
|
||
requirement: AiConnectionMetadata | AiConnectionBinding,
|
||
adapterType: string,
|
||
model?: unknown,
|
||
runnerProvider?: unknown,
|
||
acpxAgent?: unknown,
|
||
): boolean {
|
||
adapterType = aiRoutingHarness(adapterType, runnerProvider, acpxAgent);
|
||
// Antigravity uses its own Google runtime sign-in or a Gemini API key.
|
||
// Tool OAuth and API-compatible endpoints cannot authenticate this harness.
|
||
if (adapterType === "antigravity_runtime") return requirement.provider === "google"
|
||
&& (requirement.method === "api_key" || requirement.method === "subscription")
|
||
&& !("routing" in requirement && requirement.routing);
|
||
if ("routing" in requirement && requirement.routing) return requirement.method === "api_key" && isAiRoutingCompatible(requirement.routing, adapterType);
|
||
// A fixed binding contains identity only. The service checks authoritative
|
||
// connection metadata before resolving credentials or running the harness.
|
||
if (adapterType === "pi_local") return (requirement.method === "api_key" || ("mode" in requirement && requirement.mode === "responsible_user"))
|
||
&& ["openrouter", "openai", "anthropic", "google"].includes(requirement.provider)
|
||
&& typeof model === "string" && model.startsWith(`${requirement.provider}/`);
|
||
if ("mode" in requirement && requirement.mode !== "responsible_user" && requirement.method === "api_key")
|
||
return ["claude_local", "codex_local", "opencode_local", "hermes_local", "gemini_local", "grok_local", "copilot_runtime"].includes(adapterType);
|
||
const methods = AI_CONNECTION_CAPABILITIES[requirement.provider].methods;
|
||
const candidates = "mode" in requirement && requirement.mode === "responsible_user"
|
||
? Object.values(methods)
|
||
: requirement.method ? [methods[requirement.method]] : [];
|
||
return (
|
||
candidates.some((method) => method?.adapters.includes(adapterType)) &&
|
||
(requirement.provider !== "openrouter" ||
|
||
(typeof model === "string" && model.startsWith("openrouter/")))
|
||
);
|
||
}
|
||
export type AiConnectionUnavailableReason =
|
||
| "responsible_user_missing"
|
||
| "membership_missing"
|
||
| "default_missing"
|
||
| "connection_missing"
|
||
| "connection_unavailable"
|
||
| "incompatible"
|
||
| "access_denied"
|
||
| "credential_missing";
|
||
export interface AiConnectionAttribution {
|
||
/** Billing account at execution time; never resolved again from mutable settings. */
|
||
subscriptionId?: string;
|
||
connectionId: string;
|
||
grantId: string;
|
||
provider: AiProvider;
|
||
method: AiAuthMethod;
|
||
mode: AiConnectionBinding["mode"];
|
||
responsibleUserId: string | null;
|
||
}
|
||
export type AiConnectionResolution =
|
||
| { ok: true; attribution: AiConnectionAttribution }
|
||
| { ok: false; reason: AiConnectionUnavailableReason; message: string };
|
||
|
||
export interface AiManagedConnectionSummary {
|
||
id: string;
|
||
grantId: string;
|
||
companyId: string;
|
||
provider: AiProvider;
|
||
method: AiAuthMethod;
|
||
name: string;
|
||
routing?: AiProviderRouting;
|
||
accountLabel?: string;
|
||
ownership: "personal" | "shared";
|
||
ownerUserId?: string;
|
||
ownerName?: string;
|
||
isDefault: boolean;
|
||
status: "connected" | "needs_attention" | "expired" | "revoked";
|
||
unavailableReason?: string;
|
||
usageProbeSupported?: boolean;
|
||
}
|
||
export interface AiConnectionList {
|
||
currentUserId: string;
|
||
pools?: import("./ai-connection-router.js").AiConnectionPool[];
|
||
canManageConnections: boolean;
|
||
connections: AiManagedConnectionSummary[];
|
||
}
|
||
export const createAiConnectionSchema = z
|
||
.object({
|
||
...requirement,
|
||
name: z.string().trim().min(1).max(160),
|
||
ownership: z.enum(["personal", "shared"]),
|
||
routing: aiProviderRoutingSchema.optional(),
|
||
apiKey: z.string().trim().min(1).max(32768).optional(),
|
||
environmentId: z.string().uuid().nullable().optional(),
|
||
loginSessionId: z.string().max(128).optional(),
|
||
connectionId: z.string().uuid().optional(),
|
||
agentIds: z.array(z.string().uuid()).max(1000).default([]),
|
||
allAgents: z.boolean().default(false),
|
||
})
|
||
.strict()
|
||
.superRefine((v, ctx) => {
|
||
if (!AI_CONNECTION_CAPABILITIES[v.provider].methods[v.method])
|
||
ctx.addIssue({ code: "custom", message: "Unsupported sign-in method" });
|
||
if (v.routing && (v.method !== "api_key" || (v.routing.kind === "openrouter" && v.provider !== "openrouter") || (v.routing.kind === "bedrock" && v.provider !== "anthropic")))
|
||
ctx.addIssue({ code: "custom", message: "Routing requires the matching provider and API authentication." });
|
||
if (v.routing && ["gateway", "local"].includes(v.routing.kind) && v.provider !== (v.routing.protocol === "messages" ? "anthropic" : "openai"))
|
||
ctx.addIssue({ code: "custom", message: "The provider must match the endpoint’s API format." });
|
||
if (v.routing?.auth === "none") {
|
||
if (v.apiKey || v.loginSessionId) ctx.addIssue({ code: "custom", message: "Provide only the selected authentication method." });
|
||
return;
|
||
}
|
||
if (
|
||
v.method === "api_key"
|
||
? !v.apiKey || Boolean(v.loginSessionId)
|
||
: !v.loginSessionId || Boolean(v.apiKey)
|
||
) {
|
||
ctx.addIssue({
|
||
code: "custom",
|
||
message:
|
||
"Provide exactly the credential for the selected sign-in method",
|
||
});
|
||
}
|
||
});
|
||
export type CreateAiConnection = z.infer<typeof createAiConnectionSchema>;
|
||
|
||
export const aiConnectionLoginIntentSchema = z
|
||
.object({
|
||
provider: z.enum(["anthropic", "openai", "xai", "google"]),
|
||
method: z.literal("subscription"),
|
||
name: z.string().trim().min(1).max(160),
|
||
ownership: z.enum(["personal", "shared"]),
|
||
connectionId: z.string().uuid().optional(),
|
||
agentIds: z.array(z.string().uuid()).max(1000).default([]),
|
||
allAgents: z.boolean().default(false),
|
||
})
|
||
.strict();
|
||
export type AiConnectionLoginIntent = z.infer<
|
||
typeof aiConnectionLoginIntentSchema
|
||
>;
|
||
|
||
export const localAiConnectionSchema = aiConnectionLoginIntentSchema.extend({
|
||
localSessionId: z.string().uuid().optional(),
|
||
});
|
||
export const localAiLoginStartSchema = aiConnectionLoginIntentSchema.extend({ restart: z.boolean().optional() });
|
||
export interface LocalAiLoginStatus {
|
||
status: "ready" | "sign_in_required" | "expired";
|
||
authorizationUrl?: string;
|
||
code?: string;
|
||
error?: string;
|
||
accountLabel?: string;
|
||
}
|
||
export interface LocalAiLoginAttempt {
|
||
sessionId: string;
|
||
/** Grok still uses terminal sign-in until it has an in-app login runner. */
|
||
command?: string;
|
||
expiresAt: string;
|
||
}
|
||
|
||
/** Preview-era copies of rotating local credentials must be reconnected. */
|
||
export function aiSubscriptionNeedsIsolatedLogin(config: Record<string, unknown> | undefined): boolean {
|
||
const metadata = aiConnectionMetadataSchema.safeParse(config?.ai);
|
||
return metadata.success && metadata.data.method === "subscription" &&
|
||
(["openai", "xai", "google"].includes(metadata.data.provider)) &&
|
||
config?.aiIsolatedSubscription !== true;
|
||
}
|