Files
PaperClipAI/tests/runner-e2e/evidence.ts
T
DottaandPaperclip ab15aff390 feat: add experimental persistent agent chat (#13284)
## Thinking Path

> - Paperclip is the open source app people use to manage AI agents for
work.
> - Conversations must use the same tasks, controls, and execution
history.
> - Users need an ongoing chat with an agent without managing task
properties.
> - Agents should clarify and plan work, then hand execution to assigned
project tasks.
> - This pull request combines the reviewed Agent Chat stack for one
squash merge.
> - The benefit is persistent conversation with normal task governance
and shared UI.

## Linked Issues or Issue Description

**Subsystem affected**

Task lifecycle, agent runtime tools, shared task UI, and browser/paid
runner tests.

**Problem or motivation**

Users need one persistent conversation with each agent. A separate chat
store or renderer would duplicate task behavior and bypass existing
controls.

**Proposed solution**

Use a task-backed chat per company, user, and agent. Reuse the task
composer and transcript. Clarify and plan in chat, then create assigned
project tasks with the relevant plan. Keep Agent Chat behind its own
disabled-by-default experimental setting.

**Roadmap alignment**

This implements the task-backed direction in [CEO
Chat](https://github.com/paperclipai/paperclip/blob/master/ROADMAP.md#-ceo-chat).
Related proposals: #2504 and #9693. Related request: #7981. The
maintainer requested one squash merge of the complete stack.

Consolidates the reviewed runtime
[#13281](https://github.com/paperclipai/paperclip/pull/13281), backend
[#13282](https://github.com/paperclipai/paperclip/pull/13282), and UI
[#13283](https://github.com/paperclipai/paperclip/pull/13283) layers
with this PR's E2E coverage. All four layers passed CI and received
Greptile 5/5 before consolidation. This PR targets master and includes
the complete feature.

## What Changed

- Add personal canonical chat tasks with ordinary company visibility,
immutable identity, idempotent first sends, and an idle waiting state.
- Process `/new` in queue order. Preserve history, release a chat pause,
and fence old provider context and delayed writes.
- Keep chat lifecycle rules across recovery, finalization, assignment,
task lists, and rollups.
- Support research and plan revision in chat. Hand plans to ordinary
assigned project tasks before execution starts. Reject new chat
subtasks.
- Add repository-aware project creation and discovery tools, including
multiple repository IDs and GitHub URLs, authorization, idempotency, and
durable project-created cards.
- Reuse task UI components for chat, with starred/recent agent
navigation and a separate `enableAgentChat` experimental flag.
- Add deterministic browser tests and 24 paid chat cells across four
Codex/Claude profiles, with validated reports and screenshots.
- Integrate current master recovery, controller lease, queued-message,
and task UI changes. Gate chat interruption and deferred promotion on
ownership/feature policy. Guarantee lease renewal and active controls
are stopped even if teardown fails.
- Preserve master's migration 0273 and generate chat migration 0274 with
idempotent replay for development databases.

## Verification

- Prior exact heads of all four PRs passed Linux CI, including build,
typecheck, general/serialized tests, and browser E2E. Each had Greptile
5/5 and no unresolved findings.
- Integrated local verification passed: full repository typecheck and
production build, Storybook build, token gates, 340 focused UI tests,
all 20 deterministic chat browser tests, two migration replay tests, 88
focused chat/queue/native/controller tests, and provider/session
regressions including real lease expiry. These include the three
lifecycle regressions for the final admission/teardown fixes; server
typecheck also passes. Current head
`1268eda16cc2af892055917e7292f068820be135` has Greptile 5/5 with no
unresolved findings and passing security scans. All final-head CI gates
passed: build, full Runner verification, typecheck/release registry,
canary, all general/serialized test shards, and all browser E2E shards
([CI
run](https://github.com/paperclipai/paperclip/actions/runs/34696739927)).
Local PostgreSQL startup contention required serialized retries; skipped
fixtures do not count as passing coverage.
- The earlier paid campaign passed all 24 chat cells and retained 32
screenshots:
[report](https://d1p6rlowie26tp.cloudfront.net/runner-e2e/campaigns/gha-34648511170-1/index.html?report=agent-chat#suite-agent-chat).
It tested `abacbdfd2f660709ec37312cdb758284c8399d04`; it is prior
evidence, not a paid run of this integrated head.
- Manual check: enable Agent Chat in Experimental settings, open an
agent, clarify and revise a plan, then hand off to an assigned project
task. Stop a reply, send `/new`, and verify fresh context with retained
history. Disable the setting and verify agent shortcuts/new chat turns
are blocked.

## Risks

- Queue/session integration can affect retries and delayed writes. Tests
cover ownership, cancellation, reset boundaries, idle recovery, and
ordinary task behavior.
- Migration 0274 adds conversation fields and constraints. Replay is
idempotent and preserves existing development chat history.
- This combines the previously reviewed stack at the maintainer's
request. Agent Chat remains off by default and is separate from
Conference Room.

## Model Used

OpenAI Codex, GPT-6 Astra (`gpt-6-astra`), with reasoning, code
execution, browser tools, and parallel review. The exact context-window
size is not exposed in this session. Codex and Claude also ran as test
subjects in the linked paid campaign.

## Checklist

- [x] I have included a thinking path that traces from project context
to this change
- [x] I have specified the model used (with version and capability
details)
- [x] I have checked ROADMAP.md and confirmed this PR does not duplicate
planned core work
- [x] I have searched GitHub for duplicate or related PRs and linked
them above
- [x] I have either (a) linked existing issues with `Fixes: #` / `Closes
#` / `Refs #` OR (b) described the issue in-PR following the relevant
issue template
- [x] I have not referenced internal/instance-local Paperclip issues or
links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip`
URLs)
- [x] My branch name describes the change (e.g. `docs/...`, `fix/...`)
and contains no internal Paperclip ticket id or instance-derived details
- [x] I have run tests locally and they pass
- [x] I have added or updated tests where applicable
- [x] I have updated relevant documentation to reflect my changes
- [x] I have considered and documented any risks above
- [x] All Paperclip CI gates are green
- [x] Greptile is 5/5 with no open P2s, recommendations, or follow-ups
- [x] I will address all Greptile and reviewer comments before
requesting merge

---------

Co-authored-by: Paperclip <noreply@paperclip.ing>
2026-09-12 08:56:04 -05:00

235 lines
7.5 KiB
TypeScript

import { spawn } from "node:child_process";
import {
mkdir,
readFile,
readdir,
rm,
writeFile,
copyFile,
} from "node:fs/promises";
import path from "node:path";
import {
assertSecretFree,
findSecretLeak,
findSecretLeakInJsonValues,
redactText,
sanitizeJson,
} from "./redaction.js";
const TEXT_EXTENSIONS = new Set([
".json",
".xml",
".html",
".css",
".js",
".txt",
".log",
".md",
]);
const BINARY_EXTENSIONS = new Set([".png", ".webm"]);
const ACTIVE_CONTENT_EXTENSIONS = new Set([".svg"]);
const ALLOWED_DIRECTORIES = new Set([
"snapshots",
"playwright-output",
"blob-report",
"html-report",
]);
const ALLOWED_ROOT_FILES = new Set([
"result.json",
"final-state.png",
"failure.png",
"chat-plan-draft.png",
"chat-plan-revised.png",
"server.log",
"playwright.log",
"junit.xml",
]);
const REQUIRED_PASS_FILES = [
"final-state.png",
"result.json",
"junit.xml",
path.join("html-report", "index.html"),
path.join("snapshots", "fixtures.json"),
path.join("snapshots", "api-state.json"),
] as const;
export interface EvidencePackageResult {
files: string[];
leaks: Array<{ file: string; reason: string }>;
missing: string[];
}
async function walk(root: string, relative = ""): Promise<string[]> {
const directory = path.join(root, relative);
const entries = await readdir(directory, { withFileTypes: true }).catch(
() => [],
);
const files: string[] = [];
for (const entry of entries) {
const next = path.join(relative, entry.name);
if (entry.isDirectory()) files.push(...(await walk(root, next)));
else if (entry.isFile()) files.push(next);
}
return files;
}
function isAllowed(relative: string) {
const segments = relative.split(path.sep);
if (segments.length === 1)
return (
ALLOWED_ROOT_FILES.has(relative) ||
/^(?:plan|question)-[a-z0-9-]+\.png$/.test(relative)
);
return ALLOWED_DIRECTORIES.has(segments[0]);
}
async function inspectZip(source: string, secrets: readonly string[]) {
// Failure traces can exceed Node's child-process output buffer. Stream the
// expanded archive through the exact-value scanner with enough overlap to
// detect a credential split across stdout chunks, without retaining the
// archive in memory or weakening fail-closed evidence publication.
const overlap = Math.max(
256,
...secrets.map((secret) => Buffer.byteLength(secret, "utf8") + 16),
);
return new Promise<string | null>((resolve) => {
const unzip = spawn("unzip", ["-p", source], {
stdio: ["ignore", "pipe", "pipe"],
});
let carry = Buffer.alloc(0);
let leak: string | null = null;
let spawnError: Error | null = null;
unzip.stdout.on("data", (chunk: Buffer) => {
if (leak) return;
const data = Buffer.concat([carry, chunk]);
leak = findSecretLeak(data, secrets, { includeShapes: false });
carry = data.subarray(Math.max(0, data.length - overlap));
if (leak) unzip.kill();
});
// Drain diagnostics so a noisy unzip cannot block. Error text is withheld
// because archive paths and contents belong to private attempt evidence.
unzip.stderr.resume();
unzip.on("error", (error) => {
spawnError = error;
});
unzip.on("close", (code) => {
if (leak) return resolve(leak);
if (spawnError) {
return resolve(`zip could not be inspected: ${spawnError.message}`);
}
return resolve(
code === 0
? null
: `zip could not be inspected: unzip exited with code ${String(code)}`,
);
});
});
}
export async function packageEvidence(input: {
privateDir: string;
uploadDir: string;
secrets: readonly string[];
expectPassScreenshot: boolean;
}): Promise<EvidencePackageResult> {
await rm(input.uploadDir, { recursive: true, force: true });
await mkdir(input.uploadDir, { recursive: true });
const files: string[] = [];
const leaks: EvidencePackageResult["leaks"] = [];
const available = await walk(input.privateDir);
for (const relative of available.filter(isAllowed)) {
const source = path.join(input.privateDir, relative);
const extension = path.extname(relative).toLowerCase();
const destination = path.join(input.uploadDir, relative);
await mkdir(path.dirname(destination), { recursive: true });
if (ACTIVE_CONTENT_EXTENSIONS.has(extension)) {
// SVG can execute script when opened directly from an artifact. Keep the
// source in the disposable private attempt directory, but never admit it
// to the sanitized CI artifact.
continue;
} else if (TEXT_EXTENSIONS.has(extension)) {
const raw = await readFile(source, "utf8");
const parsed = extension === ".json" ? JSON.parse(raw) : null;
const leak =
extension === ".json"
? findSecretLeakInJsonValues(parsed, input.secrets)
: findSecretLeak(raw, input.secrets);
if (leak) leaks.push({ file: relative, reason: leak });
// Redacting an already serialized JSON string can change escape
// boundaries around shell commands. Sanitize parsed values instead so
// uploaded snapshots stay valid JSON.
const safe =
extension === ".json"
? `${JSON.stringify(sanitizeJson(parsed, input.secrets), null, 2)}\n`
: redactText(raw, input.secrets);
if (extension === ".json") {
const safeLeak = findSecretLeakInJsonValues(
JSON.parse(safe),
input.secrets,
);
if (safeLeak)
throw new Error(`Secret leak in ${relative}: ${safeLeak}`);
} else {
assertSecretFree(safe, input.secrets, relative);
}
await writeFile(destination, safe, "utf8");
files.push(relative);
} else if (extension === ".zip") {
const leak = await inspectZip(source, input.secrets);
if (leak) {
leaks.push({ file: relative, reason: leak });
continue;
}
await copyFile(source, destination);
files.push(relative);
} else if (BINARY_EXTENSIONS.has(extension)) {
// This raw-byte scan catches embedded plaintext credentials, but cannot
// inspect rendered pixels. Provider/UI raster and video files remain in
// the access-controlled CI artifact. The public publisher creates its
// own synthetic summary image from fixed labels and numeric/status data.
const raw = await readFile(source);
const leak = findSecretLeak(raw, input.secrets);
if (leak) {
leaks.push({ file: relative, reason: leak });
continue;
}
await copyFile(source, destination);
files.push(relative);
}
}
const missing = input.expectPassScreenshot
? [
...REQUIRED_PASS_FILES.filter((required) => !files.includes(required)),
...(files.some(
(file) =>
file.startsWith(`blob-report${path.sep}`) && file.endsWith(".zip"),
)
? []
: [path.join("blob-report", "*.zip")]),
]
: [];
const manifest = {
schema: "paperclip.runner-e2e.evidence/v1",
files: [...files].sort(),
leaks,
missing,
};
const manifestText = `${JSON.stringify(sanitizeJson(manifest, input.secrets), null, 2)}\n`;
const manifestLeak = findSecretLeakInJsonValues(
JSON.parse(manifestText),
input.secrets,
);
if (manifestLeak)
throw new Error(`Secret leak in evidence-manifest.json: ${manifestLeak}`);
await writeFile(
path.join(input.uploadDir, "evidence-manifest.json"),
manifestText,
"utf8",
);
files.push("evidence-manifest.json");
return { files, leaks, missing };
}