Files
PaperClipAI/server/src/services/agent-conversations.ts
T
DottaandPaperclip 3c561642b4 fix(chat): resolve approvals and preserve unanswered questions (#14613)
## Thinking Path

> - Paperclip is the open source app people use to manage AI agents for
work.
> - Agents ask for decisions and optional details through cards in chat.
> - A clear approval in a message can leave the matching card pending.
> - An unanswered question can also block an unrelated later reply.
> - Decisions need a saved source message, while optional questions need
to remain answerable in history.
> - This pull request records conversational decisions and lets users
move on from questions and answer them later.

## Linked Issues or Issue Description

**What happened?**

Native Claude and Codex could act on approval in chat while the original
approval card stayed pending. Pending question forms stayed above the
composer, were absent from history, and could suppress later chat
replies. A late native question answer could wait for a finished run to
reconnect.

**Expected behavior**

The active agent records a clear approval or refusal against the exact
card and user message. Ambiguous replies do not grant consent. Users can
send another message without answering a question. The question remains
pending in history and can be reopened and answered later. The saved
answer reaches the agent.

**Steps to reproduce**

1. Ask an agent to propose work with a confirmation card, then approve
it in chat.
2. Check that the original card records that approval before work
starts.
3. Ask an interactive question, send an unrelated message, and reload.
4. Open the unanswered question from history and submit an answer.

Related work: #14408 added completion delivery. #14607 tests completion
reporting turns. Neither records conversational answers on approval
cards.

## What Changed

- Add a confirmation endpoint backed by a user comment, with schema
validation, OpenAPI discovery, and native Plan-mode access. Ask mode
remains read-only.
- Check company, active run, actor, current session, message provenance,
revision, and resolver policy. Save the decision and audit in one
transaction. Retries do not repeat effects. Emit resolution telemetry
after commit.
- Give fresh and resumed chat turns the actual pending confirmation
identities. Teach agents to save clear conversational decisions before
acting and to clarify ambiguity.
- Keep unanswered Agent Chat questions as compact history entries. A
newer user message closes the old form. Question cards never contribute
to composer pending counts or navigation, including after dismissing a
fresh form. The history card is the sole reminder; clicking it restores
that exact form and draft.
- Preserve Agent Chat questions when later messages or questions arrive.
Historical ordinary inputs no longer gate later chat replies.
Current-run requests, task execution, and governed approvals keep their
gates. Remove the special acknowledgement-publication proof helpers that
this rule replaces.
- Route answers to finished native runs through durable fresh-wake
delivery, with existing idempotency and source-question context. Settle
late replies against contiguous completed conversation turns and freeze
their history replay; failed, unhandled, and newly arriving messages
remain actionable.
- Add real-component Storybook scenarios, database and UI regressions,
and a three-turn native Claude/Codex E2E case. Capture distinct,
UI-ready screenshots and report the individual assertions.

## Verification

- Focused decision/publication/UI regressions after merging master: 288
passed; subsequent UI draft, failed-send, and conversation checks: 199
passed.
- Native question and durable delivery regressions: 106 passed,
including all four terminal run states and exactly-once late delivery.
Seven targeted regressions fail against the original implementation and
pass with the fix.
- Latest conversation/decision/native-delivery regressions after the
master merge: 121 passed. Covers completed progress, missing or failed
intervening turns, new messages during a late reply, stale sessions, and
frozen retry/replay boundaries. Four new assertions fail before the
ordering fix.
- E2E support suite after the master merge: 792 passed. Negative
controls reject expired cards, wrong questions/answers, stale or missing
replies, unrelated clarification forms, and unexpected tasks.
- The embedded-browser walkthrough caught one additional defect:
dismissing a fresh question still showed a composer badge. Both Cancel
and close-button regressions failed before the fix. The fix at
`65f2ade12` passes 170 chat-thread tests and 792 E2E support tests.
After merging master, 232 chat-thread/confirmation tests, server/UI
typechecks, and token gates pass. The preview and two-provider live E2E
pass at `e5512a206`; Greptile is 5/5 with zero unresolved threads at
that commit. All 55 checks are now successful at `e5512a206` (four
conditional checks skipped), including the aggregate verification gate
and clean-install canary test. The first attempt was interrupted by
simultaneous CI worker shutdowns; one failed-job rerun passed without
code changes.
- [Published
Storybook](https://d1p6rlowie26tp.cloudfront.net/storybook/branches/codex~2Fchat-approval-resolution/?path=/story/chat-comments-agent-chat-unanswered-questions--moved-on):
nine real-component scenarios. Manually exercised move on, reopen,
preserve draft, answer later, answer one of multiple questions, and a
custom mobile answer in the embedded browser. Retested fresh Cancel and
close-button dismissal in the updated build, then reopened and submitted
the preserved Green selection and inspected its answered receipt. Static
preview has no live model/backend; its callbacks are fixture responses.
- [First live
campaign](https://d1p6rlowie26tp.cloudfront.net/runner-e2e/campaigns/gha-36714504406-1/)
reproduced the late-answer completion-state defect on both providers
despite correct saved answers and acknowledgements. It also exposed a
valid imperative clarification rejected by the old oracle. Both issues
are fixed with regression controls; this failing run is retained as
evidence.
- [Four-cell
qualification](https://d1p6rlowie26tp.cloudfront.net/runner-e2e/campaigns/gha-36717804064-1/)
passed 4/4 at `2bf8a1009`: unanswered-question return and ambiguous
confirmation, each on native Claude and Codex. Inspected saved state,
source-message decisions, visible cards, and agent replies. Both
late-answer chats settled to waiting; no unrequested tasks were created.
[Final branch
rerun](https://d1p6rlowie26tp.cloudfront.net/runner-e2e/campaigns/gha-36719666238-1/)
passed 2/2 at `142630720`: the same unanswered-question journey after
merging master, plus an additional screenshot and browser assertion for
the actual late-answer acknowledgement.
- [Composer-reminder
E2E](https://d1p6rlowie26tp.cloudfront.net/runner-e2e/campaigns/gha-36727006818-1/)
passed 2/2 at `5b62c52d9`: native Claude and Codex, three turns each,
with explicit no-badge assertions before and after reload. Inspected
saved pending/answered state, both screenshots with a clear composer,
and actual Blue acknowledgements; all five behavioral matchers passed
per provider and neither created tasks. Cost coverage is partial; this
is bounded workflow qualification.
- [Fresh-dismissal
E2E](https://d1p6rlowie26tp.cloudfront.net/runner-e2e/campaigns/gha-36742773318-1/)
passed 2/2 at `e5512a206`: native Claude and Codex, including fresh
Cancel, clear composer, reopen, unrelated message, reload, late Blue
answer, and actual agent acknowledgement. All five behavioral matchers
pass per provider. Inspected the fresh-dismissal screenshots and saved
pending/answered identity; neither created tasks. Cost coverage is
partial (4/6 runs).
- Prior evidence remains available in [the earlier
campaign](https://d1p6rlowie26tp.cloudfront.net/runner-e2e/campaigns/gha-36642252725-1/).
Its early loading screenshot and overwritten final capture prompted the
UI-ready, distinct screenshot fixes.

## Risks

- The model interprets intent. The server verifies permission and
provenance; it does not infer consent from text. Ambiguous and unrelated
replies are not approvals.
- Historical questions can accumulate. They remain visible, pending, and
answerable; no automatic answer or expiry is invented.
- The change to completion gates is scoped to Agent Chat and ordinary
historical inputs. Current-turn and governed approvals retain their
existing controls.
- Live qualification is limited to the selected stories. Broader native
onboarding finalization remains separate work.
- No database migration. Telemetry adds no fields or values; the
contract and README document the commit boundary. Privacy review was
requested on the PR.

## Model Used

OpenAI Codex, GPT-6 family, with reasoning, repository tools, code
execution, and browser-test orchestration. The exact model ID and
context-window size are not exposed to this session.

## Checklist

- [x] I have included a thinking path that traces from project context
to this change
- [x] I have specified the model used (with version and capability
details)
- [x] I have checked ROADMAP.md and confirmed this PR does not duplicate
planned core work
- [x] I have searched GitHub for duplicate or related PRs and linked
them above
- [x] I have either (a) linked existing issues with `Fixes: #` / `Closes
#` / `Refs #` OR (b) described the issue in-PR following the relevant
issue template
- [x] I have not referenced internal/instance-local Paperclip issues or
links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip`
URLs)
- [x] My branch name describes the change (e.g. `docs/...`, `fix/...`)
and contains no internal Paperclip ticket id or instance-derived details
- [x] I have run tests locally and they pass
- [x] I have added or updated tests where applicable
- [x] I have updated relevant documentation to reflect my changes
- [x] I have considered and documented any risks above
- [x] All Paperclip CI gates are green
- [x] Greptile is 5/5 with no open P2s, recommendations, or follow-ups
- [x] I will address all Greptile and reviewer comments before
requesting merge

---------

Co-authored-by: Paperclip <noreply@paperclip.ing>
2026-09-30 11:46:46 -05:00

605 lines
30 KiB
TypeScript

import {
persistActivity,
publishActivity,
type ActivityPublication,
} from "./activity-log.js";
import type { NativeStatusDecision } from "./native-runtime/status-arbiter.js";
import { and, desc, eq, isNull, sql } from "drizzle-orm";
import {
agentTaskSessions,
agentWakeupRequests,
heartbeatRuns,
issueComments,
issueTreeHolds,
issueThreadInteractions,
issues,
type Db,
} from "@paperclipai/db";
import { sanitizeQuarantinedCommentForHigherTrust } from "./source-trust.js";
export type ConversationIdentity = {
conversationAgentId?: string | null;
conversationUserId?: string | null;
conversationState?: string | null;
status?: string;
};
export function isConversation(
issue: ConversationIdentity | null | undefined,
): boolean {
return Boolean(issue?.conversationAgentId && issue.conversationUserId);
}
export function isWaitingConversation(
issue: ConversationIdentity | null | undefined,
): boolean {
return (
isConversation(issue) &&
issue?.conversationState === "waiting" &&
issue.status === "in_review"
);
}
/** Recovery for an older turn must not replace a reset or an answered chat. */
export function isSupersededConversationRun(
issue: ConversationIdentity & {
conversationSessionGeneration?: number;
executionRunId?: string | null;
},
run: { id: string; contextSnapshot: Record<string, unknown> | null },
): boolean {
if (!isConversation(issue)) return false;
const generation = run.contextSnapshot?.conversationSessionGeneration;
return (
(typeof generation === "number" &&
typeof issue.conversationSessionGeneration === "number" &&
generation !== issue.conversationSessionGeneration) ||
(typeof generation === "number" &&
isWaitingConversation(issue) &&
issue.executionRunId !== run.id)
);
}
/** Execution tasks may link to a conversation, but never drive its turns.
* Apply before enqueue, including while a reply is still running: waiting until
* finalization is too late to prevent a deferred dependency follow-up.
*/
export function isConversationExecutionWake(
issue: ConversationIdentity | null | undefined,
reason: string | null | undefined,
): boolean {
return isConversation(issue) && (
reason === "issue_blockers_resolved" ||
reason === "issue_children_completed" ||
reason === "issue_unblock_requested"
);
}
export function isConversationReset(body: string): boolean {
return body.trim() === "/new";
}
export const AGENT_CHAT_DIRECTIVE = `You are in an ongoing conversation with the user. Help them clarify the outcome they want. Ask focused questions when missing information materially affects the task; when the request is already clear, do not require a ritual confirmation.
Research, clarify, and develop full plans here using the conversation's plan document. Revise the draft as the discussion develops. Planning alone does not create execution tasks. Put implementation and substantial execution into separate tasks.
When the user asks to approve a plan before handoff, publish the plan and create a revision-bound approval card before ending the turn. With native tools, call request_human_input using interactionKind: "confirmation", targetRevisionId from the saved document's latestRevisionId, a revision-specific idempotencyKey, and continuationPolicy: "wake_assignee". Set payload.target to { type: "issue_document", key: "plan", revisionId: latestRevisionId }. Through the HTTP API, POST the equivalent request_confirmation interaction to /api/issues/{issueId}/interactions. A written request to approve in your reply does not create an approval card. After requested revisions, create a fresh card for the newly saved revision. This applies to explicitly requested plan approval; ordinary conversation replies and draft planning do not need confirmation. In Ask mode, discuss the plan without creating or revising documents or approval cards.
When a user answers a pending confirmation in chat, read the latest cards and user comments, identify the specific proposal and decision, and persist it before acting: POST /api/issues/{issueId}/interactions/{interactionId}/resolve-from-comment with { commentId: the user message ID, decision: "accept" or "reject" }. Use call_api on native runners. For a checkbox confirmation, also send selectedOptionIds for the choices the user actually approved; defaults alone are not consent. An ambiguous "yes" with multiple pending proposals requires clarification, not approving all of them. A requested revision is not acceptance. Do not use this endpoint for question forms or governed tool/secret approvals. Respect resolver-policy denials. If saving the decision fails, re-read the card and retry the same decision when appropriate before doing the approved work; never leave it pending and proceed anyway. If a card is already resolved, use its recorded outcome. Do not ask the user to clear a card after recording their answer.
Before handing off work, inspect available projects and repositories. Every task you create from this chat must belong to a suitable project. Reuse an appropriate existing project; otherwise use create_project. Consider all relevant available repositories and pass repositoryIds for one or multiple repositories when the work spans them. For existing GitHub repositories you can access that are absent from the catalog, pass their HTTPS repositoryUrls; this registers them with the project without creating remote GitHub repositories. You may combine known IDs and URLs and attach multiple repositories. The direct HTTP equivalent is POST /api/companies/{companyId}/projects with name, repositoryIds and/or repositoryUrls arrays, and an idempotencyKey. Include all selected repositories in that creation; do not combine these arrays with workspace. Never invent repository IDs or substitute inaccessible repositories. Ask when the choice is materially ambiguous or required access is missing. Non-code projects may need no repository.
Create ordinary assigned tasks, never subtasks of this conversation. Give each task a clear outcome, context, acceptance criteria, project, and appropriate assignee. Use create_task with initialPlan to copy the relevant plan into the new task before execution starts. If using the HTTP API directly, POST /api/companies/{companyId}/issues with projectId, assigneeAgentId, status: "todo", initialPlan containing the relevant plan Markdown, and an idempotencyKey; omit parentId. Putting a plan in description does not create the task's plan document. Verify the new task's plan document before claiming the handoff is complete. Preserve the original plan here. Carry forward only the remaining execution steps, not completed planning, approval, project creation, or task creation steps. Include the source conversation ID, approved plan revision ID, and accepted interaction ID so the worker can verify the recorded approval. State the approved scope and what is already done; do not claim the new plan document has its own approval. The worker should execute that authorized scope, and ask again only if scope changes or another applicable gate requires it. When splitting work, include the relevant part of the plan in each task. Create and link each task before claiming it exists.
For review or follow-up tasks, include the existing source materials the assignee needs, not just task identifiers or a rubric. Read the source task's saved documents and comments, then copy the relevant existing content into the handoff or attach resources the recipient can actually read. A new task's tools may only expose its own documents and history. Supplying existing source material is coordination, not creating the assigned deliverable.
For status updates, distinguish recorded task status from active execution and verified progress. Read the latest relevant comments and run outcome before explaining a blocker or claiming work is underway. Use the advertised API tools for another task's details when needed. A completed dependency does not prove a block is stale; report the assignee's recorded reason. Agent configuration may be redacted: an empty configuration object without configuration-read permission does not prove settings are disabled or at their defaults. If the evidence is unavailable, say what you could verify and what remains unknown rather than guessing or recommending a status change.
Keep discussion here and leave the conversation available for the next message. Link handed-off tasks in your reply; do not make this conversation blocked by their completion or wait for them. Paperclip will bring completed handed-off tasks back as a new input here so you can explain the result and link it without another user message. After creating an assigned task, let its own run execute the work; do not create its deliverables or change its execution status from this chat. Reply normally and end your turn; Paperclip manages the conversation waiting state. Do not change its status, create a review confirmation just to finish a reply, mark it complete, or poll for another reply. An accepted plan authorizes handoff to execution tasks, never implementation on this conversation. Honor normal approvals. Ask mode is non-mutating. Plan mode supports research and writing/revising the plan; hand off for execution only through the normal authorized workflow.`;
/** A reset keeps history visible, but parked input from a stopped session cannot become a new turn. */
export function currentConversationCommentCondition() {
return sql`not exists (
select 1 from ${issues} conversation_issue
join ${issueComments} conversation_boundary
on conversation_boundary.id = conversation_issue.conversation_boundary_comment_id
and conversation_boundary.company_id = conversation_issue.company_id
and conversation_boundary.issue_id = conversation_issue.id
where conversation_issue.id = ${issueComments.issueId}
and conversation_issue.company_id = ${issueComments.companyId}
and conversation_issue.conversation_agent_id is not null
and (${issueComments.createdAt}, ${issueComments.id}) < (conversation_boundary.created_at, conversation_boundary.id)
)`;
}
/** Runs under the normal issue execution lock, before any provider session is read. */
export async function prepareConversationTurn(
db: Db,
run: typeof heartbeatRuns.$inferSelect,
) {
const context = { ...(run.contextSnapshot ?? {}) };
const issueId = typeof context.issueId === "string" ? context.issueId : null;
if (!issueId) return { context, reset: false, conversation: false };
let publication: ActivityPublication | null = null;
const result = await db.transaction(async (tx) => {
const [issue] = await tx
.select()
.from(issues)
.where(and(eq(issues.id, issueId), eq(issues.companyId, run.companyId)))
.for("update");
if (!isConversation(issue))
return { context, reset: false, conversation: false };
const commentId =
typeof context.wakeCommentId === "string"
? context.wakeCommentId
: typeof context.commentId === "string"
? context.commentId
: null;
const [comment] = commentId
? await tx
.select()
.from(issueComments)
.where(
and(
eq(issueComments.id, commentId),
eq(issueComments.issueId, issueId),
eq(issueComments.companyId, run.companyId),
),
)
: [];
const reset = Boolean(
comment && comment.authorUserId && isConversationReset(comment.body),
);
let generation = issue.conversationSessionGeneration;
if (
typeof context.conversationSessionGeneration === "number" &&
context.conversationSessionGeneration !== generation
) {
throw new Error(
"Conversation session changed; this older turn cannot resume",
);
}
// The boundary lives on the command comment. A crash/retry reuses it instead of resetting twice.
if (reset && comment && comment.conversationSessionGeneration == null) {
generation += 1;
await tx
.update(issues)
.set({
conversationSessionGeneration: generation,
conversationBoundaryCommentId: comment.id,
updatedAt: new Date(),
})
.where(eq(issues.id, issue.id));
await tx
.update(issueComments)
.set({ conversationSessionGeneration: generation })
.where(eq(issueComments.id, comment.id));
// Questions from the previous session must not keep occupying the
// composer or wake the old topic, even if they survive normal comments.
const expiredQuestions = await tx.update(issueThreadInteractions).set({
status: "expired", resolvedAt: new Date(), updatedAt: new Date(),
resolvedByUserId: comment.authorUserId,
result: { version: 1, outcome: "withdrawn", reason: "New conversation session", answers: [], summaryMarkdown: null },
}).where(and(eq(issueThreadInteractions.companyId, issue.companyId),
eq(issueThreadInteractions.issueId, issue.id), eq(issueThreadInteractions.status, "pending"),
eq(issueThreadInteractions.kind, "ask_user_questions"))).returning({ id: issueThreadInteractions.id });
publication = (
await persistActivity(tx as unknown as Db, {
companyId: issue.companyId,
actorType: "system",
actorId: "conversation",
action: "issue.conversation_session_started",
entityType: "issue",
entityId: issue.id,
runId: run.id,
details: { generation, boundaryCommentId: comment.id, expiredInteractionIds: expiredQuestions.map((row) => row.id) },
})
).publication;
// Deliberately do not touch agentRuntimeState or sessions belonging to other tasks.
await tx
.delete(agentTaskSessions)
.where(
and(
eq(agentTaskSessions.companyId, issue.companyId),
eq(agentTaskSessions.agentId, issue.conversationAgentId!),
eq(agentTaskSessions.taskKey, issue.id),
),
);
}
// An answer to a historical question references its original user message.
// Keep that provenance, but do not mistake already answered later messages
// for new work. Only advance through a successful, durably answered turn in
// this same session; queued, failed, or response-less turns do not qualify.
if (context.interactionKind === "ask_user_questions" && context.interactionStatus === "answered"
&& typeof context.interactionId === "string" && typeof context.conversationReplyBoundaryCommentId !== "string") {
const [answered] = await tx.select({ id: issueThreadInteractions.id }).from(issueThreadInteractions).where(and(
eq(issueThreadInteractions.id, context.interactionId), eq(issueThreadInteractions.companyId, run.companyId),
eq(issueThreadInteractions.issueId, issueId), eq(issueThreadInteractions.kind, "ask_user_questions"),
eq(issueThreadInteractions.status, "answered"),
));
if (answered) {
const progress = await tx.select({
id: issueComments.id,
handled: sql<boolean>`exists (select 1 from ${heartbeatRuns} completed
where completed.company_id = ${run.companyId}::uuid and completed.agent_id = ${issue.conversationAgentId}::uuid
and completed.status = 'succeeded' and completed.context_snapshot->>'issueId' = ${issueId}
and completed.context_snapshot->>'conversationSessionGeneration' = ${String(generation)}
and coalesce(completed.context_snapshot->>'wakeCommentId', completed.context_snapshot->>'commentId') = issue_comments.id::text
and (exists (select 1 from issue_comments reply where reply.company_id = ${run.companyId}::uuid
and reply.issue_id = ${issueId}::uuid and reply.created_by_run_id = completed.id
and reply.author_agent_id = ${issue.conversationAgentId}::uuid and reply.deleted_at is null)
or exists (select 1 from issue_thread_interactions question where question.company_id = ${run.companyId}::uuid
and question.issue_id = ${issueId}::uuid and question.source_run_id = completed.id
and question.created_by_agent_id = ${issue.conversationAgentId}::uuid)))`,
}).from(issueComments).where(and(
eq(issueComments.companyId, run.companyId), eq(issueComments.issueId, issueId),
isNull(issueComments.deletedAt), isNull(issueComments.createdByRunId), isNull(issueComments.authorAgentId),
sql`${issueComments.authorUserId} is not null`,
comment ? sql`(${issueComments.createdAt}, ${issueComments.id}) > (select cursor.created_at, cursor.id from issue_comments cursor where cursor.id = ${comment.id}::uuid)` : sql`false`,
)).orderBy(issueComments.createdAt, issueComments.id);
let replyBoundary = commentId;
let firstUnhandled: string | null = null;
for (const candidate of progress) {
if (!candidate.handled) { firstUnhandled = candidate.id; break; }
replyBoundary = candidate.id;
}
context.conversationReplyBoundaryCommentId = replyBoundary;
// Freeze the visible history too. Include prior replies, but never pull
// an unhandled or newly arriving message into this historical answer.
const [replayThrough] = await tx.select({ id: issueComments.id }).from(issueComments).where(and(
eq(issueComments.companyId, run.companyId), eq(issueComments.issueId, issueId), isNull(issueComments.deletedAt),
firstUnhandled ? sql`(${issueComments.createdAt}, ${issueComments.id}) < (select cursor.created_at, cursor.id from issue_comments cursor where cursor.id = ${firstUnhandled}::uuid)` : undefined,
)).orderBy(desc(issueComments.createdAt), desc(issueComments.id)).limit(1);
context.conversationReplayThroughCommentId = replayThrough?.id ?? commentId;
}
}
await tx
.update(issues)
.set({
conversationState: "active",
status: "in_progress",
updatedAt: new Date(),
})
.where(eq(issues.id, issue.id));
const next = {
...context,
conversationSessionGeneration: generation,
conversationMode: true,
};
await tx
.update(heartbeatRuns)
.set({ contextSnapshot: next })
.where(eq(heartbeatRuns.id, run.id));
return { context: next, reset, conversation: true };
});
if (publication) publishActivity(publication);
return result;
}
/** Finalizers only park a turn with a durable response, interaction, or processed /new. */
export async function settleConversationTurn(
db: Db,
run: typeof heartbeatRuns.$inferSelect,
) {
if (run.status !== "succeeded") return false;
const context = run.contextSnapshot ?? {};
const issueId = typeof context.issueId === "string" ? context.issueId : null;
if (!issueId) return false;
let publication: ActivityPublication | null = null;
const settled = await db.transaction(async (tx) => {
const [issue] = await tx
.select()
.from(issues)
.where(and(eq(issues.id, issueId), eq(issues.companyId, run.companyId)))
.for("update");
if (
!isConversation(issue) ||
(issue.executionRunId && issue.executionRunId !== run.id)
)
return false;
const [response] = await tx
.select({ id: issueComments.id })
.from(issueComments)
.where(
and(
eq(issueComments.issueId, issueId),
eq(issueComments.createdByRunId, run.id),
eq(issueComments.authorAgentId, issue.conversationAgentId!),
isNull(issueComments.deletedAt),
),
)
.limit(1);
// Native question/plan waits use the durable interaction as the reply;
// their terminal prose is deliberately not materialized as a comment.
const [interaction] = !response && context.conversationReset !== true
? await tx.select({ id: issueThreadInteractions.id })
.from(issueThreadInteractions)
.where(and(
eq(issueThreadInteractions.companyId, run.companyId),
eq(issueThreadInteractions.issueId, issueId),
eq(issueThreadInteractions.sourceRunId, run.id),
eq(issueThreadInteractions.createdByAgentId, issue.conversationAgentId!),
eq(issueThreadInteractions.status, "pending"),
))
.limit(1)
: [];
if (!response && !interaction && context.conversationReset !== true) return false;
if (
context.conversationSessionGeneration !==
issue.conversationSessionGeneration
)
return false;
// Messages arriving during the reply remain actionable, including the
// crash window between their comment commit and wake enqueue.
const wakeId =
typeof context.conversationReplyBoundaryCommentId === "string"
? context.conversationReplyBoundaryCommentId
: typeof context.wakeCommentId === "string"
? context.wakeCommentId
: context.commentId;
const [wake] =
typeof wakeId === "string"
? await tx
.select()
.from(issueComments)
.where(eq(issueComments.id, wakeId))
: [];
const [pending] = wake
? await tx
.select({ id: issueComments.id })
.from(issueComments)
.where(
and(
eq(issueComments.issueId, issueId),
isNull(issueComments.deletedAt),
sql`${issueComments.authorUserId} is not null`,
sql`(${issueComments.createdAt}, ${issueComments.id}) > (select cursor.created_at, cursor.id from issue_comments cursor where cursor.id = ${wake.id}::uuid)`,
),
)
.limit(1)
: [];
const status = pending ? "in_progress" : "in_review";
const conversationState = pending ? "active" : "waiting";
if (
issue.status === status &&
issue.conversationState === conversationState
)
return true;
await tx
.update(issues)
.set({
status,
conversationState,
statusVersion: sql`${issues.statusVersion} + 1`,
completedAt: null,
cancelledAt: null,
updatedAt: new Date(),
})
.where(
and(
eq(issues.id, issueId),
sql`(${issues.executionRunId} is null or ${issues.executionRunId} = ${run.id})`,
),
);
publication = (
await persistActivity(tx as unknown as Db, {
companyId: issue.companyId,
actorType: "system",
actorId: "conversation",
action: "issue.updated",
entityType: "issue",
entityId: issue.id,
runId: run.id,
details: {
status,
conversationState,
conversationSessionGeneration: issue.conversationSessionGeneration,
},
})
).publication;
return true;
});
if (publication) publishActivity(publication);
return settled;
}
/** Fresh provider context uses only messages in this session, up to this turn. */
export async function conversationReplay(
db: Db,
companyId: string,
issueId: string,
wakeCommentId: string | null,
throughCommentId?: string,
) {
const [issue] = await db
.select()
.from(issues)
.where(and(eq(issues.id, issueId), eq(issues.companyId, companyId)));
if (!isConversation(issue)) return "";
const [boundary] = issue.conversationBoundaryCommentId
? await db
.select()
.from(issueComments)
.where(eq(issueComments.id, issue.conversationBoundaryCommentId))
: [];
const replayCutoffId = throughCommentId ?? wakeCommentId;
const [wake] = replayCutoffId
? await db
.select()
.from(issueComments)
.where(
and(
eq(issueComments.id, replayCutoffId),
eq(issueComments.issueId, issueId),
),
)
: [];
const rows = await db
.select()
.from(issueComments)
.where(
and(
eq(issueComments.companyId, companyId),
eq(issueComments.issueId, issueId),
isNull(issueComments.deletedAt),
boundary
? sql`(${issueComments.createdAt}, ${issueComments.id}) > (select cursor.created_at, cursor.id from issue_comments cursor where cursor.id = ${boundary.id}::uuid)`
: undefined,
wake
? throughCommentId
? sql`(${issueComments.createdAt}, ${issueComments.id}) <= (select cursor.created_at, cursor.id from issue_comments cursor where cursor.id = ${wake.id}::uuid)`
: sql`(${issueComments.createdAt}, ${issueComments.id}) < (select cursor.created_at, cursor.id from issue_comments cursor where cursor.id = ${wake.id}::uuid)`
: undefined,
),
)
.orderBy(desc(issueComments.createdAt), desc(issueComments.id))
.limit(40);
return rows
.reverse()
.map((row) =>
JSON.stringify({
author: row.authorAgentId ? "agent" : "user",
body: sanitizeQuarantinedCommentForHigherTrust(row).body.slice(0, 8000),
}),
)
.join("\n");
}
/** Comment rows form a durable outbox for the narrow commit-to-enqueue crash window. */
export async function undeliveredConversationComments(
db: Db,
companyId: string,
issueId: string,
) {
return db
.select()
.from(issueComments)
.where(
and(
eq(issueComments.companyId, companyId),
eq(issueComments.issueId, issueId),
isNull(issueComments.deletedAt),
sql`${issueComments.clientRequestId} is not null`,
sql`not exists (select 1 from ${agentWakeupRequests} where ${agentWakeupRequests.companyId} = ${companyId}
and ${agentWakeupRequests.idempotencyKey} = 'conversation-comment:' || ${issueComments.id}::text)`,
),
)
.orderBy(issueComments.createdAt, issueComments.id)
.limit(100);
}
/** A user's /new resumes this chat without replaying the stopped turn. */
export async function resumeConversationForReset(db: Db, comment: typeof issueComments.$inferSelect) {
if (!comment.authorUserId || !isConversationReset(comment.body)) return;
const publications: ActivityPublication[] = [];
await db.transaction(async (tx) => {
const [issue] = await tx.select().from(issues).where(and(
eq(issues.id, comment.issueId), eq(issues.companyId, comment.companyId),
)).for("update");
if (!isConversation(issue) || comment.conversationSessionGeneration != null) return;
const released = await tx.update(issueTreeHolds).set({
status: "released", releasedAt: new Date(), updatedAt: new Date(),
releasedByActorType: "user", releasedByUserId: comment.authorUserId,
releaseReason: "Resumed by /new", releaseMetadata: { commentId: comment.id, wakeAgents: false },
}).where(and(eq(issueTreeHolds.companyId, issue.companyId),
eq(issueTreeHolds.rootIssueId, issue.id), eq(issueTreeHolds.mode, "pause"),
eq(issueTreeHolds.status, "active"))).returning();
for (const hold of released) {
publications.push((await persistActivity(tx as unknown as Db, {
companyId: issue.companyId, actorType: "user", actorId: comment.authorUserId!,
action: "issue.tree_hold_released", entityType: "issue", entityId: issue.id,
details: { holdId: hold.id, mode: "pause", reason: "Resumed by /new", commentId: comment.id },
})).publication);
}
});
for (const publication of publications) publishActivity(publication);
}
/** Serialize durable outbox delivery across API servers; the normal wake queue owns execution. */
export async function deliverConversationComments(
db: Db,
issue: { id: string; companyId: string; conversationAgentId: string | null },
enqueue: (
agentId: string,
options: {
source: "on_demand";
triggerDetail: "manual";
reason: string;
idempotencyKey: string;
requestedByActorType: "user";
requestedByActorId: string | null;
payload: Record<string, unknown>;
contextSnapshot: Record<string, unknown>;
},
) => Promise<unknown>,
) {
if (!issue.conversationAgentId) return;
for (;;) {
const delivered = await db.transaction(async (tx) => {
// Contenders release their connection while waiting so concurrent sends
// cannot exhaust the pool needed by normal wake admission.
const locks = await tx.execute(
sql`select pg_try_advisory_xact_lock(hashtextextended(${"conversation-delivery:" + issue.id}, 0)) as acquired`,
);
if (!locks[0]?.acquired) return false;
for (const comment of await undeliveredConversationComments(
tx as unknown as Db,
issue.companyId,
issue.id,
)) {
await resumeConversationForReset(db, comment);
await enqueue(issue.conversationAgentId!, {
source: "on_demand",
triggerDetail: "manual",
reason: "issue_commented",
idempotencyKey: `conversation-comment:${comment.id}`,
requestedByActorType: "user",
requestedByActorId: comment.authorUserId,
payload: { issueId: issue.id, commentId: comment.id },
contextSnapshot: {
issueId: issue.id,
taskKey: issue.id,
commentId: comment.id,
wakeCommentId: comment.id,
wakeCommentIds: [comment.id],
source: "issue.comment",
},
});
}
return true;
});
if (delivered) return;
await new Promise((resolve) => setTimeout(resolve, 10));
}
}
/** Conversation turns do not need execution-task completion evidence or a continuation. */
export function conversationNativeDecision(input: {
conversation: boolean;
terminalState: unknown;
workspaceFinalizeStatus: string;
hasGovernanceGate: boolean;
priorStatus: NativeStatusDecision["toStatus"];
decision: NativeStatusDecision;
}): NativeStatusDecision {
if (
!input.conversation ||
input.terminalState !== "succeeded" ||
input.workspaceFinalizeStatus !== "succeeded" ||
input.hasGovernanceGate ||
input.decision.statusAction === "blocked" ||
input.decision.effects.some(
(effect) =>
effect.kind === "schedule_retry" ||
effect.kind === "record_finalization_error",
)
)
return input.decision;
return {
...input.decision,
statusAction: "preserve",
toStatus: input.priorStatus,
reasonCode: "conversation_turn_finished",
unblockDescriptor: null,
effects: [],
};
}