mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-10-23 09:07:46 +02:00
## Thinking Path > - Paperclip manages AI agents and their work. > - Cases keep facts, documents, and one primary task across agent handoffs. > - Each case currently needs its own procedure text. > - Agents need to reuse procedures and move cases between them without replacing the task. > - This change adds company workflow definitions with a name and Markdown prompt. > - Existing handoff and document transactions preserve authority, revisions, and recovery. > - Cases remain behind `experimental.enableCases`. ## Linked Issues or Issue Description Refs #16959. Related proposal: #3951 uses task graphs and a visual editor. This change extends existing Cases with prompt definitions and keeps its current handoff model. **Problem or motivation** Agents cannot share a reusable procedure across cases or inspect a case's movement between procedures. **Proposed solution** Add name-and-prompt workflow definitions. Adopt a prompt into the primary task's revisioned workflow document through a handoff. Keep phases as free text. **Alternatives considered** Defer graphs, workflow versions, run entities, role schemas, authoring screens, and Spec Kit integration. **Roadmap alignment** This extends the existing Cases experiment and same-task review flow. It adds no work queue or new execution engine. The maintainer approved this scope in the implementation plan. ## What Changed - Add company-scoped definition storage, shared request schemas, REST routes, and four optional Cases tools. - Accept a workflow ID at kickoff. Agent handoffs can adopt, refresh, preserve, or detach a workflow. - Capture prompt text and the document base revision at acceptance. Apply workflow, phase, and document revision together after outgoing execution settles. - Hold conflicting document edits for recovery. Preserve cancellation, replay, and restart behavior. - Show current workflow names and captured transition names/phases in Work, history, and Audit. - Update instructions, API/tool contracts, capability maps, and the isolated workflow journey. - Pin bounded workflow prompt reads to a content fingerprint; continuation conflicts on edits and can restart safely. - Remove experimental Cases/workflow/Mermaid guidance from the always-on native prompt. Extract runtime-context prompt strings into a CODEOWNERS-protected constants file while preserving the public imports. - Refresh Copilot’s pinned source identity to v57, including the extracted prompt file and retaining historical identities. ## Verification Local checks: repository `pnpm -r typecheck` and `pnpm build` pass on the prompt-extraction tree (`88222d45d8`). Full repository coverage previously completed through the supported isolated shard groups (1,082 general server suites, 161 serialized suites, and all three workspace groups). The earlier default serial run was interrupted and remains incomplete. The first sharded run retained the failures described below; targeted corrections and separate limited-concurrency reruns pass. All CI jobs, security checks, and the 5/5 Greptile review passed on `fc1bd79c28`. Fresh CI and review are pending for the prompt extraction in `88222d45d8`. Focused verification passes: real-database handoff recovery and reuse; 2,002 native-tool/API contract checks; 144 Runner catalog/discovery checks; 27 Runner context/coverage checks; 37 case/Audit UI checks; and Product E2E oracle calibration. Token gates, migration safety/numbering, module boundaries, capability maps, and generated tool/Storybook catalogs pass. The final route/context corrections pass 49 API/native-tool tests, 90 real-database handoff tests, and server typecheck; 142 Copilot installation/sidecar tests pass with the refreshed identity. Greptile’s first review found that successive prompt pages could mix definitions after an edit. The fix returns a content fingerprint, requires it for continuation, and rejects edits with 409. Strict live/catalog schemas pass (171 Runner checks). The 2,005 API/OpenAPI tests pass; the initial native regression caught compression’s weak ETag prefix, and all 23 native integration tests pass after handling it. The regression covers same-length edits and a four-byte restart window. No stored version fields or entities were added. The prompt extraction passes all 462 checks across six focused suites, including persisted-context recovery and provider transport. The first local transport attempt lacked the required debug Runner binaries (102 failures, retained); after building the normal prerequisites, all 283 tests in that suite pass without source or assertion changes. Existing saved snapshots retain their recorded prompt text, and new executions use core-only prompt v7. The extracted prompt source is now covered by both CODEOWNERS and Copilot’s source fingerprint. Live-provider evidence is separate from those simulated checks: the isolated API-key campaign `reusable-workflows-api-final-2026-10-21` passed with local code matching `a1d73b4652`. Four actual Codex API runs read the adopted task documents, moved one case A → B → A on the same task, completed normally, and passed all nine durable checks. Browser assertions verified the current workflow/phase, historical names/phases, five handoff records including terminal completion, and the completed original task. Cleanup passed. The local report remains under `tests/runner-e2e/results/reusable-workflows-api-final-2026-10-21/`; no credentials or screenshots are committed. CI initially caught an omitted route-inventory entry and a stale pinned instruction-source hash; both are corrected and separately verified. Local serialized coverage also recorded an unrelated environment-route socket disconnect and activity-route timeout; their separate 11-test and 17-test suites passed without code or timeout changes. An unchanged chunked-webhook check also passed its separate four-test rerun. The initial adapter/database workspace groups hit time and resource limits under default worker counts; complete reruns with `VITEST_MAX_WORKERS=2` pass, including all 55 database files and 211 tests. The UI/CLI groups passed 837 files and 9,442 tests in the original run. Original failures remain retained and are not regraded. Earlier failed live campaigns remain unchanged: subscription HTTP 429 before agent execution; an obsolete exact-four-row oracle that rejected the valid terminal fifth row; and a chat-marker expectation that did not account for the existing explicit-comment presentation policy. The final fixture requires terminal completion and places the marker in its authoritative comment. Positive/negative oracle tests and the fresh live campaign pass. ## Risks - The additive migration adds a table and nullable case/handoff fields. Existing rows keep null workflow metadata; no assignments are inferred. - Adoption can wait on an intervening task-document edit. Recovery must cancel the old intent and accept a new one after readback. - Shared definition edits affect future adoptions. Existing case copies keep their revisions. - The feature remains experimental. This PR does not merge or deploy the change. - Live acceptance covers native Codex before the prompt extraction; this cleanup has contract/transport verification rather than a new live-provider campaign. The refreshed Copilot identity has static compatibility evidence, not new live-provider qualification. ## Model Used OpenAI Codex, configured model ID `gpt-6-astra`, xhigh reasoning. Used terminal execution, file editing, and tool calls. The active context-window size is not exposed. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either (a) linked existing issues with `Fixes: #` / `Closes #` / `Refs #` OR (b) described the issue in-PR following the relevant issue template - [x] I have not referenced internal/instance-local Paperclip issues or links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip` URLs) - [x] My branch name describes the change (e.g. `docs/...`, `fix/...`) and contains no internal Paperclip ticket id or instance-derived details - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [ ] All Paperclip CI gates are green - [ ] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I will address all Greptile and reviewer comments before requesting merge --------- Co-authored-by: Paperclip <noreply@paperclip.ing>
296 lines
19 KiB
TypeScript
296 lines
19 KiB
TypeScript
import { z } from "zod";
|
|
import { badRequest, forbidden, unprocessable } from "../../errors.js";
|
|
import { runnerApiSensitiveResponse } from "./runner-api-sensitive-response.js";
|
|
import { runnerApiOperation, type RunnerApiOperation } from "./runner-api-catalog.js";
|
|
import { captureRunnerApiResponse, type RunnerApiResponseBody } from "./runner-api-response.js";
|
|
import { RunnerApiResponseLimitError, RunnerApiResponseCleanupError, RUNNER_API_RESPONSE_MAX_BYTES } from "./runner-api-response-limits.js";
|
|
|
|
/** Request/upload bound only. Response capture has a separate streamed limit. */
|
|
export const RUNNER_API_MAX_BYTES = 10 * 1024 * 1024;
|
|
export const RUNNER_API_INLINE_BYTES = 24 * 1024;
|
|
export const RUNNER_API_TIMEOUT_MS = 30_000;
|
|
const fileSchema = z.object({
|
|
field: z.string().min(1).max(200).optional(),
|
|
artifactId: z.string().min(1).optional(),
|
|
path: z.string().min(1).max(1000).optional(),
|
|
}).strict().refine((file) => Boolean(file.artifactId) !== Boolean(file.path), "Specify exactly one artifactId or workspace path");
|
|
export const runnerApiCallSchema = z.object({
|
|
operationId: z.string().min(1).max(500),
|
|
pathParams: z.record(z.string().max(200), z.string().max(1000)).optional(),
|
|
query: z.record(z.string(), z.unknown()).optional(),
|
|
body: z.unknown().optional(),
|
|
contentType: z.string().max(120).optional(),
|
|
files: z.array(fileSchema).max(10).optional(),
|
|
responseText: z.object({
|
|
offsetBytes: z.number().int().min(0).max(Number.MAX_SAFE_INTEGER).optional(),
|
|
limitBytes: z.number().int().min(4).max(RUNNER_API_INLINE_BYTES).optional(),
|
|
}).strict().optional(),
|
|
}).strict();
|
|
export type RunnerApiCall = z.infer<typeof runnerApiCallSchema>;
|
|
export type RunnerApiFile = z.infer<typeof fileSchema>;
|
|
export interface RunnerApiContext {
|
|
companyId: string;
|
|
issueId: string;
|
|
issueIdentifier?: string | null;
|
|
runId: string;
|
|
workMode: string;
|
|
}
|
|
export interface RunnerApiIo {
|
|
apiUrl: string;
|
|
token: string;
|
|
fetch?: typeof fetch;
|
|
/** Server-owned page size for the dedicated saved-result reader. */
|
|
responseTextPageBytes?: number;
|
|
/** Revalidate server-owned authority after asynchronous file preparation. */
|
|
beforeDispatch?(): Promise<void>;
|
|
/** Reserve before spilling. Settle completed bytes; failed captures retain their reservation. */
|
|
reserveResponseCapture?(): Promise<(completedBytes?: number, cleanupSucceeded?: boolean) => Promise<void>>;
|
|
readFile(file: RunnerApiFile): Promise<{ bytes: Buffer; filename: string; contentType: string }>;
|
|
saveResponse(bytes: RunnerApiResponseBody, contentType: string): Promise<Record<string, unknown>>;
|
|
}
|
|
|
|
export function validateRunnerApiCall(value: unknown, context: RunnerApiContext): { input: RunnerApiCall; operation: RunnerApiOperation } {
|
|
const parsed = runnerApiCallSchema.safeParse(value);
|
|
if (!parsed.success) throw badRequest("Invalid call_api arguments", { issues: parsed.error.issues });
|
|
const input = parsed.data;
|
|
const operation = runnerApiOperation(input.operationId);
|
|
if (operation.transport !== "rest") throw unprocessable("This endpoint requires its existing protocol client; call_api supports REST only");
|
|
if (input.responseText && operation.method !== "GET") throw badRequest("responseText requires a GET operation; read the saved artifact instead of repeating a mutation");
|
|
if (!operation.allowedModes.includes(context.workMode)) throw forbidden("call_api permits only reads in Ask and Plan modes; use the permitted dedicated tools");
|
|
if (input.pathParams?.companyId && input.pathParams.companyId !== context.companyId) throw forbidden("API call belongs to another company");
|
|
const contentType = (input.contentType ?? "application/json").split(";", 1)[0].trim().toLowerCase();
|
|
if (input.body !== undefined && !input.files?.length) {
|
|
const requestSchema = operation.requestBody?.content?.[contentType]?.schema as { type?: string } | undefined;
|
|
if (contentType.includes("json") && requestSchema?.type === "object" && (!input.body || typeof input.body !== "object" || Array.isArray(input.body))) {
|
|
throw badRequest("This operation requires body to be a JSON object. Pass the object directly, not a JSON-encoded string.");
|
|
}
|
|
if (contentType.includes("json") && requestSchema?.type === "array" && !Array.isArray(input.body)) {
|
|
throw badRequest("This operation requires body to be a JSON array. Pass the array directly, not a JSON-encoded string.");
|
|
}
|
|
}
|
|
return { input, operation };
|
|
}
|
|
|
|
export function runnerApiUrl(operation: RunnerApiOperation, input: RunnerApiCall, context: RunnerApiContext, apiUrl: string): URL {
|
|
const origin = new URL(apiUrl);
|
|
if (!["http:", "https:"].includes(origin.protocol) || origin.username || origin.password || origin.search || origin.hash) throw new Error("Invalid configured Paperclip API origin");
|
|
const params = { ...input.pathParams };
|
|
if (operation.path.includes("{companyId}")) params.companyId ??= context.companyId;
|
|
const names = [...operation.path.matchAll(/\{([^}]+)\}/g)].map((match) => match[1]);
|
|
for (const name of Object.keys(params)) if (!names.includes(name)) throw badRequest(`Unknown path parameter: ${name}`);
|
|
const path = operation.path.replace(/\{([^}]+)\}/g, (_, name: string) => {
|
|
const value = params[name];
|
|
if (!value || value === "." || value === ".." || /[\\/\x00-\x1f]/.test(value) || /%[0-9a-f]{2}/i.test(value)) throw badRequest(`Invalid or missing path parameter: ${name}`);
|
|
return encodeURIComponent(value);
|
|
});
|
|
const url = new URL(path, origin.origin);
|
|
if (url.origin !== origin.origin || !url.pathname.startsWith("/api/")) throw badRequest("Invalid API path");
|
|
for (const [key, value] of Object.entries(input.query ?? {})) {
|
|
if (value === undefined || value === null) continue;
|
|
const parameter = operation.parameters.find((entry) => entry.in === "query" && entry.name === key);
|
|
const values = Array.isArray(value) ? value : [value];
|
|
if (values.some((entry) => !["string", "number", "boolean"].includes(typeof entry))) throw badRequest(`Query parameter ${key} must contain scalar values`);
|
|
if (Array.isArray(value) && parameter?.explode === false) url.searchParams.set(key, values.join(","));
|
|
else for (const entry of values) url.searchParams.append(key, String(entry));
|
|
}
|
|
if (url.href.length > 16_384) throw badRequest("API URL exceeds the request limit");
|
|
return url;
|
|
}
|
|
|
|
export async function readBoundedResponse(response: Response, maxBytes = RUNNER_API_MAX_BYTES): Promise<Buffer> {
|
|
if (Number(response.headers.get("content-length")) > maxBytes) {
|
|
await response.body?.cancel();
|
|
throw unprocessable("API response exceeds the transfer limit; narrow the request");
|
|
}
|
|
const chunks: Uint8Array[] = [];
|
|
let bytes = 0;
|
|
const reader = response.body?.getReader();
|
|
if (!reader) return Buffer.alloc(0);
|
|
try {
|
|
while (true) {
|
|
const next = await reader.read();
|
|
if (next.done) break;
|
|
bytes += next.value.byteLength;
|
|
if (bytes > maxBytes) throw unprocessable("API response exceeds the transfer limit; narrow the request");
|
|
chunks.push(next.value);
|
|
}
|
|
} finally {
|
|
await reader.cancel().catch(() => {});
|
|
reader.releaseLock();
|
|
}
|
|
return Buffer.concat(chunks);
|
|
}
|
|
|
|
export async function executeRunnerApi(input: RunnerApiCall, context: RunnerApiContext, io: RunnerApiIo) {
|
|
const inlineBytes = RUNNER_API_INLINE_BYTES;
|
|
const { operation, input: validated } = validateRunnerApiCall(input, context);
|
|
input = validated;
|
|
const sensitiveResponse = runnerApiSensitiveResponse(operation.method, operation.path);
|
|
const url = runnerApiUrl(operation, input, context, io.apiUrl);
|
|
if (!io.token) throw new Error("Paperclip run authentication is unavailable");
|
|
const headers = new Headers({ Authorization: `Bearer ${io.token}`, "X-Paperclip-Run-Id": context.runId });
|
|
const textOffset = input.responseText?.offsetBytes ?? 0;
|
|
const textLimit = input.responseText?.limitBytes
|
|
?? (input.responseText ? io.responseTextPageBytes : undefined) ?? RUNNER_API_INLINE_BYTES;
|
|
const assetTextRange = operation.operationId === "GET /api/assets/{assetId}/content"
|
|
? { start: Math.max(0, textOffset - 1), end: Math.min(Number.MAX_SAFE_INTEGER, textOffset + textLimit) }
|
|
: undefined;
|
|
// One byte before the requested offset permits an EOF read; one byte after
|
|
// the page lets the decoder trim an incomplete UTF-8 code point.
|
|
if (assetTextRange) headers.set("Range", `bytes=${assetTextRange.start}-${assetTextRange.end}`);
|
|
let body: BodyInit | undefined;
|
|
const contentType = input.contentType ?? (input.files?.length ? "multipart/form-data" : "application/json");
|
|
if (/\r|\n/.test(contentType)) throw badRequest("Invalid content type");
|
|
let totalBytes = 0;
|
|
if (input.files?.length) {
|
|
if (["GET", "HEAD"].includes(operation.method)) throw badRequest("Read requests cannot upload files");
|
|
const form = new FormData();
|
|
if (input.body !== undefined && (!input.body || typeof input.body !== "object" || Array.isArray(input.body))) throw badRequest("Multipart body must be an object of form fields");
|
|
for (const [key, value] of Object.entries((input.body ?? {}) as Record<string, unknown>)) {
|
|
const text = typeof value === "string" ? value : JSON.stringify(value);
|
|
totalBytes += Buffer.byteLength(text);
|
|
form.append(key, text);
|
|
}
|
|
for (const file of input.files) {
|
|
const resolved = await io.readFile(file);
|
|
totalBytes += resolved.bytes.length;
|
|
if (totalBytes > RUNNER_API_MAX_BYTES) throw badRequest("API upload exceeds the transfer limit");
|
|
if (contentType === "multipart/form-data") form.append(file.field ?? "file", new Blob([new Uint8Array(resolved.bytes)], { type: resolved.contentType }), resolved.filename);
|
|
else {
|
|
if (input.files.length !== 1 || input.body !== undefined) throw badRequest("Raw uploads require exactly one file and no body");
|
|
body = new Uint8Array(resolved.bytes);
|
|
}
|
|
}
|
|
if (contentType === "multipart/form-data") body = form;
|
|
else headers.set("Content-Type", contentType);
|
|
} else if (input.body !== undefined) {
|
|
if (["GET", "HEAD"].includes(operation.method)) throw badRequest("Read requests cannot have a body");
|
|
body = contentType.includes("json") ? JSON.stringify(input.body) : typeof input.body === "string" ? input.body : undefined;
|
|
if (body === undefined) throw badRequest("Non-JSON request bodies must be strings");
|
|
if (Buffer.byteLength(body) > RUNNER_API_MAX_BYTES) throw badRequest("API request exceeds the transfer limit");
|
|
headers.set("Content-Type", contentType);
|
|
}
|
|
let response: Response;
|
|
let bytes: Buffer;
|
|
let captured: Awaited<ReturnType<typeof captureRunnerApiResponse>> | undefined;
|
|
let settleCapture: ((completedBytes?: number, cleanupSucceeded?: boolean) => Promise<void>) | undefined;
|
|
const disposeCapture = async (priorCleanupSucceeded = true) => {
|
|
let cleaned = false;
|
|
try { await captured?.dispose(); cleaned = priorCleanupSucceeded; }
|
|
finally { await settleCapture?.(captured?.byteSize, cleaned); }
|
|
};
|
|
const saveResponse = async (body: RunnerApiResponseBody, type: string) => {
|
|
// Small binary responses also create assets and need storage admission.
|
|
settleCapture ??= await io.reserveResponseCapture?.();
|
|
return io.saveResponse(body, type);
|
|
};
|
|
await io.beforeDispatch?.();
|
|
const controller = new AbortController();
|
|
// Bound connection setup and stalled body reads, not the total download time.
|
|
let timeout = setTimeout(() => controller.abort(), RUNNER_API_TIMEOUT_MS);
|
|
try {
|
|
response = await (io.fetch ?? fetch)(url, { method: operation.method, headers, body, redirect: "manual", signal: controller.signal });
|
|
clearTimeout(timeout);
|
|
if (sensitiveResponse) {
|
|
timeout = setTimeout(() => controller.abort(), RUNNER_API_TIMEOUT_MS);
|
|
bytes = await readBoundedResponse(response);
|
|
await io.beforeDispatch?.();
|
|
} else if (assetTextRange && response.ok) {
|
|
timeout = setTimeout(() => controller.abort(), RUNNER_API_TIMEOUT_MS);
|
|
bytes = await readBoundedResponse(response, textLimit + 2);
|
|
} else {
|
|
captured = await captureRunnerApiResponse(response, inlineBytes, controller, RUNNER_API_TIMEOUT_MS, io.beforeDispatch, {
|
|
beforeSpill: async () => { settleCapture = await io.reserveResponseCapture?.(); },
|
|
});
|
|
// Read only the requested window (+ one UTF-8 lookahead byte) into memory.
|
|
bytes = await captured.read(input.responseText && response.ok ? textOffset : 0,
|
|
input.responseText ? textLimit + 1 : inlineBytes);
|
|
}
|
|
} catch (error) {
|
|
await disposeCapture(!(error instanceof RunnerApiResponseCleanupError));
|
|
return { ok: false, status: null, operationId: operation.operationId,
|
|
error: error instanceof RunnerApiResponseLimitError ? error.code : "api_transport_failure",
|
|
...(error instanceof RunnerApiResponseLimitError ? { message: error.message, maxResponseBytes: RUNNER_API_RESPONSE_MAX_BYTES } : {}),
|
|
outcome: ["GET", "HEAD", "OPTIONS"].includes(operation.method) ? "read_failed" : "unknown", guidance: "Inspect current state before retrying a mutation; it may already have succeeded." };
|
|
} finally { clearTimeout(timeout); }
|
|
try {
|
|
const type = response.headers.get("content-type") ?? "application/octet-stream";
|
|
const mutation = !["GET", "HEAD", "OPTIONS"].includes(operation.method);
|
|
// A server can commit a write before an error response or redirect. Preserve
|
|
// the HTTP evidence, but never describe that write as definitely not applied.
|
|
const uncertain = mutation && (response.status >= 500 || response.status === 408 || (response.status >= 300 && response.status < 400));
|
|
const uncertainty = { outcome: "unknown", guidance: "Inspect current state before retrying this mutation; it may already have succeeded." };
|
|
const etag = input.responseText && response.ok ? response.headers.get("etag") : null;
|
|
const base = { ok: response.ok, status: response.status, operationId: operation.operationId, contentType: type, retryAfter: response.headers.get("retry-after"), ...(etag ? { etag } : {}), ...(uncertain ? uncertainty : {}) };
|
|
if (response.status >= 300 && response.status < 400) return { ...base, ok: false, error: "api_redirect_not_followed" };
|
|
let totalBytes = captured?.byteSize ?? bytes.length;
|
|
let baseOffset = captured && response.ok ? textOffset : 0;
|
|
if (assetTextRange && response.ok) {
|
|
const range = /^bytes (\d+)-(\d+)\/(\d+)$/.exec(response.headers.get("content-range") ?? "");
|
|
if (response.status === 200 && bytes.length === 0 && textOffset === 0) {
|
|
// An empty asset has no satisfiable byte range; its route returns 200.
|
|
} else if (response.status !== 206 || !range) {
|
|
return { ...base, ok: false, error: "response_text_invalid_range" };
|
|
} else {
|
|
const [start, end, total] = range.slice(1).map(Number);
|
|
if (![start, end, total].every(Number.isSafeInteger) || start !== assetTextRange.start
|
|
|| total < 1 || end !== Math.min(assetTextRange.end, total - 1)
|
|
|| end < start || bytes.length !== end - start + 1) {
|
|
return { ...base, ok: false, error: "response_text_invalid_range" };
|
|
}
|
|
baseOffset = start;
|
|
totalBytes = total;
|
|
}
|
|
}
|
|
if (input.responseText) {
|
|
if (!/json|^text\//i.test(type)) return { ...base, ok: false, error: "response_text_requires_text_content" };
|
|
// HTTP denials are evidence, not text pages of an authorized asset.
|
|
const offsetBytes = response.ok ? textOffset : 0;
|
|
const localOffset = offsetBytes - baseOffset;
|
|
if (offsetBytes > totalBytes || localOffset < 0 || (localOffset < bytes.length && (bytes[localOffset] & 0xc0) === 0x80)) {
|
|
return { ...base, ok: false, error: "response_text_invalid_offset", byteSize: totalBytes };
|
|
}
|
|
let end = Math.min(bytes.length, localOffset + textLimit);
|
|
// Do not cut a UTF-8 code point. The next offset always starts a whole one.
|
|
while (end < bytes.length && end > localOffset && (bytes[end] & 0xc0) === 0x80) end--;
|
|
if (end === localOffset && end < bytes.length) return { ...base, ok: false, error: "response_text_invalid_utf8" };
|
|
let data: string;
|
|
try {
|
|
data = new TextDecoder("utf-8", { fatal: true, ignoreBOM: true }).decode(bytes.subarray(localOffset, end));
|
|
} catch {
|
|
return { ...base, ok: false, error: "response_text_invalid_utf8" };
|
|
}
|
|
const nextOffset = baseOffset + end;
|
|
const artifact = captured && captured.byteSize > inlineBytes
|
|
? await saveResponse(captured.body, type) : undefined;
|
|
return { ...base, data, ...(artifact ? { artifact, guidance: "Continue reading this saved artifact with GET /api/assets/{assetId}/content and responseText.nextOffsetBytes for a stable snapshot." } : {}), responseText: { offsetBytes, nextOffsetBytes: nextOffset < totalBytes ? nextOffset : null, totalBytes } };
|
|
}
|
|
if (assetTextRange && response.ok && (totalBytes > inlineBytes || !/json|^text\//i.test(type))) {
|
|
// This content is already an authorized, stable asset. Return its existing
|
|
// reference after a bounded preview; never download and duplicate it.
|
|
const assetId = input.pathParams!.assetId;
|
|
const sha256 = /^"([a-f0-9]{64})"$/.exec(response.headers.get("etag") ?? "")?.[1];
|
|
return { ...base, artifact: { artifactId: assetId, url: `/api/assets/${assetId}/content`, contentType: type, byteSize: totalBytes, ...(sha256 ? { sha256 } : {}) },
|
|
byteSize: totalBytes, preview: /json|^text\//i.test(type) ? bytes.subarray(0, 2000).toString("utf8") : null,
|
|
guidance: "Read this asset with responseText: { offsetBytes: 0 }. Continue with responseText.nextOffsetBytes until null." };
|
|
}
|
|
if (!totalBytes) return { ...base, data: null };
|
|
if (!sensitiveResponse && (totalBytes > inlineBytes || !/json|^text\//i.test(type))) {
|
|
return { ...base, artifact: await saveResponse(captured?.body ?? bytes, type), byteSize: totalBytes, preview: /json|^text\//i.test(type) ? bytes.subarray(0, 2000).toString("utf8") : null,
|
|
...(/json|^text\//i.test(type) ? { guidance: "Read the saved artifact with GET /api/assets/{assetId}/content and responseText: { offsetBytes: 0 }. Continue with responseText.nextOffsetBytes until null. Do not repeat a mutation to read its response." } : {}) };
|
|
}
|
|
if (sensitiveResponse && !/json|^text\//i.test(type)) return { ...base, ok: false, error: "credential_response_requires_text_content" };
|
|
const text = bytes.toString("utf8");
|
|
if (/json/i.test(type)) {
|
|
try { return { ...base, data: JSON.parse(text) as unknown }; }
|
|
catch { return { ...base, ok: false, error: "invalid_json_response", data: text, ...(mutation ? uncertainty : {}) }; }
|
|
}
|
|
return { ...base, data: text };
|
|
} catch (error) {
|
|
if (!(error instanceof RunnerApiResponseLimitError)) throw error;
|
|
return { ok: false, status: response.status, operationId: operation.operationId, error: error.code, message: error.message,
|
|
outcome: ["GET", "HEAD", "OPTIONS"].includes(operation.method) ? "read_failed" : "unknown",
|
|
guidance: "Inspect current state before retrying a mutation; it may already have succeeded." };
|
|
} finally { await disposeCapture(); }
|
|
}
|