mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-10-23 00:53:38 +02:00
## Thinking Path > - Paperclip is the open source app people use to manage AI agents for work > - Governed MCP access spans contracts, runtime enforcement, adapters, UI surfaces, and operator verification > - The parity reference PR #9534 is too large for effective automated or human review > - The feature therefore needs a linear stack whose individual diffs stay below the 100-file review limit > - This pull request is split 7/8 and focuses on Apps/Gateways UI and feature-flagged activation > - The benefit is a standalone, testable review boundary while preserving byte-for-byte parity at the top of the stack ## Linked Issues or Issue Description - Related parity reference: #9534 - Problem: The standalone UI foundation needs feature-flagged routes, navigation, app detail flows, gateways, Storybook scenarios, and QA configuration. - Proposed solution: Adds Apps/Gateways pages and components, navigation/route activation, remaining page integrations, Storybook stories, and QA Vite configuration. - Alternatives considered: keeping #9534 as one 403-file review, or rewriting the feature to manufacture seams; both were rejected in favor of path extraction plus compile-driven boundary moves. - Roadmap alignment: this advances the existing governed MCP/tool-access work already represented by #9534; it does not introduce a separate roadmap initiative. - Stack position: base branch is `pap10341-split/06-ui-tools-foundation`. - Merge policy: merge bottom-up, in order, only after the complete eight-PR stack has been reviewed and the top-of-stack parity gate remains empty. - Requested review: UXDesigner sanity pass on Apps/Gateways flows and flag-off behavior; Greptile on every PR. ## What Changed - Adds Apps/Gateways pages and components, navigation/route activation, remaining page integrations, Storybook stories, and QA Vite configuration. - Keeps this PR below 100 changed files and independently typecheckable. - Preserves the final tree from #9534 when combined with the other seven stack levels. ## Verification - `pnpm typecheck` - `pnpm check:token-gates` — all gates clean - Focused UI Vitest run with `NODE_ENV=test` — 17 files, 147 tests passed ## Risks - Navigation or flag regressions could expose incomplete experiences; activation remains controlled by existing experimental settings. - Stack risk: merging out of order can expose incomplete layers; mitigate by following the documented bottom-up merge policy. - Parity risk: later edits to an intermediate branch can drift from #9534; mitigate by re-running the empty top-of-stack diff before merge. > For core feature work, check [`ROADMAP.md`](ROADMAP.md) first and discuss it in `#dev` before opening the PR. Feature PRs that overlap with planned core work may need to be redirected — check the roadmap first. See `CONTRIBUTING.md`. ## Model Used - OpenAI Codex, exact model ID `gpt-5.4`; runtime-managed context window; medium reasoning with repository, shell, Git, GitHub CLI, and code-execution tools enabled. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either (a) linked existing issues with `Fixes: #` / `Closes #` / `Refs #` OR (b) described the issue in-PR following the relevant issue template - [x] Internal references are omitted except the execution-plan link explicitly required for this coordinated split stack - [x] My branch name describes the change and contains no internal Paperclip ticket id or instance-derived details - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [ ] All Paperclip CI gates are green - [ ] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I will address all Greptile and reviewer comments before requesting merge ## Stack Coordination - Internal execution plan: [PAP-13874](/PAP/issues/PAP-13874#document-plan) - Parity reference: #9534 - Stack: #9556 → #9557 → #9558 → #9559 → #9560 → #9561 → #9562 → #9563 - Merge bottom-up only after full-stack review and an empty parity diff at #9563. ## UI Evidence QA captured these from the live Garden MCP split stack at 1440px and verified clean rendering:    --------- Co-authored-by: Paperclip <noreply@paperclip.ing>
232 lines
8.4 KiB
TypeScript
232 lines
8.4 KiB
TypeScript
// @vitest-environment jsdom
|
|
|
|
import { flushSync } from "react-dom";
|
|
import { createRoot } from "react-dom/client";
|
|
import { QueryClient, QueryClientProvider } from "@tanstack/react-query";
|
|
import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";
|
|
import { AppDetailSidebar } from "./AppConnectionSidebar";
|
|
|
|
const sidebarNavItemMock = vi.hoisted(() => vi.fn());
|
|
const currentPath = vi.hoisted(() => ({ value: "/apps/conn-1/permissions" }));
|
|
const mockToolsApi = vi.hoisted(() => ({
|
|
getConnection: vi.fn(),
|
|
listApplications: vi.fn(),
|
|
listConnections: vi.fn(),
|
|
listGallery: vi.fn(),
|
|
listAppsAttention: vi.fn(),
|
|
}));
|
|
|
|
vi.mock("@/lib/router", () => ({
|
|
Link: ({
|
|
children,
|
|
to,
|
|
onClick,
|
|
className,
|
|
}: {
|
|
children: React.ReactNode;
|
|
to: string;
|
|
onClick?: () => void;
|
|
className?: string;
|
|
}) => (
|
|
<a href={to} onClick={onClick} className={className}>
|
|
{children}
|
|
</a>
|
|
),
|
|
}));
|
|
|
|
vi.mock("@/context/CompanyContext", () => ({
|
|
useCompany: () => ({
|
|
selectedCompanyId: "company-1",
|
|
}),
|
|
}));
|
|
|
|
vi.mock("@/context/SidebarContext", () => ({
|
|
useSidebar: () => ({
|
|
isMobile: false,
|
|
setSidebarOpen: vi.fn(),
|
|
}),
|
|
}));
|
|
|
|
vi.mock("@/api/tools", () => ({
|
|
toolsApi: mockToolsApi,
|
|
}));
|
|
|
|
vi.mock("./SidebarNavItem", () => ({
|
|
SidebarNavItem: (props: {
|
|
to: string;
|
|
label: string;
|
|
end?: boolean;
|
|
badge?: number;
|
|
badgeTone?: string;
|
|
badgeLabel?: string;
|
|
}) => {
|
|
sidebarNavItemMock(props);
|
|
return (
|
|
<div data-to={props.to} data-active={props.to === currentPath.value ? "true" : "false"}>
|
|
{props.label}
|
|
{props.badge ? ` ${props.badge}` : ""}
|
|
</div>
|
|
);
|
|
},
|
|
}));
|
|
|
|
// eslint-disable-next-line @typescript-eslint/no-explicit-any
|
|
(globalThis as any).IS_REACT_ACT_ENVIRONMENT = true;
|
|
|
|
async function act(callback: () => void | Promise<void>) {
|
|
let result: void | Promise<void> = undefined;
|
|
flushSync(() => {
|
|
result = callback();
|
|
});
|
|
await result;
|
|
}
|
|
|
|
async function flushReact() {
|
|
for (let i = 0; i < 3; i += 1) {
|
|
await act(async () => {
|
|
await Promise.resolve();
|
|
await new Promise((resolve) => window.setTimeout(resolve, 0));
|
|
});
|
|
}
|
|
}
|
|
|
|
function connection(overrides: Record<string, unknown> = {}) {
|
|
return {
|
|
id: "conn-1",
|
|
name: "GitHub",
|
|
transport: "remote_http",
|
|
status: "active",
|
|
healthStatus: "healthy",
|
|
enabled: true,
|
|
config: {},
|
|
transportConfig: {},
|
|
...overrides,
|
|
};
|
|
}
|
|
|
|
describe("AppConnectionSidebar", () => {
|
|
let container: HTMLDivElement;
|
|
let root: ReturnType<typeof createRoot>;
|
|
|
|
beforeEach(() => {
|
|
container = document.createElement("div");
|
|
document.body.appendChild(container);
|
|
currentPath.value = "/apps/conn-1/permissions";
|
|
mockToolsApi.getConnection.mockResolvedValue(connection());
|
|
mockToolsApi.listApplications.mockResolvedValue({
|
|
applications: [{
|
|
id: "app-1",
|
|
applicationKey: "github",
|
|
name: "GitHub",
|
|
description: "GitHub app",
|
|
status: "active",
|
|
}],
|
|
});
|
|
mockToolsApi.listConnections.mockResolvedValue({
|
|
connections: [connection({ id: "archived-1", applicationId: "app-1", status: "archived" })],
|
|
});
|
|
mockToolsApi.listGallery.mockResolvedValue({
|
|
apps: [{ key: "github", name: "GitHub", logoUrl: "https://example.test/github.png" }],
|
|
});
|
|
mockToolsApi.listAppsAttention.mockResolvedValue({
|
|
apps: [
|
|
{
|
|
connection: connection(),
|
|
pendingActionRequestCount: 2,
|
|
quarantinedCatalogEntryCount: 3,
|
|
healthNeedsAttention: false,
|
|
reasons: ["pending_action_requests", "quarantined_catalog_entries"],
|
|
},
|
|
],
|
|
totals: {},
|
|
});
|
|
});
|
|
|
|
afterEach(() => {
|
|
flushSync(() => root?.unmount());
|
|
container.remove();
|
|
document.body.innerHTML = "";
|
|
vi.clearAllMocks();
|
|
});
|
|
|
|
async function renderSidebar(element = <AppDetailSidebar kind="connection" connectionId="conn-1" />) {
|
|
const queryClient = new QueryClient({
|
|
defaultOptions: { queries: { retry: false } },
|
|
});
|
|
root = createRoot(container);
|
|
await act(async () => {
|
|
root.render(
|
|
<QueryClientProvider client={queryClient}>
|
|
{element}
|
|
</QueryClientProvider>,
|
|
);
|
|
});
|
|
await flushReact();
|
|
}
|
|
|
|
it("renders a back link and the connected app tabs (including Test)", async () => {
|
|
await renderSidebar();
|
|
|
|
expect(container.querySelector('a[href="/apps"]')?.textContent).toContain("All apps");
|
|
expect(container.textContent).toContain("GitHub");
|
|
expect(container.querySelectorAll("[data-to]").length).toBe(6);
|
|
expect(sidebarNavItemMock).toHaveBeenCalledWith(expect.objectContaining({ to: "/apps/conn-1/setup", label: "Setup", end: true }));
|
|
expect(sidebarNavItemMock).toHaveBeenCalledWith(expect.objectContaining({ to: "/apps/conn-1/review", label: "Review", badge: 5, badgeTone: "danger" }));
|
|
expect(sidebarNavItemMock).toHaveBeenCalledWith(expect.objectContaining({ to: "/apps/conn-1/permissions", label: "Permissions", end: true }));
|
|
expect(sidebarNavItemMock).toHaveBeenCalledWith(expect.objectContaining({ to: "/apps/conn-1/test", label: "Test", end: true }));
|
|
expect(sidebarNavItemMock).toHaveBeenCalledWith(expect.objectContaining({ to: "/apps/conn-1/activity", label: "Activity", end: true }));
|
|
expect(sidebarNavItemMock).toHaveBeenCalledWith(expect.objectContaining({ to: "/apps/conn-1/advanced", label: "Advanced", end: true }));
|
|
});
|
|
|
|
it("marks the current tab active through the nav item target", async () => {
|
|
await renderSidebar();
|
|
|
|
expect(container.querySelector('[data-to="/apps/conn-1/permissions"]')?.getAttribute("data-active")).toBe("true");
|
|
expect(container.querySelector('[data-to="/apps/conn-1/setup"]')?.getAttribute("data-active")).toBe("false");
|
|
});
|
|
|
|
it("renders application-mode tabs under the not-connected app route", async () => {
|
|
currentPath.value = "/apps/app/app-1/review";
|
|
|
|
await renderSidebar(<AppDetailSidebar kind="application" applicationId="app-1" />);
|
|
|
|
expect(container.querySelector('a[href="/apps"]')?.textContent).toContain("All apps");
|
|
expect(container.textContent).toContain("GitHub");
|
|
expect(mockToolsApi.getConnection).not.toHaveBeenCalled();
|
|
expect(sidebarNavItemMock).toHaveBeenCalledWith(expect.objectContaining({ to: "/apps/app/app-1/setup", label: "Setup", end: true }));
|
|
expect(sidebarNavItemMock).toHaveBeenCalledWith(expect.objectContaining({ to: "/apps/app/app-1/review", label: "Review", end: true }));
|
|
expect(sidebarNavItemMock).toHaveBeenCalledWith(expect.objectContaining({ to: "/apps/app/app-1/permissions", label: "Permissions", end: true }));
|
|
expect(sidebarNavItemMock).toHaveBeenCalledWith(expect.objectContaining({ to: "/apps/app/app-1/activity", label: "Activity", end: true }));
|
|
expect(sidebarNavItemMock).toHaveBeenCalledWith(expect.objectContaining({ to: "/apps/app/app-1/advanced", label: "Advanced", end: true }));
|
|
expect(container.querySelector('[data-to="/apps/app/app-1/review"]')?.getAttribute("data-active")).toBe("true");
|
|
// The Test tab needs a live connection, so it is hidden in application mode.
|
|
expect(container.querySelector('[data-to="/apps/app/app-1/test"]')).toBeNull();
|
|
expect(container.querySelectorAll("[data-to]").length).toBe(5);
|
|
});
|
|
|
|
it("keeps rendering a connection sidebar when its connection is unavailable", async () => {
|
|
mockToolsApi.getConnection.mockResolvedValue(undefined);
|
|
mockToolsApi.listGallery.mockResolvedValue({ apps: [] });
|
|
mockToolsApi.listAppsAttention.mockResolvedValue({ apps: [], totals: {} });
|
|
|
|
await renderSidebar();
|
|
|
|
expect(container.textContent).toContain("App");
|
|
expect(container.querySelector('a[href="/apps"]')?.textContent).toContain("All apps");
|
|
expect(container.querySelectorAll("[data-to]").length).toBe(6);
|
|
});
|
|
|
|
it("keeps rendering an application sidebar when its application is unavailable", async () => {
|
|
mockToolsApi.listApplications.mockResolvedValue({ applications: [] });
|
|
mockToolsApi.listConnections.mockResolvedValue({ connections: [] });
|
|
mockToolsApi.listGallery.mockResolvedValue({ apps: [] });
|
|
mockToolsApi.listAppsAttention.mockResolvedValue({ apps: [], totals: {} });
|
|
|
|
await renderSidebar(<AppDetailSidebar kind="application" applicationId="missing-app" />);
|
|
|
|
expect(container.textContent).toContain("App");
|
|
expect(container.querySelector('a[href="/apps"]')?.textContent).toContain("All apps");
|
|
expect(container.querySelectorAll("[data-to]").length).toBe(5);
|
|
});
|
|
});
|