mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-11-18 22:54:22 +01:00
## Thinking Path > - Paperclip is the open source app people use to manage AI agents for work > - Agent runs on Daytona start with a lease acquisition in the Daytona plugin > - When the host cannot reach Daytona, the Daytona SDK raises a connection error that has no HTTP status and no errno > - The host only retries a lease failure that carries structured evidence, so this failure became `setup_failed` and the task waited for a person to press Retry > - This pull request makes the plugin report the SDK connection error as a closed transport code that the host already retries > - The benefit is that a short network blip during sandbox startup no longer needs a Retry click ## Linked Issues or Issue Description **What happened?** In a restart-chaos wave (201 tasks, 6 graceful release swaps), the host could not resolve or reach Daytona for about 12 minutes. One task needed a Retry click. Its only run failed with `setup_failed` (`lease_acquire_failed`) and the message `Failed to acquire lease for environment "Daytona warm ..." (sandbox): read EADDRNOTAVAIL`. Automatic recovery did not continue the task because `setup_failed` is not a transient setup code. The task stayed failed for about 100 minutes until the grader pressed Retry. **Expected behavior** A lease acquisition that fails because the provider could not be reached is retried automatically with the bounded bootstrap budget, as `environment_provider_unavailable`. A person never needs to press Retry for a network blip. **Steps to reproduce** 1. Use the Daytona provider. 2. Make a Daytona API call during lease setup fail at the transport level (no HTTP response), for example with `read EADDRNOTAVAIL` or `getaddrinfo ENOTFOUND`. 3. See that the run fails with `setup_failed` and the task shows Retry. **Paperclip version or commit** master `ca34aca777` (wave) and `02ee538be9`. Root cause: the pinned `@daytonaio/sdk` converts an Axios transport error into `DaytonaConnectionError` (or `DaytonaConnectionTimeoutError`). It keeps neither the errno nor the cause. The worker RPC therefore sent no provider diagnostic, and `readTransientLeaseAcquisitionFailure` returned `null`. ## What Changed - The Daytona plugin wraps a `DaytonaConnectionError` from lease acquisition in an error with code `CONNECTION_FAILED`, and a `DaytonaConnectionTimeoutError` with code `ETIMEDOUT`. The message is unchanged. It reads the SDK class name only, never message text. - The plugin SDK closed diagnostic set accepts `CONNECTION_FAILED`, so the code crosses the worker RPC. - The host treats `CONNECTION_FAILED` as a transient connection failure. The run becomes `environment_provider_unavailable` and uses the existing bounded bootstrap retry (30 s, 60 s) and the automatic-run brake. - Refreshed `tests/runner-e2e/source-sdk-public-inputs.json` for the changed SDK file. ## Verification - Red/green: with the source change removed, the new plugin tests (`reports a DaytonaConnectionError during setup as a transient transport failure`, timeout variant) and the new host tests (`treats errno CONNECTION_FAILED as transient`, `retries a provider connection failure reported across the worker RPC`) fail. With the change, they pass. - `cd packages/plugins/sandbox-providers/daytona && npx vitest run` (637 passed). - `npx vitest run server/src/services/environment-provider-unavailable-error.test.ts packages/plugins/sdk/tests/environment-acquire-error.test.ts` (66 passed). - `pnpm typecheck` in the Daytona plugin passes. - `pnpm verify` asks for broad CI coverage because the SDK input registry changed. CI supplies that coverage. ## Risks - Low risk. A wrong Daytona API URL also produces `DaytonaConnectionError`. It now gets two bounded retries (about 90 s) before the same Retry state as before. - The retries count toward the automatic-run brake, so a long outage cannot multiply run starts across the company. - A create that timed out on the client keeps its existing creation-cleanup envelope. The retry is a new creation attempt with its own identity. ## Model Used - Claude Opus 5.5 (`claude-opus-5-5`), Anthropic, with tool use and code execution in Claude Code. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either (a) linked existing issues with `Fixes: #` / `Closes #` / `Refs #` OR (b) described the issue in-PR following the relevant issue template - [x] I have not referenced internal/instance-local Paperclip issues or links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip` URLs) - [x] My branch name describes the change (e.g. `docs/...`, `fix/...`) and contains no internal Paperclip ticket id or instance-derived details - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [ ] All Paperclip CI gates are green - [ ] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I will address all Greptile and reviewer comments before requesting merge 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>