mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-10-13 04:02:28 +02:00
## Thinking Path > - Paperclip manages AI agents and their work. > - AI Connections separate account access from models and harnesses. > - A pool must act as one connection while retaining each task’s account. > - Core must enforce member access and preserve session and recovery rules. > - A plugin supplies rotation policy without receiving credentials. > - This change adds durable routing and native connector setup and management. ## Linked Issues or Issue Description **Subsystem affected** AI Connections, Connectors, plugins, run dispatch, and session compatibility. **Problem or motivation** Operators need to rotate new tasks across saved accounts while each task keeps its account and session. Pool setup must fit the existing connector catalog and account workflow. **Proposed solution** Add an experimental router binding, a capability-gated plugin hook, and transactional task pins. Plugins declare native pooled connectors through `aiConnectionRouter`. Core hosts the existing-account picker, ordering step, and account settings. Related usage contract: #14936. Companion private plugin: https://github.com/paperclipai/paperclip-cloud/pull/643. **Roadmap alignment** This extends Apps and AI Connections. Core supplies generic enforcement and native connector UI; the private plugin owns rotation and quota policy. The prior duplicate search found no matching router implementation. ## What Changed - Add a router binding without changing existing concrete bindings. Keep the instance flag and new pools disabled by default. Require manual operator configuration. Show no routing toggle in Experimental settings on either open-source or Cloud installs, even after routing is enabled. - Persist company-scoped pools, one shared cursor per pool, and pins keyed by company, pool, agent, and task. Commit pins and cursor advances together with revision checks and bounded retries. Persist run-ID affinity before allocation. - Pass only authorized metadata and normalized usage to plugins. Core retains credential handling, member access checks, runtime qualification, and recovery evidence. Probe outside locks with a shared 15-second budget and freshness cache. - Resolve routing before credential preparation and backend selection. Preserve pins through turns, session resets, removed members, and quota waits. Retain admitted recovery after disable or uninstall. - Separate credential session epochs from token generations. Verified refresh preserves the epoch; reconnect and manual replacement change it. Include the credential slot ID in session and usage-cache identity, so reconnecting an indexed legacy account invalidates its old session even when both epochs are zero. - Validate pool member installations before accepting saved-agent bindings and recheck compatibility when the harness changes. Install only authorized members in the new-agent transaction and record their IDs in local activity. Pool membership cannot install a restricted shared connection. - Preserve pool bindings when agents hire teammates through either creation API or native caller runtime inheritance. Block stale manager credential references; retain explicit child authentication precedence and reject incompatible inherited pools. - Add native connector registration through plugin metadata. Reuse the Connectors catalog, setup header, account header, sidebar, dialogs, and usage display. Setup selects and orders saved connections. Advanced settings hold usage rules and member runtime defaults. New-account setup opens in another tab. - Use revision-checked pool archival from the Connectors catalog and account page. Keep task pins, cursors, recovery evidence, and underlying connections. Reject ordinary connection updates or removals that bypass pool revisions. - Add pool selectors, composer models, override notes, quota status, run details, activity records, and local run-log records. Keep session-adoption copy minimal. - Show **Used by** below the pool connections. List current company agents with shared avatars and profile links. Include paused agents; exclude terminated agents and agents using another pool. - Add Core stories for the generic connector workflow and runtime surfaces. Cloud stories reuse these production routes and tokens through a preview-only alias. ## Verification - Final head `73cb953bca30ed83e4505dd820edd9b5edffd28b`: full workspace `pnpm -r typecheck`, `pnpm build`, and `pnpm check:token-gates` pass locally. - All 422 focused connector/settings/shared-contract/migration tests and all 156 database-backed AI connection, hiring, reconnect, and durable-routing cases pass (69 hiring cases rerun after the final auth-precedence fix). The merged shared contract retains connection instructions and pool metadata. The pool migration is generated at sequence 0299 after the latest upstream migrations; this PR makes no lockfile changes. - All four full-app Playwright tests pass on the final head after a cold restart and migration, against the installed private plugin and isolated database, with no route or pool-API mocks. They cover hidden routing controls after manual opt-in, native pool creation, ordering, membership edits, rename, paused defaults, enabling/save/refresh persistence, stale edits, cancellation/removal, preserved underlying accounts, unavailable routers, and Used by avatars and profile links. Exact command: `PAPERCLIP_CONNECTION_POOL_E2E=1 AI_CONNECTIONS_TEST_COMPANY_ID=a37b9625-5ecf-4e29-8081-04df3d6e7d6f AI_CONNECTIONS_TEST_URL=http://127.0.0.1:3108 pnpm exec playwright test --config tests/ai-connections-app/playwright.config.ts connection-pools.spec.ts`. - [Native setup, ordering, and management screenshots](https://github.com/paperclipai/paperclip/pull/14967#issuecomment-6006976278) address the review follow-up. [Earlier selector, quota, and run-detail screenshots](https://github.com/paperclipai/paperclip/pull/14967#issuecomment-5971537316) show the runtime surfaces. Core previews: `pnpm --filter @paperclipai/ui storybook`, then **Connectors / Pool host** or **AI Connections / Connection pools**. Cloud owns its host-backed plugin stories; both repositories’ Operator Setup Required story assertions pass. - Live acceptance used OpenAI/Codex and Anthropic/Claude ACPX, resumed both exact sessions after restart, preserved pinned accounts through explicit reset and controlled quota deferral/recovery, and committed only two allocations across fourteen runs. A later UI-created task test again rotated OpenAI then Anthropic and resumed OpenAI through follow-up/restart/quota recovery. That later Anthropic execution was blocked by its saved OAuth token expiring (provider 401). No live usage probes ran. - The full local `pnpm test:run` was attempted earlier and did not complete because of macOS embedded PostgreSQL bootstrap/shared-memory failures and the 40,000-file Git fixture timeout. The focused database suites above now pass; full-suite verification is provided by the split CI lanes. The preceding CI run had one runtime readiness timeout; it passes locally both alone and inside the larger runtime suite. That larger local suite also encountered an embedded PostgreSQL setup failure and two macOS temporary-path alias assertions; those two assertions pass with canonical TMPDIR=/private/tmp. All final-head CI checks are terminal green, including full general/serialized server suites, Runner checks, browser E2E shards, canary verification, build, and typecheck. Greptile is 5/5 on that exact head with no unresolved threads. ## Risks - The migration adds routing tables and a credential epoch column. Install the private plugin only with the compatible Core contract. - Routing and each pool require opt-in. Production distribution and fleet defaults remain unchanged. - Unknown usage stays eligible. Known pinned exhaustion waits; revoked access requires operator repair. - Legacy adapters require compatible members. Runner model and effort overrides remain limited by qualified backend support. ## Model Used OpenAI GPT-6 through Codex, with reasoning, repository editing, code execution, and browser testing. The exact deployment model ID and context window are not exposed in this session. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either (a) linked existing issues with `Fixes:` / `Closes:` / `Refs:` OR (b) described the issue in-PR following the relevant issue template - [x] I have not referenced internal/instance-local Paperclip issues or links - [x] My branch name describes the change and contains no internal Paperclip ticket id or instance-derived details - [x] I have run tests locally and they pass (targeted suites; full-suite limitations are reported above) - [x] I have added or updated tests where applicable - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] All Paperclip CI gates are green - [x] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I will address all Greptile and reviewer comments before requesting merge --------- Co-authored-by: Paperclip <noreply@paperclip.ing>
237 lines
8.1 KiB
TypeScript
237 lines
8.1 KiB
TypeScript
import { useMemo } from "react";
|
|
import { Clock } from "lucide-react";
|
|
import type { Issue } from "@paperclipai/shared";
|
|
|
|
import { Button } from "@/components/ui/button";
|
|
import { InlineBanner } from "@/components/InlineBanner";
|
|
import { cn } from "@/lib/utils";
|
|
import {
|
|
deriveMonitorState,
|
|
formatMonitorAbsolute,
|
|
formatMonitorEta,
|
|
useMonitorCountdown,
|
|
type DerivedMonitorState,
|
|
type MonitorDisplayState,
|
|
} from "@/lib/issue-monitor";
|
|
|
|
/** Matches the `Date | string` inputs accepted by the issue-monitor helpers. */
|
|
type MonitorDate = Date | string;
|
|
|
|
/**
|
|
* States in which the waiting-monitor surfaces (top banner + composer strip)
|
|
* are shown. `cleared` and `none` hide both surfaces entirely — see
|
|
* wireframe 04 (PAP-14557).
|
|
*/
|
|
const WAITING_STATES: readonly MonitorDisplayState[] = [
|
|
"scheduled",
|
|
"retrying",
|
|
"due-now",
|
|
"overdue",
|
|
];
|
|
|
|
export function isWaitingMonitorState(state: MonitorDisplayState): boolean {
|
|
return WAITING_STATES.includes(state);
|
|
}
|
|
|
|
export function hasVisibleMonitorSurface(issue: Issue): boolean {
|
|
const derived = deriveMonitorState(issue);
|
|
return isWaitingMonitorState(derived.state) && derived.nextCheckAt !== null;
|
|
}
|
|
|
|
export interface MonitorSurfaceCopy {
|
|
/** Prominent lead for the top banner, e.g. "Waiting on monitor — resumes in 2h 12m". */
|
|
bannerTitle: string;
|
|
/** Prominent lead for the composer strip, e.g. "Resumes in 2h 12m". */
|
|
stripTitle: string;
|
|
/** Muted detail line for the banner (absolute time carries a "(your time)" hint). */
|
|
bannerMeta: string[];
|
|
/** Muted detail line for the composer strip. */
|
|
stripMeta: string[];
|
|
/** `warning` (amber) once overdue, `info` (blue) while still on schedule. */
|
|
tone: "info" | "warning";
|
|
workspaceWait?: boolean;
|
|
}
|
|
|
|
function capitalize(value: string): string {
|
|
return value.length === 0 ? value : `${value.charAt(0).toUpperCase()}${value.slice(1)}`;
|
|
}
|
|
|
|
/**
|
|
* Pure copy builder shared by the banner and the composer strip so both
|
|
* surfaces render one consistent copy system (see wireframe 04). Kept free of
|
|
* hooks/`Date.now()` so it is deterministic under test.
|
|
*/
|
|
export function buildMonitorSurfaceCopy(
|
|
derived: DerivedMonitorState,
|
|
now: MonitorDate,
|
|
scheduledRetryReason?: string | null,
|
|
): MonitorSurfaceCopy | null {
|
|
if (!isWaitingMonitorState(derived.state) || !derived.nextCheckAt) return null;
|
|
|
|
if (derived.source === "scheduled-retry" && scheduledRetryReason === "workspace_busy") {
|
|
return {
|
|
bannerTitle: "Waiting for workspace",
|
|
stripTitle: "Waiting for workspace",
|
|
bannerMeta: ["Another task is using this workspace. Work starts automatically when it is available."],
|
|
stripMeta: ["Work starts automatically when the workspace is available."],
|
|
tone: "info",
|
|
workspaceWait: true,
|
|
};
|
|
}
|
|
|
|
const eta = formatMonitorEta(derived.nextCheckAt, now); // "in 2h 12m" | "due now" | "overdue by 18m"
|
|
const absolute = formatMonitorAbsolute(derived.nextCheckAt, {}, now); // local time, e.g. "Today, 4:08 PM"
|
|
if (derived.source === "scheduled-retry" && scheduledRetryReason === "ai_connection_pool_wait") {
|
|
return {
|
|
bannerTitle: "Pool exhausted",
|
|
stripTitle: "Pool exhausted",
|
|
bannerMeta: [`Usage recheck ${eta} · ${absolute} (your time)`, "Tasks with a selected account keep it while waiting. Work resumes when usage permits."],
|
|
stripMeta: [`Usage recheck ${eta} · ${absolute}`, "Tasks with a selected account keep it while waiting."],
|
|
tone: "info",
|
|
};
|
|
}
|
|
|
|
const isScheduledRetryOnly = derived.source === "scheduled-retry";
|
|
|
|
let bannerTitle: string;
|
|
let stripTitle: string;
|
|
let statusHint: string | null = null;
|
|
switch (derived.state) {
|
|
case "scheduled":
|
|
case "retrying":
|
|
bannerTitle = isScheduledRetryOnly ? `Agent resumes ${eta}` : `Waiting on monitor — resumes ${eta}`;
|
|
stripTitle = `Resumes ${eta}`;
|
|
break;
|
|
case "due-now":
|
|
bannerTitle = isScheduledRetryOnly ? "Agent retry due now" : "Waiting on monitor — due now";
|
|
stripTitle = "Due now";
|
|
statusHint = "Checking momentarily…";
|
|
break;
|
|
case "overdue":
|
|
default:
|
|
bannerTitle = isScheduledRetryOnly ? `Agent retry ${eta}` : `Waiting on monitor — ${eta}`;
|
|
stripTitle = capitalize(eta);
|
|
statusHint = "Fires on next tick";
|
|
break;
|
|
}
|
|
|
|
const attemptLabel = derived.attemptCount >= 1 ? `Attempt ${derived.attemptCount}` : null;
|
|
const serviceLabel = derived.serviceName ? `Watching: ${derived.serviceName}` : null;
|
|
|
|
const bannerMeta = [statusHint, `${absolute} (your time)`, attemptLabel, serviceLabel].filter(
|
|
(piece): piece is string => Boolean(piece),
|
|
);
|
|
const stripMeta = [statusHint, absolute, attemptLabel, serviceLabel].filter(
|
|
(piece): piece is string => Boolean(piece),
|
|
);
|
|
|
|
return {
|
|
bannerTitle,
|
|
stripTitle,
|
|
bannerMeta,
|
|
stripMeta,
|
|
tone: derived.state === "overdue" ? "warning" : "info",
|
|
};
|
|
}
|
|
|
|
function useMonitorSurfaceCopy(issue: Issue): MonitorSurfaceCopy | null {
|
|
// `nextCheckAt` is stable for a given issue; derive once to seed the ticking
|
|
// countdown cadence, then re-derive against the live clock so the surfaces
|
|
// roll scheduled → due → overdue on their own.
|
|
const nextCheckAt = useMemo(() => deriveMonitorState(issue).nextCheckAt, [issue]);
|
|
const now = useMonitorCountdown(nextCheckAt);
|
|
return useMemo(() => buildMonitorSurfaceCopy(deriveMonitorState(issue, now), now, issue.scheduledRetry?.scheduledRetryReason), [issue, now]);
|
|
}
|
|
|
|
function CheckNowButton({
|
|
onCheckNow,
|
|
checkingNow,
|
|
}: {
|
|
onCheckNow: () => void;
|
|
checkingNow: boolean;
|
|
}) {
|
|
return (
|
|
<Button
|
|
type="button"
|
|
variant="outline"
|
|
size="sm"
|
|
className="shrink-0 shadow-none"
|
|
onClick={onCheckNow}
|
|
disabled={checkingNow}
|
|
>
|
|
{checkingNow ? "Checking…" : "Check now"}
|
|
</Button>
|
|
);
|
|
}
|
|
|
|
export interface IssueMonitorSurfaceProps {
|
|
issue: Issue;
|
|
onCheckNow?: (() => void) | null;
|
|
checkingNow?: boolean;
|
|
}
|
|
|
|
/**
|
|
* Pinned banner rendered between the issue title and description while a
|
|
* monitor is waiting. Replaces the description-area "Monitor scheduled" card
|
|
* for the waiting state (PAP-14557 decision 1) — the two never render at once.
|
|
*/
|
|
export function IssueMonitorBanner({
|
|
issue,
|
|
onCheckNow = null,
|
|
checkingNow = false,
|
|
}: IssueMonitorSurfaceProps) {
|
|
const copy = useMonitorSurfaceCopy(issue);
|
|
if (!copy) return null;
|
|
|
|
return (
|
|
<InlineBanner
|
|
tone={copy.tone}
|
|
icon={Clock}
|
|
title={copy.bannerTitle}
|
|
className="my-3"
|
|
actions={onCheckNow && !copy.workspaceWait ? <CheckNowButton onCheckNow={onCheckNow} checkingNow={checkingNow} /> : null}
|
|
>
|
|
<span>{copy.bannerMeta.join(" · ")}</span>
|
|
</InlineBanner>
|
|
);
|
|
}
|
|
|
|
/**
|
|
* Slim, inline (not sticky) strip anchored directly above the reply composer.
|
|
* Mirrors the banner's monitor state and reminds the reader that replying wakes
|
|
* the agent early (PAP-14557 decisions 2 + wireframe 02).
|
|
*/
|
|
export function IssueMonitorComposerStrip({
|
|
issue,
|
|
onCheckNow = null,
|
|
checkingNow = false,
|
|
className,
|
|
}: IssueMonitorSurfaceProps & { className?: string }) {
|
|
const copy = useMonitorSurfaceCopy(issue);
|
|
if (!copy) return null;
|
|
|
|
return (
|
|
<div
|
|
role="note"
|
|
data-testid="issue-monitor-composer-strip"
|
|
className={cn("rounded-lg border border-border bg-muted/30 px-3 py-2", className)}
|
|
>
|
|
<div className="flex flex-col gap-2 sm:flex-row sm:items-center sm:justify-between">
|
|
<div className="flex min-w-0 items-start gap-2">
|
|
<Clock className="mt-0.5 h-4 w-4 shrink-0 text-muted-foreground" aria-hidden="true" />
|
|
<div className="min-w-0">
|
|
<div className="text-sm font-medium text-foreground">{copy.stripTitle}</div>
|
|
<div className="text-xs text-muted-foreground">{copy.stripMeta.join(" · ")}</div>
|
|
</div>
|
|
</div>
|
|
{onCheckNow && !copy.workspaceWait ? <CheckNowButton onCheckNow={onCheckNow} checkingNow={checkingNow} /> : null}
|
|
</div>
|
|
<p className="mt-1.5 text-xs text-muted-foreground">
|
|
{copy.workspaceWait
|
|
? "You can keep sending instructions while the agent waits."
|
|
: "Sending a reply wakes the agent now — before the scheduled check."}
|
|
</p>
|
|
</div>
|
|
);
|
|
}
|