mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-10-25 02:26:12 +02:00
## Thinking Path > - Paperclip operators spend most of their time scanning the board, inbox, sidebar, and local dev status surfaces > - Small UI and dev-ops frictions make repeated operator workflows feel slower than they need to be > - The working branch contained several independent quality-of-life improvements mixed with larger cloud work > - Grouping these smaller UI/dev-ops changes together keeps review overhead reasonable without merging them into feature PRs > - This pull request collects the operator-facing QoL polish into one standalone branch > - The benefit is a cleaner board navigation and local dev recovery experience without depending on cloud upstream sync ## What Changed - Relaxed forced 44px touch targets for small inline widgets. - Fixed mobile mention menu scrolling and sidebar spacing on touch/mobile layouts. - Synced inbox hover state with j/k selection. - Moved plugin sidebar entries into the Work section. - Added manual dev-server restart action/banner behavior. - Logged plugin bridge 502 causes for better diagnosis. ## Verification - `pnpm install --frozen-lockfile --ignore-scripts` - `pnpm --filter @paperclipai/plugin-sdk build` - `pnpm exec vitest run ui/src/components/MarkdownEditor.test.tsx ui/src/components/Sidebar.test.tsx ui/src/components/SidebarProjects.test.tsx ui/src/pages/Inbox.test.tsx ui/src/components/DevRestartBanner.test.tsx server/src/__tests__/dev-server-status.test.ts server/src/__tests__/health-dev-server-token.test.ts server/src/__tests__/plugin-routes-authz.test.ts` initially failed only because plugin SDK `dist` was not built in the fresh worktree. - Rerun after build: `pnpm exec vitest run server/src/__tests__/plugin-routes-authz.test.ts` passed. - The remaining targeted UI/dev-server tests passed on the first post-install run. ## Visual Evidence - Sidebar layout and plugin Work section:  - Inbox/task row selection and hover-state surface:  - Dev restart banner desktop:  - Dev restart banner mobile:  ## Risks - Mostly UI/dev ergonomics with low data risk. - Sidebar and inbox changes touch frequently used navigation surfaces, so visual review on desktop/mobile is still useful. > For core feature work, check [`ROADMAP.md`](ROADMAP.md) first and discuss it in `#dev` before opening the PR. Feature PRs that overlap with planned core work may need to be redirected — check the roadmap first. See `CONTRIBUTING.md`. ## Model Used - OpenAI Codex, GPT-5-based coding agent with local shell/git/tool use. Exact hosted model ID and context-window size are not exposed by the local Paperclip adapter runtime. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] If this change affects the UI, I have included before/after screenshots - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] I will address all Greptile and reviewer comments before requesting merge --------- Co-authored-by: Paperclip <noreply@paperclip.ing>
206 lines
6.5 KiB
TypeScript
206 lines
6.5 KiB
TypeScript
import { existsSync, mkdtempSync, readFileSync, rmSync, writeFileSync } from "node:fs";
|
|
import os from "node:os";
|
|
import path from "node:path";
|
|
import express from "express";
|
|
import request from "supertest";
|
|
import { afterEach, describe, expect, it, vi } from "vitest";
|
|
import type { Db } from "@paperclipai/db";
|
|
import { healthRoutes } from "../routes/health.js";
|
|
|
|
const tempDirs: string[] = [];
|
|
|
|
function createDevServerStatusFile(payload: unknown) {
|
|
const dir = mkdtempSync(path.join(os.tmpdir(), "paperclip-health-dev-server-"));
|
|
tempDirs.push(dir);
|
|
const filePath = path.join(dir, "dev-server-status.json");
|
|
writeFileSync(filePath, `${JSON.stringify(payload)}\n`, "utf8");
|
|
return filePath;
|
|
}
|
|
|
|
afterEach(() => {
|
|
for (const dir of tempDirs.splice(0)) {
|
|
rmSync(dir, { recursive: true, force: true });
|
|
}
|
|
});
|
|
|
|
describe("GET /health dev-server supervisor access", () => {
|
|
it("exposes dev-server metadata to the supervising dev runner in authenticated mode", async () => {
|
|
const previousFile = process.env.PAPERCLIP_DEV_SERVER_STATUS_FILE;
|
|
const previousToken = process.env.PAPERCLIP_DEV_SERVER_STATUS_TOKEN;
|
|
process.env.PAPERCLIP_DEV_SERVER_STATUS_FILE = createDevServerStatusFile({
|
|
dirty: true,
|
|
lastChangedAt: "2026-03-20T12:00:00.000Z",
|
|
changedPathCount: 1,
|
|
changedPathsSample: ["server/src/routes/health.ts"],
|
|
pendingMigrations: [],
|
|
lastRestartAt: "2026-03-20T11:30:00.000Z",
|
|
});
|
|
process.env.PAPERCLIP_DEV_SERVER_STATUS_TOKEN = "dev-runner-token";
|
|
|
|
let selectCall = 0;
|
|
const db = {
|
|
execute: vi.fn().mockResolvedValue([{ "?column?": 1 }]),
|
|
select: vi.fn(() => {
|
|
selectCall += 1;
|
|
if (selectCall === 1) {
|
|
return {
|
|
from: vi.fn(() => ({
|
|
where: vi.fn().mockResolvedValue([{ count: 1 }]),
|
|
})),
|
|
};
|
|
}
|
|
if (selectCall === 2) {
|
|
return {
|
|
from: vi.fn(() => ({
|
|
where: vi.fn().mockResolvedValue([
|
|
{
|
|
id: "settings-1",
|
|
general: {},
|
|
experimental: { autoRestartDevServerWhenIdle: true },
|
|
createdAt: new Date("2026-03-20T11:00:00.000Z"),
|
|
updatedAt: new Date("2026-03-20T11:00:00.000Z"),
|
|
},
|
|
]),
|
|
})),
|
|
};
|
|
}
|
|
return {
|
|
from: vi.fn(() => ({
|
|
where: vi.fn().mockResolvedValue([{ count: 0 }]),
|
|
})),
|
|
};
|
|
}),
|
|
} as unknown as Db;
|
|
|
|
try {
|
|
const app = express();
|
|
app.use((req, _res, next) => {
|
|
(req as any).actor = { type: "none", source: "none" };
|
|
next();
|
|
});
|
|
app.use(
|
|
"/health",
|
|
healthRoutes(db, {
|
|
deploymentMode: "authenticated",
|
|
deploymentExposure: "private",
|
|
authReady: true,
|
|
companyDeletionEnabled: true,
|
|
}),
|
|
);
|
|
|
|
const res = await request(app)
|
|
.get("/health")
|
|
.set("X-Paperclip-Dev-Server-Status-Token", "dev-runner-token");
|
|
|
|
expect(res.status).toBe(200);
|
|
expect(res.body).toEqual({
|
|
status: "ok",
|
|
deploymentMode: "authenticated",
|
|
bootstrapStatus: "ready",
|
|
bootstrapInviteActive: false,
|
|
devServer: {
|
|
enabled: true,
|
|
restartRequired: true,
|
|
reason: "backend_changes",
|
|
lastChangedAt: "2026-03-20T12:00:00.000Z",
|
|
changedPathCount: 1,
|
|
changedPathsSample: ["server/src/routes/health.ts"],
|
|
pendingMigrations: [],
|
|
autoRestartEnabled: true,
|
|
activeRunCount: 0,
|
|
waitingForIdle: false,
|
|
lastRestartAt: "2026-03-20T11:30:00.000Z",
|
|
},
|
|
});
|
|
} finally {
|
|
if (previousFile === undefined) {
|
|
delete process.env.PAPERCLIP_DEV_SERVER_STATUS_FILE;
|
|
} else {
|
|
process.env.PAPERCLIP_DEV_SERVER_STATUS_FILE = previousFile;
|
|
}
|
|
if (previousToken === undefined) {
|
|
delete process.env.PAPERCLIP_DEV_SERVER_STATUS_TOKEN;
|
|
} else {
|
|
process.env.PAPERCLIP_DEV_SERVER_STATUS_TOKEN = previousToken;
|
|
}
|
|
}
|
|
});
|
|
});
|
|
|
|
describe("POST /health/dev-server/restart", () => {
|
|
it("records a manual restart request for the dev runner", async () => {
|
|
const previousFile = process.env.PAPERCLIP_DEV_SERVER_STATUS_FILE;
|
|
process.env.PAPERCLIP_DEV_SERVER_STATUS_FILE = createDevServerStatusFile({
|
|
dirty: true,
|
|
lastChangedAt: "2026-03-20T12:00:00.000Z",
|
|
changedPathCount: 1,
|
|
changedPathsSample: ["server/src/routes/health.ts"],
|
|
pendingMigrations: [],
|
|
lastRestartAt: "2026-03-20T11:30:00.000Z",
|
|
});
|
|
|
|
try {
|
|
const app = express();
|
|
app.use("/health", healthRoutes(undefined));
|
|
|
|
const res = await request(app).post("/health/dev-server/restart");
|
|
|
|
expect(res.status).toBe(202);
|
|
expect(res.body).toEqual({ status: "restart_requested" });
|
|
|
|
const requestPath = path.join(
|
|
path.dirname(process.env.PAPERCLIP_DEV_SERVER_STATUS_FILE),
|
|
"dev-server-restart-request.json",
|
|
);
|
|
expect(existsSync(requestPath)).toBe(true);
|
|
expect(JSON.parse(readFileSync(requestPath, "utf8"))).toMatchObject({
|
|
reason: "manual_restart_now",
|
|
});
|
|
} finally {
|
|
if (previousFile === undefined) {
|
|
delete process.env.PAPERCLIP_DEV_SERVER_STATUS_FILE;
|
|
} else {
|
|
process.env.PAPERCLIP_DEV_SERVER_STATUS_FILE = previousFile;
|
|
}
|
|
}
|
|
});
|
|
|
|
it("rejects unauthenticated manual restarts in authenticated mode", async () => {
|
|
const previousFile = process.env.PAPERCLIP_DEV_SERVER_STATUS_FILE;
|
|
process.env.PAPERCLIP_DEV_SERVER_STATUS_FILE = createDevServerStatusFile({
|
|
dirty: true,
|
|
changedPathCount: 1,
|
|
changedPathsSample: ["server/src/routes/health.ts"],
|
|
pendingMigrations: [],
|
|
});
|
|
|
|
try {
|
|
const app = express();
|
|
app.use((req, _res, next) => {
|
|
(req as any).actor = { type: "none", source: "none" };
|
|
next();
|
|
});
|
|
app.use(
|
|
"/health",
|
|
healthRoutes(undefined, {
|
|
deploymentMode: "authenticated",
|
|
deploymentExposure: "private",
|
|
authReady: true,
|
|
companyDeletionEnabled: true,
|
|
}),
|
|
);
|
|
|
|
const res = await request(app).post("/health/dev-server/restart");
|
|
|
|
expect(res.status).toBe(403);
|
|
expect(res.body).toEqual({ error: "board_access_required" });
|
|
} finally {
|
|
if (previousFile === undefined) {
|
|
delete process.env.PAPERCLIP_DEV_SERVER_STATUS_FILE;
|
|
} else {
|
|
process.env.PAPERCLIP_DEV_SERVER_STATUS_FILE = previousFile;
|
|
}
|
|
}
|
|
});
|
|
});
|