mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-10-29 12:59:13 +01:00
## Thinking Path > - Paperclip is the open source app people use to manage AI agents for work > - Issues use `in_review` to request a final decision from an authorized writer > - The server rejected an assignee agent that tried to close its own review, even when the issue had no independent-review rule > - This rejection stopped the default agent workflow and did not represent the configured execution-stage rules > - Paperclip needs an open default and explicit issue-level constraints for teams that require an independent or human verdict > - This pull request removes the unconditional rejection and adds `anyone`, `not_creator`, and `human_only` review policies > - The benefit is a working default path with opt-in, authenticated verdict controls ## Linked Issues or Issue Description Refs #10635, #4429, and #10671. The related public work covers execution-stage independence, self-approval fallback behavior, and durable review paths. This change is distinct. It controls who can resolve an issue review verdict. It keeps configured execution stages active. ## What Changed - Added a nullable `review_policy` issue column. Null has the same meaning as `anyone`. The migration does not backfill existing issues. - Added shared create, update, response, and compact issue contracts for `anyone`, `not_creator`, and `human_only`. - Removed the unconditional agent self-approval rejection for `in_review` issues. - Added one reusable verdict-actor check for terminal status changes and pending interaction accept or reject actions. - Used the authenticated principal type for `human_only`. Agent keys and run tokens remain agent principals. - Used the latest transition into `in_review` to identify the requester for `not_creator`. - Added actionable 403 responses that name the policy, the allowed actor, and the next step. - Kept the configured execution-stage transition and signoff behavior. - Added focused contract, helper, status-route, interaction-route, and execution-stage regression tests. - Updated the implementation specification for the new issue field. ## Verification - `pnpm exec vitest run packages/shared/src/validators/issue.test.ts server/src/__tests__/issue-review-policy.test.ts server/src/__tests__/issue-stalled-review-decision-routes.test.ts --reporter=dot` passed: 42 tests. - `pnpm --filter @paperclipai/shared typecheck` passed. - `pnpm --filter @paperclipai/db typecheck` passed, including migration numbering and safety checks. - `pnpm --filter @paperclipai/server typecheck` passed. - `pnpm run typecheck:build-gaps` passed across server, CLI, plugin SDK/examples, plugin wiki, and UI. - `git diff --check origin/master...HEAD` passed. - SecurityEngineer review approved the authenticated-principal checks and accepted policy-relaxation tradeoff with no required changes. - Greptile reviewed the latest head at 5/5 with zero inline comments or follow-ups. - The latest-head GitHub rollup passed build, typecheck, server/workspace tests, serialized suites, canary, e2e, and external security checks. ## Risks - The migration adds one nullable text column. It has no default and no backfill. - `not_creator` reads the latest recorded transition into `in_review`. It denies the verdict when it cannot identify the requester. - Agents can change or relax `reviewPolicy` when they have issue write access. This is intentional for this issue-level control. - Null and `anyone` do not add a database query to the verdict path. - Configured execution-stage checks still run after the issue-level policy check. > This work aligns with the completed "Agent Reviews and Approvals" and "Enforced Outcomes" roadmap items. It does not add a new roadmap capability. ## Model Used - OpenAI Codex, GPT-5. The exact deployment ID and context-window size are not exposed to the agent. The run used reasoning, repository tools, code execution, and GitHub CLI access. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either (a) linked existing issues with `Fixes: #` / `Closes #` / `Refs #` OR (b) described the issue in-PR following the relevant issue template - [x] I have not referenced internal/instance-local Paperclip issues or links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip` URLs) - [x] My branch name describes the change (e.g. `docs/...`, `fix/...`) and contains no internal Paperclip ticket id or instance-derived details - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] All Paperclip CI gates are green - [x] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I will address all Greptile and reviewer comments before requesting merge --------- Co-authored-by: Paperclip <noreply@paperclip.ing>
179 lines
7.7 KiB
TypeScript
179 lines
7.7 KiB
TypeScript
export { companyService } from "./companies.js";
|
|
export { companyArtifactsService } from "./company-artifacts.js";
|
|
export { companySearchService } from "./company-search.js";
|
|
export { companySearchExtractService } from "./company-search-extract.js";
|
|
export { feedbackService } from "./feedback.js";
|
|
export { companySkillService } from "./company-skills.js";
|
|
export { companySkillPolicyService, normalizeSkillPolicySourceType } from "./company-skill-policy.js";
|
|
export { folderService } from "./folders.js";
|
|
export { agentService, deduplicateAgentName } from "./agents.js";
|
|
export {
|
|
builtInAgentService,
|
|
deriveBuiltInAgentStatus,
|
|
getBuiltInAgentDefinition,
|
|
listBuiltInAgentDefinitions,
|
|
reconcileBuiltInAgentsOnStartup,
|
|
validateBuiltInAgentDefinitions,
|
|
type BuiltInAgentDefinition,
|
|
type BuiltInManagedResourceState,
|
|
type BuiltInManagedResourceStockStatus,
|
|
type BuiltInAgentState,
|
|
type BuiltInAgentStatus,
|
|
} from "./built-in-agents.js";
|
|
export { agentInstructionsService, syncInstructionsBundleConfigFromFilePath } from "./agent-instructions.js";
|
|
export { assetService } from "./assets.js";
|
|
export { documentService, extractLegacyPlanBody } from "./documents.js";
|
|
export { statusCardService } from "./status-cards.js";
|
|
export { finalizeStatusCardsForStalledGeneration } from "./status-card-finalization.js";
|
|
export { documentAnnotationService } from "./document-annotations.js";
|
|
export {
|
|
ISSUE_CONTINUATION_SUMMARY_DOCUMENT_KEY,
|
|
buildContinuationSummaryMarkdown,
|
|
getIssueContinuationSummaryDocument,
|
|
refreshIssueContinuationSummary,
|
|
} from "./issue-continuation-summary.js";
|
|
export { projectService } from "./projects.js";
|
|
export {
|
|
clampIssueListLimit,
|
|
ISSUE_LIST_DEFAULT_LIMIT,
|
|
ISSUE_LIST_MAX_LIMIT,
|
|
issueService,
|
|
type IssueFilters,
|
|
} from "./issues.js";
|
|
export { issueThreadInteractionService } from "./issue-thread-interactions.js";
|
|
export {
|
|
assertIssueReviewVerdictActorAllowed,
|
|
type IssueReviewVerdictActor,
|
|
} from "./issue-review-policy.js";
|
|
export { issueTreeControlService } from "./issue-tree-control.js";
|
|
export { issueApprovalService } from "./issue-approvals.js";
|
|
export { issueReferenceService } from "./issue-references.js";
|
|
export { issueRecoveryActionService } from "./issue-recovery-actions.js";
|
|
export {
|
|
stalledReviewDecisionService,
|
|
type DecideStalledReviewInput,
|
|
type StalledReviewDecisionActor,
|
|
} from "./stalled-review-decisions.js";
|
|
export { taskWatchdogService } from "./task-watchdogs.js";
|
|
export {
|
|
issueIsInTaskWatchdogSubtree,
|
|
resolveTaskWatchdogMutationScope,
|
|
taskWatchdogScopeAllowsIssueMutation,
|
|
} from "./task-watchdog-scope.js";
|
|
export {
|
|
createExternalObjectDetectorRegistry,
|
|
createExternalObjectResolverRegistry,
|
|
externalObjectService,
|
|
type ExternalObjectDetector,
|
|
type ExternalObjectResolver,
|
|
type ExternalObjectResolveResult,
|
|
type ExternalObjectResolverSnapshot,
|
|
} from "./external-objects.js";
|
|
export { goalService } from "./goals.js";
|
|
export { activityService, type ActivityFilters } from "./activity.js";
|
|
export { workTimelineService, normalizeTimelineWindow } from "./work-timeline.js";
|
|
export { attentionService } from "./attention.js";
|
|
export { captureDecisionSnapshot, decisionTrainingService } from "./decision-training.js";
|
|
export { decisionService } from "./decisions.js";
|
|
export { decisionRetentionService } from "./decision-retention.js";
|
|
export type {
|
|
WorkTimelineActor,
|
|
WorkTimelineEdge,
|
|
WorkTimelineEvent,
|
|
WorkTimelineQuery,
|
|
WorkTimelineResult,
|
|
WorkTimelineSpan,
|
|
} from "./work-timeline.js";
|
|
export { approvalService } from "./approvals.js";
|
|
export { budgetService } from "./budgets.js";
|
|
export { secretService } from "./secrets.js";
|
|
export { createRunSecretRedactionRegistry } from "./run-secret-redaction.js";
|
|
export { createSecretProposalsService } from "./secret-proposals.js";
|
|
export { googleSheetsRobotEmailFromEnv, toolAccessService } from "./tool-access.js";
|
|
export { smokeLabService } from "./smoke-lab.js";
|
|
export { backfillLegacyToolOAuthTokens } from "./tool-oauth-legacy-backfill.js";
|
|
export { toolAccessPolicyService } from "./tool-access-policy.js";
|
|
export { routineService } from "./routines.js";
|
|
export { costService } from "./costs.js";
|
|
export { financeService } from "./finance.js";
|
|
export { heartbeatService, resolveHeartbeatSchedulingSuppression } from "./heartbeat.js";
|
|
export {
|
|
productivityReviewService,
|
|
PRODUCTIVITY_REVIEW_ORIGIN_KIND,
|
|
} from "./productivity-review.js";
|
|
export { classifyIssueGraphLiveness, type IssueLivenessFinding } from "./recovery/index.js";
|
|
export { dashboardService } from "./dashboard.js";
|
|
export { sidebarBadgeService } from "./sidebar-badges.js";
|
|
export { sidebarPreferenceService } from "./sidebar-preferences.js";
|
|
export { resourceMembershipService, type ResourceMembershipPolicyHook } from "./resource-memberships.js";
|
|
export { inboxDismissalService } from "./inbox-dismissals.js";
|
|
export { accessService } from "./access.js";
|
|
export {
|
|
backfillPrincipalAccessCompatibility,
|
|
ensureHumanRoleDefaultGrants,
|
|
insertMissingPrincipalGrants,
|
|
type PrincipalAccessCompatibilityBackfillStats,
|
|
} from "./principal-access-compatibility.js";
|
|
export { authorizationService } from "./authorization.js";
|
|
export { inboxAgentPolicyService } from "./inbox-agent-policy.js";
|
|
export type {
|
|
AuthorizationAction,
|
|
AuthorizationActor,
|
|
AuthorizationDecision,
|
|
AuthorizationResource,
|
|
} from "./authorization.js";
|
|
export { boardAuthService } from "./board-auth.js";
|
|
export { instanceSettingsService, applyManagedExperimentalOverlay } from "./instance-settings.js";
|
|
export {
|
|
getManagedInstanceConfig,
|
|
managedFeatureKeySet,
|
|
parseManagedConfigEnv,
|
|
MANAGED_CONFIG_ENV_KEY,
|
|
type ManagedEnvironmentSpec,
|
|
type ManagedInstanceConfig,
|
|
} from "./managed-config.js";
|
|
export { bootstrapExecutionPolicyFromEnv } from "./execution-policy-bootstrap.js";
|
|
export { applyManagedEnvironments } from "./managed-environments.js";
|
|
export { buildExportFidelityReport, collectExportFidelityCounts } from "./export-fidelity.js";
|
|
export { companyPortabilityService } from "./company-portability.js";
|
|
export { teamsCatalogService } from "./teams-catalog.js";
|
|
export { environmentService } from "./environments.js";
|
|
export {
|
|
applyCustomImageTemplateToSandboxConfig,
|
|
fingerprintEnvironmentSandboxProviderConfig,
|
|
} from "./environment-custom-image-runtime.js";
|
|
export {
|
|
environmentCustomImageService,
|
|
} from "./environment-custom-images.js";
|
|
export {
|
|
environmentCustomImageTerminalConnectionRegistry,
|
|
environmentCustomImageTerminalSessionStore,
|
|
EnvironmentCustomImageTerminalConnectionRegistry,
|
|
EnvironmentCustomImageTerminalSessionStore,
|
|
parseCustomImageSetupSshCommand,
|
|
type EnvironmentCustomImageTerminalConnectionClose,
|
|
type EnvironmentCustomImageTerminalSessionRecord,
|
|
type MintedEnvironmentCustomImageTerminalSession,
|
|
type ParsedCustomImageSetupSshCommand,
|
|
} from "./environment-custom-image-terminal-sessions.js";
|
|
export { executionWorkspaceService } from "./execution-workspaces.js";
|
|
export { workspaceOperationService } from "./workspace-operations.js";
|
|
export { workspaceFileResourceService } from "./workspace-file-resources.js";
|
|
export { workProductService } from "./work-products.js";
|
|
export {
|
|
logActivity,
|
|
persistActivity,
|
|
publishActivity,
|
|
type ActivityPublication,
|
|
type LogActivityInput,
|
|
} from "./activity-log.js";
|
|
export { summarySlotService, SUMMARIZER_BUILT_IN_KEY } from "./summary-slots.js";
|
|
export { notifyHireApproved, type NotifyHireApprovedInput } from "./hire-hook.js";
|
|
export { publishLiveEvent, subscribeCompanyLiveEvents } from "./live-events.js";
|
|
export {
|
|
reconcileCodexLocalManagedHomesOnStartup,
|
|
type CodexAuthReconciliationSummary,
|
|
} from "./codex-auth-reconciliation.js";
|
|
export { reconcilePersistedRuntimeServicesOnStartup, restartDesiredRuntimeServicesOnStartup } from "./workspace-runtime.js";
|
|
export { createStorageServiceFromConfig, getStorageService } from "../storage/index.js";
|