mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-10-21 16:27:18 +02:00
## Thinking Path > - Paperclip is the open source app people use to manage AI agents for work. > - Agent runs often need provider credentials, API tokens, and other environment-bound secrets. > - Company-level secrets work for shared credentials, but they do not model values that should differ by human operator. > - Without a user-scoped model, a run can dispatch without knowing whether the responsible human has supplied the needed value. > - Paperclip also needs run attribution to make those user-scoped runtime checks deterministic and auditable. > - This pull request adds user-specific secret definitions, per-user values, environment bindings, responsible-user attribution, and runtime resolution gates. > - The benefit is that teams can define the secret once, let each user provide their own value, and block runs before dispatch when required user secrets or active definitions are unavailable. ## Linked Issues or Issue Description Refs #224 Refs #6057 This PR implements user-specific secret support as a core secret-management capability rather than a one-off adapter setting. It is related to existing public work on company secrets UI and runtime secret refs, but is distinct because the value is owned by the responsible user and resolved at run dispatch time. Related PR search before opening found existing secrets work such as #1550, #8256, #8614, #8634, and #8647; none of those add the full user-secret definition/value/runtime gate covered here. ## What Changed - Added user-secret definitions and per-user "My secrets" values, keeping stored values out of access metadata. - Added `user_secret_ref` environment bindings and UI affordances to pick them alongside existing secret refs. - Added responsible-user runtime resolution so user-secret refs resolve against the human responsible for the run. - Added pre-dispatch missing-secret gates so runs fail before adapter dispatch when required user values are absent or definitions are inactive. - Added low-trust allowlist hardening for user-secret runtime access. - Added issue, routine, run, and agent API key responsible-user attribution and fail-closed dispatch behavior when attribution cannot be resolved. - Added denial-copy mapping so responsible-user authorization failures surface as actionable run outcomes instead of opaque setup failures. - Added OpenAPI documentation for the user-secret routes. - Rebases cleanly on current `master`; migrations were renumbered incrementally as `0128_user_specific_secrets`, `0129_agent_api_key_responsible_user`, and `0130_run_responsible_user_invariant` after upstream `0126`/`0127` migrations. - Removed previously committed local design screenshots so the PR contains code/docs/tests only. ## Verification - PASS: PR head `2527febd106bcf3ca264ca0da7fca491084192d6` is based on `paperclipai/paperclip:master`. - PASS: `git diff --check` - PASS: `git diff --name-only public/master...HEAD | rg '^(pnpm-lock\\.yaml|\\.github/workflows/|screenshots/)' || true` produced no files. - PASS: migration journal audit confirmed unique indexes through `130` with tail entries `0126_issue_comment_derived_attribution`, `0127_environment_custom_images_instance_scoped`, `0128_user_specific_secrets`, `0129_agent_api_key_responsible_user`, and `0130_run_responsible_user_invariant`. - PASS: `pnpm --filter @paperclipai/ui typecheck` - PASS: `pnpm --filter @paperclipai/server typecheck` - PASS: `pnpm --filter @paperclipai/server exec vitest run src/__tests__/heartbeat-responsible-user-invariant.test.ts` - PASS: `pnpm --filter @paperclipai/server exec vitest run src/__tests__/heartbeat-active-run-output-watchdog.test.ts src/__tests__/heartbeat-stale-queue-invalidation.test.ts src/__tests__/heartbeat-workspace-finalize-branch.test.ts src/__tests__/issue-monitor-scheduler.test.ts` - PASS: `pnpm --filter @paperclipai/server exec vitest run src/__tests__/heartbeat-comment-wake-batching.test.ts src/__tests__/heartbeat-retry-scheduling.test.ts src/__tests__/heartbeat-accepted-plan-workspace-refresh.test.ts src/__tests__/heartbeat-plugin-environment.test.ts` - PASS: `pnpm --filter @paperclipai/server exec vitest run src/__tests__/low-trust-red-team-routes.test.ts` - PASS: `pnpm --filter @paperclipai/server exec vitest run src/__tests__/secrets-service.test.ts` (55 tests) - PASS: `pnpm vitest run server/src/__tests__/secrets-routes.test.ts server/src/__tests__/secrets-service.test.ts` (89 tests after final Greptile cleanup fixes) - PASS: `pnpm --filter @paperclipai/server exec vitest run src/__tests__/heartbeat-issue-liveness-escalation.test.ts` (17 tests after the final rebase CI fix) - PASS: focused server Vitest batches covering heartbeat recovery, project env, plugin env, routines, low-trust, pipelines, monitors, watchdog, and stale queue paths. - PASS: GitHub checks are green on `2527febd106bcf3ca264ca0da7fca491084192d6`, including Typecheck + Release Registry, Build, General tests, serialized server suites, e2e, Canary Dry Run, verify, security checks, and Greptile Review. - PASS: Greptile Review completed successfully on `2527febd106bcf3ca264ca0da7fca491084192d6` with Confidence Score 5/5, and GraphQL review-thread audit returned zero unresolved non-outdated threads. ## Risks - Runtime behavior now depends on a run having a correct responsible user; missing or incorrect responsibility assignment can block runs before adapter dispatch. - `user_secret_ref` bindings intentionally expose metadata without values, but UI/API callers may need to handle the new binding kind explicitly. - External secret providers and IAM policies are not automatically provisioned by this PR; operators still need to configure provider-side access for non-local vaults. - The PR is broad across db/shared/server/UI/runtime paths, so release validation should include both API and UI secret workflows before merge. - The migration renumbering is intentionally incremental after upstream migrations; the branch migrations use guarded column/table/index/constraint creation so users who tested the older draft numbering should not hit duplicate DDL for the existing objects. > For core feature work, check [`ROADMAP.md`](ROADMAP.md) first and discuss it in `#dev` before opening the PR. Feature PRs that overlap with planned core work may need to be redirected — check the roadmap first. See `CONTRIBUTING.md`. ## Model Used OpenAI Codex, GPT-5-based coding agent (`gpt-5`), Codex local adapter with shell/tool use and code execution. Context window and internal reasoning mode are not exposed by the runtime. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either (a) linked existing issues with `Fixes: #` / `Closes #` / `Refs #` OR (b) described the issue in-PR following the relevant issue template - [x] I have not referenced internal/instance-local Paperclip issues or links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip` URLs) - [x] My branch name describes the change (e.g. `docs/...`, `fix/...`) and contains no internal Paperclip ticket id or instance-derived details - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] All Paperclip CI gates are green - [x] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I will address all Greptile and reviewer comments before requesting merge --------- Co-authored-by: Paperclip <noreply@paperclip.ing> Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
223 lines
9.3 KiB
TypeScript
223 lines
9.3 KiB
TypeScript
import { createHmac } from "node:crypto";
|
|
import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";
|
|
import { createLocalAgentJwt, verifyLocalAgentJwt } from "../agent-auth-jwt.js";
|
|
|
|
describe("agent local JWT", () => {
|
|
const secretEnv = "PAPERCLIP_AGENT_JWT_SECRET";
|
|
const betterAuthSecretEnv = "BETTER_AUTH_SECRET";
|
|
const ttlEnv = "PAPERCLIP_AGENT_JWT_TTL_SECONDS";
|
|
const issuerEnv = "PAPERCLIP_AGENT_JWT_ISSUER";
|
|
const audienceEnv = "PAPERCLIP_AGENT_JWT_AUDIENCE";
|
|
const disableLegacyFallbackEnv = "PAPERCLIP_AGENT_JWT_DISABLE_LEGACY_FALLBACK";
|
|
|
|
const originalEnv = {
|
|
secret: process.env[secretEnv],
|
|
betterAuthSecret: process.env[betterAuthSecretEnv],
|
|
ttl: process.env[ttlEnv],
|
|
issuer: process.env[issuerEnv],
|
|
audience: process.env[audienceEnv],
|
|
disableLegacyFallback: process.env[disableLegacyFallbackEnv],
|
|
};
|
|
|
|
beforeEach(() => {
|
|
process.env[secretEnv] = "test-secret";
|
|
delete process.env[betterAuthSecretEnv];
|
|
process.env[ttlEnv] = "3600";
|
|
delete process.env[issuerEnv];
|
|
delete process.env[audienceEnv];
|
|
delete process.env[disableLegacyFallbackEnv];
|
|
vi.useFakeTimers();
|
|
});
|
|
|
|
afterEach(() => {
|
|
vi.useRealTimers();
|
|
if (originalEnv.secret === undefined) delete process.env[secretEnv];
|
|
else process.env[secretEnv] = originalEnv.secret;
|
|
if (originalEnv.betterAuthSecret === undefined) delete process.env[betterAuthSecretEnv];
|
|
else process.env[betterAuthSecretEnv] = originalEnv.betterAuthSecret;
|
|
if (originalEnv.ttl === undefined) delete process.env[ttlEnv];
|
|
else process.env[ttlEnv] = originalEnv.ttl;
|
|
if (originalEnv.issuer === undefined) delete process.env[issuerEnv];
|
|
else process.env[issuerEnv] = originalEnv.issuer;
|
|
if (originalEnv.audience === undefined) delete process.env[audienceEnv];
|
|
else process.env[audienceEnv] = originalEnv.audience;
|
|
if (originalEnv.disableLegacyFallback === undefined) delete process.env[disableLegacyFallbackEnv];
|
|
else process.env[disableLegacyFallbackEnv] = originalEnv.disableLegacyFallback;
|
|
});
|
|
|
|
it("creates and verifies a token", () => {
|
|
vi.setSystemTime(new Date("2026-01-01T00:00:00.000Z"));
|
|
const token = createLocalAgentJwt("agent-1", "company-1", "claude_local", "run-1", "user-1");
|
|
expect(typeof token).toBe("string");
|
|
|
|
const claims = verifyLocalAgentJwt(token!);
|
|
expect(claims).toMatchObject({
|
|
sub: "agent-1",
|
|
company_id: "company-1",
|
|
adapter_type: "claude_local",
|
|
run_id: "run-1",
|
|
responsible_user_id: "user-1",
|
|
iss: "paperclip",
|
|
aud: "paperclip-api",
|
|
});
|
|
});
|
|
|
|
it("returns null when secret is missing", () => {
|
|
process.env[secretEnv] = "";
|
|
const token = createLocalAgentJwt("agent-1", "company-1", "claude_local", "run-1");
|
|
expect(token).toBeNull();
|
|
expect(verifyLocalAgentJwt("abc.def.ghi")).toBeNull();
|
|
});
|
|
|
|
it("falls back to BETTER_AUTH_SECRET when PAPERCLIP_AGENT_JWT_SECRET is absent", () => {
|
|
delete process.env[secretEnv];
|
|
process.env[betterAuthSecretEnv] = "fallback-secret";
|
|
vi.setSystemTime(new Date("2026-01-01T00:00:00.000Z"));
|
|
const token = createLocalAgentJwt("agent-1", "company-1", "claude_local", "run-1");
|
|
expect(typeof token).toBe("string");
|
|
|
|
const claims = verifyLocalAgentJwt(token!);
|
|
expect(claims).toMatchObject({
|
|
sub: "agent-1",
|
|
company_id: "company-1",
|
|
adapter_type: "claude_local",
|
|
run_id: "run-1",
|
|
});
|
|
});
|
|
|
|
it("rejects expired tokens", () => {
|
|
process.env[ttlEnv] = "1";
|
|
vi.setSystemTime(new Date("2026-01-01T00:00:00.000Z"));
|
|
const token = createLocalAgentJwt("agent-1", "company-1", "claude_local", "run-1");
|
|
|
|
vi.setSystemTime(new Date("2026-01-01T00:00:05.000Z"));
|
|
expect(verifyLocalAgentJwt(token!)).toBeNull();
|
|
});
|
|
|
|
it("rejects issuer/audience mismatch", () => {
|
|
process.env[issuerEnv] = "custom-issuer";
|
|
process.env[audienceEnv] = "custom-audience";
|
|
vi.setSystemTime(new Date("2026-01-01T00:00:00.000Z"));
|
|
const token = createLocalAgentJwt("agent-1", "company-1", "codex_local", "run-1");
|
|
|
|
process.env[issuerEnv] = "paperclip";
|
|
process.env[audienceEnv] = "paperclip-api";
|
|
expect(verifyLocalAgentJwt(token!)).toBeNull();
|
|
});
|
|
|
|
it("does not verify a token across companies (per-company isolation)", () => {
|
|
vi.setSystemTime(new Date("2026-01-01T00:00:00.000Z"));
|
|
const tokenA = createLocalAgentJwt("agent-1", "company-A", "claude_local", "run-1");
|
|
expect(tokenA).not.toBeNull();
|
|
|
|
// A token whose body claims company-A must verify successfully under its
|
|
// own company-A derived key.
|
|
expect(verifyLocalAgentJwt(tokenA!)?.company_id).toBe("company-A");
|
|
|
|
// Tamper: forge a token by copying tokenA's header+signature and swapping
|
|
// the claim's company_id to company-B. The signature was bound to the
|
|
// company-A derived key over the original claims; once we re-encode with a
|
|
// different company_id (or rebind to company-B's key) verification must
|
|
// fail because the signature is over the original signing input.
|
|
const [headerB64, claimsB64, signature] = tokenA!.split(".");
|
|
const claims = JSON.parse(Buffer.from(claimsB64, "base64url").toString("utf8"));
|
|
claims.company_id = "company-B";
|
|
const tamperedClaimsB64 = Buffer.from(JSON.stringify(claims), "utf8").toString("base64url");
|
|
const tampered = `${headerB64}.${tamperedClaimsB64}.${signature}`;
|
|
expect(verifyLocalAgentJwt(tampered)).toBeNull();
|
|
});
|
|
|
|
it("accepts legacy tokens signed with the master secret (backward compat)", () => {
|
|
vi.setSystemTime(new Date("2026-01-01T00:00:00.000Z"));
|
|
const masterSecret = process.env[secretEnv]!;
|
|
|
|
// Hand-craft a token signed directly with the master secret, simulating a
|
|
// JWT issued before per-company derivation existed.
|
|
const now = Math.floor(Date.now() / 1000);
|
|
const header = { alg: "HS256", typ: "JWT" };
|
|
const claims = {
|
|
sub: "agent-legacy",
|
|
company_id: "company-legacy",
|
|
adapter_type: "claude_local",
|
|
run_id: "run-legacy",
|
|
iat: now,
|
|
exp: now + 3600,
|
|
iss: "paperclip",
|
|
aud: "paperclip-api",
|
|
};
|
|
const headerB64 = Buffer.from(JSON.stringify(header), "utf8").toString("base64url");
|
|
const claimsB64 = Buffer.from(JSON.stringify(claims), "utf8").toString("base64url");
|
|
const signingInput = `${headerB64}.${claimsB64}`;
|
|
const legacySig = createHmac("sha256", masterSecret).update(signingInput).digest("base64url");
|
|
const legacyToken = `${signingInput}.${legacySig}`;
|
|
|
|
const verified = verifyLocalAgentJwt(legacyToken);
|
|
expect(verified).toMatchObject({
|
|
sub: "agent-legacy",
|
|
company_id: "company-legacy",
|
|
adapter_type: "claude_local",
|
|
run_id: "run-legacy",
|
|
});
|
|
});
|
|
|
|
it("defaults TTL to 1h when PAPERCLIP_AGENT_JWT_TTL_SECONDS is unset", () => {
|
|
delete process.env[ttlEnv];
|
|
vi.setSystemTime(new Date("2026-01-01T00:00:00.000Z"));
|
|
const token = createLocalAgentJwt("agent-1", "company-1", "claude_local", "run-1");
|
|
const claims = verifyLocalAgentJwt(token!);
|
|
expect(claims).not.toBeNull();
|
|
expect(claims!.exp - claims!.iat).toBe(60 * 60);
|
|
});
|
|
|
|
// Helper: hand-craft a token signed with the raw master secret (legacy path).
|
|
function craftLegacyMasterSecretToken(masterSecret: string, companyId: string) {
|
|
const now = Math.floor(Date.now() / 1000);
|
|
const header = { alg: "HS256", typ: "JWT" };
|
|
const claims = {
|
|
sub: "agent-legacy",
|
|
company_id: companyId,
|
|
adapter_type: "claude_local",
|
|
run_id: "run-legacy",
|
|
iat: now,
|
|
exp: now + 3600,
|
|
iss: "paperclip",
|
|
aud: "paperclip-api",
|
|
};
|
|
const headerB64 = Buffer.from(JSON.stringify(header), "utf8").toString("base64url");
|
|
const claimsB64 = Buffer.from(JSON.stringify(claims), "utf8").toString("base64url");
|
|
const signingInput = `${headerB64}.${claimsB64}`;
|
|
const legacySig = createHmac("sha256", masterSecret).update(signingInput).digest("base64url");
|
|
return `${signingInput}.${legacySig}`;
|
|
}
|
|
|
|
it("accepts master-secret-signed tokens when PAPERCLIP_AGENT_JWT_DISABLE_LEGACY_FALLBACK is unset", () => {
|
|
vi.setSystemTime(new Date("2026-01-01T00:00:00.000Z"));
|
|
delete process.env[disableLegacyFallbackEnv];
|
|
const legacyToken = craftLegacyMasterSecretToken(process.env[secretEnv]!, "company-legacy");
|
|
const verified = verifyLocalAgentJwt(legacyToken);
|
|
expect(verified).not.toBeNull();
|
|
expect(verified!.company_id).toBe("company-legacy");
|
|
});
|
|
|
|
it("rejects master-secret-signed tokens when PAPERCLIP_AGENT_JWT_DISABLE_LEGACY_FALLBACK is enabled", () => {
|
|
vi.setSystemTime(new Date("2026-01-01T00:00:00.000Z"));
|
|
process.env[disableLegacyFallbackEnv] = "true";
|
|
const legacyToken = craftLegacyMasterSecretToken(process.env[secretEnv]!, "company-legacy");
|
|
expect(verifyLocalAgentJwt(legacyToken)).toBeNull();
|
|
});
|
|
|
|
it("still verifies per-company-signed tokens when PAPERCLIP_AGENT_JWT_DISABLE_LEGACY_FALLBACK is enabled", () => {
|
|
vi.setSystemTime(new Date("2026-01-01T00:00:00.000Z"));
|
|
process.env[disableLegacyFallbackEnv] = "true";
|
|
const token = createLocalAgentJwt("agent-1", "company-1", "claude_local", "run-1");
|
|
expect(token).not.toBeNull();
|
|
const verified = verifyLocalAgentJwt(token!);
|
|
expect(verified).toMatchObject({
|
|
sub: "agent-1",
|
|
company_id: "company-1",
|
|
adapter_type: "claude_local",
|
|
run_id: "run-1",
|
|
});
|
|
});
|
|
});
|