mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-11-19 16:29:42 +01:00
## Thinking Path > - Paperclip is the open source app people use to manage AI agents for work > - The release workflow runs a Docker onboarding smoke on the real npm artifact before it publishes a nightly or beta > - #22077 changed onboarding. "Get started" now opens the lead's standing chat. It does not create a first task or project > - That PR updated the e2e tests, but it did not update the release smoke > - The smoke still expects an `/issues/` landing, so every nightly smoke fails, and no nightly can publish > - This pull request changes the smoke to assert the new chat-first contract > - The benefit is that the nightly lane can publish again, and the smoke still guards the first-run experience ## Linked Issues or Issue Description Refs #22077 **What happened?** The release smoke `docker-auth-onboarding.spec.ts` fails at `expect(page).toHaveURL(/\/issues\//)`. The page is on `/<prefix>/chats/<agent id>`. The failure occurs on the first attempt and on the retry. The scheduled nightly on 2026-11-18 and a dispatched nightly for `2026.1118.0-canary.828200` both failed at this step. **Steps to reproduce** 1. Run the release workflow with `channel=nightly` on a canary that contains #22077. 2. Look at the `smoke_nightly / smoke` job. **Expected behavior** The smoke follows onboarding into the chat and passes when the artifact works. ## What Changed - Expect the launch to land on `/chats/<lead agent id>`, not on `/issues/`. - Assert that the task list and the project list are empty after launch. - Assert that exactly one chat exists, with `originKind: "onboarding_chat"`, no project, and the lead as `conversationAgentId`. - Assert that the chat composer renders. - Replace the old "no run" check. Now the smoke polls until the live welcome run is queued for the lead. The provider mock serves no completions, so the smoke does not check the welcome text. - Remove the `FIRST_TASK_TITLE` constant, because onboarding no longer seeds a task. ## Verification - `tsc --noEmit --strict` on the spec passes. - I checked the asserted fields against `server/src/services/onboarding-chat.ts`, `GET /companies/:companyId/chats` and `tests/e2e/conference-room-typing-intro.spec.ts`. - Full check: the `Release Smoke` workflow (or a nightly dispatch after merge) must pass the `smoke` job. ## Risks - Low risk. The change is test-only. - The welcome-run assertion depends on the UI requesting the welcome in a visible headless tab. If that is not true in CI, the poll times out after 30 seconds. Then remove or relax that one assertion. ## Model Used - Claude Opus 5.5 (`claude-opus-5-5`), with tool use (shell, GitHub CLI). ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either (a) linked existing issues with `Fixes: #` / `Closes #` / `Refs #` OR (b) described the issue in-PR following the relevant issue template - [x] I have not referenced internal/instance-local Paperclip issues or links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip` URLs) - [x] My branch name describes the change (e.g. `docs/...`, `fix/...`) and contains no internal Paperclip ticket id or instance-derived details - [ ] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [ ] All Paperclip CI gates are green - [ ] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [ ] I will address all Greptile and reviewer comments before requesting merge 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: devinfoley <139239+devinfoley@users.noreply.github.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>