mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-10-12 08:19:54 +02:00
## Thinking Path > - Paperclip is the open source app people use to manage AI agents for work > - Its UI is governed by a design system (`DESIGN.md` + the token layer in `ui/src/index.css`, merged in #9134) whose first principle is "one way to say each thing" — one Card, one Badge, one nav row > - After the token extraction landed, ~35 files still hand-rolled card containers, ~45 files hand-rolled pill spans, the sidebar agents section duplicated the nav-row chrome, and the inbox and tasks lists rendered the same task rows two subtly different ways > - Each divergence is a place where a future design change (radius, hover language, status vocabulary) silently misses surfaces, defeating the "edit tokens + run checks" model the design system exists for > - This pull request converges those surfaces onto the shared primitives, codifies the radius scale as the modern multiplicative shadcn ladder, and unifies the row/hover/tree-guide language across the inbox and tasks lists — every visible delta was human-reviewed screen-by-screen against a live instance across nine feedback rounds > - The benefit is that the app's look is now steerable from single knobs (one `--radius` anchor, one Card, one Badge, one row component), and the visual regression suite covers the result (514 snapshots including a new AgentDetail page story) ## Linked Issues or Issue Description No public GitHub issue exists for this work; describing per the feature template: - **Problem**: after the design-token foundation (#9134), component-level drift remained — hand-rolled cards/pills, duplicated sidebar row chrome, and two different renderings of task rows (inbox vs tasks list) meant design changes had to be applied per-surface and frequently missed spots (e.g. status glyphs rendered 16px in the inbox but 20px in the tasks list because a slot override silently beat the component default). - **Proposed behavior**: all card-shaped containers render via `Card`, all label pills via `Badge`, sidebar rows via `SidebarNavItem`, and both task-list surfaces via one `IssueRow` configuration; the radius scale is a single multiplicative ladder anchored at `--radius: 0.5rem`. - **Alternatives considered**: converting interactive `<button>`/`<Link>` cards to `Card` divs (rejected — breaks semantics; documented inline with `design-allow` comments instead); keeping the legacy additive radius ladder (rejected in favor of the standard shadcn multiplicative mapping). ## What Changed - `Card` adoption across ~35 files (settings pages, auth/board flows, dashboards, list containers, KPI tiles); non-adoptable sites (interactive cards, `<li>` rows, class-string props, chart tooltip) carry documented `design-allow(card-pattern)` comments - `Card` gains an `interactive` prop — one quiet hover affordance for clickable cards (cursor, border darken, shadow lift, focus ring), applied to skills tiles, artifact cards, and the company selector; cards carry no resting shadow - `Badge` adoption for 113 hand-rolled pill spans across ~45 files; `PropertyChip` wraps `Badge` internally; `StatusBadge`, external-object chips, and match chips stay bespoke by documented decision (WCAG-tuned status mechanics) - Radius ladder becomes the multiplicative shadcn mapping (`sm/md/lg/xl/2xl/3xl/4xl = 0.6/0.8/1.0/1.4/1.8/2.2/2.6 × --radius`, anchor `0.5rem`); every card surface unifies on `rounded-lg`; the orphaned 8px literal token is deleted - Sidebar: agent rows render via `SidebarNavItem` (new additive props: `iconNode`, `active`, `trailing`, `liveAccessory`); live dots use `--status-agent-running`; one row rhythm and inset rounded pill highlight; right-aligned trailing badges; every labeled section is collapsible - Inbox + tasks lists unified: md status glyphs, `accent/50` rounded row hovers, vertical tree guides under parent rows (opaque underlay so dark-mode translucent borders don't stack), no horizontal dividers under expanded parents; the swipe-to-archive reveal layer shows only mid-swipe; board toggle uses the `SquareKanban` glyph - Kanban: every column carries a status-hued tint; lanes default expanded (including empty); compact mode collapses empty lanes to labeled rails (fixes a clipped, label-less empty-column state) - Storybook: new AgentDetail page story (realistic fixtures, light+dark) joins the visual suite; suite captures with `reducedMotion: 'reduce'` and the ux-lab reasoning ticker honors `prefers-reduced-motion`; a stale lexical alias in `storybook/main.ts` is fixed (build was broken since the lexical 0.46 bump) - Keyboard navigation, from live review of the unified lists: inbox navigation keys work on every tab (archive keys stay scoped to the archivable tab); keyboard-driven scrolling no longer hands the selection to whatever row lands under the stationary cursor (hover selects only after real pointer movement); the tasks list view gains the same j/k / arrows / Enter selection model as the inbox; and the `g` then `i` go-to-inbox chord works app-wide instead of only on the issue detail page - Token gates restored to 3/3 CLEAN (tokenized a post-#9134 regression in the recovery card); decisions recorded in `doc/design/DECISION-SHEET.md` and `doc/design/COMPONENT-INVENTORY.md` (investigation verdicts: FileTree vs WorkspaceFileBrowser and the four entity pickers stay separate — evidence included) ## Verification - `pnpm check:token-gates` → 3/3 CLEAN - `pnpm typecheck` → green (all packages) - `cd ui && npx vitest run` → 2106/2106 (assertions updated in lockstep where they documented superseded decisions; new tests for the global go-to-inbox chord) - `pnpm --filter @paperclipai/ui build` → exit 0 - `pnpm build-storybook` → succeeds (also fixes the lexical-alias break on master) - Visual regression: 514-snapshot Playwright suite green against the updated baseline (zero diffs from the keyboard-navigation round — those changes are purely behavioral). Note: baselines live outside git per the suite design and the baseline-manifest archive is not yet published, so CI cannot run this suite — it was run locally throughout; every visible delta was reviewed screen-by-screen in a live instance across nine review rounds. Review evidence (before/after triplets) intentionally kept out of the repo for size; available on request. - Manual: exercised dashboard, tasks (list + board), inbox, agents, skills, costs, settings, and artifact surfaces in light and dark themes ## Risks - Wide but shallow visual surface: most changes are class-string substitutions with behavior preserved (props, handlers, roles, test ids). The riskiest areas — dnd-kit card refs (React 19 ref-as-prop), inbox swipe-to-archive, and sidebar overlays — are covered by existing unit tests (all green) and were manually exercised. - Intentional visual deltas (rounded cards, tinted kanban columns, md status glyphs, unified hovers) are design decisions recorded in `doc/design/DECISION-SHEET.md`; each maps to a re-baselined snapshot set locally. - The visual suite cannot yet run in CI (unpublished baseline archive — pre-existing condition from #9134); until that lands, snapshot coverage is local-only. ## Model Used - Claude Fable 5 (`claude-fable-5`, Anthropic) via Claude Code — agentic coding with tool use (file editing, test execution, Playwright screenshot verification); extended thinking enabled. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either (a) linked existing issues with `Fixes: #` / `Closes #` / `Refs #` OR (b) described the issue in-PR following the relevant issue template - [x] I have not referenced internal/instance-local Paperclip issues or links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip` URLs) - [x] My branch name describes the change (e.g. `docs/...`, `fix/...`) and contains no internal Paperclip ticket id or instance-derived details - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [ ] All Paperclip CI gates are green (will confirm once CI runs) - [ ] Greptile is 5/5 with no open P2s, recommendations, or follow-ups (pending first review) - [x] I will address all Greptile and reviewer comments before requesting merge 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
339 lines
14 KiB
TypeScript
339 lines
14 KiB
TypeScript
// token-extraction: allowlisted — intentional one-off decoration (DECISION-SHEET.md B1
|
|
// user ruling). The bg-[...gradient...] / shadow-[...] literals in this demo/UX-lab page
|
|
// are deliberate one-off decoration, reverted from --gradient-extract-*/--shadow-extract-*
|
|
// tokens; the file is on the check-token-gates allowlist in ui/src/index.css.
|
|
import { useState } from "react";
|
|
import { Button } from "@/components/ui/button";
|
|
import { Badge } from "@/components/ui/badge";
|
|
import { cn, formatDateTime } from "../lib/utils";
|
|
import { Identity } from "../components/Identity";
|
|
import { StatusBadge } from "../components/StatusBadge";
|
|
import { RunTranscriptView, type TranscriptDensity, type TranscriptMode } from "../components/transcript/RunTranscriptView";
|
|
import { runTranscriptFixtureEntries, runTranscriptFixtureMeta } from "../fixtures/runTranscriptFixtures";
|
|
import { ExternalLink, FlaskConical, LayoutPanelLeft, MonitorCog, PanelsTopLeft, RadioTower } from "lucide-react";
|
|
|
|
type SurfaceId = "detail" | "live" | "dashboard";
|
|
|
|
const surfaceOptions: Array<{
|
|
id: SurfaceId;
|
|
label: string;
|
|
eyebrow: string;
|
|
description: string;
|
|
icon: typeof LayoutPanelLeft;
|
|
}> = [
|
|
{
|
|
id: "detail",
|
|
label: "Run Detail",
|
|
eyebrow: "Full transcript",
|
|
description: "The long-form run page with the `Nice | Raw` toggle and the most inspectable transcript view.",
|
|
icon: MonitorCog,
|
|
},
|
|
{
|
|
id: "live",
|
|
label: "Issue Widget",
|
|
eyebrow: "Live stream",
|
|
description: "The issue-detail live run widget, optimized for following an active run without leaving the task page.",
|
|
icon: RadioTower,
|
|
},
|
|
{
|
|
id: "dashboard",
|
|
label: "Dashboard Card",
|
|
eyebrow: "Dense card",
|
|
description: "The active-agents dashboard card, tuned for compact scanning while keeping the same transcript language.",
|
|
icon: PanelsTopLeft,
|
|
},
|
|
];
|
|
|
|
function previewEntries(surface: SurfaceId) {
|
|
if (surface === "dashboard") {
|
|
return runTranscriptFixtureEntries.slice(-9);
|
|
}
|
|
if (surface === "live") {
|
|
return runTranscriptFixtureEntries.slice(-14);
|
|
}
|
|
return runTranscriptFixtureEntries;
|
|
}
|
|
|
|
function RunDetailPreview({
|
|
mode,
|
|
streaming,
|
|
density,
|
|
}: {
|
|
mode: TranscriptMode;
|
|
streaming: boolean;
|
|
density: TranscriptDensity;
|
|
}) {
|
|
return (
|
|
<div className="overflow-hidden rounded-xl border border-border/70 bg-background/80 shadow-[0_24px_60px_rgba(15,23,42,0.08)]">
|
|
<div className="border-b border-border/60 bg-background/90 px-5 py-4">
|
|
<div className="flex flex-wrap items-center gap-2">
|
|
<Badge variant="outline" className="uppercase tracking-(--tracking-caps) text-(length:--text-nano)">
|
|
Run Detail
|
|
</Badge>
|
|
<StatusBadge status={streaming ? "running" : "succeeded"} />
|
|
<span className="text-xs text-muted-foreground">
|
|
{formatDateTime(runTranscriptFixtureMeta.startedAt)}
|
|
</span>
|
|
</div>
|
|
<div className="mt-2 text-sm font-medium">
|
|
Transcript ({runTranscriptFixtureEntries.length})
|
|
</div>
|
|
</div>
|
|
<div className="max-h-(--sz-720px) overflow-y-auto bg-[radial-gradient(circle_at_top_left,rgba(8,145,178,0.08),transparent_36%),radial-gradient(circle_at_bottom_right,rgba(245,158,11,0.10),transparent_28%)] p-5">
|
|
<RunTranscriptView
|
|
entries={runTranscriptFixtureEntries}
|
|
mode={mode}
|
|
density={density}
|
|
streaming={streaming}
|
|
/>
|
|
</div>
|
|
</div>
|
|
);
|
|
}
|
|
|
|
function LiveWidgetPreview({
|
|
streaming,
|
|
mode,
|
|
density,
|
|
}: {
|
|
streaming: boolean;
|
|
mode: TranscriptMode;
|
|
density: TranscriptDensity;
|
|
}) {
|
|
return (
|
|
<div className="overflow-hidden rounded-xl border border-cyan-500/25 bg-background/85 shadow-[0_20px_50px_rgba(6,182,212,0.10)]">
|
|
<div className="border-b border-border/60 bg-cyan-500/[0.05] px-5 py-4">
|
|
<div className="text-xs font-semibold uppercase tracking-(--tracking-caps) text-cyan-700 dark:text-cyan-300">
|
|
Live Runs
|
|
</div>
|
|
<div className="mt-1 text-xs text-muted-foreground">
|
|
Compact live transcript stream for the issue detail page.
|
|
</div>
|
|
</div>
|
|
<div className="px-5 py-4">
|
|
<div className="mb-4 flex flex-col gap-3 sm:flex-row sm:items-start sm:justify-between">
|
|
<div className="min-w-0">
|
|
<Identity name={runTranscriptFixtureMeta.agentName} size="sm" />
|
|
<div className="mt-2 flex flex-wrap items-center gap-2 text-xs text-muted-foreground">
|
|
<Badge variant="outline" className="border-border/70 bg-background/70 py-1 font-mono">
|
|
{runTranscriptFixtureMeta.sourceRunId.slice(0, 8)}
|
|
</Badge>
|
|
<StatusBadge status={streaming ? "running" : "succeeded"} />
|
|
<span>{formatDateTime(runTranscriptFixtureMeta.startedAt)}</span>
|
|
</div>
|
|
</div>
|
|
<Badge variant="outline" className="border-border/70 bg-background/70 px-2.5 py-1 text-(length:--text-micro) text-muted-foreground">
|
|
Open run
|
|
<ExternalLink className="h-3 w-3" />
|
|
</Badge>
|
|
</div>
|
|
<div className="max-h-(--sz-460px) overflow-y-auto pr-1">
|
|
<RunTranscriptView
|
|
entries={previewEntries("live")}
|
|
mode={mode}
|
|
density={density}
|
|
limit={density === "compact" ? 10 : 12}
|
|
streaming={streaming}
|
|
/>
|
|
</div>
|
|
</div>
|
|
</div>
|
|
);
|
|
}
|
|
|
|
function DashboardPreview({
|
|
streaming,
|
|
mode,
|
|
density,
|
|
}: {
|
|
streaming: boolean;
|
|
mode: TranscriptMode;
|
|
density: TranscriptDensity;
|
|
}) {
|
|
return (
|
|
<div className="max-w-md">
|
|
<div className={cn(
|
|
"flex h-(--sz-320px) flex-col overflow-hidden rounded-xl border shadow-[0_20px_40px_rgba(15,23,42,0.10)]",
|
|
streaming
|
|
? "border-cyan-500/25 bg-cyan-500/[0.04]"
|
|
: "border-border bg-background/75",
|
|
)}>
|
|
<div className="border-b border-border/60 px-4 py-4">
|
|
<div className="flex items-start justify-between gap-3">
|
|
<div className="min-w-0">
|
|
<div className="flex items-center gap-2">
|
|
<span className={cn(
|
|
"inline-flex h-2.5 w-2.5 rounded-full",
|
|
streaming ? "bg-cyan-500 shadow-[0_0_0_6px_rgba(34,211,238,0.12)]" : "bg-muted-foreground/35",
|
|
)} />
|
|
<Identity name={runTranscriptFixtureMeta.agentName} size="sm" />
|
|
</div>
|
|
<div className="mt-2 text-(length:--text-micro) text-muted-foreground">
|
|
{streaming ? "Live now" : "Finished 2m ago"}
|
|
</div>
|
|
</div>
|
|
<Badge variant="outline" className="[&>svg]:size-2.5 border-border/70 bg-background/70 py-1 text-(length:--text-nano) text-muted-foreground">
|
|
<ExternalLink className="h-2.5 w-2.5" />
|
|
</Badge>
|
|
</div>
|
|
<div className="mt-3 rounded-lg border border-border/60 bg-background/60 px-3 py-2 text-xs text-cyan-700 dark:text-cyan-300">
|
|
{runTranscriptFixtureMeta.issueIdentifier} - {runTranscriptFixtureMeta.issueTitle}
|
|
</div>
|
|
</div>
|
|
<div className="min-h-0 flex-1 overflow-y-auto p-4">
|
|
<RunTranscriptView
|
|
entries={previewEntries("dashboard")}
|
|
mode={mode}
|
|
density={density}
|
|
limit={density === "compact" ? 6 : 8}
|
|
streaming={streaming}
|
|
/>
|
|
</div>
|
|
</div>
|
|
</div>
|
|
);
|
|
}
|
|
|
|
export function RunTranscriptUxLab() {
|
|
const [selectedSurface, setSelectedSurface] = useState<SurfaceId>("detail");
|
|
const [detailMode, setDetailMode] = useState<TranscriptMode>("nice");
|
|
const [streaming, setStreaming] = useState(true);
|
|
const [density, setDensity] = useState<TranscriptDensity>("comfortable");
|
|
|
|
const selected = surfaceOptions.find((option) => option.id === selectedSurface) ?? surfaceOptions[0];
|
|
|
|
return (
|
|
<div className="space-y-6">
|
|
<div className="overflow-hidden rounded-2xl border border-border/70 bg-[linear-gradient(135deg,rgba(8,145,178,0.08),transparent_28%),linear-gradient(180deg,rgba(245,158,11,0.08),transparent_40%),var(--background)] shadow-[0_28px_70px_rgba(15,23,42,0.10)]">
|
|
<div className="grid gap-6 lg:grid-cols-(--gtc-19)">
|
|
<aside className="border-b border-border/60 bg-background/75 p-5 lg:border-b-0 lg:border-r">
|
|
<div className="mb-5">
|
|
<div className="inline-flex items-center gap-2 rounded-full border border-cyan-500/25 bg-cyan-500/[0.08] px-3 py-1 text-(length:--text-nano) font-semibold uppercase tracking-(--tracking-caps) text-cyan-700 dark:text-cyan-300">
|
|
<FlaskConical className="h-3.5 w-3.5" />
|
|
UX Lab
|
|
</div>
|
|
<h1 className="mt-4 text-2xl font-semibold tracking-tight">Run Transcript Fixtures</h1>
|
|
<p className="mt-2 text-sm text-muted-foreground">
|
|
Built from a real Paperclip development run, then sanitized so no secrets, local paths, or environment details survive into the fixture.
|
|
</p>
|
|
</div>
|
|
|
|
<div className="space-y-2">
|
|
{surfaceOptions.map((option) => {
|
|
const Icon = option.icon;
|
|
return (
|
|
<button
|
|
key={option.id}
|
|
type="button"
|
|
onClick={() => setSelectedSurface(option.id)}
|
|
className={cn(
|
|
"w-full rounded-xl border px-4 py-3 text-left transition-all",
|
|
selectedSurface === option.id
|
|
? "border-cyan-500/35 bg-cyan-500/[0.10] shadow-[0_12px_24px_rgba(6,182,212,0.12)]"
|
|
: "border-border/70 bg-background/70 hover:border-cyan-500/20 hover:bg-cyan-500/[0.04]",
|
|
)}
|
|
>
|
|
<div className="flex items-start gap-3">
|
|
<span className="rounded-lg border border-current/15 p-2 text-cyan-700 dark:text-cyan-300">
|
|
<Icon className="h-4 w-4" />
|
|
</span>
|
|
<span className="min-w-0">
|
|
<span className="block text-(length:--text-nano) font-semibold uppercase tracking-(--tracking-caps) text-muted-foreground">
|
|
{option.eyebrow}
|
|
</span>
|
|
<span className="mt-1 block text-sm font-medium">{option.label}</span>
|
|
<span className="mt-1 block text-xs text-muted-foreground">
|
|
{option.description}
|
|
</span>
|
|
</span>
|
|
</div>
|
|
</button>
|
|
);
|
|
})}
|
|
</div>
|
|
</aside>
|
|
|
|
<main className="min-w-0 p-5">
|
|
<div className="mb-5 flex flex-col gap-4 xl:flex-row xl:items-end xl:justify-between">
|
|
<div>
|
|
<div className="text-(length:--text-micro) font-semibold uppercase tracking-(--tracking-caps) text-muted-foreground">
|
|
{selected.eyebrow}
|
|
</div>
|
|
<h2 className="mt-1 text-2xl font-semibold">{selected.label}</h2>
|
|
<p className="mt-2 max-w-2xl text-sm text-muted-foreground">
|
|
{selected.description}
|
|
</p>
|
|
</div>
|
|
|
|
<div className="flex flex-wrap items-center gap-2">
|
|
<Badge variant="outline" className="rounded-full px-3 py-1 text-(length:--text-nano) uppercase tracking-(--tracking-caps)">
|
|
Source run {runTranscriptFixtureMeta.sourceRunId.slice(0, 8)}
|
|
</Badge>
|
|
<Badge variant="outline" className="rounded-full px-3 py-1 text-(length:--text-nano) uppercase tracking-(--tracking-caps)">
|
|
{runTranscriptFixtureMeta.issueIdentifier}
|
|
</Badge>
|
|
</div>
|
|
</div>
|
|
|
|
<div className="mb-5 flex flex-wrap items-center gap-2">
|
|
<span className="text-(length:--text-micro) font-semibold uppercase tracking-(--tracking-caps) text-muted-foreground">
|
|
Controls
|
|
</span>
|
|
<div className="inline-flex rounded-full border border-border/70 bg-background/80 p-1">
|
|
{(["nice", "raw"] as const).map((mode) => (
|
|
<button
|
|
key={mode}
|
|
type="button"
|
|
className={cn(
|
|
"rounded-full px-3 py-1 text-xs font-medium capitalize transition-colors",
|
|
detailMode === mode ? "bg-accent text-foreground" : "text-muted-foreground hover:text-foreground",
|
|
)}
|
|
onClick={() => setDetailMode(mode)}
|
|
>
|
|
{mode}
|
|
</button>
|
|
))}
|
|
</div>
|
|
<div className="inline-flex rounded-full border border-border/70 bg-background/80 p-1">
|
|
{(["comfortable", "compact"] as const).map((nextDensity) => (
|
|
<button
|
|
key={nextDensity}
|
|
type="button"
|
|
className={cn(
|
|
"rounded-full px-3 py-1 text-xs font-medium capitalize transition-colors",
|
|
density === nextDensity ? "bg-accent text-foreground" : "text-muted-foreground hover:text-foreground",
|
|
)}
|
|
onClick={() => setDensity(nextDensity)}
|
|
>
|
|
{nextDensity}
|
|
</button>
|
|
))}
|
|
</div>
|
|
<Button
|
|
variant="outline"
|
|
size="sm"
|
|
className="rounded-full"
|
|
onClick={() => setStreaming((value) => !value)}
|
|
>
|
|
{streaming ? "Show settled state" : "Show streaming state"}
|
|
</Button>
|
|
</div>
|
|
|
|
{selectedSurface === "detail" ? (
|
|
<div className={cn(density === "compact" && "max-w-5xl")}>
|
|
<RunDetailPreview mode={detailMode} streaming={streaming} density={density} />
|
|
</div>
|
|
) : selectedSurface === "live" ? (
|
|
<div className={cn(density === "compact" && "max-w-4xl")}>
|
|
<LiveWidgetPreview streaming={streaming} mode={detailMode} density={density} />
|
|
</div>
|
|
) : (
|
|
<DashboardPreview streaming={streaming} mode={detailMode} density={density} />
|
|
)}
|
|
</main>
|
|
</div>
|
|
</div>
|
|
</div>
|
|
);
|
|
}
|