mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-10-31 06:04:11 +01:00
<!-- entire-trail-link-start --> https://entire.com/gh/paperclipai/-/trails/147/changes/paperclip/147 <!-- entire-trail-link-end --> ## Thinking Path > - Paperclip is the open source app people use to manage AI agents for work. > - People coordinate work through conversations, tasks, and requests for input. > - These surfaces must share task state and preserve the context of each decision. > - The existing workspace makes people switch surfaces to follow that context. > - This pull request adds an optional Coordinator workspace with linked conversations, tasks, documents, and decisions. > - Each person can enable it in Settings > Experimental and return to the classic workspace. > - The benefit is a coherent path from a request to an assigned task and reviewed work. ## Linked Issues or Issue Description **Subsystem affected** UI, server, shared contracts, and database. **Problem or motivation** People need a consistent way to start tasks from agent conversations, answer questions, review work, and return to the source context. Decisions and task state must agree across these surfaces. **Proposed solution** Add a personal, default-off workspace experiment. Keep one conversation per agent. Add task proposals, compact task and decision cards, contextual document panels, and a Needs You queue with search, filters, sorting, grouping, and history. **Alternatives considered** Replacing the classic workspace for everyone would remove the opt-out path. Keeping separate decision state in each surface would create conflicting answers. This change uses the existing canonical task and interaction records instead. **Roadmap alignment** This supports the existing agent chat, task management, and human review capabilities. It is an experimental presentation choice. The user requested this isolated implementation after design review. No Discord discussion is claimed. ## What Changed - Add per-person workspace preferences, a default-off setting, and an additive migration. - Add Coordinator navigation, pinned destinations, task lists, agent switching, and contextual panels. - Link task suggestions and creation to the source conversation. Default new task ownership to the current agent unless the user specifies another owner. - Share pending questions, decision receipts, exact review targets, and history across tasks, chat, and Needs You. - Preserve task access, assignment authorization, revision binding, and required output review gates. - Add compact document links, relative timestamps, composer controls, and reduced-motion support for task and decision transitions. - Add component stories, regression coverage, and capability-map documentation. ## Verification - Final head: `4b839aae1e314bd7e8635a766f1d205ff1c03ba6`, based on master `8bc051245f77a47bee0f8ba45896b8bfa5922e0a`. Verified October 29, 2026 at 00:10 UTC: **MERGEABLE, 56 checks passed, four conditional skips, no pending or failed checks**. [Current CI run](https://github.com/paperclipai/paperclip/actions/runs/40790639688) passed without a rerun on this head. - Fresh Greptile **5/5**, zero new comments and zero open review threads; Superagent passed with no suspicious changes. [Checks](https://github.com/paperclipai/paperclip/pull/17983/checks). - Local workspace typecheck/build passed after the latest rebase. The final account-read patch passed UI typecheck/build and all 12 related preference/settings tests, including a delayed real-client request across account changes. Earlier scoped checks cover review deduplication/replay, decision deep links, cross-surface state, access boundaries, and migration replay. - Local database/browser rechecks after the latest rebase were limited by exhausted macOS shared-memory IDs: `initdb` failed before database creation. The local run passed 31 UI/snapshot tests and skipped 24 database tests; those skips and the blocked local browser start are not claimed as passes. The independent Linux CI database and browser checks passed. No running dev database or host setting was changed. - Upstream migration 0403 is preserved. Preferences and durable review retry aliases are generated as replay-safe migrations `0404_tense_silver_sable.sql` and `0405_harsh_avengers.sql`; five newest snapshots are retained. Every detected conflict was rebased and pushed before waiting for CI/review, as requested. - The PR is unmerged. The active master ruleset still requires code-owner approval for the changed Paperclip skill; no approval or rule change was performed. <details> <summary>Earlier verification failures, integration history, and evidence</summary> These entries preserve prior checkpoints and failures; the current acceptance result is above. - Focused UI and server checks from the isolated build are recorded in the implementation plan. - Browser checks covered the opt-in shell, navigation, task/document links, and decision card states. No new live provider trial is claimed for this handoff. - Current acceptance head: `4b839aae1e314bd7e8635a766f1d205ff1c03ba6`, rebased onto master `8bc051245` immediately after its GitHub review-repair migration took 0403. Preferences are generated as idempotent `0404_tense_silver_sable.sql`, preserving upstream SQL/journal/snapshot history and five newest snapshots. GitHub reports MERGEABLE after the immediate lease-protected push. Scott's updated instruction is to rebase and push every conflict resolution first, without waiting for CI or Greptile; verification follows the push. - The final reviewed feature tree was consolidated for repeatable single-commit rebases. The complete previous commit history remains reachable through local recovery ref `codex/coordinator-recovery-before-rebase-20261028` (resolved snapshot `0e1bbdf4e`). The actual rebase completed, and its tree hash exactly matches that resolved snapshot. The force-with-lease required the known remote head `0e6ef7c44`, protecting against concurrent branch changes. No PR merge or permission/runner setting change occurred. Fresh CI/review are in progress for the current head. - `2001132fa` received Greptile 5/5 with one nonblocking account-switch read finding. Current head detaches path-coalesced preference GETs and disables HTTP caching, retaining React Query's account-scoped sharing. A delayed real-client GET regression proves account B can load its saved choice before account A responds, and A's late response only updates A's cache. Preference/settings tests 12/12 and UI typecheck passed; its review thread is resolved. Fresh current-head CI/reviews are pending. The prior CI chat shard 3 ended with “The operation was canceled” and no assertion failure ([job 123171595631](https://github.com/paperclipai/paperclip/actions/runs/40789688333/job/123171595631), `/tmp/pr17983-2001132-chat3.log`); no code/timeout change is attributed to that cancellation. - `843e823b4` reached fresh Greptile 5/5 with zero comments/open threads and Superagent pass. All browser tests including the repaired YAML shard passed, and 54 checks passed. General server shard 9 ended with “The operation was canceled” and no failed assertion; its test step was marked cancelled (job [123164350893](https://github.com/paperclipai/paperclip/actions/runs/40787501761/job/123164350893), log `/tmp/pr17983-843e-server9.log`). A single unchanged-head rerun was started after the workflow completed, but master moved while it ran. A local nested-clone check timed out in its 30-second database-startup hook and then failed cleanup before the 20 database cases ran; this is retained as a local verification limit (`/tmp/pr17983-843e-nested-clone-check.log`), not claimed as a pass or proof of the CI cancellation cause. - Following Scott's instruction, the new conflict was rebased and pushed immediately without waiting for that rerun. Upstream's `0403_natural_cerise.sql` is preserved; regenerated preferences and retry-alias migrations are `0404_tense_silver_sable.sql` and `0405_harsh_avengers.sql`, replay-safe with five newest snapshots retained. The YAML helper conflict combines upstream's click and header behavior with the editor-selection guard and injected regression. Recovery ref `codex/coordinator-recovery-843e823b4` preserves pre-rebase work. Current head is MERGEABLE. Full workspace typecheck/build passed; UI and snapshot checks passed 31 tests, but 24 database tests were skipped by the local support probe, and the local browser server could not initialize PostgreSQL. A direct disposable `initdb` diagnostic established the host limitation: `could not create shared memory segment: No space left on device` (`shmget`, shared-memory IDs exhausted, not disk space). No dev database or host setting was changed. Diagnostics: `/tmp/pr17983-2001132-initdb-probe.log`, `/tmp/pr17983-2001132-db-probe.log`; checks: `/tmp/pr17983-2001132-tests.log`, `/tmp/pr17983-2001132-browser.log`, `/tmp/pr17983-2001132-types.log`, `/tmp/pr17983-2001132-build.log`. These local skipped/blocked checks are not claimed as passes; fresh CI on independent runners is in progress. - `d18f683cd` reached fresh Greptile 5/5 with zero comments/open threads and Superagent pass, but [E2E shard 7](https://github.com/paperclipai/paperclip/actions/runs/40785966243/job/123159719925) failed parsing an Advanced YAML clipboard read beginning with “Skip to Main Content.” The log is retained at `/tmp/pr17983-d18f-e2e7.log`. Current head hardens the test helper to verify editor focus and selection, clear stale clipboard content, and require the YAML header at the start of a fresh copy before parsing. Saved-state assertions and timeouts are unchanged. All six Advanced YAML browser journeys passed on a disposable local instance (41.0s); the exact lost-response journey also passed with a one-time injected surrounding-page copy, verifying rejection/reacquisition (17.6s). The precise browser focus/clipboard timing in CI remains unproven; the observed invalid-read path is now guarded and deterministically exercised. Logs: `/tmp/pr17983-yaml-clipboard-scope-browser.log`, `/tmp/pr17983-yaml-clipboard-injected-browser.log`. Fresh current-head CI and reviews are pending. - `19e6dcb0b` passed Superagent and Greptile 5/5, with one nonblocking deep-link finding. Current head preserves attention links using `?decisionId=`: the requested pending decision is rendered even beyond the first 40 cards, focused and scrolled into view, then only that parameter is consumed so later refreshes do not refocus. Other URL parameters remain. Needs You tests 10/10 and UI typecheck passed; its review thread is resolved. The preceding post-rebase regression run passed 45/45 tests. Fresh current-head CI/reviews are pending. - `6d772b7cc` reached Greptile 5/5 with zero comments/open threads and Superagent pass. While 32 checks had passed, master moved and caused a documentation conflict in `maps/feature-map/onboarding.md`. Rebased immediately, preserving both onboarding paragraphs. The complete four-commit branch was pushed as `19e6dcb0b` before waiting on CI/review, per Scott's instruction. A transient Git index lock interrupted the first continue; the command sequence briefly pushed intermediate `34e298c07`, then the completed rebase was immediately pushed. All feature and security/retry fixes are present; local recovery ref `codex/coordinator-recovery-6d772b7cc` preserves the pre-rebase history. The only tree differences from that ref are upstream's two smoke-test files and the combined documentation paragraph. GitHub reports MERGEABLE. Fresh current-head verification is in progress; prior-head review results are not current acceptance. - `21efa3120` passed Superagent but Greptile scored 4/5 for a valid retry-key persistence bug: an acknowledged duplicate key could reopen a resolved review. Current head adds an additive, replay-safe `0404_light_swarm.sql` migration for indexed, task-scoped aliases from acknowledged retry keys to the canonical interaction. Alias registration and retry lookup occur under the existing task lock; payload/actor mismatch still conflicts, and each canonical review permits at most 100 aliases. Original and acknowledged keys replay the terminal result rather than creating a new gate. Five newest migration snapshots are retained. Service/routes tests 165/165 passed; final quality review plus migration replay/snapshot checks 25/25 passed; server typecheck passed. The P1 thread is resolved in code; fresh current-head reviews and CI are pending. - `69c2c7543` passed 55 checks and Greptile 5/5 with no open Greptile findings, but Superagent check [123140675812](https://github.com/paperclipai/paperclip/pull/17983/checks?check_run_id=123140675812) correctly flagged unbounded pending quality-card creation. Current head fixes that under the existing task-row lock: equivalent requests with fresh idempotency keys reuse the pending card; conflicting requests for an unresolved deliverable return the existing interaction ID; pending cards are capped at ten per task across all reviewers. Distinct outputs remain independent, and already-answered items in a partially pending batch can receive a fresh review. Added real-database concurrency, cross-card duplicate, partial-answer, and hard-cap regressions. Quality review 22/22 tests and final server typecheck passed; earlier service/routes 163/163 tests passed before the final partial-answer refinement. One added assertion initially expected a service HTTP error, but duplicate keys are rejected earlier by the existing shared schema; the assertion now verifies that validation. Fresh current-head CI/reviews are pending; the action-required security result is not treated as passed. - `c9c575e5f` completed all 56 checks successfully with four conditional skips, Greptile 5/5, and Superagent pass. Its two P2 review findings are fixed in the current head: independently bound quality approvals now each remain visible in attention; changing/clearing URL-backed assignee/status filters updates the URL and survives task navigation. Both review threads are resolved. Regression evidence: attention service 34/34 tests passed, CoordinatorTasks 20/20 passed, UI and server typechecks and the full workspace build passed on `69c2c7543`. The first new UI test run caught an assertion racing React Router's transition; waiting for the navigation before asserting passes without weakening the navigation/remount checks. These older-head green checks are not claimed for the new fix commit. - Preceding `0e6ef7c44` completed all 56 checks successfully with four conditional skips, fresh Greptile 5/5 and no open findings, and passed Superagent. A fifth migration-metadata collision arrived before the final Runner job finished. Those green results are preserved as prior-head evidence, not current acceptance. - Previous fully verified migration head: `0e6ef7c44696a377f35e69521b93587576374bd0`, integrating master `f8226b051` after the fourth migration-number collision. Master added terminal GitHub-response migration 0401 while the final native check ran; upstream 0401 SQL/journal/snapshot is preserved unchanged, and preferences are generated as idempotent `0402_yielding_blink.sql` on top. Exactly the five newest snapshots remain. GitHub reports MERGEABLE after the push. All 1,155 relevant migration/review/interaction/native-execution/remote-assets tests, workspace typecheck/build, migration guards and whitespace checks pass. Fresh exact-head CI/Greptile/Superagent are pending. - Immediately preceding head `36c67cf03` completed all 56 checks successfully with four conditional skips, fresh Greptile 5/5 and no open findings, plus passed Superagent security. No retry was needed for that head's CI. Master advanced and introduced only a migration-metadata conflict while its final native check ran, so that green result does not establish acceptance of the current integration. Four consecutive collisions (0398, 0399, 0400, 0401) during verification are retained as concrete integration churn; a brief pause of competing migration merges was requested, without assuming it happened or changing any repo setting. The PR has not been merged. - Prior fully verified head: `36c67cf03`, on the clean `30059c0ed` integration of master `efd65c112`. The last Greptile P2 is fixed: Needs attention retains the participant-agent scope through authoritative server membership queries for each pending task, including historical participation when another agent currently owns the task. It does not approximate participation with current assignment or enumerate every company task. The actual view-switch regression and all 31 focused task/routing/collection tests, UI typecheck/build, token gates and whitespace checks pass. Greptile completed a fresh 5/5 review on this exact head (review 19) with zero new comments and no open review threads. CI and Superagent remain in progress; no current-head CI failure has been reported. - Head `30059c0ed` received Greptile 5/5 with that one nonblocking participant finding, now fixed. Superagent passed that head. Current-base integration restored the ephemeral RunsOn fleet after a superseded workflow retained queued aggregate jobs: normal cancellation was insufficient; the single force-cancel request was interrupted but readback confirmed that obsolete run cancelled and current CI began on the trusted fleet. No cancellation retry or runner/security/workflow changes were made. Its partial CI was superseded by the necessary participant fix and is not current acceptance. - Previous compatibility/base-sync head: `30059c0ededc0eab4e04e8299a884f36db8b292f`, integrating master `efd65c112` and the Inbox/workspace compatibility fixes. GitHub reports MERGEABLE after the push. Coordinator keeps Inbox standalone under More without rewriting the instance's Combined Inbox preference; opting out restores that preference. Saved merged-Inbox URLs resolve to their original owner, task status presets remain usable, and canonical repeated `workspace` parameters retain scoped, deduplicated pagination (including Needs attention). All 192 broader routing/Inbox/sidebar/privacy/review tests and the final 16 task-page tests pass, as do workspace typecheck/build, token gates and whitespace checks. The two review threads are resolved. Fresh exact-head CI, Greptile and Superagent results are pending. - The preceding `d5b9be5bd` remained mergeable but its CI routing gate intentionally fell back to GitHub-hosted runners: “stacked base merge commit does not contain the current base branch.” All 45 downstream jobs stayed queued. Current master was merged cleanly to refresh the pinned base; no runner/security settings or workflow logic were changed. Greptile scored that preceding head 4/5 with the two compatibility findings fixed here. Its automatic Superagent scan was inconclusive at checkout; the documented retry was still pending when superseded. Those results do not establish acceptance of this current head. - Previous approval/migration head: `d5b9be5bd3b8d6b0437e42bf48138377f34fa67d`, integrating master `ba5bba86d` and the stale-output approval correction. GitHub reports MERGEABLE after the push. The fresh P1 finding is fixed: every submitted item now validates and locks its bound output inside the resolution transaction, whether or not it carries a required-quality-review binding. Real database regressions verify that an advanced document revision or deleted attachment refuses the entire batch without recording approvals, and current ordinary output reviews still resolve. All 272 combined migration/review/interaction tests pass; workspace typecheck/build passed. Fresh exact-head Greptile and CI are pending. The automatic Superagent scan ended inconclusive at checkout; one documented on-demand retry is pending. These are explicit verification limits, not passed security results. The P1 thread is resolved. - Master consumed the next migration slot three times during this verification pass: confirmation recovery took 0398, continuation recovery took 0399, and GitHub acknowledgement recovery took 0400. Each upstream SQL/journal/snapshot is preserved unchanged. Preferences are now generated as idempotent `0401_white_lenny_balinger.sql` from upstream 0400; exactly five snapshots remain, and replay coverage locates this migration by table content. This is recorded concurrent integration churn, not a claim that older green results apply to the latest base. - Head `ed3b68da9` fixed the two history/URL findings with 26 focused regression tests, server/UI typechecks, workspace build and token gates passing. Greptile then scored that head 4/5 with the stale-output P1 corrected in the current head. Its partial CI is superseded, not counted as current acceptance. - Previous filter-fix head: `ed3b68da9`, based on the `8458d39d9` merge of master `063cfd438`. The two fresh Greptile findings are fixed: history outcome filters now match recorded per-item verdicts in SQL before pagination (mixed reviews remain in both applicable outcomes), and same-page URL assignee changes/back/forward navigation update that filter without clearing independent filters. All 26 focused database/navigation/collection tests, server/UI typechecks, workspace build, token gates and whitespace checks pass. The two review threads are resolved. Fresh exact-head CI, Greptile and Superagent results are pending. - The `8458d39d9` migration integration also passed all 328 targeted migration/interaction/confirmation tests, workspace typecheck/build and Superagent security scan. Greptile scored that head 4/5 with the two functional gaps fixed in the current head; those prior-head checks are not current acceptance. - Migration integration head: `8458d39d9721f4cb312c2390070a0609f8cddd1a`, integrating master `063cfd43813cabf18417605fb9eefb9aacf95c8d`. GitHub reports MERGEABLE after the push. Master advanced twice during this conflict-resolution pass: first its confirmation-recovery migration took 0398, then its continuation-recovery migration took 0399. Both upstream migrations and journal entries remain unchanged; Coordinator preferences are now generated as idempotent `0400_sad_guardian.sql` from upstream's latest snapshot. Exactly the five newest snapshots remain. The replay regression now locates the table migration by content instead of hardcoding a renumbered filename. - All 328 targeted question/review/confirmation/migration tests passed again after the second merge. Workspace typecheck/build and fresh exact-head CI/reviews are in progress. The preceding `0c46f46d6` passed workspace typecheck/build and Superagent security scan, but was superseded because master consumed migration 0399 while those checks ran. That prior-head result is not acceptance of the current head. No production settings or runner/security permissions were changed, and the PR has not been merged. - Previous integration head: `0c46f46d6f2b23417ab872ce3cb6ff2673647287`, integrating master `287b04d72f1b9fca1412e05435c75b8302ba0710`. GitHub reports MERGEABLE after the push. The renewed conflicts were `0398_snapshot.json`, `_journal.json`, and the top imports in `issue-thread-interactions.ts`. Upstream's `0398` confirmation-recovery index and journal history are preserved unchanged; Coordinator preferences were regenerated as idempotent `0399_bouncy_miek.sql`, with replay coverage updated and exactly the five newest snapshots retained. Both terminal confirmation notifications and Coordinator task assignment/required review behavior are preserved. - All 328 targeted interaction/review/confirmation/migration tests pass, as do workspace typecheck, map validation and whitespace checks. The workspace build and fresh exact-head CI/Greptile/Superagent checks are pending. The first migration-generation attempt hit the sandbox's local IPC restriction before generating files; the unchanged authorized local generation completed successfully. Prior-head green checks below do not establish acceptance of this merge. - Previous acceptance head: `8b7dcf739ed15afc51351fdfa0e0e5fbc75ab788`, with master `1aa3a21ac` integrated and GitHub reporting MERGEABLE. Greptile completed a fresh 5/5 review on this exact head with zero new actionable findings and no open review threads. The [fresh CI workflow](https://github.com/paperclipai/paperclip/actions/runs/40752864319) completed SUCCESS on attempt 2 at 19:40:08 UTC, including all eight E2E shards. Final completed check set: 55 succeeded, four conditional checks skipped, zero pending/queued/running checks, and one neutral/inconclusive Superagent scan. The auxiliary commitperclip review and isolated native Runner compilation/cache-reuse check both passed. This is not a claim that Superagent produced a passed security verdict. GitHub still reports MERGEABLE against current master `60b8089a44b4eaa37e627adbfdf2f130bda13335`. - Current-head E2E: all eight shards and the aggregate passed, including the previously failing YAML browser journey. Serialized server shard 9/9 failed: the protected YAML projection test exceeded its original 15-second timeout; its late update request then reached the next test's reset mock (the captured payload is the prior test's model/label update). All 88 tests in that exact unchanged file passed locally in 38.03 seconds, with no timeout or assertion changes. The original slow-request cause remains unproven. CI failure log: `/tmp/pr17983-8b7-serialized9.log`; local recovery: `/tmp/pr17983-adapter-yaml-repro.log`. The single bounded unchanged shard rerun passed, and the workflow completed SUCCESS. Rerun log: `/tmp/pr17983-8b7-serialized9-rerun.log`. The initial failure is retained; a passing retry does not establish its original slow-request cause. - Greptile scored preceding head `4873704be` 5/5 with one valid P2: opened task decision records missed company-scoped live invalidation. The current head uses the existing company decision prefix for resolution and effect-completion events, and resets private record payloads on access changes. Its thread is resolved. All 107 focused record/live-update tests, UI typecheck/build, token checks and whitespace checks pass. - CI on `4873704be` failed E2E shard 7/8 in the Advanced YAML lost-creation-response journey: its clipboard helper selected page text starting with “Skip to Main Content” instead of YAML. The exact unchanged journey passed in a disposable local browser instance (1 test, 17.1 seconds). No assertion, timeout or production behavior was weakened; the original failure cause remains unproven. Failure log: `/tmp/pr17983-487-e2e7.log`; local check: `/tmp/pr17983-agent-yaml-repro.log`. The full unchanged Advanced YAML browser suite also passed locally (6 tests, 37.8 seconds). Fresh current-head CI subsequently passed this journey and all other E2E shards. - Both the automatic and one supported on-demand Superagent scan on `4873704be` ended neutral/inconclusive: “Pinned PR scan merge-base checkout failed or timed out.” These do not count as a passed security verdict. The current head's automatic scan and one documented on-demand retry also returned the identical neutral checkout failure, with zero annotations or further diagnostics. This is an external scanner blocker, not a passed security verdict. No security settings or permissions were changed. - Recorded decision links now render and focus the full source-task record in both Classic and Coordinator, including recorded choice, submitted inputs, and the existing effect-result resolver. Fresh terminal records take precedence over older open-decision cache entries. Context and account checks keep mismatched or inaccessible records out of the DOM; no decision-history tab was added to tasks or chat. The shared company live-run feed now drives live-only filtering, including ended runs and terminal tasks with stale run entries. All 213 focused tests, UI typecheck/build, token and whitespace checks pass; the final focus follow-up passed all 188 task-detail tests and UI typecheck. The first new navigation test failed because its test host omitted company context; the host was corrected before the passing run. - Previous integration head: `375c5e89516705050d94bab99336212841b2e6e1` merges master `1aa3a21ac` after four additional upstream commits. The sole conflict was competing imports in `server/src/services/issues.ts`; both quality-review policy and inbound wake-notice notifications are preserved. The PR-specific review import now sits beside execution-policy imports instead of the frequently changing first line. GitHub mergeability is rechecked after the push. - On the combined master tree, workspace typecheck/build, all 153 affected UI tests, map validation, and whitespace checks pass. Four server suites passed 77 tests; the fifth suite's module-import hook timed out while broad verification was running. Its unchanged isolated run passed all 41 tests in 7.2 seconds with the original timeout. This records recovery without claiming the original import-timeout cause is proven. CI on `375c5e895` passed every substantive job, including all eight E2E shards and Superagent; Greptile found the two functional gaps fixed in the current head. A short-lived `669d90876` commit added the main fixes before the focused navigation follow-up. - Immediately preceding head `9d9737b49` completed all 56 checks successfully with four conditional skips, Greptile 5/5 and no open findings, plus a successful Superagent scan. The signoff E2E shard passed on its single accepted rerun; its initial cancellation/timing failure is retained below. Master moved again while those checks ran, requiring this final integration rather than treating the prior head's green result as current acceptance. - Previous head `9d9737b496911a6054d0ea22d1b42b28b115e9ab` includes master `d30c8f42b842327ee1c18c41a2efd6ba623da5cd`; that head was subsequently conflicted by moving master. The master merge preserved durable account-bound writes and Coordinator UX. Workspace typecheck/build, 416 focused UI tests, and 142 affected comment-route tests passed. A stable full UI run on preceding head `938ad1665` passed all 9,833 tests across 836 files; its final full workspace build also passed. - Greptile found nested proposal project inheritance and Classic bound-revision links on `91be74952`. Both were fixed with 142 interaction-route tests, 113 focused UI tests, and UI/server typechecks. Its next review identified a valid draft-preservation bug in the new Classic loading UI. Head `9d9737b49` keeps loading/error notices outside editors and annotations while preserving dirty drafts; 115 focused review UI tests pass, including pending/failed revision loads and continued draft editing. All related threads are resolved. Greptile completed a fresh 5/5 review of `9d9737b496911a6054d0ea22d1b42b28b115e9ab` with no open findings. - CI on `938ad1665` exposed an integration regression with the newly merged durable startup saves: the personal preference gate blocked the task page before its first session lookup. The guarded title editor now mounts while that lookup is pending, with presentation-specific tools still gated. All 216 affected component tests pass. The unchanged five-test `disconnect-write-recovery.spec.ts` browser suite passes against a newly launched disposable local-trusted PostgreSQL instance on port 33219, including the exact failed startup-save journey. No live provider, hosted authentication or production proof is claimed. The helper-owned test server exited and the port has no listener. UI typecheck, built-browser assets, token and whitespace checks pass. - Initial durable-write merge tests found duplicate imports and unscoped draft fixtures, fixed before 416 focused tests passed. A sandbox typecheck could not create its IPC socket; the supported rerun passed. The first revision-link test used a wrong Return to latest button assertion, corrected before the 113-test pass. The startup E2E reproduction initially still failed because an outer shell gate also blocked the page; the subsequent fix passed all five cases without changing the test or its timeouts. A focused loading-header assertion initially used an incorrect fixture title; correcting it preceded the 216-test pass. These failures remain recorded. - Earlier routing gates fell back to GitHub-hosted runners while master was moving or conflicted. Superseded queued runs were cancelled, then the `938ad1665` routing gate explicitly selected the ephemeral RunsOn fleet. Its CI actively executed and completed most tests; only the diagnosed startup E2E shard and aggregate failed, alongside the valid Greptile finding. Auxiliary GitHub-hosted workflows also completed successfully on earlier heads, so queueing alone is not an administrative blocker. Fresh [CI on `9d9737b49`](https://github.com/paperclipai/paperclip/actions/runs/40744012678) is the acceptance target; the previously failing startup E2E shard now passes. A different signoff E2E shard failed during executor resubmission when its fixture run was cancelled as `issue_continuation_waiting_on_review`. The exact unchanged journey passed locally (1 test, 46 seconds), and the preceding head with identical server/signoff code passed that CI shard. This supports a bounded rerun but does not establish the timing failure's root cause. After the workflow finished, GitHub accepted one rerun of that failed shard and its dependent aggregate; both passed, completing all checks on that head. The failure log is retained at `/tmp/pr17983-9d9737-e2e7.log` and the local reproduction at `/tmp/pr17983-signoff-repro.log`. No assertion or timeout was weakened. - On the first merge, full workspace typecheck/build, all 9,622 UI tests, 267 tests across seven affected server suites, two migration checks, map validation, token gates, and the PR diff whitespace check passed. Greptile then found duplicate local task-search filtering and lost completed item-review detail. Both are fixed, with 42 passing focused UI tests and passing UI typecheck/build. - A subsequent Greptile review found attachment confirmations without working links and mobile history without a visible host. Confirmation layouts now derive the authenticated immutable-content endpoint from the attachment ID, and Needs You uses the existing full-screen mobile sheet. All 119 focused tests pass, including missing/stale display URLs, both review layouts, and both mobile history entry buttons. UI typecheck/build and token checks pass. Full workspace typecheck/build also pass after the second master merge. - Greptile gave head22f69c304a 5/5 score with one non-blocking desktop-history reopening finding. Head6dd52b6d3fixed it, passed all nine history tests, UI typecheck/build, token gates, and the full 9,679-test UI suite, then received a fresh 5/5 review with zero open findings. These are prior-head results; review on the master-sync commit is pending. - The chat and workspace CI jobs on head22f69c304were interrupted by runner shutdown signals and cancellation before completing their tests. Their logs do not report failing assertions. Those interrupted jobs are not claimed as passes. The new head starts fresh runs. - The first merge CI had a Slack session-sync idle assertion fail after an unexpected database read. Its exact isolated reproduction passes, and the chat CI shard passed on head618c5a2a3. The original failure's cause remains undetermined. The broader local reproduction, run concurrently with full verification, instead encountered 21 timeout failures across its two test chunks; it is not claimed as a passing full local server run. A concurrent local UI run had eight failures (seven timeouts and one delayed autosave assertion). The complete UI run on the final head passed all 9,679 tests across 830 files with two workers; no test timeout or assertion was weakened. This establishes recovery without claiming that every earlier timeout's cause has been proved. An earlier intermediate UI run also overlapped the second master merge and failed the newly added Advanced-sidebar expectation, so it is not treated as stable-tree evidence. The newly merged UI dependencies initially required refreshing the local install from the upstream package manifest; the generated local lockfile update is not committed, per repository policy. - Superagent returned neutral/inconclusive scans on the preceding heads because its pinned merge-base checkout failed or timed out. The available retry endpoint returned 404. These are not successful security verdicts. The fresh scan on `91be74952` passed (PR scan passed; no suspicious PR changes detected). The `938ad1665` scan again returned neutral/inconclusive with the same pinned merge-base checkout error; the check-suite rerun endpoint returned 404. The fresh `9d9737b49` scan completed successfully at 18:22 UTC with no suspicious changes detected. Earlier neutral scans are not counted as successful security verdicts. - Prior head `57902152ac3218096fca669d33ff18400a2a86ae` passed 9,618 UI tests across 826 files, received Greptile 5/5 with no open findings, and completed CI with 56 passes and four conditional skips. These are historical results, not acceptance of the latest merge commit. - The first full build found generated capability-contract drift. The generated outputs were refreshed. Initial sandbox runs could not open local IPC sockets; verification was rerun with local test access. - Current master was merged. The workspace preference migration was regenerated after the existing migration history. - The UI run first found two outdated expectations: early custom-answer validation and the document access error copy. Both were corrected, and the full UI suite then passed. - The local server run found three failures in unchanged tests. The Muse test passes with Python 3.13 instead of the host's Python 3.9. The two workspace tests pass when their test process uses the expected master default branch. These environment settings do not change application behavior or global machine settings. The unsharded server run was stopped after those reproductions; CI supplies the full sharded server result. No successful full local server run is claimed. - Skill inventory generation needs an external eval checkout, which is absent locally. The existing generator functions refreshed only the live skill inventory and its derived files. The checked-in eval inventory was preserved. The inventory validation gate passes. - Greptile found a dropped MCP review requirement, missing per-item output links, generic item-review summaries, and a history-refresh failure. The fixes have 32 passing database-backed server tests and focused rendered-card tests. A follow-up partial-review finding was corrected by forwarding the canonical mutation status before settling the card. Attachments open through the authenticated immutable-content route in both card layouts. The final focused UI set has 117 passing tests, including these regressions. - Both browser shards that first failed expected a disabled-chat message. The copy was restored, and those shards passed in CI on the next commit. The two journeys also passed locally. One local attempt first timed out before feature disable while waiting for the provider's initial message; its isolated reproduction passed. That earlier timing failure remains recorded and is not presented as an explained infrastructure failure. - Serialized server shard 9 first failed during pnpm setup with ECONNRESET, before dependencies or tests ran. Its single rerun passed setup and all tests. The build and production runtime boot passed on the first attempt, but that run's public-install step timed out during Pi setup. The single build-job rerun passed compilation, runtime boot, and clean public-install verification. Those setup scripts are unchanged by this PR. The successful retry establishes recovery; the earlier Pi timeout's underlying cause remains undetermined. The aggregate CI gate is green: [workflow run](https://github.com/paperclipai/paperclip/actions/runs/40637789695). </details> ## Risks - This touches shared task, interaction, and completion paths. Regression tests must cover classic and experimental behavior, authorization, duplicate answers, and stale review targets. - The additive preference table must migrate before the setting is used. The setting defaults off. - The experiment changes navigation and message presentation. Canonical task and document records remain the source of truth. - The initial task brief and saved plan can repeat information. This change fixes chronology; a broader redundancy policy remains a design decision. ## Model Used OpenAI GPT-6 Codex with reasoning and tool-assisted code editing, tests, and browser verification. Earlier iterations used Codex models in this task; their exact model IDs are not available in the current context. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used - [x] I have checked ROADMAP.md - [x] I have searched GitHub for duplicate or related PRs - [x] I have described the issue in-PR following the relevant issue template - [x] I have not referenced internal/instance-local Paperclip issues or links - [x] My branch name describes the change - [x] I have run relevant tests locally and they pass - [x] I have added or updated tests where applicable - [x] I have updated relevant documentation - [x] I have documented risks - [x] All Paperclip CI gates are green - [x] Greptile is 5/5 with no open recommendations or follow-ups - [x] I will address review comments before requesting merge --------- Co-authored-by: Paperclip <noreply@paperclip.ing>
4139 lines
161 KiB
TypeScript
4139 lines
161 KiB
TypeScript
import { createContext, useContext, useEffect, useMemo, useRef, useState, type ReactNode } from "react";
|
|
import type { Agent } from "@paperclipai/shared";
|
|
import { AlertTriangle, ArrowUpRight, Bot, Check, CheckCircle2, ChevronDown, ChevronRight, CircleDashed, Clock, ExternalLink, FileText, GitBranch, ImagePlus, KeyRound, Loader2, MessageSquareQuote, MinusCircle, ShieldAlert, ThumbsUp, TriangleAlert, Wrench, X, XCircle } from "lucide-react";
|
|
import { Link } from "@/lib/router";
|
|
import { formatAssigneeUserLabel } from "../lib/assignees";
|
|
import { describeInteractionAudience, type InteractionAudienceDescription } from "../lib/interaction-audience";
|
|
import { interactionResolutionErrorMessage } from "../lib/interaction-resolution-error";
|
|
import { buildDocumentAnnotationHash } from "../lib/document-annotation-hash";
|
|
import { itemVerdictHref } from "@/lib/item-verdict-links";
|
|
import {
|
|
isInteractionPreparingApproval,
|
|
buildSuggestedTaskTree,
|
|
collectSuggestedTaskClientKeys,
|
|
countSuggestedTaskNodes,
|
|
getCheckboxConfirmationSelectedLabels,
|
|
getItemVerdictProgress,
|
|
getQuestionAnswerLabels,
|
|
shouldHideInteractionCard,
|
|
normalizeRequestConfirmationTargetHref,
|
|
type AskUserQuestionsAnswer,
|
|
type AskUserQuestionsInteraction,
|
|
type IssueThreadInteraction,
|
|
type RequestCheckboxConfirmationInteraction,
|
|
type RequestConfirmationInteraction,
|
|
type RequestConfirmationTarget,
|
|
type RequestItemVerdictsInteraction,
|
|
type RequestItemVerdictsItem,
|
|
type RequestItemVerdictsResultItem,
|
|
type RequestItemVerdictValue,
|
|
type SuggestTasksInteraction,
|
|
type SuggestTasksResultCreatedTask,
|
|
type SuggestedTaskDraft,
|
|
type SuggestedTaskTreeNode,
|
|
} from "../lib/issue-thread-interactions";
|
|
import { cn, formatDateTime, formatShortDate } from "../lib/utils";
|
|
import { InteractionPreparationNotice } from "./InteractionPreparationNotice";
|
|
import { InteractionAudienceLine } from "./InteractionAudienceLine";
|
|
import { MarkdownBody, type MarkdownExternalReferenceMap } from "./MarkdownBody";
|
|
import { Button } from "./ui/button";
|
|
import { Checkbox } from "./ui/checkbox";
|
|
import { Collapsible, CollapsibleContent, CollapsibleTrigger } from "./ui/collapsible";
|
|
import { PriorityIcon } from "./PriorityIcon";
|
|
import { SHOW_TASK_PRIORITY_UI } from "../lib/ui-flags";
|
|
import { Textarea } from "./ui/textarea";
|
|
import { Tooltip, TooltipContent, TooltipTrigger } from "./ui/tooltip";
|
|
import { Badge } from "@/components/ui/badge";
|
|
import { ProposalJustification } from "../pages/secrets/proposal-review";
|
|
import { DropdownMenu, DropdownMenuContent, DropdownMenuItem, DropdownMenuTrigger } from "./ui/dropdown-menu";
|
|
import { AppLogo } from "@/pages/apps/AppLogo";
|
|
import { ConnectionIntentInteractionBody } from "@/features/connections/ConnectionIntentInteractionBody";
|
|
import { QuestionForm } from "./task-chat/QuestionForm";
|
|
import { useCoordinatorWorkspaceEnabled } from "@/hooks/useCoordinatorWorkspaceEnabled";
|
|
import { CoordinatorTaskCommitment } from "./coordinator/CoordinatorTaskCommitment";
|
|
|
|
import { DecisionCardFooter } from "./DecisionCardFooter";
|
|
|
|
const OTHER_ANSWER_ID = "__paperclip_other__";
|
|
|
|
/**
|
|
* The card's server-evaluated audience, shared with the per-kind subcards below
|
|
* (PAP-17287). A subcard that catches a rejected resolution needs to name who
|
|
* *can* respond, and re-deriving the audience per subcard would let two parts of
|
|
* the same card describe one policy differently.
|
|
*/
|
|
const InteractionAudienceContext = createContext<InteractionAudienceDescription | null>(null);
|
|
|
|
/**
|
|
* Turns a rejected resolution into copy for the inline error region: the
|
|
* server's own denial reason, plus who can respond when the denial is an
|
|
* audience refusal. Never invites a retry that policy will refuse again.
|
|
*/
|
|
function useResolutionErrorMessage() {
|
|
const audience = useContext(InteractionAudienceContext);
|
|
return (error: unknown) => interactionResolutionErrorMessage(error, audience);
|
|
}
|
|
|
|
/**
|
|
* The inline resolution error. Announced through an `aria-live` region because a
|
|
* denial is the only feedback a failed decision gets — the row stays put and no
|
|
* toast fires on the attention surface.
|
|
*
|
|
* The live region is the *outer* wrapper, mounted whether or not there is a
|
|
* message: a region has to be in the accessibility tree before its content
|
|
* changes for the change to be announced. The styled inner div deliberately
|
|
* carries no `role="alert"` — `alert` is itself an assertive live region, and
|
|
* nesting one inside another makes some screen reader / browser pairs announce
|
|
* the same denial twice (PAP-17289).
|
|
*/
|
|
function InteractionActionError({ message }: { message: string | null }) {
|
|
return (
|
|
<div aria-live="assertive" data-testid="interaction-action-error">
|
|
{message ? (
|
|
<div className="rounded-sm border border-destructive/60 bg-destructive/10 px-3 py-2 text-sm text-destructive">
|
|
{message}
|
|
</div>
|
|
) : null}
|
|
</div>
|
|
);
|
|
}
|
|
|
|
interface IssueThreadInteractionCardProps {
|
|
interaction: IssueThreadInteraction;
|
|
/** Reuse the resolver without the task timeline's audit/header chrome. */
|
|
footerSlot?: ReactNode;
|
|
presentationVariant?: "default" | "coordinator-decision";
|
|
agentMap?: Map<string, Agent>;
|
|
currentUserId?: string | null;
|
|
userLabelMap?: ReadonlyMap<string, string> | null;
|
|
onAcceptInteraction?: (
|
|
interaction:
|
|
| SuggestTasksInteraction
|
|
| RequestConfirmationInteraction
|
|
| RequestCheckboxConfirmationInteraction,
|
|
selectedClientKeys?: string[],
|
|
selectedOptionIds?: string[],
|
|
rememberAction?: boolean,
|
|
) => Promise<void> | void;
|
|
onRejectInteraction?: (
|
|
interaction:
|
|
| SuggestTasksInteraction
|
|
| RequestConfirmationInteraction
|
|
| RequestCheckboxConfirmationInteraction,
|
|
reason?: string,
|
|
) => Promise<void> | void;
|
|
onSubmitInteractionAnswers?: (
|
|
interaction: AskUserQuestionsInteraction,
|
|
answers: AskUserQuestionsAnswer[],
|
|
) => Promise<void> | void;
|
|
onCancelInteraction?: (
|
|
interaction: AskUserQuestionsInteraction,
|
|
) => Promise<void> | void;
|
|
/** Render confirmation CTAs with the primary action rightmost (task-chat grammar). */
|
|
primaryActionOnRight?: boolean;
|
|
onSubmitInteractionVerdicts?: (
|
|
interaction: RequestItemVerdictsInteraction,
|
|
verdicts: { id: string; verdict: RequestItemVerdictValue; reason?: string }[],
|
|
) => Promise<void> | void;
|
|
onUploadImage?: (file: File) => Promise<string>;
|
|
externalReferences?: MarkdownExternalReferenceMap;
|
|
}
|
|
|
|
function resolveActorLabel(args: {
|
|
agentId?: string | null;
|
|
userId?: string | null;
|
|
agentMap?: Map<string, Agent>;
|
|
currentUserId?: string | null;
|
|
userLabelMap?: ReadonlyMap<string, string> | null;
|
|
}) {
|
|
const { agentId, userId, agentMap, currentUserId, userLabelMap } = args;
|
|
if (agentId) {
|
|
return agentMap?.get(agentId)?.name ?? agentId.slice(0, 8);
|
|
}
|
|
if (userId) {
|
|
return formatAssigneeUserLabel(userId, currentUserId, userLabelMap) ?? "Board";
|
|
}
|
|
return "Unknown";
|
|
}
|
|
|
|
/**
|
|
* Administrative terminal outcomes (P1): an interaction that was withdrawn by
|
|
* its board/agent, or auto-expired when its issue reached a terminal state.
|
|
* Both are stored as `status="cancelled"|"expired"` with the distinguishing
|
|
* fact carried on `result.outcome` (there is no dedicated `withdrawn` status).
|
|
*/
|
|
function getAdministrativeOutcome(
|
|
interaction: IssueThreadInteraction,
|
|
): "withdrawn" | "issue_closed" | null {
|
|
const result = interaction.result;
|
|
if (result && typeof result === "object" && "outcome" in result) {
|
|
const outcome = (result as { outcome?: string | null }).outcome;
|
|
if (outcome === "withdrawn" || outcome === "issue_closed") return outcome;
|
|
}
|
|
return null;
|
|
}
|
|
|
|
function getAdministrativeReason(interaction: IssueThreadInteraction): string | null {
|
|
const result = interaction.result;
|
|
if (result && typeof result === "object" && "reason" in result) {
|
|
const reason = (result as { reason?: string | null }).reason;
|
|
if (typeof reason === "string" && reason.trim().length > 0) return reason.trim();
|
|
}
|
|
return null;
|
|
}
|
|
|
|
function statusLabel(status: IssueThreadInteraction["status"]) {
|
|
switch (status) {
|
|
case "pending":
|
|
return "Pending";
|
|
case "accepted":
|
|
return "Accepted";
|
|
case "rejected":
|
|
return "Rejected";
|
|
case "answered":
|
|
return "Answered";
|
|
case "cancelled":
|
|
return "Cancelled";
|
|
case "expired":
|
|
return "Expired";
|
|
case "failed":
|
|
return "Failed";
|
|
default:
|
|
return status;
|
|
}
|
|
}
|
|
|
|
function interactionKindLabel(kind: IssueThreadInteraction["kind"]) {
|
|
switch (kind) {
|
|
case "suggest_tasks":
|
|
return "Suggested tasks";
|
|
case "ask_user_questions":
|
|
return "Ask user questions";
|
|
case "request_confirmation":
|
|
return "Confirmation";
|
|
case "request_checkbox_confirmation":
|
|
return "Checkbox confirmation";
|
|
case "request_item_verdicts":
|
|
return "Item verdicts";
|
|
case "connection_intent":
|
|
return "Connection request";
|
|
default:
|
|
return kind;
|
|
}
|
|
}
|
|
|
|
function statusIcon(status: IssueThreadInteraction["status"]) {
|
|
switch (status) {
|
|
case "accepted":
|
|
case "answered":
|
|
return CheckCircle2;
|
|
case "rejected":
|
|
case "cancelled":
|
|
case "failed":
|
|
return XCircle;
|
|
case "expired":
|
|
return AlertTriangle;
|
|
default:
|
|
return CircleDashed;
|
|
}
|
|
}
|
|
|
|
function statusClasses(status: IssueThreadInteraction["status"]) {
|
|
switch (status) {
|
|
case "accepted":
|
|
case "answered":
|
|
return {
|
|
shell: "border-emerald-400/70 bg-transparent",
|
|
badge: "border-emerald-500/60 bg-emerald-500/10 text-emerald-900 dark:bg-emerald-500/15 dark:text-emerald-100",
|
|
};
|
|
case "rejected":
|
|
case "cancelled":
|
|
return {
|
|
shell: "border-rose-400/70 bg-transparent",
|
|
badge: "border-rose-500/60 bg-rose-500/10 text-rose-900 dark:bg-rose-500/15 dark:text-rose-100",
|
|
};
|
|
case "failed":
|
|
case "expired":
|
|
return {
|
|
shell: "border-amber-400/70 bg-transparent",
|
|
badge: "border-amber-500/60 bg-amber-500/10 text-amber-900 dark:bg-amber-500/15 dark:text-amber-100",
|
|
};
|
|
default:
|
|
return {
|
|
shell: "border-sky-500/70 bg-transparent",
|
|
badge: "border-sky-500/70 bg-sky-500/10 text-sky-900 dark:bg-sky-500/15 dark:text-sky-100",
|
|
};
|
|
}
|
|
}
|
|
|
|
/**
|
|
* A confirmation that targets the issue's `plan` document renders as a distinct
|
|
* plan card (PAP-95g): a full state-coloured outline — violet while in review,
|
|
* green once approved, red when changes are requested (PAP-75 palette) — with no
|
|
* left stripe, so plans stand out from comments and status rows.
|
|
*/
|
|
function isPlanConfirmation(interaction: IssueThreadInteraction): boolean {
|
|
if (interaction.kind !== "request_confirmation") return false;
|
|
const target = interaction.payload.target;
|
|
return target?.type === "issue_document" && target?.key === "plan";
|
|
}
|
|
|
|
function requestConfirmationResumeFailure(interaction: IssueThreadInteraction) {
|
|
if (interaction.kind !== "request_confirmation" && interaction.kind !== "request_checkbox_confirmation") return null;
|
|
return interaction.result?.resumeFailure ?? null;
|
|
}
|
|
|
|
function planStatusClasses(
|
|
status: IssueThreadInteraction["status"],
|
|
resumeFailure?: ReturnType<typeof requestConfirmationResumeFailure>,
|
|
outcome?: string | null,
|
|
) {
|
|
switch (status) {
|
|
case "accepted":
|
|
case "answered":
|
|
if (resumeFailure) {
|
|
return {
|
|
shell: "border-2 border-amber-500/70 bg-transparent",
|
|
badge: "border-amber-500/60 bg-amber-500/10 text-amber-900 dark:bg-amber-500/15 dark:text-amber-100",
|
|
label: "Approved — agent resume failed",
|
|
Icon: AlertTriangle,
|
|
};
|
|
}
|
|
return {
|
|
shell: "border-2 border-green-500/80 bg-transparent",
|
|
badge: "border-green-500/60 bg-green-500/10 text-green-900 dark:bg-green-500/15 dark:text-green-100",
|
|
label: "Approved",
|
|
Icon: CheckCircle2,
|
|
};
|
|
case "rejected":
|
|
case "cancelled":
|
|
return {
|
|
shell: "border-2 border-red-500/80 bg-transparent",
|
|
badge: "border-red-500/60 bg-red-500/10 text-red-900 dark:bg-red-500/15 dark:text-red-100",
|
|
label: outcome === "withdrawn" ? "Withdrawn" : "Changes requested",
|
|
Icon: XCircle,
|
|
};
|
|
case "failed":
|
|
case "expired":
|
|
return {
|
|
shell: "border-2 border-amber-500/70 bg-transparent",
|
|
badge: "border-amber-500/60 bg-amber-500/10 text-amber-900 dark:bg-amber-500/15 dark:text-amber-100",
|
|
label: "Expired",
|
|
Icon: AlertTriangle,
|
|
};
|
|
default:
|
|
return {
|
|
shell: "border-2 border-violet-500/80 bg-transparent",
|
|
badge: "border-violet-500/60 bg-violet-500/10 text-violet-900 dark:bg-violet-500/15 dark:text-violet-100",
|
|
label: "In review",
|
|
Icon: FileText,
|
|
};
|
|
}
|
|
}
|
|
|
|
/**
|
|
* A `request_confirmation` that carries a `payload.toolAction` block gates a
|
|
* write/destructive MCP tool call (PAP-13726 §D1). It renders as a dedicated
|
|
* tool-approval card (PAP-13745) instead of the generic confirmation rendering.
|
|
* The governing rule: approve = run, so the card never terminally reads
|
|
* "Accepted" — terminal states are Executed / Failed / Declined / Expired.
|
|
*/
|
|
function toolActionPayload(
|
|
interaction: IssueThreadInteraction,
|
|
): NonNullable<RequestConfirmationInteraction["payload"]["toolAction"]> | null {
|
|
if (interaction.kind !== "request_confirmation") return null;
|
|
return interaction.payload.toolAction ?? null;
|
|
}
|
|
|
|
function isToolActionConfirmation(interaction: IssueThreadInteraction): boolean {
|
|
return toolActionPayload(interaction) != null;
|
|
}
|
|
|
|
function secretProposalPayload(
|
|
interaction: IssueThreadInteraction,
|
|
): NonNullable<RequestConfirmationInteraction["payload"]["secretProposal"]> | null {
|
|
if (interaction.kind !== "request_confirmation") return null;
|
|
return interaction.payload.secretProposal ?? null;
|
|
}
|
|
|
|
function isSecretProposalConfirmation(interaction: IssueThreadInteraction): boolean {
|
|
return secretProposalPayload(interaction) != null;
|
|
}
|
|
|
|
/**
|
|
* A `request_confirmation` carrying `payload.connectionAuthorization` is asking
|
|
* one person to connect their own account so an agent can act as them
|
|
* (PAP-17835). It keeps the interaction kind and the server-addressed audience;
|
|
* only the presentation differs, and it reads that presentation from the payload
|
|
* rather than parsing the title string.
|
|
*/
|
|
function connectionAuthorizationPayload(
|
|
interaction: IssueThreadInteraction,
|
|
): NonNullable<RequestConfirmationInteraction["payload"]["connectionAuthorization"]> | null {
|
|
if (interaction.kind !== "request_confirmation") return null;
|
|
return interaction.payload.connectionAuthorization ?? null;
|
|
}
|
|
|
|
/**
|
|
* The five states the connection-authorization card can be read in (PAP-17859).
|
|
*
|
|
* `actionable` and `waiting` are the *same* pending row seen by two different
|
|
* readers: consent belongs to the addressed person alone, so who is looking
|
|
* changes what may be offered — not merely whether a button is greyed out.
|
|
*/
|
|
type ConnectionAuthorizationCardState =
|
|
| "actionable"
|
|
| "waiting"
|
|
| "connected"
|
|
| "declined"
|
|
| "expired";
|
|
|
|
function connectionAuthorizationCardState({
|
|
interaction,
|
|
isAddressee,
|
|
}: {
|
|
interaction: RequestConfirmationInteraction;
|
|
isAddressee: boolean;
|
|
}): ConnectionAuthorizationCardState {
|
|
if (interaction.status === "accepted") return "connected";
|
|
if (interaction.status === "rejected") return "declined";
|
|
if (interaction.status === "pending") return isAddressee ? "actionable" : "waiting";
|
|
// expired / cancelled / failed all mean the same thing to a reader here: the
|
|
// authorization run this card carried is over.
|
|
return "expired";
|
|
}
|
|
|
|
/**
|
|
* True only when the signed-in reader *is* the person the server addressed.
|
|
*
|
|
* Deliberately strict: an unknown viewer (`currentUserId` not loaded yet) is
|
|
* never treated as the addressee, so the Connect action cannot flash into view
|
|
* for someone who may not consent. The server re-authorizes the callback
|
|
* regardless; this only decides what the card offers.
|
|
*/
|
|
function isConnectionAuthorizationAddressee({
|
|
interaction,
|
|
currentUserId,
|
|
}: {
|
|
interaction: RequestConfirmationInteraction;
|
|
currentUserId?: string | null;
|
|
}): boolean {
|
|
const addressee = interaction.addresseeUserId;
|
|
if (!addressee || !currentUserId) return false;
|
|
return addressee === currentUserId;
|
|
}
|
|
|
|
/**
|
|
* The authorization URL this card may open, or `null`.
|
|
*
|
|
* A target is offered **only while the interaction is pending**. The server
|
|
* re-upserts this row with a freshly minted `state` every time it starts a new
|
|
* authorization run, so a pending card always carries a live target and a
|
|
* resolved/declined/expired one always carries a spent one. Gating on the
|
|
* status is therefore how "never reuse an expired OAuth URL" is enforced —
|
|
* there is no client-visible expiry on the payload to check instead.
|
|
*/
|
|
function connectionAuthorizationHref(interaction: RequestConfirmationInteraction): string | null {
|
|
if (interaction.status !== "pending") return null;
|
|
const href = interaction.payload.target?.href;
|
|
if (!href) return null;
|
|
return normalizeRequestConfirmationTargetHref(href);
|
|
}
|
|
|
|
type ToolActionCardState =
|
|
| "pending"
|
|
| "running"
|
|
| "executed"
|
|
| "failed"
|
|
| "cancelled"
|
|
| "declined"
|
|
| "expired";
|
|
|
|
/**
|
|
* Derives the visible lifecycle state from the interaction status plus the
|
|
* `result.toolAction.status` written back by the gateway. The card must render
|
|
* the resolved state without polling — the lifecycle metadata is authoritative,
|
|
* so an optimistic "running…" reconciles to the server's terminal state.
|
|
*/
|
|
function toolActionCardState(
|
|
interaction: RequestConfirmationInteraction,
|
|
): ToolActionCardState {
|
|
const execStatus = interaction.result?.toolAction?.status ?? null;
|
|
if (interaction.status === "pending") return "pending";
|
|
if (interaction.status === "rejected") return "declined";
|
|
if (interaction.status === "cancelled") return "cancelled";
|
|
if (interaction.status === "expired") return "expired";
|
|
// Terminal execution outcomes take precedence over the coarse interaction
|
|
// status so a self-resolving "running…" advances to its real result.
|
|
if (execStatus === "executed") return "executed";
|
|
if (execStatus === "failed") return "failed";
|
|
if (execStatus === "expired") return "expired";
|
|
if (interaction.status === "failed") return "failed";
|
|
// accepted + approved/executing/unknown → the transient running state.
|
|
return "running";
|
|
}
|
|
|
|
function toolActionStatusClasses(state: ToolActionCardState): {
|
|
shell: string;
|
|
badge: string;
|
|
label: string;
|
|
Icon: typeof CheckCircle2;
|
|
spin?: boolean;
|
|
dimmed?: boolean;
|
|
} {
|
|
switch (state) {
|
|
case "running":
|
|
return {
|
|
shell: "border-2 border-amber-500/70 bg-transparent",
|
|
badge: "border-amber-500/60 bg-amber-500/10 text-amber-900 dark:bg-amber-500/15 dark:text-amber-100",
|
|
label: "Running…",
|
|
Icon: Loader2,
|
|
spin: true,
|
|
};
|
|
case "executed":
|
|
return {
|
|
shell: "border-2 border-green-500/80 bg-transparent",
|
|
badge: "border-green-500/60 bg-green-500/10 text-green-900 dark:bg-green-500/15 dark:text-green-100",
|
|
label: "Executed",
|
|
Icon: CheckCircle2,
|
|
};
|
|
case "failed":
|
|
return {
|
|
shell: "border-2 border-amber-500/70 bg-transparent",
|
|
badge: "border-amber-500/60 bg-amber-500/10 text-amber-900 dark:bg-amber-500/15 dark:text-amber-100",
|
|
label: "Failed",
|
|
Icon: XCircle,
|
|
};
|
|
case "declined":
|
|
return {
|
|
shell: "border-2 border-red-500/80 bg-transparent",
|
|
badge: "border-red-500/60 bg-red-500/10 text-red-900 dark:bg-red-500/15 dark:text-red-100",
|
|
label: "Declined",
|
|
Icon: XCircle,
|
|
dimmed: true,
|
|
};
|
|
case "cancelled":
|
|
return { shell: "border-2 border-border bg-transparent", badge: "border-border bg-muted text-muted-foreground", label: "Cancelled", Icon: XCircle, dimmed: true };
|
|
case "expired":
|
|
return {
|
|
shell: "border-2 border-border bg-transparent",
|
|
badge: "border-border bg-muted/60 text-muted-foreground",
|
|
label: "Expired",
|
|
Icon: Clock,
|
|
dimmed: true,
|
|
};
|
|
default:
|
|
return {
|
|
shell: "border-2 border-violet-500/80 bg-transparent",
|
|
badge: "border-violet-500/60 bg-violet-500/10 text-violet-900 dark:bg-violet-500/15 dark:text-violet-100",
|
|
label: "Awaiting approval",
|
|
Icon: ShieldAlert,
|
|
};
|
|
}
|
|
}
|
|
|
|
function TaskField({
|
|
label,
|
|
value,
|
|
tone = "default",
|
|
}: {
|
|
label: string;
|
|
value: string;
|
|
tone?: "default" | "subtle";
|
|
}) {
|
|
return (
|
|
<span
|
|
className={cn(
|
|
"inline-flex items-center rounded-sm border px-2 py-0.5 text-(length:--text-nano) font-medium uppercase tracking-(--tracking-eyebrow)",
|
|
tone === "default"
|
|
? "border-border/70 bg-transparent text-foreground"
|
|
: "border-border/60 bg-transparent text-muted-foreground",
|
|
)}
|
|
>
|
|
{label}: {value}
|
|
</span>
|
|
);
|
|
}
|
|
|
|
function createdTaskMap(
|
|
createdTasks: readonly SuggestTasksResultCreatedTask[] | undefined,
|
|
) {
|
|
return new Map(
|
|
(createdTasks ?? []).map((entry) => [entry.clientKey, entry] as const),
|
|
);
|
|
}
|
|
|
|
function TaskTreeNode({
|
|
node,
|
|
createdByClientKey,
|
|
agentMap,
|
|
currentUserId,
|
|
userLabelMap,
|
|
depth = 0,
|
|
selectedClientKeys,
|
|
skippedClientKeys,
|
|
showSelection,
|
|
onToggleSelection,
|
|
}: {
|
|
node: SuggestedTaskTreeNode;
|
|
createdByClientKey: ReadonlyMap<string, SuggestTasksResultCreatedTask>;
|
|
agentMap?: Map<string, Agent>;
|
|
currentUserId?: string | null;
|
|
userLabelMap?: ReadonlyMap<string, string> | null;
|
|
depth?: number;
|
|
selectedClientKeys?: ReadonlySet<string>;
|
|
skippedClientKeys?: ReadonlySet<string>;
|
|
showSelection?: boolean;
|
|
onToggleSelection?: (node: SuggestedTaskTreeNode, checked: boolean) => void;
|
|
}) {
|
|
const visibleChildren = node.children.filter((child) => !child.task.hiddenInPreview);
|
|
const hiddenChildCount = node.children
|
|
.filter((child) => child.task.hiddenInPreview)
|
|
.reduce((sum, child) => sum + countSuggestedTaskNodes(child), 0);
|
|
const createdTask = createdByClientKey.get(node.task.clientKey);
|
|
const isSelected = selectedClientKeys?.has(node.task.clientKey) ?? false;
|
|
const isSkipped = skippedClientKeys?.has(node.task.clientKey) ?? false;
|
|
const assigneeLabel = resolveActorLabel({
|
|
agentId: node.task.assigneeAgentId,
|
|
userId: node.task.assigneeUserId,
|
|
agentMap,
|
|
currentUserId,
|
|
userLabelMap,
|
|
});
|
|
const hasExplicitAssignee = Boolean(
|
|
node.task.assigneeAgentId || node.task.assigneeUserId,
|
|
);
|
|
const labels = node.task.labels ?? [];
|
|
const hasMetadata = hasExplicitAssignee
|
|
|| Boolean(node.task.billingCode)
|
|
|| Boolean(node.task.projectId)
|
|
|| labels.length > 0;
|
|
|
|
return (
|
|
<>
|
|
<div
|
|
className={cn(
|
|
"relative border-b border-border/60 px-3 py-2.5 last:border-b-0",
|
|
depth > 0 && "before:absolute before:left-3 before:top-0 before:h-full before:w-px before:bg-border/70",
|
|
)}
|
|
style={depth > 0 ? { paddingLeft: `${depth * 24 + 12}px` } : undefined}
|
|
>
|
|
<div className="flex items-start justify-between gap-2">
|
|
<div className="min-w-0 flex-1">
|
|
<div className="flex items-start gap-2">
|
|
{showSelection ? (
|
|
<Checkbox
|
|
checked={isSelected}
|
|
onCheckedChange={(checked) => onToggleSelection?.(node, checked === true)}
|
|
aria-label={`Include ${node.task.title}`}
|
|
className="mt-0.5"
|
|
/>
|
|
) : null}
|
|
<div className="min-w-0 flex-1">
|
|
<div className="flex min-w-0 items-center gap-1.5">
|
|
{/* PAP-411: priority UI hidden behind SHOW_TASK_PRIORITY_UI. */}
|
|
{SHOW_TASK_PRIORITY_UI && node.task.priority ? (
|
|
<PriorityIcon
|
|
priority={node.task.priority}
|
|
className="mt-px"
|
|
/>
|
|
) : null}
|
|
<div className="min-w-0 truncate text-sm font-medium text-foreground">
|
|
{node.task.title}
|
|
</div>
|
|
</div>
|
|
{depth > 0 ? (
|
|
<div className="mt-0.5 text-(length:--text-nano) font-medium uppercase tracking-(--tracking-eyebrow) text-muted-foreground">
|
|
Child task
|
|
</div>
|
|
) : null}
|
|
{node.task.description ? (
|
|
<p className="mt-0.5 text-sm leading-5 text-muted-foreground">
|
|
{node.task.description}
|
|
</p>
|
|
) : null}
|
|
</div>
|
|
</div>
|
|
</div>
|
|
|
|
{createdTask?.issueId ? (
|
|
<Link
|
|
to={`/issues/${createdTask.identifier ?? createdTask.issueId}`}
|
|
className="inline-flex shrink-0 items-center gap-1 rounded-sm border border-emerald-500/50 bg-emerald-500/10 px-2.5 py-1 text-(length:--text-micro) font-medium text-emerald-900 transition-colors hover:bg-emerald-500/15 dark:text-emerald-100"
|
|
>
|
|
{createdTask.identifier ?? createdTask.issueId.slice(0, 8)}
|
|
<ChevronRight className="h-3 w-3" />
|
|
</Link>
|
|
) : isSkipped ? (
|
|
<span className="inline-flex shrink-0 items-center rounded-sm border border-amber-500/60 bg-amber-500/10 px-2.5 py-1 text-(length:--text-micro) font-medium text-amber-900 dark:text-amber-100">
|
|
Skipped
|
|
</span>
|
|
) : null}
|
|
</div>
|
|
|
|
{hasMetadata ? (
|
|
<div className="mt-2 flex flex-wrap gap-1.5">
|
|
{hasExplicitAssignee ? (
|
|
<TaskField label="Responsible" value={assigneeLabel} />
|
|
) : null}
|
|
{node.task.billingCode ? (
|
|
<TaskField label="Billing" value={node.task.billingCode} />
|
|
) : null}
|
|
{node.task.projectId ? (
|
|
<TaskField label="Project" value={node.task.projectId} tone="subtle" />
|
|
) : null}
|
|
{labels.map((label) => (
|
|
<TaskField key={label} label="Label" value={label} tone="subtle" />
|
|
))}
|
|
</div>
|
|
) : null}
|
|
|
|
{hiddenChildCount > 0 ? (
|
|
<div className="mt-2 flex items-center gap-2 rounded-sm border border-amber-500/60 bg-amber-500/10 px-3 py-2 text-xs text-amber-900 dark:text-amber-100">
|
|
<GitBranch className="h-3.5 w-3.5 shrink-0" />
|
|
<span>
|
|
{hiddenChildCount === 1
|
|
? "1 follow-on task hidden in preview"
|
|
: `${hiddenChildCount} follow-on tasks hidden in preview`}
|
|
</span>
|
|
</div>
|
|
) : null}
|
|
</div>
|
|
|
|
{visibleChildren.length > 0 ? (
|
|
<>
|
|
{visibleChildren.map((child) => (
|
|
<TaskTreeNode
|
|
key={child.task.clientKey}
|
|
node={child}
|
|
createdByClientKey={createdByClientKey}
|
|
agentMap={agentMap}
|
|
currentUserId={currentUserId}
|
|
userLabelMap={userLabelMap}
|
|
depth={depth + 1}
|
|
selectedClientKeys={selectedClientKeys}
|
|
skippedClientKeys={skippedClientKeys}
|
|
showSelection={showSelection}
|
|
onToggleSelection={onToggleSelection}
|
|
/>
|
|
))}
|
|
</>
|
|
) : null}
|
|
</>
|
|
);
|
|
}
|
|
|
|
function SuggestTasksCard({
|
|
footerSlot,
|
|
interaction,
|
|
agentMap,
|
|
currentUserId,
|
|
userLabelMap,
|
|
onAcceptInteraction,
|
|
onRejectInteraction,
|
|
}: {
|
|
footerSlot?: ReactNode;
|
|
interaction: SuggestTasksInteraction;
|
|
agentMap?: Map<string, Agent>;
|
|
currentUserId?: string | null;
|
|
userLabelMap?: ReadonlyMap<string, string> | null;
|
|
onAcceptInteraction?: (
|
|
interaction: SuggestTasksInteraction,
|
|
selectedClientKeys?: string[],
|
|
) => Promise<void> | void;
|
|
onRejectInteraction?: (
|
|
interaction: SuggestTasksInteraction,
|
|
reason?: string,
|
|
) => Promise<void> | void;
|
|
}) {
|
|
const [rejecting, setRejecting] = useState(false);
|
|
const [working, setWorking] = useState<"accept" | "reject" | null>(null);
|
|
const [rejectReason, setRejectReason] = useState(
|
|
interaction.result?.rejectionReason ?? "",
|
|
);
|
|
|
|
useEffect(() => {
|
|
setRejectReason(interaction.result?.rejectionReason ?? "");
|
|
if (interaction.status !== "pending") {
|
|
setRejecting(false);
|
|
setWorking(null);
|
|
}
|
|
}, [interaction.result?.rejectionReason, interaction.status]);
|
|
|
|
const roots = useMemo(
|
|
() =>
|
|
buildSuggestedTaskTree(interaction.payload.tasks).filter(
|
|
(node) => !node.task.hiddenInPreview,
|
|
),
|
|
[interaction.payload.tasks],
|
|
);
|
|
const createdByClientKey = useMemo(
|
|
() => createdTaskMap(interaction.result?.createdTasks),
|
|
[interaction.result?.createdTasks],
|
|
);
|
|
const skippedClientKeys = useMemo(
|
|
() => new Set(interaction.result?.skippedClientKeys ?? []),
|
|
[interaction.result?.skippedClientKeys],
|
|
);
|
|
const totalTasks = interaction.payload.tasks.length;
|
|
const [selectedClientKeys, setSelectedClientKeys] = useState<Set<string>>(
|
|
() => new Set(interaction.payload.tasks.map((task) => task.clientKey)),
|
|
);
|
|
const taskSelectionSeed = useMemo(
|
|
() => interaction.payload.tasks.map((task) => task.clientKey).join("\n"),
|
|
[interaction.payload.tasks],
|
|
);
|
|
|
|
useEffect(() => {
|
|
setSelectedClientKeys(new Set(interaction.payload.tasks.map((task) => task.clientKey)));
|
|
}, [interaction.id, interaction.status, taskSelectionSeed]);
|
|
|
|
const taskByClientKey = useMemo(
|
|
() => new Map(interaction.payload.tasks.map((task) => [task.clientKey, task] as const)),
|
|
[interaction.payload.tasks],
|
|
);
|
|
const selectedCount = selectedClientKeys.size;
|
|
const [actionError, setActionError] = useState<string | null>(null);
|
|
const resolutionErrorMessage = useResolutionErrorMessage();
|
|
const createdCount = interaction.result?.createdTasks?.length ?? 0;
|
|
const skippedCount = interaction.result?.skippedClientKeys?.length ?? 0;
|
|
|
|
async function handleAccept() {
|
|
if (!onAcceptInteraction) return;
|
|
setWorking("accept");
|
|
setActionError(null);
|
|
try {
|
|
await onAcceptInteraction(interaction, [...selectedClientKeys]);
|
|
} catch (error) {
|
|
setActionError(resolutionErrorMessage(error));
|
|
} finally {
|
|
setWorking(null);
|
|
}
|
|
}
|
|
|
|
async function handleReject() {
|
|
if (!onRejectInteraction) return;
|
|
setWorking("reject");
|
|
setActionError(null);
|
|
try {
|
|
await onRejectInteraction(interaction, rejectReason.trim() || undefined);
|
|
setRejecting(false);
|
|
} catch (error) {
|
|
setActionError(resolutionErrorMessage(error));
|
|
} finally {
|
|
setWorking(null);
|
|
}
|
|
}
|
|
|
|
function handleToggleSelection(node: SuggestedTaskTreeNode, checked: boolean) {
|
|
const subtreeClientKeys = collectSuggestedTaskClientKeys(node);
|
|
setSelectedClientKeys((current) => {
|
|
const next = new Set(current);
|
|
if (!checked) {
|
|
for (const clientKey of subtreeClientKeys) {
|
|
next.delete(clientKey);
|
|
}
|
|
return next;
|
|
}
|
|
|
|
for (const clientKey of subtreeClientKeys) {
|
|
next.add(clientKey);
|
|
}
|
|
|
|
let parentClientKey = taskByClientKey.get(node.task.clientKey)?.parentClientKey ?? null;
|
|
while (parentClientKey) {
|
|
next.add(parentClientKey);
|
|
parentClientKey = taskByClientKey.get(parentClientKey)?.parentClientKey ?? null;
|
|
}
|
|
return next;
|
|
});
|
|
}
|
|
|
|
return (
|
|
<div className="space-y-3">
|
|
<div className="flex flex-wrap items-center gap-2 text-xs text-muted-foreground">
|
|
<span>{totalTasks === 1 ? "1 draft issue" : `${totalTasks} draft issues`}</span>
|
|
{interaction.payload.defaultParentId ? (
|
|
<TaskField label="Default parent" value={interaction.payload.defaultParentId} tone="subtle" />
|
|
) : null}
|
|
</div>
|
|
|
|
<div className="overflow-hidden border border-border/70">
|
|
{roots.map((root) => (
|
|
<TaskTreeNode
|
|
key={root.task.clientKey}
|
|
node={root}
|
|
createdByClientKey={createdByClientKey}
|
|
agentMap={agentMap}
|
|
currentUserId={currentUserId}
|
|
userLabelMap={userLabelMap}
|
|
selectedClientKeys={selectedClientKeys}
|
|
skippedClientKeys={skippedClientKeys}
|
|
showSelection={interaction.status === "pending"}
|
|
onToggleSelection={handleToggleSelection}
|
|
/>
|
|
))}
|
|
</div>
|
|
|
|
{interaction.status === "accepted" ? (
|
|
<div className="rounded-sm border border-emerald-500/60 bg-emerald-500/10 px-4 py-3 text-sm text-emerald-900 dark:text-emerald-100">
|
|
<div className="text-(length:--text-micro) font-semibold uppercase tracking-(--tracking-eyebrow) text-emerald-700">
|
|
Resolution summary
|
|
</div>
|
|
<p className="mt-1 leading-6">
|
|
{skippedCount > 0
|
|
? `Created ${createdCount} draft ${createdCount === 1 ? "issue" : "issues"} and skipped ${skippedCount} during review.`
|
|
: `Created all ${createdCount} draft ${createdCount === 1 ? "issue" : "issues"}.`}
|
|
</p>
|
|
</div>
|
|
) : null}
|
|
|
|
{interaction.status === "rejected" ? (
|
|
<div className="rounded-sm border border-rose-500/60 bg-rose-500/10 px-4 py-3 text-sm text-rose-900 dark:text-rose-100">
|
|
<div className="text-(length:--text-micro) font-semibold uppercase tracking-(--tracking-eyebrow) text-rose-700">
|
|
Rejection reason
|
|
</div>
|
|
<p className={cn(
|
|
"mt-1 leading-6",
|
|
!interaction.result?.rejectionReason && "text-rose-900/75",
|
|
)}>
|
|
{interaction.result?.rejectionReason || "No reason provided."}
|
|
</p>
|
|
</div>
|
|
) : null}
|
|
|
|
{interaction.status === "pending" ? (
|
|
<div className="space-y-3">
|
|
<div className="flex flex-wrap items-center justify-between gap-3">
|
|
<div className="flex flex-wrap items-center gap-2 text-xs text-muted-foreground">
|
|
<span>
|
|
{selectedCount === totalTasks
|
|
? `All ${totalTasks} draft ${totalTasks === 1 ? "issue" : "issues"} selected`
|
|
: `${selectedCount} of ${totalTasks} draft ${totalTasks === 1 ? "issue" : "issues"} selected`}
|
|
</span>
|
|
{selectedCount < totalTasks ? (
|
|
<span>
|
|
{totalTasks - selectedCount} will be skipped if you accept this interaction.
|
|
</span>
|
|
) : null}
|
|
</div>
|
|
|
|
<DecisionCardFooter leading={footerSlot} className="w-full">
|
|
<div className="ml-auto flex flex-wrap items-center justify-end gap-2">
|
|
<Button
|
|
size="sm"
|
|
disabled={!onAcceptInteraction || working !== null || selectedCount === 0}
|
|
onClick={() => void handleAccept()}
|
|
>
|
|
{working === "accept" ? (
|
|
<>
|
|
<Loader2 className="mr-2 h-3.5 w-3.5 animate-spin" />
|
|
Accepting...
|
|
</>
|
|
) : (
|
|
selectedCount === totalTasks ? "Accept drafts" : "Accept selected drafts"
|
|
)}
|
|
</Button>
|
|
<Button
|
|
size="sm"
|
|
variant="outline"
|
|
disabled={!onRejectInteraction || working !== null}
|
|
onClick={() => setRejecting((current) => !current)}
|
|
>
|
|
Reject
|
|
</Button>
|
|
{selectedCount < totalTasks ? (
|
|
<Button
|
|
size="sm"
|
|
variant="ghost"
|
|
disabled={working !== null}
|
|
onClick={() => setSelectedClientKeys(new Set(interaction.payload.tasks.map((task) => task.clientKey)))}
|
|
>
|
|
Reset selection
|
|
</Button>
|
|
) : null}
|
|
</div>
|
|
</DecisionCardFooter>
|
|
</div>
|
|
|
|
{rejecting ? (
|
|
<div className="space-y-3">
|
|
<Textarea
|
|
value={rejectReason}
|
|
onChange={(event) => setRejectReason(event.target.value)}
|
|
placeholder="Add a short reason for rejecting this suggestion"
|
|
className="min-h-24 bg-background text-sm"
|
|
/>
|
|
<div className="flex justify-end">
|
|
<Button
|
|
size="sm"
|
|
variant="outline"
|
|
disabled={!onRejectInteraction || working !== null}
|
|
onClick={() => void handleReject()}
|
|
>
|
|
{working === "reject" ? (
|
|
<>
|
|
<Loader2 className="mr-2 h-3.5 w-3.5 animate-spin" />
|
|
Saving...
|
|
</>
|
|
) : (
|
|
"Save rejection"
|
|
)}
|
|
</Button>
|
|
</div>
|
|
</div>
|
|
) : null}
|
|
|
|
<InteractionActionError message={actionError} />
|
|
</div>
|
|
) : null}
|
|
</div>
|
|
);
|
|
}
|
|
|
|
function QuestionOptionButton({
|
|
id,
|
|
compact = false,
|
|
label,
|
|
description,
|
|
selected,
|
|
selectionMode,
|
|
onClick,
|
|
}: {
|
|
id: string;
|
|
compact?: boolean;
|
|
label: string;
|
|
description?: string | null;
|
|
selected: boolean;
|
|
selectionMode: "single" | "multi";
|
|
onClick: () => void;
|
|
}) {
|
|
return (
|
|
<button
|
|
type="button"
|
|
role={selectionMode === "single" ? "radio" : "checkbox"}
|
|
aria-checked={selected}
|
|
className={cn(
|
|
compact ? "flex w-full items-start gap-3 rounded-md px-3 py-2 text-left transition-colors outline-none focus-visible:ring-2 focus-visible:ring-ring" : "w-full rounded-sm border px-4 py-3 text-left transition-colors outline-none focus-visible:border-ring focus-visible:ring-(length:--rad-3) focus-visible:ring-ring/50",
|
|
compact ? (selected ? "bg-muted text-foreground" : "text-foreground hover:bg-muted/50") : selected
|
|
? "border-sky-500/80 bg-sky-500/10 text-sky-950 dark:border-sky-400/80 dark:bg-sky-400/15 dark:text-sky-50"
|
|
: "border-border/70 bg-transparent text-foreground hover:border-sky-500/70 hover:bg-sky-500/10 dark:hover:border-sky-400/70 dark:hover:bg-sky-400/10",
|
|
)}
|
|
id={id}
|
|
onClick={onClick}
|
|
>
|
|
{compact ? <span aria-hidden="true" className={cn("mt-0.5 flex size-4 shrink-0 items-center justify-center border", selectionMode === "single" ? "rounded-full" : "rounded-sm", selected ? "border-foreground" : "border-muted-foreground/50")}>
|
|
{selected ? <span className={cn("size-2 bg-foreground", selectionMode === "single" ? "rounded-full" : "rounded-xs")} /> : null}
|
|
</span> : null}
|
|
<div className={compact ? "min-w-0" : "contents"}>
|
|
<div
|
|
className={cn(
|
|
"text-sm font-medium",
|
|
selected && !compact ? "text-sky-950 dark:text-sky-50" : "text-foreground",
|
|
)}
|
|
>
|
|
{label}
|
|
</div>
|
|
{description ? (
|
|
<div
|
|
className={cn(
|
|
"mt-1 text-sm leading-6",
|
|
selected && !compact
|
|
? "text-sky-900/80 dark:text-sky-100/80"
|
|
: "text-muted-foreground",
|
|
)}
|
|
>
|
|
{description}
|
|
</div>
|
|
) : null}
|
|
</div>
|
|
</button>
|
|
);
|
|
}
|
|
|
|
function AskUserQuestionsCard({
|
|
footerSlot,
|
|
interaction,
|
|
compact = false,
|
|
onSubmitInteractionAnswers,
|
|
onCancelInteraction,
|
|
externalReferences,
|
|
}: {
|
|
footerSlot?: ReactNode;
|
|
interaction: AskUserQuestionsInteraction;
|
|
compact?: boolean;
|
|
onSubmitInteractionAnswers?: (
|
|
interaction: AskUserQuestionsInteraction,
|
|
answers: AskUserQuestionsAnswer[],
|
|
) => Promise<void> | void;
|
|
onCancelInteraction?: (
|
|
interaction: AskUserQuestionsInteraction,
|
|
) => Promise<void> | void;
|
|
externalReferences?: MarkdownExternalReferenceMap;
|
|
}) {
|
|
const [draftAnswers, setDraftAnswers] = useState<Record<string, string[]>>(() =>
|
|
Object.fromEntries(
|
|
(interaction.result?.answers ?? []).map((answer) => [
|
|
answer.questionId,
|
|
[...answer.optionIds],
|
|
]),
|
|
),
|
|
);
|
|
const [draftOtherAnswers, setDraftOtherAnswers] = useState<Record<string, string>>(() =>
|
|
Object.fromEntries(
|
|
(interaction.result?.answers ?? [])
|
|
.filter((answer) => answer.otherText)
|
|
.map((answer) => [answer.questionId, answer.otherText ?? ""]),
|
|
),
|
|
);
|
|
const [otherActiveQuestions, setOtherActiveQuestions] = useState<Record<string, boolean>>(() =>
|
|
Object.fromEntries(
|
|
(interaction.result?.answers ?? [])
|
|
.filter((answer) => answer.otherText)
|
|
.map((answer) => [answer.questionId, true]),
|
|
),
|
|
);
|
|
const [working, setWorking] = useState(false);
|
|
const [cancelling, setCancelling] = useState(false);
|
|
const [actionError, setActionError] = useState<string | null>(null);
|
|
const resolutionErrorMessage = useResolutionErrorMessage();
|
|
|
|
useEffect(() => {
|
|
setDraftAnswers(
|
|
Object.fromEntries(
|
|
(interaction.result?.answers ?? []).map((answer) => [
|
|
answer.questionId,
|
|
[...answer.optionIds],
|
|
]),
|
|
),
|
|
);
|
|
setDraftOtherAnswers(
|
|
Object.fromEntries(
|
|
(interaction.result?.answers ?? [])
|
|
.filter((answer) => answer.otherText)
|
|
.map((answer) => [answer.questionId, answer.otherText ?? ""]),
|
|
),
|
|
);
|
|
setOtherActiveQuestions(
|
|
Object.fromEntries(
|
|
(interaction.result?.answers ?? [])
|
|
.filter((answer) => answer.otherText)
|
|
.map((answer) => [answer.questionId, true]),
|
|
),
|
|
);
|
|
}, [interaction.result?.answers]);
|
|
|
|
const questions = interaction.payload.questions;
|
|
const requiredQuestions = questions.filter((question) => question.required);
|
|
const canSubmit = requiredQuestions.every(
|
|
(question) =>
|
|
(draftAnswers[question.id] ?? []).length > 0
|
|
|| (
|
|
otherActiveQuestions[question.id] === true
|
|
&& (draftOtherAnswers[question.id]?.trim().length ?? 0) > 0
|
|
),
|
|
);
|
|
|
|
function toggleOption(
|
|
questionId: string,
|
|
optionId: string,
|
|
selectionMode: "single" | "multi",
|
|
isFreeText = false,
|
|
) {
|
|
// A free-text option is a first-class version of the built-in "Other"
|
|
// affordance: selecting it reveals the inline text field and its typed
|
|
// value is submitted as the question's `otherText`.
|
|
if (optionId === OTHER_ANSWER_ID || isFreeText) {
|
|
setOtherActiveQuestions((current) => ({
|
|
...current,
|
|
[questionId]: !current[questionId],
|
|
}));
|
|
if (selectionMode === "single") {
|
|
setDraftAnswers((current) => ({ ...current, [questionId]: [] }));
|
|
}
|
|
return;
|
|
}
|
|
|
|
setDraftAnswers((current) => {
|
|
const existing = current[questionId] ?? [];
|
|
if (selectionMode === "single") {
|
|
return { ...current, [questionId]: [optionId] };
|
|
}
|
|
const next = existing.includes(optionId)
|
|
? existing.filter((value) => value !== optionId)
|
|
: [...existing, optionId];
|
|
return { ...current, [questionId]: next };
|
|
});
|
|
if (selectionMode === "single") {
|
|
setOtherActiveQuestions((current) => ({ ...current, [questionId]: false }));
|
|
}
|
|
}
|
|
|
|
async function handleSubmit() {
|
|
if (!onSubmitInteractionAnswers || !canSubmit) return;
|
|
setWorking(true);
|
|
setActionError(null);
|
|
try {
|
|
await onSubmitInteractionAnswers(
|
|
interaction,
|
|
questions.map((question) => {
|
|
const otherText = otherActiveQuestions[question.id] === true
|
|
? draftOtherAnswers[question.id]?.trim() ?? ""
|
|
: "";
|
|
return {
|
|
questionId: question.id,
|
|
optionIds: draftAnswers[question.id] ?? [],
|
|
...(otherText ? { otherText } : {}),
|
|
};
|
|
}),
|
|
);
|
|
} catch (error) {
|
|
setActionError(resolutionErrorMessage(error));
|
|
} finally {
|
|
setWorking(false);
|
|
}
|
|
}
|
|
|
|
async function handleCancel() {
|
|
if (!onCancelInteraction) return;
|
|
setCancelling(true);
|
|
setActionError(null);
|
|
try {
|
|
await onCancelInteraction(interaction);
|
|
} catch (error) {
|
|
setActionError(resolutionErrorMessage(error));
|
|
} finally {
|
|
setCancelling(false);
|
|
}
|
|
}
|
|
|
|
return (
|
|
<div className="space-y-4">
|
|
{!compact ? <div className="flex flex-wrap items-center gap-2 text-xs text-muted-foreground">
|
|
<Badge variant="outline" className="border-border/70 bg-background/70 px-2.5 py-1 uppercase tracking-(--tracking-eyebrow) text-foreground/70">
|
|
<MessageSquareQuote className="h-3 w-3" />
|
|
Ask user questions
|
|
</Badge>
|
|
<span>
|
|
{questions.length === 1
|
|
? "1 question"
|
|
: `${questions.length} questions`}
|
|
</span>
|
|
</div> : null}
|
|
|
|
{interaction.status === "pending" && interaction.payload.questionSet ? (
|
|
<QuestionForm
|
|
footerSlot={footerSlot}
|
|
id={interaction.id}
|
|
presentation={compact ? "decision" : "default"}
|
|
questionSet={interaction.payload.questionSet}
|
|
draftKey={`issue-question:${interaction.companyId}:${interaction.id}`}
|
|
disabled={!onSubmitInteractionAnswers}
|
|
initialResponse={interaction.result?.answers ? {
|
|
schema: "paperclip.question_response.v1",
|
|
answers: Object.fromEntries(interaction.result.answers.map((answer) => [
|
|
answer.questionId,
|
|
interaction.payload.questionSet!.questions.find((question) => question.id === answer.questionId)?.answerMode === "text"
|
|
? { text: answer.otherText ?? "" }
|
|
: { selectedOptionIds: answer.optionIds, ...(typeof answer.otherText === "string" ? { customText: answer.otherText } : {}) },
|
|
])),
|
|
} : null}
|
|
onSubmit={async (response) => {
|
|
const answers = interaction.payload.questionSet!.questions.map((question) => {
|
|
const answer = response.answers[question.id];
|
|
const otherText = question.answerMode === "text" ? answer?.text : answer?.customText?.trim();
|
|
return {
|
|
questionId: question.id,
|
|
optionIds: question.answerMode === "text" ? [] : (answer?.selectedOptionIds ?? []),
|
|
...(otherText !== undefined ? { otherText } : {}),
|
|
};
|
|
});
|
|
try {
|
|
await onSubmitInteractionAnswers?.(interaction, answers);
|
|
} catch (error) {
|
|
throw new Error(resolutionErrorMessage(error));
|
|
}
|
|
}}
|
|
onCancel={onCancelInteraction ? async () => {
|
|
try {
|
|
await onCancelInteraction(interaction);
|
|
} catch (error) {
|
|
throw new Error(resolutionErrorMessage(error));
|
|
}
|
|
} : undefined}
|
|
/>
|
|
) : interaction.status === "pending" ? (
|
|
<div className="space-y-4">
|
|
{questions.map((question, index) => {
|
|
const hasFreeTextOption = question.options.some(
|
|
(option) => option.freeText === true,
|
|
);
|
|
return (
|
|
<div
|
|
key={question.id}
|
|
className={compact ? "space-y-3" : "rounded-2xl border border-border/70 bg-background/82 p-4 shadow-(--shadow-extract-9)"}
|
|
>
|
|
<div className="flex items-start justify-between gap-3">
|
|
<div>
|
|
{!compact ? <div className="text-(length:--text-micro) font-semibold uppercase tracking-(--tracking-eyebrow) text-muted-foreground">
|
|
Question {index + 1}
|
|
</div> : null}
|
|
<div
|
|
id={`${interaction.id}-${question.id}-prompt`}
|
|
data-decision-prompt={compact ? true : undefined}
|
|
className={compact ? "text-lg font-medium leading-relaxed text-foreground" : "mt-1 text-sm font-semibold text-foreground"}
|
|
>
|
|
{question.prompt}
|
|
</div>
|
|
{question.helpText ? (
|
|
<p className="mt-1 text-sm leading-6 text-muted-foreground">
|
|
{question.helpText}
|
|
</p>
|
|
) : null}
|
|
</div>
|
|
{compact ? <span className="sr-only" id={`${interaction.id}-${question.id}-requirements`}>
|
|
{question.selectionMode === "single" ? "Choose one answer." : "Choose one or more answers."} {question.required ? "Required." : "Optional."}
|
|
</span> : <TaskField
|
|
label={question.selectionMode === "single" ? "Pick" : "Pick many"}
|
|
value={question.required ? "Required" : "Optional"}
|
|
tone="subtle"
|
|
/>}
|
|
</div>
|
|
|
|
<div className="mt-3 space-y-3">
|
|
<div
|
|
className="grid gap-3"
|
|
role={question.selectionMode === "single" ? "radiogroup" : "group"}
|
|
aria-labelledby={`${interaction.id}-${question.id}-prompt`}
|
|
aria-describedby={compact ? `${interaction.id}-${question.id}-requirements` : undefined}
|
|
aria-required={question.selectionMode === "single" && question.required ? true : undefined}
|
|
>
|
|
{question.options.map((option) => {
|
|
const isFreeText = option.freeText === true;
|
|
const optionSelected = isFreeText
|
|
? otherActiveQuestions[question.id] === true
|
|
: (draftAnswers[question.id] ?? []).includes(option.id);
|
|
return (
|
|
<div key={option.id} className="space-y-2">
|
|
<QuestionOptionButton
|
|
compact={compact}
|
|
id={`${interaction.id}-${question.id}-${option.id}`}
|
|
label={option.label}
|
|
description={option.description}
|
|
selected={optionSelected}
|
|
selectionMode={question.selectionMode}
|
|
onClick={() =>
|
|
toggleOption(question.id, option.id, question.selectionMode, isFreeText)}
|
|
/>
|
|
{isFreeText && optionSelected ? (
|
|
<Textarea
|
|
aria-label={`Describe your answer for ${question.prompt}`}
|
|
value={draftOtherAnswers[question.id] ?? ""}
|
|
onChange={(event) =>
|
|
setDraftOtherAnswers((current) => ({
|
|
...current,
|
|
[question.id]: event.target.value,
|
|
}))}
|
|
placeholder="Type your answer"
|
|
className="min-h-24 bg-background text-sm"
|
|
autoFocus
|
|
/>
|
|
) : null}
|
|
</div>
|
|
);
|
|
})}
|
|
</div>
|
|
{/*
|
|
* The built-in "Other" link is the fallback free-text affordance.
|
|
* Suppress it when the agent already authored a first-class
|
|
* free-text option so the card never shows two ways to type an
|
|
* answer (PAP-419).
|
|
*/}
|
|
{hasFreeTextOption || question.allowOther === false ? null : (
|
|
<>
|
|
<button
|
|
type="button"
|
|
id={`${interaction.id}-${question.id}-other`}
|
|
aria-expanded={otherActiveQuestions[question.id] === true}
|
|
className={cn(
|
|
"text-sm font-medium underline underline-offset-4 transition-colors outline-none focus-visible:ring-(length:--rad-3) focus-visible:ring-ring/50",
|
|
otherActiveQuestions[question.id]
|
|
? "text-sky-700 hover:text-sky-800 dark:text-sky-300 dark:hover:text-sky-200"
|
|
: "text-muted-foreground hover:text-foreground",
|
|
)}
|
|
onClick={() =>
|
|
toggleOption(question.id, OTHER_ANSWER_ID, question.selectionMode)}
|
|
>
|
|
Other
|
|
</button>
|
|
{otherActiveQuestions[question.id] ? (
|
|
<Textarea
|
|
aria-label={`Other answer for ${question.prompt}`}
|
|
value={draftOtherAnswers[question.id] ?? ""}
|
|
onChange={(event) =>
|
|
setDraftOtherAnswers((current) => ({
|
|
...current,
|
|
[question.id]: event.target.value,
|
|
}))}
|
|
placeholder="Type your answer"
|
|
className="min-h-24 bg-background text-sm"
|
|
/>
|
|
) : null}
|
|
</>
|
|
)}
|
|
</div>
|
|
</div>
|
|
);
|
|
})}
|
|
|
|
<DecisionCardFooter leading={footerSlot}>
|
|
<div className={compact ? "flex flex-wrap items-center justify-end gap-3" : "flex flex-wrap items-center justify-between gap-3 rounded-2xl border border-border/70 bg-background/75 p-4"}>
|
|
{!compact ? <div className="text-sm text-muted-foreground">
|
|
Submit once after you finish the full form.
|
|
</div> : null}
|
|
<div className="flex flex-wrap items-center gap-2">
|
|
{onCancelInteraction ? (
|
|
<Button
|
|
size="sm"
|
|
variant={compact ? "ghost" : "outline"}
|
|
disabled={working || cancelling}
|
|
onClick={() => void handleCancel()}
|
|
>
|
|
{cancelling ? (
|
|
<>
|
|
<Loader2 className="mr-2 h-3.5 w-3.5 animate-spin" />
|
|
Cancelling...
|
|
</>
|
|
) : (
|
|
"Cancel question"
|
|
)}
|
|
</Button>
|
|
) : null}
|
|
<Button
|
|
size="sm"
|
|
disabled={!onSubmitInteractionAnswers || !canSubmit || working || cancelling}
|
|
onClick={() => void handleSubmit()}
|
|
>
|
|
{working ? (
|
|
<>
|
|
<Loader2 className="mr-2 h-3.5 w-3.5 animate-spin" />
|
|
Submitting...
|
|
</>
|
|
) : (
|
|
interaction.payload.submitLabel ?? "Submit answers"
|
|
)}
|
|
</Button>
|
|
</div>
|
|
</div>
|
|
</DecisionCardFooter>
|
|
|
|
<InteractionActionError message={actionError} />
|
|
</div>
|
|
) : interaction.status === "cancelled" ? (
|
|
<div className="rounded-2xl border border-rose-300/60 bg-rose-50/85 p-4 text-sm leading-6 text-rose-950 dark:border-rose-500/40 dark:bg-rose-500/10 dark:text-rose-100">
|
|
<div className="font-semibold">
|
|
{interaction.result?.outcome === "withdrawn"
|
|
? questions.length === 1 ? "Question withdrawn" : "Questions withdrawn"
|
|
: "Question cancelled"}
|
|
</div>
|
|
{interaction.result?.cancellationReason ? (
|
|
<p className="mt-1">{interaction.result.cancellationReason}</p>
|
|
) : interaction.result?.reason ? (
|
|
<p className="mt-1">{interaction.result.reason}</p>
|
|
) : (
|
|
<p className="mt-1">No answer was recorded.</p>
|
|
)}
|
|
</div>
|
|
) : interaction.status === "expired" ? (
|
|
<div className="rounded-2xl border border-amber-300/70 bg-amber-50/85 p-4 text-sm leading-6 text-amber-950 dark:border-amber-500/40 dark:bg-amber-500/10 dark:text-amber-100">
|
|
<div className="flex items-center gap-2 font-semibold">
|
|
<AlertTriangle className="h-4 w-4" />
|
|
{interaction.result?.outcome === "issue_closed"
|
|
? questions.length === 1
|
|
? "Question expired when the issue closed"
|
|
: "Questions expired when the issue closed"
|
|
: questions.length === 1
|
|
? "Question expired by comment"
|
|
: "Questions expired by comment"}
|
|
</div>
|
|
<p className="mt-1">
|
|
{interaction.result?.outcome === "issue_closed"
|
|
? "This question request expired automatically when the issue reached a terminal state."
|
|
: "A later board/user comment superseded this question request. Create a fresh request if answers are still needed."}
|
|
</p>
|
|
{interaction.result?.commentId ? (
|
|
<a
|
|
href={`#comment-${interaction.result.commentId}`}
|
|
className="mt-3 inline-flex text-sm font-medium underline underline-offset-4"
|
|
>
|
|
Jump to comment
|
|
</a>
|
|
) : null}
|
|
</div>
|
|
) : (
|
|
<div className="space-y-3">
|
|
{questions.map((question) => {
|
|
const labels = getQuestionAnswerLabels({
|
|
question,
|
|
answers: interaction.result?.answers ?? [],
|
|
});
|
|
return (
|
|
<div
|
|
key={question.id}
|
|
className="rounded-2xl border border-border/70 bg-background/82 p-4"
|
|
>
|
|
<div className="text-sm font-semibold text-foreground">
|
|
{question.prompt}
|
|
</div>
|
|
<div className="mt-2 flex flex-wrap gap-2">
|
|
{labels.length > 0 ? (
|
|
labels.map((label) => (
|
|
<TaskField key={label} label="Answer" value={label} />
|
|
))
|
|
) : (
|
|
<span className="text-sm text-muted-foreground">No answer recorded.</span>
|
|
)}
|
|
</div>
|
|
</div>
|
|
);
|
|
})}
|
|
|
|
{interaction.result?.summaryMarkdown ? (
|
|
<div className="rounded-2xl border border-emerald-300/60 bg-emerald-50/85 p-4">
|
|
<div className="mb-2 text-(length:--text-micro) font-semibold uppercase tracking-(--tracking-eyebrow) text-emerald-700">
|
|
Submitted summary
|
|
</div>
|
|
<MarkdownBody externalReferences={externalReferences}>{interaction.result.summaryMarkdown}</MarkdownBody>
|
|
</div>
|
|
) : null}
|
|
</div>
|
|
)}
|
|
</div>
|
|
);
|
|
}
|
|
|
|
/** A custom target key is a machine identifier (e.g. `github:org/repo:pull:16`),
|
|
* not display copy, so unlabeled custom targets render no chip. */
|
|
function isDisplayableRequestConfirmationTarget(
|
|
target: RequestConfirmationTarget | null | undefined,
|
|
): target is RequestConfirmationTarget {
|
|
if (!target) return false;
|
|
return target.type !== "custom" || Boolean(target.label);
|
|
}
|
|
|
|
function requestConfirmationTargetLabel(target: RequestConfirmationTarget) {
|
|
if (target.label) return target.label;
|
|
if (target.type === "issue_attachment") return "Attachment";
|
|
const revision = target.revisionNumber ? ` v${target.revisionNumber}` : "";
|
|
if (target.type === "issue_document" && target.key === "plan") {
|
|
return `Plan${revision}`;
|
|
}
|
|
return `${target.key}${revision}`;
|
|
}
|
|
|
|
function requestConfirmationTargetHref({
|
|
interaction,
|
|
target,
|
|
}: {
|
|
interaction: Pick<IssueThreadInteraction, "issueId" | "id">;
|
|
target: RequestConfirmationTarget;
|
|
}) {
|
|
if (target.type === "issue_document" && target.revisionId) {
|
|
return `/issues/${target.issueId ?? interaction.issueId}${buildDocumentAnnotationHash({ documentKey: target.key, revisionId: target.revisionId, interactionId: interaction.id, threadId: null, commentId: null })}`;
|
|
}
|
|
if (target.type === "issue_attachment") {
|
|
return `/api/attachments/${encodeURIComponent(target.attachmentId)}/content`;
|
|
}
|
|
if (target.href) return target.href;
|
|
if (target.type === "issue_document") {
|
|
const issueId = target.issueId ?? interaction.issueId;
|
|
return `/issues/${issueId}#document-${encodeURIComponent(target.key)}`;
|
|
}
|
|
return null;
|
|
}
|
|
|
|
function RequestConfirmationTargetChip({
|
|
interaction,
|
|
target,
|
|
tone = "default",
|
|
}: {
|
|
interaction: Pick<IssueThreadInteraction, "issueId" | "id">;
|
|
target: RequestConfirmationTarget | null | undefined;
|
|
tone?: "default" | "subtle";
|
|
}) {
|
|
if (!isDisplayableRequestConfirmationTarget(target)) return null;
|
|
|
|
const href = requestConfirmationTargetHref({ interaction, target });
|
|
const className = cn(
|
|
"inline-flex max-w-full items-center gap-1.5 rounded-sm border px-2 py-0.5 text-(length:--text-nano) font-medium uppercase tracking-(--tracking-eyebrow)",
|
|
tone === "default"
|
|
? "border-border/70 bg-transparent text-foreground"
|
|
: "border-border/60 bg-transparent text-muted-foreground",
|
|
href && "transition-colors hover:border-sky-500/70 hover:bg-sky-500/10",
|
|
);
|
|
const content = (
|
|
<>
|
|
<GitBranch className="h-3 w-3 shrink-0" />
|
|
<span className="min-w-0 truncate">{requestConfirmationTargetLabel(target)}</span>
|
|
</>
|
|
);
|
|
|
|
if (!href) return <span className={className}>{content}</span>;
|
|
if (target.type === "issue_attachment" || /^https?:\/\//i.test(href)) {
|
|
return (
|
|
<a href={href} target="_blank" rel="noreferrer" className={className}>
|
|
{content}
|
|
</a>
|
|
);
|
|
}
|
|
return (
|
|
<Link to={href} className={className}>
|
|
{content}
|
|
</Link>
|
|
);
|
|
}
|
|
|
|
function RequestConfirmationResolution({
|
|
interaction,
|
|
}: {
|
|
interaction: RequestConfirmationInteraction;
|
|
}) {
|
|
const outcome = interaction.result?.outcome;
|
|
const target = interaction.payload.target ?? null;
|
|
const staleTarget = interaction.result?.staleTarget ?? null;
|
|
|
|
if (interaction.status === "accepted") {
|
|
const resumeFailure = requestConfirmationResumeFailure(interaction);
|
|
if (resumeFailure) {
|
|
return (
|
|
<div className="space-y-2">
|
|
<div className="flex flex-wrap items-center gap-2 text-sm leading-6 text-foreground">
|
|
<span className="font-medium">Confirmed</span>
|
|
<RequestConfirmationTargetChip interaction={interaction} target={target} />
|
|
</div>
|
|
<div className="rounded-sm border border-amber-500/60 bg-amber-500/10 px-4 py-3 text-sm text-amber-900 dark:text-amber-100">
|
|
<div className="text-(length:--text-micro) font-semibold uppercase tracking-(--tracking-eyebrow) text-amber-700">
|
|
Agent resume failed
|
|
</div>
|
|
<p className="mt-1 leading-6">
|
|
{resumeFailure.status === "retrying"
|
|
? `Paperclip is retrying the agent resume after approval (attempt ${resumeFailure.attempt}/${resumeFailure.maxAttempts}).`
|
|
: "Paperclip needs attention before the agent can resume this approved work."}
|
|
</p>
|
|
{resumeFailure.errorCode ? (
|
|
<p className="mt-1 leading-6">
|
|
Latest cause: <code className="font-mono text-(length:--text-micro)">{resumeFailure.errorCode}</code>
|
|
</p>
|
|
) : null}
|
|
</div>
|
|
</div>
|
|
);
|
|
}
|
|
return (
|
|
<div className="flex flex-wrap items-center gap-2 text-sm leading-6 text-foreground">
|
|
<span className="font-medium">Confirmed</span>
|
|
<RequestConfirmationTargetChip interaction={interaction} target={target} />
|
|
</div>
|
|
);
|
|
}
|
|
|
|
if (interaction.status === "rejected") {
|
|
return (
|
|
<div className="space-y-2">
|
|
<div className="flex flex-wrap items-center gap-2 text-sm leading-6 text-foreground">
|
|
<span className="font-medium">Declined</span>
|
|
<RequestConfirmationTargetChip interaction={interaction} target={target} />
|
|
</div>
|
|
{interaction.result?.reason ? (
|
|
<div className="rounded-sm border-l-2 border-rose-500/70 bg-rose-500/10 px-3 py-2 text-sm leading-6 text-rose-900 dark:text-rose-100">
|
|
<MarkdownBody>{interaction.result.reason}</MarkdownBody>
|
|
</div>
|
|
) : null}
|
|
</div>
|
|
);
|
|
}
|
|
|
|
if (interaction.status === "cancelled" && outcome === "withdrawn") {
|
|
// Withdrawn is a neutral administrative retraction (P4 design review): the
|
|
// card-level withdrawn footer carries the "Withdrawn by …" attribution and
|
|
// reason, so this body only anchors the target chip — no rose/red styling
|
|
// and no duplicated reason text.
|
|
return (
|
|
<div className="flex flex-wrap items-center gap-2 text-sm leading-6 text-foreground">
|
|
<span className="font-medium">Withdrawn</span>
|
|
<RequestConfirmationTargetChip interaction={interaction} target={target} />
|
|
</div>
|
|
);
|
|
}
|
|
|
|
if (interaction.status === "expired") {
|
|
const expiredByComment = outcome === "superseded_by_comment";
|
|
const expiredByIssueClosed = outcome === "issue_closed";
|
|
const expiredByTargetChange = outcome === "stale_target";
|
|
return (
|
|
<div className="space-y-3 rounded-sm border border-amber-500/60 bg-amber-500/10 px-4 py-3 text-sm text-amber-900 dark:text-amber-100">
|
|
{/*
|
|
* issue_closed already carries its label in the header status badge
|
|
* ("Expired · issue closed"), so this eyebrow would duplicate it
|
|
* verbatim — only render the eyebrow for the states the header shows
|
|
* generically as "Expired".
|
|
*/}
|
|
{expiredByIssueClosed ? null : (
|
|
<div className="text-(length:--text-micro) font-semibold uppercase tracking-(--tracking-eyebrow) text-amber-700">
|
|
{expiredByComment ? "Expired by comment" : "Expired by target change"}
|
|
</div>
|
|
)}
|
|
<p className="leading-6">
|
|
{expiredByComment
|
|
? "A board comment superseded this confirmation before it was resolved."
|
|
: expiredByIssueClosed
|
|
? "This confirmation expired automatically when the issue reached a terminal state."
|
|
: "The requested target changed before this confirmation was resolved."}
|
|
</p>
|
|
{expiredByComment && interaction.result?.commentId ? (
|
|
<Button asChild size="sm" variant="ghost" className="h-7 px-2 text-amber-950 hover:bg-amber-500/15 dark:text-amber-50">
|
|
<a href={`#comment-${interaction.result.commentId}`}>Jump to comment</a>
|
|
</Button>
|
|
) : null}
|
|
{expiredByTargetChange ? (
|
|
<div className="flex flex-wrap items-center gap-2">
|
|
<RequestConfirmationTargetChip
|
|
interaction={interaction}
|
|
target={staleTarget}
|
|
tone="subtle"
|
|
/>
|
|
{isDisplayableRequestConfirmationTarget(staleTarget)
|
|
&& isDisplayableRequestConfirmationTarget(target) ? (
|
|
<ChevronRight className="h-3.5 w-3.5 text-amber-700" />
|
|
) : null}
|
|
<RequestConfirmationTargetChip interaction={interaction} target={target} />
|
|
</div>
|
|
) : null}
|
|
</div>
|
|
);
|
|
}
|
|
|
|
if (interaction.status === "failed") {
|
|
return (
|
|
<p className="text-sm leading-6 text-muted-foreground">
|
|
This request could not be resolved. Try again or create a new request.
|
|
</p>
|
|
);
|
|
}
|
|
|
|
return null;
|
|
}
|
|
|
|
function ToolActionResolution({
|
|
state,
|
|
interaction,
|
|
}: {
|
|
state: ToolActionCardState;
|
|
interaction: RequestConfirmationInteraction;
|
|
}) {
|
|
const result = interaction.result?.toolAction;
|
|
const [resultOpen, setResultOpen] = useState(false);
|
|
const output = state === "executed" ? result?.resultSummary?.trim() : null;
|
|
let formattedOutput = output;
|
|
if (output) {
|
|
try { formattedOutput = JSON.stringify(JSON.parse(output), null, 2); } catch { /* Plain-text results remain readable. */ }
|
|
}
|
|
const labels = {
|
|
pending: "Waiting for approval",
|
|
running: "Approved · Running…",
|
|
executed: "Succeeded",
|
|
failed: "Execution failed",
|
|
declined: "Declined",
|
|
expired: "Expired",
|
|
cancelled: "Cancelled",
|
|
};
|
|
const Icon = state === "running" ? Loader2 : state === "executed" ? CheckCircle2 : state === "failed" ? AlertTriangle : state === "expired" ? Clock : MinusCircle;
|
|
const detail = state === "failed" ? result?.errorMessage?.trim() || "The action could not complete."
|
|
: state === "declined" ? interaction.result?.reason?.trim()
|
|
: null;
|
|
const status = <>
|
|
<Icon className={cn("h-3.5 w-3.5 shrink-0", state === "running" && "animate-spin", state === "failed" && "text-destructive")} />
|
|
{labels[state]}
|
|
{result?.rememberedAction ? " · Always allowed" : ""}
|
|
</>;
|
|
return (
|
|
<div className="space-y-1 text-sm text-muted-foreground" aria-live="polite">
|
|
{output ? (
|
|
<Collapsible open={resultOpen} onOpenChange={setResultOpen}>
|
|
<CollapsibleTrigger asChild>
|
|
<button type="button" className="flex items-center gap-1.5 rounded-sm hover:text-foreground focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-ring" aria-label={resultOpen ? "Hide result details" : "Show result details"}>
|
|
{status}<ChevronDown className={cn("h-3 w-3", resultOpen && "rotate-180")} />
|
|
</button>
|
|
</CollapsibleTrigger>
|
|
<CollapsibleContent>
|
|
<pre className="mt-2 max-h-64 overflow-auto whitespace-pre-wrap break-words rounded-md bg-muted p-3 font-mono text-xs text-foreground">{formattedOutput}</pre>
|
|
</CollapsibleContent>
|
|
</Collapsible>
|
|
) : <p className="flex items-center gap-1.5">{status}</p>}
|
|
{detail ? <p className={cn("break-words", state === "failed" && "text-destructive")}>{detail}</p> : null}
|
|
{state === "executed" && result?.resultHref?.trim() ? (
|
|
<a className="inline-flex items-center gap-1 underline underline-offset-4 hover:text-foreground" href={result.resultHref} target="_blank" rel="noreferrer">View result<ExternalLink className="h-3 w-3" /></a>
|
|
) : null}
|
|
</div>
|
|
);
|
|
}
|
|
|
|
function RequestToolActionCard({
|
|
footerSlot,
|
|
interaction,
|
|
state,
|
|
onAcceptInteraction,
|
|
onRejectInteraction,
|
|
externalReferences,
|
|
}: {
|
|
footerSlot?: ReactNode;
|
|
interaction: RequestConfirmationInteraction;
|
|
state: ToolActionCardState;
|
|
onAcceptInteraction?: IssueThreadInteractionCardProps["onAcceptInteraction"];
|
|
onRejectInteraction?: (interaction: RequestConfirmationInteraction, reason?: string) => Promise<void> | void;
|
|
externalReferences?: MarkdownExternalReferenceMap;
|
|
}) {
|
|
const payload = interaction.payload.toolAction!;
|
|
const [working, setWorking] = useState<"accept" | "always" | "reject" | null>(null);
|
|
const [actionError, setActionError] = useState<string | null>(null);
|
|
const resolutionErrorMessage = useResolutionErrorMessage();
|
|
const isPending = state === "pending";
|
|
const variant = payload.risk === "destructive" ? "destructive" : "cta";
|
|
|
|
useEffect(() => {
|
|
if (!isPending) setWorking(null);
|
|
}, [interaction.id, isPending]);
|
|
|
|
async function decide(decision: "accept" | "always" | "reject") {
|
|
setWorking(decision);
|
|
setActionError(null);
|
|
try {
|
|
if (decision === "reject") await onRejectInteraction?.(interaction);
|
|
else await onAcceptInteraction?.(interaction, undefined, undefined, decision === "always");
|
|
} catch (error) {
|
|
setActionError(resolutionErrorMessage(error));
|
|
} finally {
|
|
setWorking(null);
|
|
}
|
|
}
|
|
|
|
return (
|
|
<div className="text-foreground">
|
|
<div className="flex items-start gap-3">
|
|
<span role="img" aria-label={payload.appDisplayName || payload.toolDisplayName}>
|
|
<AppLogo name={payload.appDisplayName || payload.toolDisplayName} size={36} />
|
|
</span>
|
|
<div className="min-w-0 flex-1 space-y-1 text-sm">
|
|
<MarkdownBody externalReferences={externalReferences}>{payload.previewMarkdown || payload.toolDisplayName}</MarkdownBody>
|
|
{!isPending ? <ToolActionResolution state={state} interaction={interaction} /> : null}
|
|
</div>
|
|
</div>
|
|
{isPending ? (
|
|
<DecisionCardFooter leading={footerSlot} className="mt-3">
|
|
<div className={cn(!footerSlot && "mt-3", "flex flex-wrap items-center justify-end gap-2")}>
|
|
<Button size="sm" variant="ghost" disabled={!onRejectInteraction || working !== null} onClick={() => void decide("reject")}>
|
|
{working === "reject" ? "Declining…" : "Decline"}
|
|
</Button>
|
|
<div className="inline-flex" role="group" aria-label="Approve request">
|
|
<Button size="sm" variant={variant} className={payload.rememberActionScope ? "rounded-r-none" : undefined} disabled={!onAcceptInteraction || working !== null} onClick={() => void decide("accept")}>
|
|
{working === "accept" || working === "always" ? <><Loader2 className="h-3.5 w-3.5 animate-spin" />{working === "always" ? "Saving…" : "Approving…"}</> : "Approve & run"}
|
|
</Button>
|
|
{payload.rememberActionScope ? (
|
|
<DropdownMenu>
|
|
<DropdownMenuTrigger asChild>
|
|
<Button size="icon-sm" variant={variant} className="rounded-l-none border-l border-background/30" aria-label="Approval options" disabled={!onAcceptInteraction || working !== null}>
|
|
<ChevronDown className="h-4 w-4" />
|
|
</Button>
|
|
</DropdownMenuTrigger>
|
|
<DropdownMenuContent align="end">
|
|
<DropdownMenuItem onSelect={() => void decide("always")} title={payload.rememberActionScope} aria-description={payload.rememberActionScope}>
|
|
Always allow
|
|
</DropdownMenuItem>
|
|
</DropdownMenuContent>
|
|
</DropdownMenu>
|
|
) : null}
|
|
</div>
|
|
</div>
|
|
</DecisionCardFooter>
|
|
) : <DecisionCardFooter leading={footerSlot} className="mt-3" />}
|
|
<InteractionActionError message={actionError} />
|
|
</div>
|
|
);
|
|
}
|
|
|
|
type SecretProposalCardState = ToolActionCardState;
|
|
|
|
function secretProposalCardState(
|
|
interaction: RequestConfirmationInteraction,
|
|
): SecretProposalCardState {
|
|
const proposalStatus = interaction.result?.secretProposal?.status ?? null;
|
|
if (interaction.status === "pending") return "pending";
|
|
if (proposalStatus === "executed") return "executed";
|
|
if (proposalStatus === "failed" || interaction.status === "failed") return "failed";
|
|
if (proposalStatus === "expired" || interaction.status === "expired") return "expired";
|
|
if (
|
|
proposalStatus === "rejected"
|
|
|| proposalStatus === "withdrawn"
|
|
|| interaction.status === "rejected"
|
|
|| interaction.status === "cancelled"
|
|
) {
|
|
return "declined";
|
|
}
|
|
return "running";
|
|
}
|
|
|
|
function secretProposalStatusClasses(state: SecretProposalCardState) {
|
|
if (state === "failed") {
|
|
return {
|
|
shell: "border-2 border-red-500/80 bg-transparent",
|
|
badge: "border-red-500/60 bg-red-500/10 text-red-900 dark:bg-red-500/15 dark:text-red-100",
|
|
label: "FAILED",
|
|
Icon: XCircle,
|
|
};
|
|
}
|
|
return toolActionStatusClasses(state);
|
|
}
|
|
|
|
function SecretProposalIdentityHeader({
|
|
state,
|
|
}: {
|
|
state: SecretProposalCardState;
|
|
}) {
|
|
const dimmed = state === "declined" || state === "expired";
|
|
return (
|
|
<div className={cn("flex items-start gap-3", dimmed && "opacity-60 grayscale")}>
|
|
<div
|
|
aria-hidden
|
|
className="flex h-10 w-10 shrink-0 items-center justify-center rounded-lg border border-border/70 bg-muted/60 text-foreground"
|
|
>
|
|
<KeyRound className="h-5 w-5" />
|
|
</div>
|
|
<div className="min-w-0 flex-1">
|
|
<div className="text-base font-bold leading-tight text-foreground">
|
|
Bind an existing secret
|
|
</div>
|
|
</div>
|
|
</div>
|
|
);
|
|
}
|
|
|
|
function SecretProposalDetails({
|
|
payload,
|
|
}: {
|
|
payload: NonNullable<RequestConfirmationInteraction["payload"]["secretProposal"]>;
|
|
}) {
|
|
return (
|
|
<dl className="grid gap-3 rounded-sm border border-border/70 bg-muted/30 p-3 sm:grid-cols-2">
|
|
<div className="min-w-0 space-y-1">
|
|
<dt className="text-(length:--text-micro) font-semibold uppercase tracking-(--tracking-eyebrow) text-muted-foreground">
|
|
Source secret
|
|
</dt>
|
|
<dd className="truncate text-sm font-medium text-foreground">{payload.sourceSecretLabel}</dd>
|
|
</div>
|
|
<div className="min-w-0 space-y-1">
|
|
<dt className="text-(length:--text-micro) font-semibold uppercase tracking-(--tracking-eyebrow) text-muted-foreground">
|
|
Target agent
|
|
</dt>
|
|
<dd className="truncate text-sm font-medium text-foreground">{payload.targetAgentName}</dd>
|
|
</div>
|
|
<div className="min-w-0 space-y-1 sm:col-span-2">
|
|
<dt className="text-(length:--text-micro) font-semibold uppercase tracking-(--tracking-eyebrow) text-muted-foreground">
|
|
New config path
|
|
</dt>
|
|
<dd className="break-all font-mono text-sm text-foreground">{payload.configPath}</dd>
|
|
</div>
|
|
</dl>
|
|
);
|
|
}
|
|
|
|
function SecretProposalResolution({
|
|
interaction,
|
|
state,
|
|
resolvedByLabel,
|
|
}: {
|
|
interaction: RequestConfirmationInteraction;
|
|
state: SecretProposalCardState;
|
|
resolvedByLabel: string | null;
|
|
}) {
|
|
const result = interaction.result?.secretProposal ?? null;
|
|
const who = resolvedByLabel ?? "the board";
|
|
const when = interaction.resolvedAt
|
|
? formatDateTime(interaction.resolvedAt)
|
|
: result?.updatedAt
|
|
? formatDateTime(result.updatedAt)
|
|
: null;
|
|
|
|
if (state === "running") {
|
|
return (
|
|
<div aria-live="polite" className="flex items-start gap-2 rounded-sm border border-amber-500/50 bg-amber-500/10 px-4 py-3 text-sm text-amber-900 dark:text-amber-100">
|
|
<Loader2 className="mt-0.5 h-4 w-4 shrink-0 animate-spin" />
|
|
<div>
|
|
<div className="font-medium">Approved by {who} — creating the binding</div>
|
|
<p className="mt-1 text-amber-900/80 dark:text-amber-100/80">
|
|
Paperclip is re-checking authority and the proposal snapshot before writing.
|
|
</p>
|
|
</div>
|
|
</div>
|
|
);
|
|
}
|
|
|
|
if (state === "executed") {
|
|
return (
|
|
<div aria-live="polite" className="flex items-start gap-2 rounded-sm border border-green-500/50 bg-green-500/10 px-4 py-3 text-sm text-green-900 dark:text-green-100">
|
|
<CheckCircle2 className="mt-0.5 h-4 w-4 shrink-0" />
|
|
<div>
|
|
<div className="font-medium">Binding created · approved by {who}</div>
|
|
<p className="mt-1 text-green-900/80 dark:text-green-100/80">
|
|
The target agent can now use the proposed config path{when ? ` · ${when}` : ""}.
|
|
</p>
|
|
</div>
|
|
</div>
|
|
);
|
|
}
|
|
|
|
if (state === "failed") {
|
|
const errorCode = result?.errorCode?.trim();
|
|
return (
|
|
<div aria-live="assertive" className="space-y-2 rounded-sm border border-red-500/60 bg-red-500/10 px-4 py-3 text-sm text-red-900 dark:text-red-100">
|
|
<div className="flex items-start gap-2">
|
|
<XCircle className="mt-0.5 h-4 w-4 shrink-0" />
|
|
<div>
|
|
<div className="font-semibold uppercase tracking-(--tracking-eyebrow)">
|
|
FAILED · binding was not created
|
|
</div>
|
|
<p className="mt-1 text-red-900/80 dark:text-red-100/80">
|
|
The request was accepted, but execution failed closed. No secret value was exposed.
|
|
</p>
|
|
</div>
|
|
</div>
|
|
{errorCode ? (
|
|
<div className="rounded-sm border border-red-500/50 bg-background/60 px-3 py-2">
|
|
<span className="text-(length:--text-nano) font-semibold uppercase tracking-(--tracking-eyebrow)">
|
|
Error code
|
|
</span>{" "}
|
|
<code className="font-mono text-foreground">{errorCode}</code>
|
|
</div>
|
|
) : null}
|
|
</div>
|
|
);
|
|
}
|
|
|
|
if (state === "declined") {
|
|
const reason = interaction.result?.reason?.trim();
|
|
return (
|
|
<div className="space-y-2 rounded-sm border border-red-500/50 bg-red-500/10 px-4 py-3 text-sm text-red-900 dark:text-red-100">
|
|
<div className="flex items-start gap-2">
|
|
<XCircle className="mt-0.5 h-4 w-4 shrink-0" />
|
|
<div>
|
|
<div className="font-medium">Rejected by {who}</div>
|
|
<p className="mt-1 text-red-900/80 dark:text-red-100/80">The binding was not created.</p>
|
|
</div>
|
|
</div>
|
|
{reason ? (
|
|
<div className="rounded-sm border border-red-500/40 bg-background/60 px-3 py-2 text-foreground">
|
|
<MarkdownBody>{reason}</MarkdownBody>
|
|
</div>
|
|
) : null}
|
|
</div>
|
|
);
|
|
}
|
|
|
|
return (
|
|
<div className="flex items-start gap-2 rounded-sm border border-border bg-muted/50 px-4 py-3 text-sm text-muted-foreground">
|
|
<Clock className="mt-0.5 h-4 w-4 shrink-0" />
|
|
<div>
|
|
<div className="font-medium text-foreground">Proposal expired{when ? ` · ${when}` : ""}</div>
|
|
<p className="mt-1">The binding was not created. A fresh proposal is required.</p>
|
|
</div>
|
|
</div>
|
|
);
|
|
}
|
|
|
|
function RequestSecretProposalCard({
|
|
footerSlot,
|
|
interaction,
|
|
state,
|
|
resolvedByLabel,
|
|
onAcceptInteraction,
|
|
onRejectInteraction,
|
|
}: {
|
|
footerSlot?: ReactNode;
|
|
interaction: RequestConfirmationInteraction;
|
|
state: SecretProposalCardState;
|
|
resolvedByLabel: string | null;
|
|
onAcceptInteraction?: (interaction: RequestConfirmationInteraction) => Promise<void> | void;
|
|
onRejectInteraction?: (
|
|
interaction: RequestConfirmationInteraction,
|
|
reason?: string,
|
|
) => Promise<void> | void;
|
|
}) {
|
|
const payload = interaction.payload.secretProposal!;
|
|
const [working, setWorking] = useState<"accept" | "reject" | null>(null);
|
|
const [actionError, setActionError] = useState<string | null>(null);
|
|
const resolutionErrorMessage = useResolutionErrorMessage();
|
|
const isPending = state === "pending";
|
|
|
|
useEffect(() => {
|
|
setActionError(null);
|
|
if (!isPending) setWorking(null);
|
|
}, [interaction.id, isPending]);
|
|
|
|
async function handleAccept() {
|
|
if (!onAcceptInteraction) return;
|
|
setWorking("accept");
|
|
setActionError(null);
|
|
try {
|
|
await onAcceptInteraction(interaction);
|
|
} catch (error) {
|
|
setActionError(resolutionErrorMessage(error));
|
|
} finally {
|
|
setWorking(null);
|
|
}
|
|
}
|
|
|
|
async function handleReject(reason?: string) {
|
|
if (!onRejectInteraction) return;
|
|
setWorking("reject");
|
|
setActionError(null);
|
|
try {
|
|
await onRejectInteraction(interaction, reason);
|
|
} catch (error) {
|
|
setActionError(resolutionErrorMessage(error));
|
|
} finally {
|
|
setWorking(null);
|
|
}
|
|
}
|
|
|
|
return (
|
|
<div className="space-y-4">
|
|
<SecretProposalIdentityHeader state={state} />
|
|
<SecretProposalDetails payload={payload} />
|
|
<ProposalJustification justification={payload.justification} />
|
|
<div className="flex items-center gap-2 text-(length:--text-micro) text-muted-foreground">
|
|
<Clock className="h-3.5 w-3.5" />
|
|
Expires {formatDateTime(payload.expiresAt)}
|
|
</div>
|
|
|
|
{isPending ? (
|
|
<ConfirmationActionRow
|
|
footerSlot={footerSlot}
|
|
resetKey={`${interaction.id}:${interaction.status}`}
|
|
approveLabel={interaction.payload.acceptLabel ?? "Approve & bind"}
|
|
reviseLabel="Add reason…"
|
|
rejectLabel={interaction.payload.rejectLabel ?? "Reject"}
|
|
approveVariant="cta"
|
|
allowRevise={interaction.payload.allowDeclineReason !== false}
|
|
rejectRequiresReason={interaction.payload.rejectRequiresReason === true}
|
|
reasonPlaceholder={interaction.payload.declineReasonPlaceholder ?? "Optional: explain why this binding should not be created."}
|
|
working={working}
|
|
actionError={actionError}
|
|
preparingApproval={isInteractionPreparingApproval(interaction)}
|
|
canApprove={Boolean(onAcceptInteraction)}
|
|
canReject={Boolean(onRejectInteraction)}
|
|
onApprove={() => void handleAccept()}
|
|
onReject={(reason) => void handleReject(reason)}
|
|
stackActionsOnMobile
|
|
/>
|
|
) : (
|
|
<SecretProposalResolution
|
|
interaction={interaction}
|
|
state={state}
|
|
resolvedByLabel={resolvedByLabel}
|
|
/>
|
|
)}
|
|
</div>
|
|
);
|
|
}
|
|
|
|
/**
|
|
* The single approval grammar shared by every plan / task-approval card
|
|
* (PAP-418): **Approve · Revise… · Reject**. "Revise…" reveals an attached text
|
|
* field for the changes you want (the former "decline with a reason" path);
|
|
* bare "Reject" sends the work back with no note. These are the default words —
|
|
* producers may still override the accept/reject labels for domain-specific
|
|
* confirmations (e.g. "Delete selected"), but the shape stays consistent.
|
|
*/
|
|
const CONFIRMATION_APPROVE_LABEL = "Approve";
|
|
const CONFIRMATION_REVISE_LABEL = "Revise…";
|
|
const CONFIRMATION_REJECT_LABEL = "Reject";
|
|
|
|
/**
|
|
* The one action control every confirmation card renders (PAP-418), collapsing
|
|
* what used to be a two-button card plus a separate sticky Plan-pane bar into a
|
|
* single consistent surface. Producer flags tune which affordances appear:
|
|
* `allowDeclineReason: false` drops the Revise… path so only Approve/Reject
|
|
* remain; `rejectRequiresReason: true` drops the bare Reject so every rejection
|
|
* carries a note. The revise text stays attached to the card.
|
|
*/
|
|
function ConfirmationActionRow({
|
|
footerSlot,
|
|
resetKey,
|
|
approveLabel,
|
|
reviseLabel = CONFIRMATION_REVISE_LABEL,
|
|
rejectLabel,
|
|
approveVariant = "default",
|
|
primaryActionOnRight = false,
|
|
allowRevise,
|
|
rejectRequiresReason,
|
|
reasonPlaceholder,
|
|
working,
|
|
actionError,
|
|
approveDisabled = false,
|
|
preparingApproval = false,
|
|
canApprove,
|
|
canReject,
|
|
onApprove,
|
|
onReject,
|
|
composeReason,
|
|
extraReasonSatisfied = false,
|
|
revisePanelChildren,
|
|
stackActionsOnMobile = false,
|
|
}: {
|
|
footerSlot?: ReactNode;
|
|
/** Changing this (interaction id + status) collapses the revise panel and
|
|
* clears its draft text — the row is reused across interaction updates. */
|
|
resetKey: string;
|
|
approveLabel: string;
|
|
reviseLabel?: string;
|
|
rejectLabel: string;
|
|
approveVariant?: React.ComponentProps<typeof Button>["variant"];
|
|
primaryActionOnRight?: boolean;
|
|
allowRevise: boolean;
|
|
rejectRequiresReason: boolean;
|
|
reasonPlaceholder: string;
|
|
working: "accept" | "reject" | null;
|
|
actionError: string | null;
|
|
approveDisabled?: boolean;
|
|
preparingApproval?: boolean;
|
|
canApprove: boolean;
|
|
canReject: boolean;
|
|
onApprove: () => void;
|
|
onReject: (reason: string | undefined) => void;
|
|
/** Compose the final reject reason from the typed text (plan cards append
|
|
* screenshot markdown here). */
|
|
composeReason?: (text: string) => string | undefined;
|
|
/** A required reason is already satisfied by an attachment (e.g. screenshots),
|
|
* so an empty text box should not block sending the revision. */
|
|
extraReasonSatisfied?: boolean;
|
|
/** Extra affordances rendered inside the revise panel (e.g. screenshot attach). */
|
|
revisePanelChildren?: ReactNode;
|
|
/** Give domain cards with longer action labels an intentional narrow-screen
|
|
* hierarchy instead of relying on opportunistic flex wrapping. */
|
|
stackActionsOnMobile?: boolean;
|
|
}) {
|
|
const [revising, setRevising] = useState(false);
|
|
const { enabled: coordinatorEnabled } = useCoordinatorWorkspaceEnabled();
|
|
const [reason, setReason] = useState("");
|
|
const [attempted, setAttempted] = useState(false);
|
|
|
|
useEffect(() => {
|
|
setRevising(false);
|
|
setReason("");
|
|
setAttempted(false);
|
|
}, [resetKey]);
|
|
|
|
const trimmed = reason.trim();
|
|
const reasonMissing = rejectRequiresReason && trimmed.length === 0 && !extraReasonSatisfied;
|
|
|
|
function submitRevision() {
|
|
setAttempted(true);
|
|
if (!canReject || reasonMissing) return;
|
|
onReject(composeReason ? composeReason(reason) : trimmed || undefined);
|
|
}
|
|
|
|
return (
|
|
<div className="space-y-3">
|
|
{preparingApproval ? <InteractionPreparationNotice /> : null}
|
|
<DecisionCardFooter leading={footerSlot} className={coordinatorEnabled && revising ? "hidden" : undefined}>
|
|
<div
|
|
data-testid="confirmation-actions"
|
|
hidden={coordinatorEnabled && revising}
|
|
data-mobile-layout={stackActionsOnMobile ? "stacked" : "inline"}
|
|
className={cn(
|
|
stackActionsOnMobile
|
|
? "grid grid-cols-2 items-stretch gap-2 sm:flex sm:flex-wrap sm:items-center sm:justify-end"
|
|
: "flex flex-wrap items-center justify-end gap-2",
|
|
primaryActionOnRight && "flex-row-reverse justify-start",
|
|
coordinatorEnabled && revising && "hidden",
|
|
)}
|
|
>
|
|
<Button
|
|
size="sm"
|
|
variant={revising ? "outline" : approveVariant}
|
|
className={stackActionsOnMobile ? "col-span-2 w-full sm:col-auto sm:w-auto" : undefined}
|
|
disabled={!canApprove || working !== null || approveDisabled || preparingApproval}
|
|
onClick={onApprove}
|
|
>
|
|
{working === "accept" ? (
|
|
<>
|
|
<Loader2 className="mr-2 h-3.5 w-3.5 animate-spin" />
|
|
Approving…
|
|
</>
|
|
) : (
|
|
approveLabel
|
|
)}
|
|
</Button>
|
|
{allowRevise ? (
|
|
<Button
|
|
size="sm"
|
|
variant="outline"
|
|
className={stackActionsOnMobile ? "w-full sm:w-auto" : undefined}
|
|
disabled={!canReject || working !== null}
|
|
onClick={() => {
|
|
setAttempted(false);
|
|
setRevising((current) => !current);
|
|
}}
|
|
>
|
|
{reviseLabel}
|
|
</Button>
|
|
) : null}
|
|
{!rejectRequiresReason ? (
|
|
<Button
|
|
size="sm"
|
|
variant="ghost"
|
|
className={stackActionsOnMobile ? "w-full sm:w-auto" : undefined}
|
|
disabled={!canReject || working !== null}
|
|
onClick={() => onReject(undefined)}
|
|
>
|
|
{working === "reject" && !revising ? (
|
|
<>
|
|
<Loader2 className="mr-2 h-3.5 w-3.5 animate-spin" />
|
|
Rejecting…
|
|
</>
|
|
) : (
|
|
rejectLabel
|
|
)}
|
|
</Button>
|
|
) : null}
|
|
</div>
|
|
</DecisionCardFooter>
|
|
|
|
{revising ? (
|
|
<div className="space-y-3 rounded-sm border border-border/70 bg-background/75 p-3">
|
|
<Textarea
|
|
value={reason}
|
|
onChange={(event) => setReason(event.target.value)}
|
|
placeholder={reasonPlaceholder}
|
|
aria-invalid={attempted && reasonMissing}
|
|
className={cn(
|
|
"min-h-24 bg-background text-sm",
|
|
attempted && reasonMissing && "border-rose-500 focus-visible:ring-rose-500/25",
|
|
)}
|
|
/>
|
|
{attempted && reasonMissing ? (
|
|
<p className="text-xs text-destructive">Add a note describing the changes you want.</p>
|
|
) : null}
|
|
{revisePanelChildren}
|
|
<DecisionCardFooter leading={footerSlot}>
|
|
<div className="flex flex-wrap justify-end gap-2">
|
|
<Button
|
|
size="sm"
|
|
variant="ghost"
|
|
disabled={working !== null}
|
|
onClick={() => {
|
|
setRevising(false);
|
|
setAttempted(false);
|
|
}}
|
|
>
|
|
Cancel
|
|
</Button>
|
|
<Button
|
|
size="sm"
|
|
variant="outline"
|
|
disabled={!canReject || working !== null}
|
|
onClick={submitRevision}
|
|
>
|
|
{working === "reject" ? (
|
|
<>
|
|
<Loader2 className="mr-2 h-3.5 w-3.5 animate-spin" />
|
|
Sending…
|
|
</>
|
|
) : (
|
|
"Send revision"
|
|
)}
|
|
</Button>
|
|
</div>
|
|
</DecisionCardFooter>
|
|
</div>
|
|
) : null}
|
|
|
|
<InteractionActionError message={actionError} />
|
|
</div>
|
|
);
|
|
}
|
|
|
|
function connectionAuthorizationStatusClasses(
|
|
state: ConnectionAuthorizationCardState,
|
|
copy: { providerName: string; addresseeLabel: string },
|
|
): {
|
|
shell: string;
|
|
badge: string;
|
|
label: string;
|
|
Icon: typeof CheckCircle2;
|
|
} {
|
|
switch (state) {
|
|
case "actionable":
|
|
return {
|
|
shell: "border-2 border-sky-500/70 bg-transparent",
|
|
badge: "border-sky-500/60 bg-sky-500/10 text-sky-900 dark:bg-sky-500/15 dark:text-sky-100",
|
|
label: "Action required",
|
|
Icon: KeyRound,
|
|
};
|
|
case "waiting":
|
|
// Not a warning and not a failure: someone else's decision is simply
|
|
// outstanding. The calm inert lane keeps it out of the reader's queue.
|
|
return {
|
|
shell: "border-border bg-transparent",
|
|
badge: "border-border bg-muted/60 text-muted-foreground",
|
|
label: `Waiting for ${copy.addresseeLabel}`,
|
|
Icon: Clock,
|
|
};
|
|
case "connected":
|
|
return {
|
|
shell: "border-2 border-green-500/80 bg-transparent",
|
|
badge: "border-green-500/60 bg-green-500/10 text-green-900 dark:bg-green-500/15 dark:text-green-100",
|
|
label: `${copy.providerName} connected`,
|
|
Icon: CheckCircle2,
|
|
};
|
|
case "declined":
|
|
return {
|
|
shell: "border-border bg-transparent",
|
|
badge: "border-border bg-muted/60 text-muted-foreground",
|
|
label: "Not connected",
|
|
Icon: MinusCircle,
|
|
};
|
|
case "expired":
|
|
default:
|
|
return {
|
|
shell: "border-border bg-transparent",
|
|
badge: "border-border bg-muted/60 text-muted-foreground",
|
|
label: "Authorization expired",
|
|
Icon: CircleDashed,
|
|
};
|
|
}
|
|
}
|
|
|
|
/**
|
|
* Connection authorization — "Connect your Gmail to continue" (PAP-17796
|
|
* Surface F, corrected in PAP-17859).
|
|
*
|
|
* This is deliberately *not* the generic Approve / Revise… / Reject grammar it
|
|
* used to fall through to. Authorization is not a review: there is nothing to
|
|
* revise, "Reject" is the wrong word for declining to link your own account,
|
|
* and only one person in the company can answer at all. So the card composes
|
|
* one title, one body, and exactly the affordances the reader legitimately has:
|
|
*
|
|
* - the addressed person gets the single primary **Connect <Provider>** target
|
|
* plus a plain **Not now**;
|
|
* - anybody else gets **Waiting for <Person>** and no action at all — a
|
|
* policy-forbidden action is omitted, never rendered disabled, and the card
|
|
* must not imply a teammate can consent on their behalf;
|
|
* - once resolved it states the outcome, who resolved it, and when.
|
|
*
|
|
* The primary action is a link to the server-minted authorization URL, not an
|
|
* accept call: the OAuth callback is what resolves this interaction, so the
|
|
* card never claims success the provider has not granted.
|
|
*/
|
|
function RequestConnectionAuthorizationCard({
|
|
footerSlot,
|
|
interaction,
|
|
state,
|
|
isAddressee,
|
|
providerName,
|
|
addresseeLabel,
|
|
requestingAgentLabel,
|
|
resolvedByLabel,
|
|
resolvedByAgent,
|
|
onRejectInteraction,
|
|
}: {
|
|
footerSlot?: ReactNode;
|
|
interaction: RequestConfirmationInteraction;
|
|
state: ConnectionAuthorizationCardState;
|
|
/** Is the signed-in reader the person the server addressed? */
|
|
isAddressee: boolean;
|
|
providerName: string;
|
|
addresseeLabel: string;
|
|
requestingAgentLabel: string | null;
|
|
resolvedByLabel: string | null;
|
|
resolvedByAgent: boolean;
|
|
onRejectInteraction?: (
|
|
interaction: RequestConfirmationInteraction,
|
|
reason?: string,
|
|
) => Promise<void> | void;
|
|
}) {
|
|
const [working, setWorking] = useState(false);
|
|
const [actionError, setActionError] = useState<string | null>(null);
|
|
const resolutionErrorMessage = useResolutionErrorMessage();
|
|
const href = connectionAuthorizationHref(interaction);
|
|
const declineReason = getAdministrativeReason(interaction);
|
|
|
|
useEffect(() => {
|
|
setActionError(null);
|
|
setWorking(false);
|
|
}, [interaction.id, interaction.status]);
|
|
|
|
async function handleNotNow() {
|
|
if (!onRejectInteraction) return;
|
|
setWorking(true);
|
|
setActionError(null);
|
|
try {
|
|
await onRejectInteraction(interaction);
|
|
} catch (error) {
|
|
setActionError(resolutionErrorMessage(error));
|
|
} finally {
|
|
setWorking(false);
|
|
}
|
|
}
|
|
|
|
// One body, composed here rather than split between the header summary and a
|
|
// payload prompt that repeats the title.
|
|
//
|
|
// The server's summary is written in the second person ("needs *your* Gmail
|
|
// identity for work running as *you*") because the server addressed one
|
|
// person. Shown to a teammate it names the wrong account, so a reader who is
|
|
// not the addressee gets the same fact stated about them. Caught by rendering
|
|
// the card, not by reading it.
|
|
const agentLabel = requestingAgentLabel ?? "An agent";
|
|
const lead = isAddressee
|
|
? interaction.summary?.trim()
|
|
|| `${agentLabel} needs your ${providerName} identity for work running as you.`
|
|
: `${agentLabel} ${state === "connected" ? "needed" : "needs"} ${addresseeLabel}'s ${providerName} identity for work running as them.`;
|
|
// Only the actionable state needs the consent boundary spelled out; the other
|
|
// states carry it in their own status line.
|
|
const consentSentence = state === "actionable" ? "No one else can complete this step." : null;
|
|
|
|
return (
|
|
<div className="space-y-4">
|
|
<p
|
|
className="max-w-3xl text-sm leading-6 text-muted-foreground"
|
|
data-testid="connection-authorization-body"
|
|
>
|
|
{consentSentence ? `${lead} ${consentSentence}` : lead}
|
|
</p>
|
|
|
|
{state === "actionable" ? (
|
|
<div className="space-y-3">
|
|
{href ? (
|
|
<DecisionCardFooter leading={footerSlot}>
|
|
<div
|
|
data-testid="connection-authorization-actions"
|
|
className="grid grid-cols-1 items-stretch gap-2 sm:flex sm:flex-wrap sm:items-center sm:justify-end"
|
|
>
|
|
<Button asChild size="sm" variant="cta" className="w-full sm:w-auto">
|
|
<a href={href} target="_blank" rel="noreferrer">
|
|
Connect {providerName}
|
|
<ArrowUpRight className="ml-1.5 h-3.5 w-3.5" />
|
|
</a>
|
|
</Button>
|
|
<Button
|
|
size="sm"
|
|
variant="ghost"
|
|
className="w-full sm:w-auto"
|
|
disabled={!onRejectInteraction || working}
|
|
onClick={() => void handleNotNow()}
|
|
>
|
|
{working ? (
|
|
<>
|
|
<Loader2 className="mr-2 h-3.5 w-3.5 animate-spin" />
|
|
Saving…
|
|
</>
|
|
) : (
|
|
"Not now"
|
|
)}
|
|
</Button>
|
|
</div>
|
|
</DecisionCardFooter>
|
|
) : (
|
|
// A pending card with no usable target is a server-side gap, not an
|
|
// invitation to reuse an old URL.
|
|
<ConnectionAuthorizationStatusLine
|
|
Icon={TriangleAlert}
|
|
testId="connection-authorization-no-target"
|
|
headline="This authorization link is unavailable"
|
|
detail={`Ask ${requestingAgentLabel ?? "the agent"} to send a fresh ${providerName} authorization link.`}
|
|
/>
|
|
)}
|
|
<InteractionActionError message={actionError} />
|
|
</div>
|
|
) : state === "waiting" ? (
|
|
<ConnectionAuthorizationStatusLine
|
|
Icon={Clock}
|
|
testId="connection-authorization-waiting"
|
|
headline={`Waiting for ${addresseeLabel}`}
|
|
detail={`Only ${addresseeLabel} can connect their own ${providerName} account.`}
|
|
/>
|
|
) : state === "connected" ? (
|
|
<ConnectionAuthorizationStatusLine
|
|
Icon={CheckCircle2}
|
|
testId="connection-authorization-connected"
|
|
headline={`${providerName} connected`}
|
|
detail={
|
|
<>
|
|
Connected by{" "}
|
|
<span className="font-medium text-foreground">
|
|
{/* "You" is display-cased for a badge; this is mid-sentence. */}
|
|
{(resolvedByLabel ?? addresseeLabel) === "You" ? "you" : resolvedByLabel ?? addresseeLabel}
|
|
</span>
|
|
{resolvedByAgent ? <ResolvedByAgentChip /> : null}
|
|
{interaction.resolvedAt ? ` on ${formatDateTime(interaction.resolvedAt)}` : ""}
|
|
</>
|
|
}
|
|
/>
|
|
) : (
|
|
// Declined or expired. No Connect action: the authorization target this
|
|
// card carried is spent, and the agent asks again with a fresh one
|
|
// rather than the board replaying a dead URL.
|
|
<ConnectionAuthorizationStatusLine
|
|
Icon={state === "declined" ? MinusCircle : CircleDashed}
|
|
testId={state === "declined" ? "connection-authorization-declined" : "connection-authorization-expired"}
|
|
headline={state === "declined" ? `${providerName} was not connected` : "This authorization request expired"}
|
|
detail={
|
|
declineReason
|
|
?? `${requestingAgentLabel ?? "The agent"} can ask again with a new ${providerName} authorization link.`
|
|
}
|
|
/>
|
|
)}
|
|
</div>
|
|
);
|
|
}
|
|
|
|
function ConnectionAuthorizationStatusLine({
|
|
Icon,
|
|
testId,
|
|
headline,
|
|
detail,
|
|
}: {
|
|
Icon: typeof CheckCircle2;
|
|
testId: string;
|
|
headline: string;
|
|
detail: ReactNode;
|
|
}) {
|
|
return (
|
|
<div
|
|
data-testid={testId}
|
|
className="flex items-start gap-2 rounded-sm border border-border/70 bg-muted/30 p-3"
|
|
>
|
|
<Icon className="mt-0.5 h-4 w-4 shrink-0 text-muted-foreground" />
|
|
<div className="min-w-0 space-y-0.5 text-sm">
|
|
<div className="font-medium text-foreground">{headline}</div>
|
|
<div className="leading-6 text-muted-foreground">{detail}</div>
|
|
</div>
|
|
</div>
|
|
);
|
|
}
|
|
|
|
function RequestConfirmationCard({
|
|
footerSlot,
|
|
interaction,
|
|
compact = false,
|
|
isPlan = false,
|
|
primaryActionOnRight = false,
|
|
onAcceptInteraction,
|
|
onRejectInteraction,
|
|
onUploadImage,
|
|
externalReferences,
|
|
}: {
|
|
footerSlot?: ReactNode;
|
|
interaction: RequestConfirmationInteraction;
|
|
compact?: boolean;
|
|
isPlan?: boolean;
|
|
primaryActionOnRight?: boolean;
|
|
onAcceptInteraction?: (
|
|
interaction: RequestConfirmationInteraction,
|
|
) => Promise<void> | void;
|
|
onRejectInteraction?: (
|
|
interaction: RequestConfirmationInteraction,
|
|
reason?: string,
|
|
) => Promise<void> | void;
|
|
onUploadImage?: (file: File) => Promise<string>;
|
|
externalReferences?: MarkdownExternalReferenceMap;
|
|
}) {
|
|
const [working, setWorking] = useState<"accept" | "reject" | null>(null);
|
|
const [actionError, setActionError] = useState<string | null>(null);
|
|
const resolutionErrorMessage = useResolutionErrorMessage();
|
|
const [shots, setShots] = useState<{ name: string; url: string }[]>([]);
|
|
const [uploading, setUploading] = useState(false);
|
|
const [uploadError, setUploadError] = useState<string | null>(null);
|
|
const fileInputRef = useRef<HTMLInputElement | null>(null);
|
|
// Screenshots ride along in the revise note as markdown image refs so the
|
|
// board can attach images when sending a plan back — no schema change needed.
|
|
const allowScreenshots = isPlan && Boolean(onUploadImage);
|
|
const rejectRequiresReason = interaction.payload.rejectRequiresReason === true;
|
|
const allowRevise = interaction.payload.allowDeclineReason !== false;
|
|
const reasonPlaceholder =
|
|
interaction.payload.declineReasonPlaceholder
|
|
?? (interaction.payload.acceptLabel === "Approve plan"
|
|
? "Optional: what would you like revised?"
|
|
: "Optional: tell the agent what you'd change.");
|
|
|
|
useEffect(() => {
|
|
setActionError(null);
|
|
setShots([]);
|
|
setUploadError(null);
|
|
if (interaction.status !== "pending") {
|
|
setWorking(null);
|
|
}
|
|
}, [interaction.id, interaction.result?.reason, interaction.status]);
|
|
|
|
async function handleAddScreenshots(files: FileList | null) {
|
|
if (!onUploadImage || !files || files.length === 0) return;
|
|
setUploadError(null);
|
|
setUploading(true);
|
|
try {
|
|
const uploaded: { name: string; url: string }[] = [];
|
|
for (const file of Array.from(files)) {
|
|
if (!file.type.startsWith("image/")) continue;
|
|
const url = await onUploadImage(file);
|
|
uploaded.push({ name: file.name || "screenshot", url });
|
|
}
|
|
if (uploaded.length > 0) setShots((current) => [...current, ...uploaded]);
|
|
} catch {
|
|
setUploadError("Couldn't upload that image. Try again.");
|
|
} finally {
|
|
setUploading(false);
|
|
}
|
|
}
|
|
|
|
function composeReason(text: string) {
|
|
const trimmed = text.trim();
|
|
if (shots.length === 0) return trimmed || undefined;
|
|
const images = shots.map((s) => ``).join("\n");
|
|
return [trimmed, images].filter(Boolean).join("\n\n");
|
|
}
|
|
|
|
async function handleAccept() {
|
|
if (!onAcceptInteraction) return;
|
|
setWorking("accept");
|
|
setActionError(null);
|
|
try {
|
|
await onAcceptInteraction(interaction);
|
|
} catch (error) {
|
|
setActionError(resolutionErrorMessage(error));
|
|
} finally {
|
|
setWorking(null);
|
|
}
|
|
}
|
|
|
|
async function handleReject(reason: string | undefined) {
|
|
if (!onRejectInteraction) return;
|
|
setWorking("reject");
|
|
setActionError(null);
|
|
try {
|
|
await onRejectInteraction(interaction, reason);
|
|
} catch (error) {
|
|
setActionError(resolutionErrorMessage(error));
|
|
} finally {
|
|
setWorking(null);
|
|
}
|
|
}
|
|
|
|
return (
|
|
<div className="space-y-4">
|
|
{interaction.status === "pending" ? (
|
|
<div className={compact ? "space-y-3" : "space-y-3 rounded-sm border border-border/70 bg-background/75 p-4"}>
|
|
<div data-decision-prompt={compact ? true : undefined} className={compact ? "text-lg font-medium leading-relaxed text-foreground" : "text-sm leading-6 text-foreground"}>
|
|
{interaction.payload.prompt}
|
|
</div>
|
|
{interaction.payload.detailsMarkdown ? (
|
|
compact ? <details className="group/confirmation-details">
|
|
<summary className="flex cursor-pointer list-none items-center gap-1 rounded-sm text-xs font-medium text-muted-foreground hover:text-foreground focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-ring">
|
|
<ChevronRight aria-hidden className="h-3.5 w-3.5 transition-transform group-open/confirmation-details:rotate-90 motion-reduce:transition-none" />
|
|
Details
|
|
</summary>
|
|
<div className="mt-2 rounded-sm bg-muted/40 px-2.5 py-2 text-sm text-muted-foreground">
|
|
<MarkdownBody externalReferences={externalReferences}>{interaction.payload.detailsMarkdown}</MarkdownBody>
|
|
</div>
|
|
</details> : <div className="border-t border-border/60 pt-3 text-sm">
|
|
<MarkdownBody externalReferences={externalReferences}>{interaction.payload.detailsMarkdown}</MarkdownBody>
|
|
</div>
|
|
) : null}
|
|
<RequestConfirmationTargetChip
|
|
interaction={interaction}
|
|
target={interaction.payload.target}
|
|
/>
|
|
</div>
|
|
) : null}
|
|
|
|
{interaction.status === "pending" ? (
|
|
<ConfirmationActionRow
|
|
footerSlot={footerSlot}
|
|
resetKey={`${interaction.id}:${interaction.status}`}
|
|
approveLabel={interaction.payload.acceptLabel ?? CONFIRMATION_APPROVE_LABEL}
|
|
rejectLabel={CONFIRMATION_REJECT_LABEL}
|
|
approveVariant={isPlan ? "cta" : "default"}
|
|
primaryActionOnRight={primaryActionOnRight}
|
|
allowRevise={allowRevise}
|
|
rejectRequiresReason={rejectRequiresReason}
|
|
reasonPlaceholder={reasonPlaceholder}
|
|
working={working}
|
|
actionError={actionError}
|
|
preparingApproval={isInteractionPreparingApproval(interaction)}
|
|
canApprove={Boolean(onAcceptInteraction)}
|
|
canReject={Boolean(onRejectInteraction)}
|
|
onApprove={() => void handleAccept()}
|
|
onReject={(reason) => void handleReject(reason)}
|
|
composeReason={composeReason}
|
|
extraReasonSatisfied={shots.length > 0}
|
|
revisePanelChildren={
|
|
allowScreenshots ? (
|
|
<div className="space-y-2">
|
|
{shots.length > 0 ? (
|
|
<div className="flex flex-wrap gap-2">
|
|
{shots.map((shot, index) => (
|
|
<div
|
|
key={`${shot.url}-${index}`}
|
|
className="group relative h-16 w-16 overflow-hidden rounded-sm border border-border/70"
|
|
>
|
|
<img
|
|
src={shot.url}
|
|
alt={shot.name}
|
|
className="h-full w-full object-cover"
|
|
/>
|
|
<button
|
|
type="button"
|
|
aria-label={`Remove ${shot.name}`}
|
|
className="absolute right-0.5 top-0.5 rounded-full bg-background/90 p-0.5 text-foreground opacity-0 transition-opacity group-hover:opacity-100"
|
|
onClick={() =>
|
|
setShots((current) => current.filter((_, i) => i !== index))
|
|
}
|
|
>
|
|
<X className="h-3 w-3" />
|
|
</button>
|
|
</div>
|
|
))}
|
|
</div>
|
|
) : null}
|
|
<input
|
|
ref={fileInputRef}
|
|
type="file"
|
|
accept="image/*"
|
|
multiple
|
|
className="hidden"
|
|
onChange={(event) => {
|
|
void handleAddScreenshots(event.target.value ? event.target.files : null);
|
|
event.target.value = "";
|
|
}}
|
|
/>
|
|
<Button
|
|
type="button"
|
|
size="sm"
|
|
variant="outline"
|
|
disabled={working !== null || uploading}
|
|
onClick={() => fileInputRef.current?.click()}
|
|
>
|
|
{uploading ? (
|
|
<>
|
|
<Loader2 className="mr-2 h-3.5 w-3.5 animate-spin" />
|
|
Uploading...
|
|
</>
|
|
) : (
|
|
<>
|
|
<ImagePlus className="mr-2 h-3.5 w-3.5" />
|
|
Attach screenshots
|
|
</>
|
|
)}
|
|
</Button>
|
|
{uploadError ? (
|
|
<p className="text-xs text-destructive">{uploadError}</p>
|
|
) : null}
|
|
</div>
|
|
) : null
|
|
}
|
|
/>
|
|
) : (
|
|
<RequestConfirmationResolution interaction={interaction} />
|
|
)}
|
|
</div>
|
|
);
|
|
}
|
|
|
|
const CHECKBOX_SUMMARY_LABEL_LIMIT = 8;
|
|
|
|
function RequestCheckboxConfirmationResolution({
|
|
interaction,
|
|
}: {
|
|
interaction: RequestCheckboxConfirmationInteraction;
|
|
}) {
|
|
const target = interaction.payload.target ?? null;
|
|
const [expanded, setExpanded] = useState(false);
|
|
|
|
if (interaction.status === "accepted") {
|
|
const totalOptions = interaction.payload.options.length;
|
|
const selectedLabels = getCheckboxConfirmationSelectedLabels({
|
|
payload: interaction.payload,
|
|
result: interaction.result,
|
|
});
|
|
const selectedCount = interaction.result?.selectedOptionIds?.length ?? selectedLabels.length;
|
|
const visibleLabels = expanded
|
|
? selectedLabels
|
|
: selectedLabels.slice(0, CHECKBOX_SUMMARY_LABEL_LIMIT);
|
|
const hiddenCount = selectedLabels.length - CHECKBOX_SUMMARY_LABEL_LIMIT;
|
|
const hasHiddenLabels = hiddenCount > 0;
|
|
const chipClassName =
|
|
"inline-flex items-center rounded-sm border border-border/60 bg-transparent px-2 py-0.5 text-(length:--text-nano) font-medium uppercase tracking-(--tracking-eyebrow) text-muted-foreground";
|
|
|
|
return (
|
|
<div className="space-y-3">
|
|
<div className="flex flex-wrap items-center gap-2 text-sm leading-6 text-foreground">
|
|
<span className="font-medium">
|
|
{selectedCount === 0
|
|
? "Confirmed with no options selected"
|
|
: `Confirmed ${selectedCount} of ${totalOptions} ${totalOptions === 1 ? "option" : "options"}`}
|
|
</span>
|
|
<RequestConfirmationTargetChip interaction={interaction} target={target} />
|
|
</div>
|
|
{visibleLabels.length > 0 ? (
|
|
<div className="flex flex-wrap gap-1.5">
|
|
{visibleLabels.map((label, index) => (
|
|
<TaskField key={`${label}-${index}`} label="Selected" value={label} />
|
|
))}
|
|
{hasHiddenLabels ? (
|
|
<button
|
|
type="button"
|
|
onClick={() => setExpanded((current) => !current)}
|
|
className={cn(
|
|
chipClassName,
|
|
"cursor-pointer transition-colors hover:border-border hover:text-foreground focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-ring focus-visible:ring-offset-1",
|
|
)}
|
|
aria-expanded={expanded}
|
|
>
|
|
{expanded ? "Show less" : `+${hiddenCount} more`}
|
|
</button>
|
|
) : null}
|
|
</div>
|
|
) : null}
|
|
</div>
|
|
);
|
|
}
|
|
|
|
if (interaction.status === "rejected") {
|
|
return <RequestConfirmationResolution interaction={interaction as unknown as RequestConfirmationInteraction} />;
|
|
}
|
|
|
|
if (interaction.status === "expired") {
|
|
return <RequestConfirmationResolution interaction={interaction as unknown as RequestConfirmationInteraction} />;
|
|
}
|
|
|
|
if (interaction.status === "failed") {
|
|
return (
|
|
<p className="text-sm leading-6 text-muted-foreground">
|
|
This request could not be resolved. Try again or create a new request.
|
|
</p>
|
|
);
|
|
}
|
|
|
|
return null;
|
|
}
|
|
|
|
function CheckboxOptionRow({
|
|
id,
|
|
label,
|
|
description,
|
|
checked,
|
|
disabled,
|
|
onToggle,
|
|
}: {
|
|
id: string;
|
|
label: string;
|
|
description?: string | null;
|
|
checked: boolean;
|
|
disabled: boolean;
|
|
onToggle: (checked: boolean) => void;
|
|
}) {
|
|
return (
|
|
<label
|
|
htmlFor={id}
|
|
className={cn(
|
|
"flex cursor-pointer items-start gap-2.5 border-b border-border/60 px-3 py-2 last:border-b-0 transition-colors",
|
|
checked ? "bg-sky-500/10" : "hover:bg-sky-500/5",
|
|
disabled && "cursor-not-allowed opacity-60",
|
|
)}
|
|
>
|
|
<Checkbox
|
|
id={id}
|
|
checked={checked}
|
|
disabled={disabled}
|
|
onCheckedChange={(value) => onToggle(value === true)}
|
|
aria-label={label}
|
|
className="mt-0.5"
|
|
/>
|
|
<div className="min-w-0 flex-1">
|
|
<div className="text-sm font-medium leading-5 text-foreground">{label}</div>
|
|
{description ? (
|
|
<p className="mt-0.5 text-sm leading-5 text-muted-foreground">{description}</p>
|
|
) : null}
|
|
</div>
|
|
</label>
|
|
);
|
|
}
|
|
|
|
function RequestCheckboxConfirmationCard({
|
|
footerSlot,
|
|
interaction,
|
|
primaryActionOnRight = false,
|
|
onAcceptInteraction,
|
|
onRejectInteraction,
|
|
externalReferences,
|
|
}: {
|
|
footerSlot?: ReactNode;
|
|
interaction: RequestCheckboxConfirmationInteraction;
|
|
primaryActionOnRight?: boolean;
|
|
onAcceptInteraction?: (
|
|
interaction: RequestCheckboxConfirmationInteraction,
|
|
selectedClientKeys: undefined,
|
|
selectedOptionIds: string[],
|
|
) => Promise<void> | void;
|
|
onRejectInteraction?: (
|
|
interaction: RequestCheckboxConfirmationInteraction,
|
|
reason?: string,
|
|
) => Promise<void> | void;
|
|
externalReferences?: MarkdownExternalReferenceMap;
|
|
}) {
|
|
const options = interaction.payload.options;
|
|
const optionIds = useMemo(() => options.map((option) => option.id), [options]);
|
|
const validOptionIds = useMemo(() => new Set(optionIds), [optionIds]);
|
|
const minSelected = interaction.payload.minSelected ?? 0;
|
|
const maxSelected = interaction.payload.maxSelected ?? null;
|
|
|
|
const defaultSelected = useMemo(
|
|
() =>
|
|
new Set(
|
|
(interaction.payload.defaultSelectedOptionIds ?? []).filter((id) => validOptionIds.has(id)),
|
|
),
|
|
[interaction.payload.defaultSelectedOptionIds, validOptionIds],
|
|
);
|
|
|
|
const [selectedOptionIds, setSelectedOptionIds] = useState<Set<string>>(() => new Set(defaultSelected));
|
|
const [working, setWorking] = useState<"accept" | "reject" | null>(null);
|
|
const [acceptAttempted, setAcceptAttempted] = useState(false);
|
|
const [actionError, setActionError] = useState<string | null>(null);
|
|
const resolutionErrorMessage = useResolutionErrorMessage();
|
|
|
|
const optionSeed = useMemo(() => optionIds.join("\n"), [optionIds]);
|
|
|
|
useEffect(() => {
|
|
setSelectedOptionIds(new Set(defaultSelected));
|
|
setAcceptAttempted(false);
|
|
setActionError(null);
|
|
if (interaction.status !== "pending") {
|
|
setWorking(null);
|
|
}
|
|
}, [interaction.id, interaction.status, interaction.result?.reason, defaultSelected, optionSeed]);
|
|
|
|
const rejectRequiresReason = interaction.payload.rejectRequiresReason === true;
|
|
const allowRevise = interaction.payload.allowDeclineReason !== false;
|
|
const reasonPlaceholder =
|
|
interaction.payload.declineReasonPlaceholder ?? "Optional: tell the agent what you'd change.";
|
|
|
|
const selectedCount = selectedOptionIds.size;
|
|
const totalOptions = options.length;
|
|
const atMax = maxSelected != null && selectedCount >= maxSelected;
|
|
const belowMin = selectedCount < minSelected;
|
|
const aboveMax = maxSelected != null && selectedCount > maxSelected;
|
|
const selectionValid = !belowMin && !aboveMax;
|
|
|
|
const validationMessage = belowMin
|
|
? minSelected === 1
|
|
? "Select at least 1 option."
|
|
: `Select at least ${minSelected} options.`
|
|
: aboveMax && maxSelected != null
|
|
? maxSelected === 1
|
|
? "Select at most 1 option."
|
|
: `Select at most ${maxSelected} options.`
|
|
: null;
|
|
|
|
function toggleOption(optionId: string, checked: boolean) {
|
|
setSelectedOptionIds((current) => {
|
|
const next = new Set(current);
|
|
if (checked) {
|
|
next.add(optionId);
|
|
} else {
|
|
next.delete(optionId);
|
|
}
|
|
return next;
|
|
});
|
|
}
|
|
|
|
function handleSelectAll() {
|
|
const capped = maxSelected != null ? optionIds.slice(0, maxSelected) : optionIds;
|
|
setSelectedOptionIds(new Set(capped));
|
|
}
|
|
|
|
function handleClearSelection() {
|
|
setSelectedOptionIds(new Set());
|
|
}
|
|
|
|
async function handleAccept() {
|
|
setAcceptAttempted(true);
|
|
if (!onAcceptInteraction || !selectionValid) return;
|
|
setWorking("accept");
|
|
setActionError(null);
|
|
try {
|
|
await onAcceptInteraction(interaction, undefined, [...selectedOptionIds]);
|
|
} catch (error) {
|
|
setActionError(resolutionErrorMessage(error));
|
|
} finally {
|
|
setWorking(null);
|
|
}
|
|
}
|
|
|
|
async function handleReject(reason: string | undefined) {
|
|
if (!onRejectInteraction) return;
|
|
setWorking("reject");
|
|
setActionError(null);
|
|
try {
|
|
await onRejectInteraction(interaction, reason);
|
|
} catch (error) {
|
|
setActionError(resolutionErrorMessage(error));
|
|
} finally {
|
|
setWorking(null);
|
|
}
|
|
}
|
|
|
|
if (interaction.status !== "pending") {
|
|
return (
|
|
<div className="space-y-4">
|
|
<RequestCheckboxConfirmationResolution interaction={interaction} />
|
|
</div>
|
|
);
|
|
}
|
|
|
|
const selectionSummary = totalOptions > 0 && selectedCount === totalOptions
|
|
? `All ${totalOptions} options selected`
|
|
: `${selectedCount} of ${totalOptions} ${totalOptions === 1 ? "option" : "options"} selected`;
|
|
const boundsHint = maxSelected != null
|
|
? `Pick ${minSelected === maxSelected ? `exactly ${maxSelected}` : `${minSelected}-${maxSelected}`}.`
|
|
: minSelected > 0
|
|
? `Pick at least ${minSelected}.`
|
|
: null;
|
|
|
|
return (
|
|
<div className="space-y-4">
|
|
<div className="space-y-3 rounded-sm border border-border/70 bg-background/75 p-4">
|
|
{/* Show each piece of state once: a connection-authorization prompt is
|
|
the same sentence as the card title, so repeating it here is noise. */}
|
|
{interaction.payload.prompt === interaction.title ? null : (
|
|
<div className="text-sm leading-6 text-foreground">{interaction.payload.prompt}</div>
|
|
)}
|
|
{interaction.payload.detailsMarkdown ? (
|
|
<div className="border-t border-border/60 pt-3 text-sm">
|
|
<MarkdownBody externalReferences={externalReferences}>{interaction.payload.detailsMarkdown}</MarkdownBody>
|
|
</div>
|
|
) : null}
|
|
<RequestConfirmationTargetChip
|
|
interaction={interaction}
|
|
target={interaction.payload.target}
|
|
/>
|
|
</div>
|
|
|
|
<div className="space-y-3">
|
|
<div className="flex flex-wrap items-center justify-between gap-2">
|
|
<div className="flex flex-wrap items-center gap-2 text-xs text-muted-foreground">
|
|
<span>{selectionSummary}</span>
|
|
{boundsHint ? <span>{boundsHint}</span> : null}
|
|
</div>
|
|
<div className="flex flex-wrap items-center gap-2">
|
|
<Button
|
|
size="sm"
|
|
variant="ghost"
|
|
disabled={working !== null || selectedCount === totalOptions || (maxSelected != null && selectedCount >= maxSelected)}
|
|
onClick={handleSelectAll}
|
|
>
|
|
Select all
|
|
</Button>
|
|
<Button
|
|
size="sm"
|
|
variant="ghost"
|
|
disabled={working !== null || selectedCount === 0}
|
|
onClick={handleClearSelection}
|
|
>
|
|
Clear selection
|
|
</Button>
|
|
</div>
|
|
</div>
|
|
|
|
<div
|
|
role="group"
|
|
aria-label="Selectable options"
|
|
className="max-h-80 overflow-y-auto rounded-sm border border-border/70"
|
|
>
|
|
{options.map((option) => {
|
|
const checked = selectedOptionIds.has(option.id);
|
|
return (
|
|
<CheckboxOptionRow
|
|
key={option.id}
|
|
id={`${interaction.id}-${option.id}`}
|
|
label={option.label}
|
|
description={option.description}
|
|
checked={checked}
|
|
disabled={working !== null || (!checked && atMax)}
|
|
onToggle={(value) => toggleOption(option.id, value)}
|
|
/>
|
|
);
|
|
})}
|
|
</div>
|
|
|
|
{acceptAttempted && validationMessage ? (
|
|
<p className="text-xs text-destructive">{validationMessage}</p>
|
|
) : null}
|
|
|
|
<ConfirmationActionRow
|
|
footerSlot={footerSlot}
|
|
resetKey={`${interaction.id}:${interaction.status}`}
|
|
approveLabel={interaction.payload.acceptLabel ?? CONFIRMATION_APPROVE_LABEL}
|
|
rejectLabel={interaction.payload.rejectLabel ?? CONFIRMATION_REJECT_LABEL}
|
|
primaryActionOnRight={primaryActionOnRight}
|
|
allowRevise={allowRevise}
|
|
rejectRequiresReason={rejectRequiresReason}
|
|
reasonPlaceholder={reasonPlaceholder}
|
|
working={working}
|
|
actionError={actionError}
|
|
preparingApproval={isInteractionPreparingApproval(interaction)}
|
|
canApprove={Boolean(onAcceptInteraction)}
|
|
canReject={Boolean(onRejectInteraction)}
|
|
onApprove={() => void handleAccept()}
|
|
onReject={(reason) => void handleReject(reason)}
|
|
/>
|
|
</div>
|
|
</div>
|
|
);
|
|
}
|
|
|
|
// --- Per-item verdicts (C3) ---------------------------------------------
|
|
|
|
const VERDICT_LABEL: Record<RequestItemVerdictValue, string> = {
|
|
approve: "Approve",
|
|
reject: "Reject",
|
|
defer: "Defer",
|
|
};
|
|
|
|
/** Present-tense past-participle label for a resolved verdict chip. */
|
|
const VERDICT_RESOLVED_LABEL: Record<RequestItemVerdictValue, string> = {
|
|
approve: "Approved",
|
|
reject: "Rejected",
|
|
defer: "Deferred",
|
|
};
|
|
|
|
function verdictChipClasses(verdict: RequestItemVerdictValue) {
|
|
switch (verdict) {
|
|
case "approve":
|
|
return "border-emerald-500/60 bg-emerald-500/10 text-emerald-900 dark:bg-emerald-500/15 dark:text-emerald-100";
|
|
case "reject":
|
|
return "border-rose-500/60 bg-rose-500/10 text-rose-900 dark:bg-rose-500/15 dark:text-rose-100";
|
|
default:
|
|
return "border-border/70 bg-muted/40 text-muted-foreground";
|
|
}
|
|
}
|
|
|
|
function VerdictConsequenceChip({ verdict }: { verdict: RequestItemVerdictValue }) {
|
|
const Icon = verdict === "approve" ? CheckCircle2 : verdict === "reject" ? XCircle : MinusCircle;
|
|
return (
|
|
<span
|
|
className={cn(
|
|
"inline-flex items-center gap-1 rounded-sm border px-2 py-0.5 text-(length:--text-micro) font-semibold uppercase tracking-(--tracking-eyebrow)",
|
|
verdictChipClasses(verdict),
|
|
)}
|
|
>
|
|
<Icon className="h-3.5 w-3.5" aria-hidden />
|
|
{VERDICT_RESOLVED_LABEL[verdict]}
|
|
</span>
|
|
);
|
|
}
|
|
|
|
function ItemVerdictDeepLink({ item, interaction }: { item: RequestItemVerdictsItem; interaction: RequestItemVerdictsInteraction }) {
|
|
const href = itemVerdictHref(item, interaction);
|
|
if (!href) return null;
|
|
const isInternal = !href.startsWith("/api/") && (href.startsWith("/") || href.startsWith("#"));
|
|
const className =
|
|
"inline-flex items-center gap-1 text-xs font-medium text-primary hover:underline focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-ring focus-visible:ring-offset-1";
|
|
const label = (
|
|
<>
|
|
Open
|
|
{isInternal ? <ArrowUpRight className="h-3 w-3" aria-hidden /> : <ExternalLink className="h-3 w-3" aria-hidden />}
|
|
</>
|
|
);
|
|
if (isInternal) {
|
|
return (
|
|
<Link to={href} className={className}>
|
|
{label}
|
|
</Link>
|
|
);
|
|
}
|
|
return (
|
|
<a href={href} target="_blank" rel="noreferrer" className={className}>
|
|
{label}
|
|
</a>
|
|
);
|
|
}
|
|
|
|
function ItemVerdictSegmentedControl({
|
|
itemId,
|
|
verdicts,
|
|
value,
|
|
disabled,
|
|
onSelect,
|
|
}: {
|
|
itemId: string;
|
|
verdicts: RequestItemVerdictValue[];
|
|
value: RequestItemVerdictValue | null;
|
|
disabled: boolean;
|
|
onSelect: (verdict: RequestItemVerdictValue) => void;
|
|
}) {
|
|
return (
|
|
<div
|
|
role="group"
|
|
aria-label="Choose a verdict"
|
|
className="flex shrink-0 flex-wrap items-center gap-2"
|
|
>
|
|
{verdicts.map((verdict) => {
|
|
const active = value === verdict;
|
|
const variant = verdict === "reject"
|
|
? (active ? "destructive" : "outline")
|
|
: verdict === "approve"
|
|
? (active ? "default" : "outline")
|
|
: (active ? "secondary" : "outline");
|
|
const Icon = verdict === "approve" ? Check : verdict === "reject" ? X : MinusCircle;
|
|
return (
|
|
<Button
|
|
key={verdict}
|
|
type="button"
|
|
size="sm"
|
|
variant={variant}
|
|
disabled={disabled}
|
|
aria-pressed={active}
|
|
aria-label={`${VERDICT_LABEL[verdict]} this item`}
|
|
className="min-h-11 min-w-24"
|
|
onClick={() => onSelect(verdict)}
|
|
data-verdict={verdict}
|
|
data-item-id={itemId}
|
|
data-active={active}
|
|
>
|
|
<Icon className="h-4 w-4" aria-hidden />
|
|
{VERDICT_LABEL[verdict]}
|
|
</Button>
|
|
);
|
|
})}
|
|
</div>
|
|
);
|
|
}
|
|
|
|
interface VerdictDraft {
|
|
verdict: RequestItemVerdictValue;
|
|
reason: string;
|
|
}
|
|
|
|
function RequestItemVerdictsCard({
|
|
footerSlot,
|
|
interaction,
|
|
onSubmitInteractionVerdicts,
|
|
externalReferences,
|
|
}: {
|
|
footerSlot?: ReactNode;
|
|
interaction: RequestItemVerdictsInteraction;
|
|
onSubmitInteractionVerdicts?: (
|
|
interaction: RequestItemVerdictsInteraction,
|
|
verdicts: { id: string; verdict: RequestItemVerdictValue; reason?: string }[],
|
|
) => Promise<void> | void;
|
|
externalReferences?: MarkdownExternalReferenceMap;
|
|
}) {
|
|
const payload = interaction.payload;
|
|
const items = payload.items;
|
|
const enabledVerdicts = useMemo<RequestItemVerdictValue[]>(
|
|
() => payload.verdicts ?? ["approve", "reject"],
|
|
[payload.verdicts],
|
|
);
|
|
const requireReasonOn = useMemo(
|
|
() => new Set<RequestItemVerdictValue>(payload.requireReasonOn ?? ["reject"]),
|
|
[payload.requireReasonOn],
|
|
);
|
|
const allowBulkApprove = payload.allowBulkApprove !== false && enabledVerdicts.includes("approve");
|
|
const reasonLabel = payload.reasonLabel ?? "Reason";
|
|
|
|
const resolvedById = useMemo(
|
|
() => new Map<string, RequestItemVerdictsResultItem>((interaction.result?.items ?? []).map((item) => [item.id, item])),
|
|
[interaction.result],
|
|
);
|
|
|
|
const [drafts, setDrafts] = useState<Map<string, VerdictDraft>>(new Map());
|
|
const [applyingItemIds, setApplyingItemIds] = useState<Set<string>>(new Set());
|
|
const [working, setWorking] = useState(false);
|
|
const [attempted, setAttempted] = useState(false);
|
|
const [actionError, setActionError] = useState<string | null>(null);
|
|
const resolutionErrorMessage = useResolutionErrorMessage();
|
|
|
|
// When the server merges newly-resolved items, drop their local drafts and
|
|
// clear the applying/working state so the terminal chips take over (S3 → S4).
|
|
useEffect(() => {
|
|
setDrafts((current) => {
|
|
let changed = false;
|
|
const next = new Map(current);
|
|
for (const id of [...next.keys()]) {
|
|
if (resolvedById.has(id)) {
|
|
next.delete(id);
|
|
changed = true;
|
|
}
|
|
}
|
|
return changed ? next : current;
|
|
});
|
|
setApplyingItemIds(new Set());
|
|
setWorking(false);
|
|
setActionError(null);
|
|
}, [resolvedById]);
|
|
|
|
const progress = getItemVerdictProgress({ payload, result: interaction.result });
|
|
const isTerminal = interaction.status !== "pending";
|
|
const isExpired = interaction.status === "expired";
|
|
const isComplete = interaction.status === "answered" || progress.decided === progress.total;
|
|
|
|
const draftEntries = [...drafts.entries()];
|
|
const draftCount = draftEntries.length;
|
|
const invalidDraftIds = new Set(
|
|
draftEntries
|
|
.filter(([, draft]) => requireReasonOn.has(draft.verdict) && draft.reason.trim().length === 0)
|
|
.map(([id]) => id),
|
|
);
|
|
// Apply is enabled as soon as there is ≥1 draft (spec §1). If a required
|
|
// reject reason is missing, clicking Apply reveals the inline error instead
|
|
// of silently submitting — the reason gates the actual submit (spec AC).
|
|
const hasDrafts = draftCount > 0 && !working && Boolean(onSubmitInteractionVerdicts);
|
|
const canApply = hasDrafts && invalidDraftIds.size === 0;
|
|
|
|
function toggleDraft(itemId: string, verdict: RequestItemVerdictValue) {
|
|
setDrafts((current) => {
|
|
const next = new Map(current);
|
|
const existing = next.get(itemId);
|
|
if (existing?.verdict === verdict) {
|
|
next.delete(itemId); // per-item undo
|
|
} else {
|
|
next.set(itemId, { verdict, reason: existing?.reason ?? "" });
|
|
}
|
|
return next;
|
|
});
|
|
}
|
|
|
|
function setDraftReason(itemId: string, reason: string) {
|
|
setDrafts((current) => {
|
|
const existing = current.get(itemId);
|
|
if (!existing) return current;
|
|
const next = new Map(current);
|
|
next.set(itemId, { ...existing, reason });
|
|
return next;
|
|
});
|
|
}
|
|
|
|
function handleApproveAll() {
|
|
if (!allowBulkApprove) return;
|
|
setDrafts((current) => {
|
|
const next = new Map(current);
|
|
for (const id of progress.pendingItemIds) {
|
|
const existing = next.get(id);
|
|
next.set(id, { verdict: "approve", reason: existing?.reason ?? "" });
|
|
}
|
|
return next;
|
|
});
|
|
}
|
|
|
|
async function handleApply() {
|
|
setAttempted(true);
|
|
if (!onSubmitInteractionVerdicts || draftCount === 0 || invalidDraftIds.size > 0) return;
|
|
const verdicts = draftEntries.map(([id, draft]) => ({
|
|
id,
|
|
verdict: draft.verdict,
|
|
reason: draft.reason.trim() ? draft.reason.trim() : undefined,
|
|
}));
|
|
setWorking(true);
|
|
setApplyingItemIds(new Set(verdicts.map((entry) => entry.id)));
|
|
setActionError(null);
|
|
try {
|
|
await onSubmitInteractionVerdicts(interaction, verdicts);
|
|
// Success: the parent refetch updates `interaction.result`, the effect
|
|
// above clears drafts + applying state, and terminal chips render.
|
|
} catch (error) {
|
|
setActionError(resolutionErrorMessage(error));
|
|
setApplyingItemIds(new Set());
|
|
setWorking(false);
|
|
}
|
|
}
|
|
|
|
const applyLabel = draftCount === 0
|
|
? "Apply 0 decisions"
|
|
: `Apply ${draftCount} decision${draftCount === 1 ? "" : "s"}`;
|
|
|
|
return (
|
|
<div className="space-y-4">
|
|
{/* Prompt + details (S1) */}
|
|
<div className="space-y-3 rounded-sm border border-border/70 bg-background/75 p-4">
|
|
<div className="flex flex-wrap items-center justify-between gap-2">
|
|
<div className="text-sm leading-6 text-foreground">{payload.prompt}</div>
|
|
<VerdictProgressBadge progress={progress} pendingReason={invalidDraftIds.size > 0} />
|
|
</div>
|
|
{payload.detailsMarkdown ? (
|
|
<div className="border-t border-border/60 pt-3 text-sm">
|
|
<MarkdownBody externalReferences={externalReferences}>{payload.detailsMarkdown}</MarkdownBody>
|
|
</div>
|
|
) : null}
|
|
{interaction.payload.target ? (
|
|
<RequestConfirmationTargetChip interaction={interaction} target={interaction.payload.target} />
|
|
) : null}
|
|
</div>
|
|
|
|
{/* Stale / superseded notice (S6) */}
|
|
{isExpired ? (
|
|
<div className="rounded-sm border border-amber-500/50 bg-amber-500/10 px-3 py-2 text-sm text-amber-900 dark:text-amber-100">
|
|
<div className="flex items-center gap-2 font-medium">
|
|
<AlertTriangle className="h-4 w-4" aria-hidden />
|
|
{interaction.result?.outcome === "superseded_by_comment"
|
|
? "This review expired after a later comment."
|
|
: interaction.result?.outcome === "stale_target"
|
|
? "This review expired after the target changed."
|
|
: "This review expired."}
|
|
</div>
|
|
{progress.decided > 0 ? (
|
|
<p className="mt-1 text-xs leading-5">
|
|
{progress.decided === 1 ? "1 item was" : `${progress.decided} items were`} already applied and cannot be
|
|
reverted. Remaining items were cancelled.
|
|
</p>
|
|
) : null}
|
|
</div>
|
|
) : null}
|
|
|
|
{/* Item list (S1/S2/S3/S4) */}
|
|
<ul className="space-y-2" aria-label="Items to review">
|
|
{items.map((item) => {
|
|
const resolved = resolvedById.get(item.id);
|
|
const applying = applyingItemIds.has(item.id);
|
|
const draft = drafts.get(item.id);
|
|
return (
|
|
<li
|
|
key={item.id}
|
|
className={cn(
|
|
"rounded-sm border border-border/70 bg-background/60 p-3",
|
|
draft && !resolved && "border-border",
|
|
)}
|
|
data-item-id={item.id}
|
|
data-item-state={resolved ? "resolved" : applying ? "applying" : draft ? "draft" : "pending"}
|
|
>
|
|
<div className="flex flex-wrap items-start justify-between gap-3">
|
|
<div className="min-w-0 flex-1 basis-64">
|
|
<div className="flex flex-wrap items-center gap-2">
|
|
<span className="text-sm font-medium leading-5 text-foreground">{item.label}</span>
|
|
<ItemVerdictDeepLink item={item} interaction={interaction} />
|
|
</div>
|
|
{item.description ? (
|
|
<p className="mt-0.5 text-sm leading-5 text-muted-foreground">{item.description}</p>
|
|
) : null}
|
|
{item.previewMarkdown ? (
|
|
<div className="mt-2 rounded-sm border border-border/50 bg-muted/20 px-2.5 py-2 text-xs">
|
|
<MarkdownBody externalReferences={externalReferences}>{item.previewMarkdown}</MarkdownBody>
|
|
</div>
|
|
) : null}
|
|
{resolved?.reason ? (
|
|
<p className="mt-2 text-xs leading-5 text-muted-foreground">
|
|
<span className="font-medium text-foreground">{reasonLabel}: </span>
|
|
{resolved.reason}
|
|
</p>
|
|
) : null}
|
|
</div>
|
|
|
|
<div className="flex shrink-0 flex-col items-end gap-1">
|
|
{resolved ? (
|
|
<VerdictConsequenceChip verdict={resolved.verdict} />
|
|
) : applying ? (
|
|
<span className="inline-flex items-center gap-1.5 rounded-sm border border-border/70 bg-muted/40 px-2 py-0.5 text-(length:--text-micro) font-semibold uppercase tracking-(--tracking-eyebrow) text-muted-foreground">
|
|
<Loader2 className="h-3.5 w-3.5 motion-safe:animate-spin" aria-hidden />
|
|
Applying…
|
|
</span>
|
|
) : isTerminal ? (
|
|
<span className="inline-flex items-center gap-1 rounded-sm border border-border/70 bg-muted/30 px-2 py-0.5 text-(length:--text-micro) font-semibold uppercase tracking-(--tracking-eyebrow) text-muted-foreground">
|
|
<CircleDashed className="h-3.5 w-3.5" aria-hidden />
|
|
Not decided
|
|
</span>
|
|
) : (
|
|
<ItemVerdictSegmentedControl
|
|
itemId={item.id}
|
|
verdicts={enabledVerdicts}
|
|
value={draft?.verdict ?? null}
|
|
disabled={working}
|
|
onSelect={(verdict) => toggleDraft(item.id, verdict)}
|
|
/>
|
|
)}
|
|
</div>
|
|
</div>
|
|
|
|
{/* Draft reason field (S2) — reveals when the draft verdict needs a reason */}
|
|
{!resolved && !applying && draft && requireReasonOn.has(draft.verdict) ? (
|
|
<div className="mt-3 space-y-1.5">
|
|
<label
|
|
htmlFor={`${interaction.id}-${item.id}-reason`}
|
|
className="text-xs font-medium text-foreground"
|
|
>
|
|
{reasonLabel}
|
|
</label>
|
|
<Textarea
|
|
id={`${interaction.id}-${item.id}-reason`}
|
|
value={draft.reason}
|
|
onChange={(event) => setDraftReason(item.id, event.target.value)}
|
|
placeholder="Give the agent a reason so it can act on this item."
|
|
aria-invalid={attempted && invalidDraftIds.has(item.id)}
|
|
className={cn(
|
|
"min-h-16 bg-background text-sm",
|
|
attempted && invalidDraftIds.has(item.id) && "border-rose-500 focus-visible:ring-rose-500/25",
|
|
)}
|
|
/>
|
|
{attempted && invalidDraftIds.has(item.id) ? (
|
|
<p className="text-xs text-destructive">A reason is required to {VERDICT_LABEL[draft.verdict].toLowerCase()} this item.</p>
|
|
) : null}
|
|
</div>
|
|
) : null}
|
|
</li>
|
|
);
|
|
})}
|
|
</ul>
|
|
|
|
{/* Complete summary (S5) */}
|
|
{isComplete && !isExpired ? (
|
|
<div className="flex flex-wrap items-center gap-2 rounded-sm border border-emerald-500/50 bg-emerald-500/10 px-3 py-2 text-sm text-emerald-900 dark:text-emerald-100">
|
|
<CheckCircle2 className="h-4 w-4" aria-hidden />
|
|
<span className="font-medium">
|
|
{progress.decided} decided · {progress.approved} approved · {progress.rejected} rejected
|
|
{progress.deferred > 0 ? ` · ${progress.deferred} deferred` : ""}
|
|
</span>
|
|
</div>
|
|
) : null}
|
|
|
|
{/* Pinned batch bar (S1/S2) — only while items remain actionable */}
|
|
{!isTerminal && progress.pendingItemIds.length > 0 ? (
|
|
<DecisionCardFooter leading={footerSlot}>
|
|
<div className="flex flex-wrap items-center justify-between gap-2 border-t border-border/60 pt-3">
|
|
<div className="text-xs text-muted-foreground">
|
|
{draftCount > 0
|
|
? `${draftCount} draft verdict${draftCount === 1 ? "" : "s"} ready to apply`
|
|
: "Mark verdicts, then apply them in one pass."}
|
|
</div>
|
|
<div className="flex flex-wrap items-center gap-2">
|
|
{allowBulkApprove ? (
|
|
<Button
|
|
type="button"
|
|
size="sm"
|
|
variant="outline"
|
|
disabled={working || progress.pendingItemIds.length === 0}
|
|
onClick={handleApproveAll}
|
|
>
|
|
<ThumbsUp className="h-4 w-4" aria-hidden />
|
|
Approve all
|
|
</Button>
|
|
) : null}
|
|
<Button
|
|
type="button"
|
|
size="sm"
|
|
variant="default"
|
|
aria-disabled={!canApply}
|
|
disabled={!hasDrafts}
|
|
onClick={() => void handleApply()}
|
|
>
|
|
{working ? (
|
|
<>
|
|
<Loader2 className="h-4 w-4 motion-safe:animate-spin" aria-hidden />
|
|
Applying…
|
|
</>
|
|
) : (
|
|
applyLabel
|
|
)}
|
|
</Button>
|
|
</div>
|
|
</div>
|
|
</DecisionCardFooter>
|
|
) : null}
|
|
|
|
<InteractionActionError message={actionError} />
|
|
</div>
|
|
);
|
|
}
|
|
|
|
function VerdictProgressBadge({
|
|
progress,
|
|
pendingReason,
|
|
}: {
|
|
progress: ReturnType<typeof getItemVerdictProgress>;
|
|
pendingReason: boolean;
|
|
}) {
|
|
const pct = progress.total > 0 ? Math.round((progress.decided / progress.total) * 100) : 0;
|
|
return (
|
|
<div className="flex items-center gap-2">
|
|
{/* Von Restorff accent when a draft reject is missing its reason */}
|
|
{pendingReason ? (
|
|
<span className="inline-flex items-center gap-1 rounded-sm border border-amber-500/60 bg-amber-500/10 px-1.5 py-0.5 text-(length:--text-nano) font-semibold uppercase tracking-(--tracking-eyebrow) text-amber-900 dark:text-amber-100">
|
|
<AlertTriangle className="h-3 w-3" aria-hidden />
|
|
Reason needed
|
|
</span>
|
|
) : null}
|
|
<div
|
|
className="flex items-center gap-2"
|
|
role="progressbar"
|
|
aria-valuemin={0}
|
|
aria-valuemax={progress.total}
|
|
aria-valuenow={progress.decided}
|
|
aria-label={`${progress.decided} of ${progress.total} decided`}
|
|
>
|
|
<div className="h-1.5 w-16 overflow-hidden rounded-full bg-muted">
|
|
<div
|
|
className="h-full rounded-full bg-primary transition-[width] motion-reduce:transition-none"
|
|
style={{ width: `${pct}%` }}
|
|
/>
|
|
</div>
|
|
<span className="whitespace-nowrap text-xs font-medium text-muted-foreground">
|
|
{progress.decided} of {progress.total} decided
|
|
</span>
|
|
</div>
|
|
</div>
|
|
);
|
|
}
|
|
|
|
export function IssueThreadInteractionCard({
|
|
interaction,
|
|
presentationVariant = "default",
|
|
footerSlot,
|
|
agentMap,
|
|
currentUserId,
|
|
userLabelMap,
|
|
onAcceptInteraction,
|
|
onRejectInteraction,
|
|
onSubmitInteractionAnswers,
|
|
onCancelInteraction,
|
|
primaryActionOnRight,
|
|
onSubmitInteractionVerdicts,
|
|
onUploadImage,
|
|
externalReferences,
|
|
}: IssueThreadInteractionCardProps) {
|
|
const { enabled: coordinatorEnabled } = useCoordinatorWorkspaceEnabled();
|
|
const compactDecision = presentationVariant === "coordinator-decision";
|
|
// Single enforcement point (PAP-424, plan from PAP-420; extended by PAP-437):
|
|
// a card that should never be drawn — a degenerate `ask_user_questions`
|
|
// (placeholder junk like the onboarding `Test / A` card, no genuine question)
|
|
// or a stale sibling the server auto-expired when its creator posted a newer
|
|
// question (`superseded_by_newer_interaction`). Every render site (both thread
|
|
// backbones + the attention resolver) routes through this component, so
|
|
// suppressing here suppresses it everywhere at once. The interaction is still
|
|
// created and stored server-side; only the render is suppressed. Composition
|
|
// sites additionally filter it so no empty slot lingers.
|
|
if (shouldHideInteractionCard(interaction)) return null;
|
|
const isPlan = isPlanConfirmation(interaction);
|
|
const isToolAction =
|
|
interaction.kind === "request_confirmation" && isToolActionConfirmation(interaction);
|
|
const isSecretProposal =
|
|
interaction.kind === "request_confirmation" && isSecretProposalConfirmation(interaction);
|
|
const connectionAuthorization = connectionAuthorizationPayload(interaction);
|
|
const isConnectionAddressee =
|
|
connectionAuthorization && interaction.kind === "request_confirmation"
|
|
? isConnectionAuthorizationAddressee({ interaction, currentUserId })
|
|
: false;
|
|
const connectionAuthorizationState =
|
|
connectionAuthorization && interaction.kind === "request_confirmation"
|
|
? connectionAuthorizationCardState({ interaction, isAddressee: isConnectionAddressee })
|
|
: null;
|
|
const toolActionState =
|
|
isToolAction && interaction.kind === "request_confirmation"
|
|
? toolActionCardState(interaction)
|
|
: null;
|
|
const toolActionStyles = toolActionState ? toolActionStatusClasses(toolActionState) : null;
|
|
const secretProposalState =
|
|
isSecretProposal && interaction.kind === "request_confirmation"
|
|
? secretProposalCardState(interaction)
|
|
: null;
|
|
const secretProposalStyles = secretProposalState
|
|
? secretProposalStatusClasses(secretProposalState)
|
|
: null;
|
|
const resumeFailure = requestConfirmationResumeFailure(interaction);
|
|
const planStyles = isPlan
|
|
? planStatusClasses(
|
|
interaction.status,
|
|
resumeFailure,
|
|
interaction.result && "outcome" in interaction.result ? interaction.result.outcome : null,
|
|
)
|
|
: null;
|
|
// Interactions can be directed at a specific agent or board user. Resolved
|
|
// before the status styling because the connection-authorization badge names
|
|
// the addressee ("Waiting for Carol").
|
|
const addresseeLabel = interaction.addresseeAgentId || interaction.addresseeUserId
|
|
? resolveActorLabel({
|
|
agentId: interaction.addresseeAgentId,
|
|
userId: interaction.addresseeUserId,
|
|
agentMap,
|
|
currentUserId,
|
|
userLabelMap,
|
|
})
|
|
: null;
|
|
const connectionAuthorizationStyles = connectionAuthorization && connectionAuthorizationState
|
|
? connectionAuthorizationStatusClasses(connectionAuthorizationState, {
|
|
providerName: connectionAuthorization.providerName,
|
|
addresseeLabel: addresseeLabel ?? "the addressed person",
|
|
})
|
|
: null;
|
|
const activeStyles =
|
|
connectionAuthorizationStyles ?? secretProposalStyles ?? toolActionStyles ?? planStyles;
|
|
const adminOutcome = getAdministrativeOutcome(interaction);
|
|
const adminReason = adminOutcome ? getAdministrativeReason(interaction) : null;
|
|
// P4 (design review R2): a withdrawal is a neutral administrative retraction by
|
|
// the requester — NOT a board "no". It must not inherit the `cancelled` card's
|
|
// rose/red border + XCircle, which is pixel-identical to a rejected plan and
|
|
// mis-signals a denial to anyone scanning the thread. Give withdrawn its own
|
|
// inert lane (sibling to the calm `expired` state): muted border/badge +
|
|
// MinusCircle ("retracted"). This overrides the plan/tool-action/status styling
|
|
// so a withdrawn plan or confirmation reads "closed", not "changes requested".
|
|
const withdrawnStyles =
|
|
adminOutcome === "withdrawn"
|
|
? { shell: "border-border bg-transparent", badge: "border-border bg-muted/60 text-muted-foreground" }
|
|
: null;
|
|
const StatusIcon = withdrawnStyles
|
|
? MinusCircle
|
|
: activeStyles
|
|
? activeStyles.Icon
|
|
: statusIcon(interaction.status);
|
|
const iconSpin = secretProposalStyles?.spin ?? toolActionStyles?.spin ?? false;
|
|
const styles = withdrawnStyles ?? activeStyles ?? statusClasses(interaction.status);
|
|
const createdByLabel = resolveActorLabel({
|
|
agentId: interaction.createdByAgentId,
|
|
userId: interaction.createdByUserId,
|
|
agentMap,
|
|
currentUserId,
|
|
userLabelMap,
|
|
});
|
|
const resolvedByLabel =
|
|
interaction.resolvedByAgentId || interaction.resolvedByUserId
|
|
? resolveActorLabel({
|
|
agentId: interaction.resolvedByAgentId,
|
|
userId: interaction.resolvedByUserId,
|
|
agentMap,
|
|
currentUserId,
|
|
userLabelMap,
|
|
})
|
|
: null;
|
|
// P4: audit-visible distinction between agent and human resolution.
|
|
const resolvedByAgent = Boolean(interaction.resolvedByAgentId);
|
|
// PAP-17280: the effective audience, shown *before* anyone responds so a
|
|
// reader never has to guess whether an open card is waiting on them. Derived
|
|
// from the same server snapshot the resolver routes enforce, so the copy
|
|
// cannot promise a wider audience than the API allows.
|
|
const audience = describeInteractionAudience({
|
|
interaction,
|
|
creatorLabel: createdByLabel,
|
|
addresseeLabel,
|
|
});
|
|
if (coordinatorEnabled && !compactDecision && interaction.kind === "suggest_tasks") {
|
|
return <InteractionAudienceContext.Provider value={audience}>
|
|
<CoordinatorTaskCommitment interaction={interaction}>
|
|
<div className="p-4 space-y-3">
|
|
{interaction.status === "pending" ? <InteractionAudienceLine audience={audience} /> : null}
|
|
<SuggestTasksCard interaction={interaction} agentMap={agentMap} currentUserId={currentUserId}
|
|
userLabelMap={userLabelMap} onAcceptInteraction={onAcceptInteraction} onRejectInteraction={onRejectInteraction} />
|
|
</div>
|
|
</CoordinatorTaskCommitment>
|
|
</InteractionAudienceContext.Provider>;
|
|
}
|
|
if (interaction.kind === "connection_intent" && interaction.payload.accessRequest) {
|
|
return (
|
|
<div id={`interaction-${interaction.id}`}>
|
|
<ConnectionIntentInteractionBody
|
|
footerSlot={footerSlot}
|
|
interaction={interaction}
|
|
currentUserId={currentUserId}
|
|
addresseeLabel={addresseeLabel ?? "the addressed person"}
|
|
/>
|
|
</div>
|
|
);
|
|
}
|
|
if (isToolAction && interaction.kind === "request_confirmation" && toolActionState) {
|
|
return (
|
|
<InteractionAudienceContext.Provider value={audience}>
|
|
<RequestToolActionCard
|
|
footerSlot={footerSlot}
|
|
interaction={interaction}
|
|
state={toolActionState}
|
|
onAcceptInteraction={onAcceptInteraction}
|
|
onRejectInteraction={onRejectInteraction}
|
|
externalReferences={externalReferences}
|
|
/>
|
|
</InteractionAudienceContext.Provider>
|
|
);
|
|
}
|
|
const statusText =
|
|
adminOutcome === "withdrawn"
|
|
? "Withdrawn"
|
|
: adminOutcome === "issue_closed"
|
|
? "Expired · issue closed"
|
|
: activeStyles
|
|
? activeStyles.label
|
|
: statusLabel(interaction.status);
|
|
|
|
// The decision surface already names its source task. The actionable prompt
|
|
// carries the heading; keep only distinct context, not a second task title.
|
|
const bodyNamesDecision = interaction.kind === "ask_user_questions"
|
|
|| (interaction.kind === "request_confirmation" && !connectionAuthorization && !isSecretProposal);
|
|
const bodyContext = interaction.kind === "ask_user_questions"
|
|
? [interaction.payload.questionSet?.description, ...interaction.payload.questions.flatMap(question => [question.prompt, question.helpText])]
|
|
: interaction.kind === "request_confirmation" ? [interaction.payload.prompt, interaction.payload.detailsMarkdown] : [];
|
|
const summaryIsRepeated = bodyContext.some(text => text?.trim() === interaction.summary?.trim());
|
|
const addressedElsewhere = Boolean(interaction.addresseeAgentId
|
|
|| (interaction.addresseeUserId && interaction.addresseeUserId !== currentUserId));
|
|
|
|
return (
|
|
// Every nested subcard resolves the same interaction, so they all explain a
|
|
// denial with the same audience the header states (PAP-17287).
|
|
<InteractionAudienceContext.Provider value={audience}>
|
|
<div data-presentation={presentationVariant} className={compactDecision ? "coordinator-decision-content space-y-4" : cn("rounded-lg border p-5 shadow-none", styles.shell)}>
|
|
{compactDecision ? <>
|
|
{!bodyNamesDecision && interaction.title ? <h2 className="text-lg font-medium">{interaction.title}</h2> : null}
|
|
{interaction.summary && !summaryIsRepeated && !connectionAuthorization && interaction.kind !== "connection_intent" ? <p className="text-sm text-muted-foreground">{interaction.summary}</p> : null}
|
|
{interaction.status === "pending" ? <div className={addressedElsewhere ? undefined : "sr-only"}><InteractionAudienceLine audience={audience} variant="compact" /></div> : null}
|
|
</> : <div className="flex flex-wrap items-start justify-between gap-4">
|
|
<div className="min-w-0 flex-1 basis-64">
|
|
<div className="flex flex-wrap items-center gap-2">
|
|
<span
|
|
data-testid="interaction-status-badge"
|
|
className={cn(
|
|
"inline-flex items-center gap-1 rounded-sm border px-2.5 py-1 text-(length:--text-micro) font-semibold uppercase tracking-(--tracking-eyebrow)",
|
|
styles.badge,
|
|
)}
|
|
>
|
|
<StatusIcon className={cn("h-3.5 w-3.5", iconSpin && "animate-spin")} />
|
|
{isSecretProposal ? (
|
|
<span className="flex flex-col sm:flex-row sm:items-center sm:gap-1">
|
|
<span>Secret binding</span>
|
|
<span className="hidden text-current/60 sm:inline">/</span>
|
|
<span>{statusText}</span>
|
|
</span>
|
|
) : connectionAuthorization ? (
|
|
// One state, in the reader's own terms: "Action required",
|
|
// "Waiting for Carol", "Gmail connected". The interaction kind
|
|
// is machinery the person being asked does not need.
|
|
<span>{statusText}</span>
|
|
) : (
|
|
<>
|
|
{isPlan ? "Plan" : interactionKindLabel(interaction.kind)}
|
|
<span className="text-current/60">/</span>
|
|
{statusText}
|
|
</>
|
|
)}
|
|
</span>
|
|
{addresseeLabel ? (
|
|
<Tooltip>
|
|
<TooltipTrigger asChild>
|
|
<Badge
|
|
variant="secondary"
|
|
className="gap-1"
|
|
data-testid="interaction-addressee-badge"
|
|
>
|
|
<Bot className="h-3 w-3" />
|
|
For {addresseeLabel}
|
|
</Badge>
|
|
</TooltipTrigger>
|
|
<TooltipContent side="bottom" className="max-w-xs text-xs">
|
|
Directed to {addresseeLabel}. Agent-addressed interactions are owned by that agent and are kept out of the open organization attention feed.
|
|
</TooltipContent>
|
|
</Tooltip>
|
|
) : null}
|
|
</div>
|
|
|
|
<div className="mt-3 text-lg font-bold text-foreground">
|
|
{interaction.title
|
|
?? (interaction.kind === "suggest_tasks"
|
|
? "Suggested task tree"
|
|
: interaction.kind === "ask_user_questions"
|
|
// Only a human-only card is genuinely "for the operator";
|
|
// an open card is answerable by any teammate (PAP-17280).
|
|
? interaction.payload.title
|
|
?? (audience.policy === "human_only"
|
|
? "Questions for the operator"
|
|
: "Questions to answer")
|
|
: interaction.kind === "request_checkbox_confirmation"
|
|
? "Checkbox confirmation requested"
|
|
: isSecretProposal
|
|
? "Secret binding requested"
|
|
: connectionAuthorization
|
|
? `Connect your ${connectionAuthorization.providerName} to continue`
|
|
: isToolAction
|
|
? "Tool approval requested"
|
|
: interaction.kind === "request_item_verdicts"
|
|
? "Review these items"
|
|
: isPlan
|
|
? "Plan review"
|
|
: "Confirmation requested")}
|
|
</div>
|
|
{/* A connection-authorization card composes its own single body
|
|
below, because the closing sentence depends on whether the
|
|
reader is the person who may consent. Rendering the summary here
|
|
as well would be the second body PAP-17859 removed. */}
|
|
{interaction.summary && !connectionAuthorization && interaction.kind !== "connection_intent" ? (
|
|
<p className="mt-2 max-w-3xl text-sm leading-6 text-muted-foreground">
|
|
{interaction.summary}
|
|
</p>
|
|
) : null}
|
|
{interaction.status === "pending" ? (
|
|
<InteractionAudienceLine audience={audience} className="mt-3" />
|
|
) : null}
|
|
</div>
|
|
|
|
<Tooltip>
|
|
<TooltipTrigger asChild>
|
|
<div className="rounded-sm border border-border/70 bg-transparent px-3 py-2 text-right text-xs text-muted-foreground">
|
|
<div className="font-medium text-foreground">{formatShortDate(interaction.createdAt)}</div>
|
|
<div>proposed by {createdByLabel}</div>
|
|
</div>
|
|
</TooltipTrigger>
|
|
<TooltipContent side="bottom" className="text-xs">
|
|
Created {formatDateTime(interaction.createdAt)}
|
|
</TooltipContent>
|
|
</Tooltip>
|
|
</div>}
|
|
|
|
<div className={compactDecision ? undefined : "mt-5"}>
|
|
{interaction.kind === "suggest_tasks" ? (
|
|
<SuggestTasksCard
|
|
footerSlot={footerSlot}
|
|
interaction={interaction}
|
|
agentMap={agentMap}
|
|
currentUserId={currentUserId}
|
|
userLabelMap={userLabelMap}
|
|
onAcceptInteraction={onAcceptInteraction}
|
|
onRejectInteraction={onRejectInteraction}
|
|
/>
|
|
) : interaction.kind === "ask_user_questions" ? (
|
|
<AskUserQuestionsCard
|
|
footerSlot={footerSlot}
|
|
interaction={interaction}
|
|
compact={compactDecision}
|
|
onSubmitInteractionAnswers={onSubmitInteractionAnswers}
|
|
onCancelInteraction={onCancelInteraction}
|
|
externalReferences={externalReferences}
|
|
/>
|
|
) : interaction.kind === "request_checkbox_confirmation" ? (
|
|
<RequestCheckboxConfirmationCard
|
|
footerSlot={footerSlot}
|
|
interaction={interaction}
|
|
primaryActionOnRight={primaryActionOnRight}
|
|
onAcceptInteraction={onAcceptInteraction}
|
|
onRejectInteraction={onRejectInteraction}
|
|
externalReferences={externalReferences}
|
|
/>
|
|
) : connectionAuthorization
|
|
&& interaction.kind === "request_confirmation"
|
|
&& connectionAuthorizationState ? (
|
|
<RequestConnectionAuthorizationCard
|
|
footerSlot={footerSlot}
|
|
interaction={interaction}
|
|
state={connectionAuthorizationState}
|
|
isAddressee={isConnectionAddressee}
|
|
providerName={connectionAuthorization.providerName}
|
|
addresseeLabel={addresseeLabel ?? "the addressed person"}
|
|
requestingAgentLabel={connectionAuthorization.requestingAgentName ?? null}
|
|
resolvedByLabel={resolvedByLabel}
|
|
resolvedByAgent={resolvedByAgent}
|
|
onRejectInteraction={onRejectInteraction}
|
|
/>
|
|
) : isSecretProposal && interaction.kind === "request_confirmation" && secretProposalState ? (
|
|
<RequestSecretProposalCard
|
|
footerSlot={footerSlot}
|
|
interaction={interaction}
|
|
state={secretProposalState}
|
|
resolvedByLabel={resolvedByLabel}
|
|
onAcceptInteraction={onAcceptInteraction}
|
|
onRejectInteraction={onRejectInteraction}
|
|
/>
|
|
) : interaction.kind === "connection_intent" ? (
|
|
<ConnectionIntentInteractionBody
|
|
footerSlot={footerSlot}
|
|
interaction={interaction}
|
|
currentUserId={currentUserId}
|
|
addresseeLabel={addresseeLabel ?? "the addressed person"}
|
|
addresseeName={interaction.addresseeUserId ? userLabelMap?.get(interaction.addresseeUserId) : undefined}
|
|
/>
|
|
) : interaction.kind === "request_item_verdicts" ? (
|
|
<RequestItemVerdictsCard
|
|
footerSlot={footerSlot}
|
|
interaction={interaction}
|
|
onSubmitInteractionVerdicts={onSubmitInteractionVerdicts}
|
|
externalReferences={externalReferences}
|
|
/>
|
|
) : (
|
|
<RequestConfirmationCard
|
|
footerSlot={footerSlot}
|
|
interaction={interaction}
|
|
compact={compactDecision}
|
|
isPlan={isPlan}
|
|
primaryActionOnRight={primaryActionOnRight}
|
|
onAcceptInteraction={onAcceptInteraction}
|
|
onRejectInteraction={onRejectInteraction}
|
|
onUploadImage={onUploadImage}
|
|
externalReferences={externalReferences}
|
|
/>
|
|
)}
|
|
</div>
|
|
|
|
{footerSlot && ((interaction.status !== "pending" && interaction.kind !== "connection_intent") || (connectionAuthorization && connectionAuthorizationState !== "actionable")) ? <DecisionCardFooter leading={footerSlot} /> : null}
|
|
|
|
{adminOutcome === "withdrawn" ? (
|
|
<div
|
|
className="mt-4 border-t border-border/60 pt-3 text-xs text-muted-foreground"
|
|
data-testid="interaction-withdrawn-footer"
|
|
>
|
|
<div>
|
|
Withdrawn by{" "}
|
|
<span className="font-medium text-foreground">{resolvedByLabel ?? "an agent"}</span>
|
|
{resolvedByAgent ? <ResolvedByAgentChip /> : null}
|
|
{interaction.resolvedAt ? ` on ${formatShortDate(interaction.resolvedAt)}` : ""}
|
|
</div>
|
|
{adminReason ? (
|
|
<div className="mt-1 italic text-muted-foreground/90">"{adminReason}"</div>
|
|
) : null}
|
|
</div>
|
|
) : adminOutcome === "issue_closed" && interaction.resolvedAt ? (
|
|
// The header badge + body already explain the issue-closed expiry;
|
|
// the footer is just the audit timestamp.
|
|
<div
|
|
className="mt-4 border-t border-border/60 pt-3 text-xs text-muted-foreground"
|
|
data-testid="interaction-issue-closed-footer"
|
|
>
|
|
{formatShortDate(interaction.resolvedAt)}
|
|
</div>
|
|
) : resolvedByLabel && !isToolAction && !connectionAuthorization ? (
|
|
// The connection-authorization card states its own resolver and
|
|
// timestamp inside the "Gmail connected" block, so the shared footer
|
|
// would repeat it.
|
|
<div
|
|
className="mt-4 flex flex-wrap items-center gap-x-1 gap-y-0.5 border-t border-border/60 pt-3 text-xs text-muted-foreground"
|
|
data-testid="interaction-resolved-footer"
|
|
>
|
|
Resolved by <span className="font-medium text-foreground">{resolvedByLabel}</span>
|
|
{resolvedByAgent ? <ResolvedByAgentChip /> : null}
|
|
{interaction.resolvedAt ? ` on ${formatShortDate(interaction.resolvedAt)}` : ""}
|
|
</div>
|
|
) : null}
|
|
</div>
|
|
</InteractionAudienceContext.Provider>
|
|
);
|
|
}
|
|
|
|
/**
|
|
* Small audit chip marking that an interaction was resolved by an agent (rather
|
|
* than a human board member) — governed agent resolution introduced in P2.
|
|
*/
|
|
function ResolvedByAgentChip() {
|
|
return (
|
|
<Tooltip>
|
|
<TooltipTrigger asChild>
|
|
<Badge
|
|
variant="outline"
|
|
className="ml-1 gap-1 border-indigo-500/50 py-0 text-[length:--text-micro] text-indigo-700 dark:text-indigo-200"
|
|
data-testid="interaction-resolved-by-agent-chip"
|
|
>
|
|
<Bot className="h-3 w-3" />
|
|
Agent
|
|
</Badge>
|
|
</TooltipTrigger>
|
|
<TooltipContent side="bottom" className="max-w-xs text-xs">
|
|
Resolved by an agent under the organization's interaction governance policy — audit-distinct from a human board resolution.
|
|
</TooltipContent>
|
|
</Tooltip>
|
|
);
|
|
}
|