mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-10-28 04:02:18 +01:00
## Thinking Path > - Paperclip is the open source app people use to manage AI agents for work > - Its UI is governed by a design system (`DESIGN.md` + the token layer in `ui/src/index.css`, merged in #9134) whose first principle is "one way to say each thing" — one Card, one Badge, one nav row > - After the token extraction landed, ~35 files still hand-rolled card containers, ~45 files hand-rolled pill spans, the sidebar agents section duplicated the nav-row chrome, and the inbox and tasks lists rendered the same task rows two subtly different ways > - Each divergence is a place where a future design change (radius, hover language, status vocabulary) silently misses surfaces, defeating the "edit tokens + run checks" model the design system exists for > - This pull request converges those surfaces onto the shared primitives, codifies the radius scale as the modern multiplicative shadcn ladder, and unifies the row/hover/tree-guide language across the inbox and tasks lists — every visible delta was human-reviewed screen-by-screen against a live instance across nine feedback rounds > - The benefit is that the app's look is now steerable from single knobs (one `--radius` anchor, one Card, one Badge, one row component), and the visual regression suite covers the result (514 snapshots including a new AgentDetail page story) ## Linked Issues or Issue Description No public GitHub issue exists for this work; describing per the feature template: - **Problem**: after the design-token foundation (#9134), component-level drift remained — hand-rolled cards/pills, duplicated sidebar row chrome, and two different renderings of task rows (inbox vs tasks list) meant design changes had to be applied per-surface and frequently missed spots (e.g. status glyphs rendered 16px in the inbox but 20px in the tasks list because a slot override silently beat the component default). - **Proposed behavior**: all card-shaped containers render via `Card`, all label pills via `Badge`, sidebar rows via `SidebarNavItem`, and both task-list surfaces via one `IssueRow` configuration; the radius scale is a single multiplicative ladder anchored at `--radius: 0.5rem`. - **Alternatives considered**: converting interactive `<button>`/`<Link>` cards to `Card` divs (rejected — breaks semantics; documented inline with `design-allow` comments instead); keeping the legacy additive radius ladder (rejected in favor of the standard shadcn multiplicative mapping). ## What Changed - `Card` adoption across ~35 files (settings pages, auth/board flows, dashboards, list containers, KPI tiles); non-adoptable sites (interactive cards, `<li>` rows, class-string props, chart tooltip) carry documented `design-allow(card-pattern)` comments - `Card` gains an `interactive` prop — one quiet hover affordance for clickable cards (cursor, border darken, shadow lift, focus ring), applied to skills tiles, artifact cards, and the company selector; cards carry no resting shadow - `Badge` adoption for 113 hand-rolled pill spans across ~45 files; `PropertyChip` wraps `Badge` internally; `StatusBadge`, external-object chips, and match chips stay bespoke by documented decision (WCAG-tuned status mechanics) - Radius ladder becomes the multiplicative shadcn mapping (`sm/md/lg/xl/2xl/3xl/4xl = 0.6/0.8/1.0/1.4/1.8/2.2/2.6 × --radius`, anchor `0.5rem`); every card surface unifies on `rounded-lg`; the orphaned 8px literal token is deleted - Sidebar: agent rows render via `SidebarNavItem` (new additive props: `iconNode`, `active`, `trailing`, `liveAccessory`); live dots use `--status-agent-running`; one row rhythm and inset rounded pill highlight; right-aligned trailing badges; every labeled section is collapsible - Inbox + tasks lists unified: md status glyphs, `accent/50` rounded row hovers, vertical tree guides under parent rows (opaque underlay so dark-mode translucent borders don't stack), no horizontal dividers under expanded parents; the swipe-to-archive reveal layer shows only mid-swipe; board toggle uses the `SquareKanban` glyph - Kanban: every column carries a status-hued tint; lanes default expanded (including empty); compact mode collapses empty lanes to labeled rails (fixes a clipped, label-less empty-column state) - Storybook: new AgentDetail page story (realistic fixtures, light+dark) joins the visual suite; suite captures with `reducedMotion: 'reduce'` and the ux-lab reasoning ticker honors `prefers-reduced-motion`; a stale lexical alias in `storybook/main.ts` is fixed (build was broken since the lexical 0.46 bump) - Keyboard navigation, from live review of the unified lists: inbox navigation keys work on every tab (archive keys stay scoped to the archivable tab); keyboard-driven scrolling no longer hands the selection to whatever row lands under the stationary cursor (hover selects only after real pointer movement); the tasks list view gains the same j/k / arrows / Enter selection model as the inbox; and the `g` then `i` go-to-inbox chord works app-wide instead of only on the issue detail page - Token gates restored to 3/3 CLEAN (tokenized a post-#9134 regression in the recovery card); decisions recorded in `doc/design/DECISION-SHEET.md` and `doc/design/COMPONENT-INVENTORY.md` (investigation verdicts: FileTree vs WorkspaceFileBrowser and the four entity pickers stay separate — evidence included) ## Verification - `pnpm check:token-gates` → 3/3 CLEAN - `pnpm typecheck` → green (all packages) - `cd ui && npx vitest run` → 2106/2106 (assertions updated in lockstep where they documented superseded decisions; new tests for the global go-to-inbox chord) - `pnpm --filter @paperclipai/ui build` → exit 0 - `pnpm build-storybook` → succeeds (also fixes the lexical-alias break on master) - Visual regression: 514-snapshot Playwright suite green against the updated baseline (zero diffs from the keyboard-navigation round — those changes are purely behavioral). Note: baselines live outside git per the suite design and the baseline-manifest archive is not yet published, so CI cannot run this suite — it was run locally throughout; every visible delta was reviewed screen-by-screen in a live instance across nine review rounds. Review evidence (before/after triplets) intentionally kept out of the repo for size; available on request. - Manual: exercised dashboard, tasks (list + board), inbox, agents, skills, costs, settings, and artifact surfaces in light and dark themes ## Risks - Wide but shallow visual surface: most changes are class-string substitutions with behavior preserved (props, handlers, roles, test ids). The riskiest areas — dnd-kit card refs (React 19 ref-as-prop), inbox swipe-to-archive, and sidebar overlays — are covered by existing unit tests (all green) and were manually exercised. - Intentional visual deltas (rounded cards, tinted kanban columns, md status glyphs, unified hovers) are design decisions recorded in `doc/design/DECISION-SHEET.md`; each maps to a re-baselined snapshot set locally. - The visual suite cannot yet run in CI (unpublished baseline archive — pre-existing condition from #9134); until that lands, snapshot coverage is local-only. ## Model Used - Claude Fable 5 (`claude-fable-5`, Anthropic) via Claude Code — agentic coding with tool use (file editing, test execution, Playwright screenshot verification); extended thinking enabled. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either (a) linked existing issues with `Fixes: #` / `Closes #` / `Refs #` OR (b) described the issue in-PR following the relevant issue template - [x] I have not referenced internal/instance-local Paperclip issues or links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip` URLs) - [x] My branch name describes the change (e.g. `docs/...`, `fix/...`) and contains no internal Paperclip ticket id or instance-derived details - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [ ] All Paperclip CI gates are green (will confirm once CI runs) - [ ] Greptile is 5/5 with no open P2s, recommendations, or follow-ups (pending first review) - [x] I will address all Greptile and reviewer comments before requesting merge 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
420 lines
15 KiB
TypeScript
420 lines
15 KiB
TypeScript
import { useEffect, useMemo, useState } from "react";
|
|
import { useMutation, useQuery, useQueryClient } from "@tanstack/react-query";
|
|
import { useNavigate } from "@/lib/router";
|
|
import { useDialog } from "../context/DialogContext";
|
|
import { useCompany } from "../context/CompanyContext";
|
|
import { accessApi } from "../api/access";
|
|
import { agentsApi } from "../api/agents";
|
|
import { adaptersApi } from "../api/adapters";
|
|
import { queryKeys } from "@/lib/queryKeys";
|
|
import {
|
|
Dialog,
|
|
DialogContent,
|
|
} from "@/components/ui/dialog";
|
|
import { Button } from "@/components/ui/button";
|
|
import { Textarea } from "@/components/ui/textarea";
|
|
import {
|
|
ArrowLeft,
|
|
Bot,
|
|
Check,
|
|
MailPlus,
|
|
Settings2,
|
|
} from "lucide-react";
|
|
import { cn } from "@/lib/utils";
|
|
import { buildAgentOnboardingPrompt } from "@/lib/agent-onboarding-prompt";
|
|
import { listUIAdapters } from "../adapters";
|
|
import { isVisualAdapterChoice } from "../adapters/metadata";
|
|
import { getAdapterDisplay } from "../adapters/adapter-display-registry";
|
|
import { useDisabledAdaptersSync } from "../adapters/use-disabled-adapters";
|
|
import { useToast } from "../context/ToastContext";
|
|
import { Badge } from "@/components/ui/badge";
|
|
|
|
/**
|
|
* Adapter types that are suitable for agent creation (excludes internal
|
|
* system adapters like "process" and "http").
|
|
*/
|
|
const SYSTEM_ADAPTER_TYPES = new Set(["process", "http"]);
|
|
|
|
type NewAgentDialogMode = "choices" | "runtime" | "invite" | "prompt";
|
|
|
|
function isAgentAdapterType(type: string): boolean {
|
|
return !SYSTEM_ADAPTER_TYPES.has(type);
|
|
}
|
|
|
|
export function NewAgentDialog() {
|
|
const { newAgentOpen, closeNewAgent, openNewIssue } = useDialog();
|
|
const { selectedCompanyId } = useCompany();
|
|
const { pushToast } = useToast();
|
|
const navigate = useNavigate();
|
|
const queryClient = useQueryClient();
|
|
const [mode, setMode] = useState<NewAgentDialogMode>("choices");
|
|
const [agentMessage, setAgentMessage] = useState("");
|
|
const [latestAgentPrompt, setLatestAgentPrompt] = useState<string | null>(null);
|
|
const [latestAgentPromptCopied, setLatestAgentPromptCopied] = useState(false);
|
|
const disabledTypes = useDisabledAdaptersSync();
|
|
|
|
function resetDialogState() {
|
|
setMode("choices");
|
|
setAgentMessage("");
|
|
setLatestAgentPrompt(null);
|
|
setLatestAgentPromptCopied(false);
|
|
}
|
|
|
|
useEffect(() => {
|
|
if (!latestAgentPromptCopied) return;
|
|
const timeout = window.setTimeout(() => {
|
|
setLatestAgentPromptCopied(false);
|
|
}, 1600);
|
|
return () => window.clearTimeout(timeout);
|
|
}, [latestAgentPromptCopied]);
|
|
|
|
// Fetch registered adapters from server (syncs disabled store + provides data)
|
|
const { data: serverAdapters } = useQuery({
|
|
queryKey: queryKeys.adapters.all,
|
|
queryFn: () => adaptersApi.list(),
|
|
staleTime: 5 * 60 * 1000,
|
|
});
|
|
|
|
// Fetch existing agents for the "Ask CEO" flow
|
|
const { data: agents } = useQuery({
|
|
queryKey: queryKeys.agents.list(selectedCompanyId!),
|
|
queryFn: () => agentsApi.list(selectedCompanyId!),
|
|
enabled: !!selectedCompanyId && newAgentOpen,
|
|
});
|
|
|
|
const ceoAgent = (agents ?? []).find((a) => a.role === "ceo");
|
|
const inviteHistoryQueryKey = queryKeys.access.invites(selectedCompanyId ?? "", "all", 5);
|
|
|
|
// Build the adapter grid from the UI registry merged with display metadata.
|
|
// This automatically includes external/plugin adapters.
|
|
const adapterGrid = useMemo(() => {
|
|
const registered = listUIAdapters()
|
|
.filter((a) =>
|
|
isAgentAdapterType(a.type) &&
|
|
!disabledTypes.has(a.type) &&
|
|
isVisualAdapterChoice(a.type)
|
|
);
|
|
|
|
// Sort: recommended first, then alphabetical
|
|
return registered
|
|
.map((a) => {
|
|
const display = getAdapterDisplay(a.type);
|
|
return {
|
|
value: a.type,
|
|
label: display.label,
|
|
desc: display.description,
|
|
icon: display.icon,
|
|
recommended: display.recommended,
|
|
comingSoon: display.comingSoon,
|
|
disabledLabel: display.disabledLabel,
|
|
};
|
|
})
|
|
.sort((a, b) => {
|
|
if (a.recommended && !b.recommended) return -1;
|
|
if (!a.recommended && b.recommended) return 1;
|
|
return a.label.localeCompare(b.label);
|
|
});
|
|
}, [disabledTypes, serverAdapters]);
|
|
|
|
function handleAskCeo() {
|
|
closeNewAgent();
|
|
openNewIssue({
|
|
assigneeAgentId: ceoAgent?.id,
|
|
title: "Create a new agent",
|
|
description: "(type in what kind of agent you want here)",
|
|
});
|
|
}
|
|
|
|
function handleAdvancedConfig() {
|
|
setMode("runtime");
|
|
}
|
|
|
|
function handleInviteExternalAgent() {
|
|
setMode("invite");
|
|
}
|
|
|
|
function handleAdvancedAdapterPick(adapterType: string) {
|
|
closeNewAgent();
|
|
resetDialogState();
|
|
navigate(`/agents/new?adapterType=${encodeURIComponent(adapterType)}`);
|
|
}
|
|
|
|
async function copyText(text: string, unavailableBody: string) {
|
|
try {
|
|
if (typeof navigator !== "undefined" && navigator.clipboard?.writeText) {
|
|
await navigator.clipboard.writeText(text);
|
|
return true;
|
|
}
|
|
} catch {
|
|
// Fall through to the unavailable message below.
|
|
}
|
|
|
|
pushToast({
|
|
title: "Clipboard unavailable",
|
|
body: unavailableBody,
|
|
tone: "warn",
|
|
});
|
|
return false;
|
|
}
|
|
|
|
const createAgentInviteMutation = useMutation({
|
|
mutationFn: () =>
|
|
accessApi.createCompanyInvite(selectedCompanyId!, {
|
|
allowedJoinTypes: "agent",
|
|
humanRole: null,
|
|
agentMessage: agentMessage.trim() || null,
|
|
}),
|
|
onSuccess: async (invite) => {
|
|
const base = window.location.origin.replace(/\/+$/, "");
|
|
const onboardingTextLink =
|
|
invite.onboardingTextUrl ??
|
|
invite.onboardingTextPath ??
|
|
`/api/invites/${invite.token}/onboarding.txt`;
|
|
const onboardingTextUrl = onboardingTextLink.startsWith("http")
|
|
? onboardingTextLink
|
|
: `${base}${onboardingTextLink}`;
|
|
|
|
let prompt: string;
|
|
try {
|
|
const manifest = await accessApi.getInviteOnboarding(invite.token);
|
|
prompt = buildAgentOnboardingPrompt({
|
|
onboardingTextUrl,
|
|
connectionCandidates:
|
|
manifest.onboarding.connectivity?.connectionCandidates ?? null,
|
|
testResolutionUrl:
|
|
manifest.onboarding.connectivity?.testResolutionEndpoint?.url ??
|
|
null,
|
|
});
|
|
} catch {
|
|
prompt = buildAgentOnboardingPrompt({
|
|
onboardingTextUrl,
|
|
connectionCandidates: null,
|
|
testResolutionUrl: null,
|
|
});
|
|
}
|
|
|
|
setLatestAgentPrompt(prompt);
|
|
setLatestAgentPromptCopied(false);
|
|
setMode("prompt");
|
|
const copied = await copyText(prompt, "Copy the agent onboarding prompt manually from the field below.");
|
|
|
|
await queryClient.invalidateQueries({ queryKey: inviteHistoryQueryKey });
|
|
pushToast({
|
|
title: "Agent invite created",
|
|
body: copied ? "Agent onboarding prompt ready below and copied to clipboard." : "Agent onboarding prompt ready below.",
|
|
tone: "success",
|
|
});
|
|
},
|
|
onError: (error) => {
|
|
pushToast({
|
|
title: "Failed to create agent invite",
|
|
body: error instanceof Error ? error.message : "Unknown error",
|
|
tone: "error",
|
|
});
|
|
},
|
|
});
|
|
|
|
return (
|
|
<Dialog
|
|
open={newAgentOpen}
|
|
onOpenChange={(open) => {
|
|
if (!open) {
|
|
resetDialogState();
|
|
closeNewAgent();
|
|
}
|
|
}}
|
|
>
|
|
<DialogContent
|
|
showCloseButton={false}
|
|
className={cn(
|
|
"max-h-(--sz-calc-16) p-0 gap-0 overflow-hidden flex flex-col",
|
|
mode === "invite" || mode === "prompt" ? "sm:max-w-2xl" : "sm:max-w-md",
|
|
)}
|
|
>
|
|
{/* Header */}
|
|
<div className="flex items-center justify-between px-4 py-2.5 border-b border-border">
|
|
<span className="text-sm text-muted-foreground">Add a new agent</span>
|
|
<Button
|
|
variant="ghost"
|
|
size="icon-xs"
|
|
className="text-muted-foreground"
|
|
onClick={() => {
|
|
resetDialogState();
|
|
closeNewAgent();
|
|
}}
|
|
>
|
|
<span className="text-lg leading-none">×</span>
|
|
</Button>
|
|
</div>
|
|
|
|
<div className="min-h-0 overflow-y-auto p-6 space-y-6">
|
|
{mode === "choices" ? (
|
|
<>
|
|
{/* Recommendation */}
|
|
<div className="text-center space-y-3">
|
|
<div className="mx-auto flex h-12 w-12 items-center justify-center rounded-full bg-accent">
|
|
<Bot className="h-6 w-6 text-foreground" />
|
|
</div>
|
|
<p className="text-sm text-muted-foreground">
|
|
Ask a leader to propose the hire, configure a runtime yourself,
|
|
or send an onboarding prompt to an external agent.
|
|
</p>
|
|
</div>
|
|
|
|
<Button className="w-full" size="lg" onClick={handleAskCeo}>
|
|
<Bot className="h-4 w-4 mr-2" />
|
|
Ask the CEO to create a new agent
|
|
</Button>
|
|
|
|
<div className="grid gap-2">
|
|
<Button variant="outline" className="w-full" onClick={handleAdvancedConfig}>
|
|
<Settings2 className="h-4 w-4 mr-2" />
|
|
Configure a runtime manually
|
|
</Button>
|
|
<div className="space-y-1">
|
|
<Button variant="outline" className="w-full" onClick={handleInviteExternalAgent}>
|
|
<MailPlus className="h-4 w-4 mr-2" />
|
|
Invite an external agent
|
|
</Button>
|
|
<p className="text-xs text-muted-foreground text-center">
|
|
(OpenClaw, Hermes, or any agent that can call the invite API.)
|
|
</p>
|
|
</div>
|
|
</div>
|
|
</>
|
|
) : mode === "runtime" ? (
|
|
<>
|
|
<div className="space-y-2">
|
|
<button
|
|
className="inline-flex items-center gap-1 text-xs text-muted-foreground hover:text-foreground transition-colors"
|
|
onClick={() => setMode("choices")}
|
|
>
|
|
<ArrowLeft className="h-3.5 w-3.5" />
|
|
Back
|
|
</button>
|
|
<p className="text-sm text-muted-foreground">
|
|
Choose the runtime Paperclip should start or resume directly.
|
|
</p>
|
|
</div>
|
|
|
|
<div className="grid grid-cols-2 gap-2">
|
|
{adapterGrid.map((opt) => (
|
|
<button
|
|
key={opt.value}
|
|
className={cn(
|
|
"flex flex-col items-center gap-1.5 rounded-md border border-border p-3 text-xs transition-colors hover:bg-accent/50 relative",
|
|
opt.comingSoon && "opacity-40 cursor-not-allowed",
|
|
)}
|
|
disabled={!!opt.comingSoon}
|
|
title={opt.comingSoon ? opt.disabledLabel : undefined}
|
|
onClick={() => {
|
|
if (!opt.comingSoon) handleAdvancedAdapterPick(opt.value);
|
|
}}
|
|
>
|
|
{opt.recommended && (
|
|
<Badge variant="ghost" className="absolute -top-1.5 right-1.5 bg-green-500 text-white text-(length:--text-nano) font-semibold px-1.5 leading-none">
|
|
Recommended
|
|
</Badge>
|
|
)}
|
|
<opt.icon className="h-4 w-4" />
|
|
<span className="font-medium">{opt.label}</span>
|
|
<span className="text-muted-foreground text-(length:--text-nano)">
|
|
{opt.desc}
|
|
</span>
|
|
</button>
|
|
))}
|
|
</div>
|
|
</>
|
|
) : mode === "invite" ? (
|
|
<div className="space-y-5">
|
|
<div className="space-y-2">
|
|
<button
|
|
className="inline-flex items-center gap-1 text-xs text-muted-foreground hover:text-foreground transition-colors"
|
|
onClick={() => setMode("choices")}
|
|
>
|
|
<ArrowLeft className="h-3.5 w-3.5" />
|
|
Back
|
|
</button>
|
|
<div className="space-y-1">
|
|
<h2 className="text-sm font-semibold">Invite an external agent</h2>
|
|
<p className="text-sm text-muted-foreground">
|
|
Generate a one-time onboarding prompt that any compatible agent can use to request access, wait for approval, and claim its Paperclip API key.
|
|
</p>
|
|
</div>
|
|
</div>
|
|
|
|
<label className="block space-y-2">
|
|
<span className="text-sm font-medium">Optional message for the agent</span>
|
|
<Textarea
|
|
value={agentMessage}
|
|
onChange={(event) => setAgentMessage(event.target.value)}
|
|
className="min-h-24 resize-y"
|
|
placeholder="Add onboarding context, expected role, or first instructions."
|
|
maxLength={4000}
|
|
/>
|
|
</label>
|
|
|
|
<div className="rounded-lg border border-border px-4 py-3 text-sm text-muted-foreground">
|
|
Agent invites create a join request first. A company admin still approves the request before the agent can claim its API key.
|
|
</div>
|
|
|
|
<div>
|
|
<Button
|
|
onClick={() => createAgentInviteMutation.mutate()}
|
|
disabled={!selectedCompanyId || createAgentInviteMutation.isPending}
|
|
>
|
|
{createAgentInviteMutation.isPending ? "Generating…" : "Generate onboarding prompt"}
|
|
</Button>
|
|
</div>
|
|
</div>
|
|
) : (
|
|
<div className="space-y-5">
|
|
<div className="space-y-2">
|
|
<button
|
|
className="inline-flex items-center gap-1 text-xs text-muted-foreground hover:text-foreground transition-colors"
|
|
onClick={() => setMode("invite")}
|
|
>
|
|
<ArrowLeft className="h-3.5 w-3.5" />
|
|
Back
|
|
</button>
|
|
<div className="space-y-1">
|
|
<div className="flex items-center justify-between gap-3">
|
|
<h2 className="text-sm font-semibold">Agent onboarding prompt</h2>
|
|
{latestAgentPromptCopied ? (
|
|
<div className="inline-flex items-center gap-1 text-xs font-medium text-foreground">
|
|
<Check className="h-3.5 w-3.5" />
|
|
Copied
|
|
</div>
|
|
) : null}
|
|
</div>
|
|
<p className="text-sm text-muted-foreground">
|
|
Send this prompt to the external agent that should join this company.
|
|
</p>
|
|
</div>
|
|
</div>
|
|
|
|
<Textarea
|
|
readOnly
|
|
value={latestAgentPrompt ?? ""}
|
|
className="h-(--sz-24rem) resize-y font-mono text-xs"
|
|
/>
|
|
<Button
|
|
size="sm"
|
|
variant="outline"
|
|
disabled={!latestAgentPrompt}
|
|
onClick={async () => {
|
|
if (!latestAgentPrompt) return;
|
|
const copied = await copyText(latestAgentPrompt, "Copy the agent onboarding prompt manually from the field above.");
|
|
setLatestAgentPromptCopied(copied);
|
|
}}
|
|
>
|
|
{latestAgentPromptCopied ? "Copied prompt" : "Copy prompt"}
|
|
</Button>
|
|
</div>
|
|
)}
|
|
</div>
|
|
</DialogContent>
|
|
</Dialog>
|
|
);
|
|
}
|