mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-11-14 00:26:28 +01:00
## Thinking Path > - Paperclip lets people manage agent work through the board. > - The board reads task, agent, settings, plugin, and run data from the server. > - A deploy can interrupt those reads after content is already visible. > - Local error branches can replace that content with an error or show raw codes. > - This pull request moves the remaining reads to the shared recovery behavior. > - The query-error guard prevents new local error patterns from returning. ## Linked Issues or Issue Description **What happened?** Loaded lists, settings, task panels, and manual reads could clear their content or show errors during a server restart. Some reads also disabled the shared retry policy. **Expected behavior** Keep loaded content during a temporary failure. Show the shared connection banner. Retry reads after recovery. Replace content after a real access denial or missing resource, with readable copy. **Steps to reproduce** Open a task, settings page, or run log. Return 503 with `tenant_app_unavailable` from the API. Restore the API and check that content refreshes. Repeat with 403 and 404 to check the failure state. Related merged work: Refs #15754, Refs #15772, Refs #17960. This change covers remaining reads and enforcement. Browser persistence and the outage browser suite follow separately. ## What Changed - Repair an existing PostgreSQL deadline fixture at UTC boundaries. A daily cap defers a heartbeat until both its original interval and the next UTC day allow it. Keep the counted run in its seeded day and cover noon, just before midnight and the first second after midnight with explicit clocks and real PostgreSQL. Production scheduling is unchanged. - Integrate the saved list, settings, shell, task, and manual-read recovery changes against current master. Preserve the current task, Inbox, and run-log structure. - Add `useResilientFetch` for component-local reads. Preserve loaded data, cancel stale requests, and retry through the shared connectivity policy. Keep browser and pairing capabilities in memory. - Retain run log chunks across stream changes and catch up after recovery without duplicate chunks or stalled requests. - Keep genuine authorization and missing-resource failures visible. Translate known single-word codes such as `forbidden`. Show known skills and disconnected-app failures before sibling loading states. Keep Retry bound to its failed request. - Make the query-error guard enforce by default and run it in the CI policy job. Document the narrow exceptions and the read recovery contract. - Invalidate pending OAuth discovery when the operator leaves setup or its context changes. Keep reserved-popup cleanup bound to the current attempt. ## Verification - Current read head `09d1db29dea` is merge-ready: all 59 check runs are completed (54 successful, three skipped, two neutral), the legacy Snyk status is successful, and both required `ci / verify` and `ci / e2e` gates pass. Greptile Apex reviewed this exact head at 5/5 with no unresolved threads; the branch has no merge conflicts. The current CI run is `41748339602`. - Current read head `09d1db29dea` includes master `683fa4725e9`. The latest change touches only the existing server deadline test fixture. Application source remains the previously verified `86376fa751e` revision: all 60 affected skills/disconnected-app tests and both application UI typechecks passed, along with token gates and the enforcing query-error guard. Those UI suites were not repeated for this test-only repair. - The fixture repair passes all seven deadline integration cases and the complete server typecheck, including the server test layer. The old assertion deterministically fails at 23:59:06.888 UTC; its one-second-old run also fails the first-second-of-day probe. The corrected fixture passes noon and both midnight probes. The permanent three-case coverage uses seeded 2099 clocks. - Twelve new regressions fail against the previous implementation. Both skills variants and disconnected-app pages show either request's 403 or 429 while the sibling pauses or remains fetching. Permission failures stay visible. Retry stays usable for its failed request and recovers independently. An initial test-fixture query-key typo was corrected before the passing run. The finding is replied to and resolved. Greptile reviewed prior application revision `86376fa751e` at 5/5 with no new actionable findings or unresolved threads. The current test-only head has now received its own Apex 5/5 review with no unresolved threads, and its CI is successful as recorded above. - The preceding OAuth fix passed all 237 setup tests on both application branches. Its ten regressions prove that Back, Cancel, unmount, or context changes retire initial discovery without creating a connection, caching old identities, navigating an abandoned popup, or closing a newer attempt. - Earlier master integration `e992f770339` passed all 309 tests across eight affected Slack, recovery, retry, submission and task files, plus UI typecheck, token gates, enforcing query-error scan and seven guard tests. The integration preserves Slack workspace reconnect and shared recovery, readable execution errors, source-inspection company scoping, and current submission behavior. Newly inherited retained-file recovery controls keep cached data through transient failures and hide it after definitive denial. - The preceding cache head `97c0bc3966f` passed 1,038 focused cache/write/editor/account/task/API tests. All 22 built-UI outage/write/loading cases passed in 4.7 minutes on exact browser head `b7deaaee5da`, with strict checking of all three specs. The latest skills/app rendering fix is covered by its affected component suites; those broader cases were not repeated for this separate read path. - Historical broader UI, CLI and build results and unresolved aggregate server/DB/adapter failures remain in the PR discussion. Interrupted CI runs were audited and recorded separately; they are not counted as passes. Controlled local outages do not prove hosted authentication or a real Cloud restart/deploy. Real hosted acceptance remains required after merge and deployment. Commands for the latest fix: ```sh pnpm --filter @paperclipai/ui exec vitest run src/pages/CompanySkills.test.tsx src/pages/apps/AppNotConnected.test.tsx pnpm --filter @paperclipai/ui typecheck pnpm check:token-gates node scripts/check-query-error-rendering.mjs --enforce --summary ``` ## Risks This migration touches many read surfaces. The main risks are initial loading, request cancellation, retained authorization state, and run-log paging. The tests cover those states. There are no server, schema, dependency, or API contract changes. The follow-up browser suite and hosted deploy acceptance are required before release acceptance. Recovered commits retain their original authors. If squash-merging, preserve `Co-Authored-By: Bender (Fable) <bender@agents.paperclip.ing>` and the Paperclip trailer. ## Model Used OpenAI `gpt-6.1-sol` through Codex, with xhigh reasoning effort, tool use, and code execution. The context window size is not exposed. Saved source commits keep their original authorship. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have described the issue in-PR following the bug report template - [x] I have not referenced internal/instance-local Paperclip issues or links - [x] My branch name describes the change and contains no internal ticket id - [x] The affected local tests pass; broader limitations are recorded above - [x] I have added or updated tests where applicable - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented risks above - [x] All Paperclip CI gates are green - [x] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I will address all Greptile and reviewer comments before requesting merge --------- Co-authored-by: devinfoley <139239+devinfoley@users.noreply.github.com> Co-authored-by: Paperclip <noreply@paperclip.ing> Co-authored-by: Bender (Fable) <bender@agents.paperclip.ing> Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
391 lines
16 KiB
TypeScript
391 lines
16 KiB
TypeScript
import { useEffect, useMemo, useRef, useState } from "react";
|
|
import { useInfiniteQuery, useMutation, useQueryClient } from "@tanstack/react-query";
|
|
import { Check, Copy } from "lucide-react";
|
|
import { accessApi } from "@/api/access";
|
|
import { QueryErrorState, useQueryView } from "@/components/QueryView";
|
|
import { Button } from "@/components/ui/button";
|
|
import { useCompany } from "@/context/CompanyContext";
|
|
import { useToast } from "@/context/ToastContext";
|
|
import { Link } from "@/lib/router";
|
|
import { queryKeys } from "@/lib/queryKeys";
|
|
import { copyTextToClipboard } from "@/lib/clipboard";
|
|
import { Badge } from "@/components/ui/badge";
|
|
import { describeError } from "@/api/errors";
|
|
|
|
const inviteRoleOptions = [
|
|
{
|
|
value: "viewer",
|
|
label: "Viewer",
|
|
description: "Can view organization work and follow along.",
|
|
gets: "View-only organization membership.",
|
|
},
|
|
{
|
|
value: "operator",
|
|
label: "Operator",
|
|
description: "Can edit organization work and invite people.",
|
|
gets: "Full editing and audit access. Cannot approve join requests or manage member permissions.",
|
|
},
|
|
{
|
|
value: "admin",
|
|
label: "Admin",
|
|
description: "Recommended for operators who need to invite people, create agents, and approve joins.",
|
|
gets: "Can create agents, invite users, assign tasks, and approve join requests.",
|
|
},
|
|
{
|
|
value: "owner",
|
|
label: "Owner",
|
|
description: "Full organization access, including membership management.",
|
|
gets: "Everything in Admin, plus managing members.",
|
|
},
|
|
] as const;
|
|
|
|
const INVITE_HISTORY_PAGE_SIZE = 5;
|
|
|
|
function isInviteHistoryRow(value: unknown): value is Awaited<ReturnType<typeof accessApi.listInvites>>["invites"][number] {
|
|
if (!value || typeof value !== "object") return false;
|
|
return "id" in value && "state" in value && "createdAt" in value;
|
|
}
|
|
|
|
/** The Invites tab of the Members page (extracted from the former standalone Invites page). */
|
|
export function InvitesSection() {
|
|
const { selectedCompanyId } = useCompany();
|
|
const { pushToast } = useToast();
|
|
const queryClient = useQueryClient();
|
|
const [humanRole, setHumanRole] = useState<"owner" | "admin" | "operator" | "viewer">("operator");
|
|
const [latestInviteUrl, setLatestInviteUrl] = useState<string | null>(null);
|
|
const [latestInviteCopied, setLatestInviteCopied] = useState(false);
|
|
const latestInviteInputRef = useRef<HTMLInputElement | null>(null);
|
|
|
|
useEffect(() => {
|
|
if (!latestInviteCopied) return;
|
|
const timeout = window.setTimeout(() => {
|
|
setLatestInviteCopied(false);
|
|
}, 1600);
|
|
return () => window.clearTimeout(timeout);
|
|
}, [latestInviteCopied]);
|
|
|
|
function selectLatestInviteUrl() {
|
|
latestInviteInputRef.current?.focus();
|
|
latestInviteInputRef.current?.select();
|
|
}
|
|
|
|
async function copyText(text: string, unavailableBody: string, afterFallback?: () => void) {
|
|
try {
|
|
await copyTextToClipboard(text);
|
|
return true;
|
|
} catch {
|
|
afterFallback?.();
|
|
}
|
|
pushToast({
|
|
title: "Clipboard unavailable",
|
|
body: unavailableBody,
|
|
tone: "warn",
|
|
});
|
|
return false;
|
|
}
|
|
|
|
async function copyInviteUrl(url: string) {
|
|
return copyText(url, "The invite URL is selected. Copy it manually from the field.", selectLatestInviteUrl);
|
|
}
|
|
|
|
const inviteHistoryQueryKey = queryKeys.access.invites(selectedCompanyId ?? "", "all", INVITE_HISTORY_PAGE_SIZE);
|
|
const invitesQuery = useInfiniteQuery({
|
|
queryKey: inviteHistoryQueryKey,
|
|
queryFn: ({ pageParam }) =>
|
|
accessApi.listInvites(selectedCompanyId!, {
|
|
limit: INVITE_HISTORY_PAGE_SIZE,
|
|
offset: pageParam,
|
|
}),
|
|
enabled: !!selectedCompanyId,
|
|
initialPageParam: 0,
|
|
getNextPageParam: (lastPage) => lastPage.nextOffset ?? undefined,
|
|
});
|
|
const invitesView = useQueryView(invitesQuery);
|
|
const inviteHistory = useMemo(
|
|
() =>
|
|
invitesQuery.data?.pages.flatMap((page) =>
|
|
Array.isArray(page?.invites) ? page.invites.filter(isInviteHistoryRow) : [],
|
|
) ?? [],
|
|
[invitesQuery.data?.pages],
|
|
);
|
|
|
|
const createInviteMutation = useMutation({
|
|
mutationFn: () =>
|
|
accessApi.createCompanyInvite(selectedCompanyId!, {
|
|
allowedJoinTypes: "human",
|
|
humanRole,
|
|
agentMessage: null,
|
|
}),
|
|
onSuccess: async (invite) => {
|
|
setLatestInviteUrl(invite.inviteUrl);
|
|
setLatestInviteCopied(false);
|
|
const copied = await copyText(invite.inviteUrl, "Copy the invite URL manually from the field below.");
|
|
|
|
await queryClient.invalidateQueries({ queryKey: inviteHistoryQueryKey });
|
|
pushToast({
|
|
title: "Invite created",
|
|
body: copied ? "Invite ready below and copied to clipboard." : "Invite ready below.",
|
|
tone: "success",
|
|
});
|
|
},
|
|
onError: (error) => {
|
|
pushToast({
|
|
title: "Failed to create invite",
|
|
body: describeError(error).body,
|
|
tone: "error",
|
|
});
|
|
},
|
|
});
|
|
|
|
const revokeMutation = useMutation({
|
|
mutationFn: (inviteId: string) => accessApi.revokeInvite(inviteId),
|
|
onSuccess: async () => {
|
|
await queryClient.invalidateQueries({ queryKey: inviteHistoryQueryKey });
|
|
pushToast({ title: "Invite revoked", tone: "success" });
|
|
},
|
|
onError: (error) => {
|
|
pushToast({
|
|
title: "Failed to revoke invite",
|
|
body: describeError(error).body,
|
|
tone: "error",
|
|
});
|
|
},
|
|
});
|
|
|
|
if (!selectedCompanyId) {
|
|
return <div className="text-sm text-muted-foreground">Select an organization to manage invites.</div>;
|
|
}
|
|
|
|
if (invitesQuery.isLoading || invitesView.kind === "reconnecting") {
|
|
return <div className="text-sm text-muted-foreground">Loading invites…</div>;
|
|
}
|
|
|
|
if (invitesView.kind === "error") {
|
|
if (invitesView.errorKind === "forbidden") {
|
|
return <div className="text-sm text-destructive">You do not have permission to manage organization invites.</div>;
|
|
}
|
|
return (
|
|
<QueryErrorState
|
|
size="page"
|
|
error={invitesQuery.error}
|
|
action="load invites"
|
|
onRetry={invitesView.retry}
|
|
retrying={invitesView.isFetching}
|
|
/>
|
|
);
|
|
}
|
|
|
|
return (
|
|
<div className="max-w-6xl space-y-8">
|
|
<p className="max-w-3xl text-sm text-muted-foreground">
|
|
Invite people to request access to this organization. New invite links are copied to your clipboard when they are
|
|
generated.
|
|
</p>
|
|
|
|
<section className="space-y-4 rounded-xl border border-border p-5">
|
|
<div className="space-y-1">
|
|
<h2 className="text-sm font-semibold">Invite a person</h2>
|
|
<p className="text-sm text-muted-foreground">
|
|
Generate a human invite link and choose the default access it should request.
|
|
</p>
|
|
</div>
|
|
|
|
<fieldset className="space-y-3">
|
|
<legend className="text-sm font-medium">Choose a role</legend>
|
|
<div className="rounded-xl border border-border">
|
|
{inviteRoleOptions.map((option, index) => {
|
|
const checked = humanRole === option.value;
|
|
return (
|
|
<label
|
|
key={option.value}
|
|
className={`flex cursor-pointer gap-3 px-4 py-4 ${index > 0 ? "border-t border-border" : ""}`}
|
|
>
|
|
<input
|
|
type="radio"
|
|
name="invite-role"
|
|
value={option.value}
|
|
checked={checked}
|
|
onChange={() => setHumanRole(option.value)}
|
|
className="mt-1 h-4 w-4 border-border text-foreground"
|
|
/>
|
|
<span className="min-w-0 space-y-1">
|
|
<span className="flex flex-wrap items-center gap-2">
|
|
<span className="text-sm font-medium">{option.label}</span>
|
|
{option.value === "operator" ? (
|
|
<Badge variant="outline" className="border-border text-muted-foreground">
|
|
Default
|
|
</Badge>
|
|
) : null}
|
|
</span>
|
|
<span className="block max-w-2xl text-sm text-muted-foreground">{option.description}</span>
|
|
<span className="block text-sm text-foreground">{option.gets}</span>
|
|
</span>
|
|
</label>
|
|
);
|
|
})}
|
|
</div>
|
|
</fieldset>
|
|
|
|
<div className="rounded-lg border border-border px-4 py-3 text-sm text-muted-foreground">
|
|
Each invite link is single-use. Human invitees get the selected role immediately after sign-in; agent invites still create a join request for approval.
|
|
</div>
|
|
|
|
<div className="flex flex-wrap items-center gap-3">
|
|
<Button onClick={() => createInviteMutation.mutate()} disabled={createInviteMutation.isPending}>
|
|
{createInviteMutation.isPending ? "Creating…" : "Create invite"}
|
|
</Button>
|
|
<span className="text-sm text-muted-foreground">Invite history below keeps the audit trail.</span>
|
|
</div>
|
|
|
|
{latestInviteUrl ? (
|
|
<div className="space-y-3 rounded-lg border border-border px-4 py-4">
|
|
<div className="space-y-1">
|
|
<div className="flex items-center justify-between gap-3">
|
|
<div className="text-sm font-medium">Latest invite link</div>
|
|
{latestInviteCopied ? (
|
|
<div className="inline-flex items-center gap-1 text-xs font-medium text-foreground">
|
|
<Check className="h-3.5 w-3.5" />
|
|
Copied
|
|
</div>
|
|
) : null}
|
|
</div>
|
|
<div className="text-sm text-muted-foreground">
|
|
This URL includes the current Paperclip domain returned by the server.
|
|
</div>
|
|
</div>
|
|
<label className="block space-y-1">
|
|
<span className="sr-only">Latest invite URL</span>
|
|
<input
|
|
ref={latestInviteInputRef}
|
|
readOnly
|
|
value={latestInviteUrl}
|
|
onFocus={(event) => event.currentTarget.select()}
|
|
onClick={(event) => event.currentTarget.select()}
|
|
className="w-full rounded-md border border-border bg-muted/60 px-3 py-2 text-sm text-foreground outline-none transition-colors selection:bg-primary selection:text-primary-foreground focus:border-ring"
|
|
aria-label="Latest invite URL"
|
|
/>
|
|
</label>
|
|
<div className="flex flex-wrap gap-2">
|
|
<Button
|
|
type="button"
|
|
size="sm"
|
|
variant="outline"
|
|
onClick={async () => {
|
|
const copied = await copyInviteUrl(latestInviteUrl);
|
|
setLatestInviteCopied(copied);
|
|
}}
|
|
>
|
|
<Copy className="h-4 w-4" />
|
|
Copy link
|
|
</Button>
|
|
</div>
|
|
</div>
|
|
) : null}
|
|
</section>
|
|
|
|
<section className="rounded-xl border border-border">
|
|
<div className="flex flex-wrap items-center justify-between gap-4 px-5 py-4">
|
|
<div className="space-y-1">
|
|
<h2 className="text-sm font-semibold">Invite history</h2>
|
|
<p className="text-sm text-muted-foreground">
|
|
Review invite status, audience, inviter, and any linked join request.
|
|
</p>
|
|
</div>
|
|
<Link to="/inbox/requests" className="text-sm underline underline-offset-4">
|
|
Open join request queue
|
|
</Link>
|
|
</div>
|
|
|
|
{inviteHistory.length === 0 ? (
|
|
<div className="border-t border-border px-5 py-8 text-sm text-muted-foreground">
|
|
No invites have been created for this organization yet.
|
|
</div>
|
|
) : (
|
|
<div className="border-t border-border">
|
|
<div className="overflow-x-auto">
|
|
<table className="min-w-full text-left text-sm">
|
|
<thead>
|
|
<tr className="border-b border-border">
|
|
<th className="px-5 py-3 font-medium text-muted-foreground">State</th>
|
|
<th className="px-5 py-3 font-medium text-muted-foreground">For</th>
|
|
<th className="px-5 py-3 font-medium text-muted-foreground">Invited by</th>
|
|
<th className="px-5 py-3 font-medium text-muted-foreground">Created</th>
|
|
<th className="px-5 py-3 font-medium text-muted-foreground">Join request</th>
|
|
<th className="px-5 py-3 text-right font-medium text-muted-foreground">Action</th>
|
|
</tr>
|
|
</thead>
|
|
<tbody>
|
|
{inviteHistory.map((invite) => (
|
|
<tr key={invite.id} className="border-b border-border last:border-b-0">
|
|
<td className="px-5 py-3 align-top">
|
|
<Badge variant="outline" className="border-border text-muted-foreground">
|
|
{formatInviteState(invite.state)}
|
|
</Badge>
|
|
</td>
|
|
<td className="px-5 py-3 align-top">{formatInviteAudience(invite)}</td>
|
|
<td className="px-5 py-3 align-top">
|
|
<div>{invite.invitedByUser?.name || invite.invitedByUser?.email || "Unknown inviter"}</div>
|
|
{invite.invitedByUser?.email && invite.invitedByUser.name ? (
|
|
<div className="text-xs text-muted-foreground">{invite.invitedByUser.email}</div>
|
|
) : null}
|
|
</td>
|
|
<td className="px-5 py-3 align-top text-muted-foreground">
|
|
{new Date(invite.createdAt).toLocaleString()}
|
|
</td>
|
|
<td className="px-5 py-3 align-top">
|
|
{invite.relatedJoinRequestId ? (
|
|
<Link to="/inbox/requests" className="underline underline-offset-4">
|
|
Review request
|
|
</Link>
|
|
) : (
|
|
<span className="text-muted-foreground">—</span>
|
|
)}
|
|
</td>
|
|
<td className="px-5 py-3 text-right align-top">
|
|
{invite.state === "active" ? (
|
|
<Button
|
|
size="sm"
|
|
variant="outline"
|
|
onClick={() => revokeMutation.mutate(invite.id)}
|
|
disabled={revokeMutation.isPending}
|
|
>
|
|
Revoke
|
|
</Button>
|
|
) : (
|
|
<span className="text-xs text-muted-foreground">Inactive</span>
|
|
)}
|
|
</td>
|
|
</tr>
|
|
))}
|
|
</tbody>
|
|
</table>
|
|
</div>
|
|
{invitesQuery.hasNextPage ? (
|
|
<div className="flex justify-center border-t border-border px-5 py-4">
|
|
<Button
|
|
type="button"
|
|
variant="outline"
|
|
onClick={() => invitesQuery.fetchNextPage()}
|
|
disabled={invitesQuery.isFetchingNextPage}
|
|
>
|
|
{invitesQuery.isFetchingNextPage ? "Loading more…" : "View more"}
|
|
</Button>
|
|
</div>
|
|
) : null}
|
|
</div>
|
|
)}
|
|
</section>
|
|
</div>
|
|
);
|
|
}
|
|
|
|
function formatInviteState(state: "active" | "accepted" | "expired" | "revoked") {
|
|
return state.charAt(0).toUpperCase() + state.slice(1);
|
|
}
|
|
|
|
function formatInviteAudience(invite: Awaited<ReturnType<typeof accessApi.listInvites>>["invites"][number]) {
|
|
if (invite.allowedJoinTypes === "agent") return "Agent";
|
|
if (invite.allowedJoinTypes === "both") return invite.humanRole ? `Human or agent · ${invite.humanRole}` : "Human or agent";
|
|
return invite.humanRole ?? "Human";
|
|
}
|