mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-10-17 01:25:26 +02:00
## Thinking Path > - Paperclip lets people manage AI agents and review their work. > - Task confirmations must use the work produced by their source run. > - The server blocks approval while that run still needs to sync its workspace. > - The card currently enables approval before that check can pass, so an ordinary click produces an error. > - This PR exposes the existing readiness check and shows “Preparing approval…” with acceptance disabled. > - The card refreshes itself and enables approval when the source workspace settles. ## Linked Issues or Issue Description **What happened?** A confirmation appears while its source run is still preparing or syncing its workspace. Its enabled approval button returns a conflict asking the user to retry after syncing. **Steps to reproduce** 1. Run an agent in an isolated workspace. 2. Have it create a confirmation before workspace finalization completes. 3. Click the approval button while the source workspace is still active. **Expected behavior** The card explains that approval is preparing. Acceptance becomes available automatically when the same server check permits it. Reject and revise remain available. Related work: #10770 handles this conflict after a click with retries. #9520 proposes changing the workspace acceptance barrier. This PR preserves that barrier and exposes readiness before the click, including in compact task chat. It preserves the terminal-finalize behavior from #10099. ## What Changed - Add an optional, read-only `acceptanceBlocker` to interaction responses. Readiness uses the existing source-run workspace predicate, with one check per pending source run. - Disable acceptance and show a shared preparation notice in classic and compact confirmation cards, including checkbox and secret-binding confirmations. - Refresh preparing cards every two seconds in task detail, attention, pipelines, and Skill Studio. Restore each surface's previous polling cadence when preparation clears. - Preserve live tool reviews, questions, rejection, revision, and the server acceptance barrier. No automatic acceptance occurs. - Document the preparation state and cover readiness, terminal sync outcomes, unrelated runs, historical cards, and automatic refresh. ## Verification - Focused service, card, query-refresh, and helper tests: 217 passed across five files. - `pnpm -r typecheck`: passed. - `pnpm build`: passed. - `pnpm build-storybook`: passed. - `pnpm check:token-gates`: passed. - `pnpm test:run`: incomplete locally. Stopped after about 17 minutes once it reproduced seven existing environment failures: two Slack tests and two email tests lack ancestor-directory skill fixtures; three company-skills tests fail on macOS runtime-cache staging permissions. These are outside this change. The full CI test matrix passed. - CI: all 53 checks passed; two optional Storybook jobs were skipped. The branch has no conflicts with `master`. - Greptile: 5/5 on commit `8a6f216d8d`, with no review threads. - Reviewed added lines and new files for credentials, private URLs, internal task references, user paths, and run artifacts. None found. ## Risks - No database migration or change to acceptance authorization. Readiness is advisory; the server still enforces its existing gate at acceptance. - An open preparing card adds a read every two seconds. This cadence stops after readiness clears; historical cards add no workspace checks. - Failed or stale finalization retains the existing server behavior. This PR does not change recovery policy. ## Model Used OpenAI GPT-6 through Codex. The exact serving model ID and context-window size are not exposed in this session. Used reasoning, repository inspection, tool execution, and automated tests. No sub-agents. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either (a) linked existing issues with `Fixes: #` / `Closes #` / `Refs #` OR (b) described the issue in-PR following the relevant issue template - [x] I have not referenced internal/instance-local Paperclip issues or links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip` URLs) - [x] My branch name describes the change (e.g. `docs/...`, `fix/...`) and contains no internal Paperclip ticket id or instance-derived details - [x] I have run tests locally and they pass (217 focused tests; full local-suite limitations are recorded above) - [x] I have added or updated tests where applicable - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] All Paperclip CI gates are green - [x] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I will address all Greptile and reviewer comments before requesting merge Co-authored-by: Paperclip <noreply@paperclip.ing>
67 lines
2.7 KiB
TypeScript
67 lines
2.7 KiB
TypeScript
// @vitest-environment jsdom
|
|
|
|
import { act, type ReactNode } from "react";
|
|
import { createRoot } from "react-dom/client";
|
|
import { QueryClient, QueryClientProvider } from "@tanstack/react-query";
|
|
import { afterEach, expect, it, vi } from "vitest";
|
|
import { issuesApi } from "../api/issues";
|
|
import { pendingRequestConfirmationInteraction } from "../fixtures/issueThreadInteractionFixtures";
|
|
import { ThemeProvider } from "../context/ThemeContext";
|
|
import { TooltipProvider } from "./ui/tooltip";
|
|
import { AttentionInteractionResolver } from "./AttentionInteractionResolver";
|
|
|
|
(globalThis as { IS_REACT_ACT_ENVIRONMENT?: boolean }).IS_REACT_ACT_ENVIRONMENT = true;
|
|
|
|
vi.mock("@/lib/router", () => ({
|
|
Link: ({ children }: { children: ReactNode }) => <span>{children}</span>,
|
|
}));
|
|
|
|
vi.mock("../api/issues", () => ({
|
|
issuesApi: { listInteractions: vi.fn(), acceptInteraction: vi.fn() },
|
|
}));
|
|
|
|
afterEach(() => {
|
|
vi.useRealTimers();
|
|
vi.clearAllMocks();
|
|
});
|
|
|
|
it("refreshes a preparing approval automatically, then stops polling without accepting it", async () => {
|
|
vi.useFakeTimers();
|
|
const interaction = pendingRequestConfirmationInteraction;
|
|
vi.mocked(issuesApi.listInteractions)
|
|
.mockResolvedValueOnce([{ ...interaction, acceptanceBlocker: "workspace_sync_pending" }])
|
|
.mockResolvedValue([interaction]);
|
|
const client = new QueryClient({ defaultOptions: { queries: { retry: false } } });
|
|
const container = document.createElement("div");
|
|
document.body.appendChild(container);
|
|
const root = createRoot(container);
|
|
try {
|
|
await act(async () => root.render(
|
|
<QueryClientProvider client={client}>
|
|
<TooltipProvider><ThemeProvider>
|
|
<AttentionInteractionResolver
|
|
companyId={interaction.companyId}
|
|
issueId={interaction.issueId}
|
|
interactionId={interaction.id}
|
|
/>
|
|
</ThemeProvider></TooltipProvider>
|
|
</QueryClientProvider>,
|
|
));
|
|
await act(async () => { await vi.advanceTimersByTimeAsync(1); });
|
|
const approve = () => container.querySelector<HTMLButtonElement>('[data-testid="confirmation-actions"] button')!;
|
|
expect(approve().disabled).toBe(true);
|
|
expect(container.textContent).toContain("Preparing approval…");
|
|
await act(async () => { await vi.advanceTimersByTimeAsync(2_001); });
|
|
expect(issuesApi.listInteractions).toHaveBeenCalledTimes(2);
|
|
expect(approve().disabled).toBe(false);
|
|
expect(container.textContent).not.toContain("Preparing approval…");
|
|
await act(async () => { await vi.advanceTimersByTimeAsync(10_000); });
|
|
expect(issuesApi.listInteractions).toHaveBeenCalledTimes(2);
|
|
expect(issuesApi.acceptInteraction).not.toHaveBeenCalled();
|
|
} finally {
|
|
await act(async () => root.unmount());
|
|
container.remove();
|
|
client.clear();
|
|
}
|
|
});
|