mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-11-17 21:34:48 +01:00
## Thinking Path > - Paperclip runs agents in managed environments. > - An agent can use an explicit environment or the instance default. > - A lifecycle plugin must receive the driver that provisions the agent. > - A managed plugin environment also needs to select the Runner process lifecycle. > - This change gives lifecycle selection and provisioning the same environment lookup. ## Linked Issues or Issue Description **What existing behavior does this improve?** Managed plugin environment provisioning and lifecycle configuration. **Current behavior** Lifecycle calls lack the selected plugin driver. Managed plugin configuration cannot select warm Runner execution. **Proposed behavior** Resolve the environment once per lifecycle operation. Pass the driver key for the plugin that serves it. Parse and persist the managed Runner lifecycle mode. The portable ownership and workspace placement changes are in [#21066](https://github.com/paperclipai/paperclip/pull/21066) and [#20743](https://github.com/paperclipai/paperclip/pull/20743). ## What Changed - Share agent environment resolution between required plugin selection and the lifecycle RPC. - Pass `environmentDriverKey` to the plugin that serves the selected environment. - Allow managed plugin environments to set `warm` or `per_turn` and persist the selected mode. - Advertise `pluginEnvironmentRunnerLifecycleMode` in the release capability manifest so senders can check support before including the field. ## Verification - Built shared types, the plugin SDK, and Runner. Server typecheck and SDK source-pin check passed for the initial layer. - The capability contract test failed before the manifest fix and passed after it. Independent verification passed all 160 tests across managed configuration, plugin environment persistence, lifecycle routing, and environment reconciliation. - Routing coverage includes the instance default, an explicit second driver from the same plugin, and an explicit sandbox. - [Hosted CI](https://github.com/paperclipai/paperclip/actions/runs/43193311862) passed on `f07b192c21`. The first attempt timed out in an unchanged workspace-recovery fixture and then collided with a background recovery action. The exact test and all 44 tests in its suite passed locally; the isolated shard retry passed without code changes. ## Risks - Existing managed configuration can omit the lifecycle mode. Senders must check the target release for `pluginEnvironmentRunnerLifecycleMode` before sending the new field. Publishing this signal does not update external deployment tools. ## Model Used - OpenAI Codex GPT-6 with GPT-6.1 Sol agents for implementation and independent review. ## Checklist - [x] Thinking path and model are included. - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] The issue is described using the enhancement template. - [x] Local checks passed and new behavior has tests. - [x] All Paperclip CI gates are green. - [x] Greptile is 5/5 with no open findings. --------- Co-authored-by: Paperclip <noreply@paperclip.ing>
100 lines
7.0 KiB
TypeScript
100 lines
7.0 KiB
TypeScript
import { and, eq, inArray, sql } from "drizzle-orm";
|
|
import { CANCELLABLE_HEARTBEAT_RUN_STATUSES } from "./heartbeat/recovery.js";
|
|
import { promoteDeferredWorkIntents } from "./work-intent-outbox.js";
|
|
import { agents, companies, environments, heartbeatRuns, plugins, pluginCompanySettings, type Db } from "@paperclipai/db";
|
|
import { instanceSettingsService } from "./instance-settings.js";
|
|
import { pluginHasAgentEnvironments, pluginServesAgentEnvironment } from "./plugin-environment-driver.js";
|
|
import { heartbeatService } from "./heartbeat.js";
|
|
import { listInvalidOrgChainDescendantIds } from "./agent-invokability.js";
|
|
import type { PluginWorkerManager } from "./plugin-worker-manager.js";
|
|
import type { LifecycleDriver } from "../modules/agent-lifecycle/index.js";
|
|
import { agentHarnessVerificationService } from "./agent-harness-verification.js";
|
|
import { agentInstanceSecretService } from "./agent-instance-secrets.js";
|
|
import { AGENT_LIFECYCLE_STOP_REASON, COMPANY_ARCHIVED_STOP_REASON } from "./governance-pause-stop.js";
|
|
|
|
export function createLifecycleDriver(db: Db, manager: PluginWorkerManager): LifecycleDriver {
|
|
const { verify } = agentHarnessVerificationService(db, manager);
|
|
const heartbeat = heartbeatService(db, { pluginWorkerManager: manager });
|
|
|
|
async function resolveAgentEnvironment(agent: { id: string; companyId: string }) {
|
|
const [placement] = await db.select({ environmentId: agents.defaultEnvironmentId }).from(agents)
|
|
.where(and(eq(agents.id, agent.id), eq(agents.companyId, agent.companyId)));
|
|
const environmentId = placement?.environmentId ?? (await instanceSettingsService(db).get()).defaultEnvironmentId;
|
|
const [environment] = environmentId ? await db.select().from(environments).where(eq(environments.id, environmentId)) : [];
|
|
return environment;
|
|
}
|
|
|
|
return {
|
|
async onReady(agent) {
|
|
await db.transaction(tx => promoteDeferredWorkIntents(tx, { companyId: agent.companyId, trigger: "pause_lifted" }));
|
|
await heartbeat.resumeQueuedRunsForAgent(agent.companyId, agent.id);
|
|
},
|
|
async requiredPluginIds(agent) {
|
|
const selected = agent.lifecycleRequiredPluginIds;
|
|
const installed = await db.select().from(plugins).where(inArray(plugins.status, ["ready", "error", "installed", "upgrade_pending"]));
|
|
const disabled = await db.select({ pluginId: pluginCompanySettings.pluginId }).from(pluginCompanySettings)
|
|
.where(and(eq(pluginCompanySettings.companyId, agent.companyId), eq(pluginCompanySettings.enabled, false)));
|
|
const candidates = installed.filter(plugin => !disabled.some(row => row.pluginId === plugin.id) &&
|
|
plugin.manifestJson.agentLifecycle && plugin.manifestJson.capabilities.includes("agents.lifecycle.manage"));
|
|
const environment = await resolveAgentEnvironment(agent);
|
|
if (selected !== null) {
|
|
const added = candidates.filter(plugin => pluginServesAgentEnvironment(plugin, environment) && !selected.includes(plugin.id));
|
|
return [...selected, ...added.map(plugin => plugin.id)];
|
|
}
|
|
return candidates.filter(plugin => !pluginHasAgentEnvironments(plugin) || pluginServesAgentEnvironment(plugin, environment)).map(plugin => plugin.id);
|
|
},
|
|
async runPlugin(agent, pluginId) {
|
|
const [plugin] = await db.select().from(plugins).where(eq(plugins.id, pluginId));
|
|
const [settings] = await db.select().from(pluginCompanySettings).where(and(
|
|
eq(pluginCompanySettings.pluginId, pluginId), eq(pluginCompanySettings.companyId, agent.companyId)));
|
|
if (settings?.enabled === false || !plugin || plugin.status !== "ready" || !plugin.manifestJson.agentLifecycle || !plugin.manifestJson.capabilities.includes("agents.lifecycle.manage")) {
|
|
throw Object.assign(new Error("A required lifecycle plugin is unavailable"), { code: "required_plugin_unavailable" });
|
|
}
|
|
const operationId = agent.lifecycleOperation!.id;
|
|
const secrets = agentInstanceSecretService(db);
|
|
const instanceSecrets = ["preparing", "resuming"].includes(agent.lifecycleState)
|
|
? await secrets.read({ companyId: agent.companyId, agentId: agent.id, pluginId }) : {};
|
|
const environment = await resolveAgentEnvironment(agent);
|
|
const environmentDriverKey = pluginServesAgentEnvironment(plugin, environment) && typeof environment?.config?.driverKey === "string"
|
|
? environment.config.driverKey : undefined;
|
|
const request = { companyId: agent.companyId, agentId: agent.id, operationId, version: agent.lifecycleVersion, phase: agent.lifecycleState,
|
|
...(environmentDriverKey ? { environmentDriverKey } : {}), instanceSecrets };
|
|
const result = await manager.call(plugin.id, "agentLifecycle", request, 30_000);
|
|
if (!result || result.operationId !== operationId || result.version !== agent.lifecycleVersion || !["complete", "pending"].includes(result.status)) {
|
|
throw Object.assign(new Error("Invalid lifecycle result"), { code: "invalid_lifecycle_result" });
|
|
}
|
|
if (result.instanceSecrets !== undefined) await secrets.apply(request, pluginId, result.instanceSecrets, agent.lifecycleOperation?.leaseOwner);
|
|
return result.status;
|
|
},
|
|
async runHost(agent) {
|
|
if (agent.lifecycleState === "verifying") return verify(agent);
|
|
if (["pausing", "terminating", "cleaning_up"].includes(agent.lifecycleState)) {
|
|
const ids = agent.lifecycleState === "pausing" ? [agent.id]
|
|
: [agent.id, ...listInvalidOrgChainDescendantIds(agent.id,
|
|
await db.select().from(agents).where(eq(agents.companyId, agent.companyId)))];
|
|
const reason = agent.lifecycleHolds?.includes("company_archived")
|
|
? COMPANY_ARCHIVED_STOP_REASON : AGENT_LIFECYCLE_STOP_REASON;
|
|
// Record what this pause stopped the runs for, so a budget resume
|
|
// continues only the work its own budget stopped, never a manual pause.
|
|
if (agent.lifecycleState === "pausing") {
|
|
// The cause recorded when the pause started survives a resume that
|
|
// already removed the holds before this Stop ran.
|
|
const cause = agent.lifecycleOperation?.pauseCause;
|
|
const pauseStop = sql`jsonb_build_object('pauseStop', jsonb_build_object(
|
|
'holds', ${JSON.stringify(cause?.holds ?? agent.lifecycleHolds ?? [])}::jsonb,
|
|
'companyPauseReason', ${cause ? sql`${cause.companyPauseReason}::text`
|
|
: sql`(select ${companies.pauseReason} from ${companies} where ${companies.id} = ${agent.companyId})`}))`;
|
|
await db.update(heartbeatRuns).set({
|
|
resultJson: sql`coalesce(${heartbeatRuns.resultJson}, '{}'::jsonb) || ${pauseStop}`,
|
|
}).where(and(eq(heartbeatRuns.companyId, agent.companyId), eq(heartbeatRuns.agentId, agent.id),
|
|
inArray(heartbeatRuns.status, [...CANCELLABLE_HEARTBEAT_RUN_STATUSES]),
|
|
sql`not (coalesce(${heartbeatRuns.resultJson}, '{}'::jsonb) ? 'pauseStop')`));
|
|
}
|
|
if (!await heartbeat.stopInvocationsForAgents(ids, reason,
|
|
{ preservePauseDeferred: agent.lifecycleState === "pausing" })) return "pending";
|
|
}
|
|
return "complete";
|
|
},
|
|
};
|
|
}
|