mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-11-13 15:55:46 +01:00
## Thinking Path > - Paperclip is the open source app people use to manage AI agents for work > - The chat-feature evals measure whether agents complete real chat requests through the product > - The chat catalog eval harness and its repairs live on the `chat-eval/master-candidate` branch, not on master > - Today's work made 139 of 242 chat evals pass in verified single-case live runs. Each product fix landed on master as its own pull request > - The eval-side changes (setups, graders, fault seams, evidence capture) still exist only on the candidate > - This pull request lands the harness on master. Master stays the source of truth for product behavior > - The benefit is one tree: evals run against master commits, and product fixes reach the evals as soon as they merge ## Linked Issues or Issue Description Refs #19441, Refs #19599, Refs #20270, Refs #20334, Refs #20342, Refs #20344, Refs #20354, Refs #20360, Refs #20373, Refs #20382, Refs #20409 **What existing behavior does this improve?** The chat catalog eval harness and the product it evaluates live on a long-running branch outside master. Eval fixes do not reach master, so master-based eval runs use old setups and graders. **Subsystem affected** `tests/runner-e2e` chat catalog harness, plus a small set of product changes that exist only on the candidate. **Proposed change** Land the harness on master. Every product fix from this eval work already merged to master as its own pull request. Conflicts keep master's product behavior. ## What Changed - Most of the diff (808 of 851 files) is under `tests/runner-e2e/`: chat-catalog domains, scenarios, descriptors, the TestOps manifest, private evidence tooling, and their tests. - Graders now check saved state, setup literals and rendered or clicked links. Many keyword and regex checks on free-form replies are removed. Each changed grader has a bumped `oracleVersion` and calibration tests (a valid reply, a reworded valid reply, and broken variants that must fail). - The shared link helper `hasLink` no longer treats a list link (for example `/COM/issues?view=mine`) as a link to every task without a URL key. - Setup fixes build real state through supported product routes: routine history, agent grants through the board grant route, budget holds with a real cap, and a storage-layer archive fault for `inbox-search.archive-partial-failure`. - Browser boundary journeys (sign-in, chat-disabled, onboarding) now write the standard pass evidence files. - Retargeted cases, approved by the maintainer: `agent-chat.chat-disabled` (Conference Room gate), `agents.restore-instructions` (no saved instruction history), `access.manage-membership` (member permission edits stay board-only). - The private evidence trusted files (`manual-private-handoff.ts`, `manual-private-retention.ts`, `manual-private-report-assets.ts`) are byte-identical to master. - Product files outside `tests/` (43 files, +1,328 −49) carry candidate-only changes that master does not yet have. Most are tests. The main code changes are in `request-human-input.ts`, `heartbeat-run-summary.ts`, `native-completion-feedback.ts`, `native-run-finalizer.ts`, `openapi.ts`, `secrets.ts` and `IssueChatLongThreadPerf.tsx`. ## Verification - `pnpm vitest run chat-catalog-domains chat-catalog-contract.test.ts chat-catalog-consistency.test.ts unit-launcher.test.mjs --testTimeout=180000` in `tests/runner-e2e`: 269 files pass, 3,550 tests pass. - `node --test chat-full-catalog-testops-manifest.test.mjs`: 10 pass. - `node tests/runner-e2e/source-sdk-public-inputs.mjs <HEAD> --check`: no change. - `tsc` for `server` and `tests/runner-e2e`: clean. - Live single-case verification: 139 of 242 cases passed on paid runs, and a person read the saved evidence for each. These are single-case runs, not one full-cohort run. ## Risks - Large diff. Most of it is test-only, but the 43 non-test files change product code paths. Review those files first. - Some graders are now less strict on reply wording. A person must read replies for meaning on those cases. - 42 cases need disposable outside accounts (Notion, Slack, GitHub, Daytona and others) and stay blocked. `access.invite-teammate` stays failing until local agent isolation lands, because the runner's durable state keeps a live invite token. - The paid workflow compares the trusted private-evidence files with master. They are unchanged, so this risk is low. ## Model Used Anthropic Claude Opus 5.5 (`claude-opus-5-5`), with tool use and code execution, in Claude Code. Subagents used the same model. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either (a) linked existing issues with `Fixes: #` / `Closes #` / `Refs #` OR (b) described the issue in-PR following the relevant issue template - [x] I have not referenced internal/instance-local Paperclip issues or links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip` URLs) - [x] My branch name describes the change (e.g. `docs/...`, `fix/...`) and contains no internal Paperclip ticket id or instance-derived details - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [ ] All Paperclip CI gates are green - [ ] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I will address all Greptile and reviewer comments before requesting merge 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: Paperclip <noreply@paperclip.ing>
68 lines
5.6 KiB
TypeScript
68 lines
5.6 KiB
TypeScript
import { checks, project, task, sameTask, type Entity } from "./internal-support.js";
|
|
import { runtimeDefinition, observeRuntime, runtimeObservation, type RuntimeObservation } from "./runtime-support.js";
|
|
import { expect } from "@playwright/test";
|
|
import { chatCatalogHumanQuestionPolicies, type ChatCatalogContext } from "../chat-catalog-contract.js";
|
|
import { askUserQuestionsPayloadSchema } from "../../../packages/shared/src/validators/issue.js";
|
|
|
|
interface DependencyTask extends Entity { blockedByIssueIds?: string[]; blockedBy?: Array<{ id: string }> }
|
|
interface DependencyObservation extends RuntimeObservation { dependencyTasks: DependencyTask[]; conversationInteractions?: Entity[] }
|
|
const words = (text: string, literal: string) => new RegExp(`(?<![A-Za-z0-9])${literal.replace(/[.*+?^${}()|[\]\\]/g, "\\$&")}(?![A-Za-z0-9])`, "i").test(text);
|
|
/**
|
|
* A pending question card from this run is a valid way to end the turn on the order decision
|
|
* (the chat's reply is then empty). It must be the lead's own human-resolvable card, offer at
|
|
* least two choices, and name both seeded tasks; the saved dependency sets prove the rejection.
|
|
*/
|
|
function orderDecisionCard(o: DependencyObservation, website: DependencyTask, design: DependencyTask) {
|
|
const runIds = new Set(o.runs.map(run => run.id));
|
|
return (o.conversationInteractions ?? []).some(row => {
|
|
const card = row as Entity & Record<string, unknown>;
|
|
if (card.kind !== "ask_user_questions" || card.status !== "pending" || card.companyId !== o.companyId
|
|
|| card.createdByAgentId !== o.leadId || !runIds.has(card.sourceRunId as string) || !chatCatalogHumanQuestionPolicies(card as { resolverPolicy?: unknown })) return false;
|
|
const parsed = askUserQuestionsPayloadSchema.safeParse(card.payload);
|
|
if (!parsed.success || !parsed.data.questions.some(question => question.options.length >= 2)) return false;
|
|
const text = [card.title, card.summary, ...parsed.data.questions.flatMap(question => [question.prompt, ...question.options.map(option => option.label)])]
|
|
.filter(value => typeof value === "string").join("\n");
|
|
return [website, design].every(row => [row.title, row.identifier].some(name => typeof name === "string" && words(text, name)));
|
|
});
|
|
}
|
|
export function gradeDependencyCycle(value: unknown) {
|
|
const c = checks(); const o = runtimeObservation(value) as DependencyObservation | undefined;
|
|
c.add("complete-dependency-observation", !!o && Array.isArray(o.dependencyTasks), "Both dependency sets are read from their actual persisted detail endpoints.");
|
|
if (!o || !Array.isArray(o.dependencyTasks)) return c.result();
|
|
const website = o.state.task as DependencyTask; const design = o.state.design as DependencyTask;
|
|
const currentWebsite = o.dependencyTasks.find(row => row.id === website.id);
|
|
const currentDesign = o.dependencyTasks.find(row => row.id === design.id);
|
|
const blockers = (row: DependencyTask | undefined) => row?.blockedBy?.map(edge => edge.id) ?? row?.blockedByIssueIds;
|
|
c.add("original-edge-retained-reverse-edge-absent", !!currentWebsite && !!currentDesign
|
|
&& blockers(currentWebsite)?.length === 0 && blockers(currentDesign)?.length === 1 && blockers(currentDesign)?.[0] === website.id,
|
|
"Design still waits for Website; the requested reverse edge is rejected without removing the original prerequisite.");
|
|
c.add("same-company-unchanged-task-records", !!currentWebsite && !!currentDesign && sameTask(website, currentWebsite)
|
|
&& sameTask(design, currentDesign) && [currentWebsite, currentDesign].every(row => row.companyId === o.companyId) && o.tasks.length === 2,
|
|
"Cycle rejection preserves the two task identities, ownership and ordinary properties.");
|
|
const replyDecision = /\bWebsite\b/i.test(o.reply) && /\bDesign\b/i.test(o.reply)
|
|
&& /cycl|circular|already.*depend|deadlock/i.test(o.reply) && /choose|which|instead|remove|order|first/i.test(o.reply);
|
|
c.add("explains-actual-conflict-and-next-decision", replyDecision || orderDecisionCard(o, website, design),
|
|
"The response explains the named dependency conflict and an actionable order decision, in the reply or in this run's pending question card.");
|
|
|
|
return c.result();
|
|
}
|
|
async function observeDependencies(ctx: ChatCatalogContext, state: Record<string, unknown>): Promise<DependencyObservation> {
|
|
const o = await observeRuntime(ctx, state);
|
|
const dependencyTasks = await Promise.all([state.task as Entity, state.design as Entity].map(row => ctx.input.api.get<DependencyTask>(`/api/issues/${row.id}`)));
|
|
const source = ctx.issue();
|
|
const conversationInteractions = source ? await ctx.input.api.get<Entity[]>(`/api/issues/${source.id}/interactions`) : [];
|
|
return { ...o, dependencyTasks, conversationInteractions };
|
|
}
|
|
export const runtimeTaskCoordinationCases = [runtimeDefinition("task-coordination.reject-dependency-cycle", async ctx => {
|
|
const p = await project(ctx); const website = await task(ctx, "Website", p.id);
|
|
const design = await task(ctx, "Design", p.id, { blockedByIssueIds: [website.id] });
|
|
return { project: p, task: website, design };
|
|
}, gradeDependencyCycle, { oracleVersion: "paperclip.chat-catalog.runtime.v3", observe: observeDependencies, async verifyResult(ctx, state) {
|
|
const source = ctx.input.page.url();
|
|
for (const row of [state.task as Entity, state.design as Entity]) {
|
|
await ctx.input.page.goto(`/${ctx.input.fixtures.company.issuePrefix}/issues/${row.identifier ?? row.id}`, { waitUntil: "domcontentloaded" });
|
|
await expect(ctx.input.page.getByRole("heading", { name: row.title!, exact: true }).first()).toBeVisible();
|
|
}
|
|
await ctx.input.page.goto(source, { waitUntil: "domcontentloaded" });
|
|
} })];
|