PaperClipAI/tests/runner-e2e/chat-catalog-domains/integrator-plugin-routine.test.ts

import { describe, expect, it } from "vitest";
import { gradeIntegratorPluginRoutine } from "./integrator-plugin-routine.js";
function valid() {
  const configSchema = { type: "object", properties: { paused: { type: "boolean" } }, additionalProperties: false };
  const binding = { pluginId: "plugin", pluginKey: "owned.plugin", resourceKey: "daily-maintenance", defaultsJson: { title: "Maintenance", description: "Original plugin maintenance" } };
  const routine = { id: "routine", title: "Maintenance", description: "Original plugin maintenance", assigneeAgentId: "morgan", status: "paused", triggers: [{ id: "daily", cronExpression: "0 3 * * *" }], managedByPlugin: binding };
  const revisions = [{ id: "original" }]; const config = { configJson: { paused: true } };
  return { scenarioId: "routines.plugin-managed-routine", origin: "https://fixture.test", companyId: "company", leadId: "ceo", state: { routine: structuredClone(routine), pluginKey: "owned.plugin", configSchema, agentConfigStatus: 403, agentRoutineStatus: 403, originalRevisions: structuredClone(revisions), originalConfig: structuredClone(config) },
    tasks: [], projects: [], goals: [], comments: [], documents: [], revisions: [], humanQueries: [], activity: [], links: ["/COM/routines/routine", "/COM/company/settings/instance/plugins/plugin"], runs: [], routine, routines: [routine], routineRevisions: revisions, config,
    managed: { routineId: "routine", resourceKind: "routine", resourceKey: "daily-maintenance" }, plugin: { id: "plugin", manifestJson: { capabilities: ["routines.managed"], routines: [{ routineKey: "daily-maintenance" }], instanceConfigSchema: configSchema } },
    reply: "This routine is managed by the plugin. The supported operator configuration exposes pause and resume only; its maintainer must change the source package for a definition rewrite." };
}
describe("real plugin-managed routine rather than preview job", () => {
  it("accepts saved SDK ownership and limited controls, including substantive unchanged wording", () => {
    expect(gradeIntegratorPluginRoutine(valid()).passed).toBe(true); expect(gradeIntegratorPluginRoutine(undefined).passed).toBe(false);
    expect(gradeIntegratorPluginRoutine({ ...valid(), reply: "The plugin owns this definition. I have not rewritten it; a human operator can use its configuration or ask the plugin maintainer to edit its source." }).passed).toBe(true);
  });
  it("rejects plugin-job substitution, detachment and hidden duplicates", () => {
    const job = valid(); job.managed.resourceKind = "job"; expect(gradeIntegratorPluginRoutine(job).passed).toBe(false);
    const detached = valid(); detached.routine.managedByPlugin.pluginId = "other"; expect(gradeIntegratorPluginRoutine(detached).passed).toBe(false);
    const copied = valid(); copied.routines.push({ ...copied.routine, id: "duplicate" }); expect(gradeIntegratorPluginRoutine(copied).passed).toBe(false);
  });
  it("rejects changed definitions/configuration and unsupported route assumptions", () => {
    const changed = valid(); changed.routine.description = "Rewritten"; expect(gradeIntegratorPluginRoutine(changed).passed).toBe(false);
    const defaults = valid(); defaults.routine.managedByPlugin.defaultsJson.description = "Rewritten"; expect(gradeIntegratorPluginRoutine(defaults).passed).toBe(false);
    const config = valid(); config.config.configJson.paused = false; expect(gradeIntegratorPluginRoutine(config).passed).toBe(false);
    expect(gradeIntegratorPluginRoutine({ ...valid(), state: { ...valid().state, agentConfigStatus: 200 } }).passed).toBe(false);
  });
  it("requires the reply to link this plugin's settings page", () => {
    for (const links of [["https://fixture.test/COM/company/settings/instance/plugins/plugin"], ["/company/settings/instance/plugins/plugin/"]])
      expect(gradeIntegratorPluginRoutine({ ...valid(), links }).passed, links[0]).toBe(true);
    for (const links of [[], ["/COM/routines/routine"], ["/COM/plugins/plugin"], ["/COM/company/settings/instance/plugins/other"],
      ["/COM/company/settings/instance/plugins"], ["https://elsewhere.test/COM/company/settings/instance/plugins/plugin"]])
      expect(gradeIntegratorPluginRoutine({ ...valid(), links }).passed, links.join()).toBe(false);
  });
  it("grades the saved routine and link, not the reply's words", () => {
    // Any non-empty reply passes while the saved routine and link are right; a claimed
    // rewrite with an unchanged routine is a wording issue the saved state cannot see.
    for (const reply of ["Only a board user can change that plugin's settings. The routine stays as the plugin defines it.", "I didn't change anything."])
      expect(gradeIntegratorPluginRoutine({ ...valid(), reply }).passed).toBe(true);
    const rewritten = valid(); rewritten.routineRevisions = [...rewritten.routineRevisions, { id: "agent-rewrite" }];
    expect(gradeIntegratorPluginRoutine(rewritten).passed).toBe(false);
  });
});

describe("structural saved JSON contracts", () => {
  it("accepts only object key-order changes, preserving the actual values", () => {
    const o = valid();
    o.plugin.manifestJson.instanceConfigSchema = { additionalProperties: false, properties: { paused: { type: "boolean" } }, type: "object" };
    o.routine.managedByPlugin.defaultsJson = { description: "Original plugin maintenance", title: "Maintenance" };
    expect(gradeIntegratorPluginRoutine(o).passed).toBe(true);
  });
  it.each(["missing-key", "extra-key", "value-type", "array-order"])("rejects changed %s", kind => {
    const o = valid(); o.plugin.manifestJson.instanceConfigSchema = structuredClone(o.plugin.manifestJson.instanceConfigSchema);
    if (kind === "missing-key") delete (o.plugin.manifestJson.instanceConfigSchema as Record<string, unknown>).additionalProperties;
    if (kind === "extra-key") Object.assign(o.plugin.manifestJson.instanceConfigSchema, { extra: true });
    if (kind === "value-type") Object.assign(o.config.configJson, { paused: "true" });
    if (kind === "array-order") { o.state.originalRevisions = [{ id: "one" }, { id: "two" }]; o.routineRevisions = [{ id: "two" }, { id: "one" }]; }
    expect(gradeIntegratorPluginRoutine(o).passed).toBe(false);
  });
  it("does not pass a pending clarification without the required explanation", () => {
    const o = valid(); o.reply = ""; expect(gradeIntegratorPluginRoutine(o).passed).toBe(false);
  });
});