mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-10-13 23:39:21 +02:00
## Thinking Path
> - Paperclip is the open source app people use to manage AI agents for
work
> - Much of the work means moving an opaque value somewhere else: an
agent id, a callback URL, a webhook secret, an error payload for a bug
report
> - Copy buttons all over the app do that, and most already say whether
it worked — an icon that flips to a check, a label that reads "Copied"
> - Eleven did not. They passed the promise to `.catch(() => {})` and
showed nothing at all
> - A copy that says nothing looks exactly like a copy the browser
refused, and the only way to tell is to paste somewhere and look
> - The clipboard really does refuse: over plain HTTP on a non-secure
host the async Clipboard API is unavailable, and the fallback can still
fail
> - This pull request gives every copy action an affordance, through two
shared hooks
> - The benefit is that a person can tell a copy from a failure without
leaving the page
## Linked Issues or Issue Description
**What happened?**
Eleven copy buttons gave no feedback. They called `copyTextToClipboard`
and discarded the result:
```
onClick={() => void copyTextToClipboard(robotEmail).catch(() => {})}
```
Nothing changes on screen, whether the write succeeded or failed. This
is the same surface where most other copy buttons do show a check or a
"Copied" label, so the silent ones read as broken.
**Expected behavior**
Every copy action says whether the clipboard took the value. A rejected
write says so rather than staying silent or claiming success.
**Steps to reproduce**
1. Open the connector setup flow for an app that shows a sharing email
or a callback URL.
2. Press **Copy** next to that value.
3. Before this change nothing on screen changes. Compare with the copy
button on a login panel, which flips to a check.
4. To see the failure case, open Paperclip over plain HTTP on a
non-localhost host, where the async Clipboard API is not available.
**Paperclip version or commit**
`45586170e` on `master`.
**Deployment mode**
Local.
**Agent adapter(s) involved**
Not adapter-specific (core bug).
**Additional context**
Commit `1fa36be35` moved every copy through `lib/clipboard.ts`, so the
call sites are findable. Of 62 call sites, 51 already showed feedback
and 11 did not.
## What Changed
- New `ui/src/lib/use-copy-action.ts` with two hooks:
- `useCopyAction` for a control that stays on screen. It returns
`copied` and `failed` for the inline swap the rest of the app already
uses, and resets itself.
- `useCopyToast` for a menu item, which unmounts with its menu before an
inline state could be read, so its confirmation goes to the toast
viewport.
- Both wait for the write to resolve before reporting success, and both
report a rejection as a failure. `AdapterLoginChrome.test.tsx` already
held that line for one button; the helper now makes it the default.
- The eleven silent sites now use one of the two: the connector setup
flow's sharing-email and callback-URL buttons, the runner inspector's
copy-value and copy-path buttons, the agent bubble and skill studio menu
items, annotation "Copy link" on both its hosts, both secret-error
detail buttons, the chat webhook secret, and the motion tweak panel's
export box.
- The chat webhook secret follows its own file's convention: a label
that reads "Webhook secret copied", matching the manifest buttons beside
it.
- The 51 sites that already had feedback are untouched. Converting them
would be a large diff with no visible change.
- `clipboard-usage.test.ts` gains a static check, sibling to the one
that already keeps copies on the shared helper. It fails if a new copy
site ships with no affordance.
## Verification
- `npx vitest run ui/src/lib/use-copy-action.test.tsx
ui/src/lib/clipboard-usage.test.ts ui/src/lib/clipboard.test.ts
ui/src/components/AdapterLoginChrome.test.tsx` — 18 tests pass.
- The new hook tests cover the three cases that matter: no confirmation
while the write is still in flight, a failure state on a rejected write,
and a return to rest after the reset delay. The toast hook is covered
for both tones.
- `npx vitest run ui/src/pages/apps/AppsConnect.test.tsx
ui/src/components/task-chat ui/src/components/RunnerInspector.test.tsx
ui/src/components/DocumentAnnotation` — the suites over the touched
components pass.
- `npx tsc -b ui` — clean.
## Risks
Low. Each change is additive at its own call site and the copy path
itself is unchanged. The static check is the only part that touches
future contributors: it is one assertion, and its pattern list is easy
to extend or drop.
## Model Used
Claude Opus 5 (`claude-opus-5`), 1M context, extended thinking, with
tool use and code execution.
## Checklist
- [x] I have included a thinking path that traces from project context
to this change
- [x] I have specified the model used (with version and capability
details)
- [x] I have checked ROADMAP.md and confirmed this PR does not duplicate
planned core work
- [x] I have searched GitHub for duplicate or related PRs and linked
them above
- [x] I have either (a) linked existing issues with `Fixes: #` / `Closes
#` / `Refs #` OR (b) described the issue in-PR following the relevant
issue template
- [x] I have not referenced internal/instance-local Paperclip issues or
links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip`
URLs)
- [x] My branch name describes the change (e.g. `docs/...`, `fix/...`)
and contains no internal Paperclip ticket id or instance-derived details
- [x] I have run tests locally and they pass
- [x] I have added or updated tests where applicable
- [x] I have updated relevant documentation to reflect my changes
- [x] I have considered and documented any risks above
- [ ] All Paperclip CI gates are green
- [ ] Greptile is 5/5 with no open P2s, recommendations, or follow-ups
- [ ] I will address all Greptile and reviewer comments before
requesting merge
---------
Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
156 lines
6.8 KiB
TypeScript
156 lines
6.8 KiB
TypeScript
import { useEffect, useMemo, useRef, useState } from "react";
|
|
import type { Agent, DocumentAnnotationThreadWithComments } from "@paperclipai/shared";
|
|
import { Button } from "@/components/ui/button";
|
|
import { Textarea } from "@/components/ui/textarea";
|
|
import type { DocumentAnnotationTarget } from "@/api/document-annotations";
|
|
import type { CompanyUserProfile } from "@/lib/company-members";
|
|
import { useDocumentAnnotationMutations } from "@/hooks/useDocumentAnnotationMutations";
|
|
import type { AnnotationAnchorRect, PendingAnchor } from "./DocumentAnnotationLayer";
|
|
import { useCopyAnnotationLink, ThreadCard, truncate } from "./DocumentAnnotationPanel";
|
|
|
|
export interface DocumentAnnotationPopoverProps {
|
|
anchorRect: AnnotationAnchorRect;
|
|
containerRef: React.RefObject<HTMLElement | null>;
|
|
target: DocumentAnnotationTarget;
|
|
documentKey: string;
|
|
baseRevisionId: string | null;
|
|
baseRevisionNumber: number;
|
|
pendingAnchor: PendingAnchor | null;
|
|
thread: DocumentAnnotationThreadWithComments | null;
|
|
focusedCommentId: string | null;
|
|
onFocusThread: (threadId: string | null) => void;
|
|
onClose: () => void;
|
|
onThreadCreated: (thread: DocumentAnnotationThreadWithComments) => void;
|
|
newCommentDisabled?: boolean;
|
|
agentMap?: ReadonlyMap<string, Pick<Agent, "id" | "name"> & Partial<Pick<Agent, "icon">>>;
|
|
userProfileMap?: ReadonlyMap<string, CompanyUserProfile>;
|
|
}
|
|
|
|
export function DocumentAnnotationPopover(props: DocumentAnnotationPopoverProps) {
|
|
const copyAnnotationLink = useCopyAnnotationLink();
|
|
const cardRef = useRef<HTMLDivElement | null>(null);
|
|
const composerRef = useRef<HTMLTextAreaElement | null>(null);
|
|
const [composer, setComposer] = useState("");
|
|
const [reply, setReply] = useState("");
|
|
const target = useMemo(() => props.target, [props.target]);
|
|
const { createThread, addReply, updateStatus, mutationError } = useDocumentAnnotationMutations({
|
|
target,
|
|
baseRevisionId: props.baseRevisionId,
|
|
baseRevisionNumber: props.baseRevisionNumber,
|
|
pendingAnchor: props.pendingAnchor,
|
|
onFocusThread: props.onFocusThread,
|
|
onThreadCreated: props.onThreadCreated,
|
|
onReplyAdded: () => setReply(""),
|
|
});
|
|
|
|
useEffect(() => composerRef.current?.focus(), [props.pendingAnchor]);
|
|
useEffect(() => {
|
|
const dismiss = (event: PointerEvent) => {
|
|
if (!cardRef.current?.contains(event.target as Node)) props.onClose();
|
|
};
|
|
const escape = (event: KeyboardEvent) => {
|
|
if (event.key === "Escape") {
|
|
event.preventDefault();
|
|
props.onClose();
|
|
}
|
|
};
|
|
document.addEventListener("pointerdown", dismiss);
|
|
document.addEventListener("keydown", escape);
|
|
return () => {
|
|
document.removeEventListener("pointerdown", dismiss);
|
|
document.removeEventListener("keydown", escape);
|
|
};
|
|
}, [props.onClose]);
|
|
|
|
const cardHeight = cardRef.current?.offsetHeight ?? 260;
|
|
const containerHeight = visibleBottomWithinContainer(props.containerRef.current);
|
|
const below = props.anchorRect.top + props.anchorRect.height + 6;
|
|
const top = below + cardHeight <= containerHeight
|
|
? below
|
|
: Math.max(0, props.anchorRect.top - cardHeight - 6);
|
|
const containerWidth = props.containerRef.current?.clientWidth ?? 320;
|
|
const left = Math.max(0, Math.min(props.anchorRect.left, containerWidth - 320));
|
|
const submitComposer = () => {
|
|
const body = composer.trim();
|
|
if (body && !createThread.isPending && props.baseRevisionId) createThread.mutate(body);
|
|
};
|
|
|
|
return (
|
|
<div
|
|
ref={cardRef}
|
|
role="dialog"
|
|
aria-label={props.pendingAnchor ? "Add annotation comment" : "Annotation thread"}
|
|
data-testid="document-annotation-popover"
|
|
className="absolute z-(--z-20) w-80 max-w-full rounded-lg border border-border bg-popover text-popover-foreground shadow-xl"
|
|
style={{ top, left }}
|
|
>
|
|
{mutationError ? <p className="border-b border-border bg-destructive/10 px-3 py-2 text-xs text-destructive">{mutationError}</p> : null}
|
|
{props.pendingAnchor ? (
|
|
<div className="p-3">
|
|
<blockquote className="mb-2 line-clamp-2 rounded-md bg-muted px-2 py-1 text-xs italic text-muted-foreground">
|
|
{truncate(props.pendingAnchor.selectedText, 120)}
|
|
</blockquote>
|
|
<Textarea
|
|
ref={composerRef}
|
|
data-testid="document-annotation-popover-composer"
|
|
rows={3}
|
|
value={composer}
|
|
onChange={(event) => setComposer(event.target.value)}
|
|
onKeyDown={(event) => {
|
|
if (event.key === "Enter" && (event.metaKey || event.ctrlKey)) {
|
|
event.preventDefault();
|
|
submitComposer();
|
|
}
|
|
}}
|
|
placeholder="Write a comment…"
|
|
disabled={props.newCommentDisabled || createThread.isPending}
|
|
className="resize-y text-sm"
|
|
/>
|
|
<div className="mt-2 flex justify-end gap-2">
|
|
<Button type="button" size="sm" variant="ghost" onClick={props.onClose}>Cancel</Button>
|
|
<Button type="button" size="sm" disabled={!composer.trim() || createThread.isPending || props.newCommentDisabled || !props.baseRevisionId} onClick={submitComposer}>
|
|
{createThread.isPending ? "Posting…" : "Comment"}
|
|
</Button>
|
|
</div>
|
|
</div>
|
|
) : props.thread ? (
|
|
<ul className="p-2">
|
|
<ThreadCard
|
|
thread={props.thread}
|
|
expanded
|
|
focusedCommentId={props.focusedCommentId}
|
|
onFocus={() => props.onFocusThread(props.thread!.id)}
|
|
replyDraft={reply}
|
|
onReplyChange={setReply}
|
|
onSubmitReply={() => {
|
|
const body = reply.trim();
|
|
if (body) addReply.mutate({ threadId: props.thread!.id, body });
|
|
}}
|
|
onResolveToggle={() => updateStatus.mutate({ threadId: props.thread!.id, status: props.thread!.status === "resolved" ? "open" : "resolved" })}
|
|
onCopyLink={() => copyAnnotationLink(props.documentKey, props.thread!.id)}
|
|
pendingReply={addReply.isPending}
|
|
pendingStatus={updateStatus.isPending}
|
|
agentMap={props.agentMap}
|
|
userProfileMap={props.userProfileMap}
|
|
/>
|
|
</ul>
|
|
) : null}
|
|
</div>
|
|
);
|
|
}
|
|
|
|
function visibleBottomWithinContainer(container: HTMLElement | null): number {
|
|
if (!container || typeof window === "undefined") return Number.POSITIVE_INFINITY;
|
|
const containerRect = container.getBoundingClientRect();
|
|
let visibleBottom = window.innerHeight;
|
|
let parent = container.parentElement;
|
|
while (parent) {
|
|
const style = window.getComputedStyle(parent);
|
|
if ([style.overflow, style.overflowY].some((value) => value === "auto" || value === "scroll" || value === "hidden" || value === "clip")) {
|
|
visibleBottom = Math.min(visibleBottom, parent.getBoundingClientRect().bottom);
|
|
}
|
|
parent = parent.parentElement;
|
|
}
|
|
return visibleBottom - containerRect.top;
|
|
}
|